package com.atlassian.plugin.manager;
   
   import java.io.FileInputStream;
   import java.io.IOException;
   import java.io.InputStream;
   import java.util.ArrayDeque;
   import java.util.ArrayList;
   import java.util.Collection;
   import java.util.Collections;
  import java.util.HashMap;
  import java.util.HashSet;
  import java.util.LinkedHashMap;
  import java.util.LinkedList;
  import java.util.List;
  import java.util.Map;
  import java.util.Properties;
  import java.util.Set;
  import java.util.TreeSet;
  
  import javax.annotation.Nullable;
  
  import com.atlassian.annotations.ExperimentalApi;
  import com.atlassian.annotations.Internal;
  import com.atlassian.plugin.ModuleCompleteKey;
  import com.atlassian.plugin.ModuleDescriptor;
  import com.atlassian.plugin.ModuleDescriptorFactory;
  import com.atlassian.plugin.Plugin;
  import com.atlassian.plugin.PluginAccessor;
  import com.atlassian.plugin.PluginArtifact;
  import com.atlassian.plugin.PluginController;
  import com.atlassian.plugin.PluginException;
  import com.atlassian.plugin.PluginInformation;
  import com.atlassian.plugin.PluginInstaller;
  import com.atlassian.plugin.PluginParseException;
  import com.atlassian.plugin.PluginRestartState;
  import com.atlassian.plugin.PluginState;
  import com.atlassian.plugin.RevertablePluginInstaller;
  import com.atlassian.plugin.SplitStartupPluginSystemLifecycle;
  import com.atlassian.plugin.StateAware;
  import com.atlassian.plugin.classloader.PluginsClassLoader;
  import com.atlassian.plugin.descriptors.CannotDisable;
  import com.atlassian.plugin.descriptors.UnloadableModuleDescriptor;
  import com.atlassian.plugin.descriptors.UnloadableModuleDescriptorFactory;
  import com.atlassian.plugin.event.NotificationException;
  import com.atlassian.plugin.event.PluginEventListener;
  import com.atlassian.plugin.event.PluginEventManager;
  import com.atlassian.plugin.event.events.BeforePluginDisabledEvent;
  import com.atlassian.plugin.event.events.BeforePluginModuleDisabledEvent;
  import com.atlassian.plugin.event.events.PluginContainerUnavailableEvent;
  import com.atlassian.plugin.event.events.PluginDisabledEvent;
  import com.atlassian.plugin.event.events.PluginEnabledEvent;
  import com.atlassian.plugin.event.events.PluginFrameworkDelayedEvent;
  import com.atlassian.plugin.event.events.PluginFrameworkResumingEvent;
  import com.atlassian.plugin.event.events.PluginFrameworkShutdownEvent;
  import com.atlassian.plugin.event.events.PluginFrameworkShuttingDownEvent;
  import com.atlassian.plugin.event.events.PluginFrameworkStartedEvent;
  import com.atlassian.plugin.event.events.PluginFrameworkStartingEvent;
  import com.atlassian.plugin.event.events.PluginFrameworkWarmRestartedEvent;
  import com.atlassian.plugin.event.events.PluginFrameworkWarmRestartingEvent;
  import com.atlassian.plugin.event.events.PluginModuleAvailableEvent;
  import com.atlassian.plugin.event.events.PluginModuleDisabledEvent;
  import com.atlassian.plugin.event.events.PluginModuleEnabledEvent;
  import com.atlassian.plugin.event.events.PluginModuleUnavailableEvent;
  import com.atlassian.plugin.event.events.PluginRefreshedEvent;
  import com.atlassian.plugin.event.events.PluginUninstalledEvent;
  import com.atlassian.plugin.event.events.PluginUpgradedEvent;
  import com.atlassian.plugin.exception.NoOpPluginExceptionInterception;
  import com.atlassian.plugin.exception.PluginExceptionInterception;
  import com.atlassian.plugin.impl.UnloadablePlugin;
  import com.atlassian.plugin.impl.UnloadablePluginFactory;
  import com.atlassian.plugin.loaders.DiscardablePluginLoader;
  import com.atlassian.plugin.loaders.DynamicPluginLoader;
  import com.atlassian.plugin.loaders.PermissionCheckingPluginLoader;
  import com.atlassian.plugin.loaders.PluginLoader;
  import com.atlassian.plugin.manager.PluginPersistentState.Builder;
  import com.atlassian.plugin.metadata.ClasspathFilePluginMetadata;
  import com.atlassian.plugin.metadata.DefaultRequiredPluginValidator;
  import com.atlassian.plugin.metadata.RequiredPluginValidator;
  import com.atlassian.plugin.parsers.DescriptorParserFactory;
  import com.atlassian.plugin.predicate.EnabledModulePredicate;
  import com.atlassian.plugin.predicate.EnabledPluginPredicate;
  import com.atlassian.plugin.predicate.ModuleDescriptorOfClassPredicate;
  import com.atlassian.plugin.predicate.ModuleDescriptorOfTypePredicate;
  import com.atlassian.plugin.predicate.ModuleDescriptorPredicate;
  import com.atlassian.plugin.predicate.ModuleOfClassPredicate;
  import com.atlassian.plugin.predicate.PluginPredicate;
  import com.atlassian.plugin.util.PluginUtils;
  import com.atlassian.util.concurrent.CopyOnWriteMap;
  
  import com.google.common.annotations.VisibleForTesting;
  import com.google.common.base.Function;
  import com.google.common.base.Predicate;
  import com.google.common.base.Predicates;
  import com.google.common.collect.ArrayListMultimap;
  import com.google.common.collect.Iterables;
  import com.google.common.collect.Lists;
  import com.google.common.collect.Maps;
  import com.google.common.collect.Multimap;
  import com.google.common.collect.Ordering;
 import com.google.common.collect.Sets;
 import com.google.common.collect.TreeMultimap;
 
 import org.apache.commons.lang.time.StopWatch;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
 import static com.atlassian.plugin.util.Assertions.notNull;
 import static com.atlassian.plugin.util.EnumUtils.enumValueFromProperty;
 import static com.atlassian.plugin.util.collect.Transforms.toPluginKeys;
 import static com.google.common.base.Preconditions.checkState;
 import static com.google.common.collect.ImmutableList.copyOf;
 import static com.google.common.collect.Iterables.concat;
 import static com.google.common.collect.Iterables.filter;
 import static com.google.common.collect.Iterables.transform;
 import static com.google.common.collect.Iterables.tryFind;
 import static com.google.common.collect.Maps.filterKeys;
 
 /**
  * This implementation delegates the initiation and classloading of plugins to a
  * list of {@link com.atlassian.plugin.loaders.PluginLoader}s and records the
  * state of plugins in a
  * {@link com.atlassian.plugin.manager.PluginPersistentStateStore}.
  * <p/>
  * This class is responsible for enabling and disabling plugins and plugin
  * modules and reflecting these state changes in the PluginPersistentStateStore.
  * <p/>
  * An interesting quirk in the design is that
  * {@link #installPlugin(com.atlassian.plugin.PluginArtifact)} explicitly stores
  * the plugin via a {@link com.atlassian.plugin.PluginInstaller}, whereas
  * {@link #uninstall(Plugin)} relies on the underlying
  * {@link com.atlassian.plugin.loaders.PluginLoader} to remove the plugin if
  * necessary.
  */
 public class DefaultPluginManager implements PluginController, PluginAccessor, SplitStartupPluginSystemLifecycle
 {
     private static final Logger log = LoggerFactory.getLogger(DefaultPluginManager.class);
 
     @Internal
     public enum PluginSortMode
     {
         SORTED,
         LEGACY,
         SHUFFLE;
 
         private static final String PROPERTY_NAME = DefaultPluginManager.class.getName() + ".pluginSortMode";
 
         static PluginSortMode current()
         {
             return enumValueFromProperty(PROPERTY_NAME, PluginSortMode.values(), PluginSortMode.SORTED);
         }
     }
 
     @Internal
     public static String getPluginSortModeProperty()
     {
         return PluginSortMode.PROPERTY_NAME;
     }
 
     @Internal
     public static String getStartupOverrideFileProperty()
     {
         return DefaultPluginManager.class.getName() + ".startupOverrideFile";
     }
 
     @Internal
     public static String getLateStartupEnableRetryProperty()
     {
         return DefaultPluginManager.class.getName() + ".lateStartupEnableRetry";
     }
 
     private final List<DiscardablePluginLoader> pluginLoaders;
     private final PluginPersistentStateStore store;
     private final ModuleDescriptorFactory moduleDescriptorFactory;
     private final PluginEventManager pluginEventManager;
 
     private final Map<String, Plugin> plugins;
     private final PluginsClassLoader classLoader;
     private final PluginEnabler pluginEnabler;
     private final StateTracker tracker;
 
     private final boolean verifyRequiredPlugins;
 
     /**
      * Predicate for identify plugins which are not loaded at initialization.
      *
      * This can be used to support two-phase "tenant aware" startup.
      */
     private final PluginPredicate delayLoadOf;
 
     /**
      * Installer used for storing plugins. Used by
      * {@link #installPlugin(PluginArtifact)}.
      */
     private RevertablePluginInstaller pluginInstaller;
 
     /**
      * Stores {@link Plugin}s as a key and {@link PluginLoader} as a value.
      */
     private final Map<Plugin, PluginLoader> installedPluginsToPluginLoader;
 
     /**
      * A map to pass information from {@link #earlyStartup} to {@link #addPlugins} without an API change.
      * <p/>
      * This map allows earlyStartup to specify a plugin-specific loader for the list of plugins provided to addPlugins. It is only
      * valid when addPlugins is called from earlyStartup or lateStartup. Products may override addPlugins (to add clustering
      * behaviour for example), so fixing the API here is a more involved change.
      */
     private final Map<Plugin, DiscardablePluginLoader> candidatePluginsToPluginLoader;
 
     /**
      * A list of plugins to be re-enabled when adding plugins.
      * <p/>
      * As with {@link #candidatePluginsToPluginLoader}, this is passing data from {@link #earlyStartup} and {@link #lateStartup} to
      * {@link #addPlugins} without an API change.
      */
     private final Collection<Plugin> additionalPluginsToEnable;
 
     private final DefaultPluginManagerJmxBridge defaultPluginManagerJmxBridge;
 
     /**
      * The list of plugins whose load was delayed.
      */
     private final List<Plugin> delayedPlugins;
 
     /**
      * A map of plugins which need to be removed during lateStartup.
      *
      * The plugins which need to be removed on restart are discovered during earlyStartup so we can avoid installing them
      * when not required, but cannot be removed until persistence is available during late startup.
      */
     private final Map<Plugin, DiscardablePluginLoader> delayedPluginRemovalsToLoader;
 
     private static PluginExceptionInterception defaultPluginExceptionInterception()
     {
         return NoOpPluginExceptionInterception.NOOP_INTERCEPTION;
     }
 
     private static boolean defaultVerifyRequiredPlugins()
     {
         return false;
     }
 
     private static PluginPredicate defaultDelayLoadOf()
     {
         return new PluginPredicate()
         {
             public boolean matches(final Plugin plugin)
             {
                 return false;
             }
         };
     }
 
     public DefaultPluginManager(
             final PluginPersistentStateStore store,
             final List<PluginLoader> pluginLoaders,
             final ModuleDescriptorFactory moduleDescriptorFactory,
             final PluginEventManager pluginEventManager)
     {
         this(store, pluginLoaders, moduleDescriptorFactory, pluginEventManager,
                 defaultPluginExceptionInterception(), defaultVerifyRequiredPlugins(), defaultDelayLoadOf());
     }
 
     public DefaultPluginManager(
             final PluginPersistentStateStore store,
             final List<PluginLoader> pluginLoaders,
             final ModuleDescriptorFactory moduleDescriptorFactory,
             final PluginEventManager pluginEventManager,
             final PluginExceptionInterception pluginExceptionInterception)
     {
         this(store, pluginLoaders, moduleDescriptorFactory, pluginEventManager,
                 pluginExceptionInterception, defaultVerifyRequiredPlugins(), defaultDelayLoadOf());
     }
 
     public DefaultPluginManager(
             final PluginPersistentStateStore store,
             final List<PluginLoader> pluginLoaders,
             final ModuleDescriptorFactory moduleDescriptorFactory,
             final PluginEventManager pluginEventManager,
             final boolean verifyRequiredPlugins)
     {
         this(store, pluginLoaders, moduleDescriptorFactory, pluginEventManager,
                 defaultPluginExceptionInterception(), verifyRequiredPlugins, defaultDelayLoadOf());
     }
 
     @ExperimentalApi
     public DefaultPluginManager(
             final PluginPersistentStateStore store,
             final List<PluginLoader> pluginLoaders,
             final ModuleDescriptorFactory moduleDescriptorFactory,
             final PluginEventManager pluginEventManager,
             final PluginPredicate delayLoadOf)
     {
         this(store, pluginLoaders, moduleDescriptorFactory, pluginEventManager,
                 defaultPluginExceptionInterception(), defaultVerifyRequiredPlugins(), delayLoadOf);
     }
 
     @ExperimentalApi
     public DefaultPluginManager(
             final PluginPersistentStateStore store,
             final List<PluginLoader> pluginLoaders,
             final ModuleDescriptorFactory moduleDescriptorFactory,
             final PluginEventManager pluginEventManager,
             final PluginExceptionInterception pluginExceptionInterception,
             final PluginPredicate delayLoadOf)
     {
         this(store, pluginLoaders, moduleDescriptorFactory, pluginEventManager,
                 pluginExceptionInterception, defaultVerifyRequiredPlugins(), delayLoadOf);
     }
 
     public DefaultPluginManager(
             final PluginPersistentStateStore store,
             final List<PluginLoader> pluginLoaders,
             final ModuleDescriptorFactory moduleDescriptorFactory,
             final PluginEventManager pluginEventManager,
             final PluginExceptionInterception pluginExceptionInterception,
             final boolean verifyRequiredPlugins)
     {
         this(store, pluginLoaders, moduleDescriptorFactory, pluginEventManager,
                 pluginExceptionInterception, verifyRequiredPlugins, defaultDelayLoadOf());
     }
 
     @ExperimentalApi
     public DefaultPluginManager(
             final PluginPersistentStateStore store,
             final List<PluginLoader> pluginLoaders,
             final ModuleDescriptorFactory moduleDescriptorFactory,
             final PluginEventManager pluginEventManager,
             final PluginExceptionInterception pluginExceptionInterception,
             final boolean verifyRequiredPlugins,
             final PluginPredicate delayLoadOf)
     {
         this.pluginLoaders = toPermissionCheckingPluginLoaders(notNull("Plugin Loaders list must not be null.", pluginLoaders));
         this.store = notNull("PluginPersistentStateStore must not be null.", store);
         this.moduleDescriptorFactory = notNull("ModuleDescriptorFactory must not be null.", moduleDescriptorFactory);
         this.pluginEventManager = notNull("PluginEventManager must not be null.", pluginEventManager);
 
         this.pluginEnabler = new PluginEnabler(this, this, notNull("PluginExceptionInterception must not be null.", pluginExceptionInterception));
         this.verifyRequiredPlugins = verifyRequiredPlugins;
         this.delayLoadOf = wrapDelayPredicateWithOverrides(delayLoadOf);
 
         this.plugins = CopyOnWriteMap.<String, Plugin> builder().stableViews().newHashMap();
         this.tracker = new StateTracker();
         this.pluginInstaller = new NoOpRevertablePluginInstaller(new UnsupportedPluginInstaller());
         this.installedPluginsToPluginLoader = new HashMap<Plugin, PluginLoader>();
         this.candidatePluginsToPluginLoader = new HashMap<Plugin, DiscardablePluginLoader>();
         this.additionalPluginsToEnable = new ArrayList<Plugin>();
         this.delayedPlugins = new ArrayList<Plugin>();
         this.delayedPluginRemovalsToLoader = new HashMap<Plugin, DiscardablePluginLoader>();
 
         this.pluginEventManager.register(this);
         this.classLoader = new PluginsClassLoader(null, this, pluginEventManager);
         this.defaultPluginManagerJmxBridge = new DefaultPluginManagerJmxBridge(this);
     }
 
     private List<DiscardablePluginLoader> toPermissionCheckingPluginLoaders(final List<PluginLoader> fromIterable)
     {
         return Lists.newArrayList(Iterables.transform(fromIterable, new Function<PluginLoader, DiscardablePluginLoader>()
         {
             @Override
             public PermissionCheckingPluginLoader apply(final PluginLoader pluginLoader)
             {
                 return new PermissionCheckingPluginLoader(pluginLoader);
             }
         }));
     }
 
     private PluginPredicate wrapDelayPredicateWithOverrides(final PluginPredicate pluginPredicate)
     {
         final Properties startupOverridesProperties = new Properties();
         final String startupOverrideFile = System.getProperty(getStartupOverrideFileProperty());
         if (null != startupOverrideFile)
         try
         {
             startupOverridesProperties.load(new FileInputStream(startupOverrideFile));
         }
         catch(final IOException eio)
         {
             log.warn("Failed to load startupOverrideFile '{}': {}", startupOverrideFile, eio.getMessage());
         }
         final Map<String, String> startupOverridesMap = Maps.fromProperties(startupOverridesProperties);
 
         return new PluginPredicate()
         {
             @Override
             public boolean matches(final Plugin plugin)
             {
                 final String pluginKey = plugin.getKey();
 
                 // Check startup overrides for plugin startup declaration
                 final String stringFromFile = startupOverridesMap.get(pluginKey);
                 final Boolean parsedFromFile = parseStartupToDelay(stringFromFile, pluginKey, "override file");
                 if (null != parsedFromFile)
                 {
                     return parsedFromFile;
                 }
 
                 // Check PluginInformation for plugin startup declaration
                 final PluginInformation pluginInformation = plugin.getPluginInformation();
                 final String stringFromInformation = (null != pluginInformation) ? pluginInformation.getStartup() : null;
                 final Boolean parsedFromInformation = parseStartupToDelay(stringFromInformation, pluginKey, "PluginInformation");
                 if (null != parsedFromInformation)
                 {
                     return parsedFromInformation;
                 }
 
                 // No plugin startup information, so use product supplied predicate
                 return pluginPredicate.matches(plugin);
             }
 
             private Boolean parseStartupToDelay(final String startup, final String pluginKey, final String source)
             {
                 if (null != startup)
                 {
                     if ("early".equals(startup))
                     {
                         return false;
                     }
                     if ("late".equals(startup))
                     {
                         return true;
                     }
 
                     log.warn("Unknown startup '{}' for plugin '{}' from {}", new Object[] { startup, pluginKey, source });
                     // and fall through
                 }
 
                 return null;
             }
 
         };
     }
 
     public void init() throws PluginParseException, NotificationException
     {
         earlyStartup();
         lateStartup();
     }
 
     @ExperimentalApi
     public void earlyStartup() throws PluginParseException, NotificationException
     {
         final StopWatch stopWatch = new StopWatch();
         stopWatch.start();
         log.info("Plugin system earlyStartup begun");
         tracker.setState(StateTracker.State.STARTING);
 
         defaultPluginManagerJmxBridge.register();
         pluginEventManager.broadcast(new PluginFrameworkStartingEvent(this, this));
         pluginInstaller.clearBackups();
         final PluginPersistentState pluginPersistentState = getState();
 
         final Multimap<String, Plugin> candidatePluginKeyToVersionedPlugins = TreeMultimap.create();
         for (final DiscardablePluginLoader loader : pluginLoaders)
         {
             if (loader == null)
             {
                 continue;
             }
 
             final Iterable<Plugin> possiblePluginsToLoad = loader.loadAllPlugins(moduleDescriptorFactory);
 
             if (log.isDebugEnabled())
             {
                 log.debug("Found {} plugins to possibly load: {}",
                         Iterables.size(possiblePluginsToLoad), toPluginKeys(possiblePluginsToLoad));
             }
 
             for (final Plugin plugin : possiblePluginsToLoad)
             {
                 if (pluginPersistentState.getPluginRestartState(plugin.getKey()) == PluginRestartState.REMOVE)
                 {
                     if (log.isInfoEnabled())
                     {
                         log.info("Plugin " + plugin.getKey() + " was marked to be removed on restart.  Removing now.");
                     }
                     // We need to remove the plugin and clear its state, but we don't want to do any persistence until
                     // late startup. We may as well delay PluginLoader#removePlugin also, as it doesn't hurt,
                     // and it makes fewer assumptions about how the product persists the plugins themselves.
                     delayedPluginRemovalsToLoader.put(plugin, loader);
                 }
                 else
                 {
                     // We need the loaders for installed plugins so we can issue removePlugin() when
                     // the plugin is unloaded. So anything we didn't remove above, we put into the
                     // candidatePluginsToPluginLoader map. All of these need either removePlugin()
                     // or discardPlugin() for resource management.
                     candidatePluginsToPluginLoader.put(plugin, loader);
                     candidatePluginKeyToVersionedPlugins.put(plugin.getKey(), plugin);
                 }
             }
         }
         final List<Plugin> pluginsToInstall = new ArrayList<Plugin>();
         for (final Collection<Plugin> plugins : candidatePluginKeyToVersionedPlugins.asMap().values())
         {
             final Plugin plugin = Ordering.natural().max(plugins);
             if (plugins.size() > 1)
             {
                 log.debug("Plugin {} contained multiple versions. installing version {}.", plugin.getKey(), plugin.getPluginInformation().getVersion());
             }
             pluginsToInstall.add(plugin);
         }
 
         // Partition pluginsToInstall into immediatePlugins that we install now, and delayedPlugins
         // that we install when instructed by a call to lateStartup.
         // In later versions of Guava, ImmutableListMultimap.index is another way to slice this if
         // you convert the PluginPredicate to a function. Whether or this is cleaner is a bit moot
         // since we can't use it yet anyway.
         final List<Plugin> immediatePlugins = new ArrayList<Plugin>();
         for (final Plugin plugin : pluginsToInstall)
         {
             if (delayLoadOf.matches(plugin))
             {
                 delayedPlugins.add(plugin);
             }
             else
             {
                 immediatePlugins.add(plugin);
             }
         }
 
         // Install the non-delayed plugins
         addPlugins(null, immediatePlugins);
 
         // For each immediatePlugins, addPlugins has either called removePlugin()/discardPlugin()
         // for its loader, or is tracking it in installedPluginsToPluginLoader for a removePlugin()
         // when it is uninstalled (either via upgrade or shutdown).
         for (final Plugin plugin : immediatePlugins)
         {
             candidatePluginsToPluginLoader.remove(plugin);
         }
 
         if (Boolean.getBoolean(getLateStartupEnableRetryProperty()))
         {
             for (final Plugin plugin : immediatePlugins)
             {
                 // For each plugin that didn't enable but should have, make a note so we can try them again later. It's a little
                 // bit vexing that we are checking the persistent state here again just after addPlugins did it, but refactoring this
                 // stuff is fraught with API danger, so this can wait. PLUG-1116 seems like a time this might be worth revisiting.
                 if ((PluginState.ENABLED != plugin.getPluginState()) && pluginPersistentState.isEnabled(plugin))
                 {
                     additionalPluginsToEnable.add(plugin);
                 }
             }
             if (!additionalPluginsToEnable.isEmpty())
             {
                 // Let people know we're going to retry them, so there is information in the logs about this near the resolution errors
                 log.warn("Failed to enable some ({}) early plugins, will fallback during lateStartup. Plugins: {}",
                         additionalPluginsToEnable.size(), additionalPluginsToEnable);
             }
         }
 
         // We need to keep candidatePluginsToPluginLoader populated with the delayedPlugins so that
         // addPlugins can do the right thing when called by lateStartup. However, we want to
         // discardPlugin anything we don't need so that loaders can release resources. So move what
         // we need later from candidatePluginsToPluginLoader to delayedPluginsLoaders.
         final Map<Plugin, DiscardablePluginLoader> delayedPluginsLoaders = new HashMap<Plugin, DiscardablePluginLoader>();
         for (final Plugin plugin : delayedPlugins)
         {
             final DiscardablePluginLoader loader = candidatePluginsToPluginLoader.remove(plugin);
             delayedPluginsLoaders.put(plugin, loader);
         }
         // Now candidatePluginsToPluginLoader contains exactly Plugins returned by loadAllPlugins
         // for which we didn't removePlugin() above, didn't pass on addPlugins(), and won't handle
         // in loadDelayedPlugins. So loaders can release resources, we discardPlugin() these.
         for (final Map.Entry<Plugin, DiscardablePluginLoader> entry : candidatePluginsToPluginLoader.entrySet())
         {
             final Plugin plugin = entry.getKey();
             final DiscardablePluginLoader loader = entry.getValue();
             loader.discardPlugin(plugin);
         }
         // Finally, make candidatePluginsToPluginLoader contain what loadDelayedPlugins needs.
         candidatePluginsToPluginLoader.clear();
         candidatePluginsToPluginLoader.putAll(delayedPluginsLoaders);
         tracker.setState(StateTracker.State.DELAYED);
 
         stopWatch.stop();
         log.info("Plugin system earlyStartup finished in " + stopWatch);
 
         pluginEventManager.broadcast(new PluginFrameworkDelayedEvent(this, this));
     }
 
     @ExperimentalApi
     public void lateStartup() throws PluginParseException, NotificationException
     {
         final StopWatch stopWatch = new StopWatch();
         stopWatch.start();
         log.info("Plugin system lateStartup begun");
 
         tracker.setState(StateTracker.State.RESUMING);
         pluginEventManager.broadcast(new PluginFrameworkResumingEvent(this, this));
 
         addPlugins(null, delayedPlugins);
         delayedPlugins.clear();
         candidatePluginsToPluginLoader.clear();
 
         getStore().save(getBuilder().clearPluginRestartState().toState());
         for(final Map.Entry<Plugin, DiscardablePluginLoader>  entry : delayedPluginRemovalsToLoader.entrySet())
         {
             final Plugin plugin = entry.getKey();
             final DiscardablePluginLoader loader = entry.getValue();
             // Remove the plugin from the loader, and discard saved state (see PLUG-13).
             loader.removePlugin(plugin);
             removeStateFromStore(getStore(), plugin);
         }
         delayedPluginRemovalsToLoader.clear();
 
         stopWatch.stop();
         log.info("Plugin system lateStartup finished in " + stopWatch);
 
         tracker.setState(StateTracker.State.STARTED);
         if (verifyRequiredPlugins)
         {
             validateRequiredPlugins();
         }
         pluginEventManager.broadcast(new PluginFrameworkStartedEvent(this, this));
     }
 
     private void validateRequiredPlugins() throws PluginException
     {
         final RequiredPluginValidator validator = new DefaultRequiredPluginValidator(this, new ClasspathFilePluginMetadata());
         final Collection<String> errors = validator.validate();
         if (errors.size() > 0)
         {
             log.error("Unable to validate required plugins or modules - plugin system shutting down");
             log.error("Failures:");
             for (final String error : errors)
             {
                 log.error("\t{}", error);
             }
             shutdown();
             throw new PluginException("Unable to validate required plugins or modules");
         }
     }
 
     /**
      * Fires the shutdown event
      *
      * @since 2.0.0
      * @throws IllegalStateException if already shutdown or already in the
      *             process of shutting down.
      */
     public void shutdown()
     {
         tracker.setState(StateTracker.State.SHUTTING_DOWN);
 
         log.info("Preparing to shut down the plugin system");
         broadcast(new PluginFrameworkShuttingDownEvent(this, this));
 
         log.info("Shutting down the plugin system");
         broadcast(new PluginFrameworkShutdownEvent(this, this));
 
         plugins.clear();
         pluginEventManager.unregister(this);
         tracker.setState(StateTracker.State.SHUTDOWN);
         defaultPluginManagerJmxBridge.unregister();
     }
 
     private void broadcast(final Object event)
     {
         try
         {
             pluginEventManager.broadcast(event);
         }
         catch (final NotificationException ex)
         {
             log.error(
                     "At least one error occured while broadcasting the {}. We will continue to shutdown the Plugin Manager anyway.",
                     event.getClass().getName());
         }
     }
 
     public final void warmRestart()
     {
         tracker.setState(StateTracker.State.WARM_RESTARTING);
         log.info("Initiating a warm restart of the plugin system");
         pluginEventManager.broadcast(new PluginFrameworkWarmRestartingEvent(this, this));
 
         // Make sure we reload plugins in order
         final List<Plugin> restartedPlugins = new ArrayList<Plugin>();
         final List<PluginLoader> loaders = new ArrayList<PluginLoader>(pluginLoaders);
         Collections.reverse(loaders);
         for (final PluginLoader loader : pluginLoaders)
         {
             for (final Map.Entry<Plugin, PluginLoader> entry : installedPluginsToPluginLoader.entrySet())
             {
                 if (entry.getValue() == loader)
                 {
                     final Plugin plugin = entry.getKey();
                     if (isPluginEnabled(plugin.getKey()))
                     {
                         disablePluginModules(plugin);
                         restartedPlugins.add(plugin);
                     }
                 }
             }
         }
 
         // then enable them in reverse order
         Collections.reverse(restartedPlugins);
         for (final Plugin plugin : restartedPlugins)
         {
             enableConfiguredPluginModules(plugin);
         }
 
         pluginEventManager.broadcast(new PluginFrameworkWarmRestartedEvent(this, this));
         tracker.setState(StateTracker.State.STARTED);
     }
 
     @PluginEventListener
     public void onPluginModuleAvailable(final PluginModuleAvailableEvent event)
     {
         enableConfiguredPluginModule(event.getModule().getPlugin(), event.getModule(), new HashSet<ModuleDescriptor<?>>());
     }
 
     @PluginEventListener
     public void onPluginModuleUnavailable(final PluginModuleUnavailableEvent event)
     {
         notifyModuleDisabled(event.getModule());
     }
 
     @PluginEventListener
     public void onPluginContainerUnavailable(final PluginContainerUnavailableEvent event)
     {
         disablePluginWithoutPersisting(event.getPluginKey());
     }
 
     @PluginEventListener
     public void onPluginRefresh(final PluginRefreshedEvent event)
     {
         final Plugin plugin = event.getPlugin();
 
         disablePluginModules(plugin);
 
         // enable the plugin, shamefully copied from notifyPluginEnabled()
         if (enableConfiguredPluginModules(plugin))
         {
             pluginEventManager.broadcast(new PluginEnabledEvent(plugin));
         }
     }
 
     /**
      * Set the plugin installation strategy for this manager
      *
      * @param pluginInstaller the plugin installation strategy to use
      * @see PluginInstaller
      */
     public void setPluginInstaller(final PluginInstaller pluginInstaller)
     {
         if (pluginInstaller instanceof RevertablePluginInstaller)
         {
             this.pluginInstaller = (RevertablePluginInstaller) pluginInstaller;
         }
         else
         {
             this.pluginInstaller = new NoOpRevertablePluginInstaller(pluginInstaller);
         }
     }
 
     protected final PluginPersistentStateStore getStore()
     {
         return store;
     }
 
     public String installPlugin(final PluginArtifact pluginArtifact) throws PluginParseException
     {
         final Set<String> keys = installPlugins(pluginArtifact);
         if ((keys != null) && (keys.size() == 1))
         {
             return keys.iterator().next();
         }
         else
         {
             // should never happen
             throw new PluginParseException("Could not install plugin");
         }
     }
 
     public Set<String> installPlugins(final PluginArtifact... pluginArtifacts) throws PluginParseException
     {
         final Map<String, PluginArtifact> validatedArtifacts = new LinkedHashMap<String, PluginArtifact>();
         try
         {
             for (final PluginArtifact pluginArtifact : pluginArtifacts)
             {
                 validatedArtifacts.put(validatePlugin(pluginArtifact), pluginArtifact);
             }
         }
         catch (final PluginParseException ex)
         {
             throw new PluginParseException("All plugins could not be validated", ex);
         }
 
         for (final Map.Entry<String, PluginArtifact> entry : validatedArtifacts.entrySet())
         {
             pluginInstaller.installPlugin(entry.getKey(), entry.getValue());
         }
 
         scanForNewPlugins();
         return validatedArtifacts.keySet();
     }
 
     /**
      * Validate a plugin jar. Looks through all plugin loaders for ones that can
      * load the plugin and extract the plugin key as proof.
      *
      * @param pluginArtifact the jar file representing the plugin
      * @return The plugin key
      * @throws PluginParseException if the plugin cannot be parsed
      * @throws NullPointerException if <code>pluginJar</code> is null.
      */
     String validatePlugin(final PluginArtifact pluginArtifact) throws PluginParseException
     {
         boolean foundADynamicPluginLoader = false;
         for (final PluginLoader loader : pluginLoaders)
         {
             if (loader.isDynamicPluginLoader())
             {
                 foundADynamicPluginLoader = true;
                 final String key =  ((DynamicPluginLoader) loader).canLoad(pluginArtifact);
                 if (key != null)
                 {
                     return key;
                 }
             }
         }
 
         if (!foundADynamicPluginLoader)
         {
             throw new IllegalStateException("Should be at least one DynamicPluginLoader in the plugin loader list");
         }
         throw new PluginParseException("Jar " + pluginArtifact.getName() + " is not a valid plugin!");
     }
 
     public int scanForNewPlugins() throws PluginParseException
     {
         final StateTracker.State state = tracker.get();
         checkState((StateTracker.State.RESUMING == state) || (StateTracker.State.STARTED == state),
                 "Cannot scanForNewPlugins in state %s", state);
 
         int numberFound = 0;
 
         for (final PluginLoader loader : pluginLoaders)
         {
             if (loader != null)
             {
                 if (loader.supportsAddition())
                 {
                     final List<Plugin> pluginsToAdd = new ArrayList<Plugin>();
                     for (Plugin plugin : loader.loadFoundPlugins(moduleDescriptorFactory))
                     {
                         final Plugin oldPlugin = plugins.get(plugin.getKey());
                         // Only actually install the plugin if its module
                         // descriptors support it. Otherwise, mark it as
                         // unloadable.
                         if (!(plugin instanceof UnloadablePlugin))
                         {
                             if (PluginUtils.doesPluginRequireRestart(plugin))
                             {
                                 if (oldPlugin == null)
                                 {
                                     markPluginInstallThatRequiresRestart(plugin);
 
                                     final UnloadablePlugin unloadablePlugin = UnloadablePluginFactory.createUnloadablePlugin(plugin);
                                     unloadablePlugin.setErrorText("Plugin requires a restart of the application due " + "to the following modules: " + PluginUtils.getPluginModulesThatRequireRestart(plugin));
                                     plugin = unloadablePlugin;
                                 }
                                 else
                                 {
                                     // If a plugin has been installed but is waiting for restart then we do not want to
                                     // put the plugin into the update state, we want to keep it in the install state.
                                     if (!PluginRestartState.INSTALL.equals(getPluginRestartState(plugin.getKey())))
                                     {
                                         markPluginUpgradeThatRequiresRestart(plugin);
                                     }
                                     continue;
                                 }
                             }
                             // If the new plugin does not require restart we need to check what the restart state of
                             // the old plugin was and act accordingly
                             else if (oldPlugin != null && PluginUtils.doesPluginRequireRestart(oldPlugin))
                             {
                                 // If you have installed the plugin that requires restart and before restart you have
                                 // reinstalled a version of that plugin that does not require restart then you should
                                 // just go ahead and install that plugin. This means reverting the previous install
                                 // and letting the plugin fall into the plugins to add list
                                 if (PluginRestartState.INSTALL.equals(getPluginRestartState(oldPlugin.getKey())))
                                 {
                                     revertRestartRequiredChange(oldPlugin.getKey());
                                 }
                                 else
                                 {
                                     markPluginUpgradeThatRequiresRestart(plugin);
                                     continue;
                                 }
                             }
                             pluginsToAdd.add(plugin);
                         }
                     }
                     addPlugins(loader, pluginsToAdd);
                     numberFound += pluginsToAdd.size();
                 }
             }
         }
         return numberFound;
     }
 
     private void markPluginInstallThatRequiresRestart(final Plugin plugin)
     {
         if (log.isInfoEnabled())
         {
             log.info("Installed plugin '" + plugin.getKey() + "' requires a restart due to the following modules: " + PluginUtils.getPluginModulesThatRequireRestart(plugin));
         }
         updateRequiresRestartState(plugin.getKey(), PluginRestartState.INSTALL);
     }
 
     private void markPluginUpgradeThatRequiresRestart(final Plugin plugin)
     {
         if (log.isInfoEnabled())
         {
             log.info("Upgraded plugin '" + plugin.getKey() + "' requires a restart due to the following modules: " + PluginUtils.getPluginModulesThatRequireRestart(plugin));
         }
         updateRequiresRestartState(plugin.getKey(), PluginRestartState.UPGRADE);
     }
 
     private void markPluginUninstallThatRequiresRestart(final Plugin plugin)
     {
         if (log.isInfoEnabled())
         {
             log.info("Uninstalled plugin '" + plugin.getKey() + "' requires a restart due to the following modules: " + PluginUtils.getPluginModulesThatRequireRestart(plugin));
         }
         updateRequiresRestartState(plugin.getKey(), PluginRestartState.REMOVE);
     }
 
     private void updateRequiresRestartState(final String pluginKey, final PluginRestartState pluginRestartState)
     {
         getStore().save(getBuilder().setPluginRestartState(pluginKey, pluginRestartState).toState());
         onUpdateRequiresRestartState(pluginKey, pluginRestartState);
     }
 
     @SuppressWarnings ("UnusedParameters")
     protected void onUpdateRequiresRestartState(final String pluginKey, final PluginRestartState pluginRestartState)
     {
         // nothing to do in this implementation
     }
 
     /**
      * Uninstalls the given plugin, emitting disabled and uninstalled events as it does so.
      *
      * @param plugin the plugin to uninstall.
      * @throws PluginException If the plugin or loader doesn't support uninstallation
      */
     public void uninstall(final Plugin plugin) throws PluginException
     {
         if (PluginUtils.doesPluginRequireRestart(plugin))
         {
             ensurePluginAndLoaderSupportsUninstall(plugin);
             markPluginUninstallThatRequiresRestart(plugin);
         }
         else
         {
             // Explicitly disable any plugins that require this plugin
             disableDependentPlugins(plugin.getKey());
 
             uninstallNoEvent(plugin);
 
             broadcastIgnoreError(new PluginUninstalledEvent(plugin));
         }
     }
 
     /**
      * Preforms an uninstallation without broadcasting the uninstallation event.
      *
      * @param plugin The plugin to uninstall
      * @since 2.5.0
      */
     protected void uninstallNoEvent(final Plugin plugin)
     {
         unloadPlugin(plugin);
 
         // PLUG-13: Plugins should not save state across uninstalls.
         removeStateFromStore(getStore(), plugin);
     }
 
     /**
      * @param pluginKey The plugin key to revert
      * @throws PluginException If the revert cannot be completed
      */
     public void revertRestartRequiredChange(final String pluginKey) throws PluginException
     {
         notNull("pluginKey", pluginKey);
         final PluginRestartState restartState = getState().getPluginRestartState(pluginKey);
         if (restartState == PluginRestartState.UPGRADE)
         {
             pluginInstaller.revertInstalledPlugin(pluginKey);
         }
         else if (restartState == PluginRestartState.INSTALL)
         {
             pluginInstaller.revertInstalledPlugin(pluginKey);
             plugins.remove(pluginKey);
         }
         updateRequiresRestartState(pluginKey, PluginRestartState.NONE);
     }
 
     protected void removeStateFromStore(final PluginPersistentStateStore stateStore, final Plugin plugin)
     {
         final PluginPersistentState.Builder builder = PluginPersistentState.Builder.create(stateStore.load()).removeState(plugin.getKey());
         for (final ModuleDescriptor<?> moduleDescriptor : plugin.getModuleDescriptors())
         {
             builder.removeState(moduleDescriptor.getCompleteKey());
         }
         stateStore.save(builder.toState());
     }
 
     /**
      * Unload a plugin. Called when plugins are added locally, or remotely in a
      * clustered application.
      *
      * @param plugin the plugin to remove
      * @throws PluginException if the plugin cannot be uninstalled
      */
     protected void unloadPlugin(final Plugin plugin) throws PluginException
     {
         final PluginLoader loader = ensurePluginAndLoaderSupportsUninstall(plugin);
 
         if (isPluginEnabled(plugin.getKey()))
         {
             notifyPluginDisabled(plugin);
         }
 
         notifyUninstallPlugin(plugin);
         if (loader != null)
         {
             removePluginFromLoader(plugin);
         }
 
         plugins.remove(plugin.getKey());
     }
 
     private PluginLoader ensurePluginAndLoaderSupportsUninstall(final Plugin plugin)
     {
         if (!plugin.isUninstallable())
         {
             throw new PluginException("Plugin is not uninstallable: " + plugin.getKey());
         }
 
         final PluginLoader loader = installedPluginsToPluginLoader.get(plugin);
 
         if ((loader != null) && !loader.supportsRemoval())
         {
             throw new PluginException("Not uninstalling plugin - loader doesn't allow removal. Plugin: " + plugin.getKey());
         }
         return loader;
     }
 
     private void removePluginFromLoader(final Plugin plugin) throws PluginException
     {
         if (plugin.isUninstallable())
         {
             final PluginLoader pluginLoader = installedPluginsToPluginLoader.get(plugin);
             pluginLoader.removePlugin(plugin);
         }
 
         installedPluginsToPluginLoader.remove(plugin);
     }
 
     protected void notifyUninstallPlugin(final Plugin plugin)
     {
         classLoader.notifyUninstallPlugin(plugin);
 
         for (final ModuleDescriptor<?> descriptor : plugin.getModuleDescriptors())
         {
             descriptor.destroy();
         }
     }
 
     protected PluginPersistentState getState()
     {
         return getStore().load();
     }
 
     /**
      * @deprecated Since 2.0.2, use {@link #addPlugins} instead
      */
     @Deprecated
     protected void addPlugin(final PluginLoader loader, final Plugin plugin) throws PluginParseException
     {
         addPlugins(loader, Collections.singletonList(plugin));
     }
 
     /**
      * Update the local plugin state and enable state aware modules.
      * <p>
      * If there is an existing plugin with the same key, the version strings of
      * the existing plugin and the plugin provided to this method will be parsed
      * and compared. If the installed version is newer than the provided
      * version, it will not be changed. If the specified plugin's version is the
      * same or newer, the existing plugin state will be saved and the plugin
      * will be unloaded before the provided plugin is installed. If the existing
      * plugin cannot be unloaded a {@link PluginException} will be thrown.
      *
      * @param loader the loader used to load this plugin. This should only be null when called
      * internally from init(), in which case the loader is looked up per plugin in
      * candidatePluginsToPluginLoader.
      * @param pluginsToInstall the plugins to add
      * @throws PluginParseException if the plugin cannot be parsed
      * @since 2.0.2
      */
     protected void addPlugins(@Nullable final PluginLoader loader, final Collection<Plugin> pluginsToInstall)
             throws PluginParseException
     {
         final List<Plugin> pluginsToEnable = new ArrayList<Plugin>();
 
         // Install plugins, looking for upgrades and duplicates
         for (final Plugin plugin : new TreeSet<Plugin>(pluginsToInstall))
         {
             boolean pluginUpgraded = false;
             // testing to make sure plugin keys are unique
             final String pluginKey = plugin.getKey();
             final Plugin existingPlugin = plugins.get(pluginKey);
             if (existingPlugin != null)
             {
                 if (plugin.compareTo(existingPlugin) >= 0)
                 {
                     try
                     {
 
                         // It's an upgrade, so disable plugins which depend upon the plugin, as the plugin will be
                         // uninstalled when we upgrade, and this may trigger a package refresh, bringing down dependent
                         // plugins. Observe that pluginKey is the same for plugin and existingPlugin, and the
                         // dependentPlugin calculation uses only the key. Record the plugins we disabled, because we need
                         // to re-enable them once the new plugin has been installed.
                         pluginsToEnable.addAll(disableDependentPlugins(pluginKey));
                         updatePlugin(existingPlugin, plugin);
                         pluginsToEnable.remove(existingPlugin);
                         pluginUpgraded = true;
                     }
                     catch (final PluginException e)
                     {
                         throw new PluginParseException("Duplicate plugin found (installed version is the same or older) and"
                                 + " could not be unloaded: '" + pluginKey + "'", e);
                     }
                 }
                 else
                 {
                     // If we find an older plugin, don't error (PLUG-12) ...
                     log.debug("Duplicate plugin found (installed version is newer): '{}'", pluginKey);
                     // ... just discard the older (unused) plugin
                     if (null == loader)
                     {
                         // With current code, we can't get here with loader null, because the older
                         // plugins have already been discarded by init. However, let's be careful.
                         candidatePluginsToPluginLoader.get(plugin).discardPlugin(plugin);
                     }
                     else if (loader instanceof DiscardablePluginLoader)
                     {
                         // This is the typical case - the loader is once of our loaders from
                         // pluginLoaders which were wrapped with PermissionCheckingPluginLoader
                         // which is a DiscardablePluginLoader.
                         ((DiscardablePluginLoader) loader).discardPlugin(plugin);
                     }
                     else
                     {
                         // This is only reachable if the caller has supplied their own PluginLoader,
                         // since all of ours are wrapped in a PermissionCheckingPluginLoader which
                         // implements DiscardablePluginLoader.  We ignore the discard, but we log
                         // because (in the short term) this is more likely to be a PluginLoader
                         // which should really be a DiscardablePluginLoader then one which is
                         // legitimately ignoring discardPlugin.
                         log.debug("Ignoring discardPlugin({}, version {}) as delegate is not a DiscardablePluginLoader",
                                 pluginKey, plugin.getPluginInformation().getVersion());
                     }
 
                     // Don't install the older plugin
                     continue;
                 }
             }
 
             plugin.install();
             final boolean isPluginEnabled = getState().isEnabled(plugin);
             if (isPluginEnabled)
             {
                 log.debug("Plugin '{}' is to be enabled.", pluginKey);
                 pluginsToEnable.add(plugin);
             }
             else
             {
                 if (plugin.isSystemPlugin())
                 {
                     log.warn("System Plugin '{}' is disabled.", pluginKey);
                 }
                 else
                 {
                     log.debug("Plugin '{}' is disabled.", pluginKey);
                 }
             }
             if (pluginUpgraded)
             {
                 pluginEventManager.broadcast(new PluginUpgradedEvent(plugin));
             }
             plugins.put(pluginKey, plugin);
             if (loader == null)
             {
                 installedPluginsToPluginLoader.put(plugin, candidatePluginsToPluginLoader.get(plugin));
             }
             else
             {
                 installedPluginsToPluginLoader.put(plugin, loader);
             }
         }
 
         // Include any additionalPluginsToEnable which are hanging over from a previous enable attempt. This is a safety net
         // to workaround issues where early plugins are failing to enabled because of newly added dependencies on late plugins.
         // The code in question is broken, and we warn below, but this is causing enough pain we're special casing for now.
         pluginsToEnable.addAll(additionalPluginsToEnable);
 
         final PluginSortMode pluginSortMode = PluginSortMode.current();
         final List<Plugin> pluginsInEnableOrder = PluginSortMode.SORTED.equals(pluginSortMode)
                 ? sortPluginsForEnable(pluginsToEnable, plugins)
                 : pluginsToEnable;
         if (PluginSortMode.SHUFFLE.equals(pluginSortMode))
         {
             Collections.shuffle(pluginsInEnableOrder);
         }
 
         if (log.isDebugEnabled())
         {
             log.debug("Found {} plugins to enable: {}", pluginsInEnableOrder.size(), toPluginKeys(pluginsInEnableOrder));
         }
         pluginEnabler.enable(pluginsInEnableOrder); // enable all plugins, waiting a time period for them to enable
 
         for (final Plugin plugin : additionalPluginsToEnable)
         {
            if (PluginState.ENABLED == plugin.getPluginState())
            {
                log.warn("Plugin {} was early but failed to enable, but was fallback enabled in lateStartup."
                        + " It likely has dependencies on plugins which are late, in which case you should fix those plugins and"
                        + " make them early, or as a last resort make the offending plugin late",
                        plugin);
            }
         }
         additionalPluginsToEnable.clear();
 
         // handle the plugins that were able to be successfully enabled
         for (final Plugin plugin : pluginsInEnableOrder)
         {
             if (plugin.getPluginState() == PluginState.ENABLED)
             {
                 // This method enables the plugin modules
                 if (enableConfiguredPluginModules(plugin))
                 {
                     pluginEventManager.broadcast(new PluginEnabledEvent(plugin));
                 }
             }
         }
     }
 
     /**
      * Disable all plugins which require, possibly indirectly, a given plugin specified by key.
      * <p/>
      * The plugin with given key is not disabled.
      * <p/>
      * This prevents a dependent plugin trying to access, indirectly, the felix global lock, which is held by the
      * PackageAdmin while refreshing. See https://ecosystem.atlassian.net/browse/PLUG-582 for details.
      *
      * @param pluginKey The key of the plugin to disable dependents of.
      * @return A collection of the plugins that were disabled.
      */
     private Collection<Plugin> disableDependentPlugins(final String pluginKey)
     {
         final Collection<Plugin> dependentPlugins = getDependentPlugins(pluginKey, getEnabledPlugins());
 
         if (log.isInfoEnabled())
         {
             log.info("Found dependent enabled plugins for uninstalled plugin '{}': {}.  Disabling...",
                     pluginKey, toPluginKeys(dependentPlugins));
         }
         for (final Plugin depPlugin : dependentPlugins)
         {
             disablePluginWithoutPersisting(depPlugin.getKey());
         }
         return dependentPlugins;
     }
 
     /**
      * Obtain the collection of all plugins which require, possibly indirectly, a given plugin specified by key.
      *
      * The plugin with given key is not included in the returned list.
      *
      * @param rootPluginKey The key of the plugin to list dependents of.
      * @return A collection of the plugins that are dependent on the plugin with key {@code pluginKey}.
      */
     @VisibleForTesting
     Collection<Plugin> getDependentPlugins(final String rootPluginKey, final Iterable<Plugin> pluginList)
     {
         // Compute dependencies map from a key to each plugin that requires it
         final Multimap<String, Plugin> dependencies = ArrayListMultimap.create();
         for (final Plugin p : pluginList)
         {
             for (final String key : p.getRequiredPlugins())
             {
                 dependencies.put(key, p);
             }
         }
 
         final Collection<Plugin> dependentPlugins = PluginSortMode.LEGACY.equals(PluginSortMode.current())
                 ? Sets.<Plugin>newHashSet()
                 : new ArrayList <Plugin>();
 
         // A queue of the plugin keys we have yet to explore dependencies of
         final ArrayDeque<String> queue = new ArrayDeque<String>();
         queue.add(rootPluginKey);
         final Set<String> visited = Sets.newHashSet(rootPluginKey);
 
         while (!queue.isEmpty())
         {
             final String pluginKey = queue.removeFirst();
             for (final Plugin dependentPlugin : dependencies.get(pluginKey))
             {
                 final String dependentPluginKey = dependentPlugin.getKey();
                 if (visited.add(dependentPluginKey))
                 {
                     dependentPlugins.add(dependentPlugin);
                     queue.addLast(dependentPluginKey);
                 }
             }
         }
         return dependentPlugins;
     }
 
     @VisibleForTesting
     public static List<Plugin> sortPluginsForEnable(final List<Plugin> pluginsToEnable, final Map<String, Plugin> pluginKeyToPlugin)
     {
         final List<Plugin> sortedList = new ArrayList<Plugin>();
         final Set<Plugin> visited = new HashSet<Plugin>();
 
         for (final Plugin plugin : pluginsToEnable)
         {
             sortPluginForEnable(plugin, sortedList, visited, pluginsToEnable, pluginKeyToPlugin);
         }
 
         return sortedList;
     }
 
     /**
      * If currentPlugin has not been visited, recurse on to each recognized plugin that it requires, and
      * then add it to the sorted list if it is allowed.
      *
      * @param currentPlugin the plugin we are inspecting requirments of.
      * @param sortedList the list of plugins sorted by requirement order.
      * @param visited the list of plugins we've already recursed into.
      * @param allowedPlugins the plugins which we can accumulate into sortedList.
      */
     private static void sortPluginForEnable(
             final Plugin currentPlugin,
             final List<Plugin> sortedList,
             final Set<Plugin> visited,
             final Collection<Plugin> allowedPlugins,
             final Map<String, Plugin> pluginKeyToPlugin)
     {
         if (visited.add(currentPlugin))
         {
             for (final String requiredKey : currentPlugin.getRequiredPlugins())
             {
                 final Plugin requiredPlugin = pluginKeyToPlugin.get(requiredKey);
 
                 if (null != requiredPlugin)
                 {
                     sortPluginForEnable(requiredPlugin, sortedList, visited, allowedPlugins, pluginKeyToPlugin);
                 }
             }
 
             if (allowedPlugins.contains(currentPlugin))
             {
                 sortedList.add(currentPlugin);
             }
         }
     }
 
     /**
      * Replace an already loaded plugin with another version. Relevant stored
      * configuration for the plugin will be preserved.
      *
      * @param oldPlugin Plugin to replace
      * @param newPlugin New plugin to install
      * @throws PluginException if the plugin cannot be updated
      */
     protected void updatePlugin(final Plugin oldPlugin, final Plugin newPlugin) throws PluginException
     {
         if (!oldPlugin.getKey().equals(newPlugin.getKey()))
         {
             throw new IllegalArgumentException("New plugin '" + newPlugin.getKey() +
                     "' must have the same key as the old plugin '" + oldPlugin.getKey() + "'");
         }
 
         if (log.isInfoEnabled())
         {
             // We know the keys are the same here, so log the versions (if available)
             final PluginInformation oldInformation = oldPlugin.getPluginInformation();
             final String oldVersion = (oldInformation == null) ? "?" : oldInformation.getVersion();
             final PluginInformation newInformation = newPlugin.getPluginInformation();
             final String newVersion = (newInformation == null) ? "?" : newInformation.getVersion();
             log.info("Updating plugin '{}' from version '{}' to version '{}'",
                     new Object[] { oldPlugin.getKey(), oldVersion, newVersion });
         }
 
         // Preserve the old plugin configuration - uninstall changes it (as
         // disable is called on all modules) and then
         // removes it
         final Map<String, Boolean> oldPluginState = new HashMap<String, Boolean>(getState().getPluginStateMap(oldPlugin));
 
         if (log.isDebugEnabled())
         {
             log.debug("Uninstalling old plugin: " + oldPlugin);
         }
         uninstallNoEvent(oldPlugin);
         if (log.isDebugEnabled())
         {
             log.debug("Plugin uninstalled '" + oldPlugin + "', preserving old state");
         }
 
         // Build a set of module keys from the new plugin version
         final Set<String> newModuleKeys = new HashSet<String>();
         newModuleKeys.add(newPlugin.getKey());
         for (final ModuleDescriptor<?> moduleDescriptor : newPlugin.getModuleDescriptors())
         {
             newModuleKeys.add(moduleDescriptor.getCompleteKey());
         }
 
         // for removing any keys from the old plugin state that do not exist in
         // the
         // new version
         final Predicate<String> filter = new Predicate<String>()
         {
             public boolean apply(final String o)
             {
                 return newModuleKeys.contains(o);
             }
         };
 
         getStore().save(getBuilder().addState(filterKeys(oldPluginState, filter)).toState());
     }
 
     public Collection<Plugin> getPlugins()
     {
         return plugins.values();
     }
 
     /**
      * @see PluginAccessor#getPlugins(com.atlassian.plugin.predicate.PluginPredicate)
      * @since 0.17
      */
     public Collection<Plugin> getPlugins(final PluginPredicate pluginPredicate)
     {
         return copyOf(filter(getPlugins(), new Predicate<Plugin>()
         {
             public boolean apply(final Plugin plugin)
             {
                 return pluginPredicate.matches(plugin);
             }
         }));
     }
 
     /**
      * @see PluginAccessor#getEnabledPlugins()
      */
     public Collection<Plugin> getEnabledPlugins()
     {
         return getPlugins(new EnabledPluginPredicate(this));
     }
 
     /**
      * @see PluginAccessor#getModules(com.atlassian.plugin.predicate.ModuleDescriptorPredicate)
      * @since 0.17
      */
     public <M> Collection<M> getModules(final ModuleDescriptorPredicate<M> moduleDescriptorPredicate)
     {
         return copyOf(getModules(getModuleDescriptors(getPlugins(), moduleDescriptorPredicate)));
     }
 
     /**
      * @see PluginAccessor#getModuleDescriptors(com.atlassian.plugin.predicate.ModuleDescriptorPredicate)
      * @since 0.17
      */
     public <M> Collection<ModuleDescriptor<M>> getModuleDescriptors(final ModuleDescriptorPredicate<M> moduleDescriptorPredicate)
     {
         return copyOf(getModuleDescriptors(getPlugins(), moduleDescriptorPredicate));
     }
 
     /**
      * Get the all the module descriptors from the given collection of plugins,
      * filtered by the predicate.
      * <p>
      * Be careful, your predicate must filter ModuleDescriptors that are not M,
      * this method does not guarantee that the descriptors are of the correct
      * type by itself.
      *
      * @param plugins a collection of {@link Plugin}s
      * @return a collection of {@link ModuleDescriptor descriptors}
      */
     private <M> Iterable<ModuleDescriptor<M>> getModuleDescriptors(final Collection<Plugin> plugins, final ModuleDescriptorPredicate<M> predicate)
     {
         // hack way to get typed descriptors from plugin and
         // keep generics happy
         final Function<ModuleDescriptor<?>, ModuleDescriptor<M>> coercer = new Function<ModuleDescriptor<?>, ModuleDescriptor<M>>()
         {
             public ModuleDescriptor<M> apply(final ModuleDescriptor<?> input)
             {
                 @SuppressWarnings("unchecked")
                 final ModuleDescriptor<M> result = (ModuleDescriptor<M>) input;
                 return result;
             }
         };
 
         // google predicate adapter
         final Predicate<ModuleDescriptor<M>> adapter = new Predicate<ModuleDescriptor<M>>()
         {
             public boolean apply(final ModuleDescriptor<M> input)
             {
                 return predicate.matches(input);
             }
         };
 
         // get the filtered module descriptors from a plugin
         final Function<Plugin, Iterable<ModuleDescriptor<M>>> descriptorExtractor = new Function<Plugin, Iterable<ModuleDescriptor<M>>>()
         {
             public Iterable<ModuleDescriptor<M>> apply(final Plugin plugin)
             {
                 return filter(transform(plugin.getModuleDescriptors(), coercer), adapter);
             }
         };
 
         // concatenate all the descriptor iterables into one
         return concat(transform(plugins, descriptorExtractor));
     }
 
     /**
      * Get the modules of all the given descriptor. If any of the getModule()
      * calls fails, the error is recorded in the logs and the plugin is
      * disabled.
      *
      * @param moduleDescriptors the collection of module descriptors to get the
      *            modules from.
      * @return a {@link Collection} modules that can be any type of object. This
      *         collection will not contain any null value.
      */
     private <M> Iterable<M> getModules(final Iterable<ModuleDescriptor<M>> moduleDescriptors)
     {
         return filter(transform(moduleDescriptors, new Function<ModuleDescriptor<M>, M>()
         {
             private final Set<String> disabled = new HashSet<String>();
             public M apply(final ModuleDescriptor<M> input)
             {
                 try
                 {
                     return input.getModule();
                 }
                 catch (final RuntimeException ex)
                 {
                     final String key = input.getPlugin().getKey();
                     log.error("Exception when retrieving plugin module {}", input.getKey(), ex);
                     if (disabled.contains(key))
                     {
                         return null;
                     }
 
                     log.error("Disabling plugin {}", key);
                     disabled.add(key);
                     disablePlugin(key);
                     return null;
                 }
             }
         }), Predicates.notNull());
     }
 
     public Plugin getPlugin(final String key)
     {
         return plugins.get(notNull("The plugin key must be specified", key));
     }
 
     public Plugin getEnabledPlugin(final String pluginKey)
     {
         if (!isPluginEnabled(pluginKey))
         {
             return null;
         }
         return getPlugin(pluginKey);
     }
 
     public ModuleDescriptor<?> getPluginModule(final String completeKey)
     {
         return getPluginModule(new ModuleCompleteKey(completeKey));
     }
 
     private ModuleDescriptor<?> getPluginModule(final ModuleCompleteKey key)
     {
         final Plugin plugin = getPlugin(key.getPluginKey());
         if (plugin == null)
         {
             return null;
         }
         return plugin.getModuleDescriptor(key.getModuleKey());
     }
 
     public ModuleDescriptor<?> getEnabledPluginModule(final String completeKey)
     {
         final ModuleCompleteKey key = new ModuleCompleteKey(completeKey);
 
         // If it's disabled, return null
         if (!isPluginModuleEnabled(key))
         {
             return null;
         }
 
         return getEnabledPlugin(key.getPluginKey()).getModuleDescriptor(key.getModuleKey());
     }
 
     /**
      * @see PluginAccessor#getEnabledModulesByClass(Class)
      */
     public <M> List<M> getEnabledModulesByClass(final Class<M> moduleClass)
     {
         return copyOf(getModules(getEnabledModuleDescriptorsByModuleClass(moduleClass)));
     }
 
     /**
      * @see PluginAccessor#getEnabledModulesByClassAndDescriptor(Class[], Class)
      * @deprecated since 0.17, use
      *             {@link #getModules(com.atlassian.plugin.predicate.ModuleDescriptorPredicate)}
      *             with an appropriate predicate instead.
      */
     @Deprecated
     public <M> List<M> getEnabledModulesByClassAndDescriptor(final Class<ModuleDescriptor<M>>[] descriptorClasses, final Class<M> moduleClass)
     {
         final Iterable<ModuleDescriptor<M>> moduleDescriptors = filterDescriptors(getEnabledModuleDescriptorsByModuleClass(moduleClass), new ModuleDescriptorOfClassPredicate<M>(descriptorClasses));
 
         return copyOf(getModules(moduleDescriptors));
     }
 
     /**
      * @see PluginAccessor#getEnabledModulesByClassAndDescriptor(Class, Class)
      * @deprecated since 0.17, use
      *             {@link #getModules(com.atlassian.plugin.predicate.ModuleDescriptorPredicate)}
      *             with an appropriate predicate instead.
      */
     @Deprecated
     public <M> List<M> getEnabledModulesByClassAndDescriptor(final Class<ModuleDescriptor<M>> descriptorClass, final Class<M> moduleClass)
     {
         final Iterable<ModuleDescriptor<M>> moduleDescriptors = getEnabledModuleDescriptorsByModuleClass(moduleClass);
         return copyOf(getModules(filterDescriptors(moduleDescriptors, new ModuleDescriptorOfClassPredicate<M>(
                 descriptorClass))));
     }
 
     /**
      * Get all module descriptor that are enabled and for which the module is an
      * instance of the given class.
      *
      * @param moduleClass the class of the module within the module descriptor.
      * @return a collection of {@link ModuleDescriptor}s
      */
     private <M> Collection<ModuleDescriptor<M>> getEnabledModuleDescriptorsByModuleClass(final Class<M> moduleClass)
     {
         final ModuleOfClassPredicate<M> ofType = new ModuleOfClassPredicate<M>(moduleClass);
         final EnabledModulePredicate<M> enabled = new EnabledModulePredicate<M>(this);
         return copyOf(getModuleDescriptors(getEnabledPlugins(), new ModuleDescriptorPredicate<M>()
         {
             public boolean matches(final ModuleDescriptor<? extends M> moduleDescriptor)
             {
                 return ofType.matches(moduleDescriptor) && enabled.matches(moduleDescriptor);
             }
         }));
     }
 
     /**
      * This method has been reverted to pre PLUG-40 to fix performance issues
      * that were encountered during load testing. This should be reverted to the
      * state it was in at 54639 when the fundamental issue leading to this
      * slowdown has been corrected (that is, slowness of PluginClassLoader).
      *
      * @see PluginAccessor#getEnabledModuleDescriptorsByClass(Class)
      */
     public <D extends ModuleDescriptor<?>> List<D> getEnabledModuleDescriptorsByClass(final Class<D> descriptorClazz)
     {
         final List<D> result = new LinkedList<D>();
         for (final Plugin plugin : plugins.values())
         {
             // Skip disabled plugins
             if (!isPluginEnabled(plugin.getKey()))
             {
                 if (log.isDebugEnabled())
                 {
                     log.debug("Plugin [" + plugin.getKey() + "] is disabled.");
                 }
                 continue;
             }
 
             for (final ModuleDescriptor<?> module : plugin.getModuleDescriptors())
             {
                 if (descriptorClazz.isInstance(module))
                 {
                     if (isPluginModuleEnabled(module.getCompleteKey()))
                     {
                         result.add(descriptorClazz.cast(module));
                     }
                     else if (log.isDebugEnabled())
                     {
                         log.debug("Module [" + module.getCompleteKey() + "] is disabled.");
                     }
                 }
             }
         }
 
         return result;
     }
 
     public <D extends ModuleDescriptor<?>> List<D> getEnabledModuleDescriptorsByClass(final Class<D> descriptorClazz, final boolean verbose)
     {
         return getEnabledModuleDescriptorsByClass(descriptorClazz);
     }
 
     /**
      * @see PluginAccessor#getEnabledModuleDescriptorsByType(String)
      * @deprecated since 0.17, use
      *             {@link #getModuleDescriptors(com.atlassian.plugin.predicate.ModuleDescriptorPredicate)}
      *             with an appropriate predicate instead.
      */
     @Deprecated
     public <M> List<ModuleDescriptor<M>> getEnabledModuleDescriptorsByType(final String type) throws PluginParseException, IllegalArgumentException
     {
         final ModuleDescriptorOfTypePredicate<M> ofType = new ModuleDescriptorOfTypePredicate<M>(moduleDescriptorFactory, type);
         final EnabledModulePredicate<M> enabled = new EnabledModulePredicate<M>(this);
         return copyOf(getModuleDescriptors(getEnabledPlugins(), new ModuleDescriptorPredicate<M>()
         {
             public boolean matches(final ModuleDescriptor<? extends M> moduleDescriptor)
             {
                 return ofType.matches(moduleDescriptor) && enabled.matches(moduleDescriptor);
             }
         }));
     }
 
     /**
      * Filters out a collection of {@link ModuleDescriptor}s given a predicate.
      *
      * @param descriptors the collection of {@link ModuleDescriptor}s to filter.
      * @param predicate the predicate to use for filtering.
      */
     private static <M> Iterable<ModuleDescriptor<M>> filterDescriptors(final Iterable<ModuleDescriptor<M>> descriptors, final ModuleDescriptorPredicate<M> predicate)
     {
         return filter(descriptors, new Predicate<ModuleDescriptor<M>>()
         {
             public boolean apply(final ModuleDescriptor<M> input)
             {
                 return predicate.matches(input);
             }
         });
     }
 
     /**
      * Enable a set of plugins by key. This will implicitly and recursively
      * enable all dependent plugins.
      *
      * @param keys The plugin keys. Must not be null.
      * @since 2.5.0
      */
     public void enablePlugins(final String... keys)
     {
         final Collection<Plugin> pluginsToEnable = new ArrayList<Plugin>(keys.length);
 
         for (final String key : keys)
         {
             if (key == null)
             {
                 throw new IllegalArgumentException("Keys passed to enablePlugins must be non-null");
             }
 
             final Plugin plugin = plugins.get(key);
             if (plugin == null)
             {
                 final Plugin delayedPlugin = findDelayedPlugin(key);
                 if (delayedPlugin == null)
                 {
                     log.info("No plugin was found for key '{}'. Not enabling.", key);
                 }
                 else
                 {
                     enablePluginState(delayedPlugin, getStore());
                 }
                 continue;
             }
 
             if (!plugin.getPluginInformation().satisfiesMinJavaVersion())
             {
                 log.error("Minimum Java version of '" + plugin.getPluginInformation().getMinJavaVersion() + "' was not satisfied for module '" + key + "'. Not enabling.");
                 continue;
             }
 
             //Do not enable if already enabled, which inturn will prevent the notify
             if(plugin.getPluginState() != PluginState.ENABLED)
             {
                 pluginsToEnable.add(plugin);
             }
         }
         final Collection<Plugin> enabledPlugins = pluginEnabler.enableAllRecursively(pluginsToEnable);
 
         for (final Plugin plugin : enabledPlugins)
         {
             enablePluginState(plugin, getStore());
             notifyPluginEnabled(plugin);
         }
     }
 
     /**
      * @deprecated since 2.5.0, use {#link enablePlugins(String... keys)} instead
      */
     @Deprecated
     public void enablePlugin(final String key)
     {
         enablePlugins(key);
     }
 
     protected void enablePluginState(final Plugin plugin, final PluginPersistentStateStore stateStore)
     {
         stateStore.save(getBuilder().setEnabled(plugin, true).toState());
     }
 
     /**
      * Called on all clustered application nodes, rather than
      * {@link #enablePlugin(String)} to just update the local state, state aware
      * modules and loaders, but not affect the global plugin state.
      *
      * @param plugin the plugin being enabled
      */
     protected void notifyPluginEnabled(final Plugin plugin)
     {
         plugin.enable();
         if (enableConfiguredPluginModules(plugin))
         {
             pluginEventManager.broadcast(new PluginEnabledEvent(plugin));
         }
     }
 
     /**
      * For each module in the plugin, call the module descriptor's enabled()
      * method if the module is StateAware and enabled.
      * <p>
      * If any modules fail to enable then the plugin is replaced by an
      * UnloadablePlugin, and this method will return {@code false}.
      *
      * @param plugin the plugin to enable
      * @return true if the modules were all enabled correctly, false otherwise.
      */
     private boolean enableConfiguredPluginModules(final Plugin plugin)
     {
         boolean success = true;
         final Set<ModuleDescriptor<?>> enabledDescriptors = new HashSet<ModuleDescriptor<?>>();
         for (final ModuleDescriptor<?> descriptor : plugin.getModuleDescriptors())
         {
             if (!enableConfiguredPluginModule(plugin, descriptor, enabledDescriptors))
             {
                 success = false;
                 break;
             }
         }
         return success;
     }
 
     private boolean enableConfiguredPluginModule(final Plugin plugin, final ModuleDescriptor<?> descriptor, final Set<ModuleDescriptor<?>> enabledDescriptors)
     {
         try
         {
             // This can happen if the plugin available event is fired as part of the plugin initialization process
             if (pluginEnabler.isPluginBeingEnabled(plugin))
             {
                 log.debug("The plugin is currently being enabled, so we won't bother trying to enable the '{}' module",
                         descriptor.getKey());
                 return true;
             }
 
             // We only want to re-enable modules that weren't explicitly
             // disabled by the user.
             if (!isPluginModuleEnabled(descriptor.getCompleteKey()))
             {
                 log.debug("Plugin module '{}' is explicitly disabled (or so by default), so not re-enabling.",
                         descriptor.getName() == null ? descriptor.getKey() : descriptor.getName());
                 return true;
             }
 
             notifyModuleEnabled(descriptor);
             enabledDescriptors.add(descriptor);
 
             return true;
         }
         catch (final Throwable enableException)
         {
             // catch any errors and insert an UnloadablePlugin (PLUG-7)
             log.error("There was an error loading the descriptor '{}' of plugin '{}'. Disabling.",
                     new Object[] { descriptor.getName(), plugin.getKey(), enableException });
 
             // Disable all previously enabled descriptors
             for (final ModuleDescriptor<?> descriptorToDisable : enabledDescriptors)
             {
                 try
                 {
                     notifyModuleDisabled(descriptorToDisable);
                 }
                 catch (final Exception disableException)
                 {
                     log.error("Could not notify previously enabled descriptor {} of module disabled in plugin {}",
                             descriptorToDisable.getName(), plugin.getKey());
                     log.info("Stacktrace : ", disableException);
                 }
             }
 
             //use the original exception
             replacePluginWithUnloadablePlugin(plugin, descriptor, enableException);
             return false;
         }
     }
 
     public void disablePlugin(final String key)
     {
         disablePluginInternal(key, true);
     }
 
     public void disablePluginWithoutPersisting(final String key)
     {
         disablePluginInternal(key, false);
     }
 
     protected void disablePluginInternal(final String key, final boolean persistDisabledState)
     {
         if (key == null)
         {
             throw new IllegalArgumentException("You must specify a plugin key to disable.");
         }
 
         final Plugin plugin = plugins.get(key);
         if (plugin == null)
         {
             final Plugin delayedPlugin = findDelayedPlugin(key);
             if (delayedPlugin == null)
             {
                 log.info("No plugin was found for key '{}'. Not disabling.", key);
             }
             else
             {
                 if (persistDisabledState)
                 {
                     disablePluginState(delayedPlugin, getStore());
                 }
             }
             return;
         }
 
         //Do not disable if the plugin is already disabled
         if(plugin.getPluginState() != PluginState.DISABLED)
         {
             notifyPluginDisabled(plugin);
             if (persistDisabledState)
             {
                 disablePluginState(plugin, getStore());
             }
         }
     }
 
     private Plugin findDelayedPlugin(final String key) {
         return tryFind(delayedPlugins, new Predicate<Plugin>() {
                     @Override
                     public boolean apply(final Plugin input) {
                         return input.getKey().equals(key);
                     }
                 }).orNull();
     }
 
     protected void disablePluginState(final Plugin plugin, final PluginPersistentStateStore stateStore)
     {
         stateStore.save(getBuilder().setEnabled(plugin, false).toState());
     }
 
     protected void notifyPluginDisabled(final Plugin plugin)
     {
         if (log.isInfoEnabled())
         {
             log.info("Disabling " + plugin.getKey());
         }
         broadcastIgnoreError(new BeforePluginDisabledEvent(plugin));
         disablePluginModules(plugin);
 
         // This needs to happen after modules are disabled to prevent errors
         plugin.disable();
         broadcastIgnoreError(new PluginDisabledEvent(plugin));
     }
 
     private void disablePluginModules(final Plugin plugin)
     {
         final List<ModuleDescriptor<?>> moduleDescriptors = new ArrayList<ModuleDescriptor<?>>(plugin.getModuleDescriptors());
         Collections.reverse(moduleDescriptors); // disable in reverse order
 
         for (final ModuleDescriptor<?> module : moduleDescriptors)
         {
             // don't actually disable the module, just fire the events because
             // its plugin is being disabled
             // if the module was actually disabled, you'd have to reenable each
             // one when enabling the plugin
 
             disablePluginModuleNoPersist(module);
         }
     }
 
     private void disablePluginModuleNoPersist(final ModuleDescriptor<?> module)
     {
         if (isPluginModuleEnabled(module.getCompleteKey()))
         {
             publishModuleDisabledEvents(module, false);
         }
     }
 
     public void disablePluginModule(final String completeKey)
     {
         if (completeKey == null)
         {
             throw new IllegalArgumentException("You must specify a plugin module key to disable.");
         }
 
         final ModuleDescriptor<?> module = getPluginModule(completeKey);
 
         if (module == null)
         {
             if (log.isInfoEnabled())
             {
                 log.info("Returned module for key '" + completeKey + "' was null. Not disabling.");
             }
             return;
         }
         if (module.getClass().isAnnotationPresent(CannotDisable.class))
         {
             if (log.isInfoEnabled())
             {
                 log.info("Plugin module " + completeKey + " cannot be disabled; it is annotated with" + CannotDisable.class.getName());
             }
             return;
         }
         disablePluginModuleState(module, getStore());
         notifyModuleDisabled(module);
     }
 
     protected void disablePluginModuleState(final ModuleDescriptor<?> module, final PluginPersistentStateStore stateStore)
     {
         stateStore.save(getBuilder().setEnabled(module, false).toState());
     }
 
     protected void notifyModuleDisabled(final ModuleDescriptor<?> module)
     {
         publishModuleDisabledEvents(module, true);
     }
 
     private void publishModuleDisabledEvents(final ModuleDescriptor<?> module, final boolean persistent)
     {
         if (log.isDebugEnabled())
         {
             log.debug("Disabling " + module.getKey());
         }
         broadcastIgnoreError(new BeforePluginModuleDisabledEvent(module, persistent));
 
         if (module instanceof StateAware)
         {
             ((StateAware) module).disabled();
         }
 
         broadcastIgnoreError(new PluginModuleDisabledEvent(module, persistent));
     }
 
     public void enablePluginModule(final String completeKey)
     {
         if (completeKey == null)
         {
             throw new IllegalArgumentException("You must specify a plugin module key to disable.");
         }
 
         final ModuleDescriptor<?> module = getPluginModule(completeKey);
 
         if (module == null)
         {
             if (log.isInfoEnabled())
             {
                 log.info("Returned module for key '" + completeKey + "' was null. Not enabling.");
             }
 
             return;
         }
 
         if (!module.satisfiesMinJavaVersion())
         {
             log.error("Minimum Java version of '" + module.getMinJavaVersion() + "' was not satisfied for module '" + completeKey + "'. Not enabling.");
             return;
         }
         enablePluginModuleState(module, getStore());
         notifyModuleEnabled(module);
     }
 
     protected void enablePluginModuleState(final ModuleDescriptor<?> module, final PluginPersistentStateStore stateStore)
     {
         stateStore.save(getBuilder().setEnabled(module, true).toState());
     }
 
     protected void notifyModuleEnabled(final ModuleDescriptor<?> module)
     {
         if (log.isDebugEnabled())
         {
             log.debug("Enabling " + module.getKey());
         }
         if (module instanceof StateAware)
         {
             ((StateAware) module).enabled();
         }
         pluginEventManager.broadcast(new PluginModuleEnabledEvent(module));
     }
 
     public boolean isPluginModuleEnabled(final String completeKey)
     {
         // completeKey may be null
         return (completeKey != null) && isPluginModuleEnabled(new ModuleCompleteKey(completeKey));
     }
 
     private boolean isPluginModuleEnabled(final ModuleCompleteKey key)
     {
         if (!isPluginEnabled(key.getPluginKey()))
         {
             return false;
         }
         final ModuleDescriptor<?> pluginModule = getPluginModule(key);
         return (pluginModule != null) && getState().isEnabled(pluginModule);
     }
 
     /**
      * This method checks to see if the plugin is enabled based on the state
      * manager and the plugin.
      *
      * @param key The plugin key
      * @return True if the plugin is enabled
      */
     public boolean isPluginEnabled(final String key)
     {
         final Plugin plugin = plugins.get(notNull("The plugin key must be specified", key));
 
         return plugin != null &&
                plugin.getPluginState() == PluginState.ENABLED &&
                getState().isEnabled(plugin) &&
                !pluginEnabler.isPluginBeingEnabled(plugin);
     }
 
     public InputStream getDynamicResourceAsStream(final String name)
     {
         return getClassLoader().getResourceAsStream(name);
     }
 
     public Class<?> getDynamicPluginClass(final String className) throws ClassNotFoundException
     {
         return getClassLoader().loadClass(className);
     }
 
     public PluginsClassLoader getClassLoader()
     {
         return classLoader;
     }
 
     public InputStream getPluginResourceAsStream(final String pluginKey, final String resourcePath)
     {
         final Plugin plugin = getEnabledPlugin(pluginKey);
         if (plugin == null)
         {
             log.error("Attempted to retreive resource " + resourcePath + " for non-existent or inactive plugin " + pluginKey);
             return null;
         }
 
         return plugin.getResourceAsStream(resourcePath);
     }
 
     /**
      * Disables and replaces a plugin currently loaded with an UnloadablePlugin.
      *
      * @param plugin the plugin to be replaced
      * @param descriptor the descriptor which caused the problem
      * @param throwable the problem caught when enabling the descriptor
      * @return the UnloadablePlugin which replaced the broken plugin
      */
     private UnloadablePlugin replacePluginWithUnloadablePlugin(final Plugin plugin, final ModuleDescriptor<?> descriptor, final Throwable throwable)
     {
         final UnloadableModuleDescriptor unloadableDescriptor = UnloadableModuleDescriptorFactory.createUnloadableModuleDescriptor(plugin,
                 descriptor, throwable);
         final UnloadablePlugin unloadablePlugin = UnloadablePluginFactory.createUnloadablePlugin(plugin, unloadableDescriptor);
 
         // Add the error text at the plugin level as well. This is useful for
         // logging.
         unloadablePlugin.setErrorText(unloadableDescriptor.getErrorText());
         plugins.put(plugin.getKey(), unloadablePlugin);
 
         // PLUG-390: We used to persist the disabled state here, but we don't
         // want to do this.
         // We want to try load this plugin again on restart as the user may have
         // installed a fixed version of this plugin.
         return unloadablePlugin;
     }
 
     public boolean isSystemPlugin(final String key)
     {
         final Plugin plugin = getPlugin(key);
         return (plugin != null) && plugin.isSystemPlugin();
     }
 
     public PluginRestartState getPluginRestartState(final String key)
     {
         return getState().getPluginRestartState(key);
     }
 
     private Builder getBuilder()
     {
         return PluginPersistentState.Builder.create(getStore().load());
     }
 
     private void broadcastIgnoreError(final Object event)
     {
         try
         {
             pluginEventManager.broadcast(event);
         }
         catch (final NotificationException ex)
         {
             log.warn("Error broadcasting '{}': {}.  Continuing anyway.",  event.getClass().getName(), ex.getMessage());
             if (log.isDebugEnabled())
             {
                 log.debug(ex.getMessage(), ex);
             }
         }
     }
 
     /**
      * @deprecated Since 2.0.0.beta2
      */
     @Deprecated
     public void setDescriptorParserFactory(final DescriptorParserFactory descriptorParserFactory)
     {
     }
 }