Checkstyle Results

The following document contains the results of Checkstylerss feed

Summary

Files Infos info Warnings warning Errors error
19 0 0 490

Rules

Rules Violations Severity
PackageHtml 4 error Error
NewlineAtEndOfFile 1 error Error
Translation 0 error Error
JavadocMethod 58 error Error
JavadocType 7 error Error
JavadocVariable 22 error Error
JavadocStyle 0 error Error
ConstantName 4 error Error
LocalFinalVariableName 0 error Error
LocalVariableName 0 error Error
MemberName 0 error Error
MethodName 0 error Error
PackageName 0 error Error
ParameterName 0 error Error
StaticVariableName 0 error Error
TypeName 0 error Error
AvoidStarImport 2 error Error
IllegalImport 0 error Error
RedundantImport 1 error Error
UnusedImports 2 error Error
FileLength 0 error Error
LineLength 136 error Error
MethodLength 0 error Error
ParameterNumber 0 error Error
EmptyForIteratorPad 0 error Error
MethodParamPad 0 error Error
NoWhitespaceAfter 0 error Error
NoWhitespaceBefore 0 error Error
OperatorWrap 1 error Error
ParenPad 0 error Error
TypecastParenPad 0 error Error
TabCharacter 4 error Error
WhitespaceAfter 6 error Error
WhitespaceAround 29 error Error
ModifierOrder 0 error Error
RedundantModifier 0 error Error
AvoidNestedBlocks 0 error Error
EmptyBlock 0 error Error
LeftCurly 86 error Error
NeedBraces 17 error Error
RightCurly 11 error Error
AvoidInlineConditionals 2 error Error
DoubleCheckedLocking 0 error Error
EmptyStatement 0 error Error
EqualsHashCode 0 error Error
HiddenField 6 error Error
IllegalInstantiation 0 error Error
InnerAssignment 0 error Error
MagicNumber 0 error Error
MissingSwitchDefault 0 error Error
RedundantThrows 1 error Error
SimplifyBooleanExpression 0 error Error
SimplifyBooleanReturn 0 error Error
DesignForExtension 23 error Error
FinalClass 0 error Error
HideUtilityClassConstructor 1 error Error
InterfaceIsType 0 error Error
VisibilityModifier 1 error Error
ArrayTypeStyle 0 error Error
FinalParameters 60 error Error
GenericIllegalRegexp
  • message : "Line has trailing spaces."
  • format : "\s+$"
5 error Error
TodoComment 0 error Error
UpperEll 0 error Error

Details

com/atlassian/xwork/results/CSSVelocityResult.java

Violation Message Line
error Missing a Javadoc comment. 5
error '{' should be on the previous line. 6
error Method 'getContentType' is not designed for extension - needs to be abstract, final or empty. 7
error Missing a Javadoc comment. 7
error Parameter s should be final. 7
error '{' should be on the previous line. 8

com/atlassian/xwork/results/package.html

Violation Message Line
error Missing package documentation file. 0

com/atlassian/xwork/FileUploadUtils.java

Violation Message Line
error Using the '.*' form of import should be avoided - java.util.*. 7
error Missing a Javadoc comment. 11
error Utility classes should not have a public or default constructor. 11
error '{' should be on the previous line. 12
error Missing a Javadoc comment. 13
error Missing a Javadoc comment. 15
error '{' should be on the previous line. 16
error Avoid inline conditionals. 18
error Line is longer than 80 characters. 21
error Missing a Javadoc comment. 21
error Line is longer than 80 characters. 23
error Line is longer than 80 characters. 25
error 'if' construct must use '{}'s. 27
error Line is longer than 80 characters. 34
error Line is longer than 80 characters. 37
error Parameter multiWrapper should be final. 37
error Expected @param tag for 'multiWrapper'. 37
error Expected @throws tag for 'FileUploadException'. 37
error '{' should be on the previous line. 40
error '{' should be on the previous line. 46
error 'cast' is not followed by whitespace. 47
error Line is longer than 80 characters. 57
error Missing a Javadoc comment. 57
error Parameter multiWrapper should be final. 57
error Parameter clean should be final. 57
error '{' should be on the previous line. 59
error '{' should be on the previous line. 66
error 'cast' is not followed by whitespace. 68
error Line is longer than 80 characters. 73
error '=' is not preceded with whitespace. 73
error '=' is not followed by whitespace. 73
error '<' is not preceded with whitespace. 73
error '<' is not followed by whitespace. 73
error '{' should be on the previous line. 79
error Line is longer than 80 characters. 80
error Line is longer than 80 characters. 81
error '}' should be on the same line. 83
error '{' should be on the previous line. 85
error Line is longer than 80 characters. 86
error Line is longer than 80 characters. 89
error Line is longer than 80 characters. 90
error 'cast' is not followed by whitespace. 95
error Missing a Javadoc comment. 98
error '{' should be on the previous line. 99
error Missing a Javadoc comment. 100
error Missing a Javadoc comment. 101
error Missing a Javadoc comment. 102
error Missing a Javadoc comment. 104
error Parameter file should be final. 104
error 'file' hides a field. 104
error Parameter fileName should be final. 104
error 'fileName' hides a field. 104
error Parameter contentType should be final. 104
error 'contentType' hides a field. 104
error '{' should be on the previous line. 105
error Missing a Javadoc comment. 111
error '{' should be on the previous line. 112
error Missing a Javadoc comment. 116
error '{' should be on the previous line. 117
error Missing a Javadoc comment. 121
error '{' should be on the previous line. 122
error Missing a Javadoc comment. 127
error '{' should be on the previous line. 128
error Missing a Javadoc comment. 129
error Missing a Javadoc comment. 131
error Parameter error should be final. 131
error '{' should be on the previous line. 132
error Missing a Javadoc comment. 136
error '{' should be on the previous line. 137
error 'cast' is not followed by whitespace. 138
error Missing a Javadoc comment. 141
error '{' should be on the previous line. 142
error '{' should be on the previous line. 146

com/atlassian/xwork/interceptors/XWorkTransactionInterceptor.java

Violation Message Line
error Unused import - com.opensymphony.xwork.interceptor.PreResultListener. 5
error Unused import - org.apache.log4j.Logger. 6
error Line is longer than 80 characters. 11
error Line is longer than 80 characters. 14
error Line is longer than 80 characters. 15
error Line is longer than 80 characters. 16
error Line is longer than 80 characters. 19
error Line is longer than 80 characters. 22
error Line is longer than 80 characters. 23
error '{' should be on the previous line. 27
error Line is longer than 80 characters. 29
error Line is longer than 80 characters. 36
error Line is longer than 80 characters. 37
error Missing a Javadoc comment. 45
error '{' should be on the previous line. 46
error Missing a Javadoc comment. 49
error '{' should be on the previous line. 50
error Method 'intercept' is not designed for extension - needs to be abstract, final or empty. 53
error Missing a Javadoc comment. 53
error 'if' construct must use '{}'s. 55
error Line is longer than 80 characters. 56
error 'else' construct must use '{}'s. 57
error Line is longer than 80 characters. 67
error Line is longer than 80 characters. 70
error Line is longer than 80 characters. 72
error Redundant throws: 'RuntimeException' is unchecked exception. 72
error Line is longer than 80 characters. 74
error 'if' construct must use '{}'s. 75

com/atlassian/xwork/PellMultiPartRequest.java

Violation Message Line
error Line is longer than 80 characters. 16
error Line is longer than 80 characters. 17
error Line is longer than 80 characters. 20
error '{' should be on the previous line. 23
error Line is longer than 80 characters. 24
error Missing a Javadoc comment. 26
error Line is longer than 80 characters. 28
error Line is longer than 80 characters. 31
error Line is longer than 80 characters. 38
error Parameter servletRequest should be final. 38
error Parameter saveDir should be final. 38
error Parameter maxSize should be final. 38
error Expected @throws tag for 'IOException'. 38
error Line is longer than 80 characters. 39
error Line is longer than 80 characters. 40
error Line is longer than 80 characters. 43
error Line is longer than 80 characters. 47
error Method 'getFileParameterNames' is not designed for extension - needs to be abstract, final or empty. 49
error Missing a Javadoc comment. 49
error Method 'getContentType' is not designed for extension - needs to be abstract, final or empty. 53
error Missing a Javadoc comment. 53
error Parameter fieldName should be final. 53
error Method 'getFile' is not designed for extension - needs to be abstract, final or empty. 57
error Missing a Javadoc comment. 57
error Parameter fieldName should be final. 57
error Method 'getFileNames' is not designed for extension - needs to be abstract, final or empty. 61
error Missing a Javadoc comment. 61
error Parameter fieldName should be final. 61
error Line is longer than 80 characters. 62
error Line is longer than 80 characters. 63
error 'if' construct must use '{}'s. 65
error Method 'getFilesystemName' is not designed for extension - needs to be abstract, final or empty. 71
error Missing a Javadoc comment. 71
error Parameter fieldName should be final. 71
error Method 'getParameter' is not designed for extension - needs to be abstract, final or empty. 75
error Missing a Javadoc comment. 75
error Parameter name should be final. 75
error Method 'getParameterNames' is not designed for extension - needs to be abstract, final or empty. 79
error Missing a Javadoc comment. 79
error Method 'getParameterValues' is not designed for extension - needs to be abstract, final or empty. 83
error Missing a Javadoc comment. 83
error Parameter name should be final. 83
error Line is longer than 80 characters. 100
error Line is longer than 80 characters. 103
error Line is longer than 80 characters. 113
error Line is longer than 80 characters. 116
error Line is longer than 80 characters. 118
error Line is longer than 80 characters. 121
error Line is longer than 80 characters. 123

com/atlassian/xwork/ParameterSafe.java

Violation Message Line
error Line is longer than 80 characters. 9
error Line is longer than 80 characters. 10
error '}' is not preceded with whitespace. 16
error '{' should be on the previous line. 18

com/atlassian/xwork/validator/validators/package.html

Violation Message Line
error Missing package documentation file. 0

com/atlassian/xwork/interceptors/TransactionalInvocation.java

Violation Message Line
error Line is longer than 80 characters. 15
error '{' should be on the previous line. 19
error Line is longer than 80 characters. 20
error Missing a Javadoc comment. 20
error Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 20
error Line is longer than 80 characters. 22
error Missing a Javadoc comment. 22
error Line is longer than 80 characters. 23
error Name 'currentTransactionThreadLocal' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 24
error Missing a Javadoc comment. 25
error Missing a Javadoc comment. 27
error Line is longer than 80 characters. 29
error Missing a Javadoc comment. 29
error Parameter transactionManager should be final. 29
error 'transactionManager' hides a field. 29
error Line is longer than 80 characters. 34
error Missing a Javadoc comment. 34
error 'if' construct must use '{}'s. 36
error Line is longer than 80 characters. 37
error Line is longer than 80 characters. 39
error Line is longer than 80 characters. 42
error Line is longer than 80 characters. 43
error Line is longer than 80 characters. 47
error Parameter actionInvocation should be final. 47
error Parameter s should be final. 47
error 'if' construct must use '{}'s. 51
error Line is longer than 80 characters. 52
error '{' should be on the previous line. 59
error '}' should be on the same line. 61
error '{' should be on the previous line. 63
error Line is longer than 80 characters. 69
error Missing a Javadoc comment. 69
error Parameter invocation should be final. 69
error '{' should be on the previous line. 72
error '}' should be on the same line. 74
error '{' should be on the previous line. 76
error Line is longer than 80 characters. 77
error Missing a Javadoc comment. 82
error Parameter actionInvocation should be final. 82
error Line is longer than 80 characters. 84
error '{' should be on the previous line. 86
error Line is longer than 80 characters. 87
error '{' should be on the previous line. 90
error 'if' construct must use '{}'s. 91
error Line is longer than 80 characters. 92
error '}' should be on the same line. 95
error '{' should be on the previous line. 97
error 'if' construct must use '{}'s. 98
error Line is longer than 80 characters. 99
error Line is longer than 80 characters. 105
error Missing a Javadoc comment. 105
error Parameter invocation should be final. 105
error Parameter txAtt should be final. 105
error Parameter status should be final. 105
error Parameter ex should be final. 105
error 'if' construct must use '{}'s. 107
error '{' should be on the previous line. 111
error Line is longer than 80 characters. 112
error '}' should be on the same line. 114
error '{' should be on the previous line. 116
error Line is longer than 80 characters. 117
error Missing a Javadoc comment. 121
error '{' should be on the previous line. 122
error Missing a Javadoc comment. 126
error '{' should be on the previous line. 127
error Line is longer than 80 characters. 128
error Missing a Javadoc comment. 133
error Parameter transactionStatus should be final. 133
error 'transactionStatus' hides a field. 133
error '{' should be on the previous line. 134
error Missing a Javadoc comment. 139
error Parameter invocation should be final. 139
error '{' should be on the previous line. 140
error 'if' construct must use '{}'s. 144
error Line is longer than 80 characters. 147
error Line is longer than 80 characters. 149

com/atlassian/xwork/results/RssResult.java

Violation Message Line
error File does not end with a newline. 0
error Missing a Javadoc comment. 15
error Missing a Javadoc comment. 16
error Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 16
error Missing a Javadoc comment. 17
error Missing a Javadoc comment. 19
error Missing a Javadoc comment. 20
error Missing a Javadoc comment. 21
error Missing a Javadoc comment. 22
error Line is longer than 80 characters. 24
error Method 'doExecute' is not designed for extension - needs to be abstract, final or empty. 24
error Missing a Javadoc comment. 24
error Parameter finalDestination should be final. 24
error Parameter actionInvocation should be final. 24
error 'if' construct must use '{}'s. 29
error Line is longer than 80 characters. 30
error 'if' construct must use '{}'s. 31
error Line is longer than 80 characters. 32
error 'else' construct must use '{}'s. 33
error Line is longer than 80 characters. 34
error Line is longer than 80 characters. 36
error 'if' construct must use '{}'s. 37
error Line is longer than 80 characters. 46

com/atlassian/xwork/interceptors/RequestParameterHackInterceptor.java

Violation Message Line
error Using the '.*' form of import should be avoided - java.util.*. 7
error Line is longer than 80 characters. 10
error Line is longer than 80 characters. 11
error '{' should be on the previous line. 14
error Missing a Javadoc comment. 15
error Missing a Javadoc comment. 17
error Parameter hackMap should be final. 17
error '{' should be on the previous line. 18
error Line is longer than 80 characters. 19
error Method 'before' is not designed for extension - needs to be abstract, final or empty. 22
error Missing a Javadoc comment. 22
error Parameter invocation should be final. 22
error '{' should be on the previous line. 23
error Line is longer than 80 characters. 24
error '{' should be on the previous line. 27
error Line is longer than 80 characters. 31
error '{' should be on the previous line. 35
error Line is longer than 80 characters. 40
error '{' should be on the previous line. 42
error Line is longer than 80 characters. 44
error Line is longer than 80 characters. 53
error Line is longer than 80 characters. 57
error Missing a Javadoc comment. 57
error Parameter actionInvocation should be final. 57
error Parameter s should be final. 57

com/atlassian/xwork/interceptors/SafeParametersInterceptor.java

Violation Message Line
error Line is longer than 80 characters. 24
error Line is longer than 80 characters. 25
error Line is longer than 80 characters. 28
error Line is longer than 80 characters. 31
error Line is longer than 80 characters. 32
error Line is longer than 80 characters. 33
error Line is longer than 80 characters. 34
error Line is longer than 80 characters. 35
error Line is longer than 80 characters. 36
error Line is longer than 80 characters. 40
error '{' should be on the previous line. 43
error Line is longer than 80 characters. 44
error Missing a Javadoc comment. 44
error Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 44
error Line is longer than 80 characters. 46
error Missing a Javadoc comment. 46
error Line is longer than 80 characters. 47
error Missing a Javadoc comment. 47
error Line is longer than 80 characters. 49
error Missing a Javadoc comment. 49
error Parameter dispatcher should be final. 49
error Parameter result should be final. 49
error Line is longer than 80 characters. 54
error Line is longer than 80 characters. 55
error Line is longer than 80 characters. 58
error Line is longer than 80 characters. 61
error Line is longer than 80 characters. 63
error Line is longer than 80 characters. 66
error Line is longer than 80 characters. 68
error Line is longer than 80 characters. 73
error Method 'before' is not designed for extension - needs to be abstract, final or empty. 75
error Missing a Javadoc comment. 75
error Parameter invocation should be final. 75
error '{' should be on the previous line. 76
error '{' should be on the previous line. 79
error Line is longer than 80 characters. 86
error '<' is not preceded with whitespace. 86
error '<' is not followed by whitespace. 86
error '>' is not preceded with whitespace. 86
error '{' should be on the previous line. 91
error '{' should be on the previous line. 99
error Line is longer than 80 characters. 100
error Line is longer than 80 characters. 101
error Line is longer than 80 characters. 102
error '{' should be on the previous line. 105
error Line is longer than 80 characters. 106
error '<' is not preceded with whitespace. 108
error '<' is not followed by whitespace. 108
error '>' is not preceded with whitespace. 108
error '{' should be on the previous line. 109
error '}' should be on the same line. 115
error '{' should be on the previous line. 117
error Line is longer than 80 characters. 118
error Line is longer than 80 characters. 119
error Line is longer than 80 characters. 120
error Line is longer than 80 characters. 124
error Missing a Javadoc comment. 124
error '<' is not preceded with whitespace. 124
error '<' is not followed by whitespace. 124
error '>' is not preceded with whitespace. 124
error Parameter parameters should be final. 124
error '<' is not preceded with whitespace. 124
error '<' is not followed by whitespace. 124
error '>' is not preceded with whitespace. 124
error Parameter action should be final. 124
error '<' is not preceded with whitespace. 126
error '<' is not followed by whitespace. 126
error '>' is not preceded with whitespace. 126
error '<' is not preceded with whitespace. 126
error '<' is not followed by whitespace. 126
error '>' is not preceded with whitespace. 126
error '>' is not followed by whitespace. 126
error '<' is not preceded with whitespace. 128
error '<' is not followed by whitespace. 128
error '>' is not preceded with whitespace. 128
error '{' should be on the previous line. 129
error '{' should be on the previous line. 131
error Missing a Javadoc comment. 139
error Parameter key should be final. 139
error Parameter action should be final. 139
error '{' should be on the previous line. 140
error '{' should be on the previous line. 142
error '{' should be on the previous line. 147
error Missing a Javadoc comment. 154
error Parameter key should be final. 154
error Parameter action should be final. 154
error '{' should be on the previous line. 157
error '{' should be on the previous line. 163
error '{' should be on the previous line. 165
error '{' should be on the previous line. 167
error '}' should be on the same line. 169
error '{' should be on the previous line. 171
error Line is longer than 80 characters. 172
error '}' should be on the same line. 177
error '{' should be on the previous line. 179
error Line is longer than 80 characters. 180
error Missing a Javadoc comment. 186
error Parameter key should be final. 186
error '{' should be on the previous line. 187
error Line is longer than 80 characters. 188
error '}' should be on the same line. 191
error '{' should be on the previous line. 193
error Missing a Javadoc comment. 198
error Parameter writeMethod should be final. 198
error '{' should be on the previous line. 199
error '||' should be on a new line. 200
error Line is longer than 80 characters. 201

com/atlassian/xwork/results/XmlVelocityResult.java

Violation Message Line
error Redundant import from the same package - com.atlassian.xwork.results.ProfiledVelocityResult. 3
error Line is longer than 80 characters. 6
error Line is longer than 80 characters. 8
error '{' should be on the previous line. 11
error Method 'getContentType' is not designed for extension - needs to be abstract, final or empty. 12
error Missing a Javadoc comment. 12
error Parameter s should be final. 12
error '{' should be on the previous line. 13

com/atlassian/xwork/validator/validators/CommaSeparatedEmailValidator.java

Violation Message Line
error Line has trailing spaces. 2
error Line has trailing spaces. 12
error Line contains a tab character. 17
error Method 'validate' is not designed for extension - needs to be abstract, final or empty. 17
error Missing a Javadoc comment. 17
error Parameter object should be final. 17
error Line has trailing spaces. 30
error Line is longer than 80 characters. 31
error Line has trailing spaces. 32
error '=' is not preceded with whitespace. 34
error '=' is not followed by whitespace. 34
error Line contains a tab character. 35
error Line has trailing spaces. 38
error Line contains a tab character. 38
error Line contains a tab character. 40

com/atlassian/xwork/interceptors/CancelWorkflowInterceptor.java

Violation Message Line
error Missing a Javadoc comment. 9
error '{' should be on the previous line. 10
error Missing a Javadoc comment. 11
error Method 'intercept' is not designed for extension - needs to be abstract, final or empty. 13
error Missing a Javadoc comment. 13
error Parameter actionInvocation should be final. 13
error '{' should be on the previous line. 16
error 'if' construct must use '{}'s. 17
error Line is longer than 80 characters. 17

com/atlassian/xwork/results/ProfiledVelocityResult.java

Violation Message Line
error Line is longer than 80 characters. 11
error '{' should be on the previous line. 14
error Line is longer than 80 characters. 15
error Method 'doExecute' is not designed for extension - needs to be abstract, final or empty. 15
error Missing a Javadoc comment. 15
error Parameter finalLocation should be final. 15
error Parameter invocation should be final. 15
error '{' should be on the previous line. 20
error '}' should be on the same line. 22
error '{' should be on the previous line. 24
error Line is longer than 80 characters. 29
error Method 'getTemplate' is not designed for extension - needs to be abstract, final or empty. 29
error Missing a Javadoc comment. 29
error Parameter stack should be final. 29
error Parameter velocity should be final. 29
error Parameter invocation should be final. 29
error Parameter location should be final. 29
error '{' should be on the previous line. 33
error '}' should be on the same line. 35
error '{' should be on the previous line. 37

com/atlassian/xwork/interceptors/XWorkProfilingInterceptor.java

Violation Message Line
error Missing a Javadoc comment. 10
error '{' should be on the previous line. 11
error Missing a Javadoc comment. 12
error Variable 'location' must be private and have accessor methods. 12
error Method 'before' is not designed for extension - needs to be abstract, final or empty. 14
error Missing a Javadoc comment. 14
error Parameter actionInvocation should be final. 14
error '{' should be on the previous line. 15
error Line is longer than 80 characters. 17
error Line is longer than 80 characters. 20
error Method 'after' is not designed for extension - needs to be abstract, final or empty. 20
error Missing a Javadoc comment. 20
error Parameter actionInvocation should be final. 20
error Parameter string should be final. 20
error Missing a Javadoc comment. 25
error Parameter proxy should be final. 25
error '{' should be on the previous line. 26
error 'if' construct must use '{}'s. 29
error Line is longer than 80 characters. 32
error Line is longer than 80 characters. 34
error Avoid inline conditionals. 34
error Method 'getLocation' is not designed for extension - needs to be abstract, final or empty. 37
error Missing a Javadoc comment. 37
error '{' should be on the previous line. 38
error Method 'setLocation' is not designed for extension - needs to be abstract, final or empty. 42
error Missing a Javadoc comment. 42
error Parameter location should be final. 42
error 'location' hides a field. 42
error '{' should be on the previous line. 43

com/atlassian/xwork/package.html

Violation Message Line
error Missing package documentation file. 0

com/atlassian/xwork/interceptors/SimpleValidationInterceptor.java

Violation Message Line
error Line is longer than 80 characters. 11
error Line is longer than 80 characters. 12
error '{' should be on the previous line. 15
error Missing a Javadoc comment. 16
error '{' should be on the previous line. 17
error Missing a Javadoc comment. 20
error '{' should be on the previous line. 21
error Method 'intercept' is not designed for extension - needs to be abstract, final or empty. 24
error Missing a Javadoc comment. 24
error Parameter invocation should be final. 24
error '{' should be on the previous line. 25
error 'cast' is not followed by whitespace. 29
error 'cast' is not followed by whitespace. 30
error '{' should be on the previous line. 31

com/atlassian/xwork/interceptors/package.html

Violation Message Line
error Missing package documentation file. 0