com.atlassian.scheduler.core.tests

Class QuartzCronExpressionValidatorTest

java.lang.Object

com.atlassian.scheduler.core.tests.CronExpressionValidatorTest

com.atlassian.scheduler.core.tests.QuartzCronExpressionValidatorTest

public abstract class QuartzCronExpressionValidatorTest
extends CronExpressionValidatorTest

Quartz has so many stupid bugs in it (both in 1.x and 2.x) that we have little choice but to hack up the tests with a bunch of special cases. This tries to encapsulate all of that ugliness.

Since:

v1.4

Field Summary

Fields inherited from class com.atlassian.scheduler.core.tests.CronExpressionValidatorTest

validator

Constructor Summary

Constructors

Constructor and Description
QuartzCronExpressionValidatorTest()

Method Summary

Modifier and Type	Method and Description
protected void	assertErrorQuartzExempt(String cronExpression, ErrorCode errorCode, String message, String value, int errorOffset, String whyQuartzIsWrong) Allow Quartz validator to fail to detect this error.
void	testNameRangesWrongLength() Quartz's assumption that names are always 3 chars long without checking means that this causes more characters to get gobbled up as part of the name than should be.
void	testTruncatedExpression() Quartz's assumption that names are always 3 chars long without checking means that this causes a StringIndexOutOfBoundsException and gets reported as a general failure.
protected boolean	verifyErrorOffset(int expected, CronSyntaxException cse) Exempts the Quartz validator from reporting error offsets correctly as long as it reports -1.

Methods inherited from class com.atlassian.scheduler.core.tests.CronExpressionValidatorTest

assertError, assertInvalidFlagL, assertInvalidName, assertInvalidNameDayOfWeek, assertInvalidNameField, assertInvalidNameRange, assertValid, exception, stackTrace, testBadDayOfMonthExpressions, testCronDoesNotGrokThatCharacter, testEmptyString, testHashOption, testInvalidIncrements, testLastFlagSpecifiedForUnsupportedField, testLastFlagWithHyphenW, testMisplacedCommas, testMissingFields, testNameRanges, testNumericValueOutOfRange, testQuestionMarkInBothDayFields, testQuestionMarkInNonDayField, testQuestionMarkWithNonWhitespaceAfterIt, testRealWorldErrorsFromCloud, testSupportForLastMinusNumberForDayOfMonth, testTrailingGarbageIgnoredIfYearsArePresent, testWeekdayFlagSpecifiedForUnsupportedField

Methods inherited from class java.lang.Object

clone, equals, finalize, getClass, hashCode, notify, notifyAll, toString, wait, wait, wait

Constructor Detail

QuartzCronExpressionValidatorTest

public QuartzCronExpressionValidatorTest()

Method Detail

verifyErrorOffset

protected boolean verifyErrorOffset(int expected,
                                    CronSyntaxException cse)

Exempts the Quartz validator from reporting error offsets correctly as long as it reports -1.

See QuartzParseExceptionMapper for the sad explanation.

Overrides:

verifyErrorOffset in class CronExpressionValidatorTest

Parameters:

expected - the expected error offset

cse - the actual exception

assertErrorQuartzExempt

protected void assertErrorQuartzExempt(String cronExpression,
                                       ErrorCode errorCode,
                                       String message,
                                       String value,
                                       int errorOffset,
                                       String whyQuartzIsWrong)

Allow Quartz validator to fail to detect this error.

There are several cases where the Quartz cron expression parser forgives errors in the syntax that it really should not permit.

Overrides:

assertErrorQuartzExempt in class CronExpressionValidatorTest

Parameters:

cronExpression - the invalid cron expression

errorCode - the expected error code

message - the expected error message

value - the expected token value

errorOffset - the expected error offset

whyQuartzIsWrong - an explanation as to what Quartz does instead and why it is wrong

testNameRangesWrongLength

public void testNameRangesWrongLength()

Quartz's assumption that names are always 3 chars long without checking means that this causes more characters to get gobbled up as part of the name than should be.

Overrides:

testNameRangesWrongLength in class CronExpressionValidatorTest

testTruncatedExpression

public void testTruncatedExpression()

Quartz's assumption that names are always 3 chars long without checking means that this causes a StringIndexOutOfBoundsException and gets reported as a general failure.

We work backwards to try to tell what went wrong, but the logic for this is not perfect and we cannot tell what field was being checked at the time. We can't assume it is always the day-of-week at the end of the expression, because Quartz tokenizes the expression into fields beforehand, so it could just as easily happen to the day-of-month. All we can do is report INVALID_NAME to be as friendly/helpful as possible.

That's better than nothing, I guess, but the main test does the correct assertion.

Overrides:

testTruncatedExpression in class CronExpressionValidatorTest