The following document contains the results of FindBugs Report
FindBugs Version is 1.2.0
Threshold is Low
Effort is Default
| Classes | Bugs | Errors | Missing Classes |
|---|---|---|---|
| 388 | 25 | 0 | 1 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Load of known null value in com.atlassian.plugins.rest.module.ApiVersion.ApiVersion(String) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 28 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Class com.atlassian.plugins.rest.module.InvalidVersionException defines non-transient non-serializable instance field moduleDescriptor | BAD_PRACTICE | SE_BAD_FIELD | Not available |
| Class com.atlassian.plugins.rest.module.InvalidVersionException defines non-transient non-serializable instance field plugin | BAD_PRACTICE | SE_BAD_FIELD | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| The class com.atlassian.plugins.rest.module.OsgiResourceConfig$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Unchecked/unconfirmed cast from javax.servlet.ServletRequest to javax.servlet.http.HttpServletRequest in com.atlassian.plugins.rest.module.RestDelegatingServletFilter.doFilter(ServletRequest, ServletResponse, FilterChain) | STYLE | BC_UNCONFIRMED_CAST | 116 |
| com.atlassian.plugins.rest.module.RestDelegatingServletFilter.doFilter(ServletRequest, ServletResponse, FilterChain) creates a com.atlassian.plugins.rest.module.ChainingClassLoader classloader, which should be performed within a doPrivileged block | BAD_PRACTICE | DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED | 115 |
| com.atlassian.plugins.rest.module.RestDelegatingServletFilter.init(FilterConfig) creates a com.atlassian.plugins.rest.module.ChainingClassLoader classloader, which should be performed within a doPrivileged block | BAD_PRACTICE | DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED | 101 |
| Bug | Category | Details | Line |
|---|---|---|---|
| The class com.atlassian.plugins.rest.module.RestDelegatingServletFilter$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| The class com.atlassian.plugins.rest.module.RestDelegatingServletFilter$2 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| The class com.atlassian.plugins.rest.module.RestDelegatingServletFilter$3 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Class com.atlassian.plugins.rest.module.RestDelegatingServletFilter$JerseyOsgiServletContainer defines non-transient non-serializable instance field injectableProviders | BAD_PRACTICE | SE_BAD_FIELD | Not available |
| Class com.atlassian.plugins.rest.module.RestDelegatingServletFilter$JerseyOsgiServletContainer defines non-transient non-serializable instance field plugin | BAD_PRACTICE | SE_BAD_FIELD | Not available |
| Class com.atlassian.plugins.rest.module.RestDelegatingServletFilter$JerseyOsgiServletContainer defines non-transient non-serializable instance field resourceFilterFactories | BAD_PRACTICE | SE_BAD_FIELD | Not available |
| Class com.atlassian.plugins.rest.module.RestDelegatingServletFilter$JerseyOsgiServletContainer defines non-transient non-serializable instance field templateProcessors | BAD_PRACTICE | SE_BAD_FIELD | Not available |
| com.atlassian.plugins.rest.module.RestDelegatingServletFilter$JerseyOsgiServletContainer is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| JsonWithPaddingResponseAdapter.out not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| The class com.atlassian.plugins.rest.module.scanner.AnnotatedClassScanner$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Questionable use of non-short-circuit logic in com.atlassian.plugins.rest.module.scanner.AnnotatedClassScanner$AnnotatedClassVisitor.visitInnerClass(String, String, String, int) | BAD_PRACTICE | NS_NON_SHORT_CIRCUIT | 271 |
| AnnotatedClassScanner$AnnotatedClassVisitor.className not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.plugins.rest.module.servlet.DefaultRestServletModuleManager$RestServletFilterModuleDescriptorComparator implements Comparator but not Serializable | BAD_PRACTICE | SE_COMPARATOR_SHOULD_BE_SERIALIZABLE | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Unchecked/unconfirmed cast from javax.servlet.ServletRequest to javax.servlet.http.HttpServletRequest in com.atlassian.plugins.rest.module.servlet.RestServletUtilsUpdaterFilter.doFilter(ServletRequest, ServletResponse, FilterChain) | STYLE | BC_UNCONFIRMED_CAST | 40 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Unwritten field: com.atlassian.plugins.rest.module.template.VelocityTemplateProcessor.httpContext | CORRECTNESS | UWF_UNWRITTEN_FIELD | 25 |
| Unwritten field: com.atlassian.plugins.rest.module.template.VelocityTemplateProcessor.httpServletRequest | CORRECTNESS | UWF_UNWRITTEN_FIELD | 25 |
| Unwritten field: com.atlassian.plugins.rest.module.template.VelocityTemplateProcessor.httpServletResponse | CORRECTNESS | UWF_UNWRITTEN_FIELD | 25 |
| Bug | Category | Details | Line |
|---|---|---|---|
| The class com.atlassian.plugins.rest.module.template.VelocityTemplateProcessor$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | Not available |
