The following document contains the results of FindBugs Report
FindBugs Version is 1.2.0
Threshold is Low
Effort is Default
| Classes | Bugs | Errors | Missing Classes |
|---|---|---|---|
| 487 | 76 | 0 | 0 |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.renderer.DefaultIconManager.getEmoticonSymbols() may expose internal representation by returning DefaultIconManager.emoticons | MALICIOUS_CODE | EI_EXPOSE_REP | 103 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Confusing to have methods com.atlassian.renderer.attachments.RendererAttachment.getFileName() and com.atlassian.renderer.embedded.EmbeddedResourceParser.getFilename() | BAD_PRACTICE | NM_CONFUSING | 76 |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.renderer.embedded.EmbeddedAudio.RESOURCE_TYPE isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 12 |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.renderer.embedded.EmbeddedFlash.RESOURCE_TYPE isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 15 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Class com.atlassian.renderer.embedded.EmbeddedFlashRenderer implements same interface as superclass | STYLE | RI_REDUNDANT_INTERFACES | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 71 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Unchecked/unconfirmed cast from com.atlassian.renderer.embedded.EmbeddedResource to com.atlassian.renderer.embedded.EmbeddedImage in com.atlassian.renderer.embedded.EmbeddedImageRenderer.renderResource(EmbeddedResource, RenderContext) | STYLE | BC_UNCONFIRMED_CAST | 75 |
| Method com.atlassian.renderer.embedded.EmbeddedImageRenderer.outputParameters(Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 265 |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.renderer.embedded.EmbeddedObjectRenderer.validEmbedTags isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 65 |
| com.atlassian.renderer.embedded.EmbeddedObjectRenderer.validObjectTags isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 33 |
| com.atlassian.renderer.embedded.EmbeddedObjectRenderer.validParamTags isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 96 |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.renderer.embedded.EmbeddedQuicktime.FILE_EXT_1 isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 13 |
| com.atlassian.renderer.embedded.EmbeddedQuicktime.RESOURCE_TYPE isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 12 |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.renderer.embedded.EmbeddedRealMedia.FILE_EXT_1 isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 14 |
| com.atlassian.renderer.embedded.EmbeddedRealMedia.FILE_EXT_2 isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 15 |
| com.atlassian.renderer.embedded.EmbeddedRealMedia.RESOURCE_TYPE isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 12 |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.renderer.embedded.EmbeddedRealMediaRenderer.DEFAULT_CONTROLS_HEIGHT isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 20 |
| com.atlassian.renderer.embedded.EmbeddedRealMediaRenderer.DEFAULT_HEIGHT isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 18 |
| com.atlassian.renderer.embedded.EmbeddedRealMediaRenderer.DEFAULT_WIDTH isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 17 |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.renderer.embedded.EmbeddedWindowsMedia.FILE_EXT_1 isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 14 |
| com.atlassian.renderer.embedded.EmbeddedWindowsMedia.FILE_EXT_2 isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 15 |
| com.atlassian.renderer.embedded.EmbeddedWindowsMedia.FILE_EXT_3 isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 16 |
| com.atlassian.renderer.embedded.EmbeddedWindowsMedia.RESOURCE_TYPE isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 12 |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.renderer.embedded.UnembeddableObject.UNEMBEDDABLE_TYPES should be both final and package protected | MALICIOUS_CODE | MS_FINAL_PKGPROTECT | 5 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Comparison of String objects using == or != in com.atlassian.renderer.links.BaseLink.equals(Object) | BAD_PRACTICE | ES_COMPARING_STRINGS_WITH_EQ | 77 |
| com.atlassian.renderer.links.BaseLink.equals(Object) does not check for null argument | BAD_PRACTICE | NP_EQUALS_SHOULD_HANDLE_NULL_ARGUMENT | 72 |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.renderer.links.Link.equals(Object) does not check for null argument | BAD_PRACTICE | NP_EQUALS_SHOULD_HANDLE_NULL_ARGUMENT | 128 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Field BaseMacro.description masks field in superclass org.radeox.macro.BaseMacro | CORRECTNESS | MF_CLASS_MASKS_FIELD | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.renderer.macro.macros.AbstractPanelMacro.getParamDescription() may expose internal representation by returning AbstractPanelMacro.myParamDescription | MALICIOUS_CODE | EI_EXPOSE_REP | 16 |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.renderer.macro.macros.ColorMacro.getParamDescription() may expose internal representation by returning ColorMacro.myParamDescription | MALICIOUS_CODE | EI_EXPOSE_REP | 24 |
| Bug | Category | Details | Line |
|---|---|---|---|
| PanelMacro.wikiStyleRenderer not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| QuoteMacro.wikiStyleRenderer not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 26 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 63 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Method com.atlassian.renderer.util.RegExpUtil.convertToRegularExpression(String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 22 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 66 |
| Method com.atlassian.renderer.util.UrlUtil.buildNewRelativeUrl(HttpServletRequest, String, String) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 265 |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.renderer.v2.Replacer.Replacer(Pattern, String, String[]) may expose internal representation by storing an externally mutable object into Replacer.necessaryConstantParts | MALICIOUS_CODE | EI_EXPOSE_REP2 | 28 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Dead store to lastStart in com.atlassian.renderer.v2.WikiMarkupParser.parse(String) | STYLE | DLS_DEAD_LOCAL_STORE | 56 |
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 130 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Unchecked/unconfirmed cast from java.lang.Throwable to java.lang.RuntimeException in com.atlassian.renderer.v2.components.MacroRendererComponent.processMacro(String, Macro, String, Map, RenderContext, StringBuffer) | STYLE | BC_UNCONFIRMED_CAST | 181 |
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 97 |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.renderer.v2.components.UrlRendererComponent.INVALID_END_CHARS should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 24 |
| com.atlassian.renderer.v2.components.UrlRendererComponent.PURE_URL_PATTERN isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 23 |
| com.atlassian.renderer.v2.components.UrlRendererComponent.URL_PATTERN isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 22 |
| Method com.atlassian.renderer.v2.components.UrlRendererComponent.<static initializer>() concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 37 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 51 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Method com.atlassian.renderer.v2.components.table.Table.createTable(String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 70 |
| Bug | Category | Details | Line |
|---|---|---|---|
| AbstractPanelMacro.subRenderer not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
| Method com.atlassian.renderer.v2.macro.basic.AbstractPanelMacro.handleExplicitStyles(StringBuffer, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 120 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Private method com.atlassian.renderer.v2.macro.basic.validator.ColorStyleValidator.createColorValues() is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 57-75 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 61 |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.renderer.v2.macro.code.formatter.ActionScriptFormatter.getSupportedLanguages() may expose internal representation by returning ActionScriptFormatter.SUPPORTED_LANGUAGES | MALICIOUS_CODE | EI_EXPOSE_REP | 32 |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.renderer.v2.macro.code.formatter.JavaFormatter.getSupportedLanguages() may expose internal representation by returning JavaFormatter.SUPPORTED_LANGUAGES | MALICIOUS_CODE | EI_EXPOSE_REP | 34 |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.renderer.v2.macro.code.formatter.JavaScriptFormatter.getSupportedLanguages() may expose internal representation by returning JavaScriptFormatter.SUPPORTED_LANGUAGES | MALICIOUS_CODE | EI_EXPOSE_REP | 29 |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.renderer.v2.macro.code.formatter.NoneFormatter.getSupportedLanguages() may expose internal representation by returning NoneFormatter.SUPPORTED_LANGUAGES | MALICIOUS_CODE | EI_EXPOSE_REP | 22 |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.renderer.v2.macro.code.formatter.SqlFormatter.getSupportedLanguages() may expose internal representation by returning SqlFormatter.SUPPORTED_LANGUAGES | MALICIOUS_CODE | EI_EXPOSE_REP | 22 |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.renderer.v2.macro.code.formatter.XmlFormatter.getSupportedLanguages() may expose internal representation by returning XmlFormatter.SUPPORTED_LANGUAGES | MALICIOUS_CODE | EI_EXPOSE_REP | 27 |
| Bug | Category | Details | Line |
|---|---|---|---|
| PluggableWysiwygConverter.rendererComponentsAccessor not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 69 |
| Method com.atlassian.renderer.wysiwyg.HtmlParserUtil.HtmlParserUtil(InputStream) directly allocates a specific implementation of xml interfaces | STYLE | XFB_XML_FACTORY_BYPASS | 47 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 48 |
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 114 |
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 81 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 259 |
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 628 |
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 135 |
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 550 |
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 179 |
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 494 |
| com.atlassian.renderer.wysiwyg.converter.DefaultWysiwygConverter.debug isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 56 |
| Unread field: com.atlassian.renderer.wysiwyg.converter.DefaultWysiwygConverter.log | PERFORMANCE | URF_UNREAD_FIELD | 53 |
| Method com.atlassian.renderer.wysiwyg.converter.DefaultWysiwygConverter.convertXHtmlToWikiMarkup(String) directly allocates a specific implementation of xml interfaces | STYLE | XFB_XML_FACTORY_BYPASS | 676 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 37 |
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 42 |
| com.atlassian.renderer.wysiwyg.converter.FormatConverter.INSTANCE isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 12 |
