FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 1.2.0

Threshold is Low

Effort is Default

Summary

Classes Bugs Errors Missing Classes
390 38 0 0

Files

Class Bugs
com.atlassian.plugin.osgi.container.felix.ExportsBuilder 1
com.atlassian.plugin.osgi.container.felix.FelixLoggerBridge 1
com.atlassian.plugin.osgi.container.felix.FelixOsgiContainerManager$1 1
com.atlassian.plugin.osgi.container.felix.FelixOsgiContainerManager$BundleRegistration 2
com.atlassian.plugin.osgi.container.felix.FelixOsgiContainerManager$BundleRegistration$1 1
com.atlassian.plugin.osgi.container.felix.FelixOsgiContainerManager$BundleRegistration$2 1
com.atlassian.plugin.osgi.container.felix.FelixOsgiContainerManager$BundleRegistration$3 1
com.atlassian.plugin.osgi.container.felix.FelixOsgiContainerManager$BundleRegistration$4 1
com.atlassian.plugin.osgi.factory.BundleClassLoaderAccessor 1
com.atlassian.plugin.osgi.factory.OsgiBundlePlugin 1
com.atlassian.plugin.osgi.factory.OsgiPluginFactory 1
com.atlassian.plugin.osgi.factory.OsgiPluginFactory$1 1
com.atlassian.plugin.osgi.factory.OsgiPluginInstalledHelper$SpringContextAccessor 1
com.atlassian.plugin.osgi.factory.transform.DefaultPluginTransformer 2
com.atlassian.plugin.osgi.factory.transform.stage.GenerateManifestStage 3
com.atlassian.plugin.osgi.factory.transform.stage.HostComponentSpringStage 1
com.atlassian.plugin.osgi.factory.transform.stage.SpringHelper 1
com.atlassian.plugin.osgi.hostcomponents.impl.Registration 1
com.atlassian.plugin.osgi.util.Clazz 16

com.atlassian.plugin.osgi.container.felix.ExportsBuilder

Bug Category Details Line
com.atlassian.plugin.osgi.container.felix.ExportsBuilder.constructJdkExports(StringBuilder, String) may fail to close stream BAD_PRACTICE OS_OPEN_STREAM 184

com.atlassian.plugin.osgi.container.felix.FelixLoggerBridge

Bug Category Details Line
Method com.atlassian.plugin.osgi.container.felix.FelixLoggerBridge.doLog(ServiceReference, int, String, Throwable) uses the same code for two switch clauses STYLE DB_DUPLICATE_SWITCH_CLAUSES 61-62

com.atlassian.plugin.osgi.container.felix.FelixOsgiContainerManager$1

Bug Category Details Line
The class com.atlassian.plugin.osgi.container.felix.FelixOsgiContainerManager$1 could be refactored into a named _static_ inner class PERFORMANCE SIC_INNER_SHOULD_BE_STATIC_ANON Not available

com.atlassian.plugin.osgi.container.felix.FelixOsgiContainerManager$BundleRegistration

Bug Category Details Line
FelixOsgiContainerManager$BundleRegistration.bundleContext not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available
FelixOsgiContainerManager$BundleRegistration.packageAdmin not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available

com.atlassian.plugin.osgi.container.felix.FelixOsgiContainerManager$BundleRegistration$1

Bug Category Details Line
The class com.atlassian.plugin.osgi.container.felix.FelixOsgiContainerManager$BundleRegistration$1 could be refactored into a named _static_ inner class PERFORMANCE SIC_INNER_SHOULD_BE_STATIC_ANON Not available

com.atlassian.plugin.osgi.container.felix.FelixOsgiContainerManager$BundleRegistration$2

Bug Category Details Line
The class com.atlassian.plugin.osgi.container.felix.FelixOsgiContainerManager$BundleRegistration$2 could be refactored into a named _static_ inner class PERFORMANCE SIC_INNER_SHOULD_BE_STATIC_ANON Not available

com.atlassian.plugin.osgi.container.felix.FelixOsgiContainerManager$BundleRegistration$3

Bug Category Details Line
The class com.atlassian.plugin.osgi.container.felix.FelixOsgiContainerManager$BundleRegistration$3 could be refactored into a named _static_ inner class PERFORMANCE SIC_INNER_SHOULD_BE_STATIC_ANON Not available

com.atlassian.plugin.osgi.container.felix.FelixOsgiContainerManager$BundleRegistration$4

Bug Category Details Line
The class com.atlassian.plugin.osgi.container.felix.FelixOsgiContainerManager$BundleRegistration$4 could be refactored into a named _static_ inner class PERFORMANCE SIC_INNER_SHOULD_BE_STATIC_ANON Not available

com.atlassian.plugin.osgi.factory.BundleClassLoaderAccessor

Bug Category Details Line
com.atlassian.plugin.osgi.factory.BundleClassLoaderAccessor.getClassLoader(Bundle, AlternativeResourceLoader) creates a com.atlassian.plugin.osgi.factory.BundleClassLoaderAccessor$BundleClassLoader classloader, which should be performed within a doPrivileged block BAD_PRACTICE DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED 22

com.atlassian.plugin.osgi.factory.OsgiBundlePlugin

Bug Category Details Line
com.atlassian.plugin.osgi.factory.OsgiBundlePlugin.getDateLoaded() may expose internal representation by returning OsgiBundlePlugin.dateLoaded MALICIOUS_CODE EI_EXPOSE_REP 172

com.atlassian.plugin.osgi.factory.OsgiPluginFactory

Bug Category Details Line
Method com.atlassian.plugin.osgi.factory.OsgiPluginFactory.getChainedModuleDescriptorFactory(ModuleDescriptorFactory) uses Collection.toArray() with zero-length array argument PERFORMANCE ITA_INEFFICIENT_TO_ARRAY 205

com.atlassian.plugin.osgi.factory.OsgiPluginFactory$1

Bug Category Details Line
The class com.atlassian.plugin.osgi.factory.OsgiPluginFactory$1 could be refactored into a named _static_ inner class PERFORMANCE SIC_INNER_SHOULD_BE_STATIC_ANON Not available

com.atlassian.plugin.osgi.factory.OsgiPluginInstalledHelper$SpringContextAccessor

Bug Category Details Line
Load of known null value in com.atlassian.plugin.osgi.factory.OsgiPluginInstalledHelper$SpringContextAccessor.SpringContextAccessor(Object) STYLE NP_LOAD_OF_KNOWN_NULL_VALUE 245

com.atlassian.plugin.osgi.factory.transform.DefaultPluginTransformer

Bug Category Details Line
com.atlassian.plugin.osgi.factory.transform.DefaultPluginTransformer.addFilesToExistingZip(File, Map) may fail to close stream on exception BAD_PRACTICE OS_OPEN_STREAM_EXCEPTION_PATH 187
com.atlassian.plugin.osgi.factory.transform.DefaultPluginTransformer.addFilesToExistingZip(File, Map) may fail to close stream on exception BAD_PRACTICE OS_OPEN_STREAM_EXCEPTION_PATH 188

com.atlassian.plugin.osgi.factory.transform.stage.GenerateManifestStage

Bug Category Details Line
Call to equals() with null argument in com.atlassian.plugin.osgi.factory.transform.stage.GenerateManifestStage.enforceHostVersionsForUnknownImports(Manifest, SystemExports) CORRECTNESS EC_NULL_ARG 160
Load of known null value in com.atlassian.plugin.osgi.factory.transform.stage.GenerateManifestStage.enforceHostVersionsForUnknownImports(Manifest, SystemExports) STYLE NP_LOAD_OF_KNOWN_NULL_VALUE 160
Exception is caught when Exception is not thrown in com.atlassian.plugin.osgi.factory.transform.stage.GenerateManifestStage.execute(TransformContext) STYLE REC_CATCH_EXCEPTION 127

com.atlassian.plugin.osgi.factory.transform.stage.HostComponentSpringStage

Bug Category Details Line
Private method com.atlassian.plugin.osgi.factory.transform.stage.HostComponentSpringStage.convertRegistrationsToSetOfSets(List) is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD 150-159

com.atlassian.plugin.osgi.factory.transform.stage.SpringHelper

Bug Category Details Line
Method com.atlassian.plugin.osgi.factory.transform.stage.SpringHelper.documentToBytes(Document) directly allocates a specific implementation of xml interfaces STYLE XFB_XML_FACTORY_BYPASS 58

com.atlassian.plugin.osgi.hostcomponents.impl.Registration

Bug Category Details Line
Registration.instance not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available

com.atlassian.plugin.osgi.util.Clazz

Bug Category Details Line
Dead store to deflt in com.atlassian.plugin.osgi.util.Clazz.crawl(byte[]) STYLE DLS_DEAD_LOCAL_STORE 484
Dead store to s in com.atlassian.plugin.osgi.util.Clazz.parseClassFile(DataInputStream) STYLE DLS_DEAD_LOCAL_STORE 203
Method com.atlassian.plugin.osgi.util.Clazz.constantClass(DataInputStream, int) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 286
Method com.atlassian.plugin.osgi.util.Clazz.doAnnotation(DataInputStream) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 532
Method com.atlassian.plugin.osgi.util.Clazz.doElementValue(DataInputStream) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 558
Method com.atlassian.plugin.osgi.util.Clazz.doElementValue(DataInputStream) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 565
Method com.atlassian.plugin.osgi.util.Clazz.nameAndType(DataInputStream, int, byte) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 250
Method com.atlassian.plugin.osgi.util.Clazz.parseClassFile(DataInputStream) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 178
Method com.atlassian.plugin.osgi.util.Clazz.parseClassFile(DataInputStream) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 204
com.atlassian.plugin.osgi.util.Clazz.constantDouble(DataInputStream, int) ignores result of java.io.DataInputStream.skipBytes(int) BAD_PRACTICE SR_NOT_CHECKED 296
com.atlassian.plugin.osgi.util.Clazz.constantLong(DataInputStream, int) ignores result of java.io.DataInputStream.skipBytes(int) BAD_PRACTICE SR_NOT_CHECKED 305
com.atlassian.plugin.osgi.util.Clazz.doAttribute(DataInputStream, boolean) ignores result of java.io.DataInputStream.skipBytes(int) BAD_PRACTICE SR_NOT_CHECKED 409
com.atlassian.plugin.osgi.util.Clazz.doCode(DataInputStream) ignores result of java.io.DataInputStream.skipBytes(int) BAD_PRACTICE SR_NOT_CHECKED 445
com.atlassian.plugin.osgi.util.Clazz.parseClassFile(DataInputStream) ignores result of java.io.DataInputStream.skipBytes(int) BAD_PRACTICE SR_NOT_CHECKED 134
Unread field: com.atlassian.plugin.osgi.util.Clazz.major PERFORMANCE URF_UNREAD_FIELD 53
Unread field: com.atlassian.plugin.osgi.util.Clazz.minor PERFORMANCE URF_UNREAD_FIELD 52