The following document contains the results of FindBugs Report
FindBugs Version is 1.2.0
Threshold is Low
Effort is Default
| Classes | Bugs | Errors | Missing Classes |
|---|---|---|---|
| 288 | 29 | 0 | 0 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Method com.atlassian.plugin.osgi.container.felix.FelixLoggerBridge.doLog(ServiceReference, int, String, Throwable) uses the same code for two switch clauses | STYLE | DB_DUPLICATE_SWITCH_CLAUSES | 57-58 |
| Bug | Category | Details | Line |
|---|---|---|---|
| FelixOsgiContainerManager$BundleRegistration.bundleContext not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| The class com.atlassian.plugin.osgi.container.felix.FelixOsgiContainerManager$BundleRegistration$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| The class com.atlassian.plugin.osgi.container.felix.FelixOsgiContainerManager$BundleRegistration$2 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.plugin.osgi.factory.BundleClassLoaderAccessor.getClassLoader(Bundle) creates a com.atlassian.plugin.osgi.factory.BundleClassLoaderAccessor$BundleClassLoader classloader, which should be performed within a doPrivileged block | BAD_PRACTICE | DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED | 22 |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.plugin.osgi.factory.OsgiBundlePlugin.getDateLoaded() may expose internal representation by returning OsgiBundlePlugin.dateLoaded | MALICIOUS_CODE | EI_EXPOSE_REP | 140 |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.plugin.osgi.factory.OsgiPluginFactory.create(DeploymentUnit, ModuleDescriptorFactory) creates a com.atlassian.plugin.classloader.PluginClassLoader classloader, which should be performed within a doPrivileged block | BAD_PRACTICE | DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED | 82 |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.plugin.osgi.factory.transform.DefaultPluginTransformer.addFilesToExistingZip(File, Map) may fail to close stream on exception | BAD_PRACTICE | OS_OPEN_STREAM_EXCEPTION_PATH | 319 |
| com.atlassian.plugin.osgi.factory.transform.DefaultPluginTransformer.addFilesToExistingZip(File, Map) may fail to close stream on exception | BAD_PRACTICE | OS_OPEN_STREAM_EXCEPTION_PATH | 320 |
| Method com.atlassian.plugin.osgi.factory.transform.DefaultPluginTransformer.generateSpringXml(InputStream, List) directly allocates a specific implementation of xml interfaces | STYLE | XFB_XML_FACTORY_BYPASS | 179 |
| Bug | Category | Details | Line |
|---|---|---|---|
| The class com.atlassian.plugin.osgi.hostcomponents.impl.DefaultComponentRegistrar$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Registration.instance not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Dead store to deflt in com.atlassian.plugin.osgi.util.Clazz.crawl(byte[]) | STYLE | DLS_DEAD_LOCAL_STORE | 484 |
| Dead store to s in com.atlassian.plugin.osgi.util.Clazz.parseClassFile(DataInputStream) | STYLE | DLS_DEAD_LOCAL_STORE | 203 |
| Method com.atlassian.plugin.osgi.util.Clazz.constantClass(DataInputStream, int) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 286 |
| Method com.atlassian.plugin.osgi.util.Clazz.doAnnotation(DataInputStream) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 532 |
| Method com.atlassian.plugin.osgi.util.Clazz.doElementValue(DataInputStream) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 558 |
| Method com.atlassian.plugin.osgi.util.Clazz.doElementValue(DataInputStream) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 565 |
| Method com.atlassian.plugin.osgi.util.Clazz.nameAndType(DataInputStream, int, byte) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 250 |
| Method com.atlassian.plugin.osgi.util.Clazz.parseClassFile(DataInputStream) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 178 |
| Method com.atlassian.plugin.osgi.util.Clazz.parseClassFile(DataInputStream) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 204 |
| com.atlassian.plugin.osgi.util.Clazz.constantDouble(DataInputStream, int) ignores result of java.io.DataInputStream.skipBytes(int) | BAD_PRACTICE | SR_NOT_CHECKED | 296 |
| com.atlassian.plugin.osgi.util.Clazz.constantLong(DataInputStream, int) ignores result of java.io.DataInputStream.skipBytes(int) | BAD_PRACTICE | SR_NOT_CHECKED | 305 |
| com.atlassian.plugin.osgi.util.Clazz.doAttribute(DataInputStream, boolean) ignores result of java.io.DataInputStream.skipBytes(int) | BAD_PRACTICE | SR_NOT_CHECKED | 409 |
| com.atlassian.plugin.osgi.util.Clazz.doCode(DataInputStream) ignores result of java.io.DataInputStream.skipBytes(int) | BAD_PRACTICE | SR_NOT_CHECKED | 445 |
| com.atlassian.plugin.osgi.util.Clazz.parseClassFile(DataInputStream) ignores result of java.io.DataInputStream.skipBytes(int) | BAD_PRACTICE | SR_NOT_CHECKED | 134 |
| Unread field: com.atlassian.plugin.osgi.util.Clazz.major | PERFORMANCE | URF_UNREAD_FIELD | 53 |
| Unread field: com.atlassian.plugin.osgi.util.Clazz.minor | PERFORMANCE | URF_UNREAD_FIELD | 52 |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.plugin.osgi.util.OsgiHeaderUtil.constructJdkExports(StringBuilder, String) may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 209 |
