The following document contains the results of FindBugs Report
FindBugs Version is 1.2.0
Threshold is Low
Effort is Default
| Classes | Bugs | Errors | Missing Classes |
|---|---|---|---|
| 553 | 43 | 0 | 0 |
| Bug | Category | Details | Line |
|---|---|---|---|
| The class com.atlassian.theplugin.commons.DefaultSwingUiTaskExecutor$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| BambooBuildInfo.buildKey not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
| BambooBuildInfo.server not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| BambooChangeSetImpl.commitDate not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Result of integer multiplication cast to long in com.atlassian.theplugin.commons.bamboo.BambooStatusChecker.getInterval() | STYLE | ICAST_INTEGER_MULTIPLY_CAST_TO_LONG | 149 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Dead store to status in com.atlassian.theplugin.commons.bamboo.HtmlBambooStatusListenerNotUsed.updateBuildStatuses(Collection) | STYLE | DLS_DEAD_LOCAL_STORE | 172 |
| Unread field: com.atlassian.theplugin.commons.bamboo.HtmlBambooStatusListenerNotUsed.display | PERFORMANCE | URF_UNREAD_FIELD | 46 |
| Bug | Category | Details | Line |
|---|---|---|---|
| The class com.atlassian.theplugin.commons.bamboo.HtmlBambooStatusListenerNotUsed$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| The class com.atlassian.theplugin.commons.bamboo.StausIconBambooListener$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Unchecked/unconfirmed cast from com.atlassian.theplugin.commons.cfg.PrivateServerCfgInfo to com.atlassian.theplugin.commons.cfg.PrivateBambooServerCfgInfo in com.atlassian.theplugin.commons.cfg.BambooServerCfg.mergePrivateConfiguration(PrivateServerCfgInfo) | STYLE | BC_UNCONFIRMED_CAST | 163 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Confusing to have methods com.atlassian.theplugin.commons.cfg.PrivateServerCfgInfo.getUsername() and com.atlassian.theplugin.commons.crucible.api.model.UserBean.getUserName() | BAD_PRACTICE | NM_CONFUSING | 37 |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.theplugin.commons.crucible.CrucibleFiltersBean.getPredefinedFilters() may expose internal representation by returning CrucibleFiltersBean.predefinedFilters | MALICIOUS_CODE | EI_EXPOSE_REP | 43 |
| com.atlassian.theplugin.commons.crucible.CrucibleFiltersBean.setPredefinedFilters(Boolean[]) may expose internal representation by storing an externally mutable object into CrucibleFiltersBean.predefinedFilters | MALICIOUS_CODE | EI_EXPOSE_REP2 | 47 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Inconsistent synchronization of com.atlassian.theplugin.commons.crucible.CrucibleServerFacadeImpl.userCache; locked 50% of time | MT_CORRECTNESS | IS2_INCONSISTENT_SYNC | 50 |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.theplugin.commons.crucible.api.model.CrucibleFileInfoImpl.getCommitDate() may expose internal representation by returning CrucibleFileInfoImpl.commitDate | MALICIOUS_CODE | EI_EXPOSE_REP | 173 |
| com.atlassian.theplugin.commons.crucible.api.model.CrucibleFileInfoImpl.setCommitDate(Date) may expose internal representation by storing an externally mutable object into CrucibleFileInfoImpl.commitDate | MALICIOUS_CODE | EI_EXPOSE_REP2 | 177 |
| Unread field: com.atlassian.theplugin.commons.crucible.api.model.CrucibleFileInfoImpl.numberOfComments | PERFORMANCE | URF_UNREAD_FIELD | 33 |
| Unread field: com.atlassian.theplugin.commons.crucible.api.model.CrucibleFileInfoImpl.numberOfDefects | PERFORMANCE | URF_UNREAD_FIELD | 38 |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.theplugin.commons.crucible.api.model.CustomFilterBean.getState() may expose internal representation by returning CustomFilterBean.state | MALICIOUS_CODE | EI_EXPOSE_REP | 98 |
| com.atlassian.theplugin.commons.crucible.api.model.CustomFilterBean.setState(String[]) may expose internal representation by storing an externally mutable object into CustomFilterBean.state | MALICIOUS_CODE | EI_EXPOSE_REP2 | 102 |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.theplugin.commons.crucible.api.model.ReviewBean.getCloseDate() may expose internal representation by returning ReviewBean.closeDate | MALICIOUS_CODE | EI_EXPOSE_REP | 393 |
| com.atlassian.theplugin.commons.crucible.api.model.ReviewBean.getCreateDate() may expose internal representation by returning ReviewBean.createDate | MALICIOUS_CODE | EI_EXPOSE_REP | 385 |
| com.atlassian.theplugin.commons.crucible.api.model.ReviewBean.setCloseDate(Date) may expose internal representation by storing an externally mutable object into ReviewBean.closeDate | MALICIOUS_CODE | EI_EXPOSE_REP2 | 397 |
| com.atlassian.theplugin.commons.crucible.api.model.ReviewBean.setCreateDate(Date) may expose internal representation by storing an externally mutable object into ReviewBean.createDate | MALICIOUS_CODE | EI_EXPOSE_REP2 | 389 |
| ReviewBean.generalComments not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
| ReviewBean.versionedComments not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Abstract com.atlassian.theplugin.commons.crucible.api.model.User defines compareTo(User) method | BAD_PRACTICE | CO_ABSTRACT_SELF | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Confusing to have methods com.atlassian.theplugin.commons.crucible.api.model.UserBean.setUserName(String) and com.atlassian.theplugin.commons.cfg.ServerCfg.setUsername(String) | BAD_PRACTICE | NM_CONFUSING | 41-42 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Method com.atlassian.theplugin.commons.crucible.api.rest.CrucibleRestXmlHelper.prepareFilterNodeElement(CustomFilter) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 751 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Method com.atlassian.theplugin.commons.crucible.api.rest.CrucibleSessionImpl.addReviewers(PermId, Set) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 1197 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Should com.atlassian.theplugin.commons.remoteapi.rest.AbstractHttpSession$CacheRecord be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.theplugin.commons.thirdparty.base64.Base64.decode(String, int) might ignore java.lang.Exception | BAD_PRACTICE | DE_MIGHT_IGNORE | 1011 |
| com.atlassian.theplugin.commons.thirdparty.base64.Base64.decodeFileToFile(String, String) might ignore java.lang.Exception | BAD_PRACTICE | DE_MIGHT_IGNORE | 1312 |
| com.atlassian.theplugin.commons.thirdparty.base64.Base64.encodeBytes(byte[], int, int, int) might ignore java.lang.Exception | BAD_PRACTICE | DE_MIGHT_IGNORE | 740 |
| com.atlassian.theplugin.commons.thirdparty.base64.Base64.encodeFileToFile(String, String) might ignore java.lang.Exception | BAD_PRACTICE | DE_MIGHT_IGNORE | 1271 |
| com.atlassian.theplugin.commons.thirdparty.base64.Base64.encodeObject(Serializable, int) might ignore java.lang.Exception | BAD_PRACTICE | DE_MIGHT_IGNORE | 613 |
| Dead store to dontBreakLines in com.atlassian.theplugin.commons.thirdparty.base64.Base64.encodeObject(Serializable, int) | STYLE | DLS_DEAD_LOCAL_STORE | 588 |
| Null pointer dereference of bis in com.atlassian.theplugin.commons.thirdparty.base64.Base64.decodeFromFile(String) | CORRECTNESS | NP_ALWAYS_NULL | 1183 |
| Should com.atlassian.theplugin.commons.thirdparty.base64.Base64.decode(byte[], int, int, int) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 935 |
| Exception is caught when Exception is not thrown in com.atlassian.theplugin.commons.thirdparty.base64.Base64.decode4to3(byte[], int, byte[], int, int) | STYLE | REC_CATCH_EXCEPTION | 878 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Unread field: com.atlassian.theplugin.commons.thirdparty.base64.Base64$InputStream.alphabet | PERFORMANCE | URF_UNREAD_FIELD | 1383 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Unread field: com.atlassian.theplugin.commons.thirdparty.base64.Base64$OutputStream.alphabet | PERFORMANCE | URF_UNREAD_FIELD | 1599 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 62 |
