PMD Results

The following document contains the results of PMD 4.2.2.

Files

com/atlassian/theplugin/idea/CrucibleBottomToolWindowPanel.java

Violation Line
No need to import a type that lives in the same package 13
Avoid unused private fields such as 'project'. 56
Avoid unused private fields such as 'serverFacade'. 61
Avoid unused private fields such as 'splitter'. 65
Avoid unused private fields such as 'tabManager'. 67
Avoid unused local variables such as 'content'. 261

com/atlassian/theplugin/idea/GeneralConfigForm.java

Violation Line
Avoid unused constructor parameters such as 'checker'. 61 - 102

com/atlassian/theplugin/idea/IdeaHelper.java

Violation Line
Avoid unused imports such as 'com.atlassian.theplugin.idea.crucible.comments.CrucibleReviewActionListener' 22

com/atlassian/theplugin/idea/PasswordDialog.java

Violation Line
Avoid unused private methods such as 'createUIComponents()'. 102

com/atlassian/theplugin/idea/PluginToolWindow.java

Violation Line
Overriding method merely calls super 411 - 413
Overriding method merely calls super 415 - 417

com/atlassian/theplugin/idea/ThePluginProjectComponent.java

Violation Line
Avoid unused private fields such as 'crucibleActionBroker'. 95

com/atlassian/theplugin/idea/VcsIdeaHelper.java

Violation Line
Avoid empty catch blocks 70 - 72
Avoid empty catch blocks 102 - 104
Avoid empty catch blocks 104 - 106

com/atlassian/theplugin/idea/action/crucible/AddRevisionToReviewAction.java

Violation Line
These nested if statements could be combined 31 - 33

com/atlassian/theplugin/idea/action/crucible/BackToGeneralCommentsAction.java

Violation Line
Avoid unused imports such as 'com.intellij.openapi.wm.ToolWindow' 5
Avoid unused imports such as 'com.atlassian.theplugin.idea.CrucibleBottomToolWindowPanel' 7
Avoid unused imports such as 'com.atlassian.theplugin.idea.PluginToolWindow' 8

com/atlassian/theplugin/idea/action/crucible/BackToRevisionCommentsAction.java

Violation Line
Avoid unused imports such as 'com.atlassian.theplugin.idea.crucible.events.FocusOnVersionedCommentEvent' 10
Avoid unused imports such as 'com.atlassian.theplugin.idea.crucible.tree.CrucibleTreeRootNode' 14
Avoid unused imports such as 'com.atlassian.theplugin.idea.crucible.tree.ReviewItemDataNode' 15
Avoid unused private fields such as 'event'. 28

com/atlassian/theplugin/idea/action/crucible/GetGeneralCommentRepliesAction.java

Violation Line
Avoid unused imports such as 'com.intellij.openapi.actionSystem.AnAction' 3
Avoid unused imports such as 'com.intellij.openapi.actionSystem.AnActionEvent' 4
Avoid unused imports such as 'com.atlassian.theplugin.commons.crucible.api.model.GeneralComment' 5
Avoid unused imports such as 'com.atlassian.theplugin.idea.IdeaHelper' 6
Avoid unused imports such as 'com.atlassian.theplugin.idea.crucible.events.FocusOnGeneralCommentReplyEvent' 7

com/atlassian/theplugin/idea/action/crucible/PreCommitReview.java

Violation Line
Avoid unused imports such as 'com.intellij.openapi.vcs.changes.Change' 7
Avoid unused imports such as 'com.intellij.openapi.application.ApplicationManager' 8
Avoid unused imports such as 'com.intellij.openapi.application.ModalityState' 9
Avoid unused imports such as 'com.atlassian.theplugin.idea.crucible.CrucibleRevisionAddWorker' 11
Avoid unused imports such as 'com.atlassian.theplugin.idea.IdeaHelper' 13

com/atlassian/theplugin/idea/action/crucible/TableSelectedAction.java

Violation Line
Avoid unused imports such as 'com.intellij.openapi.vcs.VcsDataConstants' 7
Avoid unused imports such as 'com.atlassian.theplugin.idea.crucible.ReviewDataInfoAdapter' 12

com/atlassian/theplugin/idea/action/jira/OpenIssueAction.java

Violation Line
Avoid unused imports such as 'com.atlassian.theplugin.idea.jira.editor.ThePluginJIRAEditorComponent' 3
Avoid unused imports such as 'com.intellij.openapi.fileEditor.FileEditor' 11
Avoid unused imports such as 'com.intellij.openapi.fileEditor.FileEditorState' 12

com/atlassian/theplugin/idea/autoupdate/PluginDownloader.java

Violation Line
Avoid empty catch blocks 160 - 162
Avoid empty catch blocks 168 - 170

com/atlassian/theplugin/idea/bamboo/BambooTableToolWindowPanel.java

Violation Line
Avoid unused imports such as 'com.atlassian.theplugin.idea.IdeaHelper' 26
Avoid unused private fields such as 'instance'. 45
Avoid unused private fields such as 'project'. 47
These nested if statements could be combined 206 - 209

com/atlassian/theplugin/idea/config/HTTPProxyDialog.java

Violation Line
Avoid unused imports such as 'com.intellij.uiDesigner.core.Spacer' 21
Avoid unused private methods such as 'onOK()'. 72

com/atlassian/theplugin/idea/config/serverconfig/BambooPlansForm.java

Violation Line
These nested if statements could be combined 156 - 160

com/atlassian/theplugin/idea/config/serverconfig/BambooServerConfigForm.java

Violation Line
Avoid unused private fields such as 'LOG'. 36

com/atlassian/theplugin/idea/config/serverconfig/CrucibleGeneralForm.java

Violation Line
Avoid unused private methods such as 'createUIComponents()'. 157

com/atlassian/theplugin/idea/config/serverconfig/GenericServerConfigForm.java

Violation Line
Avoid unused private methods such as 'createUIComponents()'. 129

com/atlassian/theplugin/idea/config/serverconfig/ServerConfigPanel.java

Violation Line
These nested if statements could be combined 207 - 209
These nested if statements could be combined 225 - 227

com/atlassian/theplugin/idea/config/serverconfig/ServerTreePanel.java

Violation Line
These nested if statements could be combined 147 - 166
These nested if statements could be combined 214 - 216

com/atlassian/theplugin/idea/crucible/CrucibleConstants.java

Violation Line
Avoid unused imports such as 'com.intellij.openapi.util.JDOMUtil' 4

com/atlassian/theplugin/idea/crucible/CrucibleCustomFilterPanel.java

Violation Line
Avoid empty catch blocks 192 - 194
Avoid empty catch blocks 194 - 196

com/atlassian/theplugin/idea/crucible/CrucibleHelper.java

Violation Line
Avoid unused imports such as 'com.atlassian.theplugin.idea.IdeaHelper' 8
Avoid unused imports such as 'com.intellij.openapi.editor.Document' 12
Avoid unused imports such as 'com.intellij.openapi.vfs.VirtualFileManager' 19
Avoid unused imports such as 'com.intellij.openapi.fileEditor.FileEditor' 22
Avoid unused imports such as 'java.util.Map' 29
Avoid unused imports such as 'java.util.Set' 30
Avoid unused imports such as 'java.net.URL' 32
Avoid unused imports such as 'java.net.MalformedURLException' 33
Avoid unused local variables such as 'ranges'. 157

com/atlassian/theplugin/idea/crucible/CrucibleHelperForm.java

Violation Line
Avoid duplicate imports such as 'javax.swing.Action' 39
Avoid unused local variables such as 'projects'. 187
Avoid unused local variables such as 'users'. 189
Avoid empty catch blocks 195 - 197
Avoid empty catch blocks 197 - 199
Avoid unused method parameters such as 'server'. 210 - 220
Avoid unused local variables such as 'draftReview'. 262
Avoid unused local variables such as 'draftReview'. 275
Avoid unused private methods such as 'createUIComponents()'. 294

com/atlassian/theplugin/idea/crucible/CrucibleNewReviewNotifier.java

Violation Line
Avoid unused imports such as 'com.atlassian.theplugin.idea.IdeaHelper' 24
Avoid unused imports such as 'com.intellij.ide.DataManager' 28
These nested if statements could be combined 157 - 178

com/atlassian/theplugin/idea/crucible/CruciblePatchSubmitCommitSession.java

Violation Line
Avoid unused private fields such as 'LINES_OF_CONTEXT'. 33

com/atlassian/theplugin/idea/crucible/CrucibleReviewCreateForm.java

Violation Line
Avoid duplicate imports such as 'javax.swing.Action' 53
Avoid empty catch blocks 382 - 384
Avoid empty catch blocks 384 - 386

com/atlassian/theplugin/idea/crucible/CrucibleRevisionAddWorker.java

Violation Line
Avoid unused private fields such as 'crucibleServerFacade'. 25
Avoid unused private fields such as 'permId'. 26
Avoid unused private fields such as 'changes'. 27
Avoid unused private fields such as 'revision'. 28

com/atlassian/theplugin/idea/crucible/CrucibleStatusChecker.java

Violation Line
Avoid unused imports such as 'com.intellij.openapi.project.Project' 38

com/atlassian/theplugin/idea/crucible/CrucibleTableToolWindowPanel.java

Violation Line
Avoid duplicate imports such as 'com.intellij.openapi.project.Project' 41
Avoid unused private fields such as 'project'. 56
Avoid unused private fields such as 'instance'. 58
Avoid unused private fields such as 'serverFacade'. 87
These nested if statements could be combined 387 - 390
These nested if statements could be combined 523 - 541
Avoid empty if statements 550 - 728

com/atlassian/theplugin/idea/crucible/CrucibleTreeRenderer.java

Violation Line
Avoid unused private fields such as 'crucibleServersIcon'. 26
Avoid unused private fields such as 'crucibleServerDisabledIcon'. 28
Avoid unused private fields such as 'crucibleSelectAllIcon'. 30

com/atlassian/theplugin/idea/crucible/PatchProducer.java

Violation Line
Avoid unused imports such as 'com.atlassian.theplugin.commons.crucible.CrucibleServerFacade' 19
Avoid unused imports such as 'com.intellij.openapi.application.ApplicationManager' 20
Avoid unused imports such as 'com.intellij.openapi.application.ModalityState' 21
Avoid unused imports such as 'com.intellij.openapi.vcs.changes.CommitSession' 28
Avoid unused imports such as 'org.jetbrains.annotations.Nullable' 35

com/atlassian/theplugin/idea/crucible/ReviewDataInfoAdapter.java

Violation Line
Avoid unused imports such as 'com.atlassian.theplugin.commons.crucible.api.model.User' 22

com/atlassian/theplugin/idea/crucible/comments/CommentAuthorColumn.java

Violation Line
Avoid unused imports such as 'com.atlassian.theplugin.idea.crucible.ReviewDataInfoAdapter' 4

com/atlassian/theplugin/idea/crucible/comments/CommentStateColumn.java

Violation Line
Avoid unused imports such as 'com.atlassian.theplugin.idea.crucible.ReviewDataInfoAdapter' 4

com/atlassian/theplugin/idea/crucible/comments/CommentSummaryColumn.java

Violation Line
Avoid unused imports such as 'com.atlassian.theplugin.idea.crucible.ReviewDataInfoAdapter' 4

com/atlassian/theplugin/idea/crucible/comments/ReviewActionEventBroker.java

Violation Line
Avoid unused imports such as 'com.intellij.openapi.project.Project' 3
Avoid unused imports such as 'com.intellij.util.containers.WeakHashMap' 4
Avoid unused imports such as 'com.atlassian.theplugin.idea.crucible.ReviewDataInfoAdapter' 5
Avoid unused imports such as 'com.atlassian.theplugin.commons.crucible.api.model.ReviewItem' 7

com/atlassian/theplugin/idea/crucible/comments/VCommentAuthorColumn.java

Violation Line
Avoid unused imports such as 'com.atlassian.theplugin.commons.crucible.api.model.GeneralComment' 4

com/atlassian/theplugin/idea/crucible/comments/VCommentCreateDateColumn.java

Violation Line
Avoid unused imports such as 'com.atlassian.theplugin.commons.crucible.api.model.GeneralComment' 4

com/atlassian/theplugin/idea/crucible/comments/VCommentRepliesColumn.java

Violation Line
Avoid unused imports such as 'com.atlassian.theplugin.commons.crucible.api.model.GeneralComment' 4

com/atlassian/theplugin/idea/crucible/comments/VCommentStateColumn.java

Violation Line
Avoid unused imports such as 'com.atlassian.theplugin.commons.crucible.api.model.GeneralComment' 4

com/atlassian/theplugin/idea/crucible/table/column/ReviewReviewersColumn.java

Violation Line
Avoid unused imports such as 'com.atlassian.theplugin.commons.crucible.api.model.User' 21

com/atlassian/theplugin/idea/crucible/tree/CrucibleReviewTreeModel.java

Violation Line
No need to import a type that lives in the same package 5
No need to import a type that lives in the same package 6
No need to import a type that lives in the same package 7
Avoid unused imports such as 'javax.swing.tree.TreeNode' 11

com/atlassian/theplugin/idea/crucible/tree/CrucibleTreeRenderer.java

Violation Line
No need to import a type that lives in the same package 7
No need to import a type that lives in the same package 8
No need to import a type that lives in the same package 10
Avoid unused private fields such as 'MODIFIED_FILE_STR'. 25
Avoid unused private fields such as 'NEW_FILE_STR'. 26
Avoid unused private fields such as 'DELETED_FILE_STR'. 27
Avoid unused private fields such as 'UNKNOWN_FILE_STR'. 28
Avoid unused private fields such as 'crucibleServersIcon'. 31
Avoid unused private fields such as 'crucibleServerDisabledIcon'. 33
Avoid unused private fields such as 'crucibleSelectAllIcon'. 35
Avoid unused private methods such as 'getFileNameFromPath(String)'. 104

com/atlassian/theplugin/idea/crucible/tree/ReviewItemTreePanel.java

Violation Line
Avoid unused imports such as 'com.atlassian.theplugin.idea.Constants' 28
Avoid unused imports such as 'com.atlassian.theplugin.idea.crucible.CrucibleTableToolWindowPanel' 31
Avoid unused private fields such as 'list'. 60
Avoid unused private fields such as 'forceExpand'. 65
Avoid unused private fields such as 'currentFileItem'. 73
Avoid unused constructor parameters such as 'projectConfigurationBean'. 79 - 83
Avoid unused private methods such as 'expandAllPaths()'. 103
These nested if statements could be combined 135 - 137
Avoid unused method parameters such as 'selRow'. 160 - 173
Avoid empty if statements 163 - 165

com/atlassian/theplugin/idea/jira/ChangesetCreate.java

Violation Line
Avoid unused private methods such as 'createUIComponents()'. 71

com/atlassian/theplugin/idea/jira/IssueCreate.java

Violation Line
Avoid unused private fields such as 'LOGGER'. 46

com/atlassian/theplugin/idea/jira/JIRAToolWindowPanel.java

Violation Line
Avoid unused private fields such as 'project'. 59
Avoid empty catch blocks 341 - 343
Avoid empty catch blocks 644 - 646
Avoid empty catch blocks 657 - 659

com/atlassian/theplugin/idea/jira/WorkLogCreate.java

Violation Line
Avoid empty catch blocks 436 - 438

com/atlassian/theplugin/idea/jira/editor/vfs/MemoryVirtualFile.java

Violation Line
Avoid unused imports such as 'com.intellij.openapi.vfs.VirtualFileManager' 7

com/atlassian/theplugin/idea/jira/editor/vfs/MemoryVirtualFileSystem.java

Violation Line
Avoid unused imports such as 'com.intellij.openapi.components.ApplicationComponent' 3

com/atlassian/theplugin/idea/jira/table/renderers/ExtendedIssueInfoCellRenderer.java

Violation Line
Avoid unused local variables such as 'tooltipText'. 91

com/atlassian/theplugin/idea/ui/AbstractTableToolWindowPanel.java

Violation Line
Avoid unused imports such as 'com.atlassian.theplugin.idea.TableColumnInfo' 24

com/atlassian/theplugin/idea/ui/AtlassianTableView.java

Violation Line
Avoid unused private fields such as 'autoAdjustHeight'. 36
Overriding method merely calls super 69 - 71

com/atlassian/theplugin/idea/ui/AtlassianTableViewWithToolbar.java

Violation Line
Avoid unused imports such as 'com.atlassian.theplugin.idea.Constants' 6

com/atlassian/theplugin/idea/ui/CollapsiblePanel.java

Violation Line
Avoid unused private methods such as 'paintAsSelected()'. 343

com/atlassian/theplugin/idea/ui/CollapsibleTable.java

Violation Line
Avoid unused imports such as 'com.atlassian.theplugin.idea.TableColumnInfo' 20
Avoid unused imports such as 'com.intellij.util.ui.UIUtil' 22
Avoid unused imports such as 'java.util.ArrayList' 26
Avoid unused imports such as 'java.util.List' 27

com/atlassian/theplugin/jira/JIRAServerFacade.java

Violation Line
Avoid unused imports such as 'com.atlassian.theplugin.commons.remoteapi.RemoteApiException' 21

com/atlassian/theplugin/jira/api/JIRARssClient.java

Violation Line
Avoid unused private fields such as 'LOGGER'. 42

com/atlassian/theplugin/jira/api/soap/JIRASessionImpl.java

Violation Line
Avoid empty catch blocks 126 - 128

com/atlassian/theplugin/jira/api/soap/axis/JirasoapserviceV2SoapBindingStub.java

Violation Line
Avoid unused local variables such as 'enumsf'. 2622
Avoid unused local variables such as 'enumdf'. 2623
Avoid unused local variables such as 'arraysf'. 2624
Avoid unused local variables such as 'arraydf'. 2625
Avoid unused local variables such as 'simplesf'. 2626
Avoid unused local variables such as 'simpledf'. 2627
Avoid unused local variables such as 'simplelistsf'. 2628
Avoid unused local variables such as 'simplelistdf'. 2629
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 4354
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 4831

com/atlassian/theplugin/jira/api/soap/axis/RemoteAuthenticationException.java

Violation Line
Avoid unused local variables such as 'other'. 33

com/atlassian/theplugin/jira/api/soap/axis/RemoteComponent.java

Violation Line
Avoid unused local variables such as 'other'. 41

com/atlassian/theplugin/jira/api/soap/axis/RemoteEntity.java

Violation Line
Avoid unused local variables such as 'other'. 33

com/atlassian/theplugin/jira/api/soap/axis/RemoteException.java

Violation Line
Avoid unused local variables such as 'other'. 33

com/atlassian/theplugin/jira/api/soap/axis/RemoteField.java

Violation Line
Avoid unused local variables such as 'other'. 41

com/atlassian/theplugin/jira/api/soap/axis/RemoteNamedObject.java

Violation Line
Avoid unused local variables such as 'other'. 41

com/atlassian/theplugin/jira/api/soap/axis/RemotePermissionException.java

Violation Line
Avoid unused local variables such as 'other'. 33

com/atlassian/theplugin/jira/api/soap/axis/RemoteResolution.java

Violation Line
Avoid unused local variables such as 'other'. 45

com/atlassian/theplugin/jira/api/soap/axis/RemoteStatus.java

Violation Line
Avoid unused local variables such as 'other'. 45

com/atlassian/theplugin/jira/api/soap/axis/RemoteValidationException.java

Violation Line
Avoid unused local variables such as 'other'. 33

com/atlassian/theplugin/util/PluginTrustManager.java

Violation Line
Avoid empty catch blocks 134 - 136
Avoid empty catch blocks 276 - 278

thirdparty/javaworld/ClasspathImageView.java

Violation Line
Avoid unused local variables such as 'attr'. 85
Avoid unused private methods such as 'waitForImage()'. 219
These nested if statements could be combined 553 - 555
These nested if statements could be combined 558 - 560
These nested if statements could be combined 600 - 602
Avoid empty if statements 826 - 828
Avoid unused private fields such as 'fGrowProportionally'. 906