The following document contains the results of PMD 4.2.2.
| Violation | Line |
|---|---|
| Avoid unused imports such as 'com.intellij.openapi.ui.Messages.showMessageDialog' | 26 |
| Avoid unused constructor parameters such as 'checker'. | 65 - 93 |
| Violation | Line |
|---|---|
| Avoid unused private methods such as 'createUIComponents()'. | 102 |
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 56 - 58 |
| Avoid empty catch blocks | 87 - 89 |
| Avoid empty catch blocks | 89 - 91 |
| Violation | Line |
|---|---|
| Avoid unused imports such as 'com.intellij.openapi.actionSystem.AnAction' | 3 |
| Avoid unused imports such as 'com.atlassian.theplugin.idea.crucible.CrucibleRevisionReviewCreator' | 9 |
| Avoid unused imports such as 'com.atlassian.theplugin.commons.crucible.CrucibleVersion' | 13 |
| Avoid unused imports such as 'com.atlassian.theplugin.commons.crucible.api.ReviewData' | 14 |
| Violation | Line |
|---|---|
| Avoid unused imports such as 'com.intellij.openapi.vcs.changes.Change' | 7 |
| Avoid unused imports such as 'com.intellij.openapi.vcs.history.VcsRevisionNumber' | 8 |
| Avoid unused imports such as 'com.intellij.openapi.application.ApplicationManager' | 9 |
| Avoid unused imports such as 'com.intellij.openapi.application.ModalityState' | 10 |
| Avoid unused imports such as 'com.atlassian.theplugin.idea.crucible.CruciblePatchUploader' | 11 |
| Avoid unused imports such as 'com.atlassian.theplugin.idea.crucible.CrucibleRevisionReviewCreator' | 12 |
| Avoid unused imports such as 'com.atlassian.theplugin.commons.crucible.CrucibleServerFacadeImpl' | 14 |
| Avoid unused imports such as 'java.util.List' | 17 |
| Avoid unused imports such as 'java.util.ArrayList' | 18 |
| Violation | Line |
|---|---|
| Avoid unused imports such as 'com.atlassian.theplugin.idea.ProgressAnimationProvider' | 20 |
| Avoid unused imports such as 'com.atlassian.theplugin.util.PluginUtil' | 23 |
| Avoid unused imports such as 'com.atlassian.theplugin.commons.util.Logger' | 24 |
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 160 - 162 |
| Avoid empty catch blocks | 168 - 170 |
| Violation | Line |
|---|---|
| These nested if statements could be combined | 194 - 197 |
| Violation | Line |
|---|---|
| Avoid unused imports such as 'com.intellij.uiDesigner.core.Spacer' | 21 |
| Avoid unused private methods such as 'onOK()'. | 72 |
| Violation | Line |
|---|---|
| These nested if statements could be combined | 156 - 160 |
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'LOG'. | 36 |
| Violation | Line |
|---|---|
| Avoid unused private methods such as 'createUIComponents()'. | 157 |
| Violation | Line |
|---|---|
| Avoid unused private methods such as 'createUIComponents()'. | 129 |
| Violation | Line |
|---|---|
| These nested if statements could be combined | 207 - 209 |
| These nested if statements could be combined | 225 - 227 |
| Violation | Line |
|---|---|
| These nested if statements could be combined | 146 - 165 |
| These nested if statements could be combined | 213 - 215 |
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 192 - 194 |
| Avoid empty catch blocks | 194 - 196 |
| Violation | Line |
|---|---|
| Avoid unused local variables such as 'projects'. | 175 |
| Avoid unused local variables such as 'users'. | 177 |
| Avoid empty catch blocks | 183 - 185 |
| Avoid empty catch blocks | 185 - 187 |
| Avoid unused method parameters such as 'server'. | 198 - 208 |
| Avoid unused local variables such as 'draftReviewData'. | 250 |
| Avoid unused private methods such as 'createUIComponents()'. | 266 |
| Violation | Line |
|---|---|
| These nested if statements could be combined | 157 - 178 |
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 382 - 384 |
| Avoid empty catch blocks | 384 - 386 |
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'crucibleServerFacade'. | 25 |
| Avoid unused private fields such as 'permId'. | 26 |
| Avoid unused private fields such as 'changes'. | 27 |
| Avoid unused private fields such as 'revision'. | 28 |
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'serverFacade'. | 82 |
| These nested if statements could be combined | 499 - 517 |
| Violation | Line |
|---|---|
| Avoid unused imports such as 'com.atlassian.theplugin.commons.Server' | 20 |
| Avoid unused imports such as 'com.atlassian.theplugin.commons.crucible.api.CustomFilterData' | 21 |
| Avoid unused imports such as 'java.util.Collection' | 23 |
| Violation | Line |
|---|---|
| Avoid unused imports such as 'com.atlassian.theplugin.commons.crucible.api.UserData' | 19 |
| Violation | Line |
|---|---|
| Avoid unused private methods such as 'createUIComponents()'. | 71 |
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'LOGGER'. | 46 |
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 328 - 330 |
| Avoid empty catch blocks | 631 - 633 |
| Avoid empty catch blocks | 644 - 646 |
| Violation | Line |
|---|---|
| Avoid unused imports such as 'com.intellij.uiDesigner.core.GridLayoutManager' | 22 |
| Avoid unused imports such as 'com.intellij.uiDesigner.core.GridConstraints' | 23 |
| Avoid unused private fields such as 'minutes'. | 52 |
| Avoid unused private fields such as 'hours'. | 53 |
| Avoid unused private fields such as 'days'. | 54 |
| Avoid unused private fields such as 'weeks'. | 55 |
| Avoid empty catch blocks | 339 - 341 |
| Violation | Line |
|---|---|
| Avoid unused local variables such as 'tooltipText'. | 91 |
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'autoAdjustHeight'. | 34 |
| Violation | Line |
|---|---|
| Avoid unused private methods such as 'paintAsSelected()'. | 387 |
| Violation | Line |
|---|---|
| Avoid unused private fields such as 'LOGGER'. | 42 |
| Violation | Line |
|---|---|
| Avoid empty catch blocks | 118 - 120 |
| Violation | Line |
|---|---|
| Avoid unused local variables such as 'enumsf'. | 2622 |
| Avoid unused local variables such as 'enumdf'. | 2623 |
| Avoid unused local variables such as 'arraysf'. | 2624 |
| Avoid unused local variables such as 'arraydf'. | 2625 |
| Avoid unused local variables such as 'simplesf'. | 2626 |
| Avoid unused local variables such as 'simpledf'. | 2627 |
| Avoid unused local variables such as 'simplelistsf'. | 2628 |
| Avoid unused local variables such as 'simplelistdf'. | 2629 |
| Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. | 4354 |
| Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. | 4831 |
| Violation | Line |
|---|---|
| Avoid unused local variables such as 'other'. | 33 |
| Violation | Line |
|---|---|
| Avoid unused local variables such as 'other'. | 41 |
| Violation | Line |
|---|---|
| Avoid unused local variables such as 'other'. | 33 |
| Violation | Line |
|---|---|
| Avoid unused local variables such as 'other'. | 33 |
| Violation | Line |
|---|---|
| Avoid unused local variables such as 'other'. | 41 |
| Violation | Line |
|---|---|
| Avoid unused local variables such as 'other'. | 41 |
| Violation | Line |
|---|---|
| Avoid unused local variables such as 'other'. | 33 |
| Violation | Line |
|---|---|
| Avoid unused local variables such as 'other'. | 45 |
| Violation | Line |
|---|---|
| Avoid unused local variables such as 'other'. | 45 |
| Violation | Line |
|---|---|
| Avoid unused local variables such as 'other'. | 33 |
| Violation | Line |
|---|---|
| Avoid unused local variables such as 'attr'. | 85 |
| Avoid unused private methods such as 'waitForImage()'. | 219 |
| These nested if statements could be combined | 553 - 555 |
| These nested if statements could be combined | 558 - 560 |
| These nested if statements could be combined | 600 - 602 |
| Avoid empty if statements | 826 - 828 |
| Avoid unused private fields such as 'fGrowProportionally'. | 906 |