Checkstyle Results

The following document contains the results of Checkstylerss feed

Summary

Files Infos Infos Warnings Warnings Errors Errors
26 39 91 402

Files

Files Infos Warnings Errors
com/atlassian/gadgets/renderer/internal/AtlassianContainerConfig.java 5 14 13
com/atlassian/gadgets/renderer/internal/AtlassianOAuthCallbackGenerator.java 1 1 3
com/atlassian/gadgets/renderer/internal/BlobCrypterImpl.java 2 2 2
com/atlassian/gadgets/renderer/internal/ContainerDomainProvider.java 1 1 0
com/atlassian/gadgets/renderer/internal/CustomBlobCrypterSecurityTokenDecoder.java 1 5 10
com/atlassian/gadgets/renderer/internal/FeatureImpl.java 2 0 1
com/atlassian/gadgets/renderer/internal/GadgetRequestContextFactoryImpl.java 0 3 8
com/atlassian/gadgets/renderer/internal/GadgetSpecFactoryImpl.java 2 2 6
com/atlassian/gadgets/renderer/internal/GadgetSpecUrlCheckerImpl.java 1 1 8
com/atlassian/gadgets/renderer/internal/SecurityTokenFactoryImpl.java 1 3 2
com/atlassian/gadgets/renderer/internal/guice/AuthModule.java 1 4 4
com/atlassian/gadgets/renderer/internal/guice/InjectorProvider.java 1 1 1
com/atlassian/gadgets/renderer/internal/guice/SalModule.java 1 0 2
com/atlassian/gadgets/renderer/internal/guice/ShindigModule.java 1 5 18
com/atlassian/gadgets/renderer/internal/guice/XercesParseModule.java 2 1 2
com/atlassian/gadgets/renderer/internal/http/HttpClientFetcher.java 1 16 243
com/atlassian/gadgets/renderer/internal/http/TrustedAppContentFetcherFactory.java 1 2 6
com/atlassian/gadgets/renderer/internal/local/LocalGadgetSpecFactory.java 2 4 14
com/atlassian/gadgets/renderer/internal/oauth/AtlassianOAuthFetcher.java 1 6 8
com/atlassian/gadgets/renderer/internal/oauth/AtlassianOAuthFetcherFactory.java 1 1 3
com/atlassian/gadgets/renderer/internal/oauth/AtlassianOAuthStore.java 4 11 13
com/atlassian/gadgets/renderer/internal/rewrite/AtlassianGadgetsContentRewriter.java 2 1 3
com/atlassian/gadgets/renderer/internal/servlet/AtlassianGadgetsGuiceServletContextListener.java 2 1 3
com/atlassian/gadgets/renderer/internal/servlet/GadgetSpecUrlRenderPermissionServletFilter.java 2 5 18
com/atlassian/gadgets/renderer/internal/servlet/RpcRelay.java 1 0 8
com/atlassian/gadgets/renderer/internal/servlet/TrustedAppMakeRequestHandler.java 0 1 3

Rules

Rules Violations Severity
JavadocPackage 7 Errors Error
Translation 0 Errors Error
FileLength 0 Errors Error
FileTabCharacter
  • eachLine: "true"
0 Errors Error
RegexpSingleline
  • message: "Line has trailing spaces."
  • format: "\s+$"
68 Warnings Warning
AnnotationUseStyle 0 Errors Error
MissingDeprecated 0 Errors Error
MissingOverride
  • javaFiveCompatibility: "true"
0 Errors Error
PackageAnnotation 0 Errors Error
JavadocMethod
  • excludeScope: "private"
  • scope: "anoninner"
1 Errors Error
JavadocType
  • scope: "package"
14 Errors Error
JavadocVariable
  • scope: "package"
10 Errors Error
JavadocStyle
  • scope: "package"
2 Errors Error
ConstantName 2 Errors Error
LocalFinalVariableName 0 Errors Error
LocalVariableName 0 Errors Error
MemberName 0 Errors Error
MethodName 0 Errors Error
PackageName 0 Errors Error
ParameterName 0 Errors Error
StaticVariableName 0 Errors Error
TypeName 0 Errors Error
AvoidStarImport 0 Errors Error
IllegalImport 0 Errors Error
ImportOrder
  • separated: "true"
  • groups: "java,javax,com.atlassian,com,org"
53 Errors Error
RedundantImport 0 Errors Error
UnusedImports 2 Errors Error
LineLength
  • max: "120"
23 Warnings Warning
MethodLength 0 Errors Error
ParameterNumber 0 Errors Error
EmptyForIteratorPad 0 Errors Error
MethodParamPad 1 Errors Error
NoWhitespaceAfter 1 Errors Error
NoWhitespaceBefore 0 Errors Error
OperatorWrap 4 Errors Error
ParenPad 0 Errors Error
TypecastParenPad 0 Errors Error
WhitespaceAfter 2 Errors Error
WhitespaceAround 17 Errors Error
ModifierOrder 7 Errors Error
RedundantModifier 0 Errors Error
AvoidNestedBlocks 0 Errors Error
EmptyBlock 0 Errors Error
LeftCurly
  • option: "nl"
43 Errors Error
NeedBraces 0 Errors Error
RightCurly
  • option: "alone"
4 Errors Error
DeclarationOrder 10 Errors Error
DefaultComesLast 0 Errors Error
DoubleCheckedLocking 0 Errors Error
EmptyStatement 0 Errors Error
EqualsHashCode 0 Errors Error
ExplicitInitialization 0 Errors Error
FallThrough 0 Errors Error
HiddenField
  • ignoreConstructorParameter: "true"
  • ignoreSetter: "true"
1 Errors Error
IllegalInstantiation 0 Errors Error
InnerAssignment 0 Errors Error
MagicNumber 2 Errors Error
MissingSwitchDefault 2 Errors Error
ParameterAssignment 0 Errors Error
RedundantThrows
  • allowUnchecked: "true"
3 Errors Error
SimplifyBooleanExpression 0 Errors Error
SimplifyBooleanReturn 0 Errors Error
StringLiteralEquality 0 Errors Error
DesignForExtension 39 Infos Info
FinalClass 0 Errors Error
HideUtilityClassConstructor 2 Errors Error
InterfaceIsType 0 Errors Error
VisibilityModifier 0 Errors Error
BooleanExpressionComplexity 1 Errors Error
ClassDataAbstractionCoupling 1 Errors Error
ClassFanOutComplexity
  • max: "10"
5 Errors Error
CyclomaticComplexity 0 Errors Error
NPathComplexity
  • max: "20"
2 Errors Error
JavaNCSS 0 Errors Error
ArrayTypeStyle 0 Errors Error
Indentation 204 Errors Error
TodoComment 0 Errors Error
UpperEll 0 Errors Error

Details

com/atlassian/gadgets/renderer/internal/AtlassianContainerConfig.java

Violation Message Line
Errors 'org.apache.shindig.common.ContainerConfig' should be separated from previous imports. 14
Warnings Line has trailing spaces. 22
Errors Missing a Javadoc comment. 27
Errors Utility classes should not have a public or default constructor. 27
Errors Missing a Javadoc comment. 29
Errors Missing a Javadoc comment. 30
Warnings Line has trailing spaces. 32
Errors Missing a Javadoc comment. 33
Errors Missing a Javadoc comment. 34
Warnings Line has trailing spaces. 35
Warnings Line has trailing spaces. 40
Warnings Line is longer than 120 characters. 53
Errors method call child at indentation level 11 not at correct indentation, 12 93
Errors method call child at indentation level 11 not at correct indentation, 12 99
Errors method call child at indentation level 11 not at correct indentation, 12 103
Errors method call child at indentation level 11 not at correct indentation, 12 115
Errors method call child at indentation level 11 not at correct indentation, 12 123
Warnings Line has trailing spaces. 138
Warnings Line has trailing spaces. 140
Warnings Line has trailing spaces. 141
Errors '(' is preceded with whitespace. 149
Warnings Line has trailing spaces. 157
Warnings Line has trailing spaces. 159
Warnings Line has trailing spaces. 160
Warnings Line has trailing spaces. 176
Warnings Line has trailing spaces. 178
Warnings Line has trailing spaces. 179
Infos Method 'getContainers' is not designed for extension - needs to be abstract, final or empty. 197
Infos Method 'getJson' is not designed for extension - needs to be abstract, final or empty. 214
Infos Method 'get' is not designed for extension - needs to be abstract, final or empty. 248
Infos Method 'getJsonObject' is not designed for extension - needs to be abstract, final or empty. 254
Infos Method 'getJsonArray' is not designed for extension - needs to be abstract, final or empty. 260

com/atlassian/gadgets/renderer/internal/AtlassianOAuthCallbackGenerator.java

Violation Message Line
Errors Unused import - org.apache.shindig.gadgets.oauth.GadgetOAuthCallbackGenerator. 4
Errors Wrong order for 'com.google.inject.Singleton' import. 10
Infos Method 'generateCallback' is not designed for extension - needs to be abstract, final or empty. 19
Warnings Line has trailing spaces. 22
Errors method def throws at indentation level 12 not at correct indentation, 8 23

com/atlassian/gadgets/renderer/internal/BlobCrypterImpl.java

Violation Message Line
Errors Missing a Javadoc comment. 16
Warnings Line has trailing spaces. 31
Errors Missing a Javadoc comment. 40
Warnings Line has trailing spaces. 55
Infos Method 'unwrap' is not designed for extension - needs to be abstract, final or empty. 56
Infos Method 'wrap' is not designed for extension - needs to be abstract, final or empty. 61

com/atlassian/gadgets/renderer/internal/ContainerDomainProvider.java

Violation Message Line
Warnings Line has trailing spaces. 21
Infos Method 'getDomain' is not designed for extension - needs to be abstract, final or empty. 24

com/atlassian/gadgets/renderer/internal/CustomBlobCrypterSecurityTokenDecoder.java

Violation Message Line
Errors Missing package-info.java file. 0
Errors Wrong order for 'java.util.Map' import. 5
Errors Wrong order for 'com.atlassian.gadgets.renderer.internal.AtlassianContainerConfig.Containers' import. 14
Errors Missing a Javadoc comment. 16
Warnings Line has trailing spaces. 24
Infos Method 'createToken' is not designed for extension - needs to be abstract, final or empty. 30
Warnings Line has trailing spaces. 60
Errors Static variable definition in wrong order. 61
Errors Static variable definition in wrong order. 63
Errors Static variable definition in wrong order. 64
Errors Static variable definition in wrong order. 65
Errors Static variable definition in wrong order. 66
Errors Static variable definition in wrong order. 67
Warnings Line has trailing spaces. 72
Warnings Line has trailing spaces. 74
Warnings Line has trailing spaces. 80

com/atlassian/gadgets/renderer/internal/FeatureImpl.java

Violation Message Line
Errors Missing a Javadoc comment. 5
Infos Method 'getParameterValue' is not designed for extension - needs to be abstract, final or empty. 14
Infos Method 'getName' is not designed for extension - needs to be abstract, final or empty. 19

com/atlassian/gadgets/renderer/internal/GadgetRequestContextFactoryImpl.java

Violation Message Line
Errors Wrong order for 'com.atlassian.gadgets.GadgetRequestContextFactory' import. 5
Errors Wrong order for 'com.atlassian.gadgets.GadgetRequestContext' import. 6
Errors Wrong order for 'javax.servlet.http.HttpServletRequest' import. 9
Errors Wrong order for 'java.util.Locale' import. 10
Errors Missing a Javadoc comment. 19
Errors 'static' modifier out of order with the JLS suggestions. 19
Errors Missing a Javadoc comment. 20
Errors 'static' modifier out of order with the JLS suggestions. 20
Warnings Line has trailing spaces. 28
Warnings Line has trailing spaces. 58
Warnings Line is longer than 120 characters. 59

com/atlassian/gadgets/renderer/internal/GadgetSpecFactoryImpl.java

Violation Message Line
Errors Wrong order for 'java.util.Collections.unmodifiableCollection' import. 6
Errors Wrong order for 'java.net.URI' import. 9
Errors Wrong order for 'com.atlassian.gadgets.GadgetParsingException' import. 26
Errors 'com.google.common.base.Function' should be separated from previous imports. 36
Errors Class Fan-Out Complexity is 23 (max allowed is 10). 43
Warnings Line is longer than 120 characters. 68
Infos Method 'getGadgetSpec' is not designed for extension - needs to be abstract, final or empty. 68
Infos Method 'getGadgetSpec' is not designed for extension - needs to be abstract, final or empty. 73
Errors ',' is not followed by whitespace. 75
Warnings Line has trailing spaces. 119

com/atlassian/gadgets/renderer/internal/GadgetSpecUrlCheckerImpl.java

Violation Message Line
Errors Wrong order for 'com.atlassian.gadgets.GadgetSpecUriNotAllowedException' import. 8
Errors 'com.google.common.collect.Iterables' should be separated from previous imports. 12
Infos Method 'assertRenderable' is not designed for extension - needs to be abstract, final or empty. 49
Errors NPath Complexity is 36 (max allowed is 20). 49
Errors '+' should be on a new line. 54
Warnings Line has trailing spaces. 63
Errors '+' should be on a new line. 79
Errors switch without "default" clause. 82
Errors '+' should be on a new line. 85
Errors '+' should be on a new line. 99

com/atlassian/gadgets/renderer/internal/SecurityTokenFactoryImpl.java

Violation Message Line
Errors Wrong order for 'com.atlassian.gadgets.view.SecurityTokenFactory' import. 6
Errors Missing a Javadoc comment. 13
Warnings Line has trailing spaces. 27
Infos Method 'newSecurityToken' is not designed for extension - needs to be abstract, final or empty. 28
Warnings Line is longer than 120 characters. 30
Warnings Line has trailing spaces. 39

com/atlassian/gadgets/renderer/internal/guice/AuthModule.java

Violation Message Line
Errors Wrong order for 'org.apache.shindig.gadgets.oauth.OAuthModule.OAuthCrypterProvider' import. 9
Errors Wrong order for 'com.atlassian.gadgets.renderer.internal.AtlassianOAuthCallbackGenerator' import. 12
Errors 'com.google.inject.AbstractModule' should be separated from previous imports. 17
Errors Unused import - com.google.inject.Module. 18
Warnings Line has trailing spaces. 35
Infos Method 'configure' is not designed for extension - needs to be abstract, final or empty. 36
Warnings Line has trailing spaces. 50
Warnings Line has trailing spaces. 53
Warnings Line has trailing spaces. 56

com/atlassian/gadgets/renderer/internal/guice/InjectorProvider.java

Violation Message Line
Errors First sentence should end with a period. 8
Warnings Line has trailing spaces. 14
Infos Method 'get' is not designed for extension - needs to be abstract, final or empty. 24

com/atlassian/gadgets/renderer/internal/guice/SalModule.java

Violation Message Line
Errors 'com.google.inject.AbstractModule' should be separated from previous imports. 7
Errors Missing a Javadoc comment. 9
Infos Method 'configure' is not designed for extension - needs to be abstract, final or empty. 27

com/atlassian/gadgets/renderer/internal/guice/ShindigModule.java

Violation Message Line
Errors Missing package-info.java file. 0
Errors Wrong order for 'java.io.IOException' import. 5
Errors Wrong order for 'com.atlassian.gadgets.LocalGadgetSpecProvider' import. 28
Errors 'com.google.common.collect.ImmutableList' should be separated from previous imports. 34
Errors 'static' modifier out of order with the JLS suggestions. 49
Errors 'static' modifier out of order with the JLS suggestions. 50
Errors 'properties' hides a field. 67
Infos Method 'configure' is not designed for extension - needs to be abstract, final or empty. 86
Warnings Line has trailing spaces. 90
Errors '{' is not followed by whitespace. 97
Errors '}' is not preceded with whitespace. 97
Warnings Line has trailing spaces. 100
Warnings Line has trailing spaces. 101
Warnings Line is longer than 120 characters. 101
Errors '{' is not preceded with whitespace. 108
Errors '{' is not followed by whitespace. 108
Errors '}' is not preceded with whitespace. 108
Errors '{' is not preceded with whitespace. 109
Errors '{' is not followed by whitespace. 109
Errors '}' is not preceded with whitespace. 109
Errors Missing a Javadoc comment. 116
Warnings Line has trailing spaces. 121
Errors Missing a Javadoc comment. 133
Errors '{' should be on a new line. 143

com/atlassian/gadgets/renderer/internal/guice/XercesParseModule.java

Violation Message Line
Errors Wrong order for 'com.google.inject.AbstractModule' import. 8
Infos Method 'configure' is not designed for extension - needs to be abstract, final or empty. 17
Warnings Line has trailing spaces. 23
Errors Missing a Javadoc comment. 24
Infos Method 'get' is not designed for extension - needs to be abstract, final or empty. 26

com/atlassian/gadgets/renderer/internal/http/HttpClientFetcher.java

Violation Message Line
Errors 'org.apache.commons.io.IOUtils' should be separated from previous imports. 7
Errors Wrong order for 'javax.net.ssl.SSLException' import. 47
Errors Wrong order for 'java.io.IOException' import. 49
Errors Class Data Abstraction Coupling is 10 (max allowed is 7) classes [BasicHeader, BasicHttpParams, CustomSSLSocketFactory, DefaultHttpClient, GzipDeflatingInterceptor, HttpCacheKey, HttpResponseBuilder, InputStreamEntity, ProxySelectorRoutePlanner, Scheme]. 65
Errors Class Fan-Out Complexity is 26 (max allowed is 10). 65
Errors '{' should be on a new line. 66
Errors member def modifier at indentation level 2 not at correct indentation, 4 67
Errors member def modifier at indentation level 2 not at correct indentation, 4 69
Errors member def modifier at indentation level 2 not at correct indentation, 4 71
Errors ctor def modifier at indentation level 2 not at correct indentation, 4 73
Errors ctor def modifier at indentation level 2 not at correct indentation, 4 74
Errors '{' should be on a new line. 74
Errors ctor def child at indentation level 6 not at correct indentation, 8 75
Errors ctor def rcurly at indentation level 2 not at correct indentation, 4 76
Errors method def modifier at indentation level 2 not at correct indentation, 4 79
Infos Method 'fetch' is not designed for extension - needs to be abstract, final or empty. 79
Errors '{' should be on a new line. 79
Errors method def child at indentation level 4 not at correct indentation, 8 80
Errors method def child at indentation level 4 not at correct indentation, 8 81
Errors if at indentation level 4 not at correct indentation, 8 82
Errors '{' should be on a new line. 82
Errors if child at indentation level 6 not at correct indentation, 12 83
Errors if rcurly at indentation level 4 not at correct indentation, 8 84
Errors try at indentation level 4 not at correct indentation, 8 85
Errors '{' should be on a new line. 85
Errors try child at indentation level 6 not at correct indentation, 12 86
Errors if at indentation level 6 not at correct indentation, 12 87
Errors '{' should be on a new line. 87
Warnings Line is longer than 120 characters. 88
Errors if child at indentation level 8 not at correct indentation, 16 88
Errors method call child at indentation level 8 not at correct indentation, 16 88
Errors if rcurly at indentation level 6 not at correct indentation, 12 89
Errors try child at indentation level 6 not at correct indentation, 12 90
Errors try at indentation level 6 not at correct indentation, 12 91
Errors '{' should be on a new line. 91
Errors try child at indentation level 8 not at correct indentation, 16 93
Errors try rcurly at indentation level 6 not at correct indentation, 12 94
Errors '}' should be alone on a line. 94
Errors '{' should be on a new line. 94
Errors catch child at indentation level 10 not at correct indentation, 16 95
Errors method call child at indentation level 10 not at correct indentation, 16 95
Errors catch child at indentation level 10 not at correct indentation, 16 97
Errors catch rcurly at indentation level 6 not at correct indentation, 12 98
Errors try child at indentation level 6 not at correct indentation, 12 99
Errors try child at indentation level 6 not at correct indentation, 12 100
Errors try rcurly at indentation level 4 not at correct indentation, 8 101
Errors '}' should be alone on a line. 101
Errors '{' should be on a new line. 101
Errors if at indentation level 6 not at correct indentation, 12 102
Errors '{' should be on a new line. 102
Errors if child at indentation level 10 not at correct indentation, 16 103
Errors if rcurly at indentation level 6 not at correct indentation, 12 104
Errors '}' should be alone on a line. 104
Errors '{' should be on a new line. 104
Errors else child at indentation level 10 not at correct indentation, 16 105
Errors method call child at indentation level 10 not at correct indentation, 16 105
Errors else rcurly at indentation level 6 not at correct indentation, 12 106
Warnings Line has trailing spaces. 107
Errors catch child at indentation level 6 not at correct indentation, 12 108
Errors catch rcurly at indentation level 4 not at correct indentation, 8 109
Errors method def rcurly at indentation level 2 not at correct indentation, 4 110
Errors method def modifier at indentation level 2 not at correct indentation, 4 112
Errors method def lcurly at indentation level 2 not at correct indentation, 4 113
Errors method def child at indentation level 6 not at correct indentation, 8 114
Errors method call child at indentation level 6 not at correct indentation, 8 115
Errors method def child at indentation level 6 not at correct indentation, 8 115
Errors if at indentation level 6 not at correct indentation, 8 118
Errors 'if' is not followed by whitespace. 118
Errors if lcurly at indentation level 6 not at correct indentation, 8 119
Errors if child at indentation level 10 not at correct indentation, 12 120
Errors method call child at indentation level 10 not at correct indentation, 12 120
Errors if child at indentation level 10 not at correct indentation, 12 121
Errors method call child at indentation level 10 not at correct indentation, 12 121
Errors '3' is a magic number. 121
Errors if rcurly at indentation level 6 not at correct indentation, 8 122
Warnings Line is longer than 120 characters. 123
Errors method call child at indentation level 6 not at correct indentation, 8 123
Errors method def child at indentation level 6 not at correct indentation, 8 123
Errors method def child at indentation level 6 not at correct indentation, 8 124
Errors method def child at indentation level 6 not at correct indentation, 8 126
Errors method call child at indentation level 6 not at correct indentation, 8 129
Errors method def child at indentation level 6 not at correct indentation, 8 129
Errors method call child at indentation level 6 not at correct indentation, 8 131
Errors method def child at indentation level 6 not at correct indentation, 8 131
Warnings Line is longer than 120 characters. 132
Errors method call child at indentation level 6 not at correct indentation, 8 132
Errors method def child at indentation level 6 not at correct indentation, 8 132
Errors '443' is a magic number. 132
Errors method def child at indentation level 6 not at correct indentation, 8 133
Errors method def rcurly at indentation level 2 not at correct indentation, 4 134
Errors method def modifier at indentation level 2 not at correct indentation, 4 136
Errors '{' should be on a new line. 136
Errors method def child at indentation level 4 not at correct indentation, 8 137
Errors method def child at indentation level 4 not at correct indentation, 8 138
Errors for at indentation level 4 not at correct indentation, 8 140
Errors '{' should be on a new line. 140
Errors for child at indentation level 6 not at correct indentation, 12 141
Errors method call child at indentation level 6 not at correct indentation, 12 141
Errors for rcurly at indentation level 4 not at correct indentation, 8 142
Errors method def child at indentation level 4 not at correct indentation, 8 143
Errors method def rcurly at indentation level 2 not at correct indentation, 4 144
Warnings Line has trailing spaces. 146
Errors method def modifier at indentation level 2 not at correct indentation, 4 146
Errors '{' should be on a new line. 146
Errors method def child at indentation level 4 not at correct indentation, 8 147
Errors for at indentation level 4 not at correct indentation, 8 148
Errors '{' should be on a new line. 148
Errors for child at indentation level 8 not at correct indentation, 12 149
Errors method call child at indentation level 8 not at correct indentation, 12 149
Errors for rcurly at indentation level 4 not at correct indentation, 8 150
Errors method def child at indentation level 4 not at correct indentation, 8 152
Errors method def rcurly at indentation level 2 not at correct indentation, 4 156
Warnings Line has trailing spaces. 158
Errors class def child at indentation level 2 not at correct indentation, 4 162
Errors class def ident at indentation level 2 not at correct indentation, 4 162
Errors class def modifier at indentation level 2 not at correct indentation, 4 162
Errors '{' should be on a new line. 162
Errors member def modifier at indentation level 4 not at correct indentation, 8 163
Errors member def modifier at indentation level 4 not at correct indentation, 8 164
Errors ctor def modifier at indentation level 4 not at correct indentation, 8 166
Errors '{' should be on a new line. 166
Errors ctor def child at indentation level 6 not at correct indentation, 12 167
Errors ctor def rcurly at indentation level 4 not at correct indentation, 8 168
Warnings Line has trailing spaces. 169
Errors method def modifier at indentation level 4 not at correct indentation, 8 170
Errors '{' should be on a new line. 170
Errors method def child at indentation level 6 not at correct indentation, 12 171
Errors method call child at indentation level 6 not at correct indentation, 12 172
Errors method def child at indentation level 6 not at correct indentation, 12 172
Errors '{' is followed by whitespace. 172
Errors method def child at indentation level 6 not at correct indentation, 12 173
Errors method def rcurly at indentation level 4 not at correct indentation, 8 174
Warnings Line is longer than 120 characters. 176
Errors method def modifier at indentation level 4 not at correct indentation, 8 176
Errors method def throws at indentation level 8 not at correct indentation, 12 177
Errors Redundant throws: 'UnknownHostException' is subclass of 'IOException'. 177
Errors Redundant throws: 'ConnectTimeoutException' is subclass of 'IOException'. 177
Errors '{' should be on a new line. 177
Errors method def child at indentation level 6 not at correct indentation, 12 178
Errors method def rcurly at indentation level 4 not at correct indentation, 8 179
Errors method def modifier at indentation level 4 not at correct indentation, 8 181
Errors '{' should be on a new line. 181
Errors method def child at indentation level 6 not at correct indentation, 12 182
Errors method def rcurly at indentation level 4 not at correct indentation, 8 183
Warnings Line is longer than 120 characters. 185
Errors method def modifier at indentation level 4 not at correct indentation, 8 185
Errors Redundant throws: 'UnknownHostException' is subclass of 'IOException'. 185
Errors '{' should be on a new line. 185
Errors method def child at indentation level 6 not at correct indentation, 12 186
Errors method def rcurly at indentation level 4 not at correct indentation, 8 187
Errors class def rcurly at indentation level 2 not at correct indentation, 4 188
Warnings Line has trailing spaces. 189
Errors class def child at indentation level 2 not at correct indentation, 4 190
Errors class def ident at indentation level 2 not at correct indentation, 4 190
Errors class def modifier at indentation level 2 not at correct indentation, 4 190
Errors '{' should be on a new line. 190
Warnings Line is longer than 120 characters. 191
Errors method def modifier at indentation level 4 not at correct indentation, 8 191
Errors '{' should be on a new line. 191
Errors method def child at indentation level 6 not at correct indentation, 12 192
Errors method def child at indentation level 6 not at correct indentation, 12 193
Errors if at indentation level 6 not at correct indentation, 12 194
Errors '{' should be on a new line. 194
Errors if child at indentation level 8 not at correct indentation, 16 195
Errors for at indentation level 8 not at correct indentation, 16 196
Errors '{' should be on a new line. 196
Errors if at indentation level 10 not at correct indentation, 20 197
Errors '{' should be on a new line. 197
Errors if child at indentation level 12 not at correct indentation, 24 198
Errors method call child at indentation level 12 not at correct indentation, 24 198
Errors if child at indentation level 12 not at correct indentation, 24 199
Errors if rcurly at indentation level 10 not at correct indentation, 20 200
Errors '}' should be alone on a line. 200
Errors '{' should be on a new line. 200
Errors if child at indentation level 12 not at correct indentation, 24 201
Errors method call child at indentation level 12 not at correct indentation, 24 201
Errors if child at indentation level 12 not at correct indentation, 24 202
Errors if rcurly at indentation level 10 not at correct indentation, 20 203
Errors for rcurly at indentation level 8 not at correct indentation, 16 204
Errors if rcurly at indentation level 6 not at correct indentation, 12 205
Errors method def rcurly at indentation level 4 not at correct indentation, 8 206
Errors class def rcurly at indentation level 2 not at correct indentation, 4 207
Warnings Line has trailing spaces. 208
Errors class def child at indentation level 2 not at correct indentation, 4 209
Errors class def ident at indentation level 2 not at correct indentation, 4 209
Errors class def modifier at indentation level 2 not at correct indentation, 4 209
Errors 'abstract' modifier out of order with the JLS suggestions. 209
Errors '{' should be on a new line. 209
Errors ctor def modifier at indentation level 4 not at correct indentation, 8 210
Errors '{' should be on a new line. 210
Errors ctor def rcurly at indentation level 4 not at correct indentation, 8 212
Warnings Line has trailing spaces. 213
Errors method def modifier at indentation level 4 not at correct indentation, 8 214
Errors method def modifier at indentation level 4 not at correct indentation, 8 215
Errors '{' should be on a new line. 215
Errors method def child at indentation level 6 not at correct indentation, 12 217
Errors method def rcurly at indentation level 4 not at correct indentation, 8 218
Errors method def modifier at indentation level 4 not at correct indentation, 8 220
Errors method def modifier at indentation level 4 not at correct indentation, 8 221
Errors '{' should be on a new line. 221
Errors method def child at indentation level 6 not at correct indentation, 12 223
Errors method def rcurly at indentation level 4 not at correct indentation, 8 224
Warnings Line has trailing spaces. 225
Errors method def modifier at indentation level 4 not at correct indentation, 8 226
Errors class def rcurly at indentation level 2 not at correct indentation, 4 227
Warnings Line has trailing spaces. 228
Errors class def child at indentation level 2 not at correct indentation, 4 229
Errors class def ident at indentation level 2 not at correct indentation, 4 229
Errors class def modifier at indentation level 2 not at correct indentation, 4 229
Errors '{' should be on a new line. 229
Errors ctor def modifier at indentation level 4 not at correct indentation, 8 230
Errors '{' should be on a new line. 230
Errors ctor def rcurly at indentation level 4 not at correct indentation, 8 232
Errors method def modifier at indentation level 4 not at correct indentation, 8 234
Errors method def modifier at indentation level 4 not at correct indentation, 8 235
Errors '{' should be on a new line. 235
Errors method def child at indentation level 6 not at correct indentation, 12 236
Errors method def rcurly at indentation level 4 not at correct indentation, 8 237
Errors class def rcurly at indentation level 2 not at correct indentation, 4 238
Errors class def child at indentation level 2 not at correct indentation, 4 240
Errors class def ident at indentation level 2 not at correct indentation, 4 240
Errors class def modifier at indentation level 2 not at correct indentation, 4 240
Errors '{' should be on a new line. 240
Errors ctor def modifier at indentation level 4 not at correct indentation, 8 241
Errors '{' should be on a new line. 241
Errors ctor def rcurly at indentation level 4 not at correct indentation, 8 243
Errors method def modifier at indentation level 4 not at correct indentation, 8 245
Errors method def modifier at indentation level 4 not at correct indentation, 8 246
Errors '{' should be on a new line. 246
Errors method def child at indentation level 6 not at correct indentation, 12 247
Errors method def rcurly at indentation level 4 not at correct indentation, 8 248
Errors class def rcurly at indentation level 2 not at correct indentation, 4 249
Errors enum def child at indentation level 2 not at correct indentation, 4 251
Errors enum def ident at indentation level 2 not at correct indentation, 4 251
Errors enum def modifier at indentation level 2 not at correct indentation, 4 251
Errors '{' should be on a new line. 251
Warnings Line has trailing spaces. 253
Errors method def modifier at indentation level 4 not at correct indentation, 8 254
Errors '{' should be on a new line. 254
Errors switch at indentation level 6 not at correct indentation, 12 255
Errors switch without "default" clause. 255
Errors '{' should be on a new line. 255
Errors block child at indentation level 8 not at correct indentation, 20 256
Errors case child at indentation level 8 not at correct indentation, 16 256
Errors block child at indentation level 8 not at correct indentation, 20 257
Errors case child at indentation level 8 not at correct indentation, 16 257
Errors block child at indentation level 8 not at correct indentation, 20 258
Errors case child at indentation level 8 not at correct indentation, 16 258
Errors block child at indentation level 8 not at correct indentation, 20 259
Errors case child at indentation level 8 not at correct indentation, 16 259
Errors block child at indentation level 8 not at correct indentation, 20 260
Errors case child at indentation level 8 not at correct indentation, 16 260
Errors block child at indentation level 8 not at correct indentation, 20 261
Errors case child at indentation level 8 not at correct indentation, 16 261
Errors block child at indentation level 8 not at correct indentation, 20 262
Errors case child at indentation level 8 not at correct indentation, 16 262
Errors switch rcurly at indentation level 6 not at correct indentation, 12 263
Errors method def child at indentation level 6 not at correct indentation, 12 264
Errors method def rcurly at indentation level 4 not at correct indentation, 8 265
Errors enum def rcurly at indentation level 2 not at correct indentation, 4 266

com/atlassian/gadgets/renderer/internal/http/TrustedAppContentFetcherFactory.java

Violation Message Line
Errors Missing package-info.java file. 0
Errors Wrong order for 'org.apache.shindig.gadgets.GadgetException' import. 5
Errors Wrong order for 'com.atlassian.sal.api.user.UserManager' import. 12
Errors 'com.google.inject.Inject' should be separated from previous imports. 16
Warnings Line has trailing spaces. 38
Infos Method 'fetch' is not designed for extension - needs to be abstract, final or empty. 39
Warnings Line has trailing spaces. 49
Errors '!=' is not preceded with whitespace. 50
Errors '!=' is not followed by whitespace. 50

com/atlassian/gadgets/renderer/internal/local/LocalGadgetSpecFactory.java

Violation Message Line
Errors Missing package-info.java file. 0
Errors Wrong order for 'com.google.common.collect.MapMaker' import. 13
Errors 'org.apache.commons.logging.Log' should be separated from previous imports. 17
Errors Missing a Javadoc comment. 49
Errors Static variable definition in wrong order. 49
Errors Variable access definition in wrong order. 49
Errors Missing a Javadoc comment. 50
Errors Static variable definition in wrong order. 50
Errors Variable access definition in wrong order. 50
Infos Method 'getGadgetSpec' is not designed for extension - needs to be abstract, final or empty. 52
Infos Method 'getGadgetSpec' is not designed for extension - needs to be abstract, final or empty. 65
Errors 'static' modifier out of order with the JLS suggestions. 85
Errors Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 85
Errors 'static' modifier out of order with the JLS suggestions. 145
Errors Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 145
Errors NPath Complexity is 33 (max allowed is 20). 154
Warnings Line is longer than 120 characters. 181
Warnings Line is longer than 120 characters. 190
Warnings Line is longer than 120 characters. 199
Warnings Line is longer than 120 characters. 204

com/atlassian/gadgets/renderer/internal/oauth/AtlassianOAuthFetcher.java

Violation Message Line
Errors Missing package-info.java file. 0
Errors Wrong order for 'net.oauth.OAuth.Parameter' import. 9
Errors Wrong order for 'org.apache.shindig.gadgets.http.HttpFetcher' import. 11
Errors Wrong order for 'com.atlassian.oauth.Request' import. 16
Errors Wrong order for 'com.atlassian.oauth.Request.HttpMethod' import. 18
Errors Missing a Javadoc comment. 25
Errors Class Fan-Out Complexity is 11 (max allowed is 10). 25
Warnings Line has trailing spaces. 29
Warnings Line has trailing spaces. 30
Warnings Line has trailing spaces. 31
Infos Method 'sign' is not designed for extension - needs to be abstract, final or empty. 38
Errors method def throws at indentation level 12 not at correct indentation, 8 40
Warnings Line has trailing spaces. 47
Warnings Line is longer than 120 characters. 56
Warnings Line has trailing spaces. 58

com/atlassian/gadgets/renderer/internal/oauth/AtlassianOAuthFetcherFactory.java

Violation Message Line
Errors Wrong order for 'com.atlassian.oauth.consumer.ConsumerService' import. 10
Errors 'com.google.inject.Inject' should be separated from previous imports. 11
Errors First sentence should end with a period. 30
Warnings Line has trailing spaces. 32
Infos Method 'getOAuthFetcher' is not designed for extension - needs to be abstract, final or empty. 35

com/atlassian/gadgets/renderer/internal/oauth/AtlassianOAuthStore.java

Violation Message Line
Errors 'org.apache.commons.lang.StringUtils.isBlank' should be separated from previous imports. 4
Errors Wrong order for 'java.util.Map' import. 8
Errors Wrong order for 'org.apache.shindig.auth.SecurityToken' import. 12
Errors Wrong order for 'com.atlassian.gadgets.util.Uri' import. 16
Errors 'com.google.common.collect.ImmutableMap' should be separated from previous imports. 25
Warnings Line is longer than 120 characters. 29
Errors Class Fan-Out Complexity is 14 (max allowed is 10). 33
Warnings Line has trailing spaces. 36
Warnings Line has trailing spaces. 50
Warnings Line is longer than 120 characters. 51
Infos Method 'getConsumerKeyAndSecret' is not designed for extension - needs to be abstract, final or empty. 51
Warnings Line is longer than 120 characters. 60
Infos Method 'getTokenInfo' is not designed for extension - needs to be abstract, final or empty. 60
Warnings Line is longer than 120 characters. 74
Infos Method 'setTokenInfo' is not designed for extension - needs to be abstract, final or empty. 74
Errors Boolean expression complexity is 4 (max allowed is 3). 83
Errors if child at indentation level 9 not at correct indentation, 12 84
Errors if child at indentation level 9 not at correct indentation, 12 85
Errors if child at indentation level 9 not at correct indentation, 12 86
Warnings Line has trailing spaces. 91
Warnings Line has trailing spaces. 96
Warnings Line is longer than 120 characters. 97
Infos Method 'removeToken' is not designed for extension - needs to be abstract, final or empty. 97
Warnings Line has trailing spaces. 120
Errors Utility classes should not have a public or default constructor. 140
Errors Missing a Javadoc comment. 142
Errors Missing a Javadoc comment. 143
Warnings Line is longer than 120 characters. 156

com/atlassian/gadgets/renderer/internal/rewrite/AtlassianGadgetsContentRewriter.java

Violation Message Line
Errors Missing package-info.java file. 0
Errors Wrong order for 'com.google.inject.Inject' import. 6
Errors Missing a Javadoc comment. 10
Infos Method 'getProxyUrl' is not designed for extension - needs to be abstract, final or empty. 32
Warnings Line has trailing spaces. 37
Infos Method 'getConcatUrl' is not designed for extension - needs to be abstract, final or empty. 42

com/atlassian/gadgets/renderer/internal/servlet/AtlassianGadgetsGuiceServletContextListener.java

Violation Message Line
Errors Missing package-info.java file. 0
Errors Wrong order for 'com.google.inject.Injector' import. 9
Errors Missing a Javadoc comment. 12
Warnings Line has trailing spaces. 20
Infos Method 'contextInitialized' is not designed for extension - needs to be abstract, final or empty. 21
Infos Method 'contextDestroyed' is not designed for extension - needs to be abstract, final or empty. 27

com/atlassian/gadgets/renderer/internal/servlet/GadgetSpecUrlRenderPermissionServletFilter.java

Violation Message Line
Errors Wrong order for 'javax.servlet.FilterChain' import. 8
Errors Wrong order for 'java.io.IOException' import. 11
Errors Wrong order for 'org.apache.commons.logging.Log' import. 18
Errors Wrong order for 'org.apache.commons.lang.StringUtils' import. 19
Errors Wrong order for 'com.google.common.base.Preconditions.checkNotNull' import. 20
Errors Wrong order for 'com.atlassian.gadgets.GadgetSpecUrlChecker' import. 21
Errors Wrong order for 'com.atlassian.gadgets.GadgetSpecUriNotAllowedException' import. 22
Errors Class Fan-Out Complexity is 18 (max allowed is 10). 32
Warnings Line has trailing spaces. 41
Warnings Line has trailing spaces. 46
Infos Method 'doFilter' is not designed for extension - needs to be abstract, final or empty. 62
Errors method def throws at indentation level 12 not at correct indentation, 8 63
Errors 'if' is not followed by whitespace. 99
Errors '{' should be on a new line. 99
Warnings Line has trailing spaces. 112
Errors '{' is not preceded with whitespace. 114
Errors '{' is not followed by whitespace. 114
Errors '}' is not preceded with whitespace. 114
Errors '{' is not followed by whitespace. 115
Errors '}' is not preceded with whitespace. 115
Errors Missing a Javadoc comment. 117
Errors '{' should be on a new line. 117
Warnings Line has trailing spaces. 120
Warnings Line is longer than 120 characters. 122
Infos Method 'html' is not designed for extension - needs to be abstract, final or empty. 128

com/atlassian/gadgets/renderer/internal/servlet/RpcRelay.java

Violation Message Line
Errors assign child at indentation level 6 not at correct indentation, 8 20
Errors assign child at indentation level 6 not at correct indentation, 8 21
Errors assign child at indentation level 6 not at correct indentation, 8 22
Errors assign child at indentation level 6 not at correct indentation, 8 23
Errors assign child at indentation level 6 not at correct indentation, 8 24
Errors assign child at indentation level 6 not at correct indentation, 8 25
Errors assign child at indentation level 6 not at correct indentation, 8 26
Errors assign child at indentation level 6 not at correct indentation, 8 27
Infos Method 'doGet' is not designed for extension - needs to be abstract, final or empty. 29

com/atlassian/gadgets/renderer/internal/servlet/TrustedAppMakeRequestHandler.java

Violation Message Line
Errors Wrong order for 'com.atlassian.gadgets.renderer.internal.http.TrustedAppContentFetcherFactory' import. 6
Errors 'com.google.inject.Inject' should be separated from previous imports. 7
Errors Missing a Javadoc comment. 10
Warnings Line has trailing spaces. 18