Checkstyle Results

The following document contains the results of Checkstylerss feed

Summary

Files Infos Infos Warnings Warnings Errors Errors
24 34 83 366

Files

Files Infos Warnings Errors
com/atlassian/gadgets/renderer/internal/AtlassianContainerConfig.java 5 14 13
com/atlassian/gadgets/renderer/internal/AtlassianOAuthCallbackGenerator.java 1 1 3
com/atlassian/gadgets/renderer/internal/BlobCrypterImpl.java 2 2 2
com/atlassian/gadgets/renderer/internal/ContainerDomainProvider.java 1 1 0
com/atlassian/gadgets/renderer/internal/CustomBlobCrypterSecurityTokenDecoder.java 1 5 10
com/atlassian/gadgets/renderer/internal/FeatureImpl.java 2 0 1
com/atlassian/gadgets/renderer/internal/GadgetRequestContextFactoryImpl.java 0 3 8
com/atlassian/gadgets/renderer/internal/GadgetSpecFactoryImpl.java 2 2 6
com/atlassian/gadgets/renderer/internal/GadgetSpecUrlCheckerImpl.java 1 1 9
com/atlassian/gadgets/renderer/internal/SecurityTokenFactoryImpl.java 1 3 2
com/atlassian/gadgets/renderer/internal/guice/AuthModule.java 1 4 4
com/atlassian/gadgets/renderer/internal/guice/InjectorProvider.java 1 1 1
com/atlassian/gadgets/renderer/internal/guice/SalModule.java 1 0 3
com/atlassian/gadgets/renderer/internal/guice/ShindigModule.java 1 5 15
com/atlassian/gadgets/renderer/internal/http/HttpClientFetcher.java 1 15 226
com/atlassian/gadgets/renderer/internal/http/TrustedAppContentFetcherFactory.java 1 2 5
com/atlassian/gadgets/renderer/internal/oauth/AtlassianOAuthFetcher.java 1 6 8
com/atlassian/gadgets/renderer/internal/oauth/AtlassianOAuthFetcherFactory.java 1 1 3
com/atlassian/gadgets/renderer/internal/oauth/AtlassianOAuthStore.java 4 11 13
com/atlassian/gadgets/renderer/internal/rewrite/AtlassianGadgetsContentRewriter.java 2 1 3
com/atlassian/gadgets/renderer/internal/servlet/AtlassianGadgetsGuiceServletContextListener.java 2 1 2
com/atlassian/gadgets/renderer/internal/servlet/GadgetSpecUrlRenderPermissionServletFilter.java 1 3 17
com/atlassian/gadgets/renderer/internal/servlet/RpcRelay.java 1 0 8
com/atlassian/gadgets/renderer/internal/servlet/TrustedAppMakeRequestHandler.java 0 1 4

Rules

Rules Violations Severity
JavadocPackage 6 Errors Error
Translation 0 Errors Error
FileLength 0 Errors Error
FileTabCharacter
  • eachLine: "true"
0 Errors Error
RegexpSingleline
  • message: "Line has trailing spaces."
  • format: "\s+$"
65 Warnings Warning
AnnotationUseStyle 0 Errors Error
MissingDeprecated 0 Errors Error
MissingOverride
  • javaFiveCompatibility: "true"
0 Errors Error
PackageAnnotation 0 Errors Error
JavadocMethod
  • excludeScope: "private"
  • scope: "anoninner"
1 Errors Error
JavadocType
  • scope: "package"
12 Errors Error
JavadocVariable
  • scope: "package"
8 Errors Error
JavadocStyle
  • scope: "package"
2 Errors Error
ConstantName 0 Errors Error
LocalFinalVariableName 0 Errors Error
LocalVariableName 0 Errors Error
MemberName 0 Errors Error
MethodName 0 Errors Error
PackageName 0 Errors Error
ParameterName 0 Errors Error
StaticVariableName 0 Errors Error
TypeName 0 Errors Error
AvoidStarImport 0 Errors Error
IllegalImport 0 Errors Error
ImportOrder
  • separated: "true"
  • groups: "java,javax,com.atlassian,com,org"
49 Errors Error
RedundantImport 0 Errors Error
UnusedImports 2 Errors Error
LineLength
  • max: "120"
18 Warnings Warning
MethodLength 0 Errors Error
ParameterNumber 0 Errors Error
EmptyForIteratorPad 0 Errors Error
MethodParamPad 1 Errors Error
NoWhitespaceAfter 1 Errors Error
NoWhitespaceBefore 0 Errors Error
OperatorWrap 6 Errors Error
ParenPad 0 Errors Error
TypecastParenPad 0 Errors Error
WhitespaceAfter 2 Errors Error
WhitespaceAround 14 Errors Error
ModifierOrder 5 Errors Error
RedundantModifier 0 Errors Error
AvoidNestedBlocks 0 Errors Error
EmptyBlock 0 Errors Error
LeftCurly
  • option: "nl"
41 Errors Error
NeedBraces 0 Errors Error
RightCurly
  • option: "alone"
3 Errors Error
DeclarationOrder 6 Errors Error
DefaultComesLast 0 Errors Error
DoubleCheckedLocking 0 Errors Error
EmptyStatement 0 Errors Error
EqualsHashCode 0 Errors Error
ExplicitInitialization 0 Errors Error
FallThrough 0 Errors Error
HiddenField
  • ignoreConstructorParameter: "true"
  • ignoreSetter: "true"
1 Errors Error
IllegalInstantiation 0 Errors Error
InnerAssignment 0 Errors Error
MagicNumber 1 Errors Error
MissingSwitchDefault 2 Errors Error
ParameterAssignment 0 Errors Error
RedundantThrows
  • allowUnchecked: "true"
3 Errors Error
SimplifyBooleanExpression 0 Errors Error
SimplifyBooleanReturn 0 Errors Error
StringLiteralEquality 0 Errors Error
DesignForExtension 34 Infos Info
FinalClass 0 Errors Error
HideUtilityClassConstructor 2 Errors Error
InterfaceIsType 0 Errors Error
VisibilityModifier 0 Errors Error
BooleanExpressionComplexity 1 Errors Error
ClassDataAbstractionCoupling 1 Errors Error
ClassFanOutComplexity
  • max: "10"
5 Errors Error
CyclomaticComplexity 0 Errors Error
NPathComplexity
  • max: "20"
1 Errors Error
JavaNCSS 0 Errors Error
ArrayTypeStyle 0 Errors Error
Indentation 191 Errors Error
TodoComment 0 Errors Error
UpperEll 0 Errors Error

Details

com/atlassian/gadgets/renderer/internal/AtlassianContainerConfig.java

Violation Message Line
Errors 'org.apache.shindig.common.ContainerConfig' should be separated from previous imports. 14
Warnings Line has trailing spaces. 22
Errors Missing a Javadoc comment. 27
Errors Utility classes should not have a public or default constructor. 27
Errors Missing a Javadoc comment. 29
Errors Missing a Javadoc comment. 30
Warnings Line has trailing spaces. 32
Errors Missing a Javadoc comment. 33
Errors Missing a Javadoc comment. 34
Warnings Line has trailing spaces. 35
Warnings Line has trailing spaces. 40
Warnings Line is longer than 120 characters. 53
Errors method call child at indentation level 11 not at correct indentation, 12 93
Errors method call child at indentation level 11 not at correct indentation, 12 99
Errors method call child at indentation level 11 not at correct indentation, 12 103
Errors method call child at indentation level 11 not at correct indentation, 12 115
Errors method call child at indentation level 11 not at correct indentation, 12 123
Warnings Line has trailing spaces. 138
Warnings Line has trailing spaces. 140
Warnings Line has trailing spaces. 141
Errors '(' is preceded with whitespace. 149
Warnings Line has trailing spaces. 157
Warnings Line has trailing spaces. 159
Warnings Line has trailing spaces. 160
Warnings Line has trailing spaces. 176
Warnings Line has trailing spaces. 178
Warnings Line has trailing spaces. 179
Infos Method 'getContainers' is not designed for extension - needs to be abstract, final or empty. 197
Infos Method 'getJson' is not designed for extension - needs to be abstract, final or empty. 214
Infos Method 'get' is not designed for extension - needs to be abstract, final or empty. 248
Infos Method 'getJsonObject' is not designed for extension - needs to be abstract, final or empty. 254
Infos Method 'getJsonArray' is not designed for extension - needs to be abstract, final or empty. 260

com/atlassian/gadgets/renderer/internal/AtlassianOAuthCallbackGenerator.java

Violation Message Line
Errors Unused import - org.apache.shindig.gadgets.oauth.GadgetOAuthCallbackGenerator. 4
Errors Wrong order for 'com.google.inject.Singleton' import. 10
Infos Method 'generateCallback' is not designed for extension - needs to be abstract, final or empty. 19
Warnings Line has trailing spaces. 22
Errors method def throws at indentation level 12 not at correct indentation, 8 23

com/atlassian/gadgets/renderer/internal/BlobCrypterImpl.java

Violation Message Line
Errors Missing a Javadoc comment. 16
Warnings Line has trailing spaces. 31
Errors Missing a Javadoc comment. 40
Warnings Line has trailing spaces. 55
Infos Method 'unwrap' is not designed for extension - needs to be abstract, final or empty. 56
Infos Method 'wrap' is not designed for extension - needs to be abstract, final or empty. 61

com/atlassian/gadgets/renderer/internal/ContainerDomainProvider.java

Violation Message Line
Warnings Line has trailing spaces. 21
Infos Method 'getDomain' is not designed for extension - needs to be abstract, final or empty. 24

com/atlassian/gadgets/renderer/internal/CustomBlobCrypterSecurityTokenDecoder.java

Violation Message Line
Errors Missing package-info.java file. 0
Errors Wrong order for 'java.util.Map' import. 5
Errors Wrong order for 'com.atlassian.gadgets.renderer.internal.AtlassianContainerConfig.Containers' import. 14
Errors Missing a Javadoc comment. 16
Warnings Line has trailing spaces. 24
Infos Method 'createToken' is not designed for extension - needs to be abstract, final or empty. 30
Warnings Line has trailing spaces. 60
Errors Static variable definition in wrong order. 61
Errors Static variable definition in wrong order. 63
Errors Static variable definition in wrong order. 64
Errors Static variable definition in wrong order. 65
Errors Static variable definition in wrong order. 66
Errors Static variable definition in wrong order. 67
Warnings Line has trailing spaces. 72
Warnings Line has trailing spaces. 74
Warnings Line has trailing spaces. 80

com/atlassian/gadgets/renderer/internal/FeatureImpl.java

Violation Message Line
Errors Missing a Javadoc comment. 5
Infos Method 'getParameterValue' is not designed for extension - needs to be abstract, final or empty. 14
Infos Method 'getName' is not designed for extension - needs to be abstract, final or empty. 19

com/atlassian/gadgets/renderer/internal/GadgetRequestContextFactoryImpl.java

Violation Message Line
Errors Wrong order for 'com.atlassian.gadgets.GadgetRequestContextFactory' import. 5
Errors Wrong order for 'com.atlassian.gadgets.GadgetRequestContext' import. 6
Errors Wrong order for 'javax.servlet.http.HttpServletRequest' import. 9
Errors Wrong order for 'java.util.Locale' import. 10
Errors Missing a Javadoc comment. 19
Errors 'static' modifier out of order with the JLS suggestions. 19
Errors Missing a Javadoc comment. 20
Errors 'static' modifier out of order with the JLS suggestions. 20
Warnings Line has trailing spaces. 28
Warnings Line has trailing spaces. 58
Warnings Line is longer than 120 characters. 59

com/atlassian/gadgets/renderer/internal/GadgetSpecFactoryImpl.java

Violation Message Line
Errors Wrong order for 'java.util.Collections.unmodifiableCollection' import. 6
Errors Wrong order for 'java.net.URI' import. 9
Errors Wrong order for 'com.atlassian.gadgets.GadgetParsingException' import. 26
Errors 'com.google.common.base.Function' should be separated from previous imports. 36
Errors Class Fan-Out Complexity is 23 (max allowed is 10). 43
Warnings Line is longer than 120 characters. 68
Infos Method 'getGadgetSpec' is not designed for extension - needs to be abstract, final or empty. 68
Infos Method 'getGadgetSpec' is not designed for extension - needs to be abstract, final or empty. 73
Errors ',' is not followed by whitespace. 75
Warnings Line has trailing spaces. 119

com/atlassian/gadgets/renderer/internal/GadgetSpecUrlCheckerImpl.java

Violation Message Line
Errors Wrong order for 'com.atlassian.gadgets.GadgetSpecUrlChecker' import. 6
Errors 'com.google.common.collect.Iterables' should be separated from previous imports. 7
Errors Wrong order for 'org.apache.commons.logging.Log' import. 11
Infos Method 'assertRenderable' is not designed for extension - needs to be abstract, final or empty. 48
Errors NPath Complexity is 36 (max allowed is 20). 48
Errors '+' should be on a new line. 53
Warnings Line has trailing spaces. 62
Errors '+' should be on a new line. 78
Errors switch without "default" clause. 81
Errors '+' should be on a new line. 84
Errors '+' should be on a new line. 98

com/atlassian/gadgets/renderer/internal/SecurityTokenFactoryImpl.java

Violation Message Line
Errors Wrong order for 'com.atlassian.gadgets.view.SecurityTokenFactory' import. 6
Errors Missing a Javadoc comment. 13
Warnings Line has trailing spaces. 27
Infos Method 'newSecurityToken' is not designed for extension - needs to be abstract, final or empty. 28
Warnings Line is longer than 120 characters. 30
Warnings Line has trailing spaces. 39

com/atlassian/gadgets/renderer/internal/guice/AuthModule.java

Violation Message Line
Errors Wrong order for 'org.apache.shindig.gadgets.oauth.OAuthModule.OAuthCrypterProvider' import. 9
Errors Wrong order for 'com.atlassian.gadgets.renderer.internal.AtlassianOAuthCallbackGenerator' import. 12
Errors 'com.google.inject.AbstractModule' should be separated from previous imports. 17
Errors Unused import - com.google.inject.Module. 18
Warnings Line has trailing spaces. 35
Infos Method 'configure' is not designed for extension - needs to be abstract, final or empty. 36
Warnings Line has trailing spaces. 50
Warnings Line has trailing spaces. 53
Warnings Line has trailing spaces. 56

com/atlassian/gadgets/renderer/internal/guice/InjectorProvider.java

Violation Message Line
Errors First sentence should end with a period. 8
Warnings Line has trailing spaces. 14
Infos Method 'get' is not designed for extension - needs to be abstract, final or empty. 24

com/atlassian/gadgets/renderer/internal/guice/SalModule.java

Violation Message Line
Errors Missing package-info.java file. 0
Errors 'com.google.inject.AbstractModule' should be separated from previous imports. 7
Errors Missing a Javadoc comment. 9
Infos Method 'configure' is not designed for extension - needs to be abstract, final or empty. 27

com/atlassian/gadgets/renderer/internal/guice/ShindigModule.java

Violation Message Line
Errors Wrong order for 'java.io.IOException' import. 5
Errors Wrong order for 'com.atlassian.gadgets.renderer.internal.AtlassianContainerConfig' import. 27
Errors 'com.google.common.collect.ImmutableList' should be separated from previous imports. 31
Errors 'static' modifier out of order with the JLS suggestions. 46
Errors 'static' modifier out of order with the JLS suggestions. 47
Errors 'properties' hides a field. 60
Infos Method 'configure' is not designed for extension - needs to be abstract, final or empty. 79
Warnings Line has trailing spaces. 83
Warnings Line has trailing spaces. 90
Warnings Line has trailing spaces. 91
Warnings Line is longer than 120 characters. 91
Errors '{' is not preceded with whitespace. 98
Errors '{' is not followed by whitespace. 98
Errors '}' is not preceded with whitespace. 98
Errors '{' is not preceded with whitespace. 99
Errors '{' is not followed by whitespace. 99
Errors '}' is not preceded with whitespace. 99
Errors Missing a Javadoc comment. 106
Warnings Line has trailing spaces. 111
Errors Missing a Javadoc comment. 123
Errors '{' should be on a new line. 133

com/atlassian/gadgets/renderer/internal/http/HttpClientFetcher.java

Violation Message Line
Errors Missing package-info.java file. 0
Errors Wrong order for 'com.google.common.collect.ImmutableSet' import. 56
Errors Class Data Abstraction Coupling is 9 (max allowed is 7) classes [BasicHeader, BasicHttpParams, CustomSSLSocketFactory, DefaultHttpClient, GzipDeflatingInterceptor, HttpCacheKey, HttpResponseBuilder, InputStreamEntity, Scheme]. 63
Errors Class Fan-Out Complexity is 24 (max allowed is 10). 63
Errors '{' should be on a new line. 64
Errors member def modifier at indentation level 2 not at correct indentation, 4 65
Errors member def modifier at indentation level 2 not at correct indentation, 4 67
Errors ctor def modifier at indentation level 2 not at correct indentation, 4 69
Errors ctor def modifier at indentation level 2 not at correct indentation, 4 70
Errors '{' should be on a new line. 70
Errors ctor def child at indentation level 6 not at correct indentation, 8 71
Errors ctor def rcurly at indentation level 2 not at correct indentation, 4 72
Errors method def modifier at indentation level 2 not at correct indentation, 4 75
Infos Method 'fetch' is not designed for extension - needs to be abstract, final or empty. 75
Errors '{' should be on a new line. 75
Errors method def child at indentation level 4 not at correct indentation, 8 76
Errors method def child at indentation level 4 not at correct indentation, 8 77
Errors if at indentation level 4 not at correct indentation, 8 78
Errors '{' should be on a new line. 78
Errors if child at indentation level 6 not at correct indentation, 12 79
Errors if rcurly at indentation level 4 not at correct indentation, 8 80
Errors try at indentation level 4 not at correct indentation, 8 81
Errors '{' should be on a new line. 81
Errors try child at indentation level 6 not at correct indentation, 12 82
Errors if at indentation level 6 not at correct indentation, 12 83
Errors '{' should be on a new line. 83
Warnings Line is longer than 120 characters. 84
Errors if child at indentation level 8 not at correct indentation, 16 84
Errors method call child at indentation level 8 not at correct indentation, 16 84
Errors if rcurly at indentation level 6 not at correct indentation, 12 85
Errors try child at indentation level 6 not at correct indentation, 12 86
Errors try at indentation level 6 not at correct indentation, 12 87
Errors '{' should be on a new line. 87
Errors try child at indentation level 8 not at correct indentation, 16 89
Errors try rcurly at indentation level 6 not at correct indentation, 12 90
Errors '}' should be alone on a line. 90
Errors '{' should be on a new line. 90
Errors catch child at indentation level 10 not at correct indentation, 16 92
Errors catch rcurly at indentation level 6 not at correct indentation, 12 93
Errors try child at indentation level 6 not at correct indentation, 12 94
Errors try child at indentation level 6 not at correct indentation, 12 95
Errors try rcurly at indentation level 4 not at correct indentation, 8 96
Errors '}' should be alone on a line. 96
Errors '{' should be on a new line. 96
Errors if at indentation level 6 not at correct indentation, 12 97
Errors '||' should be on a new line. 97
Errors if child at indentation level 10 not at correct indentation, 16 98
Errors '{' should be on a new line. 98
Errors if child at indentation level 8 not at correct indentation, 16 99
Errors if rcurly at indentation level 6 not at correct indentation, 12 100
Errors catch child at indentation level 6 not at correct indentation, 12 101
Errors catch rcurly at indentation level 4 not at correct indentation, 8 102
Errors method def rcurly at indentation level 2 not at correct indentation, 4 103
Errors method def modifier at indentation level 2 not at correct indentation, 4 105
Errors method def lcurly at indentation level 2 not at correct indentation, 4 106
Errors method def child at indentation level 4 not at correct indentation, 8 107
Errors method call child at indentation level 4 not at correct indentation, 8 108
Errors method def child at indentation level 4 not at correct indentation, 8 108
Errors method call child at indentation level 4 not at correct indentation, 8 109
Errors method def child at indentation level 4 not at correct indentation, 8 109
Warnings Line is longer than 120 characters. 110
Errors method call child at indentation level 4 not at correct indentation, 8 110
Errors method def child at indentation level 4 not at correct indentation, 8 110
Errors method def child at indentation level 4 not at correct indentation, 8 111
Errors method call child at indentation level 4 not at correct indentation, 8 112
Errors method def child at indentation level 4 not at correct indentation, 8 112
Warnings Line is longer than 120 characters. 113
Errors method call child at indentation level 4 not at correct indentation, 8 113
Errors method def child at indentation level 4 not at correct indentation, 8 113
Errors '443' is a magic number. 113
Errors method def child at indentation level 4 not at correct indentation, 8 114
Errors method def rcurly at indentation level 2 not at correct indentation, 4 115
Errors method def modifier at indentation level 2 not at correct indentation, 4 117
Errors '{' should be on a new line. 117
Errors method def child at indentation level 4 not at correct indentation, 8 118
Errors method def child at indentation level 4 not at correct indentation, 8 119
Errors for at indentation level 4 not at correct indentation, 8 121
Errors '{' should be on a new line. 121
Errors for child at indentation level 6 not at correct indentation, 12 122
Errors method call child at indentation level 6 not at correct indentation, 12 122
Errors for rcurly at indentation level 4 not at correct indentation, 8 123
Errors method def child at indentation level 4 not at correct indentation, 8 124
Errors method def rcurly at indentation level 2 not at correct indentation, 4 125
Warnings Line has trailing spaces. 127
Errors method def modifier at indentation level 2 not at correct indentation, 4 127
Errors '{' should be on a new line. 127
Errors method def child at indentation level 4 not at correct indentation, 8 128
Errors for at indentation level 4 not at correct indentation, 8 129
Errors '{' should be on a new line. 129
Errors for child at indentation level 8 not at correct indentation, 12 130
Errors method call child at indentation level 8 not at correct indentation, 12 130
Errors for rcurly at indentation level 4 not at correct indentation, 8 131
Errors method def child at indentation level 4 not at correct indentation, 8 133
Errors method def rcurly at indentation level 2 not at correct indentation, 4 137
Warnings Line has trailing spaces. 139
Errors class def child at indentation level 2 not at correct indentation, 4 143
Errors class def ident at indentation level 2 not at correct indentation, 4 143
Errors class def modifier at indentation level 2 not at correct indentation, 4 143
Errors '{' should be on a new line. 143
Errors member def modifier at indentation level 4 not at correct indentation, 8 144
Errors member def modifier at indentation level 4 not at correct indentation, 8 145
Errors ctor def modifier at indentation level 4 not at correct indentation, 8 147
Errors '{' should be on a new line. 147
Errors ctor def child at indentation level 6 not at correct indentation, 12 148
Errors ctor def rcurly at indentation level 4 not at correct indentation, 8 149
Warnings Line has trailing spaces. 150
Errors method def modifier at indentation level 4 not at correct indentation, 8 151
Errors '{' should be on a new line. 151
Errors method def child at indentation level 6 not at correct indentation, 12 152
Errors method call child at indentation level 6 not at correct indentation, 12 153
Errors method def child at indentation level 6 not at correct indentation, 12 153
Errors '{' is followed by whitespace. 153
Errors method def child at indentation level 6 not at correct indentation, 12 154
Errors method def rcurly at indentation level 4 not at correct indentation, 8 155
Warnings Line is longer than 120 characters. 157
Errors method def modifier at indentation level 4 not at correct indentation, 8 157
Errors method def throws at indentation level 8 not at correct indentation, 12 158
Errors Redundant throws: 'UnknownHostException' is subclass of 'IOException'. 158
Errors Redundant throws: 'ConnectTimeoutException' is subclass of 'IOException'. 158
Errors '{' should be on a new line. 158
Errors method def child at indentation level 6 not at correct indentation, 12 159
Errors method def rcurly at indentation level 4 not at correct indentation, 8 160
Errors method def modifier at indentation level 4 not at correct indentation, 8 162
Errors '{' should be on a new line. 162
Errors method def child at indentation level 6 not at correct indentation, 12 163
Errors method def rcurly at indentation level 4 not at correct indentation, 8 164
Warnings Line is longer than 120 characters. 166
Errors method def modifier at indentation level 4 not at correct indentation, 8 166
Errors Redundant throws: 'UnknownHostException' is subclass of 'IOException'. 166
Errors '{' should be on a new line. 166
Errors method def child at indentation level 6 not at correct indentation, 12 167
Errors method def rcurly at indentation level 4 not at correct indentation, 8 168
Errors class def rcurly at indentation level 2 not at correct indentation, 4 169
Warnings Line has trailing spaces. 170
Errors class def child at indentation level 2 not at correct indentation, 4 171
Errors class def ident at indentation level 2 not at correct indentation, 4 171
Errors class def modifier at indentation level 2 not at correct indentation, 4 171
Errors '{' should be on a new line. 171
Warnings Line is longer than 120 characters. 172
Errors method def modifier at indentation level 4 not at correct indentation, 8 172
Errors '{' should be on a new line. 172
Errors method def child at indentation level 6 not at correct indentation, 12 173
Errors method def child at indentation level 6 not at correct indentation, 12 174
Errors if at indentation level 6 not at correct indentation, 12 175
Errors '{' should be on a new line. 175
Errors if child at indentation level 8 not at correct indentation, 16 176
Errors for at indentation level 8 not at correct indentation, 16 177
Errors '{' should be on a new line. 177
Errors if at indentation level 10 not at correct indentation, 20 178
Errors '{' should be on a new line. 178
Errors if child at indentation level 12 not at correct indentation, 24 179
Errors method call child at indentation level 12 not at correct indentation, 24 179
Errors if child at indentation level 12 not at correct indentation, 24 180
Errors if rcurly at indentation level 10 not at correct indentation, 20 181
Errors '}' should be alone on a line. 181
Errors '{' should be on a new line. 181
Errors if child at indentation level 12 not at correct indentation, 24 182
Errors method call child at indentation level 12 not at correct indentation, 24 182
Errors if child at indentation level 12 not at correct indentation, 24 183
Errors if rcurly at indentation level 10 not at correct indentation, 20 184
Errors for rcurly at indentation level 8 not at correct indentation, 16 185
Errors if rcurly at indentation level 6 not at correct indentation, 12 186
Errors method def rcurly at indentation level 4 not at correct indentation, 8 187
Errors class def rcurly at indentation level 2 not at correct indentation, 4 188
Warnings Line has trailing spaces. 189
Errors class def child at indentation level 2 not at correct indentation, 4 190
Errors class def ident at indentation level 2 not at correct indentation, 4 190
Errors class def modifier at indentation level 2 not at correct indentation, 4 190
Errors 'abstract' modifier out of order with the JLS suggestions. 190
Errors '{' should be on a new line. 190
Errors ctor def modifier at indentation level 4 not at correct indentation, 8 191
Errors '{' should be on a new line. 191
Errors ctor def rcurly at indentation level 4 not at correct indentation, 8 193
Warnings Line has trailing spaces. 194
Errors method def modifier at indentation level 4 not at correct indentation, 8 195
Errors method def modifier at indentation level 4 not at correct indentation, 8 196
Errors '{' should be on a new line. 196
Errors method def child at indentation level 6 not at correct indentation, 12 198
Errors method def rcurly at indentation level 4 not at correct indentation, 8 199
Errors method def modifier at indentation level 4 not at correct indentation, 8 201
Errors method def modifier at indentation level 4 not at correct indentation, 8 202
Errors '{' should be on a new line. 202
Errors method def child at indentation level 6 not at correct indentation, 12 204
Errors method def rcurly at indentation level 4 not at correct indentation, 8 205
Warnings Line has trailing spaces. 206
Errors method def modifier at indentation level 4 not at correct indentation, 8 207
Errors class def rcurly at indentation level 2 not at correct indentation, 4 208
Warnings Line has trailing spaces. 209
Errors class def child at indentation level 2 not at correct indentation, 4 210
Errors class def ident at indentation level 2 not at correct indentation, 4 210
Errors class def modifier at indentation level 2 not at correct indentation, 4 210
Errors '{' should be on a new line. 210
Errors ctor def modifier at indentation level 4 not at correct indentation, 8 211
Errors '{' should be on a new line. 211
Errors ctor def rcurly at indentation level 4 not at correct indentation, 8 213
Errors method def modifier at indentation level 4 not at correct indentation, 8 215
Errors method def modifier at indentation level 4 not at correct indentation, 8 216
Errors '{' should be on a new line. 216
Errors method def child at indentation level 6 not at correct indentation, 12 217
Errors method def rcurly at indentation level 4 not at correct indentation, 8 218
Errors class def rcurly at indentation level 2 not at correct indentation, 4 219
Errors class def child at indentation level 2 not at correct indentation, 4 221
Errors class def ident at indentation level 2 not at correct indentation, 4 221
Errors class def modifier at indentation level 2 not at correct indentation, 4 221
Errors '{' should be on a new line. 221
Errors ctor def modifier at indentation level 4 not at correct indentation, 8 222
Errors '{' should be on a new line. 222
Errors ctor def rcurly at indentation level 4 not at correct indentation, 8 224
Errors method def modifier at indentation level 4 not at correct indentation, 8 226
Errors method def modifier at indentation level 4 not at correct indentation, 8 227
Errors '{' should be on a new line. 227
Errors method def child at indentation level 6 not at correct indentation, 12 228
Errors method def rcurly at indentation level 4 not at correct indentation, 8 229
Errors class def rcurly at indentation level 2 not at correct indentation, 4 230
Errors enum def child at indentation level 2 not at correct indentation, 4 232
Errors enum def ident at indentation level 2 not at correct indentation, 4 232
Errors enum def modifier at indentation level 2 not at correct indentation, 4 232
Errors '{' should be on a new line. 232
Warnings Line has trailing spaces. 234
Errors method def modifier at indentation level 4 not at correct indentation, 8 235
Errors '{' should be on a new line. 235
Errors switch at indentation level 6 not at correct indentation, 12 236
Errors switch without "default" clause. 236
Errors '{' should be on a new line. 236
Errors block child at indentation level 8 not at correct indentation, 20 237
Errors case child at indentation level 8 not at correct indentation, 16 237
Errors block child at indentation level 8 not at correct indentation, 20 238
Errors case child at indentation level 8 not at correct indentation, 16 238
Errors block child at indentation level 8 not at correct indentation, 20 239
Errors case child at indentation level 8 not at correct indentation, 16 239
Errors block child at indentation level 8 not at correct indentation, 20 240
Errors case child at indentation level 8 not at correct indentation, 16 240
Errors block child at indentation level 8 not at correct indentation, 20 241
Errors case child at indentation level 8 not at correct indentation, 16 241
Errors block child at indentation level 8 not at correct indentation, 20 242
Errors case child at indentation level 8 not at correct indentation, 16 242
Errors block child at indentation level 8 not at correct indentation, 20 243
Errors case child at indentation level 8 not at correct indentation, 16 243
Errors switch rcurly at indentation level 6 not at correct indentation, 12 244
Errors method def child at indentation level 6 not at correct indentation, 12 245
Errors method def rcurly at indentation level 4 not at correct indentation, 8 246
Errors enum def rcurly at indentation level 2 not at correct indentation, 4 247

com/atlassian/gadgets/renderer/internal/http/TrustedAppContentFetcherFactory.java

Violation Message Line
Errors Wrong order for 'org.apache.shindig.gadgets.GadgetException' import. 5
Errors Wrong order for 'com.atlassian.sal.api.user.UserManager' import. 12
Errors 'com.google.inject.Inject' should be separated from previous imports. 16
Warnings Line has trailing spaces. 38
Infos Method 'fetch' is not designed for extension - needs to be abstract, final or empty. 39
Warnings Line has trailing spaces. 49
Errors '!=' is not preceded with whitespace. 50
Errors '!=' is not followed by whitespace. 50

com/atlassian/gadgets/renderer/internal/oauth/AtlassianOAuthFetcher.java

Violation Message Line
Errors Missing package-info.java file. 0
Errors Wrong order for 'net.oauth.OAuth.Parameter' import. 9
Errors Wrong order for 'org.apache.shindig.gadgets.http.HttpFetcher' import. 11
Errors Wrong order for 'com.atlassian.oauth.Request' import. 16
Errors Wrong order for 'com.atlassian.oauth.Request.HttpMethod' import. 18
Errors Missing a Javadoc comment. 25
Errors Class Fan-Out Complexity is 11 (max allowed is 10). 25
Warnings Line has trailing spaces. 29
Warnings Line has trailing spaces. 30
Warnings Line has trailing spaces. 31
Infos Method 'sign' is not designed for extension - needs to be abstract, final or empty. 38
Errors method def throws at indentation level 12 not at correct indentation, 8 40
Warnings Line has trailing spaces. 47
Warnings Line is longer than 120 characters. 56
Warnings Line has trailing spaces. 58

com/atlassian/gadgets/renderer/internal/oauth/AtlassianOAuthFetcherFactory.java

Violation Message Line
Errors Wrong order for 'com.atlassian.oauth.consumer.ConsumerService' import. 10
Errors 'com.google.inject.Inject' should be separated from previous imports. 11
Errors First sentence should end with a period. 30
Warnings Line has trailing spaces. 32
Infos Method 'getOAuthFetcher' is not designed for extension - needs to be abstract, final or empty. 35

com/atlassian/gadgets/renderer/internal/oauth/AtlassianOAuthStore.java

Violation Message Line
Errors 'org.apache.commons.lang.StringUtils.isBlank' should be separated from previous imports. 4
Errors Wrong order for 'java.util.Map' import. 8
Errors Wrong order for 'org.apache.shindig.auth.SecurityToken' import. 12
Errors Wrong order for 'com.atlassian.gadgets.util.Uri' import. 16
Errors 'com.google.common.collect.ImmutableMap' should be separated from previous imports. 25
Warnings Line is longer than 120 characters. 29
Errors Class Fan-Out Complexity is 14 (max allowed is 10). 33
Warnings Line has trailing spaces. 36
Warnings Line has trailing spaces. 50
Warnings Line is longer than 120 characters. 51
Infos Method 'getConsumerKeyAndSecret' is not designed for extension - needs to be abstract, final or empty. 51
Warnings Line is longer than 120 characters. 60
Infos Method 'getTokenInfo' is not designed for extension - needs to be abstract, final or empty. 60
Warnings Line is longer than 120 characters. 74
Infos Method 'setTokenInfo' is not designed for extension - needs to be abstract, final or empty. 74
Errors Boolean expression complexity is 4 (max allowed is 3). 83
Errors if child at indentation level 9 not at correct indentation, 12 84
Errors if child at indentation level 9 not at correct indentation, 12 85
Errors if child at indentation level 9 not at correct indentation, 12 86
Warnings Line has trailing spaces. 91
Warnings Line has trailing spaces. 96
Warnings Line is longer than 120 characters. 97
Infos Method 'removeToken' is not designed for extension - needs to be abstract, final or empty. 97
Warnings Line has trailing spaces. 120
Errors Utility classes should not have a public or default constructor. 140
Errors Missing a Javadoc comment. 142
Errors Missing a Javadoc comment. 143
Warnings Line is longer than 120 characters. 156

com/atlassian/gadgets/renderer/internal/rewrite/AtlassianGadgetsContentRewriter.java

Violation Message Line
Errors Missing package-info.java file. 0
Errors Wrong order for 'com.google.inject.Inject' import. 6
Errors Missing a Javadoc comment. 10
Infos Method 'getProxyUrl' is not designed for extension - needs to be abstract, final or empty. 32
Warnings Line has trailing spaces. 37
Infos Method 'getConcatUrl' is not designed for extension - needs to be abstract, final or empty. 42

com/atlassian/gadgets/renderer/internal/servlet/AtlassianGadgetsGuiceServletContextListener.java

Violation Message Line
Errors Wrong order for 'com.google.inject.Injector' import. 9
Errors Missing a Javadoc comment. 12
Warnings Line has trailing spaces. 20
Infos Method 'contextInitialized' is not designed for extension - needs to be abstract, final or empty. 21
Infos Method 'contextDestroyed' is not designed for extension - needs to be abstract, final or empty. 27

com/atlassian/gadgets/renderer/internal/servlet/GadgetSpecUrlRenderPermissionServletFilter.java

Violation Message Line
Errors Wrong order for 'javax.servlet.FilterChain' import. 8
Errors Wrong order for 'java.io.IOException' import. 11
Errors Wrong order for 'org.apache.commons.logging.Log' import. 16
Errors Wrong order for 'org.apache.commons.lang.StringUtils' import. 17
Errors Wrong order for 'com.google.common.base.Preconditions.checkNotNull' import. 18
Errors Wrong order for 'com.atlassian.gadgets.GadgetSpecUrlChecker' import. 19
Errors Wrong order for 'com.atlassian.gadgets.GadgetSpecUriNotAllowedException' import. 20
Errors Class Fan-Out Complexity is 15 (max allowed is 10). 28
Warnings Line has trailing spaces. 41
Infos Method 'doFilter' is not designed for extension - needs to be abstract, final or empty. 55
Errors method def throws at indentation level 12 not at correct indentation, 8 56
Errors 'if' is not followed by whitespace. 92
Errors '{' should be on a new line. 92
Errors '+' should be on a new line. 96
Warnings Line has trailing spaces. 98
Warnings Line has trailing spaces. 107
Errors '{' is not preceded with whitespace. 109
Errors '{' is not followed by whitespace. 109
Errors '}' is not preceded with whitespace. 109
Errors '{' is not followed by whitespace. 110
Errors '}' is not preceded with whitespace. 110

com/atlassian/gadgets/renderer/internal/servlet/RpcRelay.java

Violation Message Line
Errors assign child at indentation level 6 not at correct indentation, 8 20
Errors assign child at indentation level 6 not at correct indentation, 8 21
Errors assign child at indentation level 6 not at correct indentation, 8 22
Errors assign child at indentation level 6 not at correct indentation, 8 23
Errors assign child at indentation level 6 not at correct indentation, 8 24
Errors assign child at indentation level 6 not at correct indentation, 8 25
Errors assign child at indentation level 6 not at correct indentation, 8 26
Errors assign child at indentation level 6 not at correct indentation, 8 27
Infos Method 'doGet' is not designed for extension - needs to be abstract, final or empty. 29

com/atlassian/gadgets/renderer/internal/servlet/TrustedAppMakeRequestHandler.java

Violation Message Line
Errors Missing package-info.java file. 0
Errors Wrong order for 'com.atlassian.gadgets.renderer.internal.http.TrustedAppContentFetcherFactory' import. 6
Errors 'com.google.inject.Inject' should be separated from previous imports. 7
Errors Missing a Javadoc comment. 10
Warnings Line has trailing spaces. 18