The following document contains the results of Checkstyle.
Files | Infos | Warnings | Errors |
---|---|---|---|
31 | 0 | 0 | 936 |
Rules | Violations | Severity |
---|---|---|
PackageHtml | 6 | Error |
NewlineAtEndOfFile | 2 | Error |
Translation | 0 | Error |
JavadocMethod | 112 | Error |
JavadocType | 18 | Error |
JavadocVariable | 59 | Error |
JavadocStyle | 4 | Error |
ConstantName | 0 | Error |
LocalFinalVariableName | 0 | Error |
LocalVariableName | 0 | Error |
MemberName | 0 | Error |
MethodName | 0 | Error |
PackageName | 0 | Error |
ParameterName | 0 | Error |
StaticVariableName | 0 | Error |
TypeName | 0 | Error |
AvoidStarImport | 0 | Error |
IllegalImport | 0 | Error |
RedundantImport | 0 | Error |
UnusedImports | 4 | Error |
FileLength | 0 | Error |
LineLength | 153 | Error |
MethodLength | 0 | Error |
ParameterNumber | 0 | Error |
EmptyForIteratorPad | 0 | Error |
MethodParamPad | 0 | Error |
NoWhitespaceAfter | 1 | Error |
NoWhitespaceBefore | 0 | Error |
OperatorWrap | 6 | Error |
ParenPad | 0 | Error |
TypecastParenPad | 0 | Error |
TabCharacter | 0 | Error |
WhitespaceAfter | 5 | Error |
WhitespaceAround | 127 | Error |
ModifierOrder | 4 | Error |
RedundantModifier | 6 | Error |
AvoidNestedBlocks | 0 | Error |
EmptyBlock | 0 | Error |
LeftCurly | 140 | Error |
NeedBraces | 3 | Error |
RightCurly | 14 | Error |
AvoidInlineConditionals | 1 | Error |
DoubleCheckedLocking | 0 | Error |
EmptyStatement | 0 | Error |
EqualsHashCode | 0 | Error |
HiddenField | 30 | Error |
IllegalInstantiation | 0 | Error |
InnerAssignment | 0 | Error |
MagicNumber | 5 | Error |
MissingSwitchDefault | 2 | Error |
RedundantThrows | 8 | Error |
SimplifyBooleanExpression | 0 | Error |
SimplifyBooleanReturn | 0 | Error |
DesignForExtension | 46 | Error |
FinalClass | 0 | Error |
HideUtilityClassConstructor | 1 | Error |
InterfaceIsType | 0 | Error |
VisibilityModifier | 0 | Error |
ArrayTypeStyle | 0 | Error |
FinalParameters | 132 | Error |
GenericIllegalRegexp
|
47 | Error |
TodoComment | 0 | Error |
UpperEll | 0 | Error |
Violation | Message | Line |
---|---|---|
Line is longer than 80 characters. | 23 | |
Line has trailing spaces. | 24 | |
Line is longer than 80 characters. | 24 | |
'{' should be on the previous line. | 28 | |
Missing a Javadoc comment. | 29 | |
Utility classes should not have a public or default constructor. | 29 | |
'{' should be on the previous line. | 30 | |
Missing a Javadoc comment. | 31 | |
Missing a Javadoc comment. | 32 | |
Line has trailing spaces. | 34 | |
Line is longer than 80 characters. | 35 | |
Missing a Javadoc comment. | 36 | |
Line has trailing spaces. | 37 | |
Missing a Javadoc comment. | 38 | |
Line is longer than 80 characters. | 39 | |
Parameter applicationProperties should be final. | 39 | |
Line is longer than 80 characters. | 45 | |
Missing a Javadoc comment. | 45 | |
'<' is not preceded with whitespace. | 45 | |
'<' is not followed by whitespace. | 45 | |
'>' is not preceded with whitespace. | 45 | |
Parameter applicationProperties should be final. | 45 | |
Line is longer than 80 characters. | 47 | |
'<' is not preceded with whitespace. | 47 | |
'<' is not followed by whitespace. | 47 | |
'>' is not preceded with whitespace. | 47 | |
'<' is not preceded with whitespace. | 47 | |
'<' is not followed by whitespace. | 47 | |
'>' is not preceded with whitespace. | 47 | |
'>' is not followed by whitespace. | 47 | |
Line is longer than 80 characters. | 50 | |
Line is longer than 80 characters. | 53 | |
Line has trailing spaces. | 70 | |
Line is longer than 80 characters. | 101 | |
Line is longer than 80 characters. | 105 | |
Line is longer than 80 characters. | 111 | |
'<' is not preceded with whitespace. | 111 | |
'<' is not followed by whitespace. | 111 | |
'>' is not preceded with whitespace. | 111 | |
'>' is not followed by whitespace. | 111 | |
Line is longer than 80 characters. | 128 | |
Line has trailing spaces. | 137 | |
Line is longer than 80 characters. | 137 | |
Line is longer than 80 characters. | 138 | |
Line has trailing spaces. | 139 | |
Line has trailing spaces. | 140 | |
Line is longer than 80 characters. | 142 | |
Line is longer than 80 characters. | 144 | |
'{' should be on the previous line. | 149 | |
Line is longer than 80 characters. | 150 | |
First sentence should end with a period. | 155 | |
Line has trailing spaces. | 156 | |
Expected an @return tag. | 158 | |
Line is longer than 80 characters. | 158 | |
Expected @param tag for 'applicationProperties'. | 158 | |
'{' should be on the previous line. | 163 | |
Line is longer than 80 characters. | 164 | |
Method 'getContainers' is not designed for extension - needs to be abstract, final or empty. | 172 | |
'<' is not preceded with whitespace. | 172 | |
'<' is not followed by whitespace. | 172 | |
'>' is not preceded with whitespace. | 172 | |
'{' should be on the previous line. | 173 | |
Line has trailing spaces. | 181 | |
Line is longer than 80 characters. | 182 | |
Method 'getJson' is not designed for extension - needs to be abstract, final or empty. | 190 | |
Parameter container should be final. | 190 | |
Expected @param tag for 'container'. | 190 | |
Parameter parameter should be final. | 190 | |
'{' should be on the previous line. | 191 | |
Line is longer than 80 characters. | 192 | |
'{' should be on the previous line. | 197 | |
'{' should be on the previous line. | 203 | |
'{' should be on the previous line. | 205 | |
'{' should be on the previous line. | 208 | |
'}' should be on the same line. | 210 | |
'{' should be on the previous line. | 212 | |
'}' should be on the same line. | 217 | |
'{' should be on the previous line. | 219 |
Violation | Message | Line |
---|---|---|
Missing a Javadoc comment. | 14 | |
'{' should be on the previous line. | 15 | |
Missing a Javadoc comment. | 16 | |
Line has trailing spaces. | 17 | |
Missing a Javadoc comment. | 18 | |
Parameter factory should be final. | 18 | |
'{' should be on the previous line. | 19 | |
Missing a Javadoc comment. | 23 | |
Parameter factory should be final. | 23 | |
'{' should be on the previous line. | 24 | |
Line is longer than 80 characters. | 25 | |
'{' should be on the previous line. | 28 | |
'32' is a magic number. | 30 | |
Line has trailing spaces. | 37 | |
Line is longer than 80 characters. | 38 | |
Method 'unwrap' is not designed for extension - needs to be abstract, final or empty. | 38 | |
Missing a Javadoc comment. | 38 | |
'<' is not preceded with whitespace. | 38 | |
'<' is not followed by whitespace. | 38 | |
'>' is not preceded with whitespace. | 38 | |
Parameter paramString should be final. | 38 | |
Parameter paramInt should be final. | 38 | |
Method 'wrap' is not designed for extension - needs to be abstract, final or empty. | 43 | |
Missing a Javadoc comment. | 43 | |
Parameter paramMap should be final. | 43 | |
'<' is not preceded with whitespace. | 43 | |
'<' is not followed by whitespace. | 43 | |
'>' is not preceded with whitespace. | 43 |
Violation | Message | Line |
---|---|---|
Line is longer than 80 characters. | 7 | |
'{' should be on the previous line. | 10 | |
First sentence should end with a period. | 11 | |
Line is longer than 80 characters. | 14 | |
'static' modifier out of order with the JLS suggestions. | 14 | |
Method 'shouldIgnoreCache' is not designed for extension - needs to be abstract, final or empty. | 16 | |
Missing a Javadoc comment. | 16 | |
Parameter requestCacheSetting should be final. | 16 | |
'{' should be on the previous line. | 17 | |
'{' should be on the previous line. | 20 | |
'{' should be on the previous line. | 22 | |
Line is longer than 80 characters. | 28 | |
'{' should be on the previous line. | 30 |
Violation | Message | Line |
---|---|---|
'{' should be on the previous line. | 11 | |
Missing a Javadoc comment. | 12 | |
Missing a Javadoc comment. | 14 | |
Parameter applicationProperties should be final. | 14 | |
'applicationProperties' hides a field. | 14 | |
Line has trailing spaces. | 21 | |
Method 'getDomain' is not designed for extension - needs to be abstract, final or empty. | 24 | |
'{' should be on the previous line. | 25 |
Violation | Message | Line |
---|---|---|
Unused import - org.apache.shindig.auth.AnonymousSecurityToken. | 7 | |
Line is longer than 80 characters. | 15 | |
Line is longer than 80 characters. | 17 | |
Missing a Javadoc comment. | 17 | |
Missing a Javadoc comment. | 19 | |
Missing a Javadoc comment. | 20 | |
Line is longer than 80 characters. | 22 | |
Missing a Javadoc comment. | 22 | |
Parameter crypter should be final. | 22 | |
'crypter' hides a field. | 22 | |
Parameter domainProvider should be final. | 22 | |
'domainProvider' hides a field. | 22 | |
Line has trailing spaces. | 25 | |
Expected an @return tag. | 31 | |
Line is longer than 80 characters. | 31 | |
Method 'createToken' is not designed for extension - needs to be abstract, final or empty. | 31 | |
Parameter tokenParameters should be final. | 31 | |
'<' is not preceded with whitespace. | 31 | |
'<' is not followed by whitespace. | 31 | |
'>' is not preceded with whitespace. | 31 | |
Expected @param tag for 'tokenParameters'. | 31 | |
Expected @throws tag for 'SecurityTokenException'. | 31 | |
Line is longer than 80 characters. | 33 | |
'{' should be on the previous line. | 35 | |
'{' should be on the previous line. | 41 | |
Line is longer than 80 characters. | 45 | |
'{' should be on the previous line. | 51 | |
Line is longer than 80 characters. | 52 | |
'}' should be on the same line. | 53 | |
'{' should be on the previous line. | 55 | |
Line has trailing spaces. | 59 | |
Line is longer than 80 characters. | 61 | |
Expected an @return tag. | 63 | |
Line is longer than 80 characters. | 63 | |
Parameter crypter should be final. | 63 | |
Expected @param tag for 'crypter'. | 63 | |
Parameter container should be final. | 63 | |
Expected @param tag for 'container'. | 63 | |
Parameter domain should be final. | 63 | |
Expected @param tag for 'domain'. | 63 | |
Parameter token should be final. | 63 | |
Expected @param tag for 'token'. | 63 | |
Expected @throws tag for 'BlobCrypterException'. | 64 | |
'{' should be on the previous line. | 65 | |
'<' is not preceded with whitespace. | 66 | |
'<' is not followed by whitespace. | 66 | |
'>' is not preceded with whitespace. | 66 | |
'3600' is a magic number. | 66 | |
Line is longer than 80 characters. | 67 | |
'{' should be on the previous line. | 73 |
Violation | Message | Line |
---|---|---|
Unused import - java.util.Map. | 5 | |
Unused import - java.util.Collections. | 6 | |
Missing a Javadoc comment. | 8 | |
'{' should be on the previous line. | 9 | |
Missing a Javadoc comment. | 10 | |
Missing a Javadoc comment. | 12 | |
Parameter feature should be final. | 12 | |
'{' should be on the previous line. | 13 | |
Method 'getParameterValue' is not designed for extension - needs to be abstract, final or empty. | 17 | |
Missing a Javadoc comment. | 17 | |
Parameter paramName should be final. | 17 | |
'{' should be on the previous line. | 18 | |
Method 'getName' is not designed for extension - needs to be abstract, final or empty. | 22 | |
Missing a Javadoc comment. | 22 | |
'{' should be on the previous line. | 23 |
Violation | Message | Line |
---|---|---|
Line is longer than 80 characters. | 17 | |
Missing a Javadoc comment. | 19 | |
Missing a Javadoc comment. | 20 | |
Line has trailing spaces. | 25 | |
Line is longer than 80 characters. | 25 | |
Line is longer than 80 characters. | 27 | |
Parameter localeResolver should be final. | 27 | |
'localeResolver' hides a field. | 27 | |
Parameter userManager should be final. | 27 | |
'userManager' hides a field. | 27 | |
Missing a Javadoc comment. | 33 | |
Parameter request should be final. | 33 | |
'{' should be on the previous line. | 34 | |
Missing a Javadoc comment. | 42 | |
Parameter request should be final. | 42 | |
'{' should be on the previous line. | 43 | |
Line is longer than 80 characters. | 44 |
Violation | Message | Line |
---|---|---|
Missing a Javadoc comment. | 24 | |
'{' should be on the previous line. | 25 | |
Missing a Javadoc comment. | 26 | |
Missing a Javadoc comment. | 27 | |
Missing a Javadoc comment. | 28 | |
Missing a Javadoc comment. | 29 | |
Line is longer than 80 characters. | 31 | |
Missing a Javadoc comment. | 31 | |
Parameter provider should be final. | 31 | |
'<' is not preceded with whitespace. | 31 | |
'<' is not followed by whitespace. | 31 | |
'>' is not preceded with whitespace. | 31 | |
Parameter cachePolicy should be final. | 31 | |
'cachePolicy' hides a field. | 31 | |
Line is longer than 80 characters. | 33 | |
Line is longer than 80 characters. | 35 | |
Line is longer than 80 characters. | 39 | |
Method 'getGadgetSpec' is not designed for extension - needs to be abstract, final or empty. | 39 | |
Missing a Javadoc comment. | 39 | |
Parameter gadgetContext should be final. | 39 | |
Line is longer than 80 characters. | 41 | |
Line is longer than 80 characters. | 42 | |
Line is longer than 80 characters. | 45 | |
Method 'getGadgetSpec' is not designed for extension - needs to be abstract, final or empty. | 45 | |
Missing a Javadoc comment. | 45 | |
Redundant throws: 'GadgetParsingException' is unchecked exception. | 45 | |
Line is longer than 80 characters. | 47 | |
Line is longer than 80 characters. | 50 | |
Method 'getGadgetSpec' is not designed for extension - needs to be abstract, final or empty. | 50 | |
Missing a Javadoc comment. | 50 | |
Parameter uri should be final. | 50 | |
Parameter gadgetRequestContext should be final. | 50 | |
Redundant throws: 'GadgetParsingException' is unchecked exception. | 50 | |
Line is longer than 80 characters. | 52 | |
'<' is not preceded with whitespace. | 52 | |
'<' is not followed by whitespace. | 52 | |
',' is not followed by whitespace. | 52 | |
'>' is not preceded with whitespace. | 52 | |
'>' is not followed by whitespace. | 52 | |
Missing a Javadoc comment. | 55 | |
'<' is not preceded with whitespace. | 56 | |
'<' is not followed by whitespace. | 56 | |
'>' is not preceded with whitespace. | 56 | |
Line is longer than 80 characters. | 57 | |
Redundant throws: 'GadgetParsingException' is unchecked exception. | 58 | |
'{' should be on the previous line. | 59 | |
'{' should be on the previous line. | 64 | |
'{' should be on the previous line. | 70 | |
Line is longer than 80 characters. | 71 | |
'{' should be on the previous line. | 76 | |
'{' should be on the previous line. | 82 | |
'{' should be on the previous line. | 88 | |
'{' should be on the previous line. | 90 | |
'{' should be on the previous line. | 98 | |
'}' should be on the same line. | 100 | |
'{' should be on the previous line. | 102 |
Violation | Message | Line |
---|---|---|
Missing a Javadoc comment. | 23 | |
'{' should be on the previous line. | 24 | |
Missing a Javadoc comment. | 25 | |
Missing a Javadoc comment. | 26 | |
Line is longer than 80 characters. | 28 | |
Missing a Javadoc comment. | 28 | |
Parameter shindigGadgetSpec should be final. | 28 | |
'shindigGadgetSpec' hides a field. | 28 | |
Parameter gadgetFeatureRegistry should be final. | 28 | |
'gadgetFeatureRegistry' hides a field. | 28 | |
Method 'isScrolling' is not designed for extension - needs to be abstract, final or empty. | 34 | |
Missing a Javadoc comment. | 34 | |
'{' should be on the previous line. | 35 | |
Method 'getHeight' is not designed for extension - needs to be abstract, final or empty. | 39 | |
Missing a Javadoc comment. | 39 | |
'{' should be on the previous line. | 40 | |
Method 'getWidth' is not designed for extension - needs to be abstract, final or empty. | 44 | |
Missing a Javadoc comment. | 44 | |
'{' should be on the previous line. | 45 | |
Method 'getTitle' is not designed for extension - needs to be abstract, final or empty. | 49 | |
Missing a Javadoc comment. | 49 | |
'{' should be on the previous line. | 50 | |
Method 'getTitleUrl' is not designed for extension - needs to be abstract, final or empty. | 54 | |
Missing a Javadoc comment. | 54 | |
'{' should be on the previous line. | 55 | |
Line is longer than 80 characters. | 56 | |
Method 'getThumbnail' is not designed for extension - needs to be abstract, final or empty. | 59 | |
Missing a Javadoc comment. | 59 | |
'{' should be on the previous line. | 60 | |
Line is longer than 80 characters. | 61 | |
Missing a Javadoc comment. | 64 | |
Parameter shindigUri should be final. | 64 | |
'{' should be on the previous line. | 65 | |
'{' should be on the previous line. | 67 | |
Method 'getAuthor' is not designed for extension - needs to be abstract, final or empty. | 73 | |
Missing a Javadoc comment. | 73 | |
'{' should be on the previous line. | 74 | |
Method 'getAuthorEmail' is not designed for extension - needs to be abstract, final or empty. | 78 | |
Missing a Javadoc comment. | 78 | |
'{' should be on the previous line. | 79 | |
Method 'getDescription' is not designed for extension - needs to be abstract, final or empty. | 83 | |
Missing a Javadoc comment. | 83 | |
'{' should be on the previous line. | 84 | |
Method 'getDirectoryTitle' is not designed for extension - needs to be abstract, final or empty. | 88 | |
Missing a Javadoc comment. | 88 | |
'{' should be on the previous line. | 89 | |
Method 'getUrl' is not designed for extension - needs to be abstract, final or empty. | 93 | |
Missing a Javadoc comment. | 93 | |
'{' should be on the previous line. | 94 | |
Method 'getUserPrefs' is not designed for extension - needs to be abstract, final or empty. | 98 | |
Missing a Javadoc comment. | 98 | |
'<' is not preceded with whitespace. | 98 | |
'<' is not followed by whitespace. | 98 | |
'>' is not preceded with whitespace. | 98 | |
'{' should be on the previous line. | 99 | |
Line is longer than 80 characters. | 100 | |
'<' is not preceded with whitespace. | 100 | |
'<' is not followed by whitespace. | 100 | |
'>' is not preceded with whitespace. | 100 | |
'>' is not followed by whitespace. | 100 | |
Line is longer than 80 characters. | 102 | |
Parameter userPref should be final. | 102 | |
Missing a Javadoc comment. | 109 | |
'<' is not preceded with whitespace. | 109 | |
'<' is not followed by whitespace. | 109 | |
'>' is not preceded with whitespace. | 109 | |
'{' should be on the previous line. | 110 | |
Method 'supportsView' is not designed for extension - needs to be abstract, final or empty. | 114 | |
Missing a Javadoc comment. | 114 | |
Parameter view should be final. | 114 | |
'{' should be on the previous line. | 115 | |
'<' is not preceded with whitespace. | 116 | |
'<' is not followed by whitespace. | 116 | |
'>' is not preceded with whitespace. | 116 | |
Line is longer than 80 characters. | 117 | |
Method 'getFeatures' is not designed for extension - needs to be abstract, final or empty. | 120 | |
Missing a Javadoc comment. | 120 | |
'<' is not preceded with whitespace. | 120 | |
'<' is not followed by whitespace. | 120 | |
'>' is not preceded with whitespace. | 120 | |
'{' should be on the previous line. | 121 | |
Line is longer than 80 characters. | 122 | |
'<' is not preceded with whitespace. | 122 | |
'<' is not followed by whitespace. | 122 | |
',' is not followed by whitespace. | 122 | |
'>' is not preceded with whitespace. | 122 | |
'<' is not preceded with whitespace. | 123 | |
'<' is not followed by whitespace. | 123 | |
',' is not followed by whitespace. | 123 | |
'>' is not preceded with whitespace. | 123 | |
'<' is not preceded with whitespace. | 123 | |
'<' is not followed by whitespace. | 123 | |
',' is not followed by whitespace. | 123 | |
'>' is not preceded with whitespace. | 123 | |
'>' is not followed by whitespace. | 123 | |
'{' should be on the previous line. | 125 | |
Line is longer than 80 characters. | 126 | |
Method 'getUnsupportedFeatureNames' is not designed for extension - needs to be abstract, final or empty. | 131 | |
Missing a Javadoc comment. | 131 | |
'<' is not preceded with whitespace. | 131 | |
'<' is not followed by whitespace. | 131 | |
'>' is not preceded with whitespace. | 131 | |
'{' should be on the previous line. | 132 | |
'<' is not preceded with whitespace. | 133 | |
'<' is not followed by whitespace. | 133 | |
'>' is not preceded with whitespace. | 133 | |
'<' is not preceded with whitespace. | 133 | |
'<' is not followed by whitespace. | 133 | |
'>' is not preceded with whitespace. | 133 | |
'>' is not followed by whitespace. | 133 | |
'<' is not preceded with whitespace. | 136 | |
'<' is not followed by whitespace. | 136 | |
'>' is not preceded with whitespace. | 136 | |
'<' is not preceded with whitespace. | 136 | |
'<' is not followed by whitespace. | 136 | |
'>' is not preceded with whitespace. | 136 | |
'>' is not followed by whitespace. | 136 | |
Line is longer than 80 characters. | 137 | |
'<' is not preceded with whitespace. | 137 | |
'<' is not followed by whitespace. | 137 | |
',' is not followed by whitespace. | 137 | |
'>' is not preceded with whitespace. | 137 | |
'{' should be on the previous line. | 139 | |
'{' should be on the previous line. | 141 | |
Line is longer than 80 characters. | 146 |
Violation | Message | Line |
---|---|---|
Line is longer than 80 characters. | 14 | |
Line is longer than 80 characters. | 24 | |
'{' should be on the previous line. | 29 | |
Missing a Javadoc comment. | 30 | |
Missing a Javadoc comment. | 32 | |
'<' is not preceded with whitespace. | 32 | |
'<' is not followed by whitespace. | 32 | |
'>' is not preceded with whitespace. | 32 | |
Line is longer than 80 characters. | 35 | |
Line is longer than 80 characters. | 38 | |
Unused @throws tag for 'NullPointerException'. | 40 | |
Line is longer than 80 characters. | 42 | |
Parameter permissions should be final. | 42 | |
'<' is not preceded with whitespace. | 42 | |
'<' is not followed by whitespace. | 42 | |
'>' is not preceded with whitespace. | 42 | |
'permissions' hides a field. | 42 | |
Method 'assertRenderable' is not designed for extension - needs to be abstract, final or empty. | 48 | |
Missing a Javadoc comment. | 48 | |
'{' should be on the previous line. | 49 | |
'{' should be on the previous line. | 52 | |
Line is longer than 80 characters. | 53 | |
'+' should be on a new line. | 53 | |
'{' should be on the previous line. | 61 | |
Line has trailing spaces. | 62 | |
'{' should be on the previous line. | 64 | |
'}' should be on the same line. | 66 | |
'{' should be on the previous line. | 68 | |
'{' should be on the previous line. | 70 | |
Line is longer than 80 characters. | 71 | |
'}' should be on the same line. | 72 | |
'{' should be on the previous line. | 74 | |
Line is longer than 80 characters. | 78 | |
'+' should be on a new line. | 78 | |
switch without "default" clause. | 81 | |
'{' should be on the previous line. | 82 | |
'+' should be on a new line. | 84 | |
Line is longer than 80 characters. | 85 | |
'{' should be on the previous line. | 97 | |
Line is longer than 80 characters. | 98 | |
'+' should be on a new line. | 98 |
Violation | Message | Line |
---|---|---|
Line is longer than 80 characters. | 8 | |
Missing a Javadoc comment. | 11 | |
'{' should be on the previous line. | 12 | |
Missing a Javadoc comment. | 13 | |
Missing a Javadoc comment. | 14 | |
Line has trailing spaces. | 15 | |
Line is longer than 80 characters. | 16 | |
Missing a Javadoc comment. | 16 | |
Parameter crypter should be final. | 16 | |
'crypter' hides a field. | 16 | |
Parameter domainProvider should be final. | 16 | |
'domainProvider' hides a field. | 16 | |
Line has trailing spaces. | 21 | |
Method 'newSecurityToken' is not designed for extension - needs to be abstract, final or empty. | 22 | |
Missing a Javadoc comment. | 22 | |
Parameter state should be final. | 22 | |
Parameter viewer should be final. | 22 | |
'{' should be on the previous line. | 23 | |
Line is longer than 80 characters. | 24 | |
'{' should be on the previous line. | 26 | |
Line is longer than 80 characters. | 29 | |
Line has trailing spaces. | 33 | |
'{' should be on the previous line. | 36 | |
'}' should be on the same line. | 38 | |
'{' should be on the previous line. | 40 |
Violation | Message | Line |
---|---|---|
Missing a Javadoc comment. | 14 | |
'{' should be on the previous line. | 16 | |
Missing a Javadoc comment. | 17 | |
Missing a Javadoc comment. | 18 | |
Missing a Javadoc comment. | 19 | |
Missing a Javadoc comment. | 20 | |
Missing a Javadoc comment. | 21 | |
'<' is not preceded with whitespace. | 21 | |
'<' is not followed by whitespace. | 21 | |
'>' is not preceded with whitespace. | 21 | |
Missing a Javadoc comment. | 22 | |
Line is longer than 80 characters. | 24 | |
Missing a Javadoc comment. | 24 | |
Parameter shindigUserPrefSpec should be final. | 24 | |
Line is longer than 80 characters. | 27 | |
Avoid inline conditionals. | 27 | |
Line is longer than 80 characters. | 31 | |
'<' is not preceded with whitespace. | 32 | |
'<' is not followed by whitespace. | 32 | |
'>' is not preceded with whitespace. | 32 | |
'enumValues' hides a field. | 32 | |
'<' is not preceded with whitespace. | 32 | |
'<' is not followed by whitespace. | 32 | |
'>' is not preceded with whitespace. | 32 | |
'>' is not followed by whitespace. | 32 | |
Line is longer than 80 characters. | 33 | |
Redundant 'final' modifier. | 46 | |
'{' should be on the previous line. | 47 | |
Redundant 'final' modifier. | 56 | |
'{' should be on the previous line. | 57 | |
Redundant 'final' modifier. | 65 | |
'{' should be on the previous line. | 66 | |
Redundant 'final' modifier. | 74 | |
'{' should be on the previous line. | 75 | |
Redundant 'final' modifier. | 84 | |
'<' is not preceded with whitespace. | 84 | |
'<' is not followed by whitespace. | 84 | |
'>' is not preceded with whitespace. | 84 | |
'{' should be on the previous line. | 85 | |
Line is longer than 80 characters. | 91 | |
Redundant 'final' modifier. | 93 | |
'{' should be on the previous line. | 94 | |
Missing a Javadoc comment. | 98 | |
'{' should be on the previous line. | 100 | |
'17' is a magic number. | 101 | |
'59' is a magic number. | 101 | |
Missing a Javadoc comment. | 110 | |
Parameter o should be final. | 111 | |
'{' should be on the previous line. | 112 | |
'if' construct must use '{}'s. | 113 | |
'if' construct must use '{}'s. | 114 | |
'if' construct must use '{}'s. | 115 |
Violation | Message | Line |
---|---|---|
Line is longer than 80 characters. | 11 | |
Unused import - com.google.inject.Module. | 16 | |
Line is longer than 80 characters. | 20 | |
'{' should be on the previous line. | 24 | |
Missing a Javadoc comment. | 25 | |
Missing a Javadoc comment. | 26 | |
Missing a Javadoc comment. | 28 | |
Parameter consumerService should be final. | 28 | |
'consumerService' hides a field. | 28 | |
Parameter tokenStore should be final. | 28 | |
'tokenStore' hides a field. | 28 | |
'{' should be on the previous line. | 29 | |
Line has trailing spaces. | 33 | |
Method 'configure' is not designed for extension - needs to be abstract, final or empty. | 34 | |
Missing a Javadoc comment. | 34 | |
'{' should be on the previous line. | 35 | |
Line is longer than 80 characters. | 37 | |
Line has trailing spaces. | 48 | |
Line has trailing spaces. | 51 |
Violation | Message | Line |
---|---|---|
First sentence should end with a period. | 10 | |
'<' is not preceded with whitespace. | 13 | |
'<' is not followed by whitespace. | 13 | |
'>' is not preceded with whitespace. | 13 | |
'{' should be on the previous line. | 14 | |
Missing a Javadoc comment. | 15 | |
Line has trailing spaces. | 16 | |
Line is longer than 80 characters. | 17 | |
Missing a Javadoc comment. | 17 | |
Parameter salModule should be final. | 17 | |
Parameter shindigModule should be final. | 17 | |
Parameter authModule should be final. | 17 | |
Method 'get' is not designed for extension - needs to be abstract, final or empty. | 27 | |
Missing a Javadoc comment. | 27 | |
'{' should be on the previous line. | 28 |
Violation | Message | Line |
---|---|---|
Missing a Javadoc comment. | 9 | |
'{' should be on the previous line. | 10 | |
Missing a Javadoc comment. | 11 | |
Missing a Javadoc comment. | 12 | |
Missing a Javadoc comment. | 13 | |
Missing a Javadoc comment. | 14 | |
Missing a Javadoc comment. | 16 | |
Parameter applicationProperties should be final. | 16 | |
'applicationProperties' hides a field. | 16 | |
Parameter trustedApplicationsManager should be final. | 17 | |
'trustedApplicationsManager' hides a field. | 17 | |
Parameter userManager should be final. | 18 | |
'userManager' hides a field. | 18 | |
Parameter pluginSettingsFactory should be final. | 19 | |
'pluginSettingsFactory' hides a field. | 19 | |
'{' should be on the previous line. | 20 | |
Method 'configure' is not designed for extension - needs to be abstract, final or empty. | 27 | |
Missing a Javadoc comment. | 27 | |
'{' should be on the previous line. | 29 | |
Line is longer than 80 characters. | 31 |
Violation | Message | Line |
---|---|---|
Line is longer than 80 characters. | 19 | |
Line is longer than 80 characters. | 20 | |
Line is longer than 80 characters. | 27 | |
'{' should be on the previous line. | 31 | |
Missing a Javadoc comment. | 32 | |
'static' modifier out of order with the JLS suggestions. | 32 | |
Missing a Javadoc comment. | 33 | |
'static' modifier out of order with the JLS suggestions. | 33 | |
Missing a Javadoc comment. | 35 | |
Missing a Javadoc comment. | 36 | |
Missing a Javadoc comment. | 38 | |
Parameter decoder should be final. | 38 | |
'decoder' hides a field. | 38 | |
'{' should be on the previous line. | 39 | |
Line is longer than 80 characters. | 46 | |
Missing a Javadoc comment. | 46 | |
Parameter propertiesFile should be final. | 46 | |
Parameter properties should be final. | 46 | |
'properties' hides a field. | 46 | |
'{' should be on the previous line. | 50 | |
'}' should be on the same line. | 53 | |
'{' should be on the previous line. | 55 | |
Line is longer than 80 characters. | 57 | |
'}' should be on the same line. | 58 | |
'{' should be on the previous line. | 60 | |
Method 'configure' is not designed for extension - needs to be abstract, final or empty. | 65 | |
Missing a Javadoc comment. | 65 | |
'{' should be on the previous line. | 67 | |
Line is longer than 80 characters. | 70 |
Violation | Message | Line |
---|---|---|
Missing package documentation file. | 0 |
Violation | Message | Line |
---|---|---|
File does not end with a newline. | 0 | |
Missing a Javadoc comment. | 65 | |
Missing a Javadoc comment. | 67 | |
Missing a Javadoc comment. | 69 | |
Parameter cache should be final. | 70 | |
'cache' hides a field. | 70 | |
Method 'fetch' is not designed for extension - needs to be abstract, final or empty. | 75 | |
Parameter request should be final. | 75 | |
Line is longer than 80 characters. | 84 | |
'||' should be on a new line. | 97 | |
Missing a Javadoc comment. | 105 | |
Parameter sslProtocol should be final. | 105 | |
'{' should be on the previous line. | 106 | |
Line is longer than 80 characters. | 110 | |
Line is longer than 80 characters. | 113 | |
'443' is a magic number. | 113 | |
Missing a Javadoc comment. | 117 | |
Parameter request should be final. | 117 | |
Line is longer than 80 characters. | 119 | |
Line is longer than 80 characters. | 121 | |
'<' is not preceded with whitespace. | 121 | |
'<' is not followed by whitespace. | 121 | |
'<' is not preceded with whitespace. | 121 | |
'<' is not followed by whitespace. | 121 | |
'>' is not preceded with whitespace. | 121 | |
'>' is not followed by whitespace. | 121 | |
'>' is not preceded with whitespace. | 121 | |
Line is longer than 80 characters. | 122 | |
Line has trailing spaces. | 127 | |
Line is longer than 80 characters. | 127 | |
Missing a Javadoc comment. | 127 | |
Parameter hcResponse should be final. | 127 | |
Line has trailing spaces. | 139 | |
Line is longer than 80 characters. | 140 | |
Line is longer than 80 characters. | 143 | |
Line is longer than 80 characters. | 144 | |
Missing a Javadoc comment. | 144 | |
Missing a Javadoc comment. | 145 | |
Missing a Javadoc comment. | 147 | |
Parameter protocol should be final. | 147 | |
'protocol' hides a field. | 147 | |
Line has trailing spaces. | 150 | |
Missing a Javadoc comment. | 151 | |
'{' is followed by whitespace. | 153 | |
Line is longer than 80 characters. | 157 | |
Missing a Javadoc comment. | 157 | |
Parameter sock should be final. | 157 | |
Parameter host should be final. | 157 | |
Parameter port should be final. | 157 | |
Parameter localAddress should be final. | 157 | |
Parameter localPort should be final. | 157 | |
Parameter params should be final. | 157 | |
Redundant throws: 'UnknownHostException' is subclass of 'IOException'. | 158 | |
Redundant throws: 'ConnectTimeoutException' is subclass of 'IOException'. | 158 | |
Line is longer than 80 characters. | 159 | |
Missing a Javadoc comment. | 162 | |
Parameter sock should be final. | 162 | |
Redundant throws: 'IllegalArgumentException' is unchecked exception. | 162 | |
Line is longer than 80 characters. | 166 | |
Missing a Javadoc comment. | 166 | |
Parameter socket should be final. | 166 | |
Parameter host should be final. | 166 | |
Parameter port should be final. | 166 | |
Parameter autoClose should be final. | 166 | |
Redundant throws: 'UnknownHostException' is subclass of 'IOException'. | 166 | |
Line has trailing spaces. | 170 | |
Line is longer than 80 characters. | 171 | |
Missing a Javadoc comment. | 171 | |
Line is longer than 80 characters. | 172 | |
Missing a Javadoc comment. | 172 | |
Line is longer than 80 characters. | 179 | |
Line has trailing spaces. | 189 | |
Line is longer than 80 characters. | 190 | |
Missing a Javadoc comment. | 190 | |
'abstract' modifier out of order with the JLS suggestions. | 190 | |
Missing a Javadoc comment. | 191 | |
Parameter wrapped should be final. | 191 | |
Line has trailing spaces. | 194 | |
Missing a Javadoc comment. | 195 | |
Line is longer than 80 characters. | 196 | |
Redundant throws: 'IllegalStateException' is unchecked exception. | 196 | |
Missing a Javadoc comment. | 201 | |
Line has trailing spaces. | 206 | |
Missing a Javadoc comment. | 207 | |
Line has trailing spaces. | 209 | |
Line is longer than 80 characters. | 210 | |
Missing a Javadoc comment. | 210 | |
Missing a Javadoc comment. | 211 | |
Missing a Javadoc comment. | 215 | |
Parameter is should be final. | 216 | |
Line is longer than 80 characters. | 221 | |
Missing a Javadoc comment. | 221 | |
Missing a Javadoc comment. | 222 | |
Missing a Javadoc comment. | 226 | |
Parameter is should be final. | 227 | |
Missing a Javadoc comment. | 232 | |
Missing a Javadoc comment. | 233 | |
Missing a Javadoc comment. | 233 | |
Missing a Javadoc comment. | 233 | |
Missing a Javadoc comment. | 233 | |
Missing a Javadoc comment. | 233 | |
Missing a Javadoc comment. | 233 | |
Missing a Javadoc comment. | 233 | |
Line has trailing spaces. | 234 | |
Missing a Javadoc comment. | 235 | |
Parameter uri should be final. | 235 | |
switch without "default" clause. | 236 |
Violation | Message | Line |
---|---|---|
'{' should be on the previous line. | 24 | |
Missing a Javadoc comment. | 25 | |
Missing a Javadoc comment. | 26 | |
Missing a Javadoc comment. | 28 | |
Line is longer than 80 characters. | 29 | |
Parameter remoteContentFetcherFactory should be final. | 29 | |
Parameter oauthFetcherFactory should be final. | 30 | |
Parameter trustedAppsManager should be final. | 31 | |
'trustedAppsManager' hides a field. | 31 | |
Parameter userManager should be final. | 32 | |
'userManager' hides a field. | 32 | |
'{' should be on the previous line. | 33 | |
Line has trailing spaces. | 38 | |
Method 'fetch' is not designed for extension - needs to be abstract, final or empty. | 39 | |
Missing a Javadoc comment. | 39 | |
Parameter request should be final. | 40 | |
'{' should be on the previous line. | 41 | |
Missing a Javadoc comment. | 46 | |
Parameter request should be final. | 46 | |
Parameter username should be final. | 46 | |
'{' should be on the previous line. | 47 | |
Line has trailing spaces. | 49 | |
'!=' is not preceded with whitespace. | 50 | |
'!=' is not followed by whitespace. | 50 | |
'{' should be on the previous line. | 51 | |
Line is longer than 80 characters. | 52 | |
Line is longer than 80 characters. | 53 | |
Line is longer than 80 characters. | 54 | |
Missing a Javadoc comment. | 58 | |
Parameter username should be final. | 58 | |
'{' should be on the previous line. | 59 | |
'{' should be on the previous line. | 61 | |
'}' should be on the same line. | 63 | |
'{' should be on the previous line. | 65 |
Violation | Message | Line |
---|---|---|
Missing package documentation file. | 0 |
Violation | Message | Line |
---|---|---|
Missing a Javadoc comment. | 28 | |
'{' should be on the previous line. | 29 | |
Missing a Javadoc comment. | 30 | |
Line has trailing spaces. | 32 | |
Missing a Javadoc comment. | 32 | |
Parameter consumerService should be final. | 32 | |
'consumerService' hides a field. | 32 | |
Line has trailing spaces. | 33 | |
Parameter fetcherConfig should be final. | 33 | |
Line has trailing spaces. | 34 | |
Parameter nextFetcher should be final. | 34 | |
Parameter request should be final. | 35 | |
'{' should be on the previous line. | 36 | |
Method 'sign' is not designed for extension - needs to be abstract, final or empty. | 41 | |
Missing a Javadoc comment. | 41 | |
Line is longer than 80 characters. | 42 | |
Parameter accessor should be final. | 42 | |
Parameter httpMethod should be final. | 42 | |
Parameter uri should be final. | 42 | |
Parameter params should be final. | 42 | |
'<' is not preceded with whitespace. | 42 | |
'<' is not followed by whitespace. | 42 | |
'>' is not preceded with whitespace. | 42 | |
'{' should be on the previous line. | 44 | |
Line has trailing spaces. | 50 | |
Line is longer than 80 characters. | 51 | |
'{' should be on the previous line. | 53 | |
Line is longer than 80 characters. | 54 | |
Line is longer than 80 characters. | 55 | |
'}' should be on the same line. | 56 | |
'{' should be on the previous line. | 58 | |
Line is longer than 80 characters. | 59 | |
Line has trailing spaces. | 61 |
Violation | Message | Line |
---|---|---|
Line is longer than 80 characters. | 15 | |
'{' should be on the previous line. | 20 | |
Missing a Javadoc comment. | 21 | |
Missing a Javadoc comment. | 23 | |
Line is longer than 80 characters. | 24 | |
Parameter fetcherConfig should be final. | 24 | |
Parameter consumerService should be final. | 24 | |
'consumerService' hides a field. | 24 | |
First sentence should end with a period. | 30 | |
Line has trailing spaces. | 32 | |
Expected an @return tag. | 35 | |
Method 'getOAuthFetcher' is not designed for extension - needs to be abstract, final or empty. | 35 | |
Line is longer than 80 characters. | 36 | |
Parameter nextFetcher should be final. | 36 | |
Expected @param tag for 'nextFetcher'. | 36 | |
Parameter request should be final. | 36 | |
Expected @param tag for 'request'. | 36 | |
Expected @throws tag for 'GadgetException'. | 36 | |
Line is longer than 80 characters. | 38 |
Violation | Message | Line |
---|---|---|
File does not end with a newline. | 0 | |
Line is longer than 80 characters. | 20 | |
Line is longer than 80 characters. | 21 | |
Line is longer than 80 characters. | 22 | |
'{' should be on the previous line. | 25 | |
Missing a Javadoc comment. | 26 | |
Missing a Javadoc comment. | 27 | |
Missing a Javadoc comment. | 29 | |
Line is longer than 80 characters. | 30 | |
Parameter consumerService should be final. | 30 | |
'consumerService' hides a field. | 30 | |
Parameter tokenStore should be final. | 30 | |
'tokenStore' hides a field. | 30 | |
Line has trailing spaces. | 35 | |
Line is longer than 80 characters. | 36 | |
Method 'getConsumerKeyAndSecret' is not designed for extension - needs to be abstract, final or empty. | 36 | |
Missing a Javadoc comment. | 36 | |
Parameter securityToken should be final. | 36 | |
Parameter service should be final. | 36 | |
Parameter provider should be final. | 36 | |
Line is longer than 80 characters. | 38 | |
Line is longer than 80 characters. | 41 | |
Method 'getTokenInfo' is not designed for extension - needs to be abstract, final or empty. | 41 | |
Missing a Javadoc comment. | 41 | |
Parameter securityToken should be final. | 41 | |
Parameter consumerInfo should be final. | 41 | |
Parameter serviceName should be final. | 41 | |
Parameter tokenName should be final. | 41 | |
'{' should be on the previous line. | 46 | |
Line is longer than 80 characters. | 52 | |
Method 'setTokenInfo' is not designed for extension - needs to be abstract, final or empty. | 52 | |
Missing a Javadoc comment. | 52 | |
Parameter securityToken should be final. | 52 | |
Parameter consumerInfo should be final. | 52 | |
Parameter serviceName should be final. | 52 | |
Parameter tokenName should be final. | 52 | |
Parameter tokenInfo should be final. | 52 | |
Line has trailing spaces. | 62 | |
Line is longer than 80 characters. | 63 | |
Method 'removeToken' is not designed for extension - needs to be abstract, final or empty. | 63 | |
Missing a Javadoc comment. | 63 | |
Parameter securityToken should be final. | 63 | |
Parameter consumerInfo should be final. | 63 | |
Parameter serviceName should be final. | 63 | |
Parameter tokenName should be final. | 63 | |
Missing a Javadoc comment. | 69 | |
Parameter service should be final. | 69 | |
'{' should be on the previous line. | 70 | |
'{' should be on the previous line. | 73 | |
'}' should be on the same line. | 75 | |
'{' should be on the previous line. | 77 | |
'{' should be on the previous line. | 80 | |
Line has trailing spaces. | 86 | |
Line is longer than 80 characters. | 87 | |
Missing a Javadoc comment. | 87 | |
Parameter securityToken should be final. | 87 | |
Parameter serviceName should be final. | 87 | |
Parameter tokenName should be final. | 87 |
Violation | Message | Line |
---|---|---|
Missing package documentation file. | 0 |
Violation | Message | Line |
---|---|---|
Missing package documentation file. | 0 |
Violation | Message | Line |
---|---|---|
Missing a Javadoc comment. | 11 | |
'{' should be on the previous line. | 13 | |
Missing a Javadoc comment. | 14 | |
Missing a Javadoc comment. | 16 | |
Parameter specFactory should be final. | 17 | |
Line is longer than 80 characters. | 18 | |
Parameter includeUrls should be final. | 18 | |
Line is longer than 80 characters. | 20 | |
Parameter excludeUrls should be final. | 20 | |
Line is longer than 80 characters. | 22 | |
Parameter expires should be final. | 22 | |
Line is longer than 80 characters. | 24 | |
Parameter includeTags should be final. | 24 | |
Line is longer than 80 characters. | 26 | |
Parameter applicationProperties should be final. | 26 | |
'applicationProperties' hides a field. | 26 | |
Method 'getProxyUrl' is not designed for extension - needs to be abstract, final or empty. | 32 | |
Missing a Javadoc comment. | 32 | |
'{' should be on the previous line. | 33 | |
Line is longer than 80 characters. | 34 | |
Method 'getConcatUrl' is not designed for extension - needs to be abstract, final or empty. | 37 | |
Missing a Javadoc comment. | 37 | |
'{' should be on the previous line. | 38 | |
Line is longer than 80 characters. | 39 |
Violation | Message | Line |
---|---|---|
Missing package documentation file. | 0 |
Violation | Message | Line |
---|---|---|
Line is longer than 80 characters. | 12 | |
Missing a Javadoc comment. | 12 | |
Missing a Javadoc comment. | 14 | |
Line is longer than 80 characters. | 16 | |
Missing a Javadoc comment. | 16 | |
Parameter provider should be final. | 16 | |
'<' is not preceded with whitespace. | 16 | |
'<' is not followed by whitespace. | 16 | |
'>' is not preceded with whitespace. | 16 | |
Line has trailing spaces. | 20 | |
Method 'contextInitialized' is not designed for extension - needs to be abstract, final or empty. | 21 | |
Missing a Javadoc comment. | 21 | |
Parameter event should be final. | 21 | |
'{' should be on the previous line. | 22 | |
Line is longer than 80 characters. | 24 | |
Method 'contextDestroyed' is not designed for extension - needs to be abstract, final or empty. | 27 | |
Missing a Javadoc comment. | 27 | |
Parameter event should be final. | 27 | |
'{' should be on the previous line. | 28 |
Violation | Message | Line |
---|---|---|
'{' should be on the previous line. | 26 | |
Missing a Javadoc comment. | 27 | |
Missing a Javadoc comment. | 29 | |
Line is longer than 80 characters. | 30 | |
Missing a Javadoc comment. | 30 | |
Line is longer than 80 characters. | 34 | |
Line has trailing spaces. | 36 | |
Line is longer than 80 characters. | 37 | |
Parameter gadgetChecker should be final. | 37 | |
'gadgetChecker' hides a field. | 37 | |
Line is longer than 80 characters. | 42 | |
Method 'doFilter' is not designed for extension - needs to be abstract, final or empty. | 42 | |
Missing a Javadoc comment. | 42 | |
Parameter request should be final. | 42 | |
Parameter response should be final. | 42 | |
Parameter chain should be final. | 42 | |
'{' should be on the previous line. | 44 | |
'{' should be on the previous line. | 50 | |
'{' should be on the previous line. | 59 | |
'}' should be on the same line. | 61 | |
'{' should be on the previous line. | 63 | |
Line is longer than 80 characters. | 65 | |
'{' should be on the previous line. | 72 | |
'}' should be on the same line. | 74 | |
'{' should be on the previous line. | 76 | |
Line is longer than 80 characters. | 78 | |
'+' should be on a new line. | 78 | |
Line has trailing spaces. | 83 | |
Missing a Javadoc comment. | 85 | |
Parameter filterConfig should be final. | 85 | |
'{' is not preceded with whitespace. | 85 | |
'{' is not followed by whitespace. | 85 | |
'}' is not preceded with whitespace. | 85 | |
Missing a Javadoc comment. | 86 | |
'{' is not followed by whitespace. | 86 | |
'}' is not preceded with whitespace. | 86 |
Violation | Message | Line |
---|---|---|
Line is longer than 80 characters. | 6 | |
Missing a Javadoc comment. | 10 | |
'{' should be on the previous line. | 12 | |
Missing a Javadoc comment. | 13 | |
Line is longer than 80 characters. | 14 | |
Parameter contentFetcherFactory should be final. | 14 | |
Parameter contentRewriterRegistry should be final. | 15 | |
'{' should be on the previous line. | 16 | |
Line has trailing spaces. | 18 |