The following document contains the results of Checkstyle.
Files | Infos | Warnings | Errors |
---|---|---|---|
14 | 31 | 43 | 62 |
Rules | Violations | Severity |
---|---|---|
JavadocPackage | 0 | Error |
Translation | 0 | Error |
FileLength | 0 | Error |
FileTabCharacter
|
0 | Error |
RegexpSingleline
|
13 | Warning |
AnnotationUseStyle | 0 | Error |
MissingDeprecated | 0 | Error |
MissingOverride
|
0 | Error |
PackageAnnotation | 0 | Error |
JavadocMethod
|
1 | Error |
JavadocType
|
2 | Error |
JavadocVariable
|
7 | Error |
JavadocStyle
|
5 | Error |
ConstantName | 2 | Error |
LocalFinalVariableName | 0 | Error |
LocalVariableName | 0 | Error |
MemberName | 0 | Error |
MethodName | 0 | Error |
PackageName | 0 | Error |
ParameterName | 0 | Error |
StaticVariableName | 4 | Error |
TypeName | 0 | Error |
AvoidStarImport | 0 | Error |
IllegalImport | 0 | Error |
ImportOrder
|
5 | Error |
RedundantImport | 0 | Error |
UnusedImports | 0 | Error |
LineLength
|
30 | Warning |
MethodLength | 0 | Error |
ParameterNumber | 0 | Error |
EmptyForIteratorPad | 0 | Error |
MethodParamPad | 0 | Error |
NoWhitespaceAfter | 0 | Error |
NoWhitespaceBefore | 0 | Error |
OperatorWrap | 2 | Error |
ParenPad | 0 | Error |
TypecastParenPad | 0 | Error |
WhitespaceAfter | 6 | Error |
WhitespaceAround | 2 | Error |
ModifierOrder | 1 | Error |
RedundantModifier | 0 | Error |
AvoidNestedBlocks | 0 | Error |
EmptyBlock | 0 | Error |
LeftCurly
|
0 | Error |
NeedBraces | 0 | Error |
RightCurly
|
0 | Error |
DeclarationOrder | 6 | Error |
DefaultComesLast | 0 | Error |
DoubleCheckedLocking | 0 | Error |
EmptyStatement | 0 | Error |
EqualsHashCode | 0 | Error |
ExplicitInitialization | 0 | Error |
FallThrough | 0 | Error |
HiddenField
|
4 | Error |
IllegalInstantiation | 0 | Error |
InnerAssignment | 0 | Error |
MagicNumber | 1 | Error |
MissingSwitchDefault | 0 | Error |
ParameterAssignment | 4 | Error |
RedundantThrows
|
0 | Error |
SimplifyBooleanExpression | 0 | Error |
SimplifyBooleanReturn | 0 | Error |
StringLiteralEquality | 0 | Error |
DesignForExtension | 31 | Info |
FinalClass | 0 | Error |
HideUtilityClassConstructor | 1 | Error |
InterfaceIsType | 0 | Error |
VisibilityModifier | 1 | Error |
BooleanExpressionComplexity | 0 | Error |
ClassDataAbstractionCoupling | 0 | Error |
ClassFanOutComplexity
|
4 | Error |
CyclomaticComplexity | 1 | Error |
NPathComplexity
|
2 | Error |
JavaNCSS | 0 | Error |
ArrayTypeStyle | 0 | Error |
Indentation | 1 | Error |
TodoComment | 0 | Error |
UpperEll | 0 | Error |
Violation | Message | Line |
---|---|---|
First sentence should end with a period. | 15 | |
Utility classes should not have a public or default constructor. | 18 | |
Name 'MIME_TYPE' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 20 | |
Name 'URL' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 21 | |
Name 'TYPE' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 22 | |
Name 'SIZE' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 23 | |
First sentence should end with a period. | 25 | |
Cyclomatic Complexity is 16 (max allowed is 10). | 30 | |
NPath Complexity is 32,768 (max allowed is 20). | 30 | |
Line is longer than 120 characters. | 52 | |
Line is longer than 120 characters. | 106 | |
Line is longer than 120 characters. | 123 | |
First sentence should end with a period. | 132 | |
NPath Complexity is 64 (max allowed is 20). | 137 |
Violation | Message | Line |
---|---|---|
Line has trailing spaces. | 22 | |
Method 'voteOn' is not designed for extension - needs to be abstract, final or empty. | 23 | |
Line has trailing spaces. | 38 |
Violation | Message | Line |
---|---|---|
Wrong order for 'java.util.Collections.singleton' import. | 10 | |
Missing a Javadoc comment. | 12 | |
Missing a Javadoc comment. | 14 | |
Missing a Javadoc comment. | 15 | |
Method 'entries' is not designed for extension - needs to be abstract, final or empty. | 24 | |
Method 'contains' is not designed for extension - needs to be abstract, final or empty. | 29 |
Violation | Message | Line |
---|---|---|
Method 'newExternalGadgetSpecId' is not designed for extension - needs to be abstract, final or empty. | 30 |
Violation | Message | Line |
---|---|---|
Method 'createGadgetState' is not designed for extension - needs to be abstract, final or empty. | 56 | |
Missing a Javadoc comment. | 65 |
Violation | Message | Line |
---|---|---|
Method 'get' is not designed for extension - needs to be abstract, final or empty. | 24 | |
Method 'put' is not designed for extension - needs to be abstract, final or empty. | 29 | |
Method 'remove' is not designed for extension - needs to be abstract, final or empty. | 34 |
Violation | Message | Line |
---|---|---|
Method 'isReadableBy' is not designed for extension - needs to be abstract, final or empty. | 36 | |
Method 'isWritableBy' is not designed for extension - needs to be abstract, final or empty. | 48 | |
'if' is not followed by whitespace. | 53 | |
'4' is a magic number. | 57 | |
Line is longer than 120 characters. | 64 | |
Method 'canConfigureDirectory' is not designed for extension - needs to be abstract, final or empty. | 68 |
Violation | Message | Line |
---|---|---|
Line is longer than 120 characters. | 25 | |
Line has trailing spaces. | 28 | |
Class Fan-Out Complexity is 15 (max allowed is 10). | 31 | |
Missing a Javadoc comment. | 33 | |
Missing a Javadoc comment. | 34 | |
Missing a Javadoc comment. | 35 | |
Line has trailing spaces. | 42 | |
if child at indentation level 16 not at correct indentation, 12 | 46 | |
'cast' is not followed by whitespace. | 46 | |
Line is longer than 120 characters. | 52 | |
Line is longer than 120 characters. | 63 | |
Method 'getActivities' is not designed for extension - needs to be abstract, final or empty. | 63 | |
Line is longer than 120 characters. | 85 | |
Method 'getActivities' is not designed for extension - needs to be abstract, final or empty. | 85 | |
Line is longer than 120 characters. | 99 | |
Method 'getActivity' is not designed for extension - needs to be abstract, final or empty. | 99 | |
'activityId' hides a field. | 99 | |
Line is longer than 120 characters. | 105 | |
Method 'deleteActivities' is not designed for extension - needs to be abstract, final or empty. | 105 | |
'activityId' hides a field. | 119 | |
Line is longer than 120 characters. | 133 | |
Method 'createActivity' is not designed for extension - needs to be abstract, final or empty. | 133 | |
Line is longer than 120 characters. | 142 | |
Line has trailing spaces. | 171 | |
'activityId' hides a field. | 175 | |
'cast' is not followed by whitespace. | 193 | |
Line is longer than 120 characters. | 198 | |
Line is longer than 120 characters. | 209 | |
'activityId' hides a field. | 219 | |
Line is longer than 120 characters. | 237 |
Violation | Message | Line |
---|---|---|
First sentence should end with a period. | 23 | |
Line is longer than 120 characters. | 24 | |
Class Fan-Out Complexity is 11 (max allowed is 10). | 26 | |
Static variable definition in wrong order. | 29 | |
Line is longer than 120 characters. | 36 | |
Method 'getPeopleData' is not designed for extension - needs to be abstract, final or empty. | 36 | |
'if' is not followed by whitespace. | 50 | |
Assignment of parameter 'fields' is not allowed. | 52 | |
Line has trailing spaces. | 56 | |
'cast' is not followed by whitespace. | 60 | |
Line is longer than 120 characters. | 71 | |
Method 'getPeopleData' is not designed for extension - needs to be abstract, final or empty. | 71 | |
Line is longer than 120 characters. | 76 | |
Method 'deletePersonData' is not designed for extension - needs to be abstract, final or empty. | 76 | |
Assignment of parameter 'fields' is not allowed. | 90 | |
Line is longer than 120 characters. | 103 | |
Method 'deletePersonData' is not designed for extension - needs to be abstract, final or empty. | 103 | |
Line is longer than 120 characters. | 108 | |
Method 'updatePersonData' is not designed for extension - needs to be abstract, final or empty. | 108 | |
Line has trailing spaces. | 133 | |
Line is longer than 120 characters. | 139 | |
Line is longer than 120 characters. | 144 | |
Line is longer than 120 characters. | 149 | |
Line is longer than 120 characters. | 154 | |
'cast' is not followed by whitespace. | 155 | |
Line is longer than 120 characters. | 168 |
Violation | Message | Line |
---|---|---|
'com.google.common.base.Preconditions.checkNotNull' should be separated from previous imports. | 23 | |
'org.apache.commons.lang.StringUtils.isBlank' should be separated from previous imports. | 26 | |
Missing a Javadoc comment. | 29 | |
Class Fan-Out Complexity is 19 (max allowed is 10). | 29 | |
Static variable definition in wrong order. | 33 | |
Static variable definition in wrong order. | 35 | |
Method 'retrieve' is not designed for extension - needs to be abstract, final or empty. | 42 | |
Line is longer than 120 characters. | 56 | |
'cast' is not followed by whitespace. | 68 | |
'+' should be on a new line. | 85 | |
Line is longer than 120 characters. | 86 | |
'+' should be on a new line. | 86 | |
Method 'findDashboardWithGadget' is not designed for extension - needs to be abstract, final or empty. | 102 | |
Line is longer than 120 characters. | 110 | |
Method 'update' is not designed for extension - needs to be abstract, final or empty. | 110 | |
'cast' is not followed by whitespace. | 117 | |
Method 'remove' is not designed for extension - needs to be abstract, final or empty. | 136 | |
Line has trailing spaces. | 179 | |
Line has trailing spaces. | 190 | |
Line has trailing spaces. | 194 | |
Line has trailing spaces. | 206 | |
Line has trailing spaces. | 219 | |
Line has trailing spaces. | 225 |
Violation | Message | Line |
---|---|---|
Wrong order for 'com.google.common.base.Preconditions.checkNotNull' import. | 19 | |
Wrong order for 'java.util.Collections.singleton' import. | 23 | |
Class Fan-Out Complexity is 13 (max allowed is 10). | 28 | |
Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 30 | |
Missing a Javadoc comment. | 31 | |
Variable access definition in wrong order. | 31 | |
Method 'entries' is not designed for extension - needs to be abstract, final or empty. | 49 | |
Method 'add' is not designed for extension - needs to be abstract, final or empty. | 90 | |
Assignment of parameter 'gadgetSpecUri' is not allowed. | 93 | |
Method 'remove' is not designed for extension - needs to be abstract, final or empty. | 117 | |
Method 'contains' is not designed for extension - needs to be abstract, final or empty. | 157 | |
Assignment of parameter 'gadgetSpecUri' is not allowed. | 160 | |
'abstract' modifier out of order with the JLS suggestions. | 241 | |
Name 'length' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 243 | |
Instance variable definition in wrong order. | 276 | |
Constructor definition in wrong order. | 278 |
Violation | Message | Line |
---|---|---|
First sentence should end with a period. | 15 | |
Missing a Javadoc comment. | 20 | |
Variable 'userManager' must be private and have accessor methods. | 20 | |
Method 'getPerson' is not designed for extension - needs to be abstract, final or empty. | 27 | |
Line is longer than 120 characters. | 40 | |
Method 'getPeople' is not designed for extension - needs to be abstract, final or empty. | 40 |