Checkstyle Results

The following document contains the results of Checkstylerss feed

Summary

Files Infos Infos Warnings Warnings Errors Errors
14 29 39 90

Rules

Rules Violations Severity
JavadocPackage 0 Errors Error
Translation 0 Errors Error
FileLength 0 Errors Error
FileTabCharacter
  • eachLine: "true"
0 Errors Error
RegexpSingleline
  • message: "Line has trailing spaces."
  • format: "\s+$"
12 Warnings Warning
AnnotationUseStyle 0 Errors Error
MissingDeprecated 0 Errors Error
MissingOverride
  • javaFiveCompatibility: "true"
0 Errors Error
PackageAnnotation 0 Errors Error
JavadocMethod
  • excludeScope: "private"
  • scope: "anoninner"
1 Errors Error
JavadocType
  • scope: "package"
2 Errors Error
JavadocVariable
  • scope: "package"
7 Errors Error
JavadocStyle
  • scope: "package"
5 Errors Error
ConstantName 2 Errors Error
LocalFinalVariableName 0 Errors Error
LocalVariableName 0 Errors Error
MemberName 0 Errors Error
MethodName 0 Errors Error
PackageName 0 Errors Error
ParameterName 0 Errors Error
StaticVariableName 0 Errors Error
TypeName 0 Errors Error
AvoidStarImport 0 Errors Error
IllegalImport 0 Errors Error
ImportOrder
  • separated: "true"
  • groups: "java,javax,com.atlassian,com,org"
33 Errors Error
RedundantImport 0 Errors Error
UnusedImports 0 Errors Error
LineLength
  • max: "120"
27 Warnings Warning
MethodLength 0 Errors Error
ParameterNumber 0 Errors Error
EmptyForIteratorPad 0 Errors Error
MethodParamPad 0 Errors Error
NoWhitespaceAfter 0 Errors Error
NoWhitespaceBefore 0 Errors Error
OperatorWrap 2 Errors Error
ParenPad 0 Errors Error
TypecastParenPad 0 Errors Error
WhitespaceAfter 7 Errors Error
WhitespaceAround 2 Errors Error
ModifierOrder 1 Errors Error
RedundantModifier 0 Errors Error
AvoidNestedBlocks 0 Errors Error
EmptyBlock 0 Errors Error
LeftCurly
  • option: "nl"
0 Errors Error
NeedBraces 0 Errors Error
RightCurly
  • option: "alone"
0 Errors Error
DeclarationOrder 8 Errors Error
DefaultComesLast 0 Errors Error
DoubleCheckedLocking 0 Errors Error
EmptyStatement 0 Errors Error
EqualsHashCode 0 Errors Error
ExplicitInitialization 0 Errors Error
FallThrough 0 Errors Error
HiddenField
  • ignoreConstructorParameter: "true"
  • ignoreSetter: "true"
4 Errors Error
IllegalInstantiation 0 Errors Error
InnerAssignment 0 Errors Error
MagicNumber 1 Errors Error
MissingSwitchDefault 0 Errors Error
ParameterAssignment 4 Errors Error
RedundantThrows
  • allowUnchecked: "true"
0 Errors Error
SimplifyBooleanExpression 0 Errors Error
SimplifyBooleanReturn 0 Errors Error
StringLiteralEquality 0 Errors Error
DesignForExtension 29 Infos Info
FinalClass 0 Errors Error
HideUtilityClassConstructor 1 Errors Error
InterfaceIsType 0 Errors Error
VisibilityModifier 1 Errors Error
BooleanExpressionComplexity 0 Errors Error
ClassDataAbstractionCoupling 0 Errors Error
ClassFanOutComplexity
  • max: "10"
4 Errors Error
CyclomaticComplexity 2 Errors Error
NPathComplexity
  • max: "20"
2 Errors Error
JavaNCSS 0 Errors Error
ArrayTypeStyle 0 Errors Error
Indentation 1 Errors Error
TodoComment 0 Errors Error
UpperEll 0 Errors Error

Details

com/atlassian/gadgets/refimpl/ActivityPropertyAdapter.java

Violation Message Line
Errors Wrong order for 'java.util.Properties' import. 8
Errors Wrong order for 'java.util.Date' import. 10
Errors First sentence should end with a period. 12
Errors Utility classes should not have a public or default constructor. 15
Errors First sentence should end with a period. 17
Errors Cyclomatic Complexity is 15 (max allowed is 10). 22
Errors NPath Complexity is 16,384 (max allowed is 20). 22
Warnings Line is longer than 120 characters. 44
Errors First sentence should end with a period. 85
Errors Cyclomatic Complexity is 35 (max allowed is 10). 91
Errors NPath Complexity is 186,624 (max allowed is 20). 91

com/atlassian/gadgets/refimpl/AllowAdminOnlyPluginGadgetSpecProviderPermissionImpl.java

Violation Message Line
Errors Wrong order for 'com.atlassian.gadgets.Vote' import. 5
Warnings Line has trailing spaces. 22
Infos Method 'voteOn' is not designed for extension - needs to be abstract, final or empty. 23
Warnings Line has trailing spaces. 38

com/atlassian/gadgets/refimpl/ApplicationGadgetSpecProviderImpl.java

Violation Message Line
Errors Wrong order for 'com.atlassian.plugin.webresource.UrlMode' import. 8
Errors Missing a Javadoc comment. 12
Errors Missing a Javadoc comment. 14
Errors Missing a Javadoc comment. 15
Infos Method 'entries' is not designed for extension - needs to be abstract, final or empty. 24
Infos Method 'contains' is not designed for extension - needs to be abstract, final or empty. 29

com/atlassian/gadgets/refimpl/ExternalGadgetSpecIdGeneratorImpl.java

Violation Message Line
Infos Method 'newExternalGadgetSpecId' is not designed for extension - needs to be abstract, final or empty. 30

com/atlassian/gadgets/refimpl/GadgetStateFactoryImpl.java

Violation Message Line
Errors Wrong order for 'java.net.URI' import. 5
Infos Method 'createGadgetState' is not designed for extension - needs to be abstract, final or empty. 56
Errors Missing a Javadoc comment. 65

com/atlassian/gadgets/refimpl/NamespacedPluginSettings.java

Violation Message Line
Infos Method 'get' is not designed for extension - needs to be abstract, final or empty. 24
Infos Method 'put' is not designed for extension - needs to be abstract, final or empty. 29
Infos Method 'remove' is not designed for extension - needs to be abstract, final or empty. 34

com/atlassian/gadgets/refimpl/PermissionServiceImpl.java

Violation Message Line
Infos Method 'isReadableBy' is not designed for extension - needs to be abstract, final or empty. 36
Infos Method 'isWritableBy' is not designed for extension - needs to be abstract, final or empty. 48
Errors 'if' is not followed by whitespace. 53
Errors '4' is a magic number. 57
Warnings Line is longer than 120 characters. 64
Infos Method 'canConfigureDirectory' is not designed for extension - needs to be abstract, final or empty. 68

com/atlassian/gadgets/refimpl/PluginSettingsActivityService.java

Violation Message Line
Errors Wrong order for 'com.atlassian.gadgets.opensocial.spi.model.ActivityId' import. 6
Errors Wrong order for 'com.atlassian.gadgets.opensocial.spi.ActivityServiceException' import. 7
Errors Wrong order for 'com.atlassian.gadgets.opensocial.OpenSocialRequestContext' import. 9
Errors Wrong order for 'com.atlassian.sal.api.pluginsettings.PluginSettings' import. 12
Errors Wrong order for 'java.util.List' import. 15
Errors Wrong order for 'java.util.ArrayList' import. 17
Errors Wrong order for 'java.util.Iterator' import. 19
Errors Wrong order for 'java.util.Collections' import. 20
Warnings Line is longer than 120 characters. 24
Warnings Line has trailing spaces. 27
Errors Class Fan-Out Complexity is 15 (max allowed is 10). 30
Errors Missing a Javadoc comment. 32
Errors Missing a Javadoc comment. 33
Errors Missing a Javadoc comment. 34
Warnings Line has trailing spaces. 41
Errors if child at indentation level 16 not at correct indentation, 12 45
Errors 'cast' is not followed by whitespace. 45
Warnings Line is longer than 120 characters. 51
Warnings Line is longer than 120 characters. 62
Infos Method 'getActivities' is not designed for extension - needs to be abstract, final or empty. 62
Warnings Line is longer than 120 characters. 84
Infos Method 'getActivities' is not designed for extension - needs to be abstract, final or empty. 84
Warnings Line is longer than 120 characters. 98
Infos Method 'getActivity' is not designed for extension - needs to be abstract, final or empty. 98
Errors 'activityId' hides a field. 98
Warnings Line is longer than 120 characters. 100
Warnings Line is longer than 120 characters. 104
Infos Method 'deleteActivities' is not designed for extension - needs to be abstract, final or empty. 104
Errors 'activityId' hides a field. 118
Warnings Line is longer than 120 characters. 132
Infos Method 'createActivity' is not designed for extension - needs to be abstract, final or empty. 132
Warnings Line is longer than 120 characters. 141
Warnings Line has trailing spaces. 170
Warnings Line is longer than 120 characters. 171
Errors 'activityId' hides a field. 174
Errors 'cast' is not followed by whitespace. 192
Warnings Line is longer than 120 characters. 197
Errors 'cast' is not followed by whitespace. 200
Warnings Line is longer than 120 characters. 208
Errors 'activityId' hides a field. 218
Warnings Line is longer than 120 characters. 236

com/atlassian/gadgets/refimpl/PluginSettingsAppDataService.java

Violation Message Line
Errors Wrong order for 'com.atlassian.gadgets.opensocial.spi.AppDataServiceException' import. 5
Errors Wrong order for 'com.atlassian.gadgets.opensocial.OpenSocialRequestContext' import. 7
Errors Wrong order for 'com.atlassian.sal.api.pluginsettings.PluginSettings' import. 9
Errors 'com.google.common.collect.Sets.newHashSet' should be separated from previous imports. 10
Errors Wrong order for 'com.google.common.collect.ImmutableSet.copyOf' import. 11
Errors Wrong order for 'com.google.common.base.Joiner.on' import. 12
Errors Wrong order for 'java.util.HashMap' import. 15
Errors Wrong order for 'java.util.Collections' import. 18
Errors First sentence should end with a period. 20
Warnings Line is longer than 120 characters. 21
Errors Class Fan-Out Complexity is 11 (max allowed is 10). 23
Errors Static variable definition in wrong order. 26
Errors Static variable definition in wrong order. 27
Errors Static variable definition in wrong order. 28
Warnings Line is longer than 120 characters. 35
Infos Method 'getPeopleData' is not designed for extension - needs to be abstract, final or empty. 35
Errors 'if' is not followed by whitespace. 49
Errors Assignment of parameter 'fields' is not allowed. 51
Warnings Line has trailing spaces. 55
Errors 'cast' is not followed by whitespace. 59
Warnings Line is longer than 120 characters. 70
Infos Method 'deletePersonData' is not designed for extension - needs to be abstract, final or empty. 70
Errors Assignment of parameter 'fields' is not allowed. 84
Warnings Line is longer than 120 characters. 97
Infos Method 'updatePersonData' is not designed for extension - needs to be abstract, final or empty. 97
Warnings Line is longer than 120 characters. 136
Warnings Line is longer than 120 characters. 141
Errors 'cast' is not followed by whitespace. 142
Warnings Line is longer than 120 characters. 155

com/atlassian/gadgets/refimpl/PluginSettingsDashboardStateStore.java

Violation Message Line
Errors 'com.google.common.base.Preconditions.checkNotNull' should be separated from previous imports. 5
Errors 'org.apache.commons.lang.StringUtils.isBlank' should be separated from previous imports. 8
Errors Wrong order for 'java.net.URISyntaxException' import. 11
Errors Wrong order for 'com.atlassian.gadgets.dashboard.DashboardState.ColumnIndex' import. 22
Errors Missing a Javadoc comment. 29
Errors Class Fan-Out Complexity is 19 (max allowed is 10). 29
Errors Static variable definition in wrong order. 33
Errors Static variable definition in wrong order. 35
Infos Method 'retrieve' is not designed for extension - needs to be abstract, final or empty. 42
Warnings Line is longer than 120 characters. 56
Errors 'cast' is not followed by whitespace. 68
Errors '+' should be on a new line. 85
Warnings Line is longer than 120 characters. 86
Errors '+' should be on a new line. 86
Infos Method 'findDashboardWithGadget' is not designed for extension - needs to be abstract, final or empty. 102
Warnings Line is longer than 120 characters. 110
Infos Method 'update' is not designed for extension - needs to be abstract, final or empty. 110
Errors 'cast' is not followed by whitespace. 117
Infos Method 'remove' is not designed for extension - needs to be abstract, final or empty. 136
Warnings Line has trailing spaces. 179
Warnings Line has trailing spaces. 190
Warnings Line has trailing spaces. 194
Warnings Line has trailing spaces. 206
Warnings Line has trailing spaces. 219
Warnings Line has trailing spaces. 225

com/atlassian/gadgets/refimpl/PluginSettingsExternalGadgetSpecStore.java

Violation Message Line
Errors Wrong order for 'java.util.Collections.singleton' import. 7
Errors Wrong order for 'java.net.URI' import. 9
Errors Wrong order for 'com.atlassian.gadgets.directory.spi.ExternalGadgetSpec' import. 18
Errors Class Fan-Out Complexity is 13 (max allowed is 10). 28
Errors Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 30
Errors Missing a Javadoc comment. 31
Errors Variable access definition in wrong order. 31
Infos Method 'entries' is not designed for extension - needs to be abstract, final or empty. 49
Infos Method 'add' is not designed for extension - needs to be abstract, final or empty. 90
Errors Assignment of parameter 'gadgetSpecUri' is not allowed. 93
Infos Method 'remove' is not designed for extension - needs to be abstract, final or empty. 117
Infos Method 'contains' is not designed for extension - needs to be abstract, final or empty. 157
Errors Assignment of parameter 'gadgetSpecUri' is not allowed. 160
Errors 'abstract' modifier out of order with the JLS suggestions. 241
Errors Name 'length' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 243
Errors Instance variable definition in wrong order. 276
Errors Constructor definition in wrong order. 278

com/atlassian/gadgets/refimpl/UserManagerPersonService.java

Violation Message Line
Errors Wrong order for 'com.atlassian.gadgets.opensocial.spi.PersonServiceException' import. 6
Errors Wrong order for 'com.atlassian.gadgets.opensocial.OpenSocialRequestContext' import. 7
Errors Wrong order for 'com.atlassian.gadgets.opensocial.Group' import. 8
Errors Wrong order for 'java.security.Principal' import. 11
Errors Wrong order for 'java.util.HashSet' import. 13
Errors First sentence should end with a period. 15
Errors Missing a Javadoc comment. 20
Errors Variable 'userManager' must be private and have accessor methods. 20
Warnings Line is longer than 120 characters. 27
Infos Method 'getPerson' is not designed for extension - needs to be abstract, final or empty. 27
Warnings Line is longer than 120 characters. 41
Infos Method 'getPeople' is not designed for extension - needs to be abstract, final or empty. 41