Checkstyle Results

The following document contains the results of Checkstyle. rss feed

Summary

Files Infos Infos Warnings Warnings Errors Errors
9 16 12 36

Files

Files I Infos W Warnings E Errors
com/atlassian/gadgets/refimpl/AllowAdminOnlyPluginGadgetSpecProviderPermissionImpl.java 1 2 1
com/atlassian/gadgets/refimpl/ApplicationGadgetSpecProviderImpl.java 2 0 4
com/atlassian/gadgets/refimpl/ExternalGadgetSpecIdGeneratorImpl.java 1 0 0
com/atlassian/gadgets/refimpl/GadgetStateFactoryImpl.java 1 0 3
com/atlassian/gadgets/refimpl/PermissionServiceImpl.java 3 1 2
com/atlassian/gadgets/refimpl/PluginSettingsDashboardStateStore.java 4 9 11
com/atlassian/gadgets/refimpl/PluginSettingsExternalGadgetSpecStore.java 4 0 15

Rules

Rules Violations Severity
JavadocPackage 0 Errors Error
Translation 0 Errors Error
FileLength 0 Errors Error
FileTabCharacter
  • eachLine: "true"
 0 Errors Error
RegexpSingleline
  • message: "Line has trailing spaces."
  • format: "\s+$"
 8 Warnings Warning
AnnotationUseStyle 0 Errors Error
MissingDeprecated 0 Errors Error
MissingOverride
  • javaFiveCompatibility: "true"
 0 Errors Error
PackageAnnotation 0 Errors Error
JavadocMethod
  • excludeScope: "private"
  • scope: "anoninner"
 4 Errors Error
JavadocType
  • scope: "package"
 2 Errors Error
JavadocVariable
  • scope: "package"
 3 Errors Error
JavadocStyle
  • scope: "package"
 0 Errors Error
ConstantName 2 Errors Error
LocalFinalVariableName 0 Errors Error
LocalVariableName 0 Errors Error
MemberName 0 Errors Error
MethodName 0 Errors Error
PackageName 0 Errors Error
ParameterName 0 Errors Error
StaticVariableName 0 Errors Error
TypeName 0 Errors Error
AvoidStarImport 0 Errors Error
IllegalImport 0 Errors Error
ImportOrder
  • separated: "true"
  • groups: "java,javax,com.atlassian,com,org"
 9 Errors Error
RedundantImport 0 Errors Error
UnusedImports 0 Errors Error
LineLength
  • max: "120"
 4 Warnings Warning
MethodLength 0 Errors Error
ParameterNumber 0 Errors Error
EmptyForIteratorPad 0 Errors Error
MethodParamPad 0 Errors Error
NoWhitespaceAfter 0 Errors Error
NoWhitespaceBefore 0 Errors Error
OperatorWrap 2 Errors Error
ParenPad 0 Errors Error
TypecastParenPad 0 Errors Error
WhitespaceAfter 2 Errors Error
WhitespaceAround 1 Errors Error
ModifierOrder 1 Errors Error
RedundantModifier 0 Errors Error
AvoidNestedBlocks 0 Errors Error
EmptyBlock 0 Errors Error
LeftCurly
  • option: "nl"
 0 Errors Error
NeedBraces 0 Errors Error
RightCurly
  • option: "alone"
 0 Errors Error
DeclarationOrder 5 Errors Error
DefaultComesLast 0 Errors Error
DoubleCheckedLocking 0 Errors Error
EmptyStatement 0 Errors Error
EqualsHashCode 0 Errors Error
ExplicitInitialization 0 Errors Error
FallThrough 0 Errors Error
HiddenField
  • ignoreConstructorParameter: "true"
  • ignoreSetter: "true"
 0 Errors Error
IllegalInstantiation 0 Errors Error
InnerAssignment 0 Errors Error
MagicNumber 1 Errors Error
MissingSwitchDefault 0 Errors Error
ParameterAssignment 2 Errors Error
RedundantThrows
  • allowUnchecked: "true"
 0 Errors Error
SimplifyBooleanExpression 0 Errors Error
SimplifyBooleanReturn 0 Errors Error
StringLiteralEquality 0 Errors Error
DesignForExtension 16 Infos Info
FinalClass 0 Errors Error
HideUtilityClassConstructor 0 Errors Error
InterfaceIsType 0 Errors Error
VisibilityModifier 0 Errors Error
BooleanExpressionComplexity 0 Errors Error
ClassDataAbstractionCoupling 0 Errors Error
ClassFanOutComplexity
  • max: "10"
 2 Errors Error
CyclomaticComplexity 0 Errors Error
NPathComplexity
  • max: "20"
 0 Errors Error
JavaNCSS 0 Errors Error
ArrayTypeStyle 0 Errors Error
Indentation 0 Errors Error
TodoComment 0 Errors Error
UpperEll 0 Errors Error

Details

com/atlassian/gadgets/refimpl/AllowAdminOnlyPluginGadgetSpecProviderPermissionImpl.java

Violation Message Line
Errors Wrong order for 'com.atlassian.gadgets.plugins.PluginGadgetSpec' import. 5
Warnings Line has trailing spaces. 22
Infos Method 'voteOn' is not designed for extension - needs to be abstract, final or empty. 23
Warnings Line has trailing spaces. 38

com/atlassian/gadgets/refimpl/ApplicationGadgetSpecProviderImpl.java

Violation Message Line
Errors Wrong order for 'com.atlassian.plugin.webresource.UrlMode' import. 8
Errors Missing a Javadoc comment. 12
Errors Missing a Javadoc comment. 14
Errors Missing a Javadoc comment. 15
Infos Method 'entries' is not designed for extension - needs to be abstract, final or empty. 24
Infos Method 'contains' is not designed for extension - needs to be abstract, final or empty. 29

com/atlassian/gadgets/refimpl/ExternalGadgetSpecIdGeneratorImpl.java

Violation Message Line
Infos Method 'newExternalGadgetSpecId' is not designed for extension - needs to be abstract, final or empty. 30

com/atlassian/gadgets/refimpl/GadgetStateFactoryImpl.java

Violation Message Line
Errors Wrong order for 'com.atlassian.gadgets.spi.GadgetStateFactory' import. 8
Errors Wrong order for 'com.atlassian.sal.api.transaction.TransactionCallback' import. 12
Infos Method 'createGadgetState' is not designed for extension - needs to be abstract, final or empty. 55
Errors Missing a Javadoc comment. 64

com/atlassian/gadgets/refimpl/PermissionServiceImpl.java

Violation Message Line
Infos Method 'isReadableBy' is not designed for extension - needs to be abstract, final or empty. 35
Infos Method 'isWritableBy' is not designed for extension - needs to be abstract, final or empty. 47
Errors 'if' is not followed by whitespace. 52
Errors '4' is a magic number. 56
Warnings Line is longer than 120 characters. 63
Infos Method 'canConfigureDirectory' is not designed for extension - needs to be abstract, final or empty. 67

com/atlassian/gadgets/refimpl/PluginSettingsDashboardStateStore.java

Violation Message Line
Errors Wrong order for 'com.atlassian.gadgets.dashboard.DashboardState.ColumnIndex' import. 10
Errors Wrong order for 'com.atlassian.gadgets.dashboard.Color' import. 12
Errors 'org.apache.commons.lang.StringUtils.isBlank' should be separated from previous imports. 26
Errors Missing a Javadoc comment. 29
Errors Class Fan-Out Complexity is 19 (max allowed is 10). 29
Errors Static variable definition in wrong order. 33
Errors Static variable definition in wrong order. 35
Infos Method 'retrieve' is not designed for extension - needs to be abstract, final or empty. 42
Warnings Line is longer than 120 characters. 56
Errors 'cast' is not followed by whitespace. 68
Errors '+' should be on a new line. 85
Warnings Line is longer than 120 characters. 86
Errors '+' should be on a new line. 86
Infos Method 'findDashboardWithGadget' is not designed for extension - needs to be abstract, final or empty. 102
Warnings Line is longer than 120 characters. 110
Infos Method 'update' is not designed for extension - needs to be abstract, final or empty. 110
Errors 'cast' is not followed by whitespace. 117
Infos Method 'remove' is not designed for extension - needs to be abstract, final or empty. 136
Warnings Line has trailing spaces. 179
Warnings Line has trailing spaces. 190
Warnings Line has trailing spaces. 194
Warnings Line has trailing spaces. 206
Warnings Line has trailing spaces. 219
Warnings Line has trailing spaces. 225

com/atlassian/gadgets/refimpl/PluginSettingsExternalGadgetSpecStore.java

Violation Message Line
Errors Wrong order for 'java.util.Set' import. 6
Errors 'org.apache.commons.logging.Log' should be separated from previous imports. 21
Errors Class Fan-Out Complexity is 13 (max allowed is 10). 27
Errors Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 29
Errors Missing a Javadoc comment. 30
Errors Variable access definition in wrong order. 30
Infos Method 'entries' is not designed for extension - needs to be abstract, final or empty. 48
Infos Method 'add' is not designed for extension - needs to be abstract, final or empty. 89
Errors Assignment of parameter 'gadgetSpecUri' is not allowed. 92
Infos Method 'remove' is not designed for extension - needs to be abstract, final or empty. 116
Infos Method 'contains' is not designed for extension - needs to be abstract, final or empty. 156
Errors Assignment of parameter 'gadgetSpecUri' is not allowed. 159
Errors 'abstract' modifier out of order with the JLS suggestions. 240
Errors Name 'length' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 242
Errors Missing a Javadoc comment. 244
Errors Missing a Javadoc comment. 254
Errors Missing a Javadoc comment. 265
Errors Instance variable definition in wrong order. 272
Errors Constructor definition in wrong order. 274