The following document contains the results of Checkstyle.
Files | Infos | Warnings | Errors |
---|---|---|---|
15 | 32 | 28 | 82 |
Rules | Violations | Severity |
---|---|---|
JavadocPackage | 0 | Error |
Translation | 0 | Error |
FileLength | 0 | Error |
FileTabCharacter
|
0 | Error |
RegexpSingleline
|
12 | Warning |
AnnotationUseStyle | 0 | Error |
MissingDeprecated | 0 | Error |
MissingOverride
|
0 | Error |
PackageAnnotation | 0 | Error |
JavadocMethod
|
1 | Error |
JavadocType
|
4 | Error |
JavadocVariable
|
7 | Error |
JavadocStyle
|
3 | Error |
ConstantName | 2 | Error |
LocalFinalVariableName | 0 | Error |
LocalVariableName | 0 | Error |
MemberName | 0 | Error |
MethodName | 0 | Error |
PackageName | 0 | Error |
ParameterName | 0 | Error |
StaticVariableName | 0 | Error |
TypeName | 0 | Error |
AvoidStarImport | 0 | Error |
IllegalImport | 0 | Error |
ImportOrder
|
28 | Error |
RedundantImport | 0 | Error |
UnusedImports | 2 | Error |
LineLength
|
16 | Warning |
MethodLength | 0 | Error |
ParameterNumber | 0 | Error |
EmptyForIteratorPad | 0 | Error |
MethodParamPad | 0 | Error |
NoWhitespaceAfter | 0 | Error |
NoWhitespaceBefore | 0 | Error |
OperatorWrap | 2 | Error |
ParenPad | 0 | Error |
TypecastParenPad | 0 | Error |
WhitespaceAfter | 7 | Error |
WhitespaceAround | 1 | Error |
ModifierOrder | 1 | Error |
RedundantModifier | 0 | Error |
AvoidNestedBlocks | 0 | Error |
EmptyBlock | 0 | Error |
LeftCurly
|
0 | Error |
NeedBraces | 2 | Error |
RightCurly
|
0 | Error |
DeclarationOrder | 10 | Error |
DefaultComesLast | 0 | Error |
DoubleCheckedLocking | 0 | Error |
EmptyStatement | 0 | Error |
EqualsHashCode | 0 | Error |
ExplicitInitialization | 0 | Error |
FallThrough | 0 | Error |
HiddenField
|
4 | Error |
IllegalInstantiation | 0 | Error |
InnerAssignment | 0 | Error |
MagicNumber | 1 | Error |
MissingSwitchDefault | 0 | Error |
ParameterAssignment | 2 | Error |
RedundantThrows
|
0 | Error |
SimplifyBooleanExpression | 0 | Error |
SimplifyBooleanReturn | 0 | Error |
StringLiteralEquality | 0 | Error |
DesignForExtension | 32 | Info |
FinalClass | 0 | Error |
HideUtilityClassConstructor | 0 | Error |
InterfaceIsType | 0 | Error |
VisibilityModifier | 1 | Error |
BooleanExpressionComplexity | 0 | Error |
ClassDataAbstractionCoupling | 0 | Error |
ClassFanOutComplexity
|
3 | Error |
CyclomaticComplexity | 0 | Error |
NPathComplexity
|
0 | Error |
JavaNCSS | 0 | Error |
ArrayTypeStyle | 0 | Error |
Indentation | 1 | Error |
TodoComment | 0 | Error |
UpperEll | 0 | Error |
Violation | Message | Line |
---|---|---|
Wrong order for 'com.atlassian.gadgets.Vote' import. | 5 | |
Line has trailing spaces. | 22 | |
Method 'voteOn' is not designed for extension - needs to be abstract, final or empty. | 23 | |
Line has trailing spaces. | 38 |
Violation | Message | Line |
---|---|---|
Wrong order for 'com.atlassian.plugin.webresource.UrlMode' import. | 8 | |
Missing a Javadoc comment. | 12 | |
Missing a Javadoc comment. | 14 | |
Missing a Javadoc comment. | 15 | |
Method 'entries' is not designed for extension - needs to be abstract, final or empty. | 24 | |
Method 'contains' is not designed for extension - needs to be abstract, final or empty. | 29 |
Violation | Message | Line |
---|---|---|
Method 'newExternalGadgetSpecId' is not designed for extension - needs to be abstract, final or empty. | 30 |
Violation | Message | Line |
---|---|---|
Wrong order for 'java.net.URI' import. | 5 | |
Method 'createGadgetState' is not designed for extension - needs to be abstract, final or empty. | 56 | |
Missing a Javadoc comment. | 65 |
Violation | Message | Line |
---|---|---|
Missing a Javadoc comment. | 3 |
Violation | Message | Line |
---|---|---|
Method 'get' is not designed for extension - needs to be abstract, final or empty. | 24 | |
Method 'put' is not designed for extension - needs to be abstract, final or empty. | 29 | |
Method 'remove' is not designed for extension - needs to be abstract, final or empty. | 34 |
Violation | Message | Line |
---|---|---|
Method 'isReadableBy' is not designed for extension - needs to be abstract, final or empty. | 36 | |
Method 'isWritableBy' is not designed for extension - needs to be abstract, final or empty. | 48 | |
'if' is not followed by whitespace. | 53 | |
'4' is a magic number. | 57 | |
Line is longer than 120 characters. | 64 | |
Method 'canConfigureDirectory' is not designed for extension - needs to be abstract, final or empty. | 68 |
Violation | Message | Line |
---|---|---|
Wrong order for 'java.security.Principal' import. | 5 | |
Missing a Javadoc comment. | 9 | |
Method 'getUserName' is not designed for extension - needs to be abstract, final or empty. | 18 | |
Method 'equals' is not designed for extension - needs to be abstract, final or empty. | 23 | |
'if' construct must use '{}'s. | 25 | |
'if' construct must use '{}'s. | 26 | |
Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. | 32 |
Violation | Message | Line |
---|---|---|
Wrong order for 'com.atlassian.gadgets.opensocial.spi.Activity' import. | 4 | |
Wrong order for 'com.atlassian.gadgets.opensocial.spi.ActivityId' import. | 6 | |
Wrong order for 'com.atlassian.gadgets.opensocial.SecurityToken' import. | 7 | |
Wrong order for 'java.util.List' import. | 11 | |
Wrong order for 'java.util.ArrayList' import. | 13 | |
Wrong order for 'java.util.HashSet' import. | 15 | |
First sentence should end with a period. | 19 | |
Line is longer than 120 characters. | 20 | |
Class Fan-Out Complexity is 15 (max allowed is 10). | 22 | |
Missing a Javadoc comment. | 24 | |
Missing a Javadoc comment. | 25 | |
Missing a Javadoc comment. | 26 | |
Static variable definition in wrong order. | 30 | |
Static variable definition in wrong order. | 31 | |
Static variable definition in wrong order. | 32 | |
Static variable definition in wrong order. | 33 | |
Line has trailing spaces. | 38 | |
if child at indentation level 16 not at correct indentation, 12 | 42 | |
'cast' is not followed by whitespace. | 42 | |
Line is longer than 120 characters. | 48 | |
Method 'getActivities' is not designed for extension - needs to be abstract, final or empty. | 59 | |
Line is longer than 120 characters. | 81 | |
Method 'getActivities' is not designed for extension - needs to be abstract, final or empty. | 81 | |
Method 'getActivity' is not designed for extension - needs to be abstract, final or empty. | 104 | |
'activityId' hides a field. | 104 | |
Method 'deleteActivities' is not designed for extension - needs to be abstract, final or empty. | 112 | |
'activityId' hides a field. | 126 | |
Line is longer than 120 characters. | 141 | |
Method 'createActivity' is not designed for extension - needs to be abstract, final or empty. | 141 | |
Line is longer than 120 characters. | 152 | |
Line has trailing spaces. | 213 | |
'activityId' hides a field. | 217 | |
'cast' is not followed by whitespace. | 232 | |
Line is longer than 120 characters. | 237 | |
'cast' is not followed by whitespace. | 240 | |
Line is longer than 120 characters. | 248 | |
'activityId' hides a field. | 257 | |
'cast' is not followed by whitespace. | 262 | |
Line is longer than 120 characters. | 268 |
Violation | Message | Line |
---|---|---|
Wrong order for 'com.atlassian.gadgets.opensocial.SecurityToken' import. | 5 | |
Wrong order for 'com.atlassian.sal.api.pluginsettings.PluginSettings' import. | 7 | |
Wrong order for 'java.util.Set' import. | 9 | |
Wrong order for 'java.util.Map' import. | 10 | |
Wrong order for 'java.util.HashMap' import. | 11 | |
First sentence should end with a period. | 13 | |
Line is longer than 120 characters. | 14 | |
Static variable definition in wrong order. | 19 | |
Line is longer than 120 characters. | 26 | |
Method 'getPeopleData' is not designed for extension - needs to be abstract, final or empty. | 26 | |
Line has trailing spaces. | 32 | |
'cast' is not followed by whitespace. | 35 | |
Method 'deletePersonData' is not designed for extension - needs to be abstract, final or empty. | 42 | |
Line is longer than 120 characters. | 51 | |
Method 'updatePersonData' is not designed for extension - needs to be abstract, final or empty. | 51 | |
Line has trailing spaces. | 57 | |
Line is longer than 120 characters. | 63 |
Violation | Message | Line |
---|---|---|
'com.google.common.base.Preconditions.checkNotNull' should be separated from previous imports. | 5 | |
'org.apache.commons.lang.StringUtils.isBlank' should be separated from previous imports. | 8 | |
Wrong order for 'java.net.URISyntaxException' import. | 11 | |
Wrong order for 'com.atlassian.gadgets.dashboard.DashboardState.ColumnIndex' import. | 22 | |
Missing a Javadoc comment. | 29 | |
Class Fan-Out Complexity is 19 (max allowed is 10). | 29 | |
Static variable definition in wrong order. | 33 | |
Static variable definition in wrong order. | 35 | |
Method 'retrieve' is not designed for extension - needs to be abstract, final or empty. | 42 | |
Line is longer than 120 characters. | 56 | |
'cast' is not followed by whitespace. | 68 | |
'+' should be on a new line. | 85 | |
Line is longer than 120 characters. | 86 | |
'+' should be on a new line. | 86 | |
Method 'findDashboardWithGadget' is not designed for extension - needs to be abstract, final or empty. | 102 | |
Line is longer than 120 characters. | 110 | |
Method 'update' is not designed for extension - needs to be abstract, final or empty. | 110 | |
'cast' is not followed by whitespace. | 117 | |
Method 'remove' is not designed for extension - needs to be abstract, final or empty. | 136 | |
Line has trailing spaces. | 179 | |
Line has trailing spaces. | 190 | |
Line has trailing spaces. | 194 | |
Line has trailing spaces. | 206 | |
Line has trailing spaces. | 219 | |
Line has trailing spaces. | 225 |
Violation | Message | Line |
---|---|---|
Wrong order for 'java.util.Collections.singleton' import. | 7 | |
Wrong order for 'java.net.URI' import. | 9 | |
Wrong order for 'com.atlassian.gadgets.directory.spi.ExternalGadgetSpec' import. | 18 | |
Class Fan-Out Complexity is 13 (max allowed is 10). | 28 | |
Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 30 | |
Missing a Javadoc comment. | 31 | |
Variable access definition in wrong order. | 31 | |
Method 'entries' is not designed for extension - needs to be abstract, final or empty. | 49 | |
Method 'add' is not designed for extension - needs to be abstract, final or empty. | 90 | |
Assignment of parameter 'gadgetSpecUri' is not allowed. | 93 | |
Method 'remove' is not designed for extension - needs to be abstract, final or empty. | 117 | |
Method 'contains' is not designed for extension - needs to be abstract, final or empty. | 157 | |
Assignment of parameter 'gadgetSpecUri' is not allowed. | 160 | |
'abstract' modifier out of order with the JLS suggestions. | 241 | |
Name 'length' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 243 | |
Instance variable definition in wrong order. | 276 | |
Constructor definition in wrong order. | 278 |
Violation | Message | Line |
---|---|---|
Wrong order for 'com.atlassian.gadgets.opensocial.spi.Person' import. | 4 | |
Wrong order for 'com.atlassian.gadgets.opensocial.SecurityToken' import. | 5 | |
Wrong order for 'com.atlassian.gadgets.opensocial.Group' import. | 6 | |
Wrong order for 'java.security.Principal' import. | 9 | |
Wrong order for 'java.util.List' import. | 11 | |
Unused import - java.util.List. | 11 | |
Wrong order for 'java.util.ArrayList' import. | 12 | |
Unused import - java.util.ArrayList. | 12 | |
First sentence should end with a period. | 15 | |
Missing a Javadoc comment. | 20 | |
Variable 'userManager' must be private and have accessor methods. | 20 | |
Method 'getPerson' is not designed for extension - needs to be abstract, final or empty. | 27 | |
Method 'getPeople' is not designed for extension - needs to be abstract, final or empty. | 37 |