Checkstyle Results

The following document contains the results of Checkstyle. rss feed

Summary

Files Infos Infos Warnings Warnings Errors Errors
8 0 0 378

Files

Files I Infos W Warnings E Errors
com/atlassian/gadgets/refimpl/ApplicationGadgetSpecProviderImpl.java 0 0 23
com/atlassian/gadgets/refimpl/ExternalGadgetSpecIdGenerator.java 0 0 3
com/atlassian/gadgets/refimpl/ExternalGadgetSpecIdGeneratorImpl.java 0 0 15
com/atlassian/gadgets/refimpl/GadgetStateFactoryImpl.java 0 0 28
com/atlassian/gadgets/refimpl/PermissionServiceImpl.java 0 0 30
com/atlassian/gadgets/refimpl/PluginSettingsDashboardStateStore.java 0 0 102
com/atlassian/gadgets/refimpl/PluginSettingsExternalGadgetSpecStore.java 0 0 176
com/atlassian/gadgets/refimpl/package.html 0 0 1

Rules

Rules Violations Severity
PackageHtml 1 Errors Error
NewlineAtEndOfFile 0 Errors Error
Translation 0 Errors Error
JavadocMethod 35 Errors Error
JavadocType 3 Errors Error
JavadocVariable 20 Errors Error
JavadocStyle 0 Errors Error
ConstantName 2 Errors Error
LocalFinalVariableName 0 Errors Error
LocalVariableName 0 Errors Error
MemberName 0 Errors Error
MethodName 0 Errors Error
PackageName 0 Errors Error
ParameterName 0 Errors Error
StaticVariableName 0 Errors Error
TypeName 0 Errors Error
AvoidStarImport 0 Errors Error
IllegalImport 0 Errors Error
RedundantImport 0 Errors Error
UnusedImports 0 Errors Error
FileLength 0 Errors Error
LineLength 81 Errors Error
MethodLength 0 Errors Error
ParameterNumber 0 Errors Error
EmptyForIteratorPad 0 Errors Error
MethodParamPad 0 Errors Error
NoWhitespaceAfter 0 Errors Error
NoWhitespaceBefore 0 Errors Error
OperatorWrap 0 Errors Error
ParenPad 0 Errors Error
TypecastParenPad 0 Errors Error
TabCharacter 0 Errors Error
WhitespaceAfter 0 Errors Error
WhitespaceAround 64 Errors Error
ModifierOrder 1 Errors Error
RedundantModifier 0 Errors Error
AvoidNestedBlocks 0 Errors Error
EmptyBlock 0 Errors Error
LeftCurly 81 Errors Error
NeedBraces 0 Errors Error
RightCurly 11 Errors Error
AvoidInlineConditionals 5 Errors Error
DoubleCheckedLocking 0 Errors Error
EmptyStatement 0 Errors Error
EqualsHashCode 0 Errors Error
HiddenField 6 Errors Error
IllegalInstantiation 0 Errors Error
InnerAssignment 0 Errors Error
MagicNumber 0 Errors Error
MissingSwitchDefault 0 Errors Error
RedundantThrows 1 Errors Error
SimplifyBooleanExpression 0 Errors Error
SimplifyBooleanReturn 0 Errors Error
DesignForExtension 14 Errors Error
FinalClass 0 Errors Error
HideUtilityClassConstructor 0 Errors Error
InterfaceIsType 0 Errors Error
VisibilityModifier 0 Errors Error
ArrayTypeStyle 0 Errors Error
FinalParameters 41 Errors Error
GenericIllegalRegexp
  • message: "Line has trailing spaces."
  • format: "\s+$"
 12 Errors Error
TodoComment 0 Errors Error
UpperEll 0 Errors Error

Details

com/atlassian/gadgets/refimpl/ApplicationGadgetSpecProviderImpl.java

Violation Message Line
Errors Missing a Javadoc comment. 11
Errors '{' should be on the previous line. 12
Errors Line is longer than 80 characters. 13
Errors Missing a Javadoc comment. 13
Errors Missing a Javadoc comment. 14
Errors Missing a Javadoc comment. 16
Errors Line is longer than 80 characters. 18
Errors Missing a Javadoc comment. 18
Errors Parameter webResourceManager should be final. 18
Errors 'webResourceManager' hides a field. 18
Errors Method 'entries' is not designed for extension - needs to be abstract, final or empty. 23
Errors Missing a Javadoc comment. 23
Errors '<' is not preceded with whitespace. 23
Errors '<' is not followed by whitespace. 23
Errors '>' is not preceded with whitespace. 23
Errors '{' should be on the previous line. 24
Errors Method 'contains' is not designed for extension - needs to be abstract, final or empty. 28
Errors Missing a Javadoc comment. 28
Errors Parameter gadgetSpecUri should be final. 28
Errors '{' should be on the previous line. 29
Errors Missing a Javadoc comment. 33
Errors '{' should be on the previous line. 34
Errors Line is longer than 80 characters. 35

com/atlassian/gadgets/refimpl/ExternalGadgetSpecIdGenerator.java

Violation Message Line
Errors Line is longer than 80 characters. 6
Errors '{' should be on the previous line. 9
Errors Line is longer than 80 characters. 11

com/atlassian/gadgets/refimpl/ExternalGadgetSpecIdGeneratorImpl.java

Violation Message Line
Errors Line is longer than 80 characters. 12
Errors Line is longer than 80 characters. 14
Errors Missing a Javadoc comment. 14
Errors Missing a Javadoc comment. 15
Errors Missing a Javadoc comment. 16
Errors Missing a Javadoc comment. 18
Errors Line is longer than 80 characters. 25
Errors Parameter pluginSettingsFactory should be final. 25
Errors Line is longer than 80 characters. 27
Errors Method 'newExternalGadgetSpecId' is not designed for extension - needs to be abstract, final or empty. 30
Errors Missing a Javadoc comment. 30
Errors '{' should be on the previous line. 31
Errors Line is longer than 80 characters. 33
Errors Avoid inline conditionals. 33
Errors Line is longer than 80 characters. 34

com/atlassian/gadgets/refimpl/GadgetStateFactoryImpl.java

Violation Message Line
Errors Line is longer than 80 characters. 13
Errors Line is longer than 80 characters. 14
Errors Line is longer than 80 characters. 15
Errors Line is longer than 80 characters. 16
Errors Line is longer than 80 characters. 17
Errors Line is longer than 80 characters. 18
Errors Line is longer than 80 characters. 20
Errors '{' should be on the previous line. 24
Errors Line is longer than 80 characters. 25
Errors Missing a Javadoc comment. 25
Errors Missing a Javadoc comment. 26
Errors Missing a Javadoc comment. 28
Errors Line is longer than 80 characters. 31
Errors Line is longer than 80 characters. 34
Errors Parameter pluginSettingsFactory should be final. 36
Errors '{' should be on the previous line. 37
Errors Line is longer than 80 characters. 42
Errors Line is longer than 80 characters. 43
Errors Line is longer than 80 characters. 46
Errors Line is longer than 80 characters. 47
Errors Method 'createGadgetState' is not designed for extension - needs to be abstract, final or empty. 49
Errors Parameter gadgetSpecUri should be final. 49
Errors '{' should be on the previous line. 50
Errors Missing a Javadoc comment. 54
Errors '{' should be on the previous line. 55
Errors Line is longer than 80 characters. 57
Errors Avoid inline conditionals. 57
Errors Line is longer than 80 characters. 58

com/atlassian/gadgets/refimpl/PermissionServiceImpl.java

Violation Message Line
Errors Line is longer than 80 characters. 8
Errors Line is longer than 80 characters. 9
Errors Line is longer than 80 characters. 10
Errors '{' should be on the previous line. 14
Errors Missing a Javadoc comment. 15
Errors Missing a Javadoc comment. 16
Errors Missing a Javadoc comment. 18
Errors Missing a Javadoc comment. 20
Errors Parameter userManager should be final. 20
Errors 'userManager' hides a field. 20
Errors '{' should be on the previous line. 21
Errors Method 'isReadableBy' is not designed for extension - needs to be abstract, final or empty. 25
Errors Missing a Javadoc comment. 25
Errors Parameter dashboardId should be final. 25
Errors Parameter username should be final. 25
Errors '{' should be on the previous line. 26
Errors Line is longer than 80 characters. 27
Errors Method 'isWritableBy' is not designed for extension - needs to be abstract, final or empty. 30
Errors Missing a Javadoc comment. 30
Errors Parameter dashboardId should be final. 30
Errors Parameter username should be final. 30
Errors '{' should be on the previous line. 31
Errors Line is longer than 80 characters. 32
Errors Method 'canConfigureDirectory' is not designed for extension - needs to be abstract, final or empty. 35
Errors Missing a Javadoc comment. 35
Errors Parameter username should be final. 35
Errors '{' should be on the previous line. 36
Errors Missing a Javadoc comment. 40
Errors Parameter username should be final. 40
Errors '{' should be on the previous line. 41

com/atlassian/gadgets/refimpl/PluginSettingsDashboardStateStore.java

Violation Message Line
Errors Missing a Javadoc comment. 27
Errors '{' should be on the previous line. 28
Errors Missing a Javadoc comment. 29
Errors Line has trailing spaces. 30
Errors Line is longer than 80 characters. 31
Errors Missing a Javadoc comment. 31
Errors Parameter pluginSettingsFactory should be final. 31
Errors 'pluginSettingsFactory' hides a field. 31
Errors Method 'retrieve' is not designed for extension - needs to be abstract, final or empty. 36
Errors Missing a Javadoc comment. 36
Errors Parameter dashboardId should be final. 36
Errors '{' should be on the previous line. 37
Errors Line is longer than 80 characters. 39
Errors '{' should be on the previous line. 41
Errors Line has trailing spaces. 44
Errors Line has trailing spaces. 46
Errors Line has trailing spaces. 50
Errors '<' is not preceded with whitespace. 51
Errors '<' is not followed by whitespace. 51
Errors '<' is not preceded with whitespace. 51
Errors '<' is not followed by whitespace. 51
Errors '>' is not preceded with whitespace. 51
Errors '>' is not followed by whitespace. 51
Errors '>' is not preceded with whitespace. 51
Errors '{' should be on the previous line. 53
Errors Line is longer than 80 characters. 54
Errors '<' is not preceded with whitespace. 55
Errors '<' is not followed by whitespace. 55
Errors '>' is not preceded with whitespace. 55
Errors '{' should be on the previous line. 57
Errors '{' should be on the previous line. 59
Errors Line is longer than 80 characters. 60
Errors '}' should be on the same line. 62
Errors '{' should be on the previous line. 64
Errors Method 'store' is not designed for extension - needs to be abstract, final or empty. 73
Errors Missing a Javadoc comment. 73
Errors Parameter dashboardState should be final. 73
Errors '{' should be on the previous line. 74
Errors Line is longer than 80 characters. 76
Errors '{' should be on the previous line. 81
Errors Line is longer than 80 characters. 83
Errors Line is longer than 80 characters. 85
Errors Line is longer than 80 characters. 89
Errors Line has trailing spaces. 93
Errors Method 'remove' is not designed for extension - needs to be abstract, final or empty. 94
Errors Missing a Javadoc comment. 94
Errors Parameter dashboardId should be final. 94
Errors '{' should be on the previous line. 95
Errors Line is longer than 80 characters. 97
Errors '{' should be on the previous line. 103
Errors Line is longer than 80 characters. 105
Errors Line is longer than 80 characters. 107
Errors Line has trailing spaces. 114
Errors Missing a Javadoc comment. 115
Errors Parameter gadgetState should be final. 115
Errors Parameter pluginSettings should be final. 115
Errors '{' should be on the previous line. 116
Errors Line is longer than 80 characters. 118
Errors Line is longer than 80 characters. 119
Errors Line has trailing spaces. 120
Errors '{' should be on the previous line. 122
Errors Line is longer than 80 characters. 123
Errors Line is longer than 80 characters. 124
Errors '<' is not preceded with whitespace. 124
Errors '<' is not followed by whitespace. 124
Errors '>' is not preceded with whitespace. 124
Errors Line is longer than 80 characters. 126
Errors Line has trailing spaces. 130
Errors Line is longer than 80 characters. 131
Errors Missing a Javadoc comment. 131
Errors Parameter gadgetId should be final. 131
Errors Parameter pluginSettings should be final. 131
Errors Line has trailing spaces. 134
Errors '{' should be on the previous line. 137
Errors Line is longer than 80 characters. 140
Errors '}' should be on the same line. 141
Errors '{' should be on the previous line. 143
Errors Line has trailing spaces. 146
Errors '<' is not preceded with whitespace. 147
Errors '<' is not followed by whitespace. 147
Errors '>' is not preceded with whitespace. 147
Errors Line is longer than 80 characters. 148
Errors Line is longer than 80 characters. 150
Errors '{' should be on the previous line. 152
Errors Line is longer than 80 characters. 154
Errors Line has trailing spaces. 159
Errors Missing a Javadoc comment. 160
Errors Parameter gadgetState should be final. 160
Errors Parameter pluginSettings should be final. 160
Errors Line has trailing spaces. 165
Errors '{' should be on the previous line. 167
Errors Line is longer than 80 characters. 169
Errors '<' is not preceded with whitespace. 169
Errors '<' is not followed by whitespace. 169
Errors '>' is not preceded with whitespace. 169
Errors Line is longer than 80 characters. 171
Errors Missing a Javadoc comment. 177
Errors Parameter gadgetId should be final. 177
Errors '{' should be on the previous line. 178
Errors Missing a Javadoc comment. 182
Errors Parameter dashboardId should be final. 182
Errors '{' should be on the previous line. 183

com/atlassian/gadgets/refimpl/PluginSettingsExternalGadgetSpecStore.java

Violation Message Line
Errors Line is longer than 80 characters. 25
Errors Line is longer than 80 characters. 27
Errors Line is longer than 80 characters. 29
Errors Missing a Javadoc comment. 29
Errors Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 29
Errors Missing a Javadoc comment. 31
Errors Missing a Javadoc comment. 33
Errors Missing a Javadoc comment. 34
Errors Line is longer than 80 characters. 36
Errors Missing a Javadoc comment. 36
Errors Parameter pluginSettingsFactory should be final. 36
Errors 'pluginSettingsFactory' hides a field. 36
Errors Parameter gadgetSpecIdGenerator should be final. 37
Errors 'gadgetSpecIdGenerator' hides a field. 37
Errors '{' should be on the previous line. 38
Errors Method 'entries' is not designed for extension - needs to be abstract, final or empty. 47
Errors Missing a Javadoc comment. 47
Errors '<' is not preceded with whitespace. 47
Errors '<' is not followed by whitespace. 47
Errors '>' is not preceded with whitespace. 47
Errors '{' should be on the previous line. 48
Errors '<' is not preceded with whitespace. 49
Errors '<' is not followed by whitespace. 49
Errors '>' is not preceded with whitespace. 49
Errors '{' should be on the previous line. 52
Errors '{' should be on the previous line. 56
Errors '{' should be on the previous line. 58
Errors Line is longer than 80 characters. 60
Errors Line is longer than 80 characters. 61
Errors Line is longer than 80 characters. 62
Errors '{' should be on the previous line. 64
Errors '}' should be on the same line. 67
Errors '{' should be on the previous line. 69
Errors '{' should be on the previous line. 71
Errors Line is longer than 80 characters. 72
Errors '}' should be on the same line. 73
Errors '{' should be on the previous line. 75
Errors Line is longer than 80 characters. 76
Errors '}' should be on the same line. 80
Errors '{' should be on the previous line. 82
Errors Line is longer than 80 characters. 88
Errors Method 'add' is not designed for extension - needs to be abstract, final or empty. 88
Errors Missing a Javadoc comment. 88
Errors Parameter gadgetSpecUri should be final. 88
Errors Redundant throws: 'ExternalGadgetStoreException' is unchecked exception. 88
Errors '{' should be on the previous line. 95
Errors Line is longer than 80 characters. 96
Errors '{' should be on the previous line. 99
Errors '}' should be on the same line. 101
Errors '{' should be on the previous line. 103
Errors Line is longer than 80 characters. 104
Errors '}' should be on the same line. 108
Errors '{' should be on the previous line. 110
Errors Method 'remove' is not designed for extension - needs to be abstract, final or empty. 115
Errors Missing a Javadoc comment. 115
Errors Parameter externalGadgetSpecId should be final. 115
Errors '{' should be on the previous line. 116
Errors '{' should be on the previous line. 121
Errors '<' is not preceded with whitespace. 122
Errors '<' is not followed by whitespace. 122
Errors '>' is not preceded with whitespace. 122
Errors '{' should be on the previous line. 125
Errors '{' should be on the previous line. 127
Errors '{' should be on the previous line. 133
Errors '{' should be on the previous line. 135
Errors Line is longer than 80 characters. 139
Errors Line is longer than 80 characters. 141
Errors Line is longer than 80 characters. 144
Errors '}' should be on the same line. 148
Errors '{' should be on the previous line. 150
Errors Method 'contains' is not designed for extension - needs to be abstract, final or empty. 155
Errors Missing a Javadoc comment. 155
Errors Parameter gadgetSpecUri should be final. 155
Errors '{' should be on the previous line. 156
Errors '{' should be on the previous line. 162
Errors '}' should be on the same line. 164
Errors '{' should be on the previous line. 166
Errors Line is longer than 80 characters. 171
Errors Missing a Javadoc comment. 171
Errors '<' is not preceded with whitespace. 171
Errors '<' is not followed by whitespace. 171
Errors '>' is not preceded with whitespace. 171
Errors Parameter gadgetSpecs should be final. 171
Errors '<' is not preceded with whitespace. 171
Errors '<' is not followed by whitespace. 171
Errors '>' is not preceded with whitespace. 171
Errors '{' should be on the previous line. 174
Errors '{' should be on the previous line. 176
Errors '<' is not preceded with whitespace. 179
Errors '<' is not followed by whitespace. 179
Errors '>' is not preceded with whitespace. 179
Errors '{' should be on the previous line. 182
Errors Line is longer than 80 characters. 183
Errors '{' should be on the previous line. 185
Errors Line is longer than 80 characters. 187
Errors Line is longer than 80 characters. 189
Errors Line is longer than 80 characters. 191
Errors Line is longer than 80 characters. 192
Errors '{' should be on the previous line. 194
Errors Line is longer than 80 characters. 195
Errors Line is longer than 80 characters. 199
Errors Line is longer than 80 characters. 200
Errors '{' should be on the previous line. 206
Errors '}' should be on the same line. 210
Errors '{' should be on the previous line. 212
Errors '}' should be on the same line. 215
Errors '{' should be on the previous line. 217
Errors Line is longer than 80 characters. 218
Errors Missing a Javadoc comment. 222
Errors Parameter gadgetSpecUri should be final. 222
Errors '{' should be on the previous line. 223
Errors '{' should be on the previous line. 225
Errors '{' should be on the previous line. 227
Errors Missing a Javadoc comment. 234
Errors '{' should be on the previous line. 235
Errors Line is longer than 80 characters. 236
Errors Missing a Javadoc comment. 239
Errors 'abstract' modifier out of order with the JLS suggestions. 239
Errors '<' is not preceded with whitespace. 239
Errors '<' is not followed by whitespace. 239
Errors '>' is not preceded with whitespace. 239
Errors '{' should be on the previous line. 240
Errors Missing a Javadoc comment. 241
Errors '<' is not preceded with whitespace. 241
Errors '<' is not followed by whitespace. 241
Errors '>' is not preceded with whitespace. 241
Errors Name 'length' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 241
Errors '<' is not preceded with whitespace. 241
Errors '<' is not followed by whitespace. 241
Errors '>' is not preceded with whitespace. 241
Errors '>' is not followed by whitespace. 241
Errors Parameter value should be final. 243
Errors '{' should be on the previous line. 244
Errors Avoid inline conditionals. 245
Errors Missing a Javadoc comment. 249
Errors '<' is not preceded with whitespace. 249
Errors '<' is not followed by whitespace. 249
Errors '>' is not preceded with whitespace. 249
Errors Parameter id should be final. 249
Errors '{' should be on the previous line. 250
Errors '<' is not preceded with whitespace. 251
Errors '<' is not followed by whitespace. 251
Errors '>' is not preceded with whitespace. 251
Errors '>' is not followed by whitespace. 251
Errors Parameter value should be final. 253
Errors '{' should be on the previous line. 254
Errors Avoid inline conditionals. 255
Errors Missing a Javadoc comment. 260
Errors '<' is not preceded with whitespace. 260
Errors '<' is not followed by whitespace. 260
Errors '>' is not preceded with whitespace. 260
Errors Parameter index should be final. 260
Errors '{' should be on the previous line. 261
Errors '<' is not preceded with whitespace. 262
Errors '<' is not followed by whitespace. 262
Errors '>' is not preceded with whitespace. 262
Errors '>' is not followed by whitespace. 262
Errors Parameter value should be final. 264
Errors '{' should be on the previous line. 265
Errors Avoid inline conditionals. 266
Errors Missing a Javadoc comment. 271
Errors Missing a Javadoc comment. 273
Errors Parameter name should be final. 273
Errors 'name' hides a field. 273
Errors '{' should be on the previous line. 274
Errors Missing a Javadoc comment. 278
Errors Parameter settings should be final. 278
Errors '{' should be on the previous line. 279
Errors Missing a Javadoc comment. 283
Errors Parameter settings should be final. 283
Errors Parameter value should be final. 283
Errors '{' should be on the previous line. 284
Errors Missing a Javadoc comment. 288
Errors Parameter settings should be final. 288
Errors '{' should be on the previous line. 289
Errors Missing a Javadoc comment. 293

com/atlassian/gadgets/refimpl/package.html

Violation Message Line
Errors Missing package documentation file. 0