The following document contains the results of Checkstyle.
Files | Infos | Warnings | Errors |
---|---|---|---|
8 | 0 | 0 | 378 |
Rules | Violations | Severity |
---|---|---|
PackageHtml | 1 | Error |
NewlineAtEndOfFile | 0 | Error |
Translation | 0 | Error |
JavadocMethod | 35 | Error |
JavadocType | 3 | Error |
JavadocVariable | 20 | Error |
JavadocStyle | 0 | Error |
ConstantName | 2 | Error |
LocalFinalVariableName | 0 | Error |
LocalVariableName | 0 | Error |
MemberName | 0 | Error |
MethodName | 0 | Error |
PackageName | 0 | Error |
ParameterName | 0 | Error |
StaticVariableName | 0 | Error |
TypeName | 0 | Error |
AvoidStarImport | 0 | Error |
IllegalImport | 0 | Error |
RedundantImport | 0 | Error |
UnusedImports | 0 | Error |
FileLength | 0 | Error |
LineLength | 81 | Error |
MethodLength | 0 | Error |
ParameterNumber | 0 | Error |
EmptyForIteratorPad | 0 | Error |
MethodParamPad | 0 | Error |
NoWhitespaceAfter | 0 | Error |
NoWhitespaceBefore | 0 | Error |
OperatorWrap | 0 | Error |
ParenPad | 0 | Error |
TypecastParenPad | 0 | Error |
TabCharacter | 0 | Error |
WhitespaceAfter | 0 | Error |
WhitespaceAround | 64 | Error |
ModifierOrder | 1 | Error |
RedundantModifier | 0 | Error |
AvoidNestedBlocks | 0 | Error |
EmptyBlock | 0 | Error |
LeftCurly | 81 | Error |
NeedBraces | 0 | Error |
RightCurly | 11 | Error |
AvoidInlineConditionals | 5 | Error |
DoubleCheckedLocking | 0 | Error |
EmptyStatement | 0 | Error |
EqualsHashCode | 0 | Error |
HiddenField | 6 | Error |
IllegalInstantiation | 0 | Error |
InnerAssignment | 0 | Error |
MagicNumber | 0 | Error |
MissingSwitchDefault | 0 | Error |
RedundantThrows | 1 | Error |
SimplifyBooleanExpression | 0 | Error |
SimplifyBooleanReturn | 0 | Error |
DesignForExtension | 14 | Error |
FinalClass | 0 | Error |
HideUtilityClassConstructor | 0 | Error |
InterfaceIsType | 0 | Error |
VisibilityModifier | 0 | Error |
ArrayTypeStyle | 0 | Error |
FinalParameters | 41 | Error |
GenericIllegalRegexp
|
12 | Error |
TodoComment | 0 | Error |
UpperEll | 0 | Error |
Violation | Message | Line |
---|---|---|
Missing a Javadoc comment. | 11 | |
'{' should be on the previous line. | 12 | |
Line is longer than 80 characters. | 13 | |
Missing a Javadoc comment. | 13 | |
Missing a Javadoc comment. | 14 | |
Missing a Javadoc comment. | 16 | |
Line is longer than 80 characters. | 18 | |
Missing a Javadoc comment. | 18 | |
Parameter webResourceManager should be final. | 18 | |
'webResourceManager' hides a field. | 18 | |
Method 'entries' is not designed for extension - needs to be abstract, final or empty. | 23 | |
Missing a Javadoc comment. | 23 | |
'<' is not preceded with whitespace. | 23 | |
'<' is not followed by whitespace. | 23 | |
'>' is not preceded with whitespace. | 23 | |
'{' should be on the previous line. | 24 | |
Method 'contains' is not designed for extension - needs to be abstract, final or empty. | 28 | |
Missing a Javadoc comment. | 28 | |
Parameter gadgetSpecUri should be final. | 28 | |
'{' should be on the previous line. | 29 | |
Missing a Javadoc comment. | 33 | |
'{' should be on the previous line. | 34 | |
Line is longer than 80 characters. | 35 |
Violation | Message | Line |
---|---|---|
Line is longer than 80 characters. | 6 | |
'{' should be on the previous line. | 9 | |
Line is longer than 80 characters. | 11 |
Violation | Message | Line |
---|---|---|
Line is longer than 80 characters. | 12 | |
Line is longer than 80 characters. | 14 | |
Missing a Javadoc comment. | 14 | |
Missing a Javadoc comment. | 15 | |
Missing a Javadoc comment. | 16 | |
Missing a Javadoc comment. | 18 | |
Line is longer than 80 characters. | 25 | |
Parameter pluginSettingsFactory should be final. | 25 | |
Line is longer than 80 characters. | 27 | |
Method 'newExternalGadgetSpecId' is not designed for extension - needs to be abstract, final or empty. | 30 | |
Missing a Javadoc comment. | 30 | |
'{' should be on the previous line. | 31 | |
Line is longer than 80 characters. | 33 | |
Avoid inline conditionals. | 33 | |
Line is longer than 80 characters. | 34 |
Violation | Message | Line |
---|---|---|
Line is longer than 80 characters. | 13 | |
Line is longer than 80 characters. | 14 | |
Line is longer than 80 characters. | 15 | |
Line is longer than 80 characters. | 16 | |
Line is longer than 80 characters. | 17 | |
Line is longer than 80 characters. | 18 | |
Line is longer than 80 characters. | 20 | |
'{' should be on the previous line. | 24 | |
Line is longer than 80 characters. | 25 | |
Missing a Javadoc comment. | 25 | |
Missing a Javadoc comment. | 26 | |
Missing a Javadoc comment. | 28 | |
Line is longer than 80 characters. | 31 | |
Line is longer than 80 characters. | 34 | |
Parameter pluginSettingsFactory should be final. | 36 | |
'{' should be on the previous line. | 37 | |
Line is longer than 80 characters. | 42 | |
Line is longer than 80 characters. | 43 | |
Line is longer than 80 characters. | 46 | |
Line is longer than 80 characters. | 47 | |
Method 'createGadgetState' is not designed for extension - needs to be abstract, final or empty. | 49 | |
Parameter gadgetSpecUri should be final. | 49 | |
'{' should be on the previous line. | 50 | |
Missing a Javadoc comment. | 54 | |
'{' should be on the previous line. | 55 | |
Line is longer than 80 characters. | 57 | |
Avoid inline conditionals. | 57 | |
Line is longer than 80 characters. | 58 |
Violation | Message | Line |
---|---|---|
Line is longer than 80 characters. | 8 | |
Line is longer than 80 characters. | 9 | |
Line is longer than 80 characters. | 10 | |
'{' should be on the previous line. | 14 | |
Missing a Javadoc comment. | 15 | |
Missing a Javadoc comment. | 16 | |
Missing a Javadoc comment. | 18 | |
Missing a Javadoc comment. | 20 | |
Parameter userManager should be final. | 20 | |
'userManager' hides a field. | 20 | |
'{' should be on the previous line. | 21 | |
Method 'isReadableBy' is not designed for extension - needs to be abstract, final or empty. | 25 | |
Missing a Javadoc comment. | 25 | |
Parameter dashboardId should be final. | 25 | |
Parameter username should be final. | 25 | |
'{' should be on the previous line. | 26 | |
Line is longer than 80 characters. | 27 | |
Method 'isWritableBy' is not designed for extension - needs to be abstract, final or empty. | 30 | |
Missing a Javadoc comment. | 30 | |
Parameter dashboardId should be final. | 30 | |
Parameter username should be final. | 30 | |
'{' should be on the previous line. | 31 | |
Line is longer than 80 characters. | 32 | |
Method 'canConfigureDirectory' is not designed for extension - needs to be abstract, final or empty. | 35 | |
Missing a Javadoc comment. | 35 | |
Parameter username should be final. | 35 | |
'{' should be on the previous line. | 36 | |
Missing a Javadoc comment. | 40 | |
Parameter username should be final. | 40 | |
'{' should be on the previous line. | 41 |
Violation | Message | Line |
---|---|---|
Missing a Javadoc comment. | 27 | |
'{' should be on the previous line. | 28 | |
Missing a Javadoc comment. | 29 | |
Line has trailing spaces. | 30 | |
Line is longer than 80 characters. | 31 | |
Missing a Javadoc comment. | 31 | |
Parameter pluginSettingsFactory should be final. | 31 | |
'pluginSettingsFactory' hides a field. | 31 | |
Method 'retrieve' is not designed for extension - needs to be abstract, final or empty. | 36 | |
Missing a Javadoc comment. | 36 | |
Parameter dashboardId should be final. | 36 | |
'{' should be on the previous line. | 37 | |
Line is longer than 80 characters. | 39 | |
'{' should be on the previous line. | 41 | |
Line has trailing spaces. | 44 | |
Line has trailing spaces. | 46 | |
Line has trailing spaces. | 50 | |
'<' is not preceded with whitespace. | 51 | |
'<' is not followed by whitespace. | 51 | |
'<' is not preceded with whitespace. | 51 | |
'<' is not followed by whitespace. | 51 | |
'>' is not preceded with whitespace. | 51 | |
'>' is not followed by whitespace. | 51 | |
'>' is not preceded with whitespace. | 51 | |
'{' should be on the previous line. | 53 | |
Line is longer than 80 characters. | 54 | |
'<' is not preceded with whitespace. | 55 | |
'<' is not followed by whitespace. | 55 | |
'>' is not preceded with whitespace. | 55 | |
'{' should be on the previous line. | 57 | |
'{' should be on the previous line. | 59 | |
Line is longer than 80 characters. | 60 | |
'}' should be on the same line. | 62 | |
'{' should be on the previous line. | 64 | |
Method 'store' is not designed for extension - needs to be abstract, final or empty. | 73 | |
Missing a Javadoc comment. | 73 | |
Parameter dashboardState should be final. | 73 | |
'{' should be on the previous line. | 74 | |
Line is longer than 80 characters. | 76 | |
'{' should be on the previous line. | 81 | |
Line is longer than 80 characters. | 83 | |
Line is longer than 80 characters. | 85 | |
Line is longer than 80 characters. | 89 | |
Line has trailing spaces. | 93 | |
Method 'remove' is not designed for extension - needs to be abstract, final or empty. | 94 | |
Missing a Javadoc comment. | 94 | |
Parameter dashboardId should be final. | 94 | |
'{' should be on the previous line. | 95 | |
Line is longer than 80 characters. | 97 | |
'{' should be on the previous line. | 103 | |
Line is longer than 80 characters. | 105 | |
Line is longer than 80 characters. | 107 | |
Line has trailing spaces. | 114 | |
Missing a Javadoc comment. | 115 | |
Parameter gadgetState should be final. | 115 | |
Parameter pluginSettings should be final. | 115 | |
'{' should be on the previous line. | 116 | |
Line is longer than 80 characters. | 118 | |
Line is longer than 80 characters. | 119 | |
Line has trailing spaces. | 120 | |
'{' should be on the previous line. | 122 | |
Line is longer than 80 characters. | 123 | |
Line is longer than 80 characters. | 124 | |
'<' is not preceded with whitespace. | 124 | |
'<' is not followed by whitespace. | 124 | |
'>' is not preceded with whitespace. | 124 | |
Line is longer than 80 characters. | 126 | |
Line has trailing spaces. | 130 | |
Line is longer than 80 characters. | 131 | |
Missing a Javadoc comment. | 131 | |
Parameter gadgetId should be final. | 131 | |
Parameter pluginSettings should be final. | 131 | |
Line has trailing spaces. | 134 | |
'{' should be on the previous line. | 137 | |
Line is longer than 80 characters. | 140 | |
'}' should be on the same line. | 141 | |
'{' should be on the previous line. | 143 | |
Line has trailing spaces. | 146 | |
'<' is not preceded with whitespace. | 147 | |
'<' is not followed by whitespace. | 147 | |
'>' is not preceded with whitespace. | 147 | |
Line is longer than 80 characters. | 148 | |
Line is longer than 80 characters. | 150 | |
'{' should be on the previous line. | 152 | |
Line is longer than 80 characters. | 154 | |
Line has trailing spaces. | 159 | |
Missing a Javadoc comment. | 160 | |
Parameter gadgetState should be final. | 160 | |
Parameter pluginSettings should be final. | 160 | |
Line has trailing spaces. | 165 | |
'{' should be on the previous line. | 167 | |
Line is longer than 80 characters. | 169 | |
'<' is not preceded with whitespace. | 169 | |
'<' is not followed by whitespace. | 169 | |
'>' is not preceded with whitespace. | 169 | |
Line is longer than 80 characters. | 171 | |
Missing a Javadoc comment. | 177 | |
Parameter gadgetId should be final. | 177 | |
'{' should be on the previous line. | 178 | |
Missing a Javadoc comment. | 182 | |
Parameter dashboardId should be final. | 182 | |
'{' should be on the previous line. | 183 |
Violation | Message | Line |
---|---|---|
Line is longer than 80 characters. | 25 | |
Line is longer than 80 characters. | 27 | |
Line is longer than 80 characters. | 29 | |
Missing a Javadoc comment. | 29 | |
Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 29 | |
Missing a Javadoc comment. | 31 | |
Missing a Javadoc comment. | 33 | |
Missing a Javadoc comment. | 34 | |
Line is longer than 80 characters. | 36 | |
Missing a Javadoc comment. | 36 | |
Parameter pluginSettingsFactory should be final. | 36 | |
'pluginSettingsFactory' hides a field. | 36 | |
Parameter gadgetSpecIdGenerator should be final. | 37 | |
'gadgetSpecIdGenerator' hides a field. | 37 | |
'{' should be on the previous line. | 38 | |
Method 'entries' is not designed for extension - needs to be abstract, final or empty. | 47 | |
Missing a Javadoc comment. | 47 | |
'<' is not preceded with whitespace. | 47 | |
'<' is not followed by whitespace. | 47 | |
'>' is not preceded with whitespace. | 47 | |
'{' should be on the previous line. | 48 | |
'<' is not preceded with whitespace. | 49 | |
'<' is not followed by whitespace. | 49 | |
'>' is not preceded with whitespace. | 49 | |
'{' should be on the previous line. | 52 | |
'{' should be on the previous line. | 56 | |
'{' should be on the previous line. | 58 | |
Line is longer than 80 characters. | 60 | |
Line is longer than 80 characters. | 61 | |
Line is longer than 80 characters. | 62 | |
'{' should be on the previous line. | 64 | |
'}' should be on the same line. | 67 | |
'{' should be on the previous line. | 69 | |
'{' should be on the previous line. | 71 | |
Line is longer than 80 characters. | 72 | |
'}' should be on the same line. | 73 | |
'{' should be on the previous line. | 75 | |
Line is longer than 80 characters. | 76 | |
'}' should be on the same line. | 80 | |
'{' should be on the previous line. | 82 | |
Line is longer than 80 characters. | 88 | |
Method 'add' is not designed for extension - needs to be abstract, final or empty. | 88 | |
Missing a Javadoc comment. | 88 | |
Parameter gadgetSpecUri should be final. | 88 | |
Redundant throws: 'ExternalGadgetStoreException' is unchecked exception. | 88 | |
'{' should be on the previous line. | 95 | |
Line is longer than 80 characters. | 96 | |
'{' should be on the previous line. | 99 | |
'}' should be on the same line. | 101 | |
'{' should be on the previous line. | 103 | |
Line is longer than 80 characters. | 104 | |
'}' should be on the same line. | 108 | |
'{' should be on the previous line. | 110 | |
Method 'remove' is not designed for extension - needs to be abstract, final or empty. | 115 | |
Missing a Javadoc comment. | 115 | |
Parameter externalGadgetSpecId should be final. | 115 | |
'{' should be on the previous line. | 116 | |
'{' should be on the previous line. | 121 | |
'<' is not preceded with whitespace. | 122 | |
'<' is not followed by whitespace. | 122 | |
'>' is not preceded with whitespace. | 122 | |
'{' should be on the previous line. | 125 | |
'{' should be on the previous line. | 127 | |
'{' should be on the previous line. | 133 | |
'{' should be on the previous line. | 135 | |
Line is longer than 80 characters. | 139 | |
Line is longer than 80 characters. | 141 | |
Line is longer than 80 characters. | 144 | |
'}' should be on the same line. | 148 | |
'{' should be on the previous line. | 150 | |
Method 'contains' is not designed for extension - needs to be abstract, final or empty. | 155 | |
Missing a Javadoc comment. | 155 | |
Parameter gadgetSpecUri should be final. | 155 | |
'{' should be on the previous line. | 156 | |
'{' should be on the previous line. | 162 | |
'}' should be on the same line. | 164 | |
'{' should be on the previous line. | 166 | |
Line is longer than 80 characters. | 171 | |
Missing a Javadoc comment. | 171 | |
'<' is not preceded with whitespace. | 171 | |
'<' is not followed by whitespace. | 171 | |
'>' is not preceded with whitespace. | 171 | |
Parameter gadgetSpecs should be final. | 171 | |
'<' is not preceded with whitespace. | 171 | |
'<' is not followed by whitespace. | 171 | |
'>' is not preceded with whitespace. | 171 | |
'{' should be on the previous line. | 174 | |
'{' should be on the previous line. | 176 | |
'<' is not preceded with whitespace. | 179 | |
'<' is not followed by whitespace. | 179 | |
'>' is not preceded with whitespace. | 179 | |
'{' should be on the previous line. | 182 | |
Line is longer than 80 characters. | 183 | |
'{' should be on the previous line. | 185 | |
Line is longer than 80 characters. | 187 | |
Line is longer than 80 characters. | 189 | |
Line is longer than 80 characters. | 191 | |
Line is longer than 80 characters. | 192 | |
'{' should be on the previous line. | 194 | |
Line is longer than 80 characters. | 195 | |
Line is longer than 80 characters. | 199 | |
Line is longer than 80 characters. | 200 | |
'{' should be on the previous line. | 206 | |
'}' should be on the same line. | 210 | |
'{' should be on the previous line. | 212 | |
'}' should be on the same line. | 215 | |
'{' should be on the previous line. | 217 | |
Line is longer than 80 characters. | 218 | |
Missing a Javadoc comment. | 222 | |
Parameter gadgetSpecUri should be final. | 222 | |
'{' should be on the previous line. | 223 | |
'{' should be on the previous line. | 225 | |
'{' should be on the previous line. | 227 | |
Missing a Javadoc comment. | 234 | |
'{' should be on the previous line. | 235 | |
Line is longer than 80 characters. | 236 | |
Missing a Javadoc comment. | 239 | |
'abstract' modifier out of order with the JLS suggestions. | 239 | |
'<' is not preceded with whitespace. | 239 | |
'<' is not followed by whitespace. | 239 | |
'>' is not preceded with whitespace. | 239 | |
'{' should be on the previous line. | 240 | |
Missing a Javadoc comment. | 241 | |
'<' is not preceded with whitespace. | 241 | |
'<' is not followed by whitespace. | 241 | |
'>' is not preceded with whitespace. | 241 | |
Name 'length' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 241 | |
'<' is not preceded with whitespace. | 241 | |
'<' is not followed by whitespace. | 241 | |
'>' is not preceded with whitespace. | 241 | |
'>' is not followed by whitespace. | 241 | |
Parameter value should be final. | 243 | |
'{' should be on the previous line. | 244 | |
Avoid inline conditionals. | 245 | |
Missing a Javadoc comment. | 249 | |
'<' is not preceded with whitespace. | 249 | |
'<' is not followed by whitespace. | 249 | |
'>' is not preceded with whitespace. | 249 | |
Parameter id should be final. | 249 | |
'{' should be on the previous line. | 250 | |
'<' is not preceded with whitespace. | 251 | |
'<' is not followed by whitespace. | 251 | |
'>' is not preceded with whitespace. | 251 | |
'>' is not followed by whitespace. | 251 | |
Parameter value should be final. | 253 | |
'{' should be on the previous line. | 254 | |
Avoid inline conditionals. | 255 | |
Missing a Javadoc comment. | 260 | |
'<' is not preceded with whitespace. | 260 | |
'<' is not followed by whitespace. | 260 | |
'>' is not preceded with whitespace. | 260 | |
Parameter index should be final. | 260 | |
'{' should be on the previous line. | 261 | |
'<' is not preceded with whitespace. | 262 | |
'<' is not followed by whitespace. | 262 | |
'>' is not preceded with whitespace. | 262 | |
'>' is not followed by whitespace. | 262 | |
Parameter value should be final. | 264 | |
'{' should be on the previous line. | 265 | |
Avoid inline conditionals. | 266 | |
Missing a Javadoc comment. | 271 | |
Missing a Javadoc comment. | 273 | |
Parameter name should be final. | 273 | |
'name' hides a field. | 273 | |
'{' should be on the previous line. | 274 | |
Missing a Javadoc comment. | 278 | |
Parameter settings should be final. | 278 | |
'{' should be on the previous line. | 279 | |
Missing a Javadoc comment. | 283 | |
Parameter settings should be final. | 283 | |
Parameter value should be final. | 283 | |
'{' should be on the previous line. | 284 | |
Missing a Javadoc comment. | 288 | |
Parameter settings should be final. | 288 | |
'{' should be on the previous line. | 289 | |
Missing a Javadoc comment. | 293 |