Checkstyle Results

The following document contains the results of Checkstyle. rss feed

Summary

Files Infos Infos Warnings Warnings Errors Errors
17 21 69 62

Files

Files I Infos W Warnings E Errors
com/atlassian/gadgets/publisher/internal/GadgetModuleDescriptor.java 0 1 3
com/atlassian/gadgets/publisher/internal/GadgetSpecSyndication.java 0 1 0
com/atlassian/gadgets/publisher/internal/GadgetSpecValidator.java 0 0 1
com/atlassian/gadgets/publisher/internal/PluginGadgetFinder.java 1 3 6
com/atlassian/gadgets/publisher/internal/PublishedGadgetSpecNotFoundException.java 0 0 1
com/atlassian/gadgets/publisher/internal/impl/AggregatePluginGadgetSpecProviderPermissionImpl.java 1 6 3
com/atlassian/gadgets/publisher/internal/impl/GadgetProcessorImpl.java 1 4 10
com/atlassian/gadgets/publisher/internal/impl/GadgetSpecProcessingWriter.java 0 2 2
com/atlassian/gadgets/publisher/internal/impl/GadgetSpecSyndicationImpl.java 3 12 5
com/atlassian/gadgets/publisher/internal/impl/GadgetSpecValidatorImpl.java 0 0 2
com/atlassian/gadgets/publisher/internal/impl/PublishedGadgetSpecStore.java 10 26 9
com/atlassian/gadgets/publisher/internal/rest/FeedWriter.java 3 8 3
com/atlassian/gadgets/publisher/internal/rest/GadgetSpecResource.java 0 1 4
com/atlassian/gadgets/publisher/internal/rest/GadgetSpecSyndicationResource.java 1 4 1
com/atlassian/gadgets/publisher/internal/transformer/TemplateTransformer.java 1 1 12

Rules

Rules Violations Severity
JavadocPackage 4 Errors Error
Translation 0 Errors Error
FileLength 0 Errors Error
FileTabCharacter
  • eachLine: "true"
 0 Errors Error
RegexpSingleline
  • message: "Line has trailing spaces."
  • format: "\s+$"
 52 Warnings Warning
AnnotationUseStyle 0 Errors Error
MissingDeprecated 0 Errors Error
MissingOverride
  • javaFiveCompatibility: "true"
 0 Errors Error
PackageAnnotation 0 Errors Error
JavadocMethod
  • excludeScope: "private"
  • scope: "anoninner"
 6 Errors Error
JavadocType
  • scope: "package"
 6 Errors Error
JavadocVariable
  • scope: "package"
 0 Errors Error
JavadocStyle
  • scope: "package"
 0 Errors Error
ConstantName 1 Errors Error
LocalFinalVariableName 0 Errors Error
LocalVariableName 0 Errors Error
MemberName 0 Errors Error
MethodName 0 Errors Error
PackageName 0 Errors Error
ParameterName 0 Errors Error
StaticVariableName 0 Errors Error
TypeName 0 Errors Error
AvoidStarImport 0 Errors Error
IllegalImport 0 Errors Error
ImportOrder
  • separated: "true"
  • groups: "java,javax,com.atlassian,com,org"
 15 Errors Error
RedundantImport 0 Errors Error
UnusedImports 2 Errors Error
LineLength
  • max: "120"
 17 Warnings Warning
MethodLength 0 Errors Error
ParameterNumber 0 Errors Error
EmptyForIteratorPad 0 Errors Error
MethodParamPad 0 Errors Error
NoWhitespaceAfter 0 Errors Error
NoWhitespaceBefore 0 Errors Error
OperatorWrap 0 Errors Error
ParenPad 0 Errors Error
TypecastParenPad 0 Errors Error
WhitespaceAfter 3 Errors Error
WhitespaceAround 4 Errors Error
ModifierOrder 0 Errors Error
RedundantModifier 0 Errors Error
AvoidNestedBlocks 0 Errors Error
EmptyBlock 0 Errors Error
LeftCurly
  • option: "nl"
 1 Errors Error
NeedBraces 0 Errors Error
RightCurly
  • option: "alone"
 0 Errors Error
DeclarationOrder 5 Errors Error
DefaultComesLast 0 Errors Error
DoubleCheckedLocking 0 Errors Error
EmptyStatement 0 Errors Error
EqualsHashCode 0 Errors Error
ExplicitInitialization 1 Errors Error
FallThrough 0 Errors Error
HiddenField
  • ignoreConstructorParameter: "true"
  • ignoreSetter: "true"
 0 Errors Error
IllegalInstantiation 0 Errors Error
InnerAssignment 0 Errors Error
MagicNumber 0 Errors Error
MissingSwitchDefault 0 Errors Error
ParameterAssignment 1 Errors Error
RedundantThrows
  • allowUnchecked: "true"
 0 Errors Error
SimplifyBooleanExpression 0 Errors Error
SimplifyBooleanReturn 0 Errors Error
StringLiteralEquality 0 Errors Error
DesignForExtension 21 Infos Info
FinalClass 0 Errors Error
HideUtilityClassConstructor 0 Errors Error
InterfaceIsType 0 Errors Error
VisibilityModifier 0 Errors Error
BooleanExpressionComplexity 0 Errors Error
ClassDataAbstractionCoupling 1 Errors Error
ClassFanOutComplexity
  • max: "10"
 6 Errors Error
CyclomaticComplexity 0 Errors Error
NPathComplexity
  • max: "20"
 0 Errors Error
JavaNCSS 0 Errors Error
ArrayTypeStyle 1 Errors Error
Indentation 5 Errors Error
TodoComment 0 Errors Error
UpperEll 0 Errors Error

Details

com/atlassian/gadgets/publisher/internal/GadgetModuleDescriptor.java

Violation Message Line
Errors Unused import - com.atlassian.plugin.util.validation.ValidationException. 7
Errors Wrong order for 'com.atlassian.plugin.util.validation.ValidationPattern.test' import. 12
Errors 'com.google.common.base.Preconditions.checkNotNull' should be separated from previous imports. 13
Warnings Line is longer than 120 characters. 28

com/atlassian/gadgets/publisher/internal/GadgetSpecSyndication.java

Violation Message Line
Warnings Line has trailing spaces. 12

com/atlassian/gadgets/publisher/internal/GadgetSpecValidator.java

Violation Message Line
Errors Missing package-info.java file. 0

com/atlassian/gadgets/publisher/internal/PluginGadgetFinder.java

Violation Message Line
Errors 'org.apache.commons.logging.Log' should be separated from previous imports. 10
Errors Wrong order for 'java.util.concurrent.ExecutorService' import. 14
Warnings Line is longer than 120 characters. 24
Warnings Line is longer than 120 characters. 54
Errors Class Fan-Out Complexity is 14 (max allowed is 10). 57
Warnings Line is longer than 120 characters. 89
Errors Missing a Javadoc comment. 95
Errors Missing a Javadoc comment. 99
Errors Missing a Javadoc comment. 107
Infos Method 'destroy' is not designed for extension - needs to be abstract, final or empty. 170

com/atlassian/gadgets/publisher/internal/PublishedGadgetSpecNotFoundException.java

Violation Message Line
Errors Missing a Javadoc comment. 5

com/atlassian/gadgets/publisher/internal/impl/AggregatePluginGadgetSpecProviderPermissionImpl.java

Violation Message Line
Errors Wrong order for 'com.google.common.base.Preconditions.checkNotNull' import. 9
Warnings Line has trailing spaces. 14
Warnings Line has trailing spaces. 19
Warnings Line has trailing spaces. 24
Infos Method 'voteOn' is not designed for extension - needs to be abstract, final or empty. 25
Errors Missing a Javadoc comment. 29
Warnings Line has trailing spaces. 35
Warnings Line has trailing spaces. 46
Warnings Line has trailing spaces. 59
Errors Missing a Javadoc comment. 70

com/atlassian/gadgets/publisher/internal/impl/GadgetProcessorImpl.java

Violation Message Line
Errors Wrong order for 'com.google.common.base.Preconditions.checkNotNull' import. 31
Errors 'org.apache.commons.lang.StringEscapeUtils.escapeXml' should be separated from previous imports. 32
Errors Class Fan-Out Complexity is 21 (max allowed is 10). 38
Errors method call rparen at indentation level 12 not at correct indentation, 4 52
Errors method call rparen at indentation level 12 not at correct indentation, 4 59
Warnings Line is longer than 120 characters. 62
Errors method call rparen at indentation level 12 not at correct indentation, 4 64
Warnings Line has trailing spaces. 74
Infos Method 'process' is not designed for extension - needs to be abstract, final or empty. 100
Warnings Line is longer than 120 characters. 225
Warnings Line has trailing spaces. 256
Errors Static variable definition in wrong order. 270
Errors Static variable definition in wrong order. 271
Errors Static variable definition in wrong order. 272
Errors Static variable definition in wrong order. 273

com/atlassian/gadgets/publisher/internal/impl/GadgetSpecProcessingWriter.java

Violation Message Line
Errors Wrong order for 'com.google.common.base.Preconditions.checkNotNull' import. 13
Errors Missing a Javadoc comment. 15
Warnings Line has trailing spaces. 18
Warnings Line has trailing spaces. 28

com/atlassian/gadgets/publisher/internal/impl/GadgetSpecSyndicationImpl.java

Violation Message Line
Errors Missing a Javadoc comment. 26
Errors Class Fan-Out Complexity is 13 (max allowed is 10). 26
Warnings Line has trailing spaces. 29
Warnings Line has trailing spaces. 34
Warnings Line has trailing spaces. 37
Warnings Line has trailing spaces. 50
Infos Method 'getFeed' is not designed for extension - needs to be abstract, final or empty. 51
Warnings Line has trailing spaces. 57
Warnings Line is longer than 120 characters. 63
Warnings Line has trailing spaces. 64
Warnings Line has trailing spaces. 66
Warnings Line has trailing spaces. 90
Warnings Line is longer than 120 characters. 91
Errors Instance variable definition in wrong order. 91
Errors Missing a Javadoc comment. 93
Warnings Line is longer than 120 characters. 95
Warnings Line has trailing spaces. 96
Errors Missing a Javadoc comment. 105
Infos Method 'pluginGadgetSpecEnabled' is not designed for extension - needs to be abstract, final or empty. 115
Infos Method 'pluginGadgetSpecDisabled' is not designed for extension - needs to be abstract, final or empty. 125

com/atlassian/gadgets/publisher/internal/impl/GadgetSpecValidatorImpl.java

Violation Message Line
Errors Missing package-info.java file. 0
Errors Wrong order for 'com.google.common.base.Preconditions.checkNotNull' import. 16

com/atlassian/gadgets/publisher/internal/impl/PublishedGadgetSpecStore.java

Violation Message Line
Errors Unused import - com.atlassian.gadgets.spec.GadgetSpec. 28
Errors 'com.google.common.base.Function' should be separated from previous imports. 33
Errors Wrong order for 'com.google.common.base.Preconditions.checkNotNull' import. 43
Errors 'org.apache.commons.io.IOUtils.closeQuietly' should be separated from previous imports. 46
Errors Class Data Abstraction Coupling is 8 (max allowed is 7) classes [AllowedPluginGadgetSpec, ConcurrentHashMap, GadgetParsingException, GadgetSpecUriNotAllowedException, PluginGadgetSpec.Key, PluginGadgetSpecStore, PluginGadgetSpecToUri, PublishedGadgetSpecNotFoundException]. 51
Errors Class Fan-Out Complexity is 24 (max allowed is 10). 51
Warnings Line is longer than 120 characters. 59
Errors Variable 'pluginSystemStarted' explicitly initialized to 'false' (default value for its type). 62
Warnings Line has trailing spaces. 75
Infos Method 'onStart' is not designed for extension - needs to be abstract, final or empty. 87
Errors '{' should be on a new line. 90
Infos Method 'getAll' is not designed for extension - needs to be abstract, final or empty. 115
Infos Method 'contains' is not designed for extension - needs to be abstract, final or empty. 120
Warnings Line has trailing spaces. 136
Infos Method 'entries' is not designed for extension - needs to be abstract, final or empty. 147
Warnings Line has trailing spaces. 151
Warnings Line has trailing spaces. 164
Warnings Line has trailing spaces. 169
Infos Method 'writeGadgetSpecTo' is not designed for extension - needs to be abstract, final or empty. 197
Infos Method 'writeGadgetSpecTo' is not designed for extension - needs to be abstract, final or empty. 205
Warnings Line has trailing spaces. 212
Infos Method 'getLastModified' is not designed for extension - needs to be abstract, final or empty. 213
Warnings Line is longer than 120 characters. 218
Infos Method 'pluginGadgetSpecEnabled' is not designed for extension - needs to be abstract, final or empty. 240
Infos Method 'pluginGadgetSpecDisabled' is not designed for extension - needs to be abstract, final or empty. 263
Warnings Line has trailing spaces. 282
Infos Method 'toString' is not designed for extension - needs to be abstract, final or empty. 283
Warnings Line has trailing spaces. 288
Errors Class Fan-Out Complexity is 14 (max allowed is 10). 289
Warnings Line has trailing spaces. 330
Warnings Line has trailing spaces. 334
Warnings Line has trailing spaces. 338
Warnings Line has trailing spaces. 354
Warnings Line is longer than 120 characters. 368
Warnings Line has trailing spaces. 372
Warnings Line is longer than 120 characters. 392
Warnings Line is longer than 120 characters. 393
Warnings Line has trailing spaces. 407
Warnings Line has trailing spaces. 411
Warnings Line has trailing spaces. 418
Warnings Line has trailing spaces. 424
Warnings Line has trailing spaces. 429
Warnings Line has trailing spaces. 435
Warnings Line has trailing spaces. 437
Warnings Line is longer than 120 characters. 445

com/atlassian/gadgets/publisher/internal/rest/FeedWriter.java

Violation Message Line
Errors Missing a Javadoc comment. 19
Errors Class Fan-Out Complexity is 13 (max allowed is 10). 19
Infos Method 'getSize' is not designed for extension - needs to be abstract, final or empty. 25
Infos Method 'isWriteable' is not designed for extension - needs to be abstract, final or empty. 30
Infos Method 'writeTo' is not designed for extension - needs to be abstract, final or empty. 35
Warnings Line has trailing spaces. 36
Warnings Line has trailing spaces. 37
Warnings Line has trailing spaces. 38
Warnings Line has trailing spaces. 39
Errors Array brackets at illegal position. 39
Warnings Line has trailing spaces. 40
Warnings Line is longer than 120 characters. 44
Warnings Line has trailing spaces. 56
Warnings Line has trailing spaces. 69

com/atlassian/gadgets/publisher/internal/rest/GadgetSpecResource.java

Violation Message Line
Errors Missing package-info.java file. 0
Errors Wrong order for 'javax.ws.rs.core.Response.Status.NOT_FOUND' import. 20
Errors Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 28
Errors Assignment of parameter 'pluginKey' is not allowed. 56
Warnings Line has trailing spaces. 74

com/atlassian/gadgets/publisher/internal/rest/GadgetSpecSyndicationResource.java

Violation Message Line
Errors Missing a Javadoc comment. 19
Warnings Line has trailing spaces. 23
Warnings Line has trailing spaces. 28
Infos Method 'get' is not designed for extension - needs to be abstract, final or empty. 29
Warnings Line has trailing spaces. 42
Warnings Line has trailing spaces. 47

com/atlassian/gadgets/publisher/internal/transformer/TemplateTransformer.java

Violation Message Line
Errors Missing package-info.java file. 0
Errors 'org.dom4j.Element' should be separated from previous imports. 7
Errors Wrong order for 'java.util.LinkedHashMap' import. 9
Warnings Line is longer than 120 characters. 18
Infos Method 'transform' is not designed for extension - needs to be abstract, final or empty. 18
Errors ',' is not followed by whitespace. 28
Errors ',' is not followed by whitespace. 28
Errors '{' is not followed by whitespace. 29
Errors '{' is not preceded with whitespace. 29
Errors block rcurly at indentation level 8 not at correct indentation, 12 34
Errors object def rcurly at indentation level 9 not at correct indentation, [8, 12] 34
Errors '}' is not followed by whitespace. 34
Errors '}' is not preceded with whitespace. 34
Errors ',' is not followed by whitespace. 45