The following document contains the results of Checkstyle.
Files | Infos | Warnings | Errors |
---|---|---|---|
17 | 21 | 69 | 62 |
Rules | Violations | Severity |
---|---|---|
JavadocPackage | 4 | Error |
Translation | 0 | Error |
FileLength | 0 | Error |
FileTabCharacter
|
0 | Error |
RegexpSingleline
|
52 | Warning |
AnnotationUseStyle | 0 | Error |
MissingDeprecated | 0 | Error |
MissingOverride
|
0 | Error |
PackageAnnotation | 0 | Error |
JavadocMethod
|
6 | Error |
JavadocType
|
6 | Error |
JavadocVariable
|
0 | Error |
JavadocStyle
|
0 | Error |
ConstantName | 1 | Error |
LocalFinalVariableName | 0 | Error |
LocalVariableName | 0 | Error |
MemberName | 0 | Error |
MethodName | 0 | Error |
PackageName | 0 | Error |
ParameterName | 0 | Error |
StaticVariableName | 0 | Error |
TypeName | 0 | Error |
AvoidStarImport | 0 | Error |
IllegalImport | 0 | Error |
ImportOrder
|
15 | Error |
RedundantImport | 0 | Error |
UnusedImports | 2 | Error |
LineLength
|
17 | Warning |
MethodLength | 0 | Error |
ParameterNumber | 0 | Error |
EmptyForIteratorPad | 0 | Error |
MethodParamPad | 0 | Error |
NoWhitespaceAfter | 0 | Error |
NoWhitespaceBefore | 0 | Error |
OperatorWrap | 0 | Error |
ParenPad | 0 | Error |
TypecastParenPad | 0 | Error |
WhitespaceAfter | 3 | Error |
WhitespaceAround | 4 | Error |
ModifierOrder | 0 | Error |
RedundantModifier | 0 | Error |
AvoidNestedBlocks | 0 | Error |
EmptyBlock | 0 | Error |
LeftCurly
|
1 | Error |
NeedBraces | 0 | Error |
RightCurly
|
0 | Error |
DeclarationOrder | 5 | Error |
DefaultComesLast | 0 | Error |
DoubleCheckedLocking | 0 | Error |
EmptyStatement | 0 | Error |
EqualsHashCode | 0 | Error |
ExplicitInitialization | 1 | Error |
FallThrough | 0 | Error |
HiddenField
|
0 | Error |
IllegalInstantiation | 0 | Error |
InnerAssignment | 0 | Error |
MagicNumber | 0 | Error |
MissingSwitchDefault | 0 | Error |
ParameterAssignment | 1 | Error |
RedundantThrows
|
0 | Error |
SimplifyBooleanExpression | 0 | Error |
SimplifyBooleanReturn | 0 | Error |
StringLiteralEquality | 0 | Error |
DesignForExtension | 21 | Info |
FinalClass | 0 | Error |
HideUtilityClassConstructor | 0 | Error |
InterfaceIsType | 0 | Error |
VisibilityModifier | 0 | Error |
BooleanExpressionComplexity | 0 | Error |
ClassDataAbstractionCoupling | 1 | Error |
ClassFanOutComplexity
|
6 | Error |
CyclomaticComplexity | 0 | Error |
NPathComplexity
|
0 | Error |
JavaNCSS | 0 | Error |
ArrayTypeStyle | 1 | Error |
Indentation | 5 | Error |
TodoComment | 0 | Error |
UpperEll | 0 | Error |
Violation | Message | Line |
---|---|---|
Unused import - com.atlassian.plugin.util.validation.ValidationException. | 7 | |
Wrong order for 'com.atlassian.plugin.util.validation.ValidationPattern.test' import. | 12 | |
'com.google.common.base.Preconditions.checkNotNull' should be separated from previous imports. | 13 | |
Line is longer than 120 characters. | 28 |
Violation | Message | Line |
---|---|---|
Missing package-info.java file. | 0 | |
Line has trailing spaces. | 12 |
Violation | Message | Line |
---|---|---|
'org.apache.commons.logging.Log' should be separated from previous imports. | 10 | |
Wrong order for 'java.util.concurrent.ExecutorService' import. | 14 | |
Line is longer than 120 characters. | 24 | |
Line is longer than 120 characters. | 54 | |
Class Fan-Out Complexity is 14 (max allowed is 10). | 57 | |
Line is longer than 120 characters. | 89 | |
Missing a Javadoc comment. | 95 | |
Missing a Javadoc comment. | 99 | |
Missing a Javadoc comment. | 107 | |
Method 'destroy' is not designed for extension - needs to be abstract, final or empty. | 170 |
Violation | Message | Line |
---|---|---|
Missing a Javadoc comment. | 5 |
Violation | Message | Line |
---|---|---|
Wrong order for 'com.google.common.base.Preconditions.checkNotNull' import. | 9 | |
Line has trailing spaces. | 14 | |
Line has trailing spaces. | 19 | |
Line has trailing spaces. | 24 | |
Method 'voteOn' is not designed for extension - needs to be abstract, final or empty. | 25 | |
Missing a Javadoc comment. | 29 | |
Line has trailing spaces. | 35 | |
Line has trailing spaces. | 46 | |
Line has trailing spaces. | 59 | |
Missing a Javadoc comment. | 70 |
Violation | Message | Line |
---|---|---|
Wrong order for 'com.google.common.base.Preconditions.checkNotNull' import. | 31 | |
'org.apache.commons.lang.StringEscapeUtils.escapeXml' should be separated from previous imports. | 32 | |
Class Fan-Out Complexity is 21 (max allowed is 10). | 38 | |
method call rparen at indentation level 12 not at correct indentation, 4 | 52 | |
method call rparen at indentation level 12 not at correct indentation, 4 | 59 | |
Line is longer than 120 characters. | 62 | |
method call rparen at indentation level 12 not at correct indentation, 4 | 64 | |
Line has trailing spaces. | 74 | |
Method 'process' is not designed for extension - needs to be abstract, final or empty. | 100 | |
Line is longer than 120 characters. | 225 | |
Line has trailing spaces. | 256 | |
Static variable definition in wrong order. | 270 | |
Static variable definition in wrong order. | 271 | |
Static variable definition in wrong order. | 272 | |
Static variable definition in wrong order. | 273 |
Violation | Message | Line |
---|---|---|
Wrong order for 'com.google.common.base.Preconditions.checkNotNull' import. | 13 | |
Missing a Javadoc comment. | 15 | |
Line has trailing spaces. | 18 | |
Line has trailing spaces. | 28 |
Violation | Message | Line |
---|---|---|
Missing a Javadoc comment. | 26 | |
Class Fan-Out Complexity is 13 (max allowed is 10). | 26 | |
Line has trailing spaces. | 29 | |
Line has trailing spaces. | 34 | |
Line has trailing spaces. | 37 | |
Line has trailing spaces. | 50 | |
Method 'getFeed' is not designed for extension - needs to be abstract, final or empty. | 51 | |
Line has trailing spaces. | 57 | |
Line is longer than 120 characters. | 63 | |
Line has trailing spaces. | 64 | |
Line has trailing spaces. | 66 | |
Line has trailing spaces. | 90 | |
Line is longer than 120 characters. | 91 | |
Instance variable definition in wrong order. | 91 | |
Missing a Javadoc comment. | 93 | |
Line is longer than 120 characters. | 95 | |
Line has trailing spaces. | 96 | |
Missing a Javadoc comment. | 105 | |
Method 'pluginGadgetSpecEnabled' is not designed for extension - needs to be abstract, final or empty. | 115 | |
Method 'pluginGadgetSpecDisabled' is not designed for extension - needs to be abstract, final or empty. | 125 |
Violation | Message | Line |
---|---|---|
Missing package-info.java file. | 0 | |
Wrong order for 'com.google.common.base.Preconditions.checkNotNull' import. | 16 |
Violation | Message | Line |
---|---|---|
Unused import - com.atlassian.gadgets.spec.GadgetSpec. | 28 | |
'com.google.common.base.Function' should be separated from previous imports. | 33 | |
Wrong order for 'com.google.common.base.Preconditions.checkNotNull' import. | 43 | |
'org.apache.commons.io.IOUtils.closeQuietly' should be separated from previous imports. | 46 | |
Class Data Abstraction Coupling is 8 (max allowed is 7) classes [AllowedPluginGadgetSpec, ConcurrentHashMap, GadgetParsingException, GadgetSpecUriNotAllowedException, PluginGadgetSpec.Key, PluginGadgetSpecStore, PluginGadgetSpecToUri, PublishedGadgetSpecNotFoundException]. | 51 | |
Class Fan-Out Complexity is 24 (max allowed is 10). | 51 | |
Line is longer than 120 characters. | 59 | |
Variable 'pluginSystemStarted' explicitly initialized to 'false' (default value for its type). | 62 | |
Line has trailing spaces. | 75 | |
Method 'onStart' is not designed for extension - needs to be abstract, final or empty. | 87 | |
'{' should be on a new line. | 90 | |
Method 'getAll' is not designed for extension - needs to be abstract, final or empty. | 115 | |
Method 'contains' is not designed for extension - needs to be abstract, final or empty. | 120 | |
Line has trailing spaces. | 136 | |
Method 'entries' is not designed for extension - needs to be abstract, final or empty. | 147 | |
Line has trailing spaces. | 151 | |
Line has trailing spaces. | 164 | |
Line has trailing spaces. | 169 | |
Method 'writeGadgetSpecTo' is not designed for extension - needs to be abstract, final or empty. | 197 | |
Method 'writeGadgetSpecTo' is not designed for extension - needs to be abstract, final or empty. | 205 | |
Line has trailing spaces. | 212 | |
Method 'getLastModified' is not designed for extension - needs to be abstract, final or empty. | 213 | |
Line is longer than 120 characters. | 218 | |
Method 'pluginGadgetSpecEnabled' is not designed for extension - needs to be abstract, final or empty. | 240 | |
Method 'pluginGadgetSpecDisabled' is not designed for extension - needs to be abstract, final or empty. | 263 | |
Line has trailing spaces. | 282 | |
Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 283 | |
Line has trailing spaces. | 288 | |
Class Fan-Out Complexity is 14 (max allowed is 10). | 289 | |
Line has trailing spaces. | 330 | |
Line has trailing spaces. | 334 | |
Line has trailing spaces. | 338 | |
Line has trailing spaces. | 354 | |
Line is longer than 120 characters. | 368 | |
Line has trailing spaces. | 372 | |
Line is longer than 120 characters. | 392 | |
Line is longer than 120 characters. | 393 | |
Line has trailing spaces. | 407 | |
Line has trailing spaces. | 411 | |
Line has trailing spaces. | 418 | |
Line has trailing spaces. | 424 | |
Line has trailing spaces. | 429 | |
Line has trailing spaces. | 435 | |
Line has trailing spaces. | 437 | |
Line is longer than 120 characters. | 445 |
Violation | Message | Line |
---|---|---|
Missing package-info.java file. | 0 | |
Missing a Javadoc comment. | 19 | |
Class Fan-Out Complexity is 13 (max allowed is 10). | 19 | |
Method 'getSize' is not designed for extension - needs to be abstract, final or empty. | 25 | |
Method 'isWriteable' is not designed for extension - needs to be abstract, final or empty. | 30 | |
Method 'writeTo' is not designed for extension - needs to be abstract, final or empty. | 35 | |
Line has trailing spaces. | 36 | |
Line has trailing spaces. | 37 | |
Line has trailing spaces. | 38 | |
Line has trailing spaces. | 39 | |
Array brackets at illegal position. | 39 | |
Line has trailing spaces. | 40 | |
Line is longer than 120 characters. | 44 | |
Line has trailing spaces. | 56 | |
Line has trailing spaces. | 69 |
Violation | Message | Line |
---|---|---|
Wrong order for 'javax.ws.rs.core.Response.Status.NOT_FOUND' import. | 20 | |
Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 28 | |
Assignment of parameter 'pluginKey' is not allowed. | 56 | |
Line has trailing spaces. | 74 |
Violation | Message | Line |
---|---|---|
Missing a Javadoc comment. | 19 | |
Line has trailing spaces. | 23 | |
Line has trailing spaces. | 28 | |
Method 'get' is not designed for extension - needs to be abstract, final or empty. | 29 | |
Line has trailing spaces. | 42 | |
Line has trailing spaces. | 47 |
Violation | Message | Line |
---|---|---|
Missing package-info.java file. | 0 | |
'org.dom4j.Element' should be separated from previous imports. | 7 | |
Wrong order for 'java.util.LinkedHashMap' import. | 9 | |
Line is longer than 120 characters. | 18 | |
Method 'transform' is not designed for extension - needs to be abstract, final or empty. | 18 | |
',' is not followed by whitespace. | 28 | |
',' is not followed by whitespace. | 28 | |
'{' is not followed by whitespace. | 29 | |
'{' is not preceded with whitespace. | 29 | |
block rcurly at indentation level 8 not at correct indentation, 12 | 34 | |
object def rcurly at indentation level 9 not at correct indentation, [8, 12] | 34 | |
'}' is not followed by whitespace. | 34 | |
'}' is not preceded with whitespace. | 34 | |
',' is not followed by whitespace. | 45 |