The following document contains the results of Checkstyle.
Files | Infos | Warnings | Errors |
---|---|---|---|
14 | 13 | 20 | 56 |
Rules | Violations | Severity |
---|---|---|
JavadocPackage | 3 | Error |
Translation | 0 | Error |
FileLength | 0 | Error |
FileTabCharacter
|
0 | Error |
RegexpSingleline
|
15 | Warning |
AnnotationUseStyle | 0 | Error |
MissingDeprecated | 0 | Error |
MissingOverride
|
0 | Error |
PackageAnnotation | 0 | Error |
JavadocMethod
|
1 | Error |
JavadocType
|
4 | Error |
JavadocVariable
|
0 | Error |
JavadocStyle
|
0 | Error |
ConstantName | 1 | Error |
LocalFinalVariableName | 0 | Error |
LocalVariableName | 0 | Error |
MemberName | 0 | Error |
MethodName | 0 | Error |
PackageName | 0 | Error |
ParameterName | 0 | Error |
StaticVariableName | 0 | Error |
TypeName | 0 | Error |
AvoidStarImport | 0 | Error |
IllegalImport | 0 | Error |
ImportOrder
|
23 | Error |
RedundantImport | 0 | Error |
UnusedImports | 1 | Error |
LineLength
|
5 | Warning |
MethodLength | 0 | Error |
ParameterNumber | 0 | Error |
EmptyForIteratorPad | 0 | Error |
MethodParamPad | 0 | Error |
NoWhitespaceAfter | 0 | Error |
NoWhitespaceBefore | 0 | Error |
OperatorWrap | 0 | Error |
ParenPad | 0 | Error |
TypecastParenPad | 0 | Error |
WhitespaceAfter | 2 | Error |
WhitespaceAround | 7 | Error |
ModifierOrder | 0 | Error |
RedundantModifier | 0 | Error |
AvoidNestedBlocks | 0 | Error |
EmptyBlock | 0 | Error |
LeftCurly
|
0 | Error |
NeedBraces | 0 | Error |
RightCurly
|
0 | Error |
DeclarationOrder | 4 | Error |
DefaultComesLast | 0 | Error |
DoubleCheckedLocking | 0 | Error |
EmptyStatement | 0 | Error |
EqualsHashCode | 0 | Error |
ExplicitInitialization | 0 | Error |
FallThrough | 0 | Error |
HiddenField
|
0 | Error |
IllegalInstantiation | 0 | Error |
InnerAssignment | 0 | Error |
MagicNumber | 0 | Error |
MissingSwitchDefault | 0 | Error |
ParameterAssignment | 1 | Error |
RedundantThrows
|
0 | Error |
SimplifyBooleanExpression | 0 | Error |
SimplifyBooleanReturn | 0 | Error |
StringLiteralEquality | 0 | Error |
DesignForExtension | 13 | Info |
FinalClass | 0 | Error |
HideUtilityClassConstructor | 2 | Error |
InterfaceIsType | 0 | Error |
VisibilityModifier | 0 | Error |
BooleanExpressionComplexity | 0 | Error |
ClassDataAbstractionCoupling | 1 | Error |
ClassFanOutComplexity
|
3 | Error |
CyclomaticComplexity | 0 | Error |
NPathComplexity
|
0 | Error |
JavaNCSS | 0 | Error |
ArrayTypeStyle | 0 | Error |
Indentation | 3 | Error |
TodoComment | 0 | Error |
UpperEll | 0 | Error |
Violation | Message | Line |
---|---|---|
Unused import - com.atlassian.plugin.util.validation.ValidationException. | 6 | |
Wrong order for 'com.atlassian.plugin.descriptors.AbstractModuleDescriptor' import. | 9 | |
'org.dom4j.Element' should be separated from previous imports. | 12 | |
Line is longer than 120 characters. | 27 |
Violation | Message | Line |
---|---|---|
Wrong order for 'javax.ws.rs.GET' import. | 5 | |
Wrong order for 'javax.ws.rs.Path' import. | 7 | |
Wrong order for 'java.io.ByteArrayOutputStream' import. | 12 | |
Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 24 | |
Assignment of parameter 'pluginKey' is not allowed. | 52 | |
Line has trailing spaces. | 70 |
Violation | Message | Line |
---|---|---|
Wrong order for 'java.util.regex.Matcher' import. | 5 | |
Missing a Javadoc comment. | 9 | |
Method 'getLocale' is not designed for extension - needs to be abstract, final or empty. | 34 |
Violation | Message | Line |
---|---|---|
Wrong order for 'javax.ws.rs.GET' import. | 7 | |
Wrong order for 'java.util.Arrays' import. | 13 | |
Method 'getMessages' is not designed for extension - needs to be abstract, final or empty. | 42 | |
'}' is not preceded with whitespace. | 44 | |
',' is not followed by whitespace. | 48 |
Violation | Message | Line |
---|---|---|
'org.apache.commons.logging.Log' should be separated from previous imports. | 15 | |
Line is longer than 120 characters. | 21 | |
Line is longer than 120 characters. | 51 | |
Class Fan-Out Complexity is 11 (max allowed is 10). | 54 | |
Method 'pluginModuleEnabled' is not designed for extension - needs to be abstract, final or empty. | 100 | |
Method 'pluginModuleDisabled' is not designed for extension - needs to be abstract, final or empty. | 122 |
Violation | Message | Line |
---|---|---|
Missing a Javadoc comment. | 3 |
Violation | Message | Line |
---|---|---|
Missing package-info.java file. | 0 | |
Wrong order for 'java.io.IOException' import. | 4 |
Violation | Message | Line |
---|---|---|
Missing package-info.java file. | 0 | |
Wrong order for 'com.atlassian.gadgets.plugins.PluginGadgetSpec' import. | 7 | |
Line has trailing spaces. | 14 | |
Line has trailing spaces. | 19 | |
Line has trailing spaces. | 24 | |
Method 'voteOn' is not designed for extension - needs to be abstract, final or empty. | 25 | |
Missing a Javadoc comment. | 29 | |
Line has trailing spaces. | 35 | |
Line has trailing spaces. | 46 | |
Line has trailing spaces. | 59 | |
Missing a Javadoc comment. | 70 |
Violation | Message | Line |
---|---|---|
Wrong order for 'java.io.IOException' import. | 5 | |
Wrong order for 'com.atlassian.gadgets.GadgetParsingException' import. | 20 | |
Wrong order for 'com.atlassian.plugin.webresource.UrlMode' import. | 24 | |
Class Fan-Out Complexity is 14 (max allowed is 10). | 32 | |
method call rparen at indentation level 12 not at correct indentation, 4 | 46 | |
method call rparen at indentation level 12 not at correct indentation, 4 | 53 | |
Line is longer than 120 characters. | 56 | |
method call rparen at indentation level 12 not at correct indentation, 4 | 58 | |
Line has trailing spaces. | 68 | |
Method 'process' is not designed for extension - needs to be abstract, final or empty. | 90 | |
'for' is not followed by whitespace. | 146 | |
Line is longer than 120 characters. | 158 | |
',' is not followed by whitespace. | 195 | |
Line has trailing spaces. | 248 | |
Static variable definition in wrong order. | 262 | |
Static variable definition in wrong order. | 263 | |
Static variable definition in wrong order. | 264 | |
Static variable definition in wrong order. | 265 |
Violation | Message | Line |
---|---|---|
'org.apache.commons.logging.Log' should be separated from previous imports. | 12 |
Violation | Message | Line |
---|---|---|
Wrong order for 'com.google.common.collect.Iterables.filter' import. | 5 | |
Wrong order for 'java.io.BufferedInputStream' import. | 7 | |
Wrong order for 'com.atlassian.gadgets.GadgetParsingException' import. | 21 | |
'com.google.common.base.Function' should be separated from previous imports. | 33 | |
Class Data Abstraction Coupling is 10 (max allowed is 7) classes [AllowedPluginGadgetSpec, BufferedInputStream, BufferedOutputStream, ByteArrayInputStream, ByteArrayOutputStream, GadgetParsingException, PluginGadgetSpec.Key, PluginGadgetSpecToUri, PublishedGadgetSpecNotFoundException, ReentrantReadWriteLock]. | 40 | |
Class Fan-Out Complexity is 25 (max allowed is 10). | 40 | |
Method 'contains' is not designed for extension - needs to be abstract, final or empty. | 62 | |
Method 'entries' is not designed for extension - needs to be abstract, final or empty. | 84 | |
Line has trailing spaces. | 96 | |
Line has trailing spaces. | 101 | |
Line has trailing spaces. | 109 | |
Line has trailing spaces. | 114 | |
Method 'writeGadgetSpecTo' is not designed for extension - needs to be abstract, final or empty. | 142 | |
Line has trailing spaces. | 161 | |
Method 'write' is not designed for extension - needs to be abstract, final or empty. | 162 | |
Method 'pluginGadgetSpecEnabled' is not designed for extension - needs to be abstract, final or empty. | 183 | |
Method 'pluginGadgetSpecDisabled' is not designed for extension - needs to be abstract, final or empty. | 203 | |
Line has trailing spaces. | 221 | |
Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 222 |
Violation | Message | Line |
---|---|---|
Missing package-info.java file. | 0 | |
Wrong order for 'javax.xml.bind.annotation.XmlElement' import. | 7 | |
Wrong order for 'javax.xml.bind.annotation.XmlAttribute' import. | 8 | |
Wrong order for 'com.google.common.collect.ImmutableList' import. | 12 | |
Wrong order for 'com.google.common.base.Function' import. | 13 | |
Missing a Javadoc comment. | 15 | |
Utility classes should not have a public or default constructor. | 15 | |
'}' is not preceded with whitespace. | 18 | |
'}' is not preceded with whitespace. | 23 | |
Utility classes should not have a public or default constructor. | 34 | |
'}' is not preceded with whitespace. | 36 | |
'}' is not preceded with whitespace. | 40 | |
'}' is not preceded with whitespace. | 45 |