The following document contains the results of Checkstyle.
Files | Infos | Warnings | Errors |
---|---|---|---|
41 | 62 | 172 | 450 |
Rules | Violations | Severity |
---|---|---|
JavadocPackage | 10 | Error |
Translation | 0 | Error |
FileLength | 0 | Error |
FileTabCharacter
|
0 | Error |
RegexpSingleline
|
70 | Warning |
AnnotationUseStyle | 0 | Error |
MissingDeprecated | 0 | Error |
MissingOverride
|
0 | Error |
PackageAnnotation | 0 | Error |
JavadocMethod
|
19 | Error |
JavadocType
|
19 | Error |
JavadocVariable
|
12 | Error |
JavadocStyle
|
18 | Error |
ConstantName | 2 | Error |
LocalFinalVariableName | 0 | Error |
LocalVariableName | 0 | Error |
MemberName | 0 | Error |
MethodName | 0 | Error |
PackageName | 0 | Error |
ParameterName | 0 | Error |
StaticVariableName | 0 | Error |
TypeName | 0 | Error |
AvoidStarImport | 0 | Error |
IllegalImport | 0 | Error |
ImportOrder
|
19 | Error |
RedundantImport | 0 | Error |
UnusedImports | 2 | Error |
LineLength
|
102 | Warning |
MethodLength | 0 | Error |
ParameterNumber | 0 | Error |
EmptyForIteratorPad | 0 | Error |
MethodParamPad | 1 | Error |
NoWhitespaceAfter | 2 | Error |
NoWhitespaceBefore | 0 | Error |
OperatorWrap | 6 | Error |
ParenPad | 0 | Error |
TypecastParenPad | 0 | Error |
WhitespaceAfter | 10 | Error |
WhitespaceAround | 20 | Error |
ModifierOrder | 7 | Error |
RedundantModifier | 0 | Error |
AvoidNestedBlocks | 0 | Error |
EmptyBlock | 1 | Error |
LeftCurly
|
46 | Error |
NeedBraces | 0 | Error |
RightCurly
|
4 | Error |
DeclarationOrder | 13 | Error |
DefaultComesLast | 0 | Error |
DoubleCheckedLocking | 0 | Error |
EmptyStatement | 0 | Error |
EqualsHashCode | 0 | Error |
ExplicitInitialization | 0 | Error |
FallThrough | 0 | Error |
HiddenField
|
2 | Error |
IllegalInstantiation | 0 | Error |
InnerAssignment | 0 | Error |
MagicNumber | 4 | Error |
MissingSwitchDefault | 2 | Error |
ParameterAssignment | 0 | Error |
RedundantThrows
|
3 | Error |
SimplifyBooleanExpression | 0 | Error |
SimplifyBooleanReturn | 0 | Error |
StringLiteralEquality | 0 | Error |
DesignForExtension | 62 | Info |
FinalClass | 1 | Error |
HideUtilityClassConstructor | 2 | Error |
InterfaceIsType | 0 | Error |
VisibilityModifier | 0 | Error |
BooleanExpressionComplexity | 1 | Error |
ClassDataAbstractionCoupling | 2 | Error |
ClassFanOutComplexity
|
11 | Error |
CyclomaticComplexity | 1 | Error |
NPathComplexity
|
5 | Error |
JavaNCSS | 0 | Error |
ArrayTypeStyle | 0 | Error |
Indentation | 207 | Error |
TodoComment | 0 | Error |
UpperEll | 0 | Error |
Violation | Message | Line |
---|---|---|
Wrong order for 'com.atlassian.gadgets.opensocial.internal.ShindigOpenSocialTypeAdapter.activityToShindigActivityFunction' import. | 31 | |
Line is longer than 120 characters. | 34 | |
Line is longer than 120 characters. | 39 | |
Class Fan-Out Complexity is 19 (max allowed is 10). | 41 | |
Line is longer than 120 characters. | 49 | |
Method 'getActivities' is not designed for extension - needs to be abstract, final or empty. | 57 | |
Line is longer than 120 characters. | 58 | |
Line is longer than 120 characters. | 62 | |
Missing a Javadoc comment. | 65 | |
Line is longer than 120 characters. | 68 | |
Line is longer than 120 characters. | 71 | |
Line is longer than 120 characters. | 72 | |
Line is longer than 120 characters. | 80 | |
Method 'getActivities' is not designed for extension - needs to be abstract, final or empty. | 80 | |
Line is longer than 120 characters. | 84 | |
Line is longer than 120 characters. | 85 | |
Missing a Javadoc comment. | 88 | |
Line is longer than 120 characters. | 91 | |
Line is longer than 120 characters. | 94 | |
Line is longer than 120 characters. | 95 | |
Line is longer than 120 characters. | 103 | |
Method 'getActivity' is not designed for extension - needs to be abstract, final or empty. | 103 | |
Line is longer than 120 characters. | 107 | |
Missing a Javadoc comment. | 110 | |
Line is longer than 120 characters. | 112 | |
Line is longer than 120 characters. | 114 | |
Line is longer than 120 characters. | 125 | |
Method 'deleteActivities' is not designed for extension - needs to be abstract, final or empty. | 125 | |
Line is longer than 120 characters. | 129 | |
Line is longer than 120 characters. | 130 | |
Missing a Javadoc comment. | 133 | |
Line is longer than 120 characters. | 136 | |
Line is longer than 120 characters. | 148 | |
Method 'createActivity' is not designed for extension - needs to be abstract, final or empty. | 148 | |
Line is longer than 120 characters. | 151 | |
Line is longer than 120 characters. | 155 | |
Line is longer than 120 characters. | 156 | |
Missing a Javadoc comment. | 159 | |
Line is longer than 120 characters. | 162 |
Violation | Message | Line |
---|---|---|
Line is longer than 120 characters. | 30 | |
Wrong order for 'com.atlassian.gadgets.opensocial.internal.ShindigOpenSocialTypeAdapter.convertShindigSecurityTokenToRequestContext' import. | 30 | |
First sentence should end with a period. | 33 | |
Line has trailing spaces. | 34 | |
Line is longer than 120 characters. | 34 | |
Class Fan-Out Complexity is 20 (max allowed is 10). | 36 | |
Static variable definition in wrong order. | 42 | |
Line is longer than 120 characters. | 45 | |
Method 'getPersonData' is not designed for extension - needs to be abstract, final or empty. | 53 | |
Line is longer than 120 characters. | 54 | |
Line is longer than 120 characters. | 58 | |
Line is longer than 120 characters. | 59 | |
Missing a Javadoc comment. | 61 | |
Line is longer than 120 characters. | 64 | |
Line is longer than 120 characters. | 91 | |
Method 'deletePersonData' is not designed for extension - needs to be abstract, final or empty. | 91 | |
Line is longer than 120 characters. | 95 | |
Line is longer than 120 characters. | 96 | |
Missing a Javadoc comment. | 100 | |
Line is longer than 120 characters. | 107 | |
Line is longer than 120 characters. | 111 | |
Line is longer than 120 characters. | 125 | |
Method 'updatePersonData' is not designed for extension - needs to be abstract, final or empty. | 125 | |
Line is longer than 120 characters. | 129 | |
Missing a Javadoc comment. | 132 | |
Line is longer than 120 characters. | 134 | |
Line is longer than 120 characters. | 138 |
Violation | Message | Line |
---|---|---|
First sentence should end with a period. | 30 | |
Class ShindigOpenSocialTypeAdapter should be declared as final. | 33 | |
Class Data Abstraction Coupling is 9 (max allowed is 7) classes [Activity.Builder, Function, HashSet, MediaItem.Builder, MediaItemImpl, NameImpl, OpenSocialRequestContext, PersonImpl, org.apache.shindig.social.core.model.ActivityImpl]. | 33 | |
Class Fan-Out Complexity is 23 (max allowed is 10). | 33 | |
First sentence should end with a period. | 40 | |
Line is longer than 120 characters. | 43 | |
Line is longer than 120 characters. | 52 | |
First sentence should end with a period. | 55 | |
Line is longer than 120 characters. | 59 | |
Line is longer than 120 characters. | 61 | |
Cyclomatic Complexity is 20 (max allowed is 10). | 61 | |
NPath Complexity is 131,072 (max allowed is 20). | 61 | |
Line is longer than 120 characters. | 68 | |
'cast' is not followed by whitespace. | 68 | |
Line is longer than 120 characters. | 69 | |
Line is longer than 120 characters. | 93 | |
First sentence should end with a period. | 140 | |
NPath Complexity is 32 (max allowed is 20). | 145 | |
First sentence should end with a period. | 184 | |
First sentence should end with a period. | 204 | |
Line is longer than 120 characters. | 209 | |
Missing a Javadoc comment. | 213 | |
Missing a Javadoc comment. | 218 | |
Missing a Javadoc comment. | 223 | |
Missing a Javadoc comment. | 228 | |
First sentence should end with a period. | 235 | |
Line is longer than 120 characters. | 244 | |
Line is longer than 120 characters. | 254 | |
Line is longer than 120 characters. | 266 | |
First sentence should end with a period. | 277 | |
Line is longer than 120 characters. | 282 | |
Missing a Javadoc comment. | 286 | |
First sentence should end with a period. | 293 | |
Line is longer than 120 characters. | 296 | |
Line has trailing spaces. | 306 | |
Line is longer than 120 characters. | 306 | |
First sentence should end with a period. | 310 | |
Line is longer than 120 characters. | 314 | |
Missing a Javadoc comment. | 318 | |
Line has trailing spaces. | 324 | |
First sentence should end with a period. | 325 | |
Line is longer than 120 characters. | 328 | |
First sentence should end with a period. | 343 | |
Line is longer than 120 characters. | 347 | |
Missing a Javadoc comment. | 351 |
Violation | Message | Line |
---|---|---|
Missing package-info.java file. | 0 | |
Wrong order for 'com.atlassian.gadgets.opensocial.internal.ShindigOpenSocialTypeAdapter.convertPersonToShindigPerson' import. | 28 | |
Line is longer than 120 characters. | 29 | |
Line is longer than 120 characters. | 34 | |
Class Fan-Out Complexity is 18 (max allowed is 10). | 36 | |
Static variable definition in wrong order. | 41 | |
Line is longer than 120 characters. | 44 | |
Missing a Javadoc comment. | 44 | |
Method 'getPeople' is not designed for extension - needs to be abstract, final or empty. | 59 | |
Line is longer than 120 characters. | 60 | |
',' is not followed by whitespace. | 60 | |
Missing a Javadoc comment. | 66 | |
Line is longer than 120 characters. | 73 | |
Line is longer than 120 characters. | 75 | |
Line is longer than 120 characters. | 85 | |
Line is longer than 120 characters. | 86 | |
Line is longer than 120 characters. | 94 | |
Method 'getPerson' is not designed for extension - needs to be abstract, final or empty. | 94 | |
Line is longer than 120 characters. | 98 | |
Missing a Javadoc comment. | 101 |
Violation | Message | Line |
---|---|---|
Missing package-info.java file. | 0 | |
First sentence should end with a period. | 21 | |
Line has trailing spaces. | 31 | |
Method 'configure' is not designed for extension - needs to be abstract, final or empty. | 38 |
Violation | Message | Line |
---|---|---|
'com.google.common.collect.ImmutableList' should be separated from previous imports. | 5 | |
'org.apache.shindig.common.ContainerConfig' should be separated from previous imports. | 10 | |
Wrong order for 'java.net.URI' import. | 16 | |
Line has trailing spaces. | 22 | |
Missing a Javadoc comment. | 27 | |
Utility classes should not have a public or default constructor. | 27 | |
Missing a Javadoc comment. | 29 | |
Missing a Javadoc comment. | 30 | |
Line has trailing spaces. | 32 | |
Missing a Javadoc comment. | 33 | |
Missing a Javadoc comment. | 34 | |
Missing a Javadoc comment. | 35 | |
Missing a Javadoc comment. | 36 | |
Line has trailing spaces. | 37 | |
Line has trailing spaces. | 42 | |
Line is longer than 120 characters. | 55 | |
Line is longer than 120 characters. | 108 | |
Line is longer than 120 characters. | 109 | |
Line is longer than 120 characters. | 112 | |
Line is longer than 120 characters. | 113 | |
Line is longer than 120 characters. | 134 | |
',' is not followed by whitespace. | 134 | |
Line has trailing spaces. | 142 | |
Line has trailing spaces. | 144 | |
Line has trailing spaces. | 145 | |
'(' is preceded with whitespace. | 153 | |
Line has trailing spaces. | 161 | |
Line has trailing spaces. | 163 | |
Line has trailing spaces. | 164 | |
Line has trailing spaces. | 204 | |
Line has trailing spaces. | 206 | |
Line has trailing spaces. | 207 | |
Method 'getContainers' is not designed for extension - needs to be abstract, final or empty. | 225 | |
Method 'getJson' is not designed for extension - needs to be abstract, final or empty. | 242 | |
Method 'get' is not designed for extension - needs to be abstract, final or empty. | 276 | |
Method 'getJsonObject' is not designed for extension - needs to be abstract, final or empty. | 282 | |
Method 'getJsonArray' is not designed for extension - needs to be abstract, final or empty. | 288 |
Violation | Message | Line |
---|---|---|
Unused import - org.apache.shindig.gadgets.oauth.GadgetOAuthCallbackGenerator. | 6 | |
Method 'generateCallback' is not designed for extension - needs to be abstract, final or empty. | 19 | |
Line has trailing spaces. | 22 | |
method def throws at indentation level 12 not at correct indentation, 8 | 23 |
Violation | Message | Line |
---|---|---|
Missing a Javadoc comment. | 16 | |
Line has trailing spaces. | 31 | |
Method 'getKey' is not designed for extension - needs to be abstract, final or empty. | 35 | |
Missing a Javadoc comment. | 40 | |
Line has trailing spaces. | 55 | |
Method 'unwrap' is not designed for extension - needs to be abstract, final or empty. | 56 | |
Method 'wrap' is not designed for extension - needs to be abstract, final or empty. | 61 |
Violation | Message | Line |
---|---|---|
Line has trailing spaces. | 21 | |
Method 'getDomain' is not designed for extension - needs to be abstract, final or empty. | 24 |
Violation | Message | Line |
---|---|---|
Missing a Javadoc comment. | 17 | |
Line has trailing spaces. | 26 | |
Method 'createToken' is not designed for extension - needs to be abstract, final or empty. | 32 | |
Line has trailing spaces. | 62 | |
Static variable definition in wrong order. | 63 | |
Static variable definition in wrong order. | 65 | |
Static variable definition in wrong order. | 66 | |
Static variable definition in wrong order. | 67 | |
Static variable definition in wrong order. | 68 | |
Static variable definition in wrong order. | 69 | |
Line has trailing spaces. | 74 | |
Line has trailing spaces. | 76 | |
Line has trailing spaces. | 82 |
Violation | Message | Line |
---|---|---|
Missing a Javadoc comment. | 6 |
Violation | Message | Line |
---|---|---|
Missing package-info.java file. | 0 | |
Missing a Javadoc comment. | 5 | |
Method 'getParameterValue' is not designed for extension - needs to be abstract, final or empty. | 14 | |
Method 'getName' is not designed for extension - needs to be abstract, final or empty. | 19 |
Violation | Message | Line |
---|---|---|
Wrong order for 'com.atlassian.gadgets.GadgetRequestContext.Builder.gadgetRequestContext' import. | 14 | |
Missing a Javadoc comment. | 21 | |
'static' modifier out of order with the JLS suggestions. | 21 | |
Missing a Javadoc comment. | 22 | |
'static' modifier out of order with the JLS suggestions. | 22 | |
Line has trailing spaces. | 30 | |
Line has trailing spaces. | 60 | |
Line is longer than 120 characters. | 61 |
Violation | Message | Line |
---|---|---|
Wrong order for 'com.google.common.base.Preconditions.checkNotNull' import. | 35 | |
Wrong order for 'java.util.Collections.unmodifiableCollection' import. | 38 | |
Class Fan-Out Complexity is 23 (max allowed is 10). | 44 | |
Line is longer than 120 characters. | 69 | |
Method 'getGadgetSpec' is not designed for extension - needs to be abstract, final or empty. | 69 | |
Method 'getGadgetSpec' is not designed for extension - needs to be abstract, final or empty. | 74 | |
',' is not followed by whitespace. | 76 | |
Line has trailing spaces. | 120 |
Violation | Message | Line |
---|---|---|
Wrong order for 'com.google.common.base.Preconditions.checkNotNull' import. | 13 | |
Method 'assertRenderable' is not designed for extension - needs to be abstract, final or empty. | 50 | |
NPath Complexity is 36 (max allowed is 20). | 50 | |
'+' should be on a new line. | 55 | |
Line has trailing spaces. | 64 | |
'+' should be on a new line. | 80 | |
switch without "default" clause. | 83 | |
'+' should be on a new line. | 86 | |
'+' should be on a new line. | 100 |
Violation | Message | Line |
---|---|---|
First sentence should end with a period. | 24 | |
Variable access definition in wrong order. | 25 | |
Method 'unwrap' is not designed for extension - needs to be abstract, final or empty. | 44 | |
'+' should be on a new line. | 81 | |
'{' is followed by whitespace. | 98 |
Violation | Message | Line |
---|---|---|
Wrong order for 'com.atlassian.gadgets.util.Uri.resolveUriAgainstBase' import. | 13 | |
Missing a Javadoc comment. | 15 | |
Line has trailing spaces. | 29 | |
Method 'newSecurityToken' is not designed for extension - needs to be abstract, final or empty. | 30 | |
Line is longer than 120 characters. | 32 | |
Line has trailing spaces. | 41 |
Violation | Message | Line |
---|---|---|
Missing a Javadoc comment. | 8 |
Violation | Message | Line |
---|---|---|
Missing package-info.java file. | 0 | |
'org.springframework.beans.factory.InitializingBean' should be separated from previous imports. | 9 | |
Method 'onClearCache' is not designed for extension - needs to be abstract, final or empty. | 42 | |
Method 'onCreate' is not designed for extension - needs to be abstract, final or empty. | 53 | |
Method 'onDelete' is not designed for extension - needs to be abstract, final or empty. | 64 | |
Method 'onUpdateId' is not designed for extension - needs to be abstract, final or empty. | 75 | |
Method 'afterPropertiesSet' is not designed for extension - needs to be abstract, final or empty. | 84 |
Violation | Message | Line |
---|---|---|
First sentence should end with a period. | 5 |
Violation | Message | Line |
---|---|---|
'org.apache.shindig.common.cache.Cache' should be separated from previous imports. | 4 | |
Wrong order for 'java.util.Map' import. | 8 | |
'1000' is a magic number. | 26 | |
Method 'createCache' is not designed for extension - needs to be abstract, final or empty. | 30 | |
'if' is not followed by whitespace. | 32 | |
'if' is not followed by whitespace. | 38 | |
Line is longer than 120 characters. | 40 | |
',' is not followed by whitespace. | 40 | |
',' is not followed by whitespace. | 40 | |
'if' is not followed by whitespace. | 42 | |
'{' should be on a new line. | 42 | |
Method 'clear' is not designed for extension - needs to be abstract, final or empty. | 49 | |
'1000' is a magic number. | 51 | |
Missing a Javadoc comment. | 62 | |
',' is not followed by whitespace. | 62 | |
'{' should be on a new line. | 62 | |
',' is not followed by whitespace. | 96 | |
'delegate' hides a field. | 96 |
Violation | Message | Line |
---|---|---|
Missing package-info.java file. | 0 | |
Unused import - com.google.inject.Module. | 10 | |
Line has trailing spaces. | 36 | |
Method 'configure' is not designed for extension - needs to be abstract, final or empty. | 37 | |
Line has trailing spaces. | 52 | |
Line has trailing spaces. | 55 | |
Line has trailing spaces. | 58 |
Violation | Message | Line |
---|---|---|
First sentence should end with a period. | 10 | |
Line has trailing spaces. | 16 | |
Line is longer than 120 characters. | 17 | |
Method 'get' is not designed for extension - needs to be abstract, final or empty. | 27 |
Violation | Message | Line |
---|---|---|
Missing a Javadoc comment. | 10 | |
Method 'configure' is not designed for extension - needs to be abstract, final or empty. | 28 |
Violation | Message | Line |
---|---|---|
Class Fan-Out Complexity is 12 (max allowed is 10). | 51 | |
'static' modifier out of order with the JLS suggestions. | 53 | |
'static' modifier out of order with the JLS suggestions. | 54 | |
'properties' hides a field. | 76 | |
Method 'configure' is not designed for extension - needs to be abstract, final or empty. | 95 | |
Line has trailing spaces. | 99 | |
'{' is not followed by whitespace. | 107 | |
'}' is not preceded with whitespace. | 107 | |
Line has trailing spaces. | 110 | |
Line has trailing spaces. | 111 | |
Line is longer than 120 characters. | 111 | |
Line has trailing spaces. | 118 | |
'{' is not preceded with whitespace. | 121 | |
'{' is not followed by whitespace. | 121 | |
'}' is not preceded with whitespace. | 121 | |
'{' is not preceded with whitespace. | 122 | |
'{' is not followed by whitespace. | 122 | |
'}' is not preceded with whitespace. | 122 | |
Missing a Javadoc comment. | 129 | |
Line has trailing spaces. | 134 | |
Missing a Javadoc comment. | 146 | |
'{' should be on a new line. | 156 |
Violation | Message | Line |
---|---|---|
Method 'configure' is not designed for extension - needs to be abstract, final or empty. | 17 | |
Line has trailing spaces. | 23 | |
Missing a Javadoc comment. | 24 | |
Method 'get' is not designed for extension - needs to be abstract, final or empty. | 26 |
Violation | Message | Line |
---|---|---|
Line has trailing spaces. | 27 | |
Method 'allows' is not designed for extension - needs to be abstract, final or empty. | 28 | |
Line has trailing spaces. | 42 | |
Line has trailing spaces. | 57 |
Violation | Message | Line |
---|---|---|
Line has trailing spaces. | 16 | |
Line has trailing spaces. | 28 | |
Method 'allows' is not designed for extension - needs to be abstract, final or empty. | 29 | |
Line has trailing spaces. | 38 |
Violation | Message | Line |
---|---|---|
Missing package-info.java file. | 0 | |
Class Data Abstraction Coupling is 10 (max allowed is 7) classes [BasicHeader, BasicHttpParams, CustomSSLSocketFactory, DefaultHttpClient, GzipDeflatingInterceptor, HttpCacheKey, HttpResponseBuilder, InputStreamEntity, ProxySelectorRoutePlanner, Scheme]. | 68 | |
Class Fan-Out Complexity is 27 (max allowed is 10). | 68 | |
'{' should be on a new line. | 69 | |
member def modifier at indentation level 2 not at correct indentation, 4 | 70 | |
member def modifier at indentation level 2 not at correct indentation, 4 | 72 | |
member def modifier at indentation level 2 not at correct indentation, 4 | 74 | |
member def modifier at indentation level 2 not at correct indentation, 4 | 75 | |
ctor def modifier at indentation level 2 not at correct indentation, 4 | 77 | |
ctor def modifier at indentation level 2 not at correct indentation, 4 | 78 | |
'{' should be on a new line. | 78 | |
ctor def child at indentation level 4 not at correct indentation, 8 | 79 | |
ctor def child at indentation level 4 not at correct indentation, 8 | 80 | |
ctor def rcurly at indentation level 2 not at correct indentation, 4 | 81 | |
method def modifier at indentation level 2 not at correct indentation, 4 | 84 | |
Method 'fetch' is not designed for extension - needs to be abstract, final or empty. | 84 | |
NPath Complexity is 24 (max allowed is 20). | 84 | |
'{' should be on a new line. | 84 | |
if at indentation level 4 not at correct indentation, 8 | 85 | |
'{' should be on a new line. | 85 | |
if child at indentation level 6 not at correct indentation, 12 | 86 | |
method call child at indentation level 6 not at correct indentation, 12 | 86 | |
'+' should be on a new line. | 86 | |
Line is longer than 120 characters. | 87 | |
method call child at indentation level 10 not at correct indentation, 16 | 87 | |
if child at indentation level 6 not at correct indentation, 12 | 88 | |
Line is longer than 120 characters. | 91 | |
if rcurly at indentation level 4 not at correct indentation, 8 | 93 | |
method def child at indentation level 4 not at correct indentation, 8 | 94 | |
method def child at indentation level 4 not at correct indentation, 8 | 95 | |
if at indentation level 4 not at correct indentation, 8 | 96 | |
'{' should be on a new line. | 96 | |
if child at indentation level 6 not at correct indentation, 12 | 97 | |
if rcurly at indentation level 4 not at correct indentation, 8 | 98 | |
try at indentation level 4 not at correct indentation, 8 | 99 | |
'{' should be on a new line. | 99 | |
try child at indentation level 6 not at correct indentation, 12 | 100 | |
if at indentation level 6 not at correct indentation, 12 | 101 | |
'{' should be on a new line. | 101 | |
Line is longer than 120 characters. | 102 | |
if child at indentation level 8 not at correct indentation, 16 | 102 | |
method call child at indentation level 8 not at correct indentation, 16 | 102 | |
if rcurly at indentation level 6 not at correct indentation, 12 | 103 | |
try child at indentation level 6 not at correct indentation, 12 | 104 | |
try at indentation level 6 not at correct indentation, 12 | 105 | |
'{' should be on a new line. | 105 | |
try child at indentation level 8 not at correct indentation, 16 | 107 | |
try rcurly at indentation level 6 not at correct indentation, 12 | 108 | |
'}' should be alone on a line. | 108 | |
'{' should be on a new line. | 108 | |
catch child at indentation level 10 not at correct indentation, 16 | 109 | |
method call child at indentation level 10 not at correct indentation, 16 | 109 | |
catch child at indentation level 10 not at correct indentation, 16 | 111 | |
catch rcurly at indentation level 6 not at correct indentation, 12 | 112 | |
try child at indentation level 6 not at correct indentation, 12 | 113 | |
try child at indentation level 6 not at correct indentation, 12 | 114 | |
try rcurly at indentation level 4 not at correct indentation, 8 | 115 | |
'}' should be alone on a line. | 115 | |
'{' should be on a new line. | 115 | |
if at indentation level 6 not at correct indentation, 12 | 116 | |
'{' should be on a new line. | 116 | |
if child at indentation level 10 not at correct indentation, 16 | 117 | |
if rcurly at indentation level 6 not at correct indentation, 12 | 118 | |
'}' should be alone on a line. | 118 | |
'{' should be on a new line. | 118 | |
else child at indentation level 10 not at correct indentation, 16 | 119 | |
method call child at indentation level 10 not at correct indentation, 16 | 119 | |
else rcurly at indentation level 6 not at correct indentation, 12 | 120 | |
catch child at indentation level 6 not at correct indentation, 12 | 121 | |
catch rcurly at indentation level 4 not at correct indentation, 8 | 122 | |
method def rcurly at indentation level 2 not at correct indentation, 4 | 123 | |
method def modifier at indentation level 2 not at correct indentation, 4 | 125 | |
method def lcurly at indentation level 2 not at correct indentation, 4 | 126 | |
method def child at indentation level 6 not at correct indentation, 8 | 127 | |
method call child at indentation level 6 not at correct indentation, 8 | 128 | |
method def child at indentation level 6 not at correct indentation, 8 | 128 | |
if at indentation level 6 not at correct indentation, 8 | 131 | |
'if' is not followed by whitespace. | 131 | |
if lcurly at indentation level 6 not at correct indentation, 8 | 132 | |
if child at indentation level 10 not at correct indentation, 12 | 133 | |
method call child at indentation level 10 not at correct indentation, 12 | 133 | |
if child at indentation level 10 not at correct indentation, 12 | 134 | |
method call child at indentation level 10 not at correct indentation, 12 | 134 | |
'3' is a magic number. | 134 | |
if rcurly at indentation level 6 not at correct indentation, 8 | 135 | |
Line is longer than 120 characters. | 136 | |
method call child at indentation level 6 not at correct indentation, 8 | 136 | |
method def child at indentation level 6 not at correct indentation, 8 | 136 | |
method def child at indentation level 6 not at correct indentation, 8 | 137 | |
method def child at indentation level 6 not at correct indentation, 8 | 139 | |
method call child at indentation level 6 not at correct indentation, 8 | 142 | |
method def child at indentation level 6 not at correct indentation, 8 | 142 | |
method call child at indentation level 6 not at correct indentation, 8 | 144 | |
method def child at indentation level 6 not at correct indentation, 8 | 144 | |
Line is longer than 120 characters. | 145 | |
method call child at indentation level 6 not at correct indentation, 8 | 145 | |
method def child at indentation level 6 not at correct indentation, 8 | 145 | |
'443' is a magic number. | 145 | |
method def child at indentation level 6 not at correct indentation, 8 | 146 | |
method def rcurly at indentation level 2 not at correct indentation, 4 | 147 | |
method def modifier at indentation level 2 not at correct indentation, 4 | 149 | |
'{' should be on a new line. | 149 | |
method def child at indentation level 4 not at correct indentation, 8 | 150 | |
method def child at indentation level 4 not at correct indentation, 8 | 151 | |
for at indentation level 4 not at correct indentation, 8 | 153 | |
'{' should be on a new line. | 153 | |
for child at indentation level 6 not at correct indentation, 12 | 154 | |
method call child at indentation level 6 not at correct indentation, 12 | 154 | |
for rcurly at indentation level 4 not at correct indentation, 8 | 155 | |
method def child at indentation level 4 not at correct indentation, 8 | 156 | |
method def rcurly at indentation level 2 not at correct indentation, 4 | 157 | |
method def modifier at indentation level 2 not at correct indentation, 4 | 159 | |
'{' should be on a new line. | 159 | |
method def child at indentation level 4 not at correct indentation, 8 | 160 | |
for at indentation level 4 not at correct indentation, 8 | 161 | |
'{' should be on a new line. | 161 | |
for child at indentation level 8 not at correct indentation, 12 | 162 | |
method call child at indentation level 8 not at correct indentation, 12 | 162 | |
for rcurly at indentation level 4 not at correct indentation, 8 | 163 | |
method def child at indentation level 4 not at correct indentation, 8 | 165 | |
method def rcurly at indentation level 2 not at correct indentation, 4 | 169 | |
class def child at indentation level 2 not at correct indentation, 4 | 175 | |
class def ident at indentation level 2 not at correct indentation, 4 | 175 | |
class def modifier at indentation level 2 not at correct indentation, 4 | 175 | |
'{' should be on a new line. | 175 | |
member def modifier at indentation level 4 not at correct indentation, 8 | 176 | |
member def modifier at indentation level 4 not at correct indentation, 8 | 177 | |
ctor def modifier at indentation level 4 not at correct indentation, 8 | 179 | |
'{' should be on a new line. | 179 | |
ctor def child at indentation level 6 not at correct indentation, 12 | 180 | |
ctor def rcurly at indentation level 4 not at correct indentation, 8 | 181 | |
method def modifier at indentation level 4 not at correct indentation, 8 | 183 | |
'{' should be on a new line. | 183 | |
method def child at indentation level 6 not at correct indentation, 12 | 184 | |
method call child at indentation level 6 not at correct indentation, 12 | 185 | |
method def child at indentation level 6 not at correct indentation, 12 | 185 | |
'{' is followed by whitespace. | 185 | |
method def child at indentation level 6 not at correct indentation, 12 | 186 | |
method def rcurly at indentation level 4 not at correct indentation, 8 | 187 | |
Line is longer than 120 characters. | 189 | |
method def modifier at indentation level 4 not at correct indentation, 8 | 189 | |
method def throws at indentation level 8 not at correct indentation, 12 | 190 | |
Redundant throws: 'UnknownHostException' is subclass of 'IOException'. | 190 | |
Redundant throws: 'ConnectTimeoutException' is subclass of 'IOException'. | 190 | |
'{' should be on a new line. | 190 | |
method def child at indentation level 6 not at correct indentation, 12 | 191 | |
method def rcurly at indentation level 4 not at correct indentation, 8 | 192 | |
method def modifier at indentation level 4 not at correct indentation, 8 | 194 | |
'{' should be on a new line. | 194 | |
method def child at indentation level 6 not at correct indentation, 12 | 195 | |
method def rcurly at indentation level 4 not at correct indentation, 8 | 196 | |
Line is longer than 120 characters. | 198 | |
method def modifier at indentation level 4 not at correct indentation, 8 | 198 | |
Redundant throws: 'UnknownHostException' is subclass of 'IOException'. | 198 | |
'{' should be on a new line. | 198 | |
method def child at indentation level 6 not at correct indentation, 12 | 199 | |
method def rcurly at indentation level 4 not at correct indentation, 8 | 200 | |
class def rcurly at indentation level 2 not at correct indentation, 4 | 201 | |
class def child at indentation level 2 not at correct indentation, 4 | 203 | |
class def ident at indentation level 2 not at correct indentation, 4 | 203 | |
class def modifier at indentation level 2 not at correct indentation, 4 | 203 | |
'{' should be on a new line. | 203 | |
Line is longer than 120 characters. | 204 | |
method def modifier at indentation level 4 not at correct indentation, 8 | 204 | |
'{' should be on a new line. | 204 | |
method def child at indentation level 6 not at correct indentation, 12 | 205 | |
method def child at indentation level 6 not at correct indentation, 12 | 206 | |
if at indentation level 6 not at correct indentation, 12 | 207 | |
'{' should be on a new line. | 207 | |
if child at indentation level 8 not at correct indentation, 16 | 208 | |
for at indentation level 8 not at correct indentation, 16 | 209 | |
'{' should be on a new line. | 209 | |
if at indentation level 10 not at correct indentation, 20 | 210 | |
'{' should be on a new line. | 210 | |
if child at indentation level 12 not at correct indentation, 24 | 211 | |
method call child at indentation level 12 not at correct indentation, 24 | 211 | |
if child at indentation level 12 not at correct indentation, 24 | 212 | |
if rcurly at indentation level 10 not at correct indentation, 20 | 213 | |
'}' should be alone on a line. | 213 | |
'{' should be on a new line. | 213 | |
if child at indentation level 12 not at correct indentation, 24 | 214 | |
method call child at indentation level 12 not at correct indentation, 24 | 214 | |
if child at indentation level 12 not at correct indentation, 24 | 215 | |
if rcurly at indentation level 10 not at correct indentation, 20 | 216 | |
for rcurly at indentation level 8 not at correct indentation, 16 | 217 | |
if rcurly at indentation level 6 not at correct indentation, 12 | 218 | |
method def rcurly at indentation level 4 not at correct indentation, 8 | 219 | |
class def rcurly at indentation level 2 not at correct indentation, 4 | 220 | |
class def child at indentation level 2 not at correct indentation, 4 | 222 | |
class def ident at indentation level 2 not at correct indentation, 4 | 222 | |
class def modifier at indentation level 2 not at correct indentation, 4 | 222 | |
'abstract' modifier out of order with the JLS suggestions. | 222 | |
'{' should be on a new line. | 222 | |
ctor def modifier at indentation level 4 not at correct indentation, 8 | 223 | |
'{' should be on a new line. | 223 | |
ctor def rcurly at indentation level 4 not at correct indentation, 8 | 225 | |
method def modifier at indentation level 4 not at correct indentation, 8 | 227 | |
method def modifier at indentation level 4 not at correct indentation, 8 | 228 | |
'{' should be on a new line. | 228 | |
method def child at indentation level 6 not at correct indentation, 12 | 230 | |
method def rcurly at indentation level 4 not at correct indentation, 8 | 231 | |
method def modifier at indentation level 4 not at correct indentation, 8 | 233 | |
method def modifier at indentation level 4 not at correct indentation, 8 | 234 | |
'{' should be on a new line. | 234 | |
method def child at indentation level 6 not at correct indentation, 12 | 236 | |
method def rcurly at indentation level 4 not at correct indentation, 8 | 237 | |
method def modifier at indentation level 4 not at correct indentation, 8 | 239 | |
class def rcurly at indentation level 2 not at correct indentation, 4 | 240 | |
class def child at indentation level 2 not at correct indentation, 4 | 242 | |
class def ident at indentation level 2 not at correct indentation, 4 | 242 | |
class def modifier at indentation level 2 not at correct indentation, 4 | 242 | |
'{' should be on a new line. | 242 | |
ctor def modifier at indentation level 4 not at correct indentation, 8 | 243 | |
'{' should be on a new line. | 243 | |
ctor def rcurly at indentation level 4 not at correct indentation, 8 | 245 | |
method def modifier at indentation level 4 not at correct indentation, 8 | 247 | |
method def modifier at indentation level 4 not at correct indentation, 8 | 248 | |
'{' should be on a new line. | 248 | |
method def child at indentation level 6 not at correct indentation, 12 | 249 | |
method def rcurly at indentation level 4 not at correct indentation, 8 | 250 | |
class def rcurly at indentation level 2 not at correct indentation, 4 | 251 | |
class def child at indentation level 2 not at correct indentation, 4 | 253 | |
class def ident at indentation level 2 not at correct indentation, 4 | 253 | |
class def modifier at indentation level 2 not at correct indentation, 4 | 253 | |
'{' should be on a new line. | 253 | |
ctor def modifier at indentation level 4 not at correct indentation, 8 | 254 | |
'{' should be on a new line. | 254 | |
ctor def rcurly at indentation level 4 not at correct indentation, 8 | 256 | |
method def modifier at indentation level 4 not at correct indentation, 8 | 258 | |
method def modifier at indentation level 4 not at correct indentation, 8 | 259 | |
'{' should be on a new line. | 259 | |
method def child at indentation level 6 not at correct indentation, 12 | 260 | |
method def rcurly at indentation level 4 not at correct indentation, 8 | 261 | |
class def rcurly at indentation level 2 not at correct indentation, 4 | 262 | |
enum def child at indentation level 2 not at correct indentation, 4 | 264 | |
enum def ident at indentation level 2 not at correct indentation, 4 | 264 | |
enum def modifier at indentation level 2 not at correct indentation, 4 | 264 | |
'{' should be on a new line. | 264 | |
method def modifier at indentation level 4 not at correct indentation, 8 | 267 | |
'{' should be on a new line. | 267 | |
switch at indentation level 6 not at correct indentation, 12 | 268 | |
switch without "default" clause. | 268 | |
'{' should be on a new line. | 268 | |
block child at indentation level 8 not at correct indentation, 20 | 269 | |
case child at indentation level 8 not at correct indentation, 16 | 269 | |
block child at indentation level 8 not at correct indentation, 20 | 270 | |
case child at indentation level 8 not at correct indentation, 16 | 270 | |
block child at indentation level 8 not at correct indentation, 20 | 271 | |
case child at indentation level 8 not at correct indentation, 16 | 271 | |
block child at indentation level 8 not at correct indentation, 20 | 272 | |
case child at indentation level 8 not at correct indentation, 16 | 272 | |
block child at indentation level 8 not at correct indentation, 20 | 273 | |
case child at indentation level 8 not at correct indentation, 16 | 273 | |
block child at indentation level 8 not at correct indentation, 20 | 274 | |
case child at indentation level 8 not at correct indentation, 16 | 274 | |
block child at indentation level 8 not at correct indentation, 20 | 275 | |
case child at indentation level 8 not at correct indentation, 16 | 275 | |
switch rcurly at indentation level 6 not at correct indentation, 12 | 276 | |
method def child at indentation level 6 not at correct indentation, 12 | 277 | |
method def rcurly at indentation level 4 not at correct indentation, 8 | 278 | |
enum def rcurly at indentation level 2 not at correct indentation, 4 | 279 |
Violation | Message | Line |
---|---|---|
Line has trailing spaces. | 39 | |
Method 'fetch' is not designed for extension - needs to be abstract, final or empty. | 40 | |
Line has trailing spaces. | 50 | |
'!=' is not preceded with whitespace. | 51 | |
'!=' is not followed by whitespace. | 51 |
Violation | Message | Line |
---|---|---|
Missing package-info.java file. | 0 | |
Wrong order for 'com.google.common.base.Preconditions.checkNotNull' import. | 26 | |
Missing a Javadoc comment. | 51 | |
Static variable definition in wrong order. | 51 | |
Variable access definition in wrong order. | 51 | |
Missing a Javadoc comment. | 52 | |
Static variable definition in wrong order. | 52 | |
Variable access definition in wrong order. | 52 | |
Method 'getGadgetSpec' is not designed for extension - needs to be abstract, final or empty. | 54 | |
Method 'getGadgetSpec' is not designed for extension - needs to be abstract, final or empty. | 67 | |
'static' modifier out of order with the JLS suggestions. | 87 | |
Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 87 | |
'static' modifier out of order with the JLS suggestions. | 147 | |
Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 147 | |
NPath Complexity is 33 (max allowed is 20). | 156 | |
Line is longer than 120 characters. | 183 | |
Line is longer than 120 characters. | 192 | |
Line is longer than 120 characters. | 201 | |
Line is longer than 120 characters. | 206 |
Violation | Message | Line |
---|---|---|
Missing a Javadoc comment. | 25 | |
Class Fan-Out Complexity is 11 (max allowed is 10). | 25 | |
Line has trailing spaces. | 29 | |
Line has trailing spaces. | 30 | |
Line has trailing spaces. | 31 | |
Method 'sign' is not designed for extension - needs to be abstract, final or empty. | 38 | |
method def throws at indentation level 12 not at correct indentation, 8 | 40 | |
Line has trailing spaces. | 47 | |
Line is longer than 120 characters. | 56 | |
Line has trailing spaces. | 58 |
Violation | Message | Line |
---|---|---|
First sentence should end with a period. | 31 | |
Line has trailing spaces. | 33 | |
Method 'getOAuthFetcher' is not designed for extension - needs to be abstract, final or empty. | 36 |
Violation | Message | Line |
---|---|---|
Missing package-info.java file. | 0 | |
Wrong order for 'com.google.common.base.Preconditions.checkNotNull' import. | 24 | |
'org.apache.commons.lang.StringUtils.isBlank' should be separated from previous imports. | 25 | |
Line is longer than 120 characters. | 30 | |
Class Fan-Out Complexity is 14 (max allowed is 10). | 34 | |
Line has trailing spaces. | 37 | |
Line has trailing spaces. | 51 | |
Line is longer than 120 characters. | 52 | |
Method 'getConsumerKeyAndSecret' is not designed for extension - needs to be abstract, final or empty. | 52 | |
Line is longer than 120 characters. | 61 | |
Method 'getTokenInfo' is not designed for extension - needs to be abstract, final or empty. | 61 | |
Line is longer than 120 characters. | 75 | |
Method 'setTokenInfo' is not designed for extension - needs to be abstract, final or empty. | 75 | |
Boolean expression complexity is 4 (max allowed is 3). | 84 | |
if child at indentation level 9 not at correct indentation, 12 | 85 | |
if child at indentation level 9 not at correct indentation, 12 | 86 | |
if child at indentation level 9 not at correct indentation, 12 | 87 | |
Line has trailing spaces. | 92 | |
Line has trailing spaces. | 97 | |
Line is longer than 120 characters. | 98 | |
Method 'removeToken' is not designed for extension - needs to be abstract, final or empty. | 98 | |
Line has trailing spaces. | 121 | |
Utility classes should not have a public or default constructor. | 141 | |
Missing a Javadoc comment. | 143 | |
Missing a Javadoc comment. | 144 | |
Line is longer than 120 characters. | 157 |
Violation | Message | Line |
---|---|---|
Missing package-info.java file. | 0 | |
Missing a Javadoc comment. | 10 | |
Method 'getProxyUrl' is not designed for extension - needs to be abstract, final or empty. | 32 | |
Line has trailing spaces. | 38 | |
Method 'getConcatUrl' is not designed for extension - needs to be abstract, final or empty. | 43 |
Violation | Message | Line |
---|---|---|
Missing package-info.java file. | 0 | |
Missing a Javadoc comment. | 12 | |
Line has trailing spaces. | 20 | |
Method 'contextInitialized' is not designed for extension - needs to be abstract, final or empty. | 21 | |
Method 'contextDestroyed' is not designed for extension - needs to be abstract, final or empty. | 27 |
Violation | Message | Line |
---|---|---|
Missing a Javadoc comment. | 7 |
Violation | Message | Line |
---|---|---|
Wrong order for 'com.google.common.base.Preconditions.checkNotNull' import. | 29 | |
Class Fan-Out Complexity is 18 (max allowed is 10). | 35 | |
Line has trailing spaces. | 44 | |
Line has trailing spaces. | 49 | |
Method 'doFilter' is not designed for extension - needs to be abstract, final or empty. | 65 | |
method def throws at indentation level 12 not at correct indentation, 8 | 66 | |
'if' is not followed by whitespace. | 102 | |
'{' should be on a new line. | 102 | |
Line has trailing spaces. | 115 | |
'{' is not preceded with whitespace. | 117 | |
'{' is not followed by whitespace. | 117 | |
'}' is not preceded with whitespace. | 117 | |
'{' is not followed by whitespace. | 118 | |
'}' is not preceded with whitespace. | 118 | |
Missing a Javadoc comment. | 120 | |
'{' should be on a new line. | 120 | |
Line has trailing spaces. | 123 | |
Line is longer than 120 characters. | 125 | |
Method 'html' is not designed for extension - needs to be abstract, final or empty. | 131 |
Violation | Message | Line |
---|---|---|
assign child at indentation level 6 not at correct indentation, 8 | 20 | |
assign child at indentation level 6 not at correct indentation, 8 | 21 | |
assign child at indentation level 6 not at correct indentation, 8 | 22 | |
assign child at indentation level 6 not at correct indentation, 8 | 23 | |
assign child at indentation level 6 not at correct indentation, 8 | 24 | |
assign child at indentation level 6 not at correct indentation, 8 | 25 | |
assign child at indentation level 6 not at correct indentation, 8 | 26 | |
assign child at indentation level 6 not at correct indentation, 8 | 27 | |
Method 'doGet' is not designed for extension - needs to be abstract, final or empty. | 29 |
Violation | Message | Line |
---|---|---|
Wrong order for 'com.google.common.base.Objects.equal' import. | 22 | |
Missing a Javadoc comment. | 25 | |
Class Fan-Out Complexity is 11 (max allowed is 10). | 25 | |
Method 'doPost' is not designed for extension - needs to be abstract, final or empty. | 37 | |
Line has trailing spaces. | 42 | |
Must have at least one statement. | 58 |