Checkstyle Results

The following document contains the results of Checkstylerss feed

Summary

Files Infos Infos Warnings Warnings Errors Errors
36 53 162 420

Files

Files Infos Warnings Errors
com/atlassian/gadgets/opensocial/internal/ShindigActivityServiceImpl.java 5 27 7
com/atlassian/gadgets/opensocial/internal/ShindigAppDataServiceImpl.java 3 17 7
com/atlassian/gadgets/opensocial/internal/ShindigOpenSocialTypeAdapter.java 0 19 26
com/atlassian/gadgets/opensocial/internal/ShindigPersonServiceImpl.java 2 10 8
com/atlassian/gadgets/opensocial/internal/guice/OpenSocialModule.java 1 1 2
com/atlassian/gadgets/renderer/internal/AtlassianContainerConfig.java 5 19 13
com/atlassian/gadgets/renderer/internal/AtlassianOAuthCallbackGenerator.java 1 1 2
com/atlassian/gadgets/renderer/internal/BlobCrypterImpl.java 3 2 2
com/atlassian/gadgets/renderer/internal/ContainerDomainProvider.java 1 1 0
com/atlassian/gadgets/renderer/internal/CustomBlobCrypterSecurityTokenDecoder.java 1 5 7
com/atlassian/gadgets/renderer/internal/CustomNonExpirableBlobCrypterSecurityTokenDecoder.java 0 0 1
com/atlassian/gadgets/renderer/internal/FeatureImpl.java 2 0 2
com/atlassian/gadgets/renderer/internal/GadgetRequestContextFactoryImpl.java 0 3 5
com/atlassian/gadgets/renderer/internal/GadgetSpecFactoryImpl.java 2 2 4
com/atlassian/gadgets/renderer/internal/GadgetSpecUrlCheckerImpl.java 1 1 7
com/atlassian/gadgets/renderer/internal/NonExpirableBlobCrypterImpl.java 1 0 4
com/atlassian/gadgets/renderer/internal/SecurityTokenFactoryImpl.java 1 3 2
com/atlassian/gadgets/renderer/internal/UpdatableBlobCrypterSecurityToken.java 0 0 1
com/atlassian/gadgets/renderer/internal/guice/AuthModule.java 1 4 2
com/atlassian/gadgets/renderer/internal/guice/InjectorProvider.java 1 2 1
com/atlassian/gadgets/renderer/internal/guice/SalModule.java 1 0 1
com/atlassian/gadgets/renderer/internal/guice/ShindigModule.java 1 5 14
com/atlassian/gadgets/renderer/internal/guice/XercesParseModule.java 2 1 1
com/atlassian/gadgets/renderer/internal/http/HttpClientFetcher.java 1 6 241
com/atlassian/gadgets/renderer/internal/http/TrustedAppContentFetcherFactory.java 1 2 2
com/atlassian/gadgets/renderer/internal/local/LocalGadgetSpecFactory.java 2 4 13
com/atlassian/gadgets/renderer/internal/oauth/AtlassianOAuthFetcher.java 1 6 3
com/atlassian/gadgets/renderer/internal/oauth/AtlassianOAuthFetcherFactory.java 1 1 1
com/atlassian/gadgets/renderer/internal/oauth/AtlassianOAuthStore.java 4 11 11
com/atlassian/gadgets/renderer/internal/rewrite/AtlassianGadgetsContentRewriter.java 2 1 2
com/atlassian/gadgets/renderer/internal/servlet/AtlassianGadgetsGuiceServletContextListener.java 2 1 2
com/atlassian/gadgets/renderer/internal/servlet/AtlassianOAuthCallbackServlet.java 0 0 1
com/atlassian/gadgets/renderer/internal/servlet/GadgetSpecUrlRenderPermissionServletFilter.java 2 5 12
com/atlassian/gadgets/renderer/internal/servlet/RpcRelay.java 1 0 8
com/atlassian/gadgets/renderer/internal/servlet/SecurityTokenServlet.java 1 1 4
com/atlassian/gadgets/renderer/internal/servlet/TrustedAppMakeRequestHandler.java 0 1 1

Rules

Rules Violations Severity
JavadocPackage 9 Errors Error
Translation 0 Errors Error
FileLength 0 Errors Error
FileTabCharacter
  • eachLine: "true"
0 Errors Error
RegexpSingleline
  • message: "Line has trailing spaces."
  • format: "\s+$"
62 Warnings Warning
AnnotationUseStyle 0 Errors Error
MissingDeprecated 0 Errors Error
MissingOverride
  • javaFiveCompatibility: "true"
0 Errors Error
PackageAnnotation 0 Errors Error
JavadocMethod
  • excludeScope: "private"
  • scope: "anoninner"
19 Errors Error
JavadocType
  • scope: "package"
18 Errors Error
JavadocVariable
  • scope: "package"
12 Errors Error
JavadocStyle
  • scope: "package"
17 Errors Error
ConstantName 2 Errors Error
LocalFinalVariableName 0 Errors Error
LocalVariableName 0 Errors Error
MemberName 0 Errors Error
MethodName 0 Errors Error
PackageName 0 Errors Error
ParameterName 0 Errors Error
StaticVariableName 0 Errors Error
TypeName 0 Errors Error
AvoidStarImport 0 Errors Error
IllegalImport 0 Errors Error
ImportOrder
  • separated: "true"
  • groups: "java,javax,com.atlassian,com,org"
16 Errors Error
RedundantImport 0 Errors Error
UnusedImports 2 Errors Error
LineLength
  • max: "120"
100 Warnings Warning
MethodLength 0 Errors Error
ParameterNumber 0 Errors Error
EmptyForIteratorPad 0 Errors Error
MethodParamPad 1 Errors Error
NoWhitespaceAfter 2 Errors Error
NoWhitespaceBefore 0 Errors Error
OperatorWrap 5 Errors Error
ParenPad 0 Errors Error
TypecastParenPad 0 Errors Error
WhitespaceAfter 6 Errors Error
WhitespaceAround 17 Errors Error
ModifierOrder 7 Errors Error
RedundantModifier 0 Errors Error
AvoidNestedBlocks 0 Errors Error
EmptyBlock 1 Errors Error
LeftCurly
  • option: "nl"
43 Errors Error
NeedBraces 0 Errors Error
RightCurly
  • option: "alone"
4 Errors Error
DeclarationOrder 13 Errors Error
DefaultComesLast 0 Errors Error
DoubleCheckedLocking 0 Errors Error
EmptyStatement 0 Errors Error
EqualsHashCode 0 Errors Error
ExplicitInitialization 0 Errors Error
FallThrough 0 Errors Error
HiddenField
  • ignoreConstructorParameter: "true"
  • ignoreSetter: "true"
1 Errors Error
IllegalInstantiation 0 Errors Error
InnerAssignment 0 Errors Error
MagicNumber 2 Errors Error
MissingSwitchDefault 2 Errors Error
ParameterAssignment 0 Errors Error
RedundantThrows
  • allowUnchecked: "true"
3 Errors Error
SimplifyBooleanExpression 0 Errors Error
SimplifyBooleanReturn 0 Errors Error
StringLiteralEquality 0 Errors Error
DesignForExtension 53 Infos Info
FinalClass 1 Errors Error
HideUtilityClassConstructor 2 Errors Error
InterfaceIsType 0 Errors Error
VisibilityModifier 0 Errors Error
BooleanExpressionComplexity 1 Errors Error
ClassDataAbstractionCoupling 2 Errors Error
ClassFanOutComplexity
  • max: "10"
10 Errors Error
CyclomaticComplexity 1 Errors Error
NPathComplexity
  • max: "20"
4 Errors Error
JavaNCSS 0 Errors Error
ArrayTypeStyle 0 Errors Error
Indentation 199 Errors Error
TodoComment 0 Errors Error
UpperEll 0 Errors Error

Details

com/atlassian/gadgets/opensocial/internal/ShindigActivityServiceImpl.java

Violation Message Line
Errors Wrong order for 'com.atlassian.gadgets.opensocial.internal.ShindigOpenSocialTypeAdapter.activityToShindigActivityFunction' import. 31
Warnings Line is longer than 120 characters. 34
Warnings Line is longer than 120 characters. 39
Errors Class Fan-Out Complexity is 19 (max allowed is 10). 41
Warnings Line is longer than 120 characters. 49
Infos Method 'getActivities' is not designed for extension - needs to be abstract, final or empty. 57
Warnings Line is longer than 120 characters. 58
Warnings Line is longer than 120 characters. 62
Errors Missing a Javadoc comment. 65
Warnings Line is longer than 120 characters. 68
Warnings Line is longer than 120 characters. 71
Warnings Line is longer than 120 characters. 72
Warnings Line is longer than 120 characters. 80
Infos Method 'getActivities' is not designed for extension - needs to be abstract, final or empty. 80
Warnings Line is longer than 120 characters. 84
Warnings Line is longer than 120 characters. 85
Errors Missing a Javadoc comment. 88
Warnings Line is longer than 120 characters. 91
Warnings Line is longer than 120 characters. 94
Warnings Line is longer than 120 characters. 95
Warnings Line is longer than 120 characters. 103
Infos Method 'getActivity' is not designed for extension - needs to be abstract, final or empty. 103
Warnings Line is longer than 120 characters. 107
Errors Missing a Javadoc comment. 110
Warnings Line is longer than 120 characters. 112
Warnings Line is longer than 120 characters. 114
Warnings Line is longer than 120 characters. 125
Infos Method 'deleteActivities' is not designed for extension - needs to be abstract, final or empty. 125
Warnings Line is longer than 120 characters. 129
Warnings Line is longer than 120 characters. 130
Errors Missing a Javadoc comment. 133
Warnings Line is longer than 120 characters. 136
Warnings Line is longer than 120 characters. 148
Infos Method 'createActivity' is not designed for extension - needs to be abstract, final or empty. 148
Warnings Line is longer than 120 characters. 151
Warnings Line is longer than 120 characters. 155
Warnings Line is longer than 120 characters. 156
Errors Missing a Javadoc comment. 159
Warnings Line is longer than 120 characters. 162

com/atlassian/gadgets/opensocial/internal/ShindigAppDataServiceImpl.java

Violation Message Line
Warnings Line is longer than 120 characters. 30
Errors Wrong order for 'com.atlassian.gadgets.opensocial.internal.ShindigOpenSocialTypeAdapter.convertShindigSecurityTokenToRequestContext' import. 30
Errors First sentence should end with a period. 33
Warnings Line has trailing spaces. 34
Warnings Line is longer than 120 characters. 34
Errors Class Fan-Out Complexity is 20 (max allowed is 10). 36
Errors Static variable definition in wrong order. 42
Warnings Line is longer than 120 characters. 45
Infos Method 'getPersonData' is not designed for extension - needs to be abstract, final or empty. 53
Warnings Line is longer than 120 characters. 54
Warnings Line is longer than 120 characters. 58
Warnings Line is longer than 120 characters. 59
Errors Missing a Javadoc comment. 61
Warnings Line is longer than 120 characters. 64
Warnings Line is longer than 120 characters. 91
Infos Method 'deletePersonData' is not designed for extension - needs to be abstract, final or empty. 91
Warnings Line is longer than 120 characters. 95
Warnings Line is longer than 120 characters. 96
Errors Missing a Javadoc comment. 100
Warnings Line is longer than 120 characters. 107
Warnings Line is longer than 120 characters. 111
Warnings Line is longer than 120 characters. 125
Infos Method 'updatePersonData' is not designed for extension - needs to be abstract, final or empty. 125
Warnings Line is longer than 120 characters. 129
Errors Missing a Javadoc comment. 132
Warnings Line is longer than 120 characters. 134
Warnings Line is longer than 120 characters. 138

com/atlassian/gadgets/opensocial/internal/ShindigOpenSocialTypeAdapter.java

Violation Message Line
Errors First sentence should end with a period. 30
Errors Class ShindigOpenSocialTypeAdapter should be declared as final. 33
Errors Class Data Abstraction Coupling is 9 (max allowed is 7) classes [Activity.Builder, Function, HashSet, MediaItem.Builder, MediaItemImpl, NameImpl, OpenSocialRequestContext, PersonImpl, org.apache.shindig.social.core.model.ActivityImpl]. 33
Errors Class Fan-Out Complexity is 23 (max allowed is 10). 33
Errors First sentence should end with a period. 40
Warnings Line is longer than 120 characters. 43
Warnings Line is longer than 120 characters. 52
Errors First sentence should end with a period. 55
Warnings Line is longer than 120 characters. 59
Warnings Line is longer than 120 characters. 61
Errors Cyclomatic Complexity is 20 (max allowed is 10). 61
Errors NPath Complexity is 131,072 (max allowed is 20). 61
Warnings Line is longer than 120 characters. 68
Errors 'cast' is not followed by whitespace. 68
Warnings Line is longer than 120 characters. 69
Warnings Line is longer than 120 characters. 93
Errors First sentence should end with a period. 140
Errors NPath Complexity is 32 (max allowed is 20). 145
Errors First sentence should end with a period. 184
Errors First sentence should end with a period. 204
Warnings Line is longer than 120 characters. 209
Errors Missing a Javadoc comment. 213
Errors Missing a Javadoc comment. 218
Errors Missing a Javadoc comment. 223
Errors Missing a Javadoc comment. 228
Errors First sentence should end with a period. 235
Warnings Line is longer than 120 characters. 244
Warnings Line is longer than 120 characters. 254
Warnings Line is longer than 120 characters. 266
Errors First sentence should end with a period. 277
Warnings Line is longer than 120 characters. 282
Errors Missing a Javadoc comment. 286
Errors First sentence should end with a period. 293
Warnings Line is longer than 120 characters. 296
Warnings Line has trailing spaces. 306
Warnings Line is longer than 120 characters. 306
Errors First sentence should end with a period. 310
Warnings Line is longer than 120 characters. 314
Errors Missing a Javadoc comment. 318
Warnings Line has trailing spaces. 324
Errors First sentence should end with a period. 325
Warnings Line is longer than 120 characters. 328
Errors First sentence should end with a period. 343
Warnings Line is longer than 120 characters. 347
Errors Missing a Javadoc comment. 351

com/atlassian/gadgets/opensocial/internal/ShindigPersonServiceImpl.java

Violation Message Line
Errors Missing package-info.java file. 0
Errors Wrong order for 'com.atlassian.gadgets.opensocial.internal.ShindigOpenSocialTypeAdapter.convertPersonToShindigPerson' import. 28
Warnings Line is longer than 120 characters. 29
Warnings Line is longer than 120 characters. 34
Errors Class Fan-Out Complexity is 18 (max allowed is 10). 36
Errors Static variable definition in wrong order. 41
Warnings Line is longer than 120 characters. 44
Errors Missing a Javadoc comment. 44
Infos Method 'getPeople' is not designed for extension - needs to be abstract, final or empty. 59
Warnings Line is longer than 120 characters. 60
Errors ',' is not followed by whitespace. 60
Errors Missing a Javadoc comment. 66
Warnings Line is longer than 120 characters. 73
Warnings Line is longer than 120 characters. 75
Warnings Line is longer than 120 characters. 85
Warnings Line is longer than 120 characters. 86
Warnings Line is longer than 120 characters. 94
Infos Method 'getPerson' is not designed for extension - needs to be abstract, final or empty. 94
Warnings Line is longer than 120 characters. 98
Errors Missing a Javadoc comment. 101

com/atlassian/gadgets/opensocial/internal/guice/OpenSocialModule.java

Violation Message Line
Errors Missing package-info.java file. 0
Errors First sentence should end with a period. 21
Warnings Line is longer than 120 characters. 30
Infos Method 'configure' is not designed for extension - needs to be abstract, final or empty. 36

com/atlassian/gadgets/renderer/internal/AtlassianContainerConfig.java

Violation Message Line
Errors 'com.google.common.collect.ImmutableList' should be separated from previous imports. 5
Errors 'org.apache.shindig.common.ContainerConfig' should be separated from previous imports. 10
Errors Wrong order for 'java.net.URI' import. 16
Warnings Line has trailing spaces. 22
Errors Missing a Javadoc comment. 27
Errors Utility classes should not have a public or default constructor. 27
Errors Missing a Javadoc comment. 29
Errors Missing a Javadoc comment. 30
Warnings Line has trailing spaces. 32
Errors Missing a Javadoc comment. 33
Errors Missing a Javadoc comment. 34
Errors Missing a Javadoc comment. 35
Errors Missing a Javadoc comment. 36
Warnings Line has trailing spaces. 37
Warnings Line has trailing spaces. 42
Warnings Line is longer than 120 characters. 55
Warnings Line is longer than 120 characters. 108
Warnings Line is longer than 120 characters. 109
Warnings Line is longer than 120 characters. 112
Warnings Line is longer than 120 characters. 113
Warnings Line is longer than 120 characters. 134
Errors ',' is not followed by whitespace. 134
Warnings Line has trailing spaces. 142
Warnings Line has trailing spaces. 144
Warnings Line has trailing spaces. 145
Errors '(' is preceded with whitespace. 153
Warnings Line has trailing spaces. 161
Warnings Line has trailing spaces. 163
Warnings Line has trailing spaces. 164
Warnings Line has trailing spaces. 204
Warnings Line has trailing spaces. 206
Warnings Line has trailing spaces. 207
Infos Method 'getContainers' is not designed for extension - needs to be abstract, final or empty. 225
Infos Method 'getJson' is not designed for extension - needs to be abstract, final or empty. 242
Infos Method 'get' is not designed for extension - needs to be abstract, final or empty. 276
Infos Method 'getJsonObject' is not designed for extension - needs to be abstract, final or empty. 282
Infos Method 'getJsonArray' is not designed for extension - needs to be abstract, final or empty. 288

com/atlassian/gadgets/renderer/internal/AtlassianOAuthCallbackGenerator.java

Violation Message Line
Errors Unused import - org.apache.shindig.gadgets.oauth.GadgetOAuthCallbackGenerator. 6
Infos Method 'generateCallback' is not designed for extension - needs to be abstract, final or empty. 19
Warnings Line has trailing spaces. 22
Errors method def throws at indentation level 12 not at correct indentation, 8 23

com/atlassian/gadgets/renderer/internal/BlobCrypterImpl.java

Violation Message Line
Errors Missing a Javadoc comment. 16
Warnings Line has trailing spaces. 31
Infos Method 'getKey' is not designed for extension - needs to be abstract, final or empty. 35
Errors Missing a Javadoc comment. 40
Warnings Line has trailing spaces. 55
Infos Method 'unwrap' is not designed for extension - needs to be abstract, final or empty. 56
Infos Method 'wrap' is not designed for extension - needs to be abstract, final or empty. 61

com/atlassian/gadgets/renderer/internal/ContainerDomainProvider.java

Violation Message Line
Warnings Line has trailing spaces. 21
Infos Method 'getDomain' is not designed for extension - needs to be abstract, final or empty. 24

com/atlassian/gadgets/renderer/internal/CustomBlobCrypterSecurityTokenDecoder.java

Violation Message Line
Errors Missing a Javadoc comment. 17
Warnings Line has trailing spaces. 26
Infos Method 'createToken' is not designed for extension - needs to be abstract, final or empty. 32
Warnings Line has trailing spaces. 62
Errors Static variable definition in wrong order. 63
Errors Static variable definition in wrong order. 65
Errors Static variable definition in wrong order. 66
Errors Static variable definition in wrong order. 67
Errors Static variable definition in wrong order. 68
Errors Static variable definition in wrong order. 69
Warnings Line has trailing spaces. 74
Warnings Line has trailing spaces. 76
Warnings Line has trailing spaces. 82

com/atlassian/gadgets/renderer/internal/CustomNonExpirableBlobCrypterSecurityTokenDecoder.java

Violation Message Line
Errors Missing a Javadoc comment. 6

com/atlassian/gadgets/renderer/internal/FeatureImpl.java

Violation Message Line
Errors Missing package-info.java file. 0
Errors Missing a Javadoc comment. 5
Infos Method 'getParameterValue' is not designed for extension - needs to be abstract, final or empty. 14
Infos Method 'getName' is not designed for extension - needs to be abstract, final or empty. 19

com/atlassian/gadgets/renderer/internal/GadgetRequestContextFactoryImpl.java

Violation Message Line
Errors Wrong order for 'com.atlassian.gadgets.GadgetRequestContext.Builder.gadgetRequestContext' import. 14
Errors Missing a Javadoc comment. 21
Errors 'static' modifier out of order with the JLS suggestions. 21
Errors Missing a Javadoc comment. 22
Errors 'static' modifier out of order with the JLS suggestions. 22
Warnings Line has trailing spaces. 30
Warnings Line has trailing spaces. 60
Warnings Line is longer than 120 characters. 61

com/atlassian/gadgets/renderer/internal/GadgetSpecFactoryImpl.java

Violation Message Line
Errors Wrong order for 'com.google.common.base.Preconditions.checkNotNull' import. 35
Errors Wrong order for 'java.util.Collections.unmodifiableCollection' import. 38
Errors Class Fan-Out Complexity is 23 (max allowed is 10). 44
Warnings Line is longer than 120 characters. 69
Infos Method 'getGadgetSpec' is not designed for extension - needs to be abstract, final or empty. 69
Infos Method 'getGadgetSpec' is not designed for extension - needs to be abstract, final or empty. 74
Errors ',' is not followed by whitespace. 76
Warnings Line has trailing spaces. 120

com/atlassian/gadgets/renderer/internal/GadgetSpecUrlCheckerImpl.java

Violation Message Line
Errors Wrong order for 'com.google.common.base.Preconditions.checkNotNull' import. 13
Infos Method 'assertRenderable' is not designed for extension - needs to be abstract, final or empty. 50
Errors NPath Complexity is 36 (max allowed is 20). 50
Errors '+' should be on a new line. 55
Warnings Line has trailing spaces. 64
Errors '+' should be on a new line. 80
Errors switch without "default" clause. 83
Errors '+' should be on a new line. 86
Errors '+' should be on a new line. 100

com/atlassian/gadgets/renderer/internal/NonExpirableBlobCrypterImpl.java

Violation Message Line
Errors First sentence should end with a period. 24
Errors Variable access definition in wrong order. 25
Infos Method 'unwrap' is not designed for extension - needs to be abstract, final or empty. 44
Errors '+' should be on a new line. 81
Errors '{' is followed by whitespace. 98

com/atlassian/gadgets/renderer/internal/SecurityTokenFactoryImpl.java

Violation Message Line
Errors Wrong order for 'com.atlassian.gadgets.util.Uri.resolveUriAgainstBase' import. 13
Errors Missing a Javadoc comment. 15
Warnings Line has trailing spaces. 29
Infos Method 'newSecurityToken' is not designed for extension - needs to be abstract, final or empty. 30
Warnings Line is longer than 120 characters. 32
Warnings Line has trailing spaces. 41

com/atlassian/gadgets/renderer/internal/UpdatableBlobCrypterSecurityToken.java

Violation Message Line
Errors Missing a Javadoc comment. 8

com/atlassian/gadgets/renderer/internal/guice/AuthModule.java

Violation Message Line
Errors Missing package-info.java file. 0
Errors Unused import - com.google.inject.Module. 10
Warnings Line has trailing spaces. 36
Infos Method 'configure' is not designed for extension - needs to be abstract, final or empty. 37
Warnings Line has trailing spaces. 52
Warnings Line has trailing spaces. 55
Warnings Line has trailing spaces. 58

com/atlassian/gadgets/renderer/internal/guice/InjectorProvider.java

Violation Message Line
Errors First sentence should end with a period. 10
Warnings Line has trailing spaces. 16
Warnings Line is longer than 120 characters. 17
Infos Method 'get' is not designed for extension - needs to be abstract, final or empty. 27

com/atlassian/gadgets/renderer/internal/guice/SalModule.java

Violation Message Line
Errors Missing a Javadoc comment. 10
Infos Method 'configure' is not designed for extension - needs to be abstract, final or empty. 28

com/atlassian/gadgets/renderer/internal/guice/ShindigModule.java

Violation Message Line
Errors 'static' modifier out of order with the JLS suggestions. 50
Errors 'static' modifier out of order with the JLS suggestions. 51
Errors 'properties' hides a field. 67
Infos Method 'configure' is not designed for extension - needs to be abstract, final or empty. 86
Warnings Line has trailing spaces. 90
Errors '{' is not followed by whitespace. 97
Errors '}' is not preceded with whitespace. 97
Warnings Line has trailing spaces. 100
Warnings Line has trailing spaces. 101
Warnings Line is longer than 120 characters. 101
Errors '{' is not preceded with whitespace. 108
Errors '{' is not followed by whitespace. 108
Errors '}' is not preceded with whitespace. 108
Errors '{' is not preceded with whitespace. 109
Errors '{' is not followed by whitespace. 109
Errors '}' is not preceded with whitespace. 109
Errors Missing a Javadoc comment. 116
Warnings Line has trailing spaces. 121
Errors Missing a Javadoc comment. 133
Errors '{' should be on a new line. 143

com/atlassian/gadgets/renderer/internal/guice/XercesParseModule.java

Violation Message Line
Infos Method 'configure' is not designed for extension - needs to be abstract, final or empty. 17
Warnings Line has trailing spaces. 23
Errors Missing a Javadoc comment. 24
Infos Method 'get' is not designed for extension - needs to be abstract, final or empty. 26

com/atlassian/gadgets/renderer/internal/http/HttpClientFetcher.java

Violation Message Line
Errors Missing package-info.java file. 0
Errors Class Data Abstraction Coupling is 10 (max allowed is 7) classes [BasicHeader, BasicHttpParams, CustomSSLSocketFactory, DefaultHttpClient, GzipDeflatingInterceptor, HttpCacheKey, HttpResponseBuilder, InputStreamEntity, ProxySelectorRoutePlanner, Scheme]. 67
Errors Class Fan-Out Complexity is 26 (max allowed is 10). 67
Errors '{' should be on a new line. 68
Errors member def modifier at indentation level 2 not at correct indentation, 4 69
Errors member def modifier at indentation level 2 not at correct indentation, 4 71
Errors member def modifier at indentation level 2 not at correct indentation, 4 73
Errors ctor def modifier at indentation level 2 not at correct indentation, 4 75
Errors ctor def modifier at indentation level 2 not at correct indentation, 4 76
Errors '{' should be on a new line. 76
Errors ctor def child at indentation level 6 not at correct indentation, 8 77
Errors ctor def rcurly at indentation level 2 not at correct indentation, 4 78
Errors method def modifier at indentation level 2 not at correct indentation, 4 81
Infos Method 'fetch' is not designed for extension - needs to be abstract, final or empty. 81
Errors '{' should be on a new line. 81
Errors method def child at indentation level 4 not at correct indentation, 8 82
Errors method def child at indentation level 4 not at correct indentation, 8 83
Errors if at indentation level 4 not at correct indentation, 8 84
Errors '{' should be on a new line. 84
Errors if child at indentation level 6 not at correct indentation, 12 85
Errors if rcurly at indentation level 4 not at correct indentation, 8 86
Errors try at indentation level 4 not at correct indentation, 8 87
Errors '{' should be on a new line. 87
Errors try child at indentation level 6 not at correct indentation, 12 88
Errors if at indentation level 6 not at correct indentation, 12 89
Errors '{' should be on a new line. 89
Warnings Line is longer than 120 characters. 90
Errors if child at indentation level 8 not at correct indentation, 16 90
Errors method call child at indentation level 8 not at correct indentation, 16 90
Errors if rcurly at indentation level 6 not at correct indentation, 12 91
Errors try child at indentation level 6 not at correct indentation, 12 92
Errors try at indentation level 6 not at correct indentation, 12 93
Errors '{' should be on a new line. 93
Errors try child at indentation level 8 not at correct indentation, 16 95
Errors try rcurly at indentation level 6 not at correct indentation, 12 96
Errors '}' should be alone on a line. 96
Errors '{' should be on a new line. 96
Errors catch child at indentation level 10 not at correct indentation, 16 97
Errors method call child at indentation level 10 not at correct indentation, 16 97
Errors catch child at indentation level 10 not at correct indentation, 16 99
Errors catch rcurly at indentation level 6 not at correct indentation, 12 100
Errors try child at indentation level 6 not at correct indentation, 12 101
Errors try child at indentation level 6 not at correct indentation, 12 102
Errors try rcurly at indentation level 4 not at correct indentation, 8 103
Errors '}' should be alone on a line. 103
Errors '{' should be on a new line. 103
Errors if at indentation level 6 not at correct indentation, 12 104
Errors '{' should be on a new line. 104
Errors if child at indentation level 10 not at correct indentation, 16 105
Errors if rcurly at indentation level 6 not at correct indentation, 12 106
Errors '}' should be alone on a line. 106
Errors '{' should be on a new line. 106
Errors else child at indentation level 10 not at correct indentation, 16 107
Errors method call child at indentation level 10 not at correct indentation, 16 107
Errors else rcurly at indentation level 6 not at correct indentation, 12 108
Errors catch child at indentation level 6 not at correct indentation, 12 109
Errors catch rcurly at indentation level 4 not at correct indentation, 8 110
Errors method def rcurly at indentation level 2 not at correct indentation, 4 111
Errors method def modifier at indentation level 2 not at correct indentation, 4 113
Errors method def lcurly at indentation level 2 not at correct indentation, 4 114
Errors method def child at indentation level 6 not at correct indentation, 8 115
Errors method call child at indentation level 6 not at correct indentation, 8 116
Errors method def child at indentation level 6 not at correct indentation, 8 116
Errors if at indentation level 6 not at correct indentation, 8 119
Errors 'if' is not followed by whitespace. 119
Errors if lcurly at indentation level 6 not at correct indentation, 8 120
Errors if child at indentation level 10 not at correct indentation, 12 121
Errors method call child at indentation level 10 not at correct indentation, 12 121
Errors if child at indentation level 10 not at correct indentation, 12 122
Errors method call child at indentation level 10 not at correct indentation, 12 122
Errors '3' is a magic number. 122
Errors if rcurly at indentation level 6 not at correct indentation, 8 123
Warnings Line is longer than 120 characters. 124
Errors method call child at indentation level 6 not at correct indentation, 8 124
Errors method def child at indentation level 6 not at correct indentation, 8 124
Errors method def child at indentation level 6 not at correct indentation, 8 125
Errors method def child at indentation level 6 not at correct indentation, 8 127
Errors method call child at indentation level 6 not at correct indentation, 8 130
Errors method def child at indentation level 6 not at correct indentation, 8 130
Errors method call child at indentation level 6 not at correct indentation, 8 132
Errors method def child at indentation level 6 not at correct indentation, 8 132
Warnings Line is longer than 120 characters. 133
Errors method call child at indentation level 6 not at correct indentation, 8 133
Errors method def child at indentation level 6 not at correct indentation, 8 133
Errors '443' is a magic number. 133
Errors method def child at indentation level 6 not at correct indentation, 8 134
Errors method def rcurly at indentation level 2 not at correct indentation, 4 135
Errors method def modifier at indentation level 2 not at correct indentation, 4 137
Errors '{' should be on a new line. 137
Errors method def child at indentation level 4 not at correct indentation, 8 138
Errors method def child at indentation level 4 not at correct indentation, 8 139
Errors for at indentation level 4 not at correct indentation, 8 141
Errors '{' should be on a new line. 141
Errors for child at indentation level 6 not at correct indentation, 12 142
Errors method call child at indentation level 6 not at correct indentation, 12 142
Errors for rcurly at indentation level 4 not at correct indentation, 8 143
Errors method def child at indentation level 4 not at correct indentation, 8 144
Errors method def rcurly at indentation level 2 not at correct indentation, 4 145
Errors method def modifier at indentation level 2 not at correct indentation, 4 147
Errors '{' should be on a new line. 147
Errors method def child at indentation level 4 not at correct indentation, 8 148
Errors for at indentation level 4 not at correct indentation, 8 149
Errors '{' should be on a new line. 149
Errors for child at indentation level 8 not at correct indentation, 12 150
Errors method call child at indentation level 8 not at correct indentation, 12 150
Errors for rcurly at indentation level 4 not at correct indentation, 8 151
Errors method def child at indentation level 4 not at correct indentation, 8 153
Errors method def rcurly at indentation level 2 not at correct indentation, 4 157
Errors class def child at indentation level 2 not at correct indentation, 4 163
Errors class def ident at indentation level 2 not at correct indentation, 4 163
Errors class def modifier at indentation level 2 not at correct indentation, 4 163
Errors '{' should be on a new line. 163
Errors member def modifier at indentation level 4 not at correct indentation, 8 164
Errors member def modifier at indentation level 4 not at correct indentation, 8 165
Errors ctor def modifier at indentation level 4 not at correct indentation, 8 167
Errors '{' should be on a new line. 167
Errors ctor def child at indentation level 6 not at correct indentation, 12 168
Errors ctor def rcurly at indentation level 4 not at correct indentation, 8 169
Errors method def modifier at indentation level 4 not at correct indentation, 8 171
Errors '{' should be on a new line. 171
Errors method def child at indentation level 6 not at correct indentation, 12 172
Errors method call child at indentation level 6 not at correct indentation, 12 173
Errors method def child at indentation level 6 not at correct indentation, 12 173
Errors '{' is followed by whitespace. 173
Errors method def child at indentation level 6 not at correct indentation, 12 174
Errors method def rcurly at indentation level 4 not at correct indentation, 8 175
Warnings Line is longer than 120 characters. 177
Errors method def modifier at indentation level 4 not at correct indentation, 8 177
Errors method def throws at indentation level 8 not at correct indentation, 12 178
Errors Redundant throws: 'UnknownHostException' is subclass of 'IOException'. 178
Errors Redundant throws: 'ConnectTimeoutException' is subclass of 'IOException'. 178
Errors '{' should be on a new line. 178
Errors method def child at indentation level 6 not at correct indentation, 12 179
Errors method def rcurly at indentation level 4 not at correct indentation, 8 180
Errors method def modifier at indentation level 4 not at correct indentation, 8 182
Errors '{' should be on a new line. 182
Errors method def child at indentation level 6 not at correct indentation, 12 183
Errors method def rcurly at indentation level 4 not at correct indentation, 8 184
Warnings Line is longer than 120 characters. 186
Errors method def modifier at indentation level 4 not at correct indentation, 8 186
Errors Redundant throws: 'UnknownHostException' is subclass of 'IOException'. 186
Errors '{' should be on a new line. 186
Errors method def child at indentation level 6 not at correct indentation, 12 187
Errors method def rcurly at indentation level 4 not at correct indentation, 8 188
Errors class def rcurly at indentation level 2 not at correct indentation, 4 189
Errors class def child at indentation level 2 not at correct indentation, 4 191
Errors class def ident at indentation level 2 not at correct indentation, 4 191
Errors class def modifier at indentation level 2 not at correct indentation, 4 191
Errors '{' should be on a new line. 191
Warnings Line is longer than 120 characters. 192
Errors method def modifier at indentation level 4 not at correct indentation, 8 192
Errors '{' should be on a new line. 192
Errors method def child at indentation level 6 not at correct indentation, 12 193
Errors method def child at indentation level 6 not at correct indentation, 12 194
Errors if at indentation level 6 not at correct indentation, 12 195
Errors '{' should be on a new line. 195
Errors if child at indentation level 8 not at correct indentation, 16 196
Errors for at indentation level 8 not at correct indentation, 16 197
Errors '{' should be on a new line. 197
Errors if at indentation level 10 not at correct indentation, 20 198
Errors '{' should be on a new line. 198
Errors if child at indentation level 12 not at correct indentation, 24 199
Errors method call child at indentation level 12 not at correct indentation, 24 199
Errors if child at indentation level 12 not at correct indentation, 24 200
Errors if rcurly at indentation level 10 not at correct indentation, 20 201
Errors '}' should be alone on a line. 201
Errors '{' should be on a new line. 201
Errors if child at indentation level 12 not at correct indentation, 24 202
Errors method call child at indentation level 12 not at correct indentation, 24 202
Errors if child at indentation level 12 not at correct indentation, 24 203
Errors if rcurly at indentation level 10 not at correct indentation, 20 204
Errors for rcurly at indentation level 8 not at correct indentation, 16 205
Errors if rcurly at indentation level 6 not at correct indentation, 12 206
Errors method def rcurly at indentation level 4 not at correct indentation, 8 207
Errors class def rcurly at indentation level 2 not at correct indentation, 4 208
Errors class def child at indentation level 2 not at correct indentation, 4 210
Errors class def ident at indentation level 2 not at correct indentation, 4 210
Errors class def modifier at indentation level 2 not at correct indentation, 4 210
Errors 'abstract' modifier out of order with the JLS suggestions. 210
Errors '{' should be on a new line. 210
Errors ctor def modifier at indentation level 4 not at correct indentation, 8 211
Errors '{' should be on a new line. 211
Errors ctor def rcurly at indentation level 4 not at correct indentation, 8 213
Errors method def modifier at indentation level 4 not at correct indentation, 8 215
Errors method def modifier at indentation level 4 not at correct indentation, 8 216
Errors '{' should be on a new line. 216
Errors method def child at indentation level 6 not at correct indentation, 12 218
Errors method def rcurly at indentation level 4 not at correct indentation, 8 219
Errors method def modifier at indentation level 4 not at correct indentation, 8 221
Errors method def modifier at indentation level 4 not at correct indentation, 8 222
Errors '{' should be on a new line. 222
Errors method def child at indentation level 6 not at correct indentation, 12 224
Errors method def rcurly at indentation level 4 not at correct indentation, 8 225
Errors method def modifier at indentation level 4 not at correct indentation, 8 227
Errors class def rcurly at indentation level 2 not at correct indentation, 4 228
Errors class def child at indentation level 2 not at correct indentation, 4 230
Errors class def ident at indentation level 2 not at correct indentation, 4 230
Errors class def modifier at indentation level 2 not at correct indentation, 4 230
Errors '{' should be on a new line. 230
Errors ctor def modifier at indentation level 4 not at correct indentation, 8 231
Errors '{' should be on a new line. 231
Errors ctor def rcurly at indentation level 4 not at correct indentation, 8 233
Errors method def modifier at indentation level 4 not at correct indentation, 8 235
Errors method def modifier at indentation level 4 not at correct indentation, 8 236
Errors '{' should be on a new line. 236
Errors method def child at indentation level 6 not at correct indentation, 12 237
Errors method def rcurly at indentation level 4 not at correct indentation, 8 238
Errors class def rcurly at indentation level 2 not at correct indentation, 4 239
Errors class def child at indentation level 2 not at correct indentation, 4 241
Errors class def ident at indentation level 2 not at correct indentation, 4 241
Errors class def modifier at indentation level 2 not at correct indentation, 4 241
Errors '{' should be on a new line. 241
Errors ctor def modifier at indentation level 4 not at correct indentation, 8 242
Errors '{' should be on a new line. 242
Errors ctor def rcurly at indentation level 4 not at correct indentation, 8 244
Errors method def modifier at indentation level 4 not at correct indentation, 8 246
Errors method def modifier at indentation level 4 not at correct indentation, 8 247
Errors '{' should be on a new line. 247
Errors method def child at indentation level 6 not at correct indentation, 12 248
Errors method def rcurly at indentation level 4 not at correct indentation, 8 249
Errors class def rcurly at indentation level 2 not at correct indentation, 4 250
Errors enum def child at indentation level 2 not at correct indentation, 4 252
Errors enum def ident at indentation level 2 not at correct indentation, 4 252
Errors enum def modifier at indentation level 2 not at correct indentation, 4 252
Errors '{' should be on a new line. 252
Errors method def modifier at indentation level 4 not at correct indentation, 8 255
Errors '{' should be on a new line. 255
Errors switch at indentation level 6 not at correct indentation, 12 256
Errors switch without "default" clause. 256
Errors '{' should be on a new line. 256
Errors block child at indentation level 8 not at correct indentation, 20 257
Errors case child at indentation level 8 not at correct indentation, 16 257
Errors block child at indentation level 8 not at correct indentation, 20 258
Errors case child at indentation level 8 not at correct indentation, 16 258
Errors block child at indentation level 8 not at correct indentation, 20 259
Errors case child at indentation level 8 not at correct indentation, 16 259
Errors block child at indentation level 8 not at correct indentation, 20 260
Errors case child at indentation level 8 not at correct indentation, 16 260
Errors block child at indentation level 8 not at correct indentation, 20 261
Errors case child at indentation level 8 not at correct indentation, 16 261
Errors block child at indentation level 8 not at correct indentation, 20 262
Errors case child at indentation level 8 not at correct indentation, 16 262
Errors block child at indentation level 8 not at correct indentation, 20 263
Errors case child at indentation level 8 not at correct indentation, 16 263
Errors switch rcurly at indentation level 6 not at correct indentation, 12 264
Errors method def child at indentation level 6 not at correct indentation, 12 265
Errors method def rcurly at indentation level 4 not at correct indentation, 8 266
Errors enum def rcurly at indentation level 2 not at correct indentation, 4 267

com/atlassian/gadgets/renderer/internal/http/TrustedAppContentFetcherFactory.java

Violation Message Line
Warnings Line has trailing spaces. 39
Infos Method 'fetch' is not designed for extension - needs to be abstract, final or empty. 40
Warnings Line has trailing spaces. 50
Errors '!=' is not preceded with whitespace. 51
Errors '!=' is not followed by whitespace. 51

com/atlassian/gadgets/renderer/internal/local/LocalGadgetSpecFactory.java

Violation Message Line
Errors Missing package-info.java file. 0
Errors Wrong order for 'com.google.common.base.Preconditions.checkNotNull' import. 26
Errors Missing a Javadoc comment. 51
Errors Static variable definition in wrong order. 51
Errors Variable access definition in wrong order. 51
Errors Missing a Javadoc comment. 52
Errors Static variable definition in wrong order. 52
Errors Variable access definition in wrong order. 52
Infos Method 'getGadgetSpec' is not designed for extension - needs to be abstract, final or empty. 54
Infos Method 'getGadgetSpec' is not designed for extension - needs to be abstract, final or empty. 67
Errors 'static' modifier out of order with the JLS suggestions. 87
Errors Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 87
Errors 'static' modifier out of order with the JLS suggestions. 147
Errors Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 147
Errors NPath Complexity is 33 (max allowed is 20). 156
Warnings Line is longer than 120 characters. 183
Warnings Line is longer than 120 characters. 192
Warnings Line is longer than 120 characters. 201
Warnings Line is longer than 120 characters. 206

com/atlassian/gadgets/renderer/internal/oauth/AtlassianOAuthFetcher.java

Violation Message Line
Errors Missing a Javadoc comment. 25
Errors Class Fan-Out Complexity is 11 (max allowed is 10). 25
Warnings Line has trailing spaces. 29
Warnings Line has trailing spaces. 30
Warnings Line has trailing spaces. 31
Infos Method 'sign' is not designed for extension - needs to be abstract, final or empty. 38
Errors method def throws at indentation level 12 not at correct indentation, 8 40
Warnings Line has trailing spaces. 47
Warnings Line is longer than 120 characters. 56
Warnings Line has trailing spaces. 58

com/atlassian/gadgets/renderer/internal/oauth/AtlassianOAuthFetcherFactory.java

Violation Message Line
Errors First sentence should end with a period. 31
Warnings Line has trailing spaces. 33
Infos Method 'getOAuthFetcher' is not designed for extension - needs to be abstract, final or empty. 36

com/atlassian/gadgets/renderer/internal/oauth/AtlassianOAuthStore.java

Violation Message Line
Errors Missing package-info.java file. 0
Errors Wrong order for 'com.google.common.base.Preconditions.checkNotNull' import. 24
Errors 'org.apache.commons.lang.StringUtils.isBlank' should be separated from previous imports. 25
Warnings Line is longer than 120 characters. 30
Errors Class Fan-Out Complexity is 14 (max allowed is 10). 34
Warnings Line has trailing spaces. 37
Warnings Line has trailing spaces. 51
Warnings Line is longer than 120 characters. 52
Infos Method 'getConsumerKeyAndSecret' is not designed for extension - needs to be abstract, final or empty. 52
Warnings Line is longer than 120 characters. 61
Infos Method 'getTokenInfo' is not designed for extension - needs to be abstract, final or empty. 61
Warnings Line is longer than 120 characters. 75
Infos Method 'setTokenInfo' is not designed for extension - needs to be abstract, final or empty. 75
Errors Boolean expression complexity is 4 (max allowed is 3). 84
Errors if child at indentation level 9 not at correct indentation, 12 85
Errors if child at indentation level 9 not at correct indentation, 12 86
Errors if child at indentation level 9 not at correct indentation, 12 87
Warnings Line has trailing spaces. 92
Warnings Line has trailing spaces. 97
Warnings Line is longer than 120 characters. 98
Infos Method 'removeToken' is not designed for extension - needs to be abstract, final or empty. 98
Warnings Line has trailing spaces. 121
Errors Utility classes should not have a public or default constructor. 141
Errors Missing a Javadoc comment. 143
Errors Missing a Javadoc comment. 144
Warnings Line is longer than 120 characters. 157

com/atlassian/gadgets/renderer/internal/rewrite/AtlassianGadgetsContentRewriter.java

Violation Message Line
Errors Missing package-info.java file. 0
Errors Missing a Javadoc comment. 10
Infos Method 'getProxyUrl' is not designed for extension - needs to be abstract, final or empty. 32
Warnings Line has trailing spaces. 38
Infos Method 'getConcatUrl' is not designed for extension - needs to be abstract, final or empty. 43

com/atlassian/gadgets/renderer/internal/servlet/AtlassianGadgetsGuiceServletContextListener.java

Violation Message Line
Errors Missing package-info.java file. 0
Errors Missing a Javadoc comment. 12
Warnings Line has trailing spaces. 20
Infos Method 'contextInitialized' is not designed for extension - needs to be abstract, final or empty. 21
Infos Method 'contextDestroyed' is not designed for extension - needs to be abstract, final or empty. 27

com/atlassian/gadgets/renderer/internal/servlet/AtlassianOAuthCallbackServlet.java

Violation Message Line
Errors Missing a Javadoc comment. 7

com/atlassian/gadgets/renderer/internal/servlet/GadgetSpecUrlRenderPermissionServletFilter.java

Violation Message Line
Errors Wrong order for 'com.google.common.base.Preconditions.checkNotNull' import. 29
Errors Class Fan-Out Complexity is 18 (max allowed is 10). 35
Warnings Line has trailing spaces. 44
Warnings Line has trailing spaces. 49
Infos Method 'doFilter' is not designed for extension - needs to be abstract, final or empty. 65
Errors method def throws at indentation level 12 not at correct indentation, 8 66
Errors 'if' is not followed by whitespace. 102
Errors '{' should be on a new line. 102
Warnings Line has trailing spaces. 115
Errors '{' is not preceded with whitespace. 117
Errors '{' is not followed by whitespace. 117
Errors '}' is not preceded with whitespace. 117
Errors '{' is not followed by whitespace. 118
Errors '}' is not preceded with whitespace. 118
Errors Missing a Javadoc comment. 120
Errors '{' should be on a new line. 120
Warnings Line has trailing spaces. 123
Warnings Line is longer than 120 characters. 125
Infos Method 'html' is not designed for extension - needs to be abstract, final or empty. 131

com/atlassian/gadgets/renderer/internal/servlet/RpcRelay.java

Violation Message Line
Errors assign child at indentation level 6 not at correct indentation, 8 20
Errors assign child at indentation level 6 not at correct indentation, 8 21
Errors assign child at indentation level 6 not at correct indentation, 8 22
Errors assign child at indentation level 6 not at correct indentation, 8 23
Errors assign child at indentation level 6 not at correct indentation, 8 24
Errors assign child at indentation level 6 not at correct indentation, 8 25
Errors assign child at indentation level 6 not at correct indentation, 8 26
Errors assign child at indentation level 6 not at correct indentation, 8 27
Infos Method 'doGet' is not designed for extension - needs to be abstract, final or empty. 29

com/atlassian/gadgets/renderer/internal/servlet/SecurityTokenServlet.java

Violation Message Line
Errors Wrong order for 'com.google.common.base.Objects.equal' import. 22
Errors Missing a Javadoc comment. 25
Errors Class Fan-Out Complexity is 11 (max allowed is 10). 25
Infos Method 'doPost' is not designed for extension - needs to be abstract, final or empty. 37
Warnings Line has trailing spaces. 42
Errors Must have at least one statement. 58

com/atlassian/gadgets/renderer/internal/servlet/TrustedAppMakeRequestHandler.java

Violation Message Line
Errors Missing a Javadoc comment. 11
Warnings Line has trailing spaces. 19