The following document contains the results of Checkstyle. 
| Files | Infos  |
Warnings  |
Errors  |
|---|---|---|---|
| 31 | 50 | 161 | 504 |
| Rules | Violations | Severity |
|---|---|---|
| JavadocPackage | 9 | Error |
| Translation | 0 | Error |
| FileLength | 0 | Error |
FileTabCharacter
|
0 | Error |
RegexpSingleline
|
61 | Warning |
| AnnotationUseStyle | 0 | Error |
| MissingDeprecated | 0 | Error |
MissingOverride
|
0 | Error |
| PackageAnnotation | 0 | Error |
JavadocMethod
|
19 | Error |
JavadocType
|
14 | Error |
JavadocVariable
|
11 | Error |
JavadocStyle
|
16 | Error |
| ConstantName | 2 | Error |
| LocalFinalVariableName | 0 | Error |
| LocalVariableName | 0 | Error |
| MemberName | 0 | Error |
| MethodName | 0 | Error |
| PackageName | 0 | Error |
| ParameterName | 0 | Error |
| StaticVariableName | 0 | Error |
| TypeName | 0 | Error |
| AvoidStarImport | 0 | Error |
| IllegalImport | 0 | Error |
ImportOrder
|
111 | Error |
| RedundantImport | 0 | Error |
| UnusedImports | 2 | Error |
LineLength
|
100 | Warning |
| MethodLength | 0 | Error |
| ParameterNumber | 0 | Error |
| EmptyForIteratorPad | 0 | Error |
| MethodParamPad | 1 | Error |
| NoWhitespaceAfter | 1 | Error |
| NoWhitespaceBefore | 0 | Error |
| OperatorWrap | 4 | Error |
| ParenPad | 0 | Error |
| TypecastParenPad | 0 | Error |
| WhitespaceAfter | 5 | Error |
| WhitespaceAround | 17 | Error |
| ModifierOrder | 7 | Error |
| RedundantModifier | 0 | Error |
| AvoidNestedBlocks | 0 | Error |
| EmptyBlock | 0 | Error |
LeftCurly
|
43 | Error |
| NeedBraces | 0 | Error |
RightCurly
|
4 | Error |
| DeclarationOrder | 12 | Error |
| DefaultComesLast | 0 | Error |
| DoubleCheckedLocking | 0 | Error |
| EmptyStatement | 0 | Error |
| EqualsHashCode | 0 | Error |
| ExplicitInitialization | 0 | Error |
| FallThrough | 0 | Error |
HiddenField
|
1 | Error |
| IllegalInstantiation | 0 | Error |
| InnerAssignment | 0 | Error |
| MagicNumber | 2 | Error |
| MissingSwitchDefault | 2 | Error |
| ParameterAssignment | 0 | Error |
RedundantThrows
|
3 | Error |
| SimplifyBooleanExpression | 0 | Error |
| SimplifyBooleanReturn | 0 | Error |
| StringLiteralEquality | 0 | Error |
| DesignForExtension | 50 | Info |
| FinalClass | 1 | Error |
| HideUtilityClassConstructor | 2 | Error |
| InterfaceIsType | 0 | Error |
| VisibilityModifier | 0 | Error |
| BooleanExpressionComplexity | 1 | Error |
| ClassDataAbstractionCoupling | 2 | Error |
ClassFanOutComplexity
|
9 | Error |
| CyclomaticComplexity | 1 | Error |
NPathComplexity
|
4 | Error |
| JavaNCSS | 0 | Error |
| ArrayTypeStyle | 0 | Error |
| Indentation | 199 | Error |
| TodoComment | 0 | Error |
| UpperEll | 0 | Error |
| Violation | Message | Line |
|---|---|---|
|
Wrong order for 'org.apache.shindig.social.ResponseError' import. | 7 |
|
Wrong order for 'org.apache.shindig.auth.SecurityToken' import. | 8 |
|
Wrong order for 'java.util.concurrent.Future' import. | 11 |
|
Wrong order for 'java.util.Set' import. | 12 |
|
Wrong order for 'java.util.List' import. | 13 |
|
Wrong order for 'com.atlassian.gadgets.opensocial.spi.ActivityService' import. | 16 |
|
Wrong order for 'com.atlassian.gadgets.opensocial.model.Activity' import. | 17 |
|
Wrong order for 'com.atlassian.gadgets.opensocial.model.AppId' import. | 19 |
|
Line is longer than 120 characters. | 23 |
|
Wrong order for 'com.atlassian.gadgets.opensocial.internal.ShindigOpenSocialTypeAdapter.convertShindigActivityToActivity' import. | 24 |
|
Wrong order for 'com.atlassian.gadgets.opensocial.internal.ShindigOpenSocialTypeAdapter.convertActivityToShindigActivity' import. | 26 |
|
Wrong order for 'com.atlassian.gadgets.opensocial.OpenSocialRequestContext' import. | 27 |
|
Wrong order for 'com.atlassian.sal.api.transaction.TransactionCallback' import. | 30 |
|
Wrong order for 'com.atlassian.sal.api.ApplicationProperties' import. | 31 |
|
'com.google.inject.Inject' should be separated from previous imports. | 32 |
|
Wrong order for 'com.google.common.collect.Lists' import. | 33 |
|
Line is longer than 120 characters. | 37 |
|
Class Fan-Out Complexity is 19 (max allowed is 10). | 39 |
|
Line is longer than 120 characters. | 47 |
|
Method 'getActivities' is not designed for extension - needs to be abstract, final or empty. | 55 |
|
Line is longer than 120 characters. | 56 |
|
Line is longer than 120 characters. | 60 |
|
Missing a Javadoc comment. | 63 |
|
Line is longer than 120 characters. | 66 |
|
Line is longer than 120 characters. | 69 |
|
Line is longer than 120 characters. | 70 |
|
Line is longer than 120 characters. | 78 |
|
Method 'getActivities' is not designed for extension - needs to be abstract, final or empty. | 78 |
|
Line is longer than 120 characters. | 82 |
|
Line is longer than 120 characters. | 83 |
|
Missing a Javadoc comment. | 86 |
|
Line is longer than 120 characters. | 89 |
|
Line is longer than 120 characters. | 92 |
|
Line is longer than 120 characters. | 93 |
|
Line is longer than 120 characters. | 101 |
|
Method 'getActivity' is not designed for extension - needs to be abstract, final or empty. | 101 |
|
Line is longer than 120 characters. | 105 |
|
Missing a Javadoc comment. | 108 |
|
Line is longer than 120 characters. | 110 |
|
Line is longer than 120 characters. | 112 |
|
Line is longer than 120 characters. | 123 |
|
Method 'deleteActivities' is not designed for extension - needs to be abstract, final or empty. | 123 |
|
Line is longer than 120 characters. | 127 |
|
Line is longer than 120 characters. | 128 |
|
Missing a Javadoc comment. | 131 |
|
Line is longer than 120 characters. | 134 |
|
Line is longer than 120 characters. | 146 |
|
Method 'createActivity' is not designed for extension - needs to be abstract, final or empty. | 146 |
|
Line is longer than 120 characters. | 149 |
|
Line is longer than 120 characters. | 153 |
|
Line is longer than 120 characters. | 154 |
|
Missing a Javadoc comment. | 157 |
|
Line is longer than 120 characters. | 160 |
| Violation | Message | Line |
|---|---|---|
|
Wrong order for 'org.apache.shindig.social.ResponseError' import. | 7 |
|
Wrong order for 'org.apache.shindig.auth.SecurityToken' import. | 8 |
|
Wrong order for 'java.util.concurrent.Future' import. | 11 |
|
Wrong order for 'java.util.Set' import. | 12 |
|
Wrong order for 'java.util.Map' import. | 13 |
|
Wrong order for 'java.util.HashMap' import. | 14 |
|
Wrong order for 'com.atlassian.gadgets.opensocial.spi.AppDataService' import. | 17 |
|
Wrong order for 'com.atlassian.gadgets.opensocial.model.Person' import. | 18 |
|
Wrong order for 'com.atlassian.gadgets.opensocial.spi.AppDataServiceException' import. | 20 |
|
Wrong order for 'com.atlassian.gadgets.opensocial.model.AppId' import. | 21 |
|
Line is longer than 120 characters. | 24 |
|
Wrong order for 'com.atlassian.gadgets.opensocial.internal.ShindigOpenSocialTypeAdapter.convertShindigSecurityTokenToRequestContext' import. | 24 |
|
Wrong order for 'com.atlassian.gadgets.opensocial.OpenSocialRequestContext' import. | 25 |
|
Wrong order for 'com.atlassian.sal.api.transaction.TransactionCallback' import. | 28 |
|
Wrong order for 'com.atlassian.sal.api.ApplicationProperties' import. | 29 |
|
First sentence should end with a period. | 31 |
|
Line has trailing spaces. | 32 |
|
Line is longer than 120 characters. | 32 |
|
Class Fan-Out Complexity is 20 (max allowed is 10). | 34 |
|
Static variable definition in wrong order. | 40 |
|
Line is longer than 120 characters. | 43 |
|
Method 'getPersonData' is not designed for extension - needs to be abstract, final or empty. | 51 |
|
Line is longer than 120 characters. | 52 |
|
Line is longer than 120 characters. | 56 |
|
Line is longer than 120 characters. | 57 |
|
Missing a Javadoc comment. | 59 |
|
Line is longer than 120 characters. | 62 |
|
Line is longer than 120 characters. | 89 |
|
Method 'deletePersonData' is not designed for extension - needs to be abstract, final or empty. | 89 |
|
Line is longer than 120 characters. | 93 |
|
Line is longer than 120 characters. | 94 |
|
Missing a Javadoc comment. | 98 |
|
Line is longer than 120 characters. | 105 |
|
Line is longer than 120 characters. | 109 |
|
Line is longer than 120 characters. | 123 |
|
Method 'updatePersonData' is not designed for extension - needs to be abstract, final or empty. | 123 |
|
Line is longer than 120 characters. | 127 |
|
Missing a Javadoc comment. | 130 |
|
Line is longer than 120 characters. | 132 |
|
Line is longer than 120 characters. | 136 |
| Violation | Message | Line |
|---|---|---|
|
Missing package-info.java file. | 0 |
|
Wrong order for 'org.apache.shindig.social.core.model.NameImpl' import. | 4 |
|
Wrong order for 'org.apache.shindig.social.core.model.MediaItemImpl' import. | 5 |
|
Wrong order for 'com.atlassian.gadgets.opensocial.spi.PersonService' import. | 8 |
|
Wrong order for 'com.atlassian.gadgets.opensocial.model.Group' import. | 9 |
|
Wrong order for 'com.atlassian.gadgets.opensocial.model.Activity' import. | 11 |
|
Wrong order for 'com.atlassian.gadgets.opensocial.model.AppId' import. | 13 |
|
Wrong order for 'com.atlassian.gadgets.opensocial.model.ActivityId' import. | 14 |
|
Wrong order for 'com.atlassian.gadgets.opensocial.OpenSocialRequestContext' import. | 16 |
|
'com.google.common.base.Function' should be separated from previous imports. | 17 |
|
Wrong order for 'com.google.common.base.Functions' import. | 20 |
|
Wrong order for 'java.util.Set' import. | 23 |
|
Wrong order for 'java.util.HashSet' import. | 24 |
|
Wrong order for 'java.net.URI' import. | 26 |
|
First sentence should end with a period. | 28 |
|
Class ShindigOpenSocialTypeAdapter should be declared as final. | 31 |
|
Class Data Abstraction Coupling is 9 (max allowed is 7) classes [Activity.Builder, Function, HashSet, MediaItem.Builder, MediaItemImpl, NameImpl, OpenSocialRequestContext, PersonImpl, org.apache.shindig.social.core.model.ActivityImpl]. | 31 |
|
Class Fan-Out Complexity is 23 (max allowed is 10). | 31 |
|
First sentence should end with a period. | 38 |
|
Line is longer than 120 characters. | 41 |
|
Line is longer than 120 characters. | 50 |
|
First sentence should end with a period. | 53 |
|
Line is longer than 120 characters. | 57 |
|
Line is longer than 120 characters. | 59 |
|
Cyclomatic Complexity is 20 (max allowed is 10). | 59 |
|
NPath Complexity is 131,072 (max allowed is 20). | 59 |
|
Line is longer than 120 characters. | 66 |
|
'cast' is not followed by whitespace. | 66 |
|
Line is longer than 120 characters. | 67 |
|
Line is longer than 120 characters. | 91 |
|
First sentence should end with a period. | 138 |
|
NPath Complexity is 32 (max allowed is 20). | 143 |
|
First sentence should end with a period. | 182 |
|
First sentence should end with a period. | 202 |
|
Line is longer than 120 characters. | 207 |
|
Missing a Javadoc comment. | 211 |
|
Missing a Javadoc comment. | 216 |
|
Missing a Javadoc comment. | 221 |
|
Missing a Javadoc comment. | 226 |
|
First sentence should end with a period. | 233 |
|
Line is longer than 120 characters. | 242 |
|
Line is longer than 120 characters. | 252 |
|
Line is longer than 120 characters. | 264 |
|
First sentence should end with a period. | 275 |
|
Line is longer than 120 characters. | 280 |
|
Missing a Javadoc comment. | 284 |
|
First sentence should end with a period. | 291 |
|
Line is longer than 120 characters. | 294 |
|
Line has trailing spaces. | 304 |
|
Line is longer than 120 characters. | 304 |
|
First sentence should end with a period. | 308 |
|
Line is longer than 120 characters. | 312 |
|
Missing a Javadoc comment. | 316 |
|
Line has trailing spaces. | 322 |
|
First sentence should end with a period. | 323 |
|
Line is longer than 120 characters. | 326 |
|
First sentence should end with a period. | 341 |
|
Line is longer than 120 characters. | 345 |
|
Missing a Javadoc comment. | 349 |
| Violation | Message | Line |
|---|---|---|
|
Wrong order for 'org.apache.shindig.social.ResponseError' import. | 8 |
|
Wrong order for 'org.apache.shindig.common.util.ImmediateFuture' import. | 9 |
|
Wrong order for 'java.util.concurrent.Future' import. | 11 |
|
Wrong order for 'java.util.ArrayList' import. | 12 |
|
Wrong order for 'com.atlassian.gadgets.opensocial.model.Person' import. | 19 |
|
Wrong order for 'com.atlassian.gadgets.opensocial.OpenSocialRequestContext' import. | 21 |
|
Line is longer than 120 characters. | 24 |
|
Wrong order for 'com.atlassian.gadgets.opensocial.internal.ShindigOpenSocialTypeAdapter.convertShindigSecurityTokenToRequestContext' import. | 24 |
|
Wrong order for 'com.atlassian.gadgets.opensocial.internal.ShindigOpenSocialTypeAdapter.convertPersonToShindigPerson' import. | 25 |
|
Wrong order for 'com.atlassian.sal.api.transaction.TransactionTemplate' import. | 26 |
|
Wrong order for 'com.atlassian.sal.api.transaction.TransactionCallback' import. | 27 |
|
'com.google.inject.Inject' should be separated from previous imports. | 28 |
|
Wrong order for 'com.google.common.collect.Collections2' import. | 29 |
|
Line is longer than 120 characters. | 32 |
|
Class Fan-Out Complexity is 18 (max allowed is 10). | 34 |
|
Static variable definition in wrong order. | 39 |
|
Line is longer than 120 characters. | 42 |
|
Missing a Javadoc comment. | 42 |
|
Method 'getPeople' is not designed for extension - needs to be abstract, final or empty. | 57 |
|
Line is longer than 120 characters. | 58 |
|
',' is not followed by whitespace. | 58 |
|
Missing a Javadoc comment. | 64 |
|
Line is longer than 120 characters. | 71 |
|
Line is longer than 120 characters. | 73 |
|
Line is longer than 120 characters. | 83 |
|
Line is longer than 120 characters. | 84 |
|
Line is longer than 120 characters. | 92 |
|
Method 'getPerson' is not designed for extension - needs to be abstract, final or empty. | 92 |
|
Line is longer than 120 characters. | 96 |
|
Missing a Javadoc comment. | 99 |
| Violation | Message | Line |
|---|---|---|
|
Missing package-info.java file. | 0 |
|
Wrong order for 'org.apache.shindig.social.opensocial.spi.ActivityService' import. | 15 |
|
Wrong order for 'com.google.inject.AbstractModule' import. | 18 |
|
First sentence should end with a period. | 21 |
|
Line is longer than 120 characters. | 30 |
|
Method 'configure' is not designed for extension - needs to be abstract, final or empty. | 36 |
| Violation | Message | Line |
|---|---|---|
|
Wrong order for 'com.atlassian.gadgets.view.ViewType' import. | 13 |
|
'com.google.common.collect.ImmutableList' should be separated from previous imports. | 15 |
|
Line has trailing spaces. | 23 |
|
Missing a Javadoc comment. | 28 |
|
Utility classes should not have a public or default constructor. | 28 |
|
Missing a Javadoc comment. | 30 |
|
Missing a Javadoc comment. | 31 |
|
Line has trailing spaces. | 33 |
|
Missing a Javadoc comment. | 34 |
|
Missing a Javadoc comment. | 35 |
|
Missing a Javadoc comment. | 36 |
|
Line has trailing spaces. | 37 |
|
Line has trailing spaces. | 42 |
|
Line is longer than 120 characters. | 55 |
|
Line is longer than 120 characters. | 106 |
|
Line is longer than 120 characters. | 107 |
|
Line is longer than 120 characters. | 110 |
|
Line is longer than 120 characters. | 111 |
|
Line is longer than 120 characters. | 132 |
|
',' is not followed by whitespace. | 132 |
|
Line has trailing spaces. | 140 |
|
Line has trailing spaces. | 142 |
|
Line has trailing spaces. | 143 |
|
'(' is preceded with whitespace. | 151 |
|
Line has trailing spaces. | 159 |
|
Line has trailing spaces. | 161 |
|
Line has trailing spaces. | 162 |
|
Line has trailing spaces. | 190 |
|
Line has trailing spaces. | 192 |
|
Line has trailing spaces. | 193 |
|
Method 'getContainers' is not designed for extension - needs to be abstract, final or empty. | 211 |
|
Method 'getJson' is not designed for extension - needs to be abstract, final or empty. | 228 |
|
Method 'get' is not designed for extension - needs to be abstract, final or empty. | 262 |
|
Method 'getJsonObject' is not designed for extension - needs to be abstract, final or empty. | 268 |
|
Method 'getJsonArray' is not designed for extension - needs to be abstract, final or empty. | 274 |
| Violation | Message | Line |
|---|---|---|
|
Unused import - org.apache.shindig.gadgets.oauth.GadgetOAuthCallbackGenerator. | 4 |
|
Wrong order for 'com.google.inject.Singleton' import. | 10 |
|
Method 'generateCallback' is not designed for extension - needs to be abstract, final or empty. | 19 |
|
Line has trailing spaces. | 22 |
|
method def throws at indentation level 12 not at correct indentation, 8 | 23 |
| Violation | Message | Line |
|---|---|---|
|
Missing a Javadoc comment. | 16 |
|
Line has trailing spaces. | 31 |
|
Missing a Javadoc comment. | 40 |
|
Line has trailing spaces. | 55 |
|
Method 'unwrap' is not designed for extension - needs to be abstract, final or empty. | 56 |
|
Method 'wrap' is not designed for extension - needs to be abstract, final or empty. | 61 |
| Violation | Message | Line |
|---|---|---|
|
Line has trailing spaces. | 21 |
|
Method 'getDomain' is not designed for extension - needs to be abstract, final or empty. | 24 |
| Violation | Message | Line |
|---|---|---|
|
Missing package-info.java file. | 0 |
|
Wrong order for 'java.util.Map' import. | 5 |
|
Wrong order for 'com.atlassian.gadgets.renderer.internal.AtlassianContainerConfig.Containers' import. | 14 |
|
Missing a Javadoc comment. | 16 |
|
Line has trailing spaces. | 24 |
|
Method 'createToken' is not designed for extension - needs to be abstract, final or empty. | 30 |
|
Line has trailing spaces. | 60 |
|
Static variable definition in wrong order. | 61 |
|
Static variable definition in wrong order. | 63 |
|
Static variable definition in wrong order. | 64 |
|
Static variable definition in wrong order. | 65 |
|
Static variable definition in wrong order. | 66 |
|
Static variable definition in wrong order. | 67 |
|
Line has trailing spaces. | 72 |
|
Line has trailing spaces. | 74 |
|
Line has trailing spaces. | 80 |
| Violation | Message | Line |
|---|---|---|
|
Missing a Javadoc comment. | 5 |
|
Method 'getParameterValue' is not designed for extension - needs to be abstract, final or empty. | 14 |
|
Method 'getName' is not designed for extension - needs to be abstract, final or empty. | 19 |
| Violation | Message | Line |
|---|---|---|
|
Wrong order for 'com.atlassian.gadgets.GadgetRequestContextFactory' import. | 5 |
|
Wrong order for 'com.atlassian.gadgets.GadgetRequestContext' import. | 6 |
|
Wrong order for 'javax.servlet.http.HttpServletRequest' import. | 9 |
|
Wrong order for 'java.util.Locale' import. | 10 |
|
Missing a Javadoc comment. | 19 |
|
'static' modifier out of order with the JLS suggestions. | 19 |
|
Missing a Javadoc comment. | 20 |
|
'static' modifier out of order with the JLS suggestions. | 20 |
|
Line has trailing spaces. | 28 |
|
Line has trailing spaces. | 58 |
|
Line is longer than 120 characters. | 59 |
| Violation | Message | Line |
|---|---|---|
|
Wrong order for 'java.util.Collections.unmodifiableCollection' import. | 6 |
|
Wrong order for 'java.net.URI' import. | 9 |
|
Wrong order for 'com.atlassian.gadgets.GadgetParsingException' import. | 26 |
|
'com.google.common.base.Function' should be separated from previous imports. | 36 |
|
Class Fan-Out Complexity is 23 (max allowed is 10). | 43 |
|
Line is longer than 120 characters. | 68 |
|
Method 'getGadgetSpec' is not designed for extension - needs to be abstract, final or empty. | 68 |
|
Method 'getGadgetSpec' is not designed for extension - needs to be abstract, final or empty. | 73 |
|
',' is not followed by whitespace. | 75 |
|
Line has trailing spaces. | 119 |
| Violation | Message | Line |
|---|---|---|
|
Wrong order for 'com.atlassian.gadgets.GadgetSpecUriNotAllowedException' import. | 8 |
|
'com.google.common.collect.Iterables' should be separated from previous imports. | 12 |
|
Method 'assertRenderable' is not designed for extension - needs to be abstract, final or empty. | 49 |
|
NPath Complexity is 36 (max allowed is 20). | 49 |
|
'+' should be on a new line. | 54 |
|
Line has trailing spaces. | 63 |
|
'+' should be on a new line. | 79 |
|
switch without "default" clause. | 82 |
|
'+' should be on a new line. | 85 |
|
'+' should be on a new line. | 99 |
| Violation | Message | Line |
|---|---|---|
|
Wrong order for 'com.atlassian.gadgets.view.SecurityTokenFactory' import. | 6 |
|
Missing a Javadoc comment. | 13 |
|
Line has trailing spaces. | 27 |
|
Method 'newSecurityToken' is not designed for extension - needs to be abstract, final or empty. | 28 |
|
Line is longer than 120 characters. | 30 |
|
Line has trailing spaces. | 39 |
| Violation | Message | Line |
|---|---|---|
|
Wrong order for 'org.apache.shindig.gadgets.oauth.OAuthModule.OAuthCrypterProvider' import. | 9 |
|
Wrong order for 'com.atlassian.gadgets.renderer.internal.AtlassianOAuthCallbackGenerator' import. | 12 |
|
'com.google.inject.AbstractModule' should be separated from previous imports. | 17 |
|
Unused import - com.google.inject.Module. | 18 |
|
Line has trailing spaces. | 35 |
|
Method 'configure' is not designed for extension - needs to be abstract, final or empty. | 36 |
|
Line has trailing spaces. | 51 |
|
Line has trailing spaces. | 54 |
|
Line has trailing spaces. | 57 |
| Violation | Message | Line |
|---|---|---|
|
Wrong order for 'com.atlassian.gadgets.opensocial.internal.guice.OpenSocialModule' import. | 7 |
|
First sentence should end with a period. | 9 |
|
Line has trailing spaces. | 15 |
|
Line is longer than 120 characters. | 16 |
|
Method 'get' is not designed for extension - needs to be abstract, final or empty. | 26 |
| Violation | Message | Line |
|---|---|---|
|
'com.google.inject.AbstractModule' should be separated from previous imports. | 7 |
|
Missing a Javadoc comment. | 9 |
|
Method 'configure' is not designed for extension - needs to be abstract, final or empty. | 27 |
| Violation | Message | Line |
|---|---|---|
|
Missing package-info.java file. | 0 |
|
Wrong order for 'java.io.IOException' import. | 5 |
|
Wrong order for 'com.atlassian.gadgets.LocalGadgetSpecProvider' import. | 28 |
|
'com.google.common.collect.ImmutableList' should be separated from previous imports. | 34 |
|
'static' modifier out of order with the JLS suggestions. | 49 |
|
'static' modifier out of order with the JLS suggestions. | 50 |
|
'properties' hides a field. | 66 |
|
Method 'configure' is not designed for extension - needs to be abstract, final or empty. | 85 |
|
Line has trailing spaces. | 89 |
|
'{' is not followed by whitespace. | 96 |
|
'}' is not preceded with whitespace. | 96 |
|
Line has trailing spaces. | 99 |
|
Line has trailing spaces. | 100 |
|
Line is longer than 120 characters. | 100 |
|
'{' is not preceded with whitespace. | 107 |
|
'{' is not followed by whitespace. | 107 |
|
'}' is not preceded with whitespace. | 107 |
|
'{' is not preceded with whitespace. | 108 |
|
'{' is not followed by whitespace. | 108 |
|
'}' is not preceded with whitespace. | 108 |
|
Missing a Javadoc comment. | 115 |
|
Line has trailing spaces. | 120 |
|
Missing a Javadoc comment. | 132 |
|
'{' should be on a new line. | 142 |
| Violation | Message | Line |
|---|---|---|
|
Wrong order for 'com.google.inject.AbstractModule' import. | 8 |
|
Method 'configure' is not designed for extension - needs to be abstract, final or empty. | 17 |
|
Line has trailing spaces. | 23 |
|
Missing a Javadoc comment. | 24 |
|
Method 'get' is not designed for extension - needs to be abstract, final or empty. | 26 |
| Violation | Message | Line |
|---|---|---|
|
'org.apache.commons.io.IOUtils' should be separated from previous imports. | 7 |
|
Wrong order for 'javax.net.ssl.SSLException' import. | 47 |
|
Wrong order for 'java.io.IOException' import. | 49 |
|
Class Data Abstraction Coupling is 10 (max allowed is 7) classes [BasicHeader, BasicHttpParams, CustomSSLSocketFactory, DefaultHttpClient, GzipDeflatingInterceptor, HttpCacheKey, HttpResponseBuilder, InputStreamEntity, ProxySelectorRoutePlanner, Scheme]. | 65 |
|
Class Fan-Out Complexity is 26 (max allowed is 10). | 65 |
|
'{' should be on a new line. | 66 |
|
member def modifier at indentation level 2 not at correct indentation, 4 | 67 |
|
member def modifier at indentation level 2 not at correct indentation, 4 | 69 |
|
member def modifier at indentation level 2 not at correct indentation, 4 | 71 |
|
ctor def modifier at indentation level 2 not at correct indentation, 4 | 73 |
|
ctor def modifier at indentation level 2 not at correct indentation, 4 | 74 |
|
'{' should be on a new line. | 74 |
|
ctor def child at indentation level 6 not at correct indentation, 8 | 75 |
|
ctor def rcurly at indentation level 2 not at correct indentation, 4 | 76 |
|
method def modifier at indentation level 2 not at correct indentation, 4 | 79 |
|
Method 'fetch' is not designed for extension - needs to be abstract, final or empty. | 79 |
|
'{' should be on a new line. | 79 |
|
method def child at indentation level 4 not at correct indentation, 8 | 80 |
|
method def child at indentation level 4 not at correct indentation, 8 | 81 |
|
if at indentation level 4 not at correct indentation, 8 | 82 |
|
'{' should be on a new line. | 82 |
|
if child at indentation level 6 not at correct indentation, 12 | 83 |
|
if rcurly at indentation level 4 not at correct indentation, 8 | 84 |
|
try at indentation level 4 not at correct indentation, 8 | 85 |
|
'{' should be on a new line. | 85 |
|
try child at indentation level 6 not at correct indentation, 12 | 86 |
|
if at indentation level 6 not at correct indentation, 12 | 87 |
|
'{' should be on a new line. | 87 |
|
Line is longer than 120 characters. | 88 |
|
if child at indentation level 8 not at correct indentation, 16 | 88 |
|
method call child at indentation level 8 not at correct indentation, 16 | 88 |
|
if rcurly at indentation level 6 not at correct indentation, 12 | 89 |
|
try child at indentation level 6 not at correct indentation, 12 | 90 |
|
try at indentation level 6 not at correct indentation, 12 | 91 |
|
'{' should be on a new line. | 91 |
|
try child at indentation level 8 not at correct indentation, 16 | 93 |
|
try rcurly at indentation level 6 not at correct indentation, 12 | 94 |
|
'}' should be alone on a line. | 94 |
|
'{' should be on a new line. | 94 |
|
catch child at indentation level 10 not at correct indentation, 16 | 95 |
|
method call child at indentation level 10 not at correct indentation, 16 | 95 |
|
catch child at indentation level 10 not at correct indentation, 16 | 97 |
|
catch rcurly at indentation level 6 not at correct indentation, 12 | 98 |
|
try child at indentation level 6 not at correct indentation, 12 | 99 |
|
try child at indentation level 6 not at correct indentation, 12 | 100 |
|
try rcurly at indentation level 4 not at correct indentation, 8 | 101 |
|
'}' should be alone on a line. | 101 |
|
'{' should be on a new line. | 101 |
|
if at indentation level 6 not at correct indentation, 12 | 102 |
|
'{' should be on a new line. | 102 |
|
if child at indentation level 10 not at correct indentation, 16 | 103 |
|
if rcurly at indentation level 6 not at correct indentation, 12 | 104 |
|
'}' should be alone on a line. | 104 |
|
'{' should be on a new line. | 104 |
|
else child at indentation level 10 not at correct indentation, 16 | 105 |
|
method call child at indentation level 10 not at correct indentation, 16 | 105 |
|
else rcurly at indentation level 6 not at correct indentation, 12 | 106 |
|
catch child at indentation level 6 not at correct indentation, 12 | 107 |
|
catch rcurly at indentation level 4 not at correct indentation, 8 | 108 |
|
method def rcurly at indentation level 2 not at correct indentation, 4 | 109 |
|
method def modifier at indentation level 2 not at correct indentation, 4 | 111 |
|
method def lcurly at indentation level 2 not at correct indentation, 4 | 112 |
|
method def child at indentation level 6 not at correct indentation, 8 | 113 |
|
method call child at indentation level 6 not at correct indentation, 8 | 114 |
|
method def child at indentation level 6 not at correct indentation, 8 | 114 |
|
if at indentation level 6 not at correct indentation, 8 | 117 |
|
'if' is not followed by whitespace. | 117 |
|
if lcurly at indentation level 6 not at correct indentation, 8 | 118 |
|
if child at indentation level 10 not at correct indentation, 12 | 119 |
|
method call child at indentation level 10 not at correct indentation, 12 | 119 |
|
if child at indentation level 10 not at correct indentation, 12 | 120 |
|
method call child at indentation level 10 not at correct indentation, 12 | 120 |
|
'3' is a magic number. | 120 |
|
if rcurly at indentation level 6 not at correct indentation, 8 | 121 |
|
Line is longer than 120 characters. | 122 |
|
method call child at indentation level 6 not at correct indentation, 8 | 122 |
|
method def child at indentation level 6 not at correct indentation, 8 | 122 |
|
method def child at indentation level 6 not at correct indentation, 8 | 123 |
|
method def child at indentation level 6 not at correct indentation, 8 | 125 |
|
method call child at indentation level 6 not at correct indentation, 8 | 128 |
|
method def child at indentation level 6 not at correct indentation, 8 | 128 |
|
method call child at indentation level 6 not at correct indentation, 8 | 130 |
|
method def child at indentation level 6 not at correct indentation, 8 | 130 |
|
Line is longer than 120 characters. | 131 |
|
method call child at indentation level 6 not at correct indentation, 8 | 131 |
|
method def child at indentation level 6 not at correct indentation, 8 | 131 |
|
'443' is a magic number. | 131 |
|
method def child at indentation level 6 not at correct indentation, 8 | 132 |
|
method def rcurly at indentation level 2 not at correct indentation, 4 | 133 |
|
method def modifier at indentation level 2 not at correct indentation, 4 | 135 |
|
'{' should be on a new line. | 135 |
|
method def child at indentation level 4 not at correct indentation, 8 | 136 |
|
method def child at indentation level 4 not at correct indentation, 8 | 137 |
|
for at indentation level 4 not at correct indentation, 8 | 139 |
|
'{' should be on a new line. | 139 |
|
for child at indentation level 6 not at correct indentation, 12 | 140 |
|
method call child at indentation level 6 not at correct indentation, 12 | 140 |
|
for rcurly at indentation level 4 not at correct indentation, 8 | 141 |
|
method def child at indentation level 4 not at correct indentation, 8 | 142 |
|
method def rcurly at indentation level 2 not at correct indentation, 4 | 143 |
|
method def modifier at indentation level 2 not at correct indentation, 4 | 145 |
|
'{' should be on a new line. | 145 |
|
method def child at indentation level 4 not at correct indentation, 8 | 146 |
|
for at indentation level 4 not at correct indentation, 8 | 147 |
|
'{' should be on a new line. | 147 |
|
for child at indentation level 8 not at correct indentation, 12 | 148 |
|
method call child at indentation level 8 not at correct indentation, 12 | 148 |
|
for rcurly at indentation level 4 not at correct indentation, 8 | 149 |
|
method def child at indentation level 4 not at correct indentation, 8 | 151 |
|
method def rcurly at indentation level 2 not at correct indentation, 4 | 155 |
|
class def child at indentation level 2 not at correct indentation, 4 | 161 |
|
class def ident at indentation level 2 not at correct indentation, 4 | 161 |
|
class def modifier at indentation level 2 not at correct indentation, 4 | 161 |
|
'{' should be on a new line. | 161 |
|
member def modifier at indentation level 4 not at correct indentation, 8 | 162 |
|
member def modifier at indentation level 4 not at correct indentation, 8 | 163 |
|
ctor def modifier at indentation level 4 not at correct indentation, 8 | 165 |
|
'{' should be on a new line. | 165 |
|
ctor def child at indentation level 6 not at correct indentation, 12 | 166 |
|
ctor def rcurly at indentation level 4 not at correct indentation, 8 | 167 |
|
method def modifier at indentation level 4 not at correct indentation, 8 | 169 |
|
'{' should be on a new line. | 169 |
|
method def child at indentation level 6 not at correct indentation, 12 | 170 |
|
method call child at indentation level 6 not at correct indentation, 12 | 171 |
|
method def child at indentation level 6 not at correct indentation, 12 | 171 |
|
'{' is followed by whitespace. | 171 |
|
method def child at indentation level 6 not at correct indentation, 12 | 172 |
|
method def rcurly at indentation level 4 not at correct indentation, 8 | 173 |
|
Line is longer than 120 characters. | 175 |
|
method def modifier at indentation level 4 not at correct indentation, 8 | 175 |
|
method def throws at indentation level 8 not at correct indentation, 12 | 176 |
|
Redundant throws: 'UnknownHostException' is subclass of 'IOException'. | 176 |
|
Redundant throws: 'ConnectTimeoutException' is subclass of 'IOException'. | 176 |
|
'{' should be on a new line. | 176 |
|
method def child at indentation level 6 not at correct indentation, 12 | 177 |
|
method def rcurly at indentation level 4 not at correct indentation, 8 | 178 |
|
method def modifier at indentation level 4 not at correct indentation, 8 | 180 |
|
'{' should be on a new line. | 180 |
|
method def child at indentation level 6 not at correct indentation, 12 | 181 |
|
method def rcurly at indentation level 4 not at correct indentation, 8 | 182 |
|
Line is longer than 120 characters. | 184 |
|
method def modifier at indentation level 4 not at correct indentation, 8 | 184 |
|
Redundant throws: 'UnknownHostException' is subclass of 'IOException'. | 184 |
|
'{' should be on a new line. | 184 |
|
method def child at indentation level 6 not at correct indentation, 12 | 185 |
|
method def rcurly at indentation level 4 not at correct indentation, 8 | 186 |
|
class def rcurly at indentation level 2 not at correct indentation, 4 | 187 |
|
class def child at indentation level 2 not at correct indentation, 4 | 189 |
|
class def ident at indentation level 2 not at correct indentation, 4 | 189 |
|
class def modifier at indentation level 2 not at correct indentation, 4 | 189 |
|
'{' should be on a new line. | 189 |
|
Line is longer than 120 characters. | 190 |
|
method def modifier at indentation level 4 not at correct indentation, 8 | 190 |
|
'{' should be on a new line. | 190 |
|
method def child at indentation level 6 not at correct indentation, 12 | 191 |
|
method def child at indentation level 6 not at correct indentation, 12 | 192 |
|
if at indentation level 6 not at correct indentation, 12 | 193 |
|
'{' should be on a new line. | 193 |
|
if child at indentation level 8 not at correct indentation, 16 | 194 |
|
for at indentation level 8 not at correct indentation, 16 | 195 |
|
'{' should be on a new line. | 195 |
|
if at indentation level 10 not at correct indentation, 20 | 196 |
|
'{' should be on a new line. | 196 |
|
if child at indentation level 12 not at correct indentation, 24 | 197 |
|
method call child at indentation level 12 not at correct indentation, 24 | 197 |
|
if child at indentation level 12 not at correct indentation, 24 | 198 |
|
if rcurly at indentation level 10 not at correct indentation, 20 | 199 |
|
'}' should be alone on a line. | 199 |
|
'{' should be on a new line. | 199 |
|
if child at indentation level 12 not at correct indentation, 24 | 200 |
|
method call child at indentation level 12 not at correct indentation, 24 | 200 |
|
if child at indentation level 12 not at correct indentation, 24 | 201 |
|
if rcurly at indentation level 10 not at correct indentation, 20 | 202 |
|
for rcurly at indentation level 8 not at correct indentation, 16 | 203 |
|
if rcurly at indentation level 6 not at correct indentation, 12 | 204 |
|
method def rcurly at indentation level 4 not at correct indentation, 8 | 205 |
|
class def rcurly at indentation level 2 not at correct indentation, 4 | 206 |
|
class def child at indentation level 2 not at correct indentation, 4 | 208 |
|
class def ident at indentation level 2 not at correct indentation, 4 | 208 |
|
class def modifier at indentation level 2 not at correct indentation, 4 | 208 |
|
'abstract' modifier out of order with the JLS suggestions. | 208 |
|
'{' should be on a new line. | 208 |
|
ctor def modifier at indentation level 4 not at correct indentation, 8 | 209 |
|
'{' should be on a new line. | 209 |
|
ctor def rcurly at indentation level 4 not at correct indentation, 8 | 211 |
|
method def modifier at indentation level 4 not at correct indentation, 8 | 213 |
|
method def modifier at indentation level 4 not at correct indentation, 8 | 214 |
|
'{' should be on a new line. | 214 |
|
method def child at indentation level 6 not at correct indentation, 12 | 216 |
|
method def rcurly at indentation level 4 not at correct indentation, 8 | 217 |
|
method def modifier at indentation level 4 not at correct indentation, 8 | 219 |
|
method def modifier at indentation level 4 not at correct indentation, 8 | 220 |
|
'{' should be on a new line. | 220 |
|
method def child at indentation level 6 not at correct indentation, 12 | 222 |
|
method def rcurly at indentation level 4 not at correct indentation, 8 | 223 |
|
method def modifier at indentation level 4 not at correct indentation, 8 | 225 |
|
class def rcurly at indentation level 2 not at correct indentation, 4 | 226 |
|
class def child at indentation level 2 not at correct indentation, 4 | 228 |
|
class def ident at indentation level 2 not at correct indentation, 4 | 228 |
|
class def modifier at indentation level 2 not at correct indentation, 4 | 228 |
|
'{' should be on a new line. | 228 |
|
ctor def modifier at indentation level 4 not at correct indentation, 8 | 229 |
|
'{' should be on a new line. | 229 |
|
ctor def rcurly at indentation level 4 not at correct indentation, 8 | 231 |
|
method def modifier at indentation level 4 not at correct indentation, 8 | 233 |
|
method def modifier at indentation level 4 not at correct indentation, 8 | 234 |
|
'{' should be on a new line. | 234 |
|
method def child at indentation level 6 not at correct indentation, 12 | 235 |
|
method def rcurly at indentation level 4 not at correct indentation, 8 | 236 |
|
class def rcurly at indentation level 2 not at correct indentation, 4 | 237 |
|
class def child at indentation level 2 not at correct indentation, 4 | 239 |
|
class def ident at indentation level 2 not at correct indentation, 4 | 239 |
|
class def modifier at indentation level 2 not at correct indentation, 4 | 239 |
|
'{' should be on a new line. | 239 |
|
ctor def modifier at indentation level 4 not at correct indentation, 8 | 240 |
|
'{' should be on a new line. | 240 |
|
ctor def rcurly at indentation level 4 not at correct indentation, 8 | 242 |
|
method def modifier at indentation level 4 not at correct indentation, 8 | 244 |
|
method def modifier at indentation level 4 not at correct indentation, 8 | 245 |
|
'{' should be on a new line. | 245 |
|
method def child at indentation level 6 not at correct indentation, 12 | 246 |
|
method def rcurly at indentation level 4 not at correct indentation, 8 | 247 |
|
class def rcurly at indentation level 2 not at correct indentation, 4 | 248 |
|
enum def child at indentation level 2 not at correct indentation, 4 | 250 |
|
enum def ident at indentation level 2 not at correct indentation, 4 | 250 |
|
enum def modifier at indentation level 2 not at correct indentation, 4 | 250 |
|
'{' should be on a new line. | 250 |
|
method def modifier at indentation level 4 not at correct indentation, 8 | 253 |
|
'{' should be on a new line. | 253 |
|
switch at indentation level 6 not at correct indentation, 12 | 254 |
|
switch without "default" clause. | 254 |
|
'{' should be on a new line. | 254 |
|
block child at indentation level 8 not at correct indentation, 20 | 255 |
|
case child at indentation level 8 not at correct indentation, 16 | 255 |
|
block child at indentation level 8 not at correct indentation, 20 | 256 |
|
case child at indentation level 8 not at correct indentation, 16 | 256 |
|
block child at indentation level 8 not at correct indentation, 20 | 257 |
|
case child at indentation level 8 not at correct indentation, 16 | 257 |
|
block child at indentation level 8 not at correct indentation, 20 | 258 |
|
case child at indentation level 8 not at correct indentation, 16 | 258 |
|
block child at indentation level 8 not at correct indentation, 20 | 259 |
|
case child at indentation level 8 not at correct indentation, 16 | 259 |
|
block child at indentation level 8 not at correct indentation, 20 | 260 |
|
case child at indentation level 8 not at correct indentation, 16 | 260 |
|
block child at indentation level 8 not at correct indentation, 20 | 261 |
|
case child at indentation level 8 not at correct indentation, 16 | 261 |
|
switch rcurly at indentation level 6 not at correct indentation, 12 | 262 |
|
method def child at indentation level 6 not at correct indentation, 12 | 263 |
|
method def rcurly at indentation level 4 not at correct indentation, 8 | 264 |
|
enum def rcurly at indentation level 2 not at correct indentation, 4 | 265 |
| Violation | Message | Line |
|---|---|---|
|
Missing package-info.java file. | 0 |
|
Wrong order for 'org.apache.shindig.gadgets.GadgetException' import. | 5 |
|
Wrong order for 'com.atlassian.sal.api.user.UserManager' import. | 12 |
|
'com.google.inject.Inject' should be separated from previous imports. | 16 |
|
Line has trailing spaces. | 38 |
|
Method 'fetch' is not designed for extension - needs to be abstract, final or empty. | 39 |
|
Line has trailing spaces. | 49 |
|
'!=' is not preceded with whitespace. | 50 |
|
'!=' is not followed by whitespace. | 50 |
| Violation | Message | Line |
|---|---|---|
|
Missing package-info.java file. | 0 |
|
Wrong order for 'com.google.common.collect.MapMaker' import. | 13 |
|
'org.apache.commons.logging.Log' should be separated from previous imports. | 17 |
|
Missing a Javadoc comment. | 49 |
|
Static variable definition in wrong order. | 49 |
|
Variable access definition in wrong order. | 49 |
|
Missing a Javadoc comment. | 50 |
|
Static variable definition in wrong order. | 50 |
|
Variable access definition in wrong order. | 50 |
|
Method 'getGadgetSpec' is not designed for extension - needs to be abstract, final or empty. | 52 |
|
Method 'getGadgetSpec' is not designed for extension - needs to be abstract, final or empty. | 65 |
|
'static' modifier out of order with the JLS suggestions. | 85 |
|
Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 85 |
|
'static' modifier out of order with the JLS suggestions. | 145 |
|
Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 145 |
|
NPath Complexity is 33 (max allowed is 20). | 154 |
|
Line is longer than 120 characters. | 181 |
|
Line is longer than 120 characters. | 190 |
|
Line is longer than 120 characters. | 199 |
|
Line is longer than 120 characters. | 204 |
| Violation | Message | Line |
|---|---|---|
|
Missing package-info.java file. | 0 |
|
Wrong order for 'net.oauth.OAuth.Parameter' import. | 9 |
|
Wrong order for 'org.apache.shindig.gadgets.http.HttpFetcher' import. | 11 |
|
Wrong order for 'com.atlassian.oauth.Request' import. | 16 |
|
Wrong order for 'com.atlassian.oauth.Request.HttpMethod' import. | 18 |
|
Missing a Javadoc comment. | 25 |
|
Class Fan-Out Complexity is 11 (max allowed is 10). | 25 |
|
Line has trailing spaces. | 29 |
|
Line has trailing spaces. | 30 |
|
Line has trailing spaces. | 31 |
|
Method 'sign' is not designed for extension - needs to be abstract, final or empty. | 38 |
|
method def throws at indentation level 12 not at correct indentation, 8 | 40 |
|
Line has trailing spaces. | 47 |
|
Line is longer than 120 characters. | 56 |
|
Line has trailing spaces. | 58 |
| Violation | Message | Line |
|---|---|---|
|
Wrong order for 'com.atlassian.oauth.consumer.ConsumerService' import. | 10 |
|
'com.google.inject.Inject' should be separated from previous imports. | 11 |
|
First sentence should end with a period. | 30 |
|
Line has trailing spaces. | 32 |
|
Method 'getOAuthFetcher' is not designed for extension - needs to be abstract, final or empty. | 35 |
| Violation | Message | Line |
|---|---|---|
|
'org.apache.commons.lang.StringUtils.isBlank' should be separated from previous imports. | 4 |
|
Wrong order for 'java.util.Map' import. | 8 |
|
Wrong order for 'org.apache.shindig.auth.SecurityToken' import. | 12 |
|
Wrong order for 'com.atlassian.gadgets.util.Uri' import. | 16 |
|
'com.google.common.collect.ImmutableMap' should be separated from previous imports. | 25 |
|
Line is longer than 120 characters. | 29 |
|
Class Fan-Out Complexity is 14 (max allowed is 10). | 33 |
|
Line has trailing spaces. | 36 |
|
Line has trailing spaces. | 50 |
|
Line is longer than 120 characters. | 51 |
|
Method 'getConsumerKeyAndSecret' is not designed for extension - needs to be abstract, final or empty. | 51 |
|
Line is longer than 120 characters. | 60 |
|
Method 'getTokenInfo' is not designed for extension - needs to be abstract, final or empty. | 60 |
|
Line is longer than 120 characters. | 74 |
|
Method 'setTokenInfo' is not designed for extension - needs to be abstract, final or empty. | 74 |
|
Boolean expression complexity is 4 (max allowed is 3). | 83 |
|
if child at indentation level 9 not at correct indentation, 12 | 84 |
|
if child at indentation level 9 not at correct indentation, 12 | 85 |
|
if child at indentation level 9 not at correct indentation, 12 | 86 |
|
Line has trailing spaces. | 91 |
|
Line has trailing spaces. | 96 |
|
Line is longer than 120 characters. | 97 |
|
Method 'removeToken' is not designed for extension - needs to be abstract, final or empty. | 97 |
|
Line has trailing spaces. | 120 |
|
Utility classes should not have a public or default constructor. | 140 |
|
Missing a Javadoc comment. | 142 |
|
Missing a Javadoc comment. | 143 |
|
Line is longer than 120 characters. | 156 |
| Violation | Message | Line |
|---|---|---|
|
Missing package-info.java file. | 0 |
|
Wrong order for 'com.google.inject.Inject' import. | 6 |
|
Missing a Javadoc comment. | 10 |
|
Method 'getProxyUrl' is not designed for extension - needs to be abstract, final or empty. | 32 |
|
Line has trailing spaces. | 38 |
|
Method 'getConcatUrl' is not designed for extension - needs to be abstract, final or empty. | 43 |
| Violation | Message | Line |
|---|---|---|
|
Missing package-info.java file. | 0 |
|
Wrong order for 'com.google.inject.Injector' import. | 9 |
|
Missing a Javadoc comment. | 12 |
|
Line has trailing spaces. | 20 |
|
Method 'contextInitialized' is not designed for extension - needs to be abstract, final or empty. | 21 |
|
Method 'contextDestroyed' is not designed for extension - needs to be abstract, final or empty. | 27 |
| Violation | Message | Line |
|---|---|---|
|
Wrong order for 'javax.servlet.FilterChain' import. | 8 |
|
Wrong order for 'java.io.IOException' import. | 11 |
|
Wrong order for 'org.apache.commons.logging.Log' import. | 18 |
|
Wrong order for 'org.apache.commons.lang.StringUtils' import. | 19 |
|
Wrong order for 'com.google.common.base.Preconditions.checkNotNull' import. | 20 |
|
Wrong order for 'com.atlassian.gadgets.GadgetSpecUrlChecker' import. | 21 |
|
Wrong order for 'com.atlassian.gadgets.GadgetSpecUriNotAllowedException' import. | 22 |
|
Class Fan-Out Complexity is 18 (max allowed is 10). | 32 |
|
Line has trailing spaces. | 41 |
|
Line has trailing spaces. | 46 |
|
Method 'doFilter' is not designed for extension - needs to be abstract, final or empty. | 62 |
|
method def throws at indentation level 12 not at correct indentation, 8 | 63 |
|
'if' is not followed by whitespace. | 99 |
|
'{' should be on a new line. | 99 |
|
Line has trailing spaces. | 112 |
|
'{' is not preceded with whitespace. | 114 |
|
'{' is not followed by whitespace. | 114 |
|
'}' is not preceded with whitespace. | 114 |
|
'{' is not followed by whitespace. | 115 |
|
'}' is not preceded with whitespace. | 115 |
|
Missing a Javadoc comment. | 117 |
|
'{' should be on a new line. | 117 |
|
Line has trailing spaces. | 120 |
|
Line is longer than 120 characters. | 122 |
|
Method 'html' is not designed for extension - needs to be abstract, final or empty. | 128 |
| Violation | Message | Line |
|---|---|---|
|
assign child at indentation level 6 not at correct indentation, 8 | 20 |
|
assign child at indentation level 6 not at correct indentation, 8 | 21 |
|
assign child at indentation level 6 not at correct indentation, 8 | 22 |
|
assign child at indentation level 6 not at correct indentation, 8 | 23 |
|
assign child at indentation level 6 not at correct indentation, 8 | 24 |
|
assign child at indentation level 6 not at correct indentation, 8 | 25 |
|
assign child at indentation level 6 not at correct indentation, 8 | 26 |
|
assign child at indentation level 6 not at correct indentation, 8 | 27 |
|
Method 'doGet' is not designed for extension - needs to be abstract, final or empty. | 29 |
| Violation | Message | Line |
|---|---|---|
|
Wrong order for 'com.atlassian.gadgets.renderer.internal.http.TrustedAppContentFetcherFactory' import. | 6 |
|
'com.google.inject.Inject' should be separated from previous imports. | 7 |
|
Missing a Javadoc comment. | 10 |
|
Line has trailing spaces. | 18 |
