Checkstyle Results

The following document contains the results of Checkstylerss feed

Summary

Files Infos Infos Warnings Warnings Errors Errors
29 41 63 137

Files

Files Infos Warnings Errors
com/atlassian/gadgets/directory/internal/ConfigurableExternalGadgetSpecStore.java 0 0 1
com/atlassian/gadgets/directory/internal/DirectoryConfigServlet.java 1 2 1
com/atlassian/gadgets/directory/internal/DirectoryConfigurationPermissionChecker.java 1 1 0
com/atlassian/gadgets/directory/internal/DirectoryEntryProvider.java 0 0 2
com/atlassian/gadgets/directory/internal/DirectoryPredicates.java 0 3 6
com/atlassian/gadgets/directory/internal/DirectoryUrlBuilder.java 0 3 2
com/atlassian/gadgets/directory/internal/GadgetFeedReaderHelper.java 0 1 2
com/atlassian/gadgets/directory/internal/GadgetFeedsSpecProvider.java 2 1 10
com/atlassian/gadgets/directory/internal/HttpCache.java 1 0 8
com/atlassian/gadgets/directory/internal/impl/AbstractDirectoryEntryProvider.java 1 4 9
com/atlassian/gadgets/directory/internal/impl/ConfigurableExternalGadgetSpecDirectoryEntryProvider.java 6 0 6
com/atlassian/gadgets/directory/internal/impl/DirectoryImpl.java 2 0 5
com/atlassian/gadgets/directory/internal/impl/DirectoryUrlBuilderImpl.java 4 1 1
com/atlassian/gadgets/directory/internal/impl/GadgetFeedReaderFactoryImpl.java 0 0 3
com/atlassian/gadgets/directory/internal/impl/GadgetFeedReaderImpl.java 0 1 7
com/atlassian/gadgets/directory/internal/impl/GadgetSpecDirectoryEntry.java 0 0 11
com/atlassian/gadgets/directory/internal/impl/GadgetSpecProviderDirectoryEntryProvider.java 4 1 7
com/atlassian/gadgets/directory/internal/impl/GadgetSpecUrlRenderPermissionImpl.java 1 1 0
com/atlassian/gadgets/directory/internal/impl/PluginExternalGadgetSpecDirectoryEntryProvider.java 6 3 3
com/atlassian/gadgets/directory/internal/impl/UnavailableFeatureException.java 0 0 1
com/atlassian/gadgets/directory/internal/jaxb/JAXBCategory.java 0 0 2
com/atlassian/gadgets/directory/internal/jaxb/JAXBDirectoryContents.java 0 1 4
com/atlassian/gadgets/directory/internal/jaxb/JAXBDirectoryEntry.java 0 1 4
com/atlassian/gadgets/directory/internal/jaxb/SubscribedGadgetFeedRepresentation.java 3 13 13
com/atlassian/gadgets/directory/internal/jaxb/SubscribedGadgetFeedsRepresentation.java 2 15 12
com/atlassian/gadgets/directory/internal/rest/DirectoryResource.java 3 0 3
com/atlassian/gadgets/directory/internal/rest/SubscribedGadgetFeedResource.java 2 2 4
com/atlassian/gadgets/directory/internal/rest/SubscribedGadgetFeedsResource.java 2 9 10

Rules

Rules Violations Severity
JavadocPackage 3 Errors Error
Translation 0 Errors Error
FileLength 0 Errors Error
FileTabCharacter
  • eachLine: "true"
0 Errors Error
RegexpSingleline
  • message: "Line has trailing spaces."
  • format: "\s+$"
42 Warnings Warning
AnnotationUseStyle 0 Errors Error
MissingDeprecated 0 Errors Error
MissingOverride
  • javaFiveCompatibility: "true"
0 Errors Error
PackageAnnotation 0 Errors Error
JavadocMethod
  • excludeScope: "private"
  • scope: "anoninner"
11 Errors Error
JavadocType
  • scope: "package"
17 Errors Error
JavadocVariable
  • scope: "package"
1 Errors Error
JavadocStyle
  • scope: "package"
4 Errors Error
ConstantName 3 Errors Error
LocalFinalVariableName 0 Errors Error
LocalVariableName 0 Errors Error
MemberName 0 Errors Error
MethodName 0 Errors Error
PackageName 0 Errors Error
ParameterName 0 Errors Error
StaticVariableName 0 Errors Error
TypeName 0 Errors Error
AvoidStarImport 0 Errors Error
IllegalImport 0 Errors Error
ImportOrder
  • separated: "true"
  • groups: "java,javax,com.atlassian,com,org"
34 Errors Error
RedundantImport 0 Errors Error
UnusedImports 0 Errors Error
LineLength
  • max: "120"
21 Warnings Warning
MethodLength 0 Errors Error
ParameterNumber 0 Errors Error
EmptyForIteratorPad 0 Errors Error
MethodParamPad 0 Errors Error
NoWhitespaceAfter 0 Errors Error
NoWhitespaceBefore 0 Errors Error
OperatorWrap 6 Errors Error
ParenPad 2 Errors Error
TypecastParenPad 0 Errors Error
WhitespaceAfter 0 Errors Error
WhitespaceAround 19 Errors Error
ModifierOrder 1 Errors Error
RedundantModifier 0 Errors Error
AvoidNestedBlocks 0 Errors Error
EmptyBlock 0 Errors Error
LeftCurly
  • option: "nl"
1 Errors Error
NeedBraces 4 Errors Error
RightCurly
  • option: "alone"
0 Errors Error
DeclarationOrder 1 Errors Error
DefaultComesLast 0 Errors Error
DoubleCheckedLocking 0 Errors Error
EmptyStatement 0 Errors Error
EqualsHashCode 0 Errors Error
ExplicitInitialization 0 Errors Error
FallThrough 0 Errors Error
HiddenField
  • ignoreConstructorParameter: "true"
  • ignoreSetter: "true"
2 Errors Error
IllegalInstantiation 0 Errors Error
InnerAssignment 0 Errors Error
MagicNumber 8 Errors Error
MissingSwitchDefault 0 Errors Error
ParameterAssignment 0 Errors Error
RedundantThrows
  • allowUnchecked: "true"
0 Errors Error
SimplifyBooleanExpression 0 Errors Error
SimplifyBooleanReturn 0 Errors Error
StringLiteralEquality 0 Errors Error
DesignForExtension 41 Infos Info
FinalClass 1 Errors Error
HideUtilityClassConstructor 1 Errors Error
InterfaceIsType 0 Errors Error
VisibilityModifier 1 Errors Error
BooleanExpressionComplexity 0 Errors Error
ClassDataAbstractionCoupling 1 Errors Error
ClassFanOutComplexity
  • max: "10"
10 Errors Error
CyclomaticComplexity 0 Errors Error
NPathComplexity
  • max: "20"
0 Errors Error
JavaNCSS 0 Errors Error
ArrayTypeStyle 0 Errors Error
Indentation 0 Errors Error
TodoComment 6 Errors Error
UpperEll 0 Errors Error

Details

com/atlassian/gadgets/directory/internal/ConfigurableExternalGadgetSpecStore.java

Violation Message Line
Errors First sentence should end with a period. 19

com/atlassian/gadgets/directory/internal/DirectoryConfigServlet.java

Violation Message Line
Errors Missing a Javadoc comment. 17
Warnings Line has trailing spaces. 29
Infos Method 'doGet' is not designed for extension - needs to be abstract, final or empty. 30
Warnings Line is longer than 120 characters. 35

com/atlassian/gadgets/directory/internal/DirectoryConfigurationPermissionChecker.java

Violation Message Line
Warnings Line is longer than 120 characters. 23
Infos Method 'checkForPermissionToConfigureDirectory' is not designed for extension - needs to be abstract, final or empty. 37

com/atlassian/gadgets/directory/internal/DirectoryEntryProvider.java

Violation Message Line
Errors Missing package-info.java file. 0
Errors Missing a Javadoc comment. 8

com/atlassian/gadgets/directory/internal/DirectoryPredicates.java

Violation Message Line
Errors First sentence should end with a period. 12
Warnings Line is longer than 120 characters. 13
Errors '{' is not followed by whitespace. 17
Errors '}' is not preceded with whitespace. 17
Warnings Line has trailing spaces. 18
Errors '(' is followed by whitespace. 49
Errors ')' is preceded with whitespace. 49
Warnings Line has trailing spaces. 55
Errors 'if' is not followed by whitespace. 56

com/atlassian/gadgets/directory/internal/DirectoryUrlBuilder.java

Violation Message Line
Errors Missing a Javadoc comment. 5
Errors First sentence should end with a period. 16
Warnings Line has trailing spaces. 27
Warnings Line has trailing spaces. 31
Warnings Line has trailing spaces. 34

com/atlassian/gadgets/directory/internal/GadgetFeedReaderHelper.java

Violation Message Line
Errors 'com.google.common.base.Function' should be separated from previous imports. 9
Errors Utility classes should not have a public or default constructor. 19
Warnings Line has trailing spaces. 137

com/atlassian/gadgets/directory/internal/GadgetFeedsSpecProvider.java

Violation Message Line
Errors 'com.google.common.base.Predicate' should be separated from previous imports. 9
Errors 'org.slf4j.Logger' should be separated from previous imports. 11
Errors Wrong order for 'java.net.URI' import. 14
Errors 'com.google.common.base.Preconditions.checkNotNull' should be separated from previous imports. 20
Errors Missing a Javadoc comment. 23
Errors Class Fan-Out Complexity is 12 (max allowed is 10). 23
Errors Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 25
Warnings Line is longer than 120 characters. 31
Infos Method 'contains' is not designed for extension - needs to be abstract, final or empty. 38
Infos Method 'entries' is not designed for extension - needs to be abstract, final or empty. 43
Errors Missing a Javadoc comment. 57
Errors 'if' construct must use '{}'s. 77
Errors 'else' construct must use '{}'s. 79

com/atlassian/gadgets/directory/internal/HttpCache.java

Violation Message Line
Errors 'org.apache.http.HttpVersion' should be separated from previous imports. 5
Errors Missing a Javadoc comment. 23
Errors Class Data Abstraction Coupling is 8 (max allowed is 7) classes [BasicHttpParams, DefaultHttpClient, HTTPClientResponseResolver, HttpTimeoutsProvider, MemoryCacheStorage, Scheme, SchemeRegistry, ThreadSafeClientConnManager]. 23
Errors Class Fan-Out Complexity is 12 (max allowed is 10). 23
Errors '80' is a magic number. 58
Errors '443' is a magic number. 60
Errors '8192' is a magic number. 76
Infos Method 'destroy' is not designed for extension - needs to be abstract, final or empty. 84
Errors '{' should be on a new line. 84

com/atlassian/gadgets/directory/internal/impl/AbstractDirectoryEntryProvider.java

Violation Message Line
Errors 'com.google.common.base.Function' should be separated from previous imports. 10
Errors 'org.apache.commons.logging.Log' should be separated from previous imports. 12
Errors Wrong order for 'java.net.URI' import. 16
Errors Missing a Javadoc comment. 28
Errors Class Fan-Out Complexity is 20 (max allowed is 10). 28
Warnings Line is longer than 120 characters. 35
Errors '15' is a magic number. 39
Errors Comment matches to-do format 'TODO:'. 44
Warnings Line is longer than 120 characters. 44
Warnings Line is longer than 120 characters. 46
Errors Missing a Javadoc comment. 51
Warnings Line is longer than 120 characters. 88
Errors Comment matches to-do format 'TODO:'. 93
Infos Method 'destroy' is not designed for extension - needs to be abstract, final or empty. 106

com/atlassian/gadgets/directory/internal/impl/ConfigurableExternalGadgetSpecDirectoryEntryProvider.java

Violation Message Line
Errors Missing package-info.java file. 0
Errors Comment matches to-do format 'TODO:'. 30
Errors Class Fan-Out Complexity is 20 (max allowed is 10). 31
Infos Method 'contains' is not designed for extension - needs to be abstract, final or empty. 54
Infos Method 'internalEntries' is not designed for extension - needs to be abstract, final or empty. 59
Infos Method 'add' is not designed for extension - needs to be abstract, final or empty. 65
Errors Missing a Javadoc comment. 69
Infos Method 'remove' is not designed for extension - needs to be abstract, final or empty. 84
Errors Missing a Javadoc comment. 88
Infos Method 'convertToLocalizedDirectoryEntry' is not designed for extension - needs to be abstract, final or empty. 96
Errors Missing a Javadoc comment. 102
Infos Method 'toString' is not designed for extension - needs to be abstract, final or empty. 148

com/atlassian/gadgets/directory/internal/impl/DirectoryImpl.java

Violation Message Line
Errors Wrong order for 'com.google.common.collect.Iterables.any' import. 16
Errors Missing a Javadoc comment. 20
Errors Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 22
Infos Method 'getEntries' is not designed for extension - needs to be abstract, final or empty. 31
Infos Method 'contains' is not designed for extension - needs to be abstract, final or empty. 36
Errors Missing a Javadoc comment. 46
Errors Missing a Javadoc comment. 72

com/atlassian/gadgets/directory/internal/impl/DirectoryUrlBuilderImpl.java

Violation Message Line
Errors Missing a Javadoc comment. 10
Infos Method 'buildDirectoryResourceUrl' is not designed for extension - needs to be abstract, final or empty. 18
Infos Method 'buildDirectoryGadgetResourceUrl' is not designed for extension - needs to be abstract, final or empty. 24
Infos Method 'buildSubscribedGadgetFeedsUrl' is not designed for extension - needs to be abstract, final or empty. 30
Warnings Line has trailing spaces. 34
Infos Method 'buildSubscribedGadgetFeedUrl' is not designed for extension - needs to be abstract, final or empty. 35

com/atlassian/gadgets/directory/internal/impl/GadgetFeedReaderFactoryImpl.java

Violation Message Line
Errors 'org.codehaus.httpcache4j.cache.HTTPCache' should be separated from previous imports. 5
Errors Wrong order for 'java.net.URI' import. 7
Errors Missing a Javadoc comment. 11

com/atlassian/gadgets/directory/internal/impl/GadgetFeedReaderImpl.java

Violation Message Line
Errors 'com.google.common.collect.ImmutableSet' should be separated from previous imports. 7
Errors 'org.apache.commons.io.IOUtils' should be separated from previous imports. 15
Errors Wrong order for 'java.io.InputStream' import. 24
Errors Missing a Javadoc comment. 34
Errors Class Fan-Out Complexity is 24 (max allowed is 10). 34
Warnings Line has trailing spaces. 66
Errors 'feed' hides a field. 69
Errors 'feed' hides a field. 131

com/atlassian/gadgets/directory/internal/impl/GadgetSpecDirectoryEntry.java

Violation Message Line
Errors 'org.apache.commons.lang.StringUtils.defaultString' should be separated from previous imports. 13
Errors Missing a Javadoc comment. 15
Errors 'static' modifier out of order with the JLS suggestions. 17
Errors '&&' should be on a new line. 123
Errors '&&' should be on a new line. 124
Errors '31' is a magic number. 133
Errors '31' is a magic number. 134
Errors '+' should be on a new line. 140
Errors '+' should be on a new line. 141
Errors '+' should be on a new line. 142
Errors '+' should be on a new line. 143

com/atlassian/gadgets/directory/internal/impl/GadgetSpecProviderDirectoryEntryProvider.java

Violation Message Line
Errors 'com.google.common.base.Function' should be separated from previous imports. 12
Errors Wrong order for 'com.google.common.collect.Iterables.any' import. 18
Errors Wrong order for 'java.util.Collections.emptySet' import. 21
Errors Class Fan-Out Complexity is 12 (max allowed is 10). 27
Infos Method 'contains' is not designed for extension - needs to be abstract, final or empty. 46
Errors Missing a Javadoc comment. 50
Infos Method 'internalEntries' is not designed for extension - needs to be abstract, final or empty. 69
Errors Missing a Javadoc comment. 74
Infos Method 'convertToLocalizedDirectoryEntry' is not designed for extension - needs to be abstract, final or empty. 97
Errors Missing a Javadoc comment. 103
Warnings Line is longer than 120 characters. 107
Infos Method 'toString' is not designed for extension - needs to be abstract, final or empty. 123

com/atlassian/gadgets/directory/internal/impl/GadgetSpecUrlRenderPermissionImpl.java

Violation Message Line
Warnings Line has trailing spaces. 27
Infos Method 'voteOn' is not designed for extension - needs to be abstract, final or empty. 28

com/atlassian/gadgets/directory/internal/impl/PluginExternalGadgetSpecDirectoryEntryProvider.java

Violation Message Line
Errors 'com.google.common.base.Function' should be separated from previous imports. 17
Errors Class Fan-Out Complexity is 14 (max allowed is 10). 26
Warnings Line is longer than 120 characters. 38
Warnings Line is longer than 120 characters. 40
Infos Method 'contains' is not designed for extension - needs to be abstract, final or empty. 43
Infos Method 'pluginGadgetSpecEnabled' is not designed for extension - needs to be abstract, final or empty. 56
Infos Method 'pluginGadgetSpecDisabled' is not designed for extension - needs to be abstract, final or empty. 64
Infos Method 'internalEntries' is not designed for extension - needs to be abstract, final or empty. 72
Infos Method 'convertToLocalizedDirectoryEntry' is not designed for extension - needs to be abstract, final or empty. 86
Errors Missing a Javadoc comment. 92
Warnings Line is longer than 120 characters. 139
Infos Method 'toString' is not designed for extension - needs to be abstract, final or empty. 143

com/atlassian/gadgets/directory/internal/impl/UnavailableFeatureException.java

Violation Message Line
Errors First sentence should end with a period. 3

com/atlassian/gadgets/directory/internal/jaxb/JAXBCategory.java

Violation Message Line
Errors Comment matches to-do format 'TODO:'. 12
Errors '}' is not preceded with whitespace. 21

com/atlassian/gadgets/directory/internal/jaxb/JAXBDirectoryContents.java

Violation Message Line
Errors Comment matches to-do format 'TODO:'. 19
Errors Class JAXBDirectoryContents should be declared as final. 21
Errors '}' is not preceded with whitespace. 24
Errors '}' is not preceded with whitespace. 27
Warnings Line is longer than 120 characters. 45

com/atlassian/gadgets/directory/internal/jaxb/JAXBDirectoryEntry.java

Violation Message Line
Errors Comment matches to-do format 'TODO:'. 17
Errors '}' is not preceded with whitespace. 45
Warnings Line is longer than 120 characters. 61
Errors '17' is a magic number. 202
Errors '29' is a magic number. 202

com/atlassian/gadgets/directory/internal/jaxb/SubscribedGadgetFeedRepresentation.java

Violation Message Line
Errors Wrong order for 'com.atlassian.gadgets.directory.spi.SubscribedGadgetFeed' import. 14
Errors 'org.slf4j.Logger' should be separated from previous imports. 18
Errors Wrong order for 'com.google.common.base.Preconditions.checkNotNull' import. 21
Errors Missing a Javadoc comment. 23
Errors Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 26
Warnings Line has trailing spaces. 27
Errors Missing a Javadoc comment. 30
Errors Variable access definition in wrong order. 30
Errors '=' is not preceded with whitespace. 30
Errors '=' is not followed by whitespace. 30
Errors Variable 'gadgets' must be private and have accessor methods. 30
Warnings Line has trailing spaces. 31
Warnings Line is longer than 120 characters. 32
Warnings Line has trailing spaces. 37
Errors 'if' construct must use '{}'s. 49
Errors 'else' construct must use '{}'s. 51
Warnings Line has trailing spaces. 54
Warnings Line has trailing spaces. 56
Warnings Line has trailing spaces. 65
Infos Method 'getFeed' is not designed for extension - needs to be abstract, final or empty. 66
Warnings Line has trailing spaces. 70
Infos Method 'getSelf' is not designed for extension - needs to be abstract, final or empty. 71
Warnings Line has trailing spaces. 75
Infos Method 'getGadgets' is not designed for extension - needs to be abstract, final or empty. 76
Warnings Line has trailing spaces. 80
Errors Missing a Javadoc comment. 81
Warnings Line has trailing spaces. 84
Warnings Line has trailing spaces. 89
Warnings Line has trailing spaces. 96

com/atlassian/gadgets/directory/internal/jaxb/SubscribedGadgetFeedsRepresentation.java

Violation Message Line
Errors Wrong order for 'com.atlassian.gadgets.directory.spi.SubscribedGadgetFeed' import. 6
Errors 'com.google.common.collect.ImmutableList' should be separated from previous imports. 8
Errors 'org.slf4j.Logger' should be separated from previous imports. 9
Errors Wrong order for 'javax.xml.bind.annotation.XmlElement' import. 12
Errors Wrong order for 'java.net.URI' import. 15
Errors Missing a Javadoc comment. 20
Errors '=' is not preceded with whitespace. 20
Errors '=' is not followed by whitespace. 20
Errors '=' is not preceded with whitespace. 24
Errors '=' is not followed by whitespace. 24
Warnings Line is longer than 120 characters. 26
Warnings Line has trailing spaces. 33
Warnings Line has trailing spaces. 41
Warnings Line has trailing spaces. 49
Infos Method 'getSelf' is not designed for extension - needs to be abstract, final or empty. 50
Warnings Line has trailing spaces. 54
Infos Method 'getSubscribedGadgetFeeds' is not designed for extension - needs to be abstract, final or empty. 55
Warnings Line has trailing spaces. 59
Errors Missing a Javadoc comment. 60
Warnings Line is longer than 120 characters. 74
Errors 'catch' is not followed by whitespace. 88
Warnings Line has trailing spaces. 94
Warnings Line has trailing spaces. 107
Warnings Line has trailing spaces. 112
Warnings Line has trailing spaces. 117
Warnings Line has trailing spaces. 122
Warnings Line has trailing spaces. 127
Warnings Line has trailing spaces. 132
Warnings Line has trailing spaces. 137

com/atlassian/gadgets/directory/internal/rest/DirectoryResource.java

Violation Message Line
Errors Class Fan-Out Complexity is 18 (max allowed is 10). 43
Infos Method 'getDirectory' is not designed for extension - needs to be abstract, final or empty. 84
Errors '}' is not preceded with whitespace. 86
Infos Method 'putGadgetInDirectory' is not designed for extension - needs to be abstract, final or empty. 102
Errors 'if' is not followed by whitespace. 147
Infos Method 'deleteGadgetFromDirectory' is not designed for extension - needs to be abstract, final or empty. 177

com/atlassian/gadgets/directory/internal/rest/SubscribedGadgetFeedResource.java

Violation Message Line
Errors Wrong order for 'com.atlassian.gadgets.directory.internal.jaxb.SubscribedGadgetFeedRepresentation' import. 19
Errors Missing a Javadoc comment. 26
Errors Class Fan-Out Complexity is 11 (max allowed is 10). 26
Warnings Line has trailing spaces. 46
Infos Method 'get' is not designed for extension - needs to be abstract, final or empty. 47
Errors '}' is not preceded with whitespace. 48
Infos Method 'remove' is not designed for extension - needs to be abstract, final or empty. 57
Warnings Line has trailing spaces. 73

com/atlassian/gadgets/directory/internal/rest/SubscribedGadgetFeedsResource.java

Violation Message Line
Errors Missing package-info.java file. 0
Errors Wrong order for 'com.atlassian.gadgets.directory.internal.jaxb.SubscribedGadgetFeedRepresentation' import. 9
Errors 'org.apache.commons.io.IOUtils' should be separated from previous imports. 14
Errors Wrong order for 'javax.servlet.http.HttpServletRequest' import. 20
Errors Wrong order for 'java.io.IOException' import. 30
Errors 'org.apache.commons.lang.StringUtils.isEmpty' should be separated from previous imports. 36
Errors Missing a Javadoc comment. 38
Errors Class Fan-Out Complexity is 21 (max allowed is 10). 38
Warnings Line has trailing spaces. 42
Warnings Line has trailing spaces. 61
Infos Method 'get' is not designed for extension - needs to be abstract, final or empty. 62
Errors '}' is not preceded with whitespace. 63
Warnings Line is longer than 120 characters. 66
Warnings Line has trailing spaces. 68
Infos Method 'add' is not designed for extension - needs to be abstract, final or empty. 69
Errors '}' is not preceded with whitespace. 71
Warnings Line is longer than 120 characters. 78
Warnings Line is longer than 120 characters. 115
Warnings Line has trailing spaces. 122
Warnings Line has trailing spaces. 136
Warnings Line is longer than 120 characters. 143