The following document contains the results of Checkstyle.
Files | Infos | Warnings | Errors |
---|---|---|---|
29 | 41 | 63 | 137 |
Rules | Violations | Severity |
---|---|---|
JavadocPackage | 3 | Error |
Translation | 0 | Error |
FileLength | 0 | Error |
FileTabCharacter
|
0 | Error |
RegexpSingleline
|
42 | Warning |
AnnotationUseStyle | 0 | Error |
MissingDeprecated | 0 | Error |
MissingOverride
|
0 | Error |
PackageAnnotation | 0 | Error |
JavadocMethod
|
11 | Error |
JavadocType
|
17 | Error |
JavadocVariable
|
1 | Error |
JavadocStyle
|
4 | Error |
ConstantName | 3 | Error |
LocalFinalVariableName | 0 | Error |
LocalVariableName | 0 | Error |
MemberName | 0 | Error |
MethodName | 0 | Error |
PackageName | 0 | Error |
ParameterName | 0 | Error |
StaticVariableName | 0 | Error |
TypeName | 0 | Error |
AvoidStarImport | 0 | Error |
IllegalImport | 0 | Error |
ImportOrder
|
34 | Error |
RedundantImport | 0 | Error |
UnusedImports | 0 | Error |
LineLength
|
21 | Warning |
MethodLength | 0 | Error |
ParameterNumber | 0 | Error |
EmptyForIteratorPad | 0 | Error |
MethodParamPad | 0 | Error |
NoWhitespaceAfter | 0 | Error |
NoWhitespaceBefore | 0 | Error |
OperatorWrap | 6 | Error |
ParenPad | 2 | Error |
TypecastParenPad | 0 | Error |
WhitespaceAfter | 0 | Error |
WhitespaceAround | 19 | Error |
ModifierOrder | 1 | Error |
RedundantModifier | 0 | Error |
AvoidNestedBlocks | 0 | Error |
EmptyBlock | 0 | Error |
LeftCurly
|
1 | Error |
NeedBraces | 4 | Error |
RightCurly
|
0 | Error |
DeclarationOrder | 1 | Error |
DefaultComesLast | 0 | Error |
DoubleCheckedLocking | 0 | Error |
EmptyStatement | 0 | Error |
EqualsHashCode | 0 | Error |
ExplicitInitialization | 0 | Error |
FallThrough | 0 | Error |
HiddenField
|
2 | Error |
IllegalInstantiation | 0 | Error |
InnerAssignment | 0 | Error |
MagicNumber | 8 | Error |
MissingSwitchDefault | 0 | Error |
ParameterAssignment | 0 | Error |
RedundantThrows
|
0 | Error |
SimplifyBooleanExpression | 0 | Error |
SimplifyBooleanReturn | 0 | Error |
StringLiteralEquality | 0 | Error |
DesignForExtension | 41 | Info |
FinalClass | 1 | Error |
HideUtilityClassConstructor | 1 | Error |
InterfaceIsType | 0 | Error |
VisibilityModifier | 1 | Error |
BooleanExpressionComplexity | 0 | Error |
ClassDataAbstractionCoupling | 1 | Error |
ClassFanOutComplexity
|
10 | Error |
CyclomaticComplexity | 0 | Error |
NPathComplexity
|
0 | Error |
JavaNCSS | 0 | Error |
ArrayTypeStyle | 0 | Error |
Indentation | 0 | Error |
TodoComment | 6 | Error |
UpperEll | 0 | Error |
Violation | Message | Line |
---|---|---|
First sentence should end with a period. | 19 |
Violation | Message | Line |
---|---|---|
Missing a Javadoc comment. | 17 | |
Line has trailing spaces. | 29 | |
Method 'doGet' is not designed for extension - needs to be abstract, final or empty. | 30 | |
Line is longer than 120 characters. | 35 |
Violation | Message | Line |
---|---|---|
Line is longer than 120 characters. | 23 | |
Method 'checkForPermissionToConfigureDirectory' is not designed for extension - needs to be abstract, final or empty. | 37 |
Violation | Message | Line |
---|---|---|
Missing a Javadoc comment. | 8 |
Violation | Message | Line |
---|---|---|
First sentence should end with a period. | 12 | |
Line is longer than 120 characters. | 13 | |
'{' is not followed by whitespace. | 17 | |
'}' is not preceded with whitespace. | 17 | |
Line has trailing spaces. | 18 | |
'(' is followed by whitespace. | 49 | |
')' is preceded with whitespace. | 49 | |
Line has trailing spaces. | 55 | |
'if' is not followed by whitespace. | 56 |
Violation | Message | Line |
---|---|---|
Missing package-info.java file. | 0 | |
Missing a Javadoc comment. | 5 | |
First sentence should end with a period. | 16 | |
Line has trailing spaces. | 27 | |
Line has trailing spaces. | 31 | |
Line has trailing spaces. | 34 |
Violation | Message | Line |
---|---|---|
'com.google.common.base.Function' should be separated from previous imports. | 9 | |
Utility classes should not have a public or default constructor. | 19 | |
Line has trailing spaces. | 137 |
Violation | Message | Line |
---|---|---|
'com.google.common.base.Predicate' should be separated from previous imports. | 9 | |
'org.slf4j.Logger' should be separated from previous imports. | 11 | |
Wrong order for 'java.net.URI' import. | 14 | |
'com.google.common.base.Preconditions.checkNotNull' should be separated from previous imports. | 20 | |
Missing a Javadoc comment. | 23 | |
Class Fan-Out Complexity is 12 (max allowed is 10). | 23 | |
Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 25 | |
Line is longer than 120 characters. | 31 | |
Method 'contains' is not designed for extension - needs to be abstract, final or empty. | 38 | |
Method 'entries' is not designed for extension - needs to be abstract, final or empty. | 43 | |
Missing a Javadoc comment. | 57 | |
'if' construct must use '{}'s. | 77 | |
'else' construct must use '{}'s. | 79 |
Violation | Message | Line |
---|---|---|
'org.apache.http.HttpVersion' should be separated from previous imports. | 5 | |
Missing a Javadoc comment. | 23 | |
Class Data Abstraction Coupling is 8 (max allowed is 7) classes [BasicHttpParams, DefaultHttpClient, HTTPClientResponseResolver, HttpTimeoutsProvider, MemoryCacheStorage, Scheme, SchemeRegistry, ThreadSafeClientConnManager]. | 23 | |
Class Fan-Out Complexity is 12 (max allowed is 10). | 23 | |
'80' is a magic number. | 58 | |
'443' is a magic number. | 60 | |
'8192' is a magic number. | 76 | |
Method 'destroy' is not designed for extension - needs to be abstract, final or empty. | 84 | |
'{' should be on a new line. | 84 |
Violation | Message | Line |
---|---|---|
'com.google.common.base.Function' should be separated from previous imports. | 10 | |
'org.apache.commons.logging.Log' should be separated from previous imports. | 12 | |
Wrong order for 'java.net.URI' import. | 16 | |
Missing a Javadoc comment. | 28 | |
Class Fan-Out Complexity is 20 (max allowed is 10). | 28 | |
Line is longer than 120 characters. | 35 | |
'15' is a magic number. | 39 | |
Comment matches to-do format 'TODO:'. | 44 | |
Line is longer than 120 characters. | 44 | |
Line is longer than 120 characters. | 46 | |
Missing a Javadoc comment. | 51 | |
Line is longer than 120 characters. | 88 | |
Comment matches to-do format 'TODO:'. | 93 | |
Method 'destroy' is not designed for extension - needs to be abstract, final or empty. | 106 |
Violation | Message | Line |
---|---|---|
Comment matches to-do format 'TODO:'. | 30 | |
Class Fan-Out Complexity is 20 (max allowed is 10). | 31 | |
Method 'contains' is not designed for extension - needs to be abstract, final or empty. | 54 | |
Method 'internalEntries' is not designed for extension - needs to be abstract, final or empty. | 59 | |
Method 'add' is not designed for extension - needs to be abstract, final or empty. | 65 | |
Missing a Javadoc comment. | 69 | |
Method 'remove' is not designed for extension - needs to be abstract, final or empty. | 84 | |
Missing a Javadoc comment. | 88 | |
Method 'convertToLocalizedDirectoryEntry' is not designed for extension - needs to be abstract, final or empty. | 96 | |
Missing a Javadoc comment. | 102 | |
Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 148 |
Violation | Message | Line |
---|---|---|
Wrong order for 'com.google.common.collect.Iterables.any' import. | 16 | |
Missing a Javadoc comment. | 20 | |
Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 22 | |
Method 'getEntries' is not designed for extension - needs to be abstract, final or empty. | 31 | |
Method 'contains' is not designed for extension - needs to be abstract, final or empty. | 36 | |
Missing a Javadoc comment. | 46 | |
Missing a Javadoc comment. | 72 |
Violation | Message | Line |
---|---|---|
Missing a Javadoc comment. | 10 | |
Method 'buildDirectoryResourceUrl' is not designed for extension - needs to be abstract, final or empty. | 18 | |
Method 'buildDirectoryGadgetResourceUrl' is not designed for extension - needs to be abstract, final or empty. | 24 | |
Method 'buildSubscribedGadgetFeedsUrl' is not designed for extension - needs to be abstract, final or empty. | 30 | |
Line has trailing spaces. | 34 | |
Method 'buildSubscribedGadgetFeedUrl' is not designed for extension - needs to be abstract, final or empty. | 35 |
Violation | Message | Line |
---|---|---|
'org.codehaus.httpcache4j.cache.HTTPCache' should be separated from previous imports. | 5 | |
Wrong order for 'java.net.URI' import. | 7 | |
Missing a Javadoc comment. | 11 |
Violation | Message | Line |
---|---|---|
Missing package-info.java file. | 0 | |
'com.google.common.collect.ImmutableSet' should be separated from previous imports. | 7 | |
'org.apache.commons.io.IOUtils' should be separated from previous imports. | 15 | |
Wrong order for 'java.io.InputStream' import. | 24 | |
Missing a Javadoc comment. | 34 | |
Class Fan-Out Complexity is 24 (max allowed is 10). | 34 | |
Line has trailing spaces. | 66 | |
'feed' hides a field. | 69 | |
'feed' hides a field. | 131 |
Violation | Message | Line |
---|---|---|
'org.apache.commons.lang.StringUtils.defaultString' should be separated from previous imports. | 13 | |
Missing a Javadoc comment. | 15 | |
'static' modifier out of order with the JLS suggestions. | 17 | |
'&&' should be on a new line. | 123 | |
'&&' should be on a new line. | 124 | |
'31' is a magic number. | 133 | |
'31' is a magic number. | 134 | |
'+' should be on a new line. | 140 | |
'+' should be on a new line. | 141 | |
'+' should be on a new line. | 142 | |
'+' should be on a new line. | 143 |
Violation | Message | Line |
---|---|---|
'com.google.common.base.Function' should be separated from previous imports. | 12 | |
Wrong order for 'com.google.common.collect.Iterables.any' import. | 18 | |
Wrong order for 'java.util.Collections.emptySet' import. | 21 | |
Class Fan-Out Complexity is 12 (max allowed is 10). | 27 | |
Method 'contains' is not designed for extension - needs to be abstract, final or empty. | 46 | |
Missing a Javadoc comment. | 50 | |
Method 'internalEntries' is not designed for extension - needs to be abstract, final or empty. | 69 | |
Missing a Javadoc comment. | 74 | |
Method 'convertToLocalizedDirectoryEntry' is not designed for extension - needs to be abstract, final or empty. | 97 | |
Missing a Javadoc comment. | 103 | |
Line is longer than 120 characters. | 107 | |
Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 123 |
Violation | Message | Line |
---|---|---|
Line has trailing spaces. | 27 | |
Method 'voteOn' is not designed for extension - needs to be abstract, final or empty. | 28 |
Violation | Message | Line |
---|---|---|
'com.google.common.base.Function' should be separated from previous imports. | 17 | |
Class Fan-Out Complexity is 14 (max allowed is 10). | 26 | |
Line is longer than 120 characters. | 38 | |
Line is longer than 120 characters. | 40 | |
Method 'contains' is not designed for extension - needs to be abstract, final or empty. | 43 | |
Method 'pluginGadgetSpecEnabled' is not designed for extension - needs to be abstract, final or empty. | 56 | |
Method 'pluginGadgetSpecDisabled' is not designed for extension - needs to be abstract, final or empty. | 64 | |
Method 'internalEntries' is not designed for extension - needs to be abstract, final or empty. | 72 | |
Method 'convertToLocalizedDirectoryEntry' is not designed for extension - needs to be abstract, final or empty. | 86 | |
Missing a Javadoc comment. | 92 | |
Line is longer than 120 characters. | 139 | |
Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 143 |
Violation | Message | Line |
---|---|---|
First sentence should end with a period. | 3 |
Violation | Message | Line |
---|---|---|
Comment matches to-do format 'TODO:'. | 12 | |
'}' is not preceded with whitespace. | 21 |
Violation | Message | Line |
---|---|---|
Comment matches to-do format 'TODO:'. | 19 | |
Class JAXBDirectoryContents should be declared as final. | 21 | |
'}' is not preceded with whitespace. | 24 | |
'}' is not preceded with whitespace. | 27 | |
Line is longer than 120 characters. | 45 |
Violation | Message | Line |
---|---|---|
Comment matches to-do format 'TODO:'. | 17 | |
'}' is not preceded with whitespace. | 45 | |
Line is longer than 120 characters. | 61 | |
'17' is a magic number. | 202 | |
'29' is a magic number. | 202 |
Violation | Message | Line |
---|---|---|
Wrong order for 'com.atlassian.gadgets.directory.spi.SubscribedGadgetFeed' import. | 14 | |
'org.slf4j.Logger' should be separated from previous imports. | 18 | |
Wrong order for 'com.google.common.base.Preconditions.checkNotNull' import. | 21 | |
Missing a Javadoc comment. | 23 | |
Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 26 | |
Line has trailing spaces. | 27 | |
Missing a Javadoc comment. | 30 | |
Variable access definition in wrong order. | 30 | |
'=' is not preceded with whitespace. | 30 | |
'=' is not followed by whitespace. | 30 | |
Variable 'gadgets' must be private and have accessor methods. | 30 | |
Line has trailing spaces. | 31 | |
Line is longer than 120 characters. | 32 | |
Line has trailing spaces. | 37 | |
'if' construct must use '{}'s. | 49 | |
'else' construct must use '{}'s. | 51 | |
Line has trailing spaces. | 54 | |
Line has trailing spaces. | 56 | |
Line has trailing spaces. | 65 | |
Method 'getFeed' is not designed for extension - needs to be abstract, final or empty. | 66 | |
Line has trailing spaces. | 70 | |
Method 'getSelf' is not designed for extension - needs to be abstract, final or empty. | 71 | |
Line has trailing spaces. | 75 | |
Method 'getGadgets' is not designed for extension - needs to be abstract, final or empty. | 76 | |
Line has trailing spaces. | 80 | |
Missing a Javadoc comment. | 81 | |
Line has trailing spaces. | 84 | |
Line has trailing spaces. | 89 | |
Line has trailing spaces. | 96 |
Violation | Message | Line |
---|---|---|
Wrong order for 'com.atlassian.gadgets.directory.spi.SubscribedGadgetFeed' import. | 6 | |
'com.google.common.collect.ImmutableList' should be separated from previous imports. | 8 | |
'org.slf4j.Logger' should be separated from previous imports. | 9 | |
Wrong order for 'javax.xml.bind.annotation.XmlElement' import. | 12 | |
Wrong order for 'java.net.URI' import. | 15 | |
Missing a Javadoc comment. | 20 | |
'=' is not preceded with whitespace. | 20 | |
'=' is not followed by whitespace. | 20 | |
'=' is not preceded with whitespace. | 24 | |
'=' is not followed by whitespace. | 24 | |
Line is longer than 120 characters. | 26 | |
Line has trailing spaces. | 33 | |
Line has trailing spaces. | 41 | |
Line has trailing spaces. | 49 | |
Method 'getSelf' is not designed for extension - needs to be abstract, final or empty. | 50 | |
Line has trailing spaces. | 54 | |
Method 'getSubscribedGadgetFeeds' is not designed for extension - needs to be abstract, final or empty. | 55 | |
Line has trailing spaces. | 59 | |
Missing a Javadoc comment. | 60 | |
Line is longer than 120 characters. | 74 | |
'catch' is not followed by whitespace. | 88 | |
Line has trailing spaces. | 94 | |
Line has trailing spaces. | 107 | |
Line has trailing spaces. | 112 | |
Line has trailing spaces. | 117 | |
Line has trailing spaces. | 122 | |
Line has trailing spaces. | 127 | |
Line has trailing spaces. | 132 | |
Line has trailing spaces. | 137 |
Violation | Message | Line |
---|---|---|
Class Fan-Out Complexity is 18 (max allowed is 10). | 43 | |
Method 'getDirectory' is not designed for extension - needs to be abstract, final or empty. | 84 | |
'}' is not preceded with whitespace. | 86 | |
Method 'putGadgetInDirectory' is not designed for extension - needs to be abstract, final or empty. | 102 | |
'if' is not followed by whitespace. | 147 | |
Method 'deleteGadgetFromDirectory' is not designed for extension - needs to be abstract, final or empty. | 177 |
Violation | Message | Line |
---|---|---|
Missing package-info.java file. | 0 | |
Wrong order for 'com.atlassian.gadgets.directory.internal.jaxb.SubscribedGadgetFeedRepresentation' import. | 19 | |
Missing a Javadoc comment. | 26 | |
Class Fan-Out Complexity is 11 (max allowed is 10). | 26 | |
Line has trailing spaces. | 46 | |
Method 'get' is not designed for extension - needs to be abstract, final or empty. | 47 | |
'}' is not preceded with whitespace. | 48 | |
Method 'remove' is not designed for extension - needs to be abstract, final or empty. | 57 | |
Line has trailing spaces. | 73 |
Violation | Message | Line |
---|---|---|
Wrong order for 'com.atlassian.gadgets.directory.internal.jaxb.SubscribedGadgetFeedRepresentation' import. | 9 | |
'org.apache.commons.io.IOUtils' should be separated from previous imports. | 14 | |
Wrong order for 'javax.servlet.http.HttpServletRequest' import. | 20 | |
Wrong order for 'java.io.IOException' import. | 30 | |
'org.apache.commons.lang.StringUtils.isEmpty' should be separated from previous imports. | 36 | |
Missing a Javadoc comment. | 38 | |
Class Fan-Out Complexity is 21 (max allowed is 10). | 38 | |
Line has trailing spaces. | 42 | |
Line has trailing spaces. | 61 | |
Method 'get' is not designed for extension - needs to be abstract, final or empty. | 62 | |
'}' is not preceded with whitespace. | 63 | |
Line is longer than 120 characters. | 66 | |
Line has trailing spaces. | 68 | |
Method 'add' is not designed for extension - needs to be abstract, final or empty. | 69 | |
'}' is not preceded with whitespace. | 71 | |
Line is longer than 120 characters. | 78 | |
Line is longer than 120 characters. | 115 | |
Line has trailing spaces. | 122 | |
Line has trailing spaces. | 136 | |
Line is longer than 120 characters. | 143 |