The following document contains the results of Checkstyle. 
| Files | Infos |
Warnings |
Errors |
|---|---|---|---|
| 32 | 65 | 80 | 133 |
| Rules | Violations | Severity |
|---|---|---|
| JavadocPackage | 3 | |
| Translation | 0 | |
| FileLength | 0 | |
FileTabCharacter
|
0 | |
RegexpSingleline
|
61 | |
| AnnotationUseStyle | 0 | |
| MissingDeprecated | 0 | |
MissingOverride
|
0 | |
| PackageAnnotation | 0 | |
JavadocMethod
|
16 | |
JavadocType
|
19 | |
JavadocVariable
|
2 | |
JavadocStyle
|
7 | |
| ConstantName | 1 | |
| LocalFinalVariableName | 0 | |
| LocalVariableName | 0 | |
| MemberName | 0 | |
| MethodName | 0 | |
| PackageName | 0 | |
| ParameterName | 0 | |
| StaticVariableName | 0 | |
| TypeName | 0 | |
| AvoidStarImport | 2 | |
| IllegalImport | 1 | |
ImportOrder
|
22 | |
| RedundantImport | 0 | |
| UnusedImports | 1 | |
LineLength
|
19 | |
| MethodLength | 0 | |
| ParameterNumber | 0 | |
| EmptyForIteratorPad | 0 | |
| MethodParamPad | 0 | |
| NoWhitespaceAfter | 0 | |
| NoWhitespaceBefore | 0 | |
| OperatorWrap | 6 | |
| ParenPad | 2 | |
| TypecastParenPad | 0 | |
| WhitespaceAfter | 0 | |
| WhitespaceAround | 19 | |
| ModifierOrder | 1 | |
| RedundantModifier | 0 | |
| AvoidNestedBlocks | 0 | |
| EmptyBlock | 0 | |
LeftCurly
|
1 | |
| NeedBraces | 0 | |
RightCurly
|
0 | |
| DeclarationOrder | 2 | |
| DefaultComesLast | 0 | |
| DoubleCheckedLocking | 0 | |
| EmptyStatement | 0 | |
| EqualsHashCode | 0 | |
| ExplicitInitialization | 0 | |
| FallThrough | 0 | |
HiddenField
|
0 | |
| IllegalInstantiation | 0 | |
| InnerAssignment | 0 | |
| MagicNumber | 8 | |
| MissingSwitchDefault | 0 | |
| ParameterAssignment | 0 | |
RedundantThrows
|
0 | |
| SimplifyBooleanExpression | 0 | |
| SimplifyBooleanReturn | 0 | |
| StringLiteralEquality | 0 | |
| DesignForExtension | 65 | |
| FinalClass | 1 | |
| HideUtilityClassConstructor | 1 | |
| InterfaceIsType | 0 | |
| VisibilityModifier | 1 | |
| BooleanExpressionComplexity | 0 | |
| ClassDataAbstractionCoupling | 1 | |
ClassFanOutComplexity
|
10 | |
| CyclomaticComplexity | 0 | |
NPathComplexity
|
0 | |
| JavaNCSS | 0 | |
| ArrayTypeStyle | 0 | |
| Indentation | 0 | |
| TodoComment | 6 | |
| UpperEll | 0 |
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 19 |
| Violation | Message | Line |
|---|---|---|
| Missing a Javadoc comment. | 17 | |
| Line has trailing spaces. | 29 | |
| Method 'doGet' is not designed for extension - needs to be abstract, final or empty. | 30 | |
| Line is longer than 120 characters. | 35 |
| Violation | Message | Line |
|---|---|---|
| Line is longer than 120 characters. | 23 | |
| Method 'checkForPermissionToConfigureDirectory' is not designed for extension - needs to be abstract, final or empty. | 37 |
| Violation | Message | Line |
|---|---|---|
| Missing a Javadoc comment. | 8 |
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 12 | |
| Line is longer than 120 characters. | 13 | |
| '{' is not followed by whitespace. | 17 | |
| '}' is not preceded with whitespace. | 17 | |
| Line has trailing spaces. | 18 | |
| '(' is followed by whitespace. | 49 | |
| ')' is preceded with whitespace. | 49 | |
| Line has trailing spaces. | 55 | |
| 'if' is not followed by whitespace. | 56 |
| Violation | Message | Line |
|---|---|---|
| Missing a Javadoc comment. | 5 | |
| First sentence should end with a period. | 16 | |
| Line has trailing spaces. | 27 | |
| Line has trailing spaces. | 31 | |
| Line has trailing spaces. | 34 |
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 5 | |
| Line has trailing spaces. | 11 | |
| Line has trailing spaces. | 17 | |
| Method 'getFeedUri' is not designed for extension - needs to be abstract, final or empty. | 18 |
| Violation | Message | Line |
|---|---|---|
| 'com.google.common.base.Function' should be separated from previous imports. | 8 | |
| 'org.apache.commons.io.IOUtils' should be separated from previous imports. | 18 | |
| Wrong order for 'java.io.InputStream' import. | 26 | |
| 'com.google.common.base.Preconditions.checkNotNull' should be separated from previous imports. | 38 | |
| 'org.apache.commons.lang.StringUtils.isBlank' should be separated from previous imports. | 40 | |
| Missing a Javadoc comment. | 42 | |
| Class Fan-Out Complexity is 15 (max allowed is 10). | 42 | |
| Method 'contains' is not designed for extension - needs to be abstract, final or empty. | 62 | |
| Method 'entries' is not designed for extension - needs to be abstract, final or empty. | 67 | |
| Method 'addFeed' is not designed for extension - needs to be abstract, final or empty. | 79 | |
| Missing a Javadoc comment. | 91 | |
| Method 'getFeeds' is not designed for extension - needs to be abstract, final or empty. | 105 | |
| Missing a Javadoc comment. | 109 | |
| Method 'containsFeed' is not designed for extension - needs to be abstract, final or empty. | 122 | |
| Missing a Javadoc comment. | 126 | |
| Method 'getFeedProvider' is not designed for extension - needs to be abstract, final or empty. | 139 | |
| Missing a Javadoc comment. | 143 | |
| Method 'removeFeed' is not designed for extension - needs to be abstract, final or empty. | 159 | |
| Missing a Javadoc comment. | 163 | |
| Method 'getFeedProviders' is not designed for extension - needs to be abstract, final or empty. | 170 | |
| Line is longer than 120 characters. | 180 | |
| Instance variable definition in wrong order. | 180 | |
| Missing a Javadoc comment. | 182 | |
| Missing a Javadoc comment. | 193 | |
| Class Fan-Out Complexity is 16 (max allowed is 10). | 193 | |
| Method 'getId' is not designed for extension - needs to be abstract, final or empty. | 206 | |
| Method 'getUri' is not designed for extension - needs to be abstract, final or empty. | 211 | |
| Method 'getApplicationName' is not designed for extension - needs to be abstract, final or empty. | 216 | |
| Method 'getTitle' is not designed for extension - needs to be abstract, final or empty. | 226 | |
| Method 'getIcon' is not designed for extension - needs to be abstract, final or empty. | 231 | |
| Method 'getBaseUri' is not designed for extension - needs to be abstract, final or empty. | 241 | |
| Method 'contains' is not designed for extension - needs to be abstract, final or empty. | 267 | |
| Method 'entries' is not designed for extension - needs to be abstract, final or empty. | 272 | |
| Class Fan-Out Complexity is 13 (max allowed is 10). | 334 | |
| Line is longer than 120 characters. | 380 |
| Violation | Message | Line |
|---|---|---|
| Missing a Javadoc comment. | 14 | |
| Utility classes should not have a public or default constructor. | 14 | |
| Line has trailing spaces. | 24 | |
| Line is longer than 120 characters. | 75 |
| Violation | Message | Line |
|---|---|---|
| 'org.apache.http.HttpVersion' should be separated from previous imports. | 5 | |
| Missing a Javadoc comment. | 23 | |
| Class Data Abstraction Coupling is 8 (max allowed is 7) classes [BasicHttpParams, DefaultHttpClient, HTTPClientResponseResolver, HttpTimeoutsProvider, MemoryCacheStorage, Scheme, SchemeRegistry, ThreadSafeClientConnManager]. | 23 | |
| Class Fan-Out Complexity is 12 (max allowed is 10). | 23 | |
| '80' is a magic number. | 58 | |
| '443' is a magic number. | 60 | |
| '8192' is a magic number. | 76 | |
| Method 'destroy' is not designed for extension - needs to be abstract, final or empty. | 84 | |
| '{' should be on a new line. | 84 |
| Violation | Message | Line |
|---|---|---|
| Line has trailing spaces. | 16 | |
| Method 'getFeedUri' is not designed for extension - needs to be abstract, final or empty. | 17 |
| Violation | Message | Line |
|---|---|---|
| Missing package-info.java file. | 0 | |
| Missing a Javadoc comment. | 7 | |
| Line has trailing spaces. | 17 | |
| Method 'getId' is not designed for extension - needs to be abstract, final or empty. | 18 | |
| Line has trailing spaces. | 22 | |
| Method 'getUri' is not designed for extension - needs to be abstract, final or empty. | 23 | |
| Line has trailing spaces. | 27 | |
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 28 |
| Violation | Message | Line |
|---|---|---|
| Line has trailing spaces. | 10 | |
| Line has trailing spaces. | 17 | |
| Line has trailing spaces. | 21 | |
| Line has trailing spaces. | 24 | |
| Line has trailing spaces. | 29 | |
| First sentence should end with a period. | 30 | |
| Line has trailing spaces. | 32 | |
| First sentence should end with a period. | 37 | |
| Line has trailing spaces. | 39 |
| Violation | Message | Line |
|---|---|---|
| 'com.google.common.base.Function' should be separated from previous imports. | 10 | |
| 'org.apache.commons.logging.Log' should be separated from previous imports. | 12 | |
| Wrong order for 'java.net.URI' import. | 16 | |
| Missing a Javadoc comment. | 28 | |
| Class Fan-Out Complexity is 20 (max allowed is 10). | 28 | |
| Line is longer than 120 characters. | 35 | |
| '15' is a magic number. | 39 | |
| Comment matches to-do format 'TODO:'. | 44 | |
| Line is longer than 120 characters. | 44 | |
| Line is longer than 120 characters. | 46 | |
| Missing a Javadoc comment. | 51 | |
| Line is longer than 120 characters. | 88 | |
| Comment matches to-do format 'TODO:'. | 93 | |
| Method 'destroy' is not designed for extension - needs to be abstract, final or empty. | 106 |
| Violation | Message | Line |
|---|---|---|
| Comment matches to-do format 'TODO:'. | 30 | |
| Class Fan-Out Complexity is 20 (max allowed is 10). | 31 | |
| Method 'contains' is not designed for extension - needs to be abstract, final or empty. | 54 | |
| Method 'internalEntries' is not designed for extension - needs to be abstract, final or empty. | 59 | |
| Method 'add' is not designed for extension - needs to be abstract, final or empty. | 65 | |
| Missing a Javadoc comment. | 69 | |
| Method 'remove' is not designed for extension - needs to be abstract, final or empty. | 84 | |
| Missing a Javadoc comment. | 88 | |
| Method 'convertToLocalizedDirectoryEntry' is not designed for extension - needs to be abstract, final or empty. | 96 | |
| Missing a Javadoc comment. | 102 | |
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 148 |
| Violation | Message | Line |
|---|---|---|
| Missing package-info.java file. | 0 | |
| Wrong order for 'com.google.common.collect.Iterables.any' import. | 16 | |
| Missing a Javadoc comment. | 20 | |
| Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 22 | |
| Method 'getEntries' is not designed for extension - needs to be abstract, final or empty. | 31 | |
| Method 'contains' is not designed for extension - needs to be abstract, final or empty. | 36 | |
| Missing a Javadoc comment. | 46 | |
| Missing a Javadoc comment. | 72 |
| Violation | Message | Line |
|---|---|---|
| Missing a Javadoc comment. | 10 | |
| Method 'buildDirectoryResourceUrl' is not designed for extension - needs to be abstract, final or empty. | 18 | |
| Method 'buildDirectoryGadgetResourceUrl' is not designed for extension - needs to be abstract, final or empty. | 24 | |
| Method 'buildSubscribedGadgetFeedsUrl' is not designed for extension - needs to be abstract, final or empty. | 30 | |
| Line has trailing spaces. | 34 | |
| Method 'buildSubscribedGadgetFeedUrl' is not designed for extension - needs to be abstract, final or empty. | 35 |
| Violation | Message | Line |
|---|---|---|
| 'org.apache.commons.lang.StringUtils.defaultString' should be separated from previous imports. | 13 | |
| Missing a Javadoc comment. | 15 | |
| 'static' modifier out of order with the JLS suggestions. | 17 | |
| '&&' should be on a new line. | 123 | |
| '&&' should be on a new line. | 124 | |
| '31' is a magic number. | 133 | |
| '31' is a magic number. | 134 | |
| '+' should be on a new line. | 140 | |
| '+' should be on a new line. | 141 | |
| '+' should be on a new line. | 142 | |
| '+' should be on a new line. | 143 |
| Violation | Message | Line |
|---|---|---|
| 'com.google.common.base.Function' should be separated from previous imports. | 12 | |
| Wrong order for 'com.google.common.collect.Iterables.any' import. | 18 | |
| Wrong order for 'java.util.Collections.emptySet' import. | 21 | |
| Class Fan-Out Complexity is 12 (max allowed is 10). | 27 | |
| Method 'contains' is not designed for extension - needs to be abstract, final or empty. | 46 | |
| Missing a Javadoc comment. | 50 | |
| Method 'internalEntries' is not designed for extension - needs to be abstract, final or empty. | 69 | |
| Missing a Javadoc comment. | 74 | |
| Method 'convertToLocalizedDirectoryEntry' is not designed for extension - needs to be abstract, final or empty. | 97 | |
| Missing a Javadoc comment. | 103 | |
| Line is longer than 120 characters. | 107 | |
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 123 |
| Violation | Message | Line |
|---|---|---|
| Line has trailing spaces. | 27 | |
| Method 'voteOn' is not designed for extension - needs to be abstract, final or empty. | 28 |
| Violation | Message | Line |
|---|---|---|
| 'com.google.common.base.Function' should be separated from previous imports. | 17 | |
| Class Fan-Out Complexity is 14 (max allowed is 10). | 26 | |
| Line is longer than 120 characters. | 38 | |
| Line is longer than 120 characters. | 40 | |
| Method 'contains' is not designed for extension - needs to be abstract, final or empty. | 43 | |
| Method 'pluginGadgetSpecEnabled' is not designed for extension - needs to be abstract, final or empty. | 56 | |
| Method 'pluginGadgetSpecDisabled' is not designed for extension - needs to be abstract, final or empty. | 64 | |
| Method 'internalEntries' is not designed for extension - needs to be abstract, final or empty. | 72 | |
| Method 'convertToLocalizedDirectoryEntry' is not designed for extension - needs to be abstract, final or empty. | 86 | |
| Missing a Javadoc comment. | 92 | |
| Line is longer than 120 characters. | 139 | |
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 143 |
| Violation | Message | Line |
|---|---|---|
| Missing a Javadoc comment. | 20 | |
| Missing a Javadoc comment. | 22 | |
| Line has trailing spaces. | 23 | |
| Line has trailing spaces. | 30 | |
| Method 'add' is not designed for extension - needs to be abstract, final or empty. | 31 | |
| Method 'contains' is not designed for extension - needs to be abstract, final or empty. | 36 | |
| Method 'get' is not designed for extension - needs to be abstract, final or empty. | 41 | |
| Method 'getAll' is not designed for extension - needs to be abstract, final or empty. | 46 | |
| Line has trailing spaces. | 50 | |
| Method 'remove' is not designed for extension - needs to be abstract, final or empty. | 51 | |
| Line has trailing spaces. | 72 | |
| Line has trailing spaces. | 81 | |
| Line has trailing spaces. | 86 |
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 3 |
| Violation | Message | Line |
|---|---|---|
| Comment matches to-do format 'TODO:'. | 12 | |
| '}' is not preceded with whitespace. | 21 |
| Violation | Message | Line |
|---|---|---|
| Comment matches to-do format 'TODO:'. | 19 | |
| Class JAXBDirectoryContents should be declared as final. | 21 | |
| '}' is not preceded with whitespace. | 24 | |
| '}' is not preceded with whitespace. | 27 | |
| Line is longer than 120 characters. | 45 |
| Violation | Message | Line |
|---|---|---|
| Comment matches to-do format 'TODO:'. | 17 | |
| '}' is not preceded with whitespace. | 45 | |
| Line is longer than 120 characters. | 61 | |
| '17' is a magic number. | 202 | |
| '29' is a magic number. | 202 |
| Violation | Message | Line |
|---|---|---|
| Missing a Javadoc comment. | 19 | |
| Missing a Javadoc comment. | 24 | |
| Variable access definition in wrong order. | 24 | |
| '=' is not preceded with whitespace. | 24 | |
| '=' is not followed by whitespace. | 24 | |
| Variable 'gadgets' must be private and have accessor methods. | 24 | |
| Line has trailing spaces. | 25 | |
| Line has trailing spaces. | 31 | |
| Line has trailing spaces. | 37 | |
| Line has trailing spaces. | 39 | |
| Line has trailing spaces. | 48 | |
| Method 'getFeed' is not designed for extension - needs to be abstract, final or empty. | 49 | |
| Line has trailing spaces. | 53 | |
| Method 'getSelf' is not designed for extension - needs to be abstract, final or empty. | 54 | |
| Line has trailing spaces. | 58 | |
| Method 'getGadgets' is not designed for extension - needs to be abstract, final or empty. | 59 | |
| Line has trailing spaces. | 63 | |
| Missing a Javadoc comment. | 64 | |
| Line has trailing spaces. | 67 | |
| Line has trailing spaces. | 72 | |
| Line has trailing spaces. | 79 |
| Violation | Message | Line |
|---|---|---|
| 'org.slf4j.Logger' should be separated from previous imports. | 15 | |
| 'sun.util.LocaleServiceProviderPool' should be separated from previous imports. | 17 | |
| Import from illegal package - sun.util.LocaleServiceProviderPool. | 17 | |
| Unused import - sun.util.LocaleServiceProviderPool. | 17 | |
| Wrong order for 'com.google.common.base.Preconditions.checkNotNull' import. | 19 | |
| Missing a Javadoc comment. | 21 | |
| '=' is not preceded with whitespace. | 21 | |
| '=' is not followed by whitespace. | 21 | |
| '=' is not preceded with whitespace. | 25 | |
| '=' is not followed by whitespace. | 25 | |
| Line has trailing spaces. | 31 | |
| Line has trailing spaces. | 33 | |
| Line has trailing spaces. | 41 | |
| Line has trailing spaces. | 49 | |
| Method 'getSelf' is not designed for extension - needs to be abstract, final or empty. | 50 | |
| Line has trailing spaces. | 54 | |
| Method 'getSubscribedGadgetFeeds' is not designed for extension - needs to be abstract, final or empty. | 55 | |
| Line has trailing spaces. | 59 | |
| Missing a Javadoc comment. | 60 | |
| 'catch' is not followed by whitespace. | 87 | |
| Line has trailing spaces. | 93 | |
| Line has trailing spaces. | 106 | |
| Line has trailing spaces. | 111 | |
| Line has trailing spaces. | 116 | |
| Line has trailing spaces. | 121 | |
| Line has trailing spaces. | 126 | |
| Line has trailing spaces. | 131 | |
| Line has trailing spaces. | 136 |
| Violation | Message | Line |
|---|---|---|
| Class Fan-Out Complexity is 18 (max allowed is 10). | 43 | |
| Method 'getDirectory' is not designed for extension - needs to be abstract, final or empty. | 84 | |
| '}' is not preceded with whitespace. | 86 | |
| Method 'putGadgetInDirectory' is not designed for extension - needs to be abstract, final or empty. | 102 | |
| 'if' is not followed by whitespace. | 147 | |
| Method 'deleteGadgetFromDirectory' is not designed for extension - needs to be abstract, final or empty. | 177 |
| Violation | Message | Line |
|---|---|---|
| Missing a Javadoc comment. | 24 | |
| Line has trailing spaces. | 42 | |
| Method 'get' is not designed for extension - needs to be abstract, final or empty. | 43 | |
| '}' is not preceded with whitespace. | 44 | |
| Method 'remove' is not designed for extension - needs to be abstract, final or empty. | 52 | |
| Line has trailing spaces. | 68 |
| Violation | Message | Line |
|---|---|---|
| Missing package-info.java file. | 0 | |
| Using the '.*' form of import should be avoided - com.atlassian.gadgets.directory.internal.*. | 4 | |
| 'org.apache.commons.io.IOUtils' should be separated from previous imports. | 9 | |
| Wrong order for 'javax.servlet.http.HttpServletRequest' import. | 15 | |
| Using the '.*' form of import should be avoided - javax.ws.rs.*. | 16 | |
| Wrong order for 'java.io.IOException' import. | 20 | |
| 'org.apache.commons.lang.StringUtils.isEmpty' should be separated from previous imports. | 26 | |
| Missing a Javadoc comment. | 28 | |
| Class Fan-Out Complexity is 20 (max allowed is 10). | 28 | |
| Line has trailing spaces. | 32 | |
| Line has trailing spaces. | 37 | |
| Line has trailing spaces. | 49 | |
| Method 'get' is not designed for extension - needs to be abstract, final or empty. | 50 | |
| '}' is not preceded with whitespace. | 51 | |
| Line has trailing spaces. | 56 | |
| Method 'add' is not designed for extension - needs to be abstract, final or empty. | 57 | |
| '}' is not preceded with whitespace. | 59 | |
| Line is longer than 120 characters. | 66 | |
| Line is longer than 120 characters. | 100 | |
| Line has trailing spaces. | 107 | |
| Line has trailing spaces. | 121 | |
| Line is longer than 120 characters. | 128 |