The following document contains the results of Checkstyle.
Files | Infos ![]() |
Warnings ![]() |
Errors ![]() |
---|---|---|---|
32 | 63 | 100 | 103 |
Rules | Violations | Severity |
---|---|---|
JavadocPackage | 3 | ![]() |
Translation | 0 | ![]() |
FileLength | 0 | ![]() |
FileTabCharacter
|
0 | ![]() |
RegexpSingleline
|
86 | ![]() |
AnnotationUseStyle | 0 | ![]() |
MissingDeprecated | 0 | ![]() |
MissingOverride
|
0 | ![]() |
PackageAnnotation | 0 | ![]() |
JavadocMethod
|
15 | ![]() |
JavadocType
|
19 | ![]() |
JavadocVariable
|
2 | ![]() |
JavadocStyle
|
7 | ![]() |
ConstantName | 1 | ![]() |
LocalFinalVariableName | 0 | ![]() |
LocalVariableName | 0 | ![]() |
MemberName | 0 | ![]() |
MethodName | 0 | ![]() |
PackageName | 0 | ![]() |
ParameterName | 0 | ![]() |
StaticVariableName | 0 | ![]() |
TypeName | 0 | ![]() |
AvoidStarImport | 0 | ![]() |
IllegalImport | 0 | ![]() |
ImportOrder
|
9 | ![]() |
RedundantImport | 0 | ![]() |
UnusedImports | 0 | ![]() |
LineLength
|
14 | ![]() |
MethodLength | 0 | ![]() |
ParameterNumber | 0 | ![]() |
EmptyForIteratorPad | 0 | ![]() |
MethodParamPad | 0 | ![]() |
NoWhitespaceAfter | 0 | ![]() |
NoWhitespaceBefore | 0 | ![]() |
OperatorWrap | 6 | ![]() |
ParenPad | 2 | ![]() |
TypecastParenPad | 0 | ![]() |
WhitespaceAfter | 0 | ![]() |
WhitespaceAround | 17 | ![]() |
ModifierOrder | 1 | ![]() |
RedundantModifier | 0 | ![]() |
AvoidNestedBlocks | 0 | ![]() |
EmptyBlock | 0 | ![]() |
LeftCurly
|
0 | ![]() |
NeedBraces | 0 | ![]() |
RightCurly
|
0 | ![]() |
DeclarationOrder | 2 | ![]() |
DefaultComesLast | 0 | ![]() |
DoubleCheckedLocking | 0 | ![]() |
EmptyStatement | 0 | ![]() |
EqualsHashCode | 0 | ![]() |
ExplicitInitialization | 0 | ![]() |
FallThrough | 0 | ![]() |
HiddenField
|
0 | ![]() |
IllegalInstantiation | 0 | ![]() |
InnerAssignment | 0 | ![]() |
MagicNumber | 4 | ![]() |
MissingSwitchDefault | 0 | ![]() |
ParameterAssignment | 0 | ![]() |
RedundantThrows
|
0 | ![]() |
SimplifyBooleanExpression | 0 | ![]() |
SimplifyBooleanReturn | 0 | ![]() |
StringLiteralEquality | 0 | ![]() |
DesignForExtension | 63 | ![]() |
FinalClass | 1 | ![]() |
HideUtilityClassConstructor | 1 | ![]() |
InterfaceIsType | 0 | ![]() |
VisibilityModifier | 1 | ![]() |
BooleanExpressionComplexity | 0 | ![]() |
ClassDataAbstractionCoupling | 0 | ![]() |
ClassFanOutComplexity
|
8 | ![]() |
CyclomaticComplexity | 0 | ![]() |
NPathComplexity
|
0 | ![]() |
JavaNCSS | 0 | ![]() |
ArrayTypeStyle | 0 | ![]() |
Indentation | 0 | ![]() |
TodoComment | 4 | ![]() |
UpperEll | 0 | ![]() |
Violation | Message | Line |
---|---|---|
![]() |
First sentence should end with a period. | 19 |
Violation | Message | Line |
---|---|---|
![]() |
Missing a Javadoc comment. | 17 |
![]() |
Line has trailing spaces. | 29 |
![]() |
Method 'doGet' is not designed for extension - needs to be abstract, final or empty. | 30 |
![]() |
Line is longer than 120 characters. | 35 |
Violation | Message | Line |
---|---|---|
![]() |
Line is longer than 120 characters. | 23 |
![]() |
Method 'checkForPermissionToConfigureDirectory' is not designed for extension - needs to be abstract, final or empty. | 37 |
Violation | Message | Line |
---|---|---|
![]() |
Missing a Javadoc comment. | 8 |
Violation | Message | Line |
---|---|---|
![]() |
Missing package-info.java file. | 0 |
![]() |
First sentence should end with a period. | 12 |
![]() |
Line is longer than 120 characters. | 13 |
![]() |
'{' is not followed by whitespace. | 17 |
![]() |
'}' is not preceded with whitespace. | 17 |
![]() |
Line has trailing spaces. | 18 |
![]() |
'(' is followed by whitespace. | 49 |
![]() |
')' is preceded with whitespace. | 49 |
![]() |
Line has trailing spaces. | 55 |
![]() |
'if' is not followed by whitespace. | 56 |
Violation | Message | Line |
---|---|---|
![]() |
Missing a Javadoc comment. | 5 |
![]() |
First sentence should end with a period. | 16 |
![]() |
Line has trailing spaces. | 27 |
![]() |
Line has trailing spaces. | 31 |
![]() |
Line has trailing spaces. | 34 |
Violation | Message | Line |
---|---|---|
![]() |
First sentence should end with a period. | 5 |
![]() |
Line has trailing spaces. | 11 |
![]() |
Line has trailing spaces. | 17 |
![]() |
Method 'getFeedUri' is not designed for extension - needs to be abstract, final or empty. | 18 |
Violation | Message | Line |
---|---|---|
![]() |
Wrong order for 'com.atlassian.gadgets.directory.internal.GadgetSpecProviderHelper.containsSpecUri' import. | 36 |
![]() |
'com.google.common.base.Preconditions.checkNotNull' should be separated from previous imports. | 38 |
![]() |
'org.apache.commons.lang.StringUtils.isBlank' should be separated from previous imports. | 42 |
![]() |
Missing a Javadoc comment. | 44 |
![]() |
Class Fan-Out Complexity is 13 (max allowed is 10). | 44 |
![]() |
Line has trailing spaces. | 47 |
![]() |
Line has trailing spaces. | 49 |
![]() |
Line has trailing spaces. | 53 |
![]() |
Line has trailing spaces. | 60 |
![]() |
Method 'contains' is not designed for extension - needs to be abstract, final or empty. | 61 |
![]() |
Method 'entries' is not designed for extension - needs to be abstract, final or empty. | 66 |
![]() |
Line has trailing spaces. | 73 |
![]() |
Method 'addFeed' is not designed for extension - needs to be abstract, final or empty. | 78 |
![]() |
Line has trailing spaces. | 83 |
![]() |
Missing a Javadoc comment. | 87 |
![]() |
Line has trailing spaces. | 97 |
![]() |
Method 'getFeeds' is not designed for extension - needs to be abstract, final or empty. | 100 |
![]() |
Missing a Javadoc comment. | 104 |
![]() |
Line has trailing spaces. | 110 |
![]() |
Line has trailing spaces. | 113 |
![]() |
Method 'containsFeed' is not designed for extension - needs to be abstract, final or empty. | 117 |
![]() |
Missing a Javadoc comment. | 121 |
![]() |
Line has trailing spaces. | 130 |
![]() |
Method 'getFeedProvider' is not designed for extension - needs to be abstract, final or empty. | 134 |
![]() |
Missing a Javadoc comment. | 138 |
![]() |
Line has trailing spaces. | 151 |
![]() |
Method 'removeFeed' is not designed for extension - needs to be abstract, final or empty. | 154 |
![]() |
Missing a Javadoc comment. | 158 |
![]() |
Method 'getFeedProviders' is not designed for extension - needs to be abstract, final or empty. | 165 |
![]() |
Line has trailing spaces. | 169 |
![]() |
Line has trailing spaces. | 174 |
![]() |
Line is longer than 120 characters. | 175 |
![]() |
Instance variable definition in wrong order. | 175 |
![]() |
Missing a Javadoc comment. | 177 |
![]() |
Line has trailing spaces. | 182 |
![]() |
Line has trailing spaces. | 187 |
![]() |
Missing a Javadoc comment. | 188 |
![]() |
Class Fan-Out Complexity is 16 (max allowed is 10). | 188 |
![]() |
Line has trailing spaces. | 194 |
![]() |
Method 'getId' is not designed for extension - needs to be abstract, final or empty. | 201 |
![]() |
Line has trailing spaces. | 205 |
![]() |
Method 'getUri' is not designed for extension - needs to be abstract, final or empty. | 206 |
![]() |
Line has trailing spaces. | 210 |
![]() |
Method 'getApplicationName' is not designed for extension - needs to be abstract, final or empty. | 211 |
![]() |
Line has trailing spaces. | 220 |
![]() |
Method 'getTitle' is not designed for extension - needs to be abstract, final or empty. | 221 |
![]() |
Line has trailing spaces. | 225 |
![]() |
Method 'getIcon' is not designed for extension - needs to be abstract, final or empty. | 226 |
![]() |
Method 'getBaseUri' is not designed for extension - needs to be abstract, final or empty. | 236 |
![]() |
Method 'contains' is not designed for extension - needs to be abstract, final or empty. | 262 |
![]() |
Method 'entries' is not designed for extension - needs to be abstract, final or empty. | 267 |
![]() |
Line has trailing spaces. | 271 |
![]() |
Line has trailing spaces. | 322 |
![]() |
Class Fan-Out Complexity is 13 (max allowed is 10). | 329 |
![]() |
Line has trailing spaces. | 357 |
![]() |
Line is longer than 120 characters. | 375 |
![]() |
Line has trailing spaces. | 380 |
Violation | Message | Line |
---|---|---|
![]() |
Missing a Javadoc comment. | 14 |
![]() |
Utility classes should not have a public or default constructor. | 14 |
![]() |
Line has trailing spaces. | 24 |
![]() |
Line is longer than 120 characters. | 75 |
Violation | Message | Line |
---|---|---|
![]() |
Missing a Javadoc comment. | 12 |
Violation | Message | Line |
---|---|---|
![]() |
Line has trailing spaces. | 16 |
![]() |
Method 'getFeedUri' is not designed for extension - needs to be abstract, final or empty. | 17 |
Violation | Message | Line |
---|---|---|
![]() |
Missing a Javadoc comment. | 7 |
![]() |
Line has trailing spaces. | 17 |
![]() |
Method 'getId' is not designed for extension - needs to be abstract, final or empty. | 18 |
![]() |
Line has trailing spaces. | 22 |
![]() |
Method 'getUri' is not designed for extension - needs to be abstract, final or empty. | 23 |
![]() |
Line has trailing spaces. | 27 |
![]() |
Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 28 |
Violation | Message | Line |
---|---|---|
![]() |
Line has trailing spaces. | 10 |
![]() |
Line has trailing spaces. | 17 |
![]() |
Line has trailing spaces. | 21 |
![]() |
Line has trailing spaces. | 24 |
![]() |
Line has trailing spaces. | 29 |
![]() |
First sentence should end with a period. | 30 |
![]() |
Line has trailing spaces. | 32 |
![]() |
First sentence should end with a period. | 37 |
![]() |
Line has trailing spaces. | 39 |
Violation | Message | Line |
---|---|---|
![]() |
Missing a Javadoc comment. | 18 |
![]() |
Line is longer than 120 characters. | 37 |
Violation | Message | Line |
---|---|---|
![]() |
Comment matches to-do format 'TODO:'. | 27 |
![]() |
Class Fan-Out Complexity is 17 (max allowed is 10). | 28 |
![]() |
Method 'contains' is not designed for extension - needs to be abstract, final or empty. | 47 |
![]() |
Method 'internalEntries' is not designed for extension - needs to be abstract, final or empty. | 52 |
![]() |
Method 'add' is not designed for extension - needs to be abstract, final or empty. | 58 |
![]() |
Missing a Javadoc comment. | 62 |
![]() |
Method 'remove' is not designed for extension - needs to be abstract, final or empty. | 74 |
![]() |
Missing a Javadoc comment. | 78 |
![]() |
Method 'convertToLocalizedDirectoryEntry' is not designed for extension - needs to be abstract, final or empty. | 86 |
![]() |
Missing a Javadoc comment. | 92 |
![]() |
Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 138 |
Violation | Message | Line |
---|---|---|
![]() |
Wrong order for 'com.google.common.collect.Iterables.any' import. | 16 |
![]() |
Missing a Javadoc comment. | 20 |
![]() |
Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 22 |
![]() |
Method 'getEntries' is not designed for extension - needs to be abstract, final or empty. | 31 |
![]() |
Method 'contains' is not designed for extension - needs to be abstract, final or empty. | 36 |
![]() |
Missing a Javadoc comment. | 46 |
![]() |
Missing a Javadoc comment. | 72 |
Violation | Message | Line |
---|---|---|
![]() |
Missing a Javadoc comment. | 10 |
![]() |
Method 'buildDirectoryResourceUrl' is not designed for extension - needs to be abstract, final or empty. | 18 |
![]() |
Method 'buildDirectoryGadgetResourceUrl' is not designed for extension - needs to be abstract, final or empty. | 24 |
![]() |
Method 'buildSubscribedGadgetFeedsUrl' is not designed for extension - needs to be abstract, final or empty. | 30 |
![]() |
Line has trailing spaces. | 34 |
![]() |
Method 'buildSubscribedGadgetFeedUrl' is not designed for extension - needs to be abstract, final or empty. | 35 |
Violation | Message | Line |
---|---|---|
![]() |
'org.apache.commons.lang.StringUtils.defaultString' should be separated from previous imports. | 13 |
![]() |
Missing a Javadoc comment. | 15 |
![]() |
'static' modifier out of order with the JLS suggestions. | 17 |
![]() |
'&&' should be on a new line. | 123 |
![]() |
'&&' should be on a new line. | 124 |
![]() |
'31' is a magic number. | 133 |
![]() |
'31' is a magic number. | 134 |
![]() |
'+' should be on a new line. | 140 |
![]() |
'+' should be on a new line. | 141 |
![]() |
'+' should be on a new line. | 142 |
![]() |
'+' should be on a new line. | 143 |
Violation | Message | Line |
---|---|---|
![]() |
Wrong order for 'com.google.common.collect.Iterables.any' import. | 17 |
![]() |
Wrong order for 'java.util.Collections.emptySet' import. | 20 |
![]() |
Class Fan-Out Complexity is 11 (max allowed is 10). | 26 |
![]() |
Method 'contains' is not designed for extension - needs to be abstract, final or empty. | 44 |
![]() |
Missing a Javadoc comment. | 48 |
![]() |
Method 'internalEntries' is not designed for extension - needs to be abstract, final or empty. | 67 |
![]() |
Missing a Javadoc comment. | 72 |
![]() |
Method 'convertToLocalizedDirectoryEntry' is not designed for extension - needs to be abstract, final or empty. | 95 |
![]() |
Missing a Javadoc comment. | 101 |
![]() |
Line is longer than 120 characters. | 105 |
![]() |
Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 121 |
Violation | Message | Line |
---|---|---|
![]() |
Line has trailing spaces. | 27 |
![]() |
Method 'voteOn' is not designed for extension - needs to be abstract, final or empty. | 28 |
Violation | Message | Line |
---|---|---|
![]() |
Missing package-info.java file. | 0 |
![]() |
Class Fan-Out Complexity is 13 (max allowed is 10). | 25 |
![]() |
Method 'contains' is not designed for extension - needs to be abstract, final or empty. | 42 |
![]() |
Method 'pluginGadgetSpecEnabled' is not designed for extension - needs to be abstract, final or empty. | 55 |
![]() |
Method 'pluginGadgetSpecDisabled' is not designed for extension - needs to be abstract, final or empty. | 63 |
![]() |
Method 'internalEntries' is not designed for extension - needs to be abstract, final or empty. | 71 |
![]() |
Method 'convertToLocalizedDirectoryEntry' is not designed for extension - needs to be abstract, final or empty. | 85 |
![]() |
Missing a Javadoc comment. | 91 |
![]() |
Line is longer than 120 characters. | 138 |
![]() |
Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 142 |
Violation | Message | Line |
---|---|---|
![]() |
Missing a Javadoc comment. | 20 |
![]() |
Missing a Javadoc comment. | 22 |
![]() |
Line has trailing spaces. | 23 |
![]() |
Line has trailing spaces. | 30 |
![]() |
Method 'add' is not designed for extension - needs to be abstract, final or empty. | 31 |
![]() |
Method 'contains' is not designed for extension - needs to be abstract, final or empty. | 36 |
![]() |
Method 'get' is not designed for extension - needs to be abstract, final or empty. | 41 |
![]() |
Method 'getAll' is not designed for extension - needs to be abstract, final or empty. | 46 |
![]() |
Line has trailing spaces. | 50 |
![]() |
Method 'remove' is not designed for extension - needs to be abstract, final or empty. | 51 |
![]() |
Line has trailing spaces. | 72 |
![]() |
Line has trailing spaces. | 81 |
![]() |
Line has trailing spaces. | 86 |
Violation | Message | Line |
---|---|---|
![]() |
First sentence should end with a period. | 3 |
Violation | Message | Line |
---|---|---|
![]() |
Comment matches to-do format 'TODO:'. | 12 |
![]() |
'}' is not preceded with whitespace. | 21 |
Violation | Message | Line |
---|---|---|
![]() |
Comment matches to-do format 'TODO:'. | 19 |
![]() |
Class JAXBDirectoryContents should be declared as final. | 21 |
![]() |
'}' is not preceded with whitespace. | 24 |
![]() |
'}' is not preceded with whitespace. | 27 |
![]() |
Line is longer than 120 characters. | 45 |
Violation | Message | Line |
---|---|---|
![]() |
Comment matches to-do format 'TODO:'. | 17 |
![]() |
'}' is not preceded with whitespace. | 45 |
![]() |
Line is longer than 120 characters. | 61 |
![]() |
'17' is a magic number. | 202 |
![]() |
'29' is a magic number. | 202 |
Violation | Message | Line |
---|---|---|
![]() |
Missing a Javadoc comment. | 19 |
![]() |
Missing a Javadoc comment. | 24 |
![]() |
Variable access definition in wrong order. | 24 |
![]() |
'=' is not preceded with whitespace. | 24 |
![]() |
'=' is not followed by whitespace. | 24 |
![]() |
Variable 'gadgets' must be private and have accessor methods. | 24 |
![]() |
Line has trailing spaces. | 25 |
![]() |
Line has trailing spaces. | 31 |
![]() |
Line has trailing spaces. | 37 |
![]() |
Line has trailing spaces. | 39 |
![]() |
Line has trailing spaces. | 48 |
![]() |
Method 'getFeed' is not designed for extension - needs to be abstract, final or empty. | 49 |
![]() |
Line has trailing spaces. | 53 |
![]() |
Method 'getSelf' is not designed for extension - needs to be abstract, final or empty. | 54 |
![]() |
Line has trailing spaces. | 58 |
![]() |
Method 'getGadgets' is not designed for extension - needs to be abstract, final or empty. | 59 |
![]() |
Line has trailing spaces. | 63 |
![]() |
Missing a Javadoc comment. | 64 |
![]() |
Line has trailing spaces. | 67 |
![]() |
Line has trailing spaces. | 72 |
![]() |
Line has trailing spaces. | 79 |
Violation | Message | Line |
---|---|---|
![]() |
Missing a Javadoc comment. | 17 |
![]() |
'=' is not preceded with whitespace. | 17 |
![]() |
'=' is not followed by whitespace. | 17 |
![]() |
'=' is not preceded with whitespace. | 21 |
![]() |
'=' is not followed by whitespace. | 21 |
![]() |
Line has trailing spaces. | 27 |
![]() |
Line has trailing spaces. | 29 |
![]() |
Line has trailing spaces. | 37 |
![]() |
Line has trailing spaces. | 45 |
![]() |
Method 'getSelf' is not designed for extension - needs to be abstract, final or empty. | 46 |
![]() |
Line has trailing spaces. | 50 |
![]() |
Method 'getSubscribedGadgetFeeds' is not designed for extension - needs to be abstract, final or empty. | 51 |
![]() |
Line has trailing spaces. | 55 |
![]() |
Missing a Javadoc comment. | 56 |
![]() |
Line has trailing spaces. | 76 |
![]() |
Line has trailing spaces. | 89 |
![]() |
Line has trailing spaces. | 94 |
![]() |
Line has trailing spaces. | 99 |
![]() |
Line has trailing spaces. | 104 |
![]() |
Line has trailing spaces. | 109 |
![]() |
Line has trailing spaces. | 114 |
![]() |
Line has trailing spaces. | 119 |
Violation | Message | Line |
---|---|---|
![]() |
Class Fan-Out Complexity is 18 (max allowed is 10). | 43 |
![]() |
Method 'getDirectory' is not designed for extension - needs to be abstract, final or empty. | 84 |
![]() |
'}' is not preceded with whitespace. | 86 |
![]() |
Method 'putGadgetInDirectory' is not designed for extension - needs to be abstract, final or empty. | 102 |
![]() |
Method 'deleteGadgetFromDirectory' is not designed for extension - needs to be abstract, final or empty. | 171 |
Violation | Message | Line |
---|---|---|
![]() |
Missing a Javadoc comment. | 24 |
![]() |
Line has trailing spaces. | 42 |
![]() |
Method 'get' is not designed for extension - needs to be abstract, final or empty. | 43 |
![]() |
'}' is not preceded with whitespace. | 44 |
![]() |
Method 'remove' is not designed for extension - needs to be abstract, final or empty. | 52 |
![]() |
Line has trailing spaces. | 68 |
Violation | Message | Line |
---|---|---|
![]() |
Missing package-info.java file. | 0 |
![]() |
Wrong order for 'com.google.common.base.Preconditions.checkNotNull' import. | 36 |
![]() |
'org.apache.commons.lang.StringUtils.isEmpty' should be separated from previous imports. | 37 |
![]() |
Missing a Javadoc comment. | 39 |
![]() |
Class Fan-Out Complexity is 20 (max allowed is 10). | 39 |
![]() |
Line has trailing spaces. | 43 |
![]() |
Line has trailing spaces. | 48 |
![]() |
Line has trailing spaces. | 60 |
![]() |
Method 'get' is not designed for extension - needs to be abstract, final or empty. | 61 |
![]() |
'}' is not preceded with whitespace. | 62 |
![]() |
Line has trailing spaces. | 67 |
![]() |
Method 'add' is not designed for extension - needs to be abstract, final or empty. | 68 |
![]() |
'}' is not preceded with whitespace. | 70 |
![]() |
Line has trailing spaces. | 74 |
![]() |
Line is longer than 120 characters. | 77 |
![]() |
Line is longer than 120 characters. | 111 |
![]() |
Line has trailing spaces. | 118 |
![]() |
Line has trailing spaces. | 132 |
![]() |
Line is longer than 120 characters. | 139 |