The following document contains the results of Checkstyle.
Files | Infos | Warnings | Errors |
---|---|---|---|
21 | 25 | 9 | 102 |
Rules | Violations | Severity |
---|---|---|
JavadocPackage | 2 | Error |
Translation | 0 | Error |
FileLength | 0 | Error |
FileTabCharacter
|
0 | Error |
RegexpSingleline
|
3 | Warning |
AnnotationUseStyle | 0 | Error |
MissingDeprecated | 0 | Error |
MissingOverride
|
0 | Error |
PackageAnnotation | 0 | Error |
JavadocMethod
|
9 | Error |
JavadocType
|
8 | Error |
JavadocVariable
|
12 | Error |
JavadocStyle
|
4 | Error |
ConstantName | 2 | Error |
LocalFinalVariableName | 0 | Error |
LocalVariableName | 0 | Error |
MemberName | 0 | Error |
MethodName | 0 | Error |
PackageName | 0 | Error |
ParameterName | 0 | Error |
StaticVariableName | 0 | Error |
TypeName | 0 | Error |
AvoidStarImport | 0 | Error |
IllegalImport | 0 | Error |
ImportOrder
|
30 | Error |
RedundantImport | 0 | Error |
UnusedImports | 0 | Error |
LineLength
|
6 | Warning |
MethodLength | 0 | Error |
ParameterNumber | 0 | Error |
EmptyForIteratorPad | 0 | Error |
MethodParamPad | 0 | Error |
NoWhitespaceAfter | 0 | Error |
NoWhitespaceBefore | 0 | Error |
OperatorWrap | 6 | Error |
ParenPad | 2 | Error |
TypecastParenPad | 0 | Error |
WhitespaceAfter | 0 | Error |
WhitespaceAround | 8 | Error |
ModifierOrder | 1 | Error |
RedundantModifier | 4 | Error |
AvoidNestedBlocks | 0 | Error |
EmptyBlock | 0 | Error |
LeftCurly
|
0 | Error |
NeedBraces | 0 | Error |
RightCurly
|
0 | Error |
DeclarationOrder | 1 | Error |
DefaultComesLast | 0 | Error |
DoubleCheckedLocking | 0 | Error |
EmptyStatement | 0 | Error |
EqualsHashCode | 0 | Error |
ExplicitInitialization | 0 | Error |
FallThrough | 0 | Error |
HiddenField
|
0 | Error |
IllegalInstantiation | 0 | Error |
InnerAssignment | 0 | Error |
MagicNumber | 4 | Error |
MissingSwitchDefault | 0 | Error |
ParameterAssignment | 0 | Error |
RedundantThrows
|
0 | Error |
SimplifyBooleanExpression | 0 | Error |
SimplifyBooleanReturn | 0 | Error |
StringLiteralEquality | 0 | Error |
DesignForExtension | 25 | Info |
FinalClass | 1 | Error |
HideUtilityClassConstructor | 0 | Error |
InterfaceIsType | 0 | Error |
VisibilityModifier | 0 | Error |
BooleanExpressionComplexity | 0 | Error |
ClassDataAbstractionCoupling | 0 | Error |
ClassFanOutComplexity
|
4 | Error |
CyclomaticComplexity | 0 | Error |
NPathComplexity
|
0 | Error |
JavaNCSS | 0 | Error |
ArrayTypeStyle | 0 | Error |
Indentation | 0 | Error |
TodoComment | 4 | Error |
UpperEll | 0 | Error |
Violation | Message | Line |
---|---|---|
Missing package-info.java file. | 0 | |
Wrong order for 'java.util.Arrays' import. | 5 | |
Missing a Javadoc comment. | 10 | |
Missing a Javadoc comment. | 14 | |
Missing a Javadoc comment. | 15 | |
Missing a Javadoc comment. | 18 | |
Missing a Javadoc comment. | 19 | |
Missing a Javadoc comment. | 20 | |
Missing a Javadoc comment. | 21 | |
Missing a Javadoc comment. | 24 | |
Missing a Javadoc comment. | 26 | |
Missing a Javadoc comment. | 46 | |
Missing a Javadoc comment. | 48 | |
Static variable definition in wrong order. | 60 | |
Name 'categoryNameMap' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 60 |
Violation | Message | Line |
---|---|---|
First sentence should end with a period. | 19 |
Violation | Message | Line |
---|---|---|
Wrong order for 'java.net.URI' import. | 5 | |
Missing a Javadoc comment. | 10 | |
Missing a Javadoc comment. | 12 | |
Redundant 'public' modifier. | 12 | |
Missing a Javadoc comment. | 13 | |
Redundant 'public' modifier. | 13 |
Violation | Message | Line |
---|---|---|
Method 'checkForPermissionToConfigureDirectory' is not designed for extension - needs to be abstract, final or empty. | 37 |
Violation | Message | Line |
---|---|---|
Wrong order for 'java.net.URI' import. | 5 | |
Missing a Javadoc comment. | 7 |
Violation | Message | Line |
---|---|---|
Wrong order for 'javax.annotation.Nullable' import. | 5 | |
First sentence should end with a period. | 9 | |
Line is longer than 120 characters. | 10 | |
'{' is not followed by whitespace. | 14 | |
'}' is not preceded with whitespace. | 14 | |
Line has trailing spaces. | 15 | |
'(' is followed by whitespace. | 45 | |
')' is preceded with whitespace. | 45 | |
Line has trailing spaces. | 51 | |
'if' is not followed by whitespace. | 52 |
Violation | Message | Line |
---|---|---|
Wrong order for 'org.apache.commons.logging.Log' import. | 31 | |
Class Fan-Out Complexity is 18 (max allowed is 10). | 39 | |
Method 'getDirectory' is not designed for extension - needs to be abstract, final or empty. | 80 | |
'}' is not preceded with whitespace. | 82 | |
Method 'putGadgetInDirectory' is not designed for extension - needs to be abstract, final or empty. | 98 | |
Method 'deleteGadgetFromDirectory' is not designed for extension - needs to be abstract, final or empty. | 170 |
Violation | Message | Line |
---|---|---|
Missing a Javadoc comment. | 5 | |
Redundant 'public' modifier. | 14 | |
First sentence should end with a period. | 16 | |
Redundant 'public' modifier. | 23 |
Violation | Message | Line |
---|---|---|
Missing package-info.java file. | 0 | |
Wrong order for 'com.atlassian.gadgets.directory.internal.Directory' import. | 6 | |
Wrong order for 'com.google.common.base.Function' import. | 9 | |
Wrong order for 'com.atlassian.gadgets.spec.GadgetSpecFactory' import. | 13 | |
Wrong order for 'com.atlassian.gadgets.spec.GadgetSpec' import. | 14 | |
Wrong order for 'com.atlassian.gadgets.GadgetParsingException' import. | 15 | |
Missing a Javadoc comment. | 18 | |
Line is longer than 120 characters. | 37 |
Violation | Message | Line |
---|---|---|
Wrong order for 'com.atlassian.sal.api.transaction.TransactionCallback' import. | 17 | |
Comment matches to-do format 'TODO:'. | 27 | |
Class Fan-Out Complexity is 17 (max allowed is 10). | 28 | |
Method 'contains' is not designed for extension - needs to be abstract, final or empty. | 47 | |
Method 'internalEntries' is not designed for extension - needs to be abstract, final or empty. | 52 | |
Method 'add' is not designed for extension - needs to be abstract, final or empty. | 58 | |
Missing a Javadoc comment. | 62 | |
Method 'remove' is not designed for extension - needs to be abstract, final or empty. | 74 | |
Missing a Javadoc comment. | 78 | |
Method 'convertToLocalizedDirectoryEntry' is not designed for extension - needs to be abstract, final or empty. | 86 | |
Missing a Javadoc comment. | 91 | |
Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 137 |
Violation | Message | Line |
---|---|---|
Wrong order for 'java.net.URI' import. | 7 | |
Wrong order for 'com.atlassian.gadgets.GadgetRequestContext' import. | 12 | |
'com.google.common.base.Function' should be separated from previous imports. | 15 | |
Missing a Javadoc comment. | 19 | |
Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 21 | |
Method 'getEntries' is not designed for extension - needs to be abstract, final or empty. | 30 | |
Method 'contains' is not designed for extension - needs to be abstract, final or empty. | 35 | |
Missing a Javadoc comment. | 45 | |
Missing a Javadoc comment. | 71 |
Violation | Message | Line |
---|---|---|
Wrong order for 'com.atlassian.gadgets.spi.ExternalGadgetSpecId' import. | 5 | |
Missing a Javadoc comment. | 9 | |
Method 'buildDirectoryResourceUrl' is not designed for extension - needs to be abstract, final or empty. | 17 | |
Method 'buildDirectoryGadgetResourceUrl' is not designed for extension - needs to be abstract, final or empty. | 23 |
Violation | Message | Line |
---|---|---|
'org.apache.commons.lang.StringUtils.defaultString' should be separated from previous imports. | 11 | |
Wrong order for 'com.atlassian.gadgets.spec.Feature' import. | 12 | |
Missing a Javadoc comment. | 15 | |
'static' modifier out of order with the JLS suggestions. | 17 | |
'&&' should be on a new line. | 123 | |
'&&' should be on a new line. | 124 | |
'31' is a magic number. | 133 | |
'31' is a magic number. | 134 | |
'+' should be on a new line. | 140 | |
'+' should be on a new line. | 141 | |
'+' should be on a new line. | 142 | |
'+' should be on a new line. | 143 |
Violation | Message | Line |
---|---|---|
Wrong order for 'com.atlassian.gadgets.GadgetSpecProvider' import. | 7 | |
'org.apache.commons.logging.Log' should be separated from previous imports. | 14 | |
Wrong order for 'com.atlassian.gadgets.spec.GadgetSpecFactory' import. | 16 | |
Wrong order for 'com.atlassian.gadgets.GadgetParsingException' import. | 17 | |
Class Fan-Out Complexity is 11 (max allowed is 10). | 24 | |
Method 'contains' is not designed for extension - needs to be abstract, final or empty. | 42 | |
Missing a Javadoc comment. | 46 | |
Method 'internalEntries' is not designed for extension - needs to be abstract, final or empty. | 65 | |
Missing a Javadoc comment. | 69 | |
Method 'convertToLocalizedDirectoryEntry' is not designed for extension - needs to be abstract, final or empty. | 92 | |
Missing a Javadoc comment. | 97 | |
Line is longer than 120 characters. | 101 | |
Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 117 |
Violation | Message | Line |
---|---|---|
Line has trailing spaces. | 27 | |
Method 'voteOn' is not designed for extension - needs to be abstract, final or empty. | 28 |
Violation | Message | Line |
---|---|---|
Wrong order for 'com.google.common.collect.ImmutableSet' import. | 18 | |
Class Fan-Out Complexity is 13 (max allowed is 10). | 24 | |
Method 'contains' is not designed for extension - needs to be abstract, final or empty. | 41 | |
Method 'pluginGadgetSpecEnabled' is not designed for extension - needs to be abstract, final or empty. | 54 | |
Method 'pluginGadgetSpecDisabled' is not designed for extension - needs to be abstract, final or empty. | 62 | |
Method 'internalEntries' is not designed for extension - needs to be abstract, final or empty. | 70 | |
Method 'convertToLocalizedDirectoryEntry' is not designed for extension - needs to be abstract, final or empty. | 83 | |
Missing a Javadoc comment. | 88 | |
Line is longer than 120 characters. | 135 | |
Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 139 |
Violation | Message | Line |
---|---|---|
First sentence should end with a period. | 3 |
Violation | Message | Line |
---|---|---|
'org.apache.commons.lang.builder.EqualsBuilder' should be separated from previous imports. | 4 | |
Wrong order for 'javax.xml.bind.annotation.XmlElement' import. | 6 | |
Comment matches to-do format 'TODO:'. | 11 | |
'}' is not preceded with whitespace. | 20 |
Violation | Message | Line |
---|---|---|
Wrong order for 'com.atlassian.gadgets.GadgetRequestContext' import. | 5 | |
Wrong order for 'javax.xml.bind.annotation.XmlElement' import. | 7 | |
Wrong order for 'java.util.Collection' import. | 9 | |
Wrong order for 'com.google.common.collect.ImmutableList' import. | 14 | |
Comment matches to-do format 'TODO:'. | 18 | |
Class JAXBDirectoryContents should be declared as final. | 20 | |
'}' is not preceded with whitespace. | 23 | |
'}' is not preceded with whitespace. | 26 | |
Line is longer than 120 characters. | 44 |
Violation | Message | Line |
---|---|---|
Wrong order for 'javax.xml.bind.annotation.XmlElement' import. | 9 | |
Wrong order for 'java.net.URI' import. | 11 | |
Comment matches to-do format 'TODO:'. | 16 | |
'}' is not preceded with whitespace. | 44 | |
Line is longer than 120 characters. | 60 | |
'17' is a magic number. | 201 | |
'29' is a magic number. | 201 |