The following document contains the results of FindBugs Report
FindBugs Version is 1.3.8
Threshold is Low
Effort is Default
Classes | Bugs | Errors | Missing Classes |
---|---|---|---|
321 | 16 | 0 | 0 |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method com.atlassian.gadgets.dashboard.internal.DashboardTemplateRenderer.createContext(Map, Writer) needlessly instantiates a class that only supplies static methods | BAD_PRACTICE | ISC_INSTANTIATE_STATIC_CLASS | 61 | Low |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Class com.atlassian.gadgets.dashboard.internal.diagnostics.DiagnosticsServlet defines non-transient non-serializable instance field diagnostics | BAD_PRACTICE | SE_BAD_FIELD | Not available | Medium |
Class com.atlassian.gadgets.dashboard.internal.diagnostics.DiagnosticsServlet defines non-transient non-serializable instance field renderer | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
Class com.atlassian.gadgets.dashboard.internal.diagnostics.DiagnosticsServlet defines non-transient non-serializable instance field userManager | BAD_PRACTICE | SE_BAD_FIELD | Not available | Low |
com.atlassian.gadgets.dashboard.internal.diagnostics.DiagnosticsServlet is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 21-112 | Low |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
column must be nonnull but is marked as nullable | STYLE | NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE | 340 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
gadgetState must be nonnull but is marked as nullable | STYLE | NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE | 360 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method com.atlassian.gadgets.dashboard.internal.impl.GadgetFactoryImpl.createGadget(GadgetState, GadgetRequestContext) invokes toString() method on a String | PERFORMANCE | DM_STRING_TOSTRING | 111 | Low |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Load of known null value in com.atlassian.gadgets.dashboard.internal.rest.ChangeLayoutHandlerImpl.persistLayout(Dashboard, JSONObject) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 117 | Low |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should com.atlassian.gadgets.dashboard.internal.rest.ChangeLayoutHandlerImpl$ParseGadgetLayoutException be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 175-177 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Load of known null value in com.atlassian.gadgets.dashboard.internal.rest.GadgetResource.changeGadgetColor(DashboardId, GadgetId, HttpServletRequest, String) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 335 | Low |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Method com.atlassian.gadgets.dashboard.internal.rest.UpdateGadgetUserPrefsHandlerImpl.adaptParameterMapToUserPrefValues(Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 83 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 39 | Low |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
userPref must be nonnull but is marked as nullable | STYLE | NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE | 61 | Medium |
The class com.atlassian.gadgets.dashboard.internal.rest.representations.UserPrefsRepresentation$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 58-61 | Low |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 237 | Low |