Checkstyle Results

The following document contains the results of Checkstylerss feed

Summary

Files Infos Infos Warnings Warnings Errors Errors
54 117 131 157

Files

Files Infos Warnings Errors
com/atlassian/gadgets/dashboard/internal/AbstractViewComponent.java 3 0 2
com/atlassian/gadgets/dashboard/internal/Dashboard.java 0 9 9
com/atlassian/gadgets/dashboard/internal/DashboardRepository.java 0 0 2
com/atlassian/gadgets/dashboard/internal/DashboardTemplateRenderer.java 4 3 1
com/atlassian/gadgets/dashboard/internal/DashboardUrlBuilder.java 0 18 8
com/atlassian/gadgets/dashboard/internal/DashboardWebItemFinder.java 2 2 1
com/atlassian/gadgets/dashboard/internal/Gadget.java 0 7 4
com/atlassian/gadgets/dashboard/internal/GadgetFactory.java 0 2 1
com/atlassian/gadgets/dashboard/internal/GadgetLayoutException.java 0 1 0
com/atlassian/gadgets/dashboard/internal/GadgetNotLoadedException.java 1 1 1
com/atlassian/gadgets/dashboard/internal/InconsistentDashboardStateException.java 0 0 1
com/atlassian/gadgets/dashboard/internal/StateConverter.java 0 0 3
com/atlassian/gadgets/dashboard/internal/Tab.java 0 1 0
com/atlassian/gadgets/dashboard/internal/UserPref.java 0 0 2
com/atlassian/gadgets/dashboard/internal/diagnostics/Diagnostics.java 1 0 5
com/atlassian/gadgets/dashboard/internal/diagnostics/DiagnosticsException.java 1 0 1
com/atlassian/gadgets/dashboard/internal/diagnostics/DiagnosticsServlet.java 2 3 5
com/atlassian/gadgets/dashboard/internal/diagnostics/UrlHostnameMismatchException.java 2 0 1
com/atlassian/gadgets/dashboard/internal/diagnostics/UrlPortMismatchException.java 2 0 1
com/atlassian/gadgets/dashboard/internal/diagnostics/UrlSchemeMismatchException.java 2 0 1
com/atlassian/gadgets/dashboard/internal/impl/Column.java 0 2 4
com/atlassian/gadgets/dashboard/internal/impl/DashboardImpl.java 19 6 7
com/atlassian/gadgets/dashboard/internal/impl/DashboardRepositoryImpl.java 3 3 0
com/atlassian/gadgets/dashboard/internal/impl/DashboardServiceImpl.java 2 1 0
com/atlassian/gadgets/dashboard/internal/impl/DashboardUrlBuilderImpl.java 14 4 1
com/atlassian/gadgets/dashboard/internal/impl/GadgetFactoryImpl.java 2 4 2
com/atlassian/gadgets/dashboard/internal/impl/GadgetImpl.java 0 3 7
com/atlassian/gadgets/dashboard/internal/impl/StateConverterImpl.java 2 0 1
com/atlassian/gadgets/dashboard/internal/impl/TabImpl.java 4 0 1
com/atlassian/gadgets/dashboard/internal/impl/TransactionalDashboardStateStoreImpl.java 4 1 9
com/atlassian/gadgets/dashboard/internal/impl/UserPrefImpl.java 0 1 7
com/atlassian/gadgets/dashboard/internal/rest/AddGadgetHandlerImpl.java 3 8 4
com/atlassian/gadgets/dashboard/internal/rest/ChangeGadgetColorHandlerImpl.java 1 0 0
com/atlassian/gadgets/dashboard/internal/rest/ChangeLayoutHandlerImpl.java 1 2 3
com/atlassian/gadgets/dashboard/internal/rest/DashboardResource.java 5 4 3
com/atlassian/gadgets/dashboard/internal/rest/DeleteGadgetHandlerImpl.java 1 0 0
com/atlassian/gadgets/dashboard/internal/rest/GadgetResource.java 8 3 14
com/atlassian/gadgets/dashboard/internal/rest/UpdateGadgetUserPrefsHandlerImpl.java 1 0 2
com/atlassian/gadgets/dashboard/internal/rest/representations/DashboardRepresentation.java 3 0 5
com/atlassian/gadgets/dashboard/internal/rest/representations/GadgetRepresentation.java 17 1 7
com/atlassian/gadgets/dashboard/internal/rest/representations/RepresentationFactory.java 0 2 1
com/atlassian/gadgets/dashboard/internal/rest/representations/RepresentationFactoryImpl.java 2 5 2
com/atlassian/gadgets/dashboard/internal/rest/representations/UserPrefRepresentation.java 3 4 2
com/atlassian/gadgets/dashboard/internal/rest/representations/UserPrefsRepresentation.java 0 1 4
com/atlassian/gadgets/dashboard/internal/util/JavaScript.java 0 11 10
com/atlassian/gadgets/dashboard/internal/velocity/DashboardEmbedder.java 1 15 4
com/atlassian/gadgets/dashboard/internal/velocity/DashboardView.java 0 2 6
com/atlassian/gadgets/dashboard/internal/velocity/VelocityViewFactory.java 1 1 2

Rules

Rules Violations Severity
JavadocPackage 6 Errors Error
Translation 0 Errors Error
FileLength 0 Errors Error
FileTabCharacter
  • eachLine: "true"
2 Errors Error
RegexpSingleline
  • message: "Line has trailing spaces."
  • format: "\s+$"
78 Warnings Warning
AnnotationUseStyle 0 Errors Error
MissingDeprecated 0 Errors Error
MissingOverride
  • javaFiveCompatibility: "true"
0 Errors Error
PackageAnnotation 0 Errors Error
JavadocMethod
  • excludeScope: "private"
  • scope: "anoninner"
7 Errors Error
JavadocType
  • scope: "package"
25 Errors Error
JavadocVariable
  • scope: "package"
0 Errors Error
JavadocStyle
  • scope: "package"
16 Errors Error
ConstantName 3 Errors Error
LocalFinalVariableName 0 Errors Error
LocalVariableName 0 Errors Error
MemberName 0 Errors Error
MethodName 0 Errors Error
PackageName 0 Errors Error
ParameterName 0 Errors Error
StaticVariableName 0 Errors Error
TypeName 0 Errors Error
AvoidStarImport 0 Errors Error
IllegalImport 0 Errors Error
ImportOrder
  • separated: "true"
  • groups: "java,javax,com.atlassian,com,org"
7 Errors Error
RedundantImport 0 Errors Error
UnusedImports 0 Errors Error
LineLength
  • max: "120"
53 Warnings Warning
MethodLength 0 Errors Error
ParameterNumber 2 Errors Error
EmptyForIteratorPad 1 Errors Error
MethodParamPad 2 Errors Error
NoWhitespaceAfter 0 Errors Error
NoWhitespaceBefore 0 Errors Error
OperatorWrap 4 Errors Error
ParenPad 3 Errors Error
TypecastParenPad 0 Errors Error
WhitespaceAfter 2 Errors Error
WhitespaceAround 13 Errors Error
ModifierOrder 2 Errors Error
RedundantModifier 9 Errors Error
AvoidNestedBlocks 0 Errors Error
EmptyBlock 0 Errors Error
LeftCurly
  • option: "nl"
1 Errors Error
NeedBraces 3 Errors Error
RightCurly
  • option: "alone"
0 Errors Error
DeclarationOrder 3 Errors Error
DefaultComesLast 0 Errors Error
DoubleCheckedLocking 0 Errors Error
EmptyStatement 0 Errors Error
EqualsHashCode 0 Errors Error
ExplicitInitialization 1 Errors Error
FallThrough 0 Errors Error
HiddenField
  • ignoreConstructorParameter: "true"
  • ignoreSetter: "true"
6 Errors Error
IllegalInstantiation 0 Errors Error
InnerAssignment 0 Errors Error
MagicNumber 9 Errors Error
MissingSwitchDefault 0 Errors Error
ParameterAssignment 0 Errors Error
RedundantThrows
  • allowUnchecked: "true"
0 Errors Error
SimplifyBooleanExpression 0 Errors Error
SimplifyBooleanReturn 0 Errors Error
StringLiteralEquality 0 Errors Error
DesignForExtension 117 Infos Info
FinalClass 0 Errors Error
HideUtilityClassConstructor 1 Errors Error
InterfaceIsType 0 Errors Error
VisibilityModifier 0 Errors Error
BooleanExpressionComplexity 0 Errors Error
ClassDataAbstractionCoupling 1 Errors Error
ClassFanOutComplexity
  • max: "10"
14 Errors Error
CyclomaticComplexity 1 Errors Error
NPathComplexity
  • max: "20"
3 Errors Error
JavaNCSS 1 Errors Error
ArrayTypeStyle 0 Errors Error
Indentation 8 Errors Error
TodoComment 1 Errors Error
UpperEll 0 Errors Error

Details

com/atlassian/gadgets/dashboard/internal/AbstractViewComponent.java

Violation Message Line
Errors Missing package-info.java file. 0
Errors Missing a Javadoc comment. 7
Infos Method 'getId' is not designed for extension - needs to be abstract, final or empty. 18
Infos Method 'getTitle' is not designed for extension - needs to be abstract, final or empty. 23
Infos Method 'toString' is not designed for extension - needs to be abstract, final or empty. 28

com/atlassian/gadgets/dashboard/internal/Dashboard.java

Violation Message Line
Errors Missing a Javadoc comment. 16
Errors Class Fan-Out Complexity is 14 (max allowed is 10). 16
Warnings Line has trailing spaces. 21
Warnings Line has trailing spaces. 23
Warnings Line has trailing spaces. 25
Errors First sentence should end with a period. 43
Errors Redundant 'public' modifier. 46
Errors First sentence should end with a period. 57
Errors First sentence should end with a period. 65
Errors First sentence should end with a period. 72
Warnings Line has trailing spaces. 80
Warnings Line has trailing spaces. 87
Warnings Line has trailing spaces. 95
Warnings Line has trailing spaces. 99
Warnings Line has trailing spaces. 105
Errors First sentence should end with a period. 113
Warnings Line is longer than 120 characters. 121
Errors ',' is not followed by whitespace. 121

com/atlassian/gadgets/dashboard/internal/DashboardRepository.java

Violation Message Line
Errors Missing a Javadoc comment. 8
Errors '(' is preceded with whitespace. 11

com/atlassian/gadgets/dashboard/internal/DashboardTemplateRenderer.java

Violation Message Line
Errors Missing a Javadoc comment. 16
Warnings Line has trailing spaces. 33
Infos Method 'render' is not designed for extension - needs to be abstract, final or empty. 34
Warnings Line is longer than 120 characters. 39
Infos Method 'render' is not designed for extension - needs to be abstract, final or empty. 39
Warnings Line has trailing spaces. 43
Infos Method 'renderFragment' is not designed for extension - needs to be abstract, final or empty. 44
Infos Method 'resolve' is not designed for extension - needs to be abstract, final or empty. 49

com/atlassian/gadgets/dashboard/internal/DashboardUrlBuilder.java

Violation Message Line
Warnings Line has trailing spaces. 22
Warnings Line has trailing spaces. 26
Warnings Line has trailing spaces. 29
Warnings Line has trailing spaces. 30
Warnings Line has trailing spaces. 34
Warnings Line has trailing spaces. 37
Warnings Line has trailing spaces. 39
Warnings Line has trailing spaces. 43
Warnings Line has trailing spaces. 46
Warnings Line has trailing spaces. 48
Warnings Line has trailing spaces. 52
Warnings Line has trailing spaces. 55
Warnings Line has trailing spaces. 57
Warnings Line has trailing spaces. 64
Errors Redundant 'public' modifier. 76
Errors Redundant 'public' modifier. 84
Errors Redundant 'public' modifier. 92
Errors First sentence should end with a period. 94
Errors Redundant 'public' modifier. 99
Warnings Line has trailing spaces. 100
Warnings Line has trailing spaces. 103
Errors Redundant 'public' modifier. 106
Errors Redundant 'public' modifier. 112
Warnings Line has trailing spaces. 113
Warnings Line has trailing spaces. 116
Errors Redundant 'public' modifier. 119

com/atlassian/gadgets/dashboard/internal/DashboardWebItemFinder.java

Violation Message Line
Errors Missing a Javadoc comment. 11
Warnings Line has trailing spaces. 13
Infos Method 'findDashboardMenuItems' is not designed for extension - needs to be abstract, final or empty. 21
Infos Method 'findDashboardToolsMenuItems' is not designed for extension - needs to be abstract, final or empty. 27
Warnings Line is longer than 120 characters. 35

com/atlassian/gadgets/dashboard/internal/Gadget.java

Violation Message Line
Errors Missing a Javadoc comment. 9
Errors First sentence should end with a period. 15
Warnings Line has trailing spaces. 20
Warnings Line has trailing spaces. 26
Warnings Line has trailing spaces. 28
Warnings Line has trailing spaces. 30
Warnings Line has trailing spaces. 37
Errors First sentence should end with a period. 42
Warnings Line is longer than 120 characters. 43
Warnings Line is longer than 120 characters. 44
Errors First sentence should end with a period. 48

com/atlassian/gadgets/dashboard/internal/GadgetFactory.java

Violation Message Line
Errors Missing a Javadoc comment. 8
Warnings Line is longer than 120 characters. 10
Warnings Line is longer than 120 characters. 11

com/atlassian/gadgets/dashboard/internal/GadgetLayoutException.java

Violation Message Line
Warnings Line has trailing spaces. 4

com/atlassian/gadgets/dashboard/internal/GadgetNotLoadedException.java

Violation Message Line
Errors Missing a Javadoc comment. 5
Warnings Line is longer than 120 characters. 11
Infos Method 'getGadgetId' is not designed for extension - needs to be abstract, final or empty. 15

com/atlassian/gadgets/dashboard/internal/InconsistentDashboardStateException.java

Violation Message Line
Errors Missing a Javadoc comment. 3

com/atlassian/gadgets/dashboard/internal/StateConverter.java

Violation Message Line
Errors First sentence should end with a period. 7
Errors First sentence should end with a period. 12
Errors First sentence should end with a period. 20

com/atlassian/gadgets/dashboard/internal/Tab.java

Violation Message Line
Warnings Line is longer than 120 characters. 11

com/atlassian/gadgets/dashboard/internal/UserPref.java

Violation Message Line
Errors First sentence should end with a period. 7
Errors Redundant 'public' modifier. 48

com/atlassian/gadgets/dashboard/internal/diagnostics/Diagnostics.java

Violation Message Line
Errors Missing package-info.java file. 0
Errors Missing a Javadoc comment. 13
Errors Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 15
Infos Method 'check' is not designed for extension - needs to be abstract, final or empty. 24
Errors '80' is a magic number. 43
Errors '443' is a magic number. 47

com/atlassian/gadgets/dashboard/internal/diagnostics/DiagnosticsException.java

Violation Message Line
Errors Missing a Javadoc comment. 6
Infos Method 'getStackTraceAsString' is not designed for extension - needs to be abstract, final or empty. 18

com/atlassian/gadgets/dashboard/internal/diagnostics/DiagnosticsServlet.java

Violation Message Line
Errors Missing a Javadoc comment. 21
Errors Class Fan-Out Complexity is 15 (max allowed is 10). 21
Errors Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 23
Infos Method 'doGet' is not designed for extension - needs to be abstract, final or empty. 39
Infos Method 'doPost' is not designed for extension - needs to be abstract, final or empty. 46
Warnings Line is longer than 120 characters. 110
Errors 'renderer' hides a field. 129
Warnings Line is longer than 120 characters. 132
Warnings Line is longer than 120 characters. 135
Errors 'renderer' hides a field. 135

com/atlassian/gadgets/dashboard/internal/diagnostics/UrlHostnameMismatchException.java

Violation Message Line
Errors Missing a Javadoc comment. 3
Infos Method 'getExpectedHostname' is not designed for extension - needs to be abstract, final or empty. 17
Infos Method 'getDetectedHostname' is not designed for extension - needs to be abstract, final or empty. 22

com/atlassian/gadgets/dashboard/internal/diagnostics/UrlPortMismatchException.java

Violation Message Line
Errors Missing a Javadoc comment. 3
Infos Method 'getExpectedPort' is not designed for extension - needs to be abstract, final or empty. 15
Infos Method 'getDetectedPort' is not designed for extension - needs to be abstract, final or empty. 20

com/atlassian/gadgets/dashboard/internal/diagnostics/UrlSchemeMismatchException.java

Violation Message Line
Errors Missing a Javadoc comment. 3
Infos Method 'getExpectedScheme' is not designed for extension - needs to be abstract, final or empty. 17
Infos Method 'getDetectedScheme' is not designed for extension - needs to be abstract, final or empty. 22

com/atlassian/gadgets/dashboard/internal/impl/Column.java

Violation Message Line
Errors Missing package-info.java file. 0
Errors Missing a Javadoc comment. 12
Warnings Line has trailing spaces. 20
Warnings Line has trailing spaces. 30
Errors ';' is followed by whitespace. 45
Errors 'gadgets' hides a field. 57

com/atlassian/gadgets/dashboard/internal/impl/DashboardImpl.java

Violation Message Line
Errors Wrong order for 'com.google.common.base.Preconditions.checkNotNull' import. 40
Errors Class Data Abstraction Coupling is 14 (max allowed is 7) classes [AddGadgetChange, ChangeColorTo, GadgetColorChange, GadgetLayoutException, GadgetNotFoundException, GadgetStateConverter, HashMap, InternalGadgetNotFoundException, RemoveGadgetChange, RemoveGadgetFunction, UpdateGadgetUserPrefsChange, UpdateLayoutChange, UpdatePrefValues, WithIdPredicate]. 49
Errors Class Fan-Out Complexity is 34 (max allowed is 10). 49
Infos Method 'getId' is not designed for extension - needs to be abstract, final or empty. 64
Infos Method 'getTitle' is not designed for extension - needs to be abstract, final or empty. 69
Infos Method 'getLayout' is not designed for extension - needs to be abstract, final or empty. 74
Warnings Line has trailing spaces. 78
Infos Method 'getGadgetsInColumn' is not designed for extension - needs to be abstract, final or empty. 79
Infos Method 'appendGadget' is not designed for extension - needs to be abstract, final or empty. 88
Infos Method 'appendGadget' is not designed for extension - needs to be abstract, final or empty. 93
Warnings Line is longer than 120 characters. 96
Infos Method 'addGadget' is not designed for extension - needs to be abstract, final or empty. 99
Infos Method 'addGadget' is not designed for extension - needs to be abstract, final or empty. 104
Infos Method 'changeLayout' is not designed for extension - needs to be abstract, final or empty. 110
Infos Method 'rearrangeGadgets' is not designed for extension - needs to be abstract, final or empty. 122
Infos Method 'changeGadgetColor' is not designed for extension - needs to be abstract, final or empty. 133
Infos Method 'updateGadgetUserPrefs' is not designed for extension - needs to be abstract, final or empty. 151
Infos Method 'removeGadget' is not designed for extension - needs to be abstract, final or empty. 169
Infos Method 'getState' is not designed for extension - needs to be abstract, final or empty. 177
Infos Method 'findGadget' is not designed for extension - needs to be abstract, final or empty. 182
Errors 'if' is not followed by whitespace. 188
Infos Method 'getChanges' is not designed for extension - needs to be abstract, final or empty. 197
Infos Method 'clearChanges' is not designed for extension - needs to be abstract, final or empty. 202
Warnings Line is longer than 120 characters. 259
Warnings Line is longer than 120 characters. 264
Errors '{' is not followed by whitespace. 295
Errors '}' is not preceded with whitespace. 295
Warnings Line is longer than 120 characters. 312
Infos Method 'getNumberOfGadgets' is not designed for extension - needs to be abstract, final or empty. 398
Warnings Line is longer than 120 characters. 420
Infos Method 'assertGadgetLayoutIsValid' is not designed for extension - needs to be abstract, final or empty. 431
Errors '+' should be on a new line. 435

com/atlassian/gadgets/dashboard/internal/impl/DashboardRepositoryImpl.java

Violation Message Line
Warnings Line has trailing spaces. 35
Warnings Line is longer than 120 characters. 36
Infos Method 'get' is not designed for extension - needs to be abstract, final or empty. 36
Infos Method 'save' is not designed for extension - needs to be abstract, final or empty. 41
Warnings Line is longer than 120 characters. 46
Infos Method 'findDashboardByGadgetId' is not designed for extension - needs to be abstract, final or empty. 51

com/atlassian/gadgets/dashboard/internal/impl/DashboardServiceImpl.java

Violation Message Line
Warnings Line is longer than 120 characters. 26
Infos Method 'get' is not designed for extension - needs to be abstract, final or empty. 32
Infos Method 'save' is not designed for extension - needs to be abstract, final or empty. 41

com/atlassian/gadgets/dashboard/internal/impl/DashboardUrlBuilderImpl.java

Violation Message Line
Errors Missing a Javadoc comment. 12
Infos Method 'getBaseUrl' is not designed for extension - needs to be abstract, final or empty. 23
Infos Method 'buildDashboardUrl' is not designed for extension - needs to be abstract, final or empty. 29
Infos Method 'buildDashboardLayoutUrl' is not designed for extension - needs to be abstract, final or empty. 34
Warnings Line has trailing spaces. 38
Infos Method 'buildGadgetUrl' is not designed for extension - needs to be abstract, final or empty. 39
Infos Method 'buildGadgetColorUrl' is not designed for extension - needs to be abstract, final or empty. 44
Infos Method 'buildGadgetUserPrefsUrl' is not designed for extension - needs to be abstract, final or empty. 49
Infos Method 'buildErrorGadgetUrl' is not designed for extension - needs to be abstract, final or empty. 54
Warnings Line is longer than 120 characters. 56
Infos Method 'buildDashboardResourceUrl' is not designed for extension - needs to be abstract, final or empty. 59
Infos Method 'buildDashboardDirectoryResourceUrl' is not designed for extension - needs to be abstract, final or empty. 65
Infos Method 'buildDashboardDirectoryBaseUrl' is not designed for extension - needs to be abstract, final or empty. 70
Infos Method 'buildDashboardDirectoryUrl' is not designed for extension - needs to be abstract, final or empty. 75
Warnings Line has trailing spaces. 79
Infos Method 'buildSubscribedGadgetFeedsUrl' is not designed for extension - needs to be abstract, final or empty. 80
Infos Method 'buildDashboardDiagnosticsRelativeUrl' is not designed for extension - needs to be abstract, final or empty. 85
Warnings Line is longer than 120 characters. 87
Infos Method 'buildSecurityTokensUrl' is not designed for extension - needs to be abstract, final or empty. 90

com/atlassian/gadgets/dashboard/internal/impl/GadgetFactoryImpl.java

Violation Message Line
Errors Class Fan-Out Complexity is 14 (max allowed is 10). 22
Warnings Line is longer than 120 characters. 48
Warnings Line is longer than 120 characters. 50
Infos Method 'createGadget' is not designed for extension - needs to be abstract, final or empty. 50
Warnings Line is longer than 120 characters. 74
Infos Method 'createGadget' is not designed for extension - needs to be abstract, final or empty. 74
Errors 'if' is not followed by whitespace. 86
Warnings Line is longer than 120 characters. 88

com/atlassian/gadgets/dashboard/internal/impl/GadgetImpl.java

Violation Message Line
Errors Wrong order for 'com.atlassian.gadgets.GadgetState.gadget' import. 23
Errors 'com.google.common.collect.Iterables.any' should be separated from previous imports. 24
Errors Class Fan-Out Complexity is 12 (max allowed is 10). 30
Warnings Line has trailing spaces. 35
Warnings Line has trailing spaces. 79
Warnings Line has trailing spaces. 118
Errors Static variable definition in wrong order. 131
Errors Name 'isNotHidden' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 131
Errors Missing a Javadoc comment. 133
Errors 'userPrefs' hides a field. 159

com/atlassian/gadgets/dashboard/internal/impl/StateConverterImpl.java

Violation Message Line
Errors Missing a Javadoc comment. 11
Infos Method 'convertStateToDashboard' is not designed for extension - needs to be abstract, final or empty. 20
Infos Method 'convertStateToGadget' is not designed for extension - needs to be abstract, final or empty. 25

com/atlassian/gadgets/dashboard/internal/impl/TabImpl.java

Violation Message Line
Errors Missing a Javadoc comment. 9
Infos Method 'getDashboardId' is not designed for extension - needs to be abstract, final or empty. 20
Infos Method 'getTitle' is not designed for extension - needs to be abstract, final or empty. 25
Infos Method 'getTabUri' is not designed for extension - needs to be abstract, final or empty. 30
Infos Method 'isWritable' is not designed for extension - needs to be abstract, final or empty. 35

com/atlassian/gadgets/dashboard/internal/impl/TransactionalDashboardStateStoreImpl.java

Violation Message Line
Errors First sentence should end with a period. 15
Infos Method 'retrieve' is not designed for extension - needs to be abstract, final or empty. 35
Errors Missing a Javadoc comment. 40
Warnings Line is longer than 120 characters. 47
Infos Method 'update' is not designed for extension - needs to be abstract, final or empty. 47
Errors Missing a Javadoc comment. 53
Infos Method 'remove' is not designed for extension - needs to be abstract, final or empty. 60
Errors Missing a Javadoc comment. 65
Infos Method 'findDashboardWithGadget' is not designed for extension - needs to be abstract, final or empty. 73
Errors method def modifier at indentation level 11 not at correct indentation, 12 78
Errors Missing a Javadoc comment. 78
Errors method def lcurly at indentation level 11 not at correct indentation, 12 79
Errors method def child at indentation level 15 not at correct indentation, 16 80
Errors method def rcurly at indentation level 11 not at correct indentation, 12 81

com/atlassian/gadgets/dashboard/internal/impl/UserPrefImpl.java

Violation Message Line
Errors Missing a Javadoc comment. 13
Warnings Line is longer than 120 characters. 21
Errors ')' is preceded with whitespace. 21
Errors '19' is a magic number. 62
Errors '35' is a magic number. 62
Errors 'if' construct must use '{}'s. 74
Errors 'if' construct must use '{}'s. 75
Errors 'if' construct must use '{}'s. 76

com/atlassian/gadgets/dashboard/internal/rest/AddGadgetHandlerImpl.java

Violation Message Line
Errors Class Fan-Out Complexity is 23 (max allowed is 10). 36
Infos Method 'addGadget' is not designed for extension - needs to be abstract, final or empty. 71
Infos Method 'addGadget' is not designed for extension - needs to be abstract, final or empty. 78
Warnings Line is longer than 120 characters. 93
Warnings Line is longer than 120 characters. 121
Infos Method 'moveGadget' is not designed for extension - needs to be abstract, final or empty. 121
Warnings Line is longer than 120 characters. 122
Errors Missing a Javadoc comment. 128
Warnings Line is longer than 120 characters. 135
Warnings Line has trailing spaces. 145
Warnings Line is longer than 120 characters. 155
Warnings Line is longer than 120 characters. 157
Warnings Line is longer than 120 characters. 175
Errors 'if' is not followed by whitespace. 189
Errors 'if' is not followed by whitespace. 191

com/atlassian/gadgets/dashboard/internal/rest/ChangeGadgetColorHandlerImpl.java

Violation Message Line
Infos Method 'setGadgetColor' is not designed for extension - needs to be abstract, final or empty. 39

com/atlassian/gadgets/dashboard/internal/rest/ChangeLayoutHandlerImpl.java

Violation Message Line
Errors Class Fan-Out Complexity is 20 (max allowed is 10). 33
Infos Method 'changeLayout' is not designed for extension - needs to be abstract, final or empty. 46
Warnings Line has trailing spaces. 90
Errors method def throws at indentation level 12 not at correct indentation, 8 102
Errors method def throws at indentation level 12 not at correct indentation, 8 134
Warnings Line is longer than 120 characters. 137

com/atlassian/gadgets/dashboard/internal/rest/DashboardResource.java

Violation Message Line
Errors Class Fan-Out Complexity is 19 (max allowed is 10). 39
Infos Method 'getDashboard' is not designed for extension - needs to be abstract, final or empty. 79
Errors '}' is not preceded with whitespace. 81
Warnings Line is longer than 120 characters. 89
Infos Method 'getNumGadgets' is not designed for extension - needs to be abstract, final or empty. 99
Warnings Line is longer than 120 characters. 103
Warnings Line is longer than 120 characters. 109
Infos Method 'addGadget' is not designed for extension - needs to be abstract, final or empty. 130
Warnings Line is longer than 120 characters. 153
Infos Method 'changeLayoutViaPOST' is not designed for extension - needs to be abstract, final or empty. 188
Infos Method 'changeLayoutViaPUT' is not designed for extension - needs to be abstract, final or empty. 207
Errors '+' should be on a new line. 223

com/atlassian/gadgets/dashboard/internal/rest/DeleteGadgetHandlerImpl.java

Violation Message Line
Infos Method 'deleteGadget' is not designed for extension - needs to be abstract, final or empty. 39

com/atlassian/gadgets/dashboard/internal/rest/GadgetResource.java

Violation Message Line
Errors Class Fan-Out Complexity is 26 (max allowed is 10). 48
Errors More than 7 parameters. 77
Infos Method 'getRenderedGadget' is not designed for extension - needs to be abstract, final or empty. 106
Errors NPath Complexity is 28 (max allowed is 20). 106
Errors ',' is not followed by whitespace. 108
Errors '}' is not preceded with whitespace. 108
Errors 'if' is not followed by whitespace. 115
Warnings Line has trailing spaces. 119
Errors '{' should be on a new line. 124
Errors 'if' is not followed by whitespace. 142
Infos Method 'deleteOrMoveGadgetViaPost' is not designed for extension - needs to be abstract, final or empty. 165
Errors if child at indentation level 16 not at correct indentation, 12 179
Errors Line contains a tab character. 179
Errors if child at indentation level 16 not at correct indentation, 12 180
Errors Line contains a tab character. 180
Infos Method 'deleteGadget' is not designed for extension - needs to be abstract, final or empty. 197
Infos Method 'moveGadget' is not designed for extension - needs to be abstract, final or empty. 223
Warnings Line is longer than 120 characters. 241
Warnings Line has trailing spaces. 260
Infos Method 'changeGadgetColorViaPOST' is not designed for extension - needs to be abstract, final or empty. 271
Infos Method 'changeGadgetColor' is not designed for extension - needs to be abstract, final or empty. 300
Errors '+' should be on a new line. 341
Infos Method 'updateUserPrefsViaPOST' is not designed for extension - needs to be abstract, final or empty. 365
Infos Method 'updateUserPrefsViaPUT' is not designed for extension - needs to be abstract, final or empty. 400
Errors '+' should be on a new line. 431

com/atlassian/gadgets/dashboard/internal/rest/UpdateGadgetUserPrefsHandlerImpl.java

Violation Message Line
Errors Class Fan-Out Complexity is 11 (max allowed is 10). 23
Errors Static variable definition in wrong order. 27
Infos Method 'updateUserPrefs' is not designed for extension - needs to be abstract, final or empty. 44

com/atlassian/gadgets/dashboard/internal/rest/representations/DashboardRepresentation.java

Violation Message Line
Errors Missing package-info.java file. 0
Errors Missing a Javadoc comment. 34
Errors Variable 'writable' explicitly initialized to 'false' (default value for its type). 40
Infos Method 'writable' is not designed for extension - needs to be abstract, final or empty. 49
Errors 'writable' hides a field. 49
Infos Method 'gadgets' is not designed for extension - needs to be abstract, final or empty. 55
Errors 'gadgets' hides a field. 55
Infos Method 'build' is not designed for extension - needs to be abstract, final or empty. 63

com/atlassian/gadgets/dashboard/internal/rest/representations/GadgetRepresentation.java

Violation Message Line
Errors Comment matches to-do format 'TODO:'. 22
Errors '}' is not preceded with whitespace. 63
Errors NPath Complexity is 256 (max allowed is 20). 91
Infos Method 'getHasNonHiddenUserPrefs' is not designed for extension - needs to be abstract, final or empty. 112
Infos Method 'isLoaded' is not designed for extension - needs to be abstract, final or empty. 117
Infos Method 'getColor' is not designed for extension - needs to be abstract, final or empty. 122
Infos Method 'getGadgetSpecUrl' is not designed for extension - needs to be abstract, final or empty. 127
Infos Method 'getHeight' is not designed for extension - needs to be abstract, final or empty. 132
Infos Method 'getId' is not designed for extension - needs to be abstract, final or empty. 137
Infos Method 'isMaximizable' is not designed for extension - needs to be abstract, final or empty. 142
Infos Method 'getTitle' is not designed for extension - needs to be abstract, final or empty. 147
Infos Method 'getTitleUrl' is not designed for extension - needs to be abstract, final or empty. 152
Infos Method 'getUserPrefs' is not designed for extension - needs to be abstract, final or empty. 157
Infos Method 'getWidth' is not designed for extension - needs to be abstract, final or empty. 162
Infos Method 'getRenderedGadgetUrl' is not designed for extension - needs to be abstract, final or empty. 167
Infos Method 'getColorUrl' is not designed for extension - needs to be abstract, final or empty. 172
Infos Method 'getGadgetUrl' is not designed for extension - needs to be abstract, final or empty. 177
Infos Method 'hasNonHiddenUserPrefs' is not designed for extension - needs to be abstract, final or empty. 182
Infos Method 'getColumn' is not designed for extension - needs to be abstract, final or empty. 187
Infos Method 'getErrorMessage' is not designed for extension - needs to be abstract, final or empty. 192
Errors 'static' modifier out of order with the JLS suggestions. 200
Warnings Line is longer than 120 characters. 217
Errors '(' is followed by whitespace. 217
Errors ')' is preceded with whitespace. 217
Errors 'if' is not followed by whitespace. 219

com/atlassian/gadgets/dashboard/internal/rest/representations/RepresentationFactory.java

Violation Message Line
Warnings Line is longer than 120 characters. 23
Errors First sentence should end with a period. 25
Warnings Line is longer than 120 characters. 35

com/atlassian/gadgets/dashboard/internal/rest/representations/RepresentationFactoryImpl.java

Violation Message Line
Errors Missing a Javadoc comment. 14
Errors Class Fan-Out Complexity is 13 (max allowed is 10). 14
Warnings Line is longer than 120 characters. 19
Warnings Line is longer than 120 characters. 25
Infos Method 'createDashboardRepresentation' is not designed for extension - needs to be abstract, final or empty. 25
Warnings Line is longer than 120 characters. 32
Warnings Line is longer than 120 characters. 39
Infos Method 'createGadgetRepresentation' is not designed for extension - needs to be abstract, final or empty. 39
Warnings Line is longer than 120 characters. 42

com/atlassian/gadgets/dashboard/internal/rest/representations/UserPrefRepresentation.java

Violation Message Line
Warnings Line is longer than 120 characters. 45
Warnings Line has trailing spaces. 47
Warnings Line is longer than 120 characters. 50
Errors Constructor definition in wrong order. 57
Warnings Line has trailing spaces. 96
Errors Missing a Javadoc comment. 98
Infos Method 'getValue' is not designed for extension - needs to be abstract, final or empty. 124
Infos Method 'getLabel' is not designed for extension - needs to be abstract, final or empty. 129
Infos Method 'isSelected' is not designed for extension - needs to be abstract, final or empty. 134

com/atlassian/gadgets/dashboard/internal/rest/representations/UserPrefsRepresentation.java

Violation Message Line
Errors Wrong order for 'com.atlassian.plugin.util.Assertions.notNull' import. 14
Errors 'com.google.common.collect.Iterables.transform' should be separated from previous imports. 15
Errors First sentence should end with a period. 18
Errors Missing a Javadoc comment. 59
Warnings Line has trailing spaces. 74

com/atlassian/gadgets/dashboard/internal/util/JavaScript.java

Violation Message Line
Errors Missing package-info.java file. 0
Errors Utility classes should not have a public or default constructor. 13
Warnings Line has trailing spaces. 24
Warnings Line has trailing spaces. 28
Warnings Line has trailing spaces. 33
Warnings Line has trailing spaces. 36
Warnings Line has trailing spaces. 41
Warnings Line has trailing spaces. 43
Warnings Line has trailing spaces. 60
Warnings Line has trailing spaces. 64
Warnings Line has trailing spaces. 85
Warnings Line has trailing spaces. 116
Errors Cyclomatic Complexity is 20 (max allowed is 10). 126
Errors NCSS for this method is 71 (max allowed is 50). 126
Errors NPath Complexity is 40 (max allowed is 20). 126
Errors '0xfff' is a magic number. 143
Errors '0xff' is a magic number. 147
Errors '0x7f' is a magic number. 151
Errors '32' is a magic number. 155
Errors '0xf' is a magic number. 180
Warnings Line has trailing spaces. 230

com/atlassian/gadgets/dashboard/internal/velocity/DashboardEmbedder.java

Violation Message Line
Errors Missing package-info.java file. 0
Errors Wrong order for 'com.google.common.base.Preconditions.checkNotNull' import. 22
Errors Class Fan-Out Complexity is 15 (max allowed is 10). 27
Warnings Line has trailing spaces. 30
Warnings Line has trailing spaces. 35
Infos Method 'json' is not designed for extension - needs to be abstract, final or empty. 36
Warnings Line is longer than 120 characters. 39
Warnings Line has trailing spaces. 146
Warnings Line has trailing spaces. 155
Warnings Line has trailing spaces. 160
Warnings Line has trailing spaces. 169
Warnings Line has trailing spaces. 178
Warnings Line has trailing spaces. 187
Warnings Line has trailing spaces. 196
Warnings Line has trailing spaces. 199
Warnings Line has trailing spaces. 201
Errors '(' is preceded with whitespace. 203
Warnings Line has trailing spaces. 215
Warnings Line has trailing spaces. 219
Warnings Line has trailing spaces. 224

com/atlassian/gadgets/dashboard/internal/velocity/DashboardView.java

Violation Message Line
Errors 'org.apache.commons.io.IOUtils.closeQuietly' should be separated from previous imports. 20
Errors Missing a Javadoc comment. 22
Errors Class Fan-Out Complexity is 12 (max allowed is 10). 22
Errors More than 7 parameters. 36
Errors 'static' modifier out of order with the JLS suggestions. 84
Warnings Line has trailing spaces. 88
Errors 'catch' is not followed by whitespace. 97
Warnings Line has trailing spaces. 116

com/atlassian/gadgets/dashboard/internal/velocity/VelocityViewFactory.java

Violation Message Line
Errors Missing a Javadoc comment. 23
Errors Class Fan-Out Complexity is 15 (max allowed is 10). 23
Warnings Line is longer than 120 characters. 45
Infos Method 'createDashboardView' is not designed for extension - needs to be abstract, final or empty. 45