FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 1.3.8

Threshold is Low

Effort is Default

Summary

Classes Bugs Errors Missing Classes
318 16 0 0

com.atlassian.gadgets.dashboard.internal.DashboardTemplateRenderer

Bug Category Details Line Priority
Method com.atlassian.gadgets.dashboard.internal.DashboardTemplateRenderer.createContext(Map, Writer) needlessly instantiates a class that only supplies static methods BAD_PRACTICE ISC_INSTANTIATE_STATIC_CLASS 56 Low

com.atlassian.gadgets.dashboard.internal.diagnostics.DiagnosticsServlet

Bug Category Details Line Priority
Class com.atlassian.gadgets.dashboard.internal.diagnostics.DiagnosticsServlet defines non-transient non-serializable instance field diagnostics BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class com.atlassian.gadgets.dashboard.internal.diagnostics.DiagnosticsServlet defines non-transient non-serializable instance field renderer BAD_PRACTICE SE_BAD_FIELD Not available Low
Class com.atlassian.gadgets.dashboard.internal.diagnostics.DiagnosticsServlet defines non-transient non-serializable instance field userManager BAD_PRACTICE SE_BAD_FIELD Not available Low
com.atlassian.gadgets.dashboard.internal.diagnostics.DiagnosticsServlet is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID 20-111 Low

com.atlassian.gadgets.dashboard.internal.impl.DashboardImpl$RemoveGadgetFunction

Bug Category Details Line Priority
column must be nonnull but is marked as nullable STYLE NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE 338 High

com.atlassian.gadgets.dashboard.internal.impl.DashboardImpl$WithIdPredicate

Bug Category Details Line Priority
gadgetState must be nonnull but is marked as nullable STYLE NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE 358 High

com.atlassian.gadgets.dashboard.internal.rest.ChangeLayoutHandlerImpl

Bug Category Details Line Priority
Load of known null value in com.atlassian.gadgets.dashboard.internal.rest.ChangeLayoutHandlerImpl.persistLayout(Dashboard, JSONObject) STYLE NP_LOAD_OF_KNOWN_NULL_VALUE 116 Low

com.atlassian.gadgets.dashboard.internal.rest.ChangeLayoutHandlerImpl$ParseGadgetLayoutException

Bug Category Details Line Priority
Should com.atlassian.gadgets.dashboard.internal.rest.ChangeLayoutHandlerImpl$ParseGadgetLayoutException be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 174-176 Medium

com.atlassian.gadgets.dashboard.internal.rest.GadgetResource

Bug Category Details Line Priority
Load of known null value in com.atlassian.gadgets.dashboard.internal.rest.GadgetResource.changeGadgetColor(DashboardId, GadgetId, HttpServletRequest, String) STYLE NP_LOAD_OF_KNOWN_NULL_VALUE 335 Low

com.atlassian.gadgets.dashboard.internal.rest.UpdateGadgetUserPrefsHandlerImpl

Bug Category Details Line Priority
Method com.atlassian.gadgets.dashboard.internal.rest.UpdateGadgetUserPrefsHandlerImpl.adaptParameterMapToUserPrefValues(Map) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 83 Medium

com.atlassian.gadgets.dashboard.internal.rest.representations.UserPrefRepresentation

Bug Category Details Line Priority
Use of non-localized String.toUpperCase() or String.toLowerCase I18N DM_CONVERT_CASE 38 Low

com.atlassian.gadgets.dashboard.internal.rest.representations.UserPrefsRepresentation$1

Bug Category Details Line Priority
userPref must be nonnull but is marked as nullable STYLE NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE 60 Medium
The class com.atlassian.gadgets.dashboard.internal.rest.representations.UserPrefsRepresentation$1 could be refactored into a named _static_ inner class PERFORMANCE SIC_INNER_SHOULD_BE_STATIC_ANON 57-60 Low

com.atlassian.gadgets.dashboard.internal.util.JavaScript

Bug Category Details Line Priority
Use of non-localized String.toUpperCase() or String.toLowerCase I18N DM_CONVERT_CASE 237 Low

com.atlassian.gadgets.dashboard.internal.velocity.DashboardView$HelpLinkResolver

Bug Category Details Line Priority
Method new com.atlassian.gadgets.dashboard.internal.velocity.DashboardView$HelpLinkResolver() may fail to clean up stream or resource of type java.io.InputStream EXPERIMENTAL OBL_UNSATISFIED_OBLIGATION 91 Medium