The following document contains the results of Checkstyle. 
| Files | Infos  |
Warnings  |
Errors  |
|---|---|---|---|
| 46 | 103 | 96 | 175 |
| Rules | Violations | Severity |
|---|---|---|
| JavadocPackage | 4 | Error |
| Translation | 0 | Error |
| FileLength | 0 | Error |
FileTabCharacter
|
2 | Error |
RegexpSingleline
|
48 | Warning |
| AnnotationUseStyle | 0 | Error |
| MissingDeprecated | 0 | Error |
MissingOverride
|
0 | Error |
| PackageAnnotation | 0 | Error |
JavadocMethod
|
7 | Error |
JavadocType
|
19 | Error |
JavadocVariable
|
0 | Error |
JavadocStyle
|
16 | Error |
| ConstantName | 1 | Error |
| LocalFinalVariableName | 0 | Error |
| LocalVariableName | 0 | Error |
| MemberName | 0 | Error |
| MethodName | 0 | Error |
| PackageName | 0 | Error |
| ParameterName | 0 | Error |
| StaticVariableName | 0 | Error |
| TypeName | 0 | Error |
| AvoidStarImport | 0 | Error |
| IllegalImport | 0 | Error |
ImportOrder
|
53 | Error |
| RedundantImport | 0 | Error |
| UnusedImports | 0 | Error |
LineLength
|
48 | Warning |
| MethodLength | 0 | Error |
| ParameterNumber | 2 | Error |
| EmptyForIteratorPad | 1 | Error |
| MethodParamPad | 1 | Error |
| NoWhitespaceAfter | 0 | Error |
| NoWhitespaceBefore | 0 | Error |
| OperatorWrap | 4 | Error |
| ParenPad | 3 | Error |
| TypecastParenPad | 0 | Error |
| WhitespaceAfter | 2 | Error |
| WhitespaceAround | 13 | Error |
| ModifierOrder | 2 | Error |
| RedundantModifier | 6 | Error |
| AvoidNestedBlocks | 0 | Error |
| EmptyBlock | 0 | Error |
LeftCurly
|
2 | Error |
| NeedBraces | 3 | Error |
RightCurly
|
0 | Error |
| DeclarationOrder | 3 | Error |
| DefaultComesLast | 0 | Error |
| DoubleCheckedLocking | 0 | Error |
| EmptyStatement | 0 | Error |
| EqualsHashCode | 0 | Error |
| ExplicitInitialization | 1 | Error |
| FallThrough | 0 | Error |
HiddenField
|
4 | Error |
| IllegalInstantiation | 0 | Error |
| InnerAssignment | 0 | Error |
| MagicNumber | 2 | Error |
| MissingSwitchDefault | 0 | Error |
| ParameterAssignment | 0 | Error |
RedundantThrows
|
0 | Error |
| SimplifyBooleanExpression | 0 | Error |
| SimplifyBooleanReturn | 0 | Error |
| StringLiteralEquality | 0 | Error |
| DesignForExtension | 103 | Info |
| FinalClass | 0 | Error |
| HideUtilityClassConstructor | 0 | Error |
| InterfaceIsType | 0 | Error |
| VisibilityModifier | 0 | Error |
| BooleanExpressionComplexity | 0 | Error |
| ClassDataAbstractionCoupling | 1 | Error |
ClassFanOutComplexity
|
12 | Error |
| CyclomaticComplexity | 0 | Error |
NPathComplexity
|
2 | Error |
| JavaNCSS | 0 | Error |
| ArrayTypeStyle | 0 | Error |
| Indentation | 8 | Error |
| TodoComment | 1 | Error |
| UpperEll | 0 | Error |
| Violation | Message | Line |
|---|---|---|
|
Missing a Javadoc comment. | 7 |
|
Method 'getId' is not designed for extension - needs to be abstract, final or empty. | 18 |
|
Method 'getTitle' is not designed for extension - needs to be abstract, final or empty. | 23 |
|
Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 28 |
| Violation | Message | Line |
|---|---|---|
|
Missing a Javadoc comment. | 16 |
|
Class Fan-Out Complexity is 14 (max allowed is 10). | 16 |
|
Line has trailing spaces. | 21 |
|
Line has trailing spaces. | 23 |
|
Line has trailing spaces. | 25 |
|
First sentence should end with a period. | 43 |
|
Redundant 'public' modifier. | 46 |
|
First sentence should end with a period. | 57 |
|
First sentence should end with a period. | 65 |
|
First sentence should end with a period. | 72 |
|
Line has trailing spaces. | 80 |
|
Line has trailing spaces. | 87 |
|
Line has trailing spaces. | 95 |
|
Line has trailing spaces. | 99 |
|
Line has trailing spaces. | 105 |
|
First sentence should end with a period. | 113 |
|
Line is longer than 120 characters. | 121 |
|
',' is not followed by whitespace. | 121 |
| Violation | Message | Line |
|---|---|---|
|
Missing package-info.java file. | 0 |
|
Wrong order for 'com.atlassian.gadgets.GadgetRequestContext' import. | 5 |
|
Wrong order for 'com.atlassian.gadgets.GadgetId' import. | 6 |
|
Missing a Javadoc comment. | 8 |
|
'(' is preceded with whitespace. | 11 |
| Violation | Message | Line |
|---|---|---|
|
Missing a Javadoc comment. | 14 |
|
Line has trailing spaces. | 28 |
|
Method 'render' is not designed for extension - needs to be abstract, final or empty. | 29 |
|
Line is longer than 120 characters. | 34 |
|
Method 'render' is not designed for extension - needs to be abstract, final or empty. | 34 |
|
Line has trailing spaces. | 38 |
|
Method 'renderFragment' is not designed for extension - needs to be abstract, final or empty. | 39 |
|
Method 'resolve' is not designed for extension - needs to be abstract, final or empty. | 44 |
| Violation | Message | Line |
|---|---|---|
|
Line has trailing spaces. | 22 |
|
Line has trailing spaces. | 26 |
|
Line has trailing spaces. | 29 |
|
Line has trailing spaces. | 30 |
|
Line has trailing spaces. | 34 |
|
Line has trailing spaces. | 37 |
|
Line has trailing spaces. | 39 |
|
Line has trailing spaces. | 43 |
|
Line has trailing spaces. | 46 |
|
Line has trailing spaces. | 48 |
|
Line has trailing spaces. | 52 |
|
Line has trailing spaces. | 55 |
|
Line has trailing spaces. | 57 |
|
Line has trailing spaces. | 64 |
|
Redundant 'public' modifier. | 76 |
|
Redundant 'public' modifier. | 84 |
|
Redundant 'public' modifier. | 92 |
|
First sentence should end with a period. | 94 |
|
Redundant 'public' modifier. | 99 |
| Violation | Message | Line |
|---|---|---|
|
'com.google.common.collect.ImmutableMap' should be separated from previous imports. | 8 |
|
Missing a Javadoc comment. | 10 |
|
Line has trailing spaces. | 12 |
|
Method 'findDashboardMenuItems' is not designed for extension - needs to be abstract, final or empty. | 20 |
|
Method 'findDashboardToolsMenuItems' is not designed for extension - needs to be abstract, final or empty. | 26 |
|
Line is longer than 120 characters. | 34 |
| Violation | Message | Line |
|---|---|---|
|
Missing a Javadoc comment. | 9 |
|
First sentence should end with a period. | 15 |
|
Line has trailing spaces. | 20 |
|
Line has trailing spaces. | 26 |
|
Line has trailing spaces. | 28 |
|
Line has trailing spaces. | 30 |
|
Line has trailing spaces. | 37 |
|
First sentence should end with a period. | 42 |
|
Line is longer than 120 characters. | 43 |
|
Line is longer than 120 characters. | 44 |
|
First sentence should end with a period. | 48 |
| Violation | Message | Line |
|---|---|---|
|
Wrong order for 'com.atlassian.gadgets.GadgetRequestContext' import. | 5 |
|
Missing a Javadoc comment. | 8 |
|
Line is longer than 120 characters. | 10 |
|
Line is longer than 120 characters. | 11 |
| Violation | Message | Line |
|---|---|---|
|
Line has trailing spaces. | 4 |
| Violation | Message | Line |
|---|---|---|
|
Missing a Javadoc comment. | 5 |
|
Line is longer than 120 characters. | 11 |
|
Method 'getGadgetId' is not designed for extension - needs to be abstract, final or empty. | 15 |
| Violation | Message | Line |
|---|---|---|
|
Missing a Javadoc comment. | 3 |
| Violation | Message | Line |
|---|---|---|
|
Wrong order for 'com.atlassian.gadgets.GadgetRequestContext' import. | 4 |
|
First sentence should end with a period. | 7 |
|
First sentence should end with a period. | 12 |
|
First sentence should end with a period. | 20 |
| Violation | Message | Line |
|---|---|---|
|
Line is longer than 120 characters. | 11 |
| Violation | Message | Line |
|---|---|---|
|
Wrong order for 'java.util.Map' import. | 5 |
|
First sentence should end with a period. | 7 |
|
Redundant 'public' modifier. | 48 |
| Violation | Message | Line |
|---|---|---|
|
Missing a Javadoc comment. | 12 |
|
Line has trailing spaces. | 20 |
|
Line has trailing spaces. | 30 |
|
';' is followed by whitespace. | 45 |
|
'gadgets' hides a field. | 57 |
| Violation | Message | Line |
|---|---|---|
|
Wrong order for 'com.google.common.base.Predicate' import. | 34 |
|
Wrong order for 'com.google.common.collect.ImmutableList' import. | 36 |
|
Wrong order for 'com.google.common.collect.Lists' import. | 41 |
|
'org.apache.commons.lang.StringUtils' should be separated from previous imports. | 42 |
|
Class Data Abstraction Coupling is 14 (max allowed is 7) classes [AddGadgetChange, ChangeColorTo, GadgetColorChange, GadgetLayoutException, GadgetNotFoundException, GadgetStateConverter, HashMap, InternalGadgetNotFoundException, RemoveGadgetChange, RemoveGadgetFunction, UpdateGadgetUserPrefsChange, UpdateLayoutChange, UpdatePrefValues, WithIdPredicate]. | 47 |
|
Class Fan-Out Complexity is 34 (max allowed is 10). | 47 |
|
Method 'getId' is not designed for extension - needs to be abstract, final or empty. | 62 |
|
Method 'getTitle' is not designed for extension - needs to be abstract, final or empty. | 67 |
|
Method 'getLayout' is not designed for extension - needs to be abstract, final or empty. | 72 |
|
Line has trailing spaces. | 76 |
|
Method 'getGadgetsInColumn' is not designed for extension - needs to be abstract, final or empty. | 77 |
|
Method 'appendGadget' is not designed for extension - needs to be abstract, final or empty. | 86 |
|
Method 'appendGadget' is not designed for extension - needs to be abstract, final or empty. | 91 |
|
Line is longer than 120 characters. | 94 |
|
Method 'addGadget' is not designed for extension - needs to be abstract, final or empty. | 97 |
|
Method 'addGadget' is not designed for extension - needs to be abstract, final or empty. | 102 |
|
Method 'changeLayout' is not designed for extension - needs to be abstract, final or empty. | 108 |
|
Method 'rearrangeGadgets' is not designed for extension - needs to be abstract, final or empty. | 120 |
|
Method 'changeGadgetColor' is not designed for extension - needs to be abstract, final or empty. | 131 |
|
Method 'updateGadgetUserPrefs' is not designed for extension - needs to be abstract, final or empty. | 149 |
|
Method 'removeGadget' is not designed for extension - needs to be abstract, final or empty. | 167 |
|
Method 'getState' is not designed for extension - needs to be abstract, final or empty. | 175 |
|
Method 'findGadget' is not designed for extension - needs to be abstract, final or empty. | 180 |
|
'if' is not followed by whitespace. | 186 |
|
Method 'getChanges' is not designed for extension - needs to be abstract, final or empty. | 195 |
|
Method 'clearChanges' is not designed for extension - needs to be abstract, final or empty. | 200 |
|
Line is longer than 120 characters. | 257 |
|
Line is longer than 120 characters. | 262 |
|
'{' is not followed by whitespace. | 293 |
|
'}' is not preceded with whitespace. | 293 |
|
Line is longer than 120 characters. | 310 |
|
Method 'getNumberOfGadgets' is not designed for extension - needs to be abstract, final or empty. | 396 |
|
Line is longer than 120 characters. | 418 |
|
Method 'assertGadgetLayoutIsValid' is not designed for extension - needs to be abstract, final or empty. | 429 |
|
'+' should be on a new line. | 433 |
| Violation | Message | Line |
|---|---|---|
|
Missing package-info.java file. | 0 |
|
Wrong order for 'com.atlassian.gadgets.dashboard.DashboardId' import. | 5 |
|
Wrong order for 'com.atlassian.gadgets.GadgetRequestContext' import. | 13 |
|
Wrong order for 'com.atlassian.gadgets.GadgetId' import. | 14 |
|
Line has trailing spaces. | 35 |
|
Line is longer than 120 characters. | 36 |
|
Method 'get' is not designed for extension - needs to be abstract, final or empty. | 36 |
|
Method 'save' is not designed for extension - needs to be abstract, final or empty. | 41 |
|
Line is longer than 120 characters. | 46 |
|
Method 'findDashboardByGadgetId' is not designed for extension - needs to be abstract, final or empty. | 51 |
| Violation | Message | Line |
|---|---|---|
|
Wrong order for 'java.util.Collections' import. | 10 |
|
Method 'get' is not designed for extension - needs to be abstract, final or empty. | 31 |
|
Method 'save' is not designed for extension - needs to be abstract, final or empty. | 40 |
| Violation | Message | Line |
|---|---|---|
|
Wrong order for 'com.atlassian.plugin.webresource.UrlMode' import. | 9 |
|
Missing a Javadoc comment. | 12 |
|
Method 'getBaseUrl' is not designed for extension - needs to be abstract, final or empty. | 23 |
|
Method 'buildDashboardUrl' is not designed for extension - needs to be abstract, final or empty. | 29 |
|
Method 'buildDashboardLayoutUrl' is not designed for extension - needs to be abstract, final or empty. | 34 |
|
Line has trailing spaces. | 38 |
|
Method 'buildGadgetUrl' is not designed for extension - needs to be abstract, final or empty. | 39 |
|
Method 'buildGadgetColorUrl' is not designed for extension - needs to be abstract, final or empty. | 44 |
|
Method 'buildGadgetUserPrefsUrl' is not designed for extension - needs to be abstract, final or empty. | 49 |
|
Method 'buildErrorGadgetUrl' is not designed for extension - needs to be abstract, final or empty. | 54 |
|
Line is longer than 120 characters. | 56 |
|
Method 'buildDashboardResourceUrl' is not designed for extension - needs to be abstract, final or empty. | 59 |
|
Method 'buildDashboardDirectoryResourceUrl' is not designed for extension - needs to be abstract, final or empty. | 65 |
|
Method 'buildDashboardDirectoryBaseUrl' is not designed for extension - needs to be abstract, final or empty. | 70 |
|
Method 'buildDashboardDirectoryUrl' is not designed for extension - needs to be abstract, final or empty. | 75 |
|
'{' is not preceded with whitespace. | 75 |
|
'{' should be on a new line. | 75 |
| Violation | Message | Line |
|---|---|---|
|
Wrong order for 'java.io.StringWriter' import. | 5 |
|
Wrong order for 'java.io.PrintWriter' import. | 6 |
|
Wrong order for 'com.atlassian.gadgets.GadgetRequestContext' import. | 10 |
|
Class Fan-Out Complexity is 13 (max allowed is 10). | 21 |
|
Line is longer than 120 characters. | 45 |
|
Line is longer than 120 characters. | 47 |
|
Method 'createGadget' is not designed for extension - needs to be abstract, final or empty. | 47 |
|
Line is longer than 120 characters. | 71 |
|
Method 'createGadget' is not designed for extension - needs to be abstract, final or empty. | 71 |
| Violation | Message | Line |
|---|---|---|
|
'com.google.common.collect.Iterables.any' should be separated from previous imports. | 4 |
|
Wrong order for 'java.net.URI' import. | 7 |
|
Wrong order for 'com.atlassian.gadgets.GadgetId' import. | 13 |
|
'com.google.common.base.Function' should be separated from previous imports. | 22 |
|
Class Fan-Out Complexity is 12 (max allowed is 10). | 29 |
|
Line has trailing spaces. | 34 |
|
Line has trailing spaces. | 78 |
|
Line has trailing spaces. | 117 |
|
Static variable definition in wrong order. | 130 |
|
Name 'isNotHidden' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 130 |
|
Missing a Javadoc comment. | 132 |
|
'userPrefs' hides a field. | 158 |
| Violation | Message | Line |
|---|---|---|
|
Wrong order for 'com.atlassian.gadgets.GadgetRequestContext' import. | 4 |
|
Missing a Javadoc comment. | 11 |
|
Method 'convertStateToDashboard' is not designed for extension - needs to be abstract, final or empty. | 20 |
|
Method 'convertStateToGadget' is not designed for extension - needs to be abstract, final or empty. | 25 |
| Violation | Message | Line |
|---|---|---|
|
Missing a Javadoc comment. | 9 |
|
Method 'getDashboardId' is not designed for extension - needs to be abstract, final or empty. | 20 |
|
Method 'getTitle' is not designed for extension - needs to be abstract, final or empty. | 25 |
|
Method 'getTabUri' is not designed for extension - needs to be abstract, final or empty. | 30 |
|
Method 'isWritable' is not designed for extension - needs to be abstract, final or empty. | 35 |
| Violation | Message | Line |
|---|---|---|
|
Wrong order for 'com.atlassian.gadgets.dashboard.DashboardId' import. | 5 |
|
Wrong order for 'com.atlassian.gadgets.GadgetId' import. | 11 |
|
Wrong order for 'com.atlassian.sal.api.transaction.TransactionCallback' import. | 13 |
|
First sentence should end with a period. | 15 |
|
Method 'retrieve' is not designed for extension - needs to be abstract, final or empty. | 35 |
|
Missing a Javadoc comment. | 40 |
|
Line is longer than 120 characters. | 47 |
|
Method 'update' is not designed for extension - needs to be abstract, final or empty. | 47 |
|
Missing a Javadoc comment. | 53 |
|
Method 'remove' is not designed for extension - needs to be abstract, final or empty. | 60 |
|
Missing a Javadoc comment. | 65 |
|
Method 'findDashboardWithGadget' is not designed for extension - needs to be abstract, final or empty. | 73 |
|
method def modifier at indentation level 11 not at correct indentation, 12 | 78 |
|
Missing a Javadoc comment. | 78 |
|
method def lcurly at indentation level 11 not at correct indentation, 12 | 79 |
|
method def child at indentation level 15 not at correct indentation, 16 | 80 |
|
method def rcurly at indentation level 11 not at correct indentation, 12 | 81 |
| Violation | Message | Line |
|---|---|---|
|
Wrong order for 'org.apache.commons.lang.builder.EqualsBuilder' import. | 4 |
|
Wrong order for 'org.apache.commons.lang.StringUtils' import. | 5 |
|
Wrong order for 'com.atlassian.gadgets.dashboard.internal.UserPref' import. | 6 |
|
Wrong order for 'com.atlassian.gadgets.spec.DataType' import. | 8 |
|
Wrong order for 'java.util.Map' import. | 10 |
|
Missing a Javadoc comment. | 12 |
|
Line is longer than 120 characters. | 20 |
|
')' is preceded with whitespace. | 20 |
|
'19' is a magic number. | 61 |
|
'35' is a magic number. | 61 |
|
'if' construct must use '{}'s. | 73 |
|
'if' construct must use '{}'s. | 74 |
|
'if' construct must use '{}'s. | 75 |
| Violation | Message | Line |
|---|---|---|
|
Class Fan-Out Complexity is 23 (max allowed is 10). | 36 |
|
Method 'addGadget' is not designed for extension - needs to be abstract, final or empty. | 71 |
|
Method 'addGadget' is not designed for extension - needs to be abstract, final or empty. | 78 |
|
Line is longer than 120 characters. | 93 |
|
Line is longer than 120 characters. | 121 |
|
Method 'moveGadget' is not designed for extension - needs to be abstract, final or empty. | 121 |
|
Line is longer than 120 characters. | 122 |
|
Missing a Javadoc comment. | 128 |
|
Line is longer than 120 characters. | 135 |
|
Line has trailing spaces. | 145 |
|
Line is longer than 120 characters. | 155 |
|
Line is longer than 120 characters. | 157 |
|
Line is longer than 120 characters. | 175 |
|
'if' is not followed by whitespace. | 189 |
|
'if' is not followed by whitespace. | 191 |
| Violation | Message | Line |
|---|---|---|
|
Wrong order for 'com.atlassian.gadgets.GadgetId' import. | 5 |
|
Wrong order for 'javax.ws.rs.core.Response' import. | 8 |
| Violation | Message | Line |
|---|---|---|
|
Method 'setGadgetColor' is not designed for extension - needs to be abstract, final or empty. | 39 |
| Violation | Message | Line |
|---|---|---|
|
Wrong order for 'com.atlassian.gadgets.GadgetRequestContext' import. | 4 |
|
Wrong order for 'javax.ws.rs.core.Response' import. | 6 |
|
Wrong order for 'javax.ws.rs.core.MultivaluedMap' import. | 7 |
|
Line is longer than 120 characters. | 18 |
| Violation | Message | Line |
|---|---|---|
|
Wrong order for 'com.atlassian.gadgets.dashboard.internal.DashboardRepository' import. | 5 |
|
Wrong order for 'com.atlassian.gadgets.dashboard.Layout' import. | 8 |
|
Wrong order for 'com.atlassian.gadgets.dashboard.DashboardId' import. | 9 |
|
Wrong order for 'com.atlassian.gadgets.GadgetId' import. | 10 |
|
Wrong order for 'javax.ws.rs.core.Response' import. | 14 |
|
Wrong order for 'javax.ws.rs.core.MultivaluedMap' import. | 15 |
|
Wrong order for 'javax.ws.rs.core.MediaType' import. | 16 |
|
Wrong order for 'java.io.IOException' import. | 17 |
|
Wrong order for 'java.util.ArrayList' import. | 19 |
|
Wrong order for 'org.apache.commons.logging.Log' import. | 25 |
|
Class Fan-Out Complexity is 18 (max allowed is 10). | 30 |
|
Method 'changeLayout' is not designed for extension - needs to be abstract, final or empty. | 43 |
|
Line has trailing spaces. | 87 |
|
method def throws at indentation level 12 not at correct indentation, 8 | 99 |
|
method def throws at indentation level 12 not at correct indentation, 8 | 121 |
|
Line is longer than 120 characters. | 124 |
| Violation | Message | Line |
|---|---|---|
|
'org.apache.commons.io.IOUtils' should be separated from previous imports. | 33 |
|
Class Fan-Out Complexity is 23 (max allowed is 10). | 42 |
|
Method 'getDashboard' is not designed for extension - needs to be abstract, final or empty. | 82 |
|
'}' is not preceded with whitespace. | 84 |
|
Line is longer than 120 characters. | 92 |
|
Method 'getNumGadgets' is not designed for extension - needs to be abstract, final or empty. | 102 |
|
Line is longer than 120 characters. | 106 |
|
Line is longer than 120 characters. | 112 |
|
Method 'addGadget' is not designed for extension - needs to be abstract, final or empty. | 133 |
|
Line is longer than 120 characters. | 160 |
|
Method 'changeLayoutViaPOST' is not designed for extension - needs to be abstract, final or empty. | 197 |
|
Method 'changeLayoutViaPUT' is not designed for extension - needs to be abstract, final or empty. | 230 |
|
'+' should be on a new line. | 245 |
| Violation | Message | Line |
|---|---|---|
|
Method 'deleteGadget' is not designed for extension - needs to be abstract, final or empty. | 39 |
| Violation | Message | Line |
|---|---|---|
|
Wrong order for 'com.atlassian.gadgets.dashboard.DashboardNotFoundException' import. | 29 |
|
Class Fan-Out Complexity is 25 (max allowed is 10). | 45 |
|
More than 7 parameters. | 74 |
|
Method 'getRenderedGadget' is not designed for extension - needs to be abstract, final or empty. | 103 |
|
NPath Complexity is 28 (max allowed is 20). | 103 |
|
',' is not followed by whitespace. | 105 |
|
'}' is not preceded with whitespace. | 105 |
|
'if' is not followed by whitespace. | 112 |
|
Line has trailing spaces. | 116 |
|
'{' should be on a new line. | 121 |
|
'if' is not followed by whitespace. | 139 |
|
Method 'deleteOrMoveGadgetViaPost' is not designed for extension - needs to be abstract, final or empty. | 162 |
|
if child at indentation level 16 not at correct indentation, 12 | 176 |
|
Line contains a tab character. | 176 |
|
if child at indentation level 16 not at correct indentation, 12 | 177 |
|
Line contains a tab character. | 177 |
|
Method 'deleteGadget' is not designed for extension - needs to be abstract, final or empty. | 194 |
|
Method 'moveGadget' is not designed for extension - needs to be abstract, final or empty. | 220 |
|
Line is longer than 120 characters. | 238 |
|
Line has trailing spaces. | 257 |
|
Method 'changeGadgetColorViaPOST' is not designed for extension - needs to be abstract, final or empty. | 269 |
|
Method 'changeGadgetColor' is not designed for extension - needs to be abstract, final or empty. | 299 |
|
'+' should be on a new line. | 328 |
|
Method 'updateUserPrefsViaPOST' is not designed for extension - needs to be abstract, final or empty. | 345 |
|
Method 'updateUserPrefsViaPUT' is not designed for extension - needs to be abstract, final or empty. | 388 |
|
'+' should be on a new line. | 412 |
| Violation | Message | Line |
|---|---|---|
|
Wrong order for 'javax.ws.rs.core.MultivaluedMap' import. | 7 |
| Violation | Message | Line |
|---|---|---|
|
Class Fan-Out Complexity is 12 (max allowed is 10). | 24 |
|
Static variable definition in wrong order. | 28 |
|
Method 'updateUserPrefs' is not designed for extension - needs to be abstract, final or empty. | 45 |
| Violation | Message | Line |
|---|---|---|
|
Missing a Javadoc comment. | 35 |
|
Variable 'writable' explicitly initialized to 'false' (default value for its type). | 41 |
|
Method 'writable' is not designed for extension - needs to be abstract, final or empty. | 50 |
|
'writable' hides a field. | 50 |
|
Method 'gadgets' is not designed for extension - needs to be abstract, final or empty. | 56 |
|
'gadgets' hides a field. | 56 |
|
Method 'build' is not designed for extension - needs to be abstract, final or empty. | 64 |
| Violation | Message | Line |
|---|---|---|
|
Wrong order for 'com.atlassian.gadgets.view.ModuleId' import. | 16 |
|
Wrong order for 'org.apache.commons.lang.StringUtils' import. | 19 |
|
Comment matches to-do format 'TODO:'. | 23 |
|
'}' is not preceded with whitespace. | 64 |
|
NPath Complexity is 256 (max allowed is 20). | 92 |
|
Line is longer than 120 characters. | 102 |
|
Method 'getHasNonHiddenUserPrefs' is not designed for extension - needs to be abstract, final or empty. | 113 |
|
Method 'isLoaded' is not designed for extension - needs to be abstract, final or empty. | 118 |
|
Method 'getColor' is not designed for extension - needs to be abstract, final or empty. | 123 |
|
Method 'getGadgetSpecUrl' is not designed for extension - needs to be abstract, final or empty. | 128 |
|
Method 'getHeight' is not designed for extension - needs to be abstract, final or empty. | 133 |
|
Method 'getId' is not designed for extension - needs to be abstract, final or empty. | 138 |
|
Method 'isMaximizable' is not designed for extension - needs to be abstract, final or empty. | 143 |
|
Method 'getTitle' is not designed for extension - needs to be abstract, final or empty. | 148 |
|
Method 'getTitleUrl' is not designed for extension - needs to be abstract, final or empty. | 153 |
|
Method 'getUserPrefs' is not designed for extension - needs to be abstract, final or empty. | 158 |
|
Method 'getWidth' is not designed for extension - needs to be abstract, final or empty. | 163 |
|
Method 'getRenderedGadgetUrl' is not designed for extension - needs to be abstract, final or empty. | 168 |
|
Method 'getColorUrl' is not designed for extension - needs to be abstract, final or empty. | 173 |
|
Method 'getGadgetUrl' is not designed for extension - needs to be abstract, final or empty. | 178 |
|
Method 'hasNonHiddenUserPrefs' is not designed for extension - needs to be abstract, final or empty. | 183 |
|
Method 'getColumn' is not designed for extension - needs to be abstract, final or empty. | 188 |
|
Method 'getErrorMessage' is not designed for extension - needs to be abstract, final or empty. | 193 |
|
'static' modifier out of order with the JLS suggestions. | 201 |
|
Line is longer than 120 characters. | 218 |
|
'(' is followed by whitespace. | 218 |
|
')' is preceded with whitespace. | 218 |
|
'if' is not followed by whitespace. | 220 |
| Violation | Message | Line |
|---|---|---|
|
Line is longer than 120 characters. | 23 |
|
First sentence should end with a period. | 25 |
|
Line is longer than 120 characters. | 35 |
| Violation | Message | Line |
|---|---|---|
|
Missing a Javadoc comment. | 14 |
|
Class Fan-Out Complexity is 13 (max allowed is 10). | 14 |
|
Line is longer than 120 characters. | 19 |
|
Line is longer than 120 characters. | 25 |
|
Method 'createDashboardRepresentation' is not designed for extension - needs to be abstract, final or empty. | 25 |
|
Line is longer than 120 characters. | 32 |
|
Line is longer than 120 characters. | 39 |
|
Method 'createGadgetRepresentation' is not designed for extension - needs to be abstract, final or empty. | 39 |
|
Line is longer than 120 characters. | 42 |
| Violation | Message | Line |
|---|---|---|
|
Wrong order for 'org.apache.commons.lang.builder.EqualsBuilder' import. | 13 |
|
Line is longer than 120 characters. | 44 |
|
Line has trailing spaces. | 46 |
|
Line is longer than 120 characters. | 49 |
|
Constructor definition in wrong order. | 56 |
|
Line has trailing spaces. | 95 |
|
Missing a Javadoc comment. | 97 |
|
Method 'getValue' is not designed for extension - needs to be abstract, final or empty. | 123 |
|
Method 'getLabel' is not designed for extension - needs to be abstract, final or empty. | 128 |
|
Method 'isSelected' is not designed for extension - needs to be abstract, final or empty. | 133 |
| Violation | Message | Line |
|---|---|---|
|
Missing package-info.java file. | 0 |
|
First sentence should end with a period. | 17 |
|
Missing a Javadoc comment. | 58 |
|
Line has trailing spaces. | 73 |
| Violation | Message | Line |
|---|---|---|
|
Missing package-info.java file. | 0 |
|
'com.google.common.base.Preconditions.checkNotNull' should be separated from previous imports. | 25 |
|
Missing a Javadoc comment. | 27 |
|
Class Fan-Out Complexity is 14 (max allowed is 10). | 27 |
|
More than 7 parameters. | 42 |
|
'static' modifier out of order with the JLS suggestions. | 110 |
|
Line has trailing spaces. | 114 |
|
'catch' is not followed by whitespace. | 122 |
|
Line has trailing spaces. | 137 |
| Violation | Message | Line |
|---|---|---|
|
Missing a Javadoc comment. | 21 |
|
Class Fan-Out Complexity is 14 (max allowed is 10). | 21 |
|
Line is longer than 120 characters. | 42 |
|
Method 'createDashboardView' is not designed for extension - needs to be abstract, final or empty. | 42 |
