The following document contains the results of Checkstyle. 
| Files | Infos  |
Warnings  |
Errors  |
|---|---|---|---|
| 44 | 98 | 101 | 323 |
| Rules | Violations | Severity |
|---|---|---|
| JavadocPackage | 3 | Error |
| Translation | 0 | Error |
| FileLength | 0 | Error |
FileTabCharacter
|
0 | Error |
RegexpSingleline
|
66 | Warning |
| AnnotationUseStyle | 0 | Error |
| MissingDeprecated | 0 | Error |
MissingOverride
|
0 | Error |
| PackageAnnotation | 0 | Error |
JavadocMethod
|
157 | Error |
JavadocType
|
20 | Error |
JavadocVariable
|
0 | Error |
JavadocStyle
|
8 | Error |
| ConstantName | 1 | Error |
| LocalFinalVariableName | 0 | Error |
| LocalVariableName | 0 | Error |
| MemberName | 0 | Error |
| MethodName | 0 | Error |
| PackageName | 0 | Error |
| ParameterName | 0 | Error |
| StaticVariableName | 0 | Error |
| TypeName | 0 | Error |
| AvoidStarImport | 0 | Error |
| IllegalImport | 0 | Error |
ImportOrder
|
71 | Error |
| RedundantImport | 0 | Error |
| UnusedImports | 6 | Error |
LineLength
|
35 | Warning |
| MethodLength | 0 | Error |
| ParameterNumber | 2 | Error |
| EmptyForIteratorPad | 1 | Error |
| MethodParamPad | 1 | Error |
| NoWhitespaceAfter | 0 | Error |
| NoWhitespaceBefore | 0 | Error |
| ParenPad | 0 | Error |
| TypecastParenPad | 0 | Error |
| WhitespaceAfter | 3 | Error |
| WhitespaceAround | 5 | Error |
| ModifierOrder | 0 | Error |
| RedundantModifier | 3 | Error |
| AvoidNestedBlocks | 0 | Error |
| EmptyBlock | 0 | Error |
LeftCurly
|
3 | Error |
| NeedBraces | 3 | Error |
RightCurly
|
0 | Error |
| DeclarationOrder | 1 | Error |
| DefaultComesLast | 0 | Error |
| DoubleCheckedLocking | 0 | Error |
| EmptyStatement | 0 | Error |
| EqualsHashCode | 0 | Error |
| ExplicitInitialization | 0 | Error |
| FallThrough | 0 | Error |
HiddenField
|
6 | Error |
| IllegalInstantiation | 0 | Error |
| InnerAssignment | 0 | Error |
| MagicNumber | 4 | Error |
| MissingSwitchDefault | 0 | Error |
| ParameterAssignment | 0 | Error |
RedundantThrows
|
0 | Error |
| SimplifyBooleanExpression | 0 | Error |
| SimplifyBooleanReturn | 0 | Error |
| StringLiteralEquality | 0 | Error |
| DesignForExtension | 98 | Info |
| FinalClass | 0 | Error |
| HideUtilityClassConstructor | 1 | Error |
| InterfaceIsType | 0 | Error |
| VisibilityModifier | 0 | Error |
| BooleanExpressionComplexity | 0 | Error |
| ClassDataAbstractionCoupling | 1 | Error |
ClassFanOutComplexity
|
9 | Error |
| CyclomaticComplexity | 0 | Error |
NPathComplexity
|
0 | Error |
| JavaNCSS | 0 | Error |
| ArrayTypeStyle | 0 | Error |
| Indentation | 13 | Error |
| TodoComment | 1 | Error |
| UpperEll | 0 | Error |
| Violation | Message | Line |
|---|---|---|
|
Missing a Javadoc comment. | 7 |
|
Missing a Javadoc comment. | 12 |
|
Method 'getId' is not designed for extension - needs to be abstract, final or empty. | 18 |
|
Missing a Javadoc comment. | 18 |
|
Method 'getTitle' is not designed for extension - needs to be abstract, final or empty. | 23 |
|
Missing a Javadoc comment. | 23 |
|
Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 28 |
| Violation | Message | Line |
|---|---|---|
|
Wrong order for 'com.atlassian.gadgets.dashboard.DashboardState.ColumnIndex' import. | 11 |
|
Missing a Javadoc comment. | 13 |
|
Class Fan-Out Complexity is 13 (max allowed is 10). | 13 |
|
Missing a Javadoc comment. | 15 |
|
Missing a Javadoc comment. | 17 |
|
Line has trailing spaces. | 18 |
|
Missing a Javadoc comment. | 19 |
|
Missing a Javadoc comment. | 21 |
|
Line has trailing spaces. | 22 |
|
Missing a Javadoc comment. | 23 |
|
Line has trailing spaces. | 24 |
|
Missing a Javadoc comment. | 25 |
|
Missing a Javadoc comment. | 34 |
|
Missing a Javadoc comment. | 44 |
|
Line has trailing spaces. | 48 |
|
Line has trailing spaces. | 55 |
|
Line has trailing spaces. | 63 |
|
Line has trailing spaces. | 67 |
|
Line has trailing spaces. | 73 |
|
Expected @throws tag for 'GadgetNotFoundException'. | 77 |
|
Expected @throws tag for 'GadgetNotLoadedException'. | 77 |
|
First sentence should end with a period. | 79 |
|
Line is longer than 120 characters. | 85 |
|
',' is not followed by whitespace. | 85 |
|
Expected @throws tag for 'GadgetNotFoundException'. | 85 |
|
Expected @throws tag for 'GadgetNotLoadedException'. | 85 |
| Violation | Message | Line |
|---|---|---|
|
Missing package-info.java file. | 0 |
|
Wrong order for 'com.atlassian.gadgets.GadgetRequestContext' import. | 5 |
|
Missing a Javadoc comment. | 7 |
|
Missing a Javadoc comment. | 9 |
|
Missing a Javadoc comment. | 10 |
|
'(' is preceded with whitespace. | 10 |
| Violation | Message | Line |
|---|---|---|
|
Wrong order for 'java.io.IOException' import. | 5 |
|
Wrong order for 'com.atlassian.templaterenderer.RenderingException' import. | 12 |
|
'com.google.common.collect.ImmutableMap' should be separated from previous imports. | 15 |
|
Missing a Javadoc comment. | 17 |
|
Missing a Javadoc comment. | 23 |
|
Line has trailing spaces. | 31 |
|
Method 'render' is not designed for extension - needs to be abstract, final or empty. | 32 |
|
Missing a Javadoc comment. | 32 |
|
Line is longer than 120 characters. | 37 |
|
Method 'render' is not designed for extension - needs to be abstract, final or empty. | 37 |
|
Missing a Javadoc comment. | 37 |
|
Line has trailing spaces. | 41 |
|
Method 'renderFragment' is not designed for extension - needs to be abstract, final or empty. | 42 |
|
Missing a Javadoc comment. | 42 |
|
Method 'resolve' is not designed for extension - needs to be abstract, final or empty. | 47 |
|
Missing a Javadoc comment. | 47 |
| Violation | Message | Line |
|---|---|---|
|
Line has trailing spaces. | 22 |
|
Line has trailing spaces. | 26 |
|
Line has trailing spaces. | 29 |
|
Line has trailing spaces. | 30 |
|
Line has trailing spaces. | 34 |
|
Line has trailing spaces. | 37 |
|
Line has trailing spaces. | 39 |
|
Line has trailing spaces. | 43 |
|
Line has trailing spaces. | 46 |
|
Line has trailing spaces. | 48 |
|
Line has trailing spaces. | 52 |
|
Line has trailing spaces. | 55 |
|
Line has trailing spaces. | 57 |
|
Line has trailing spaces. | 64 |
|
Redundant 'public' modifier. | 76 |
|
Redundant 'public' modifier. | 84 |
|
Redundant 'public' modifier. | 92 |
| Violation | Message | Line |
|---|---|---|
|
'com.google.common.collect.ImmutableMap' should be separated from previous imports. | 8 |
|
Missing a Javadoc comment. | 10 |
|
Line has trailing spaces. | 12 |
|
Missing a Javadoc comment. | 13 |
|
Method 'findDashboardMenuItems' is not designed for extension - needs to be abstract, final or empty. | 20 |
|
Missing a Javadoc comment. | 20 |
|
Method 'findDashboardToolsMenuItems' is not designed for extension - needs to be abstract, final or empty. | 26 |
|
Missing a Javadoc comment. | 26 |
|
Line is longer than 120 characters. | 34 |
| Violation | Message | Line |
|---|---|---|
|
Wrong order for 'java.net.URI' import. | 5 |
|
Missing a Javadoc comment. | 11 |
|
Missing a Javadoc comment. | 13 |
|
Missing a Javadoc comment. | 15 |
|
First sentence should end with a period. | 17 |
|
Expected an @return tag. | 21 |
|
Line has trailing spaces. | 22 |
|
Missing a Javadoc comment. | 23 |
|
Missing a Javadoc comment. | 25 |
|
Missing a Javadoc comment. | 27 |
|
Line has trailing spaces. | 28 |
|
Missing a Javadoc comment. | 29 |
|
Line has trailing spaces. | 30 |
|
Missing a Javadoc comment. | 31 |
|
Line has trailing spaces. | 32 |
|
Missing a Javadoc comment. | 33 |
|
Line has trailing spaces. | 41 |
|
Missing a Javadoc comment. | 42 |
|
Unused @throws tag for 'IllegalArgumentException'. | 49 |
|
Missing a Javadoc comment. | 54 |
|
First sentence should end with a period. | 56 |
|
Line is longer than 120 characters. | 57 |
|
Line is longer than 120 characters. | 58 |
|
Expected an @return tag. | 60 |
|
First sentence should end with a period. | 62 |
|
Expected an @return tag. | 67 |
| Violation | Message | Line |
|---|---|---|
|
Wrong order for 'com.atlassian.gadgets.GadgetRequestContext' import. | 5 |
|
Missing a Javadoc comment. | 8 |
|
Line is longer than 120 characters. | 10 |
|
Missing a Javadoc comment. | 10 |
|
Line is longer than 120 characters. | 11 |
|
Missing a Javadoc comment. | 11 |
| Violation | Message | Line |
|---|---|---|
|
Missing a Javadoc comment. | 6 |
|
Missing a Javadoc comment. | 8 |
|
Missing a Javadoc comment. | 9 |
| Violation | Message | Line |
|---|---|---|
|
Line has trailing spaces. | 4 |
|
Missing a Javadoc comment. | 9 |
| Violation | Message | Line |
|---|---|---|
|
Missing a Javadoc comment. | 5 |
|
Missing a Javadoc comment. | 9 |
|
Line is longer than 120 characters. | 11 |
|
Method 'getGadgetId' is not designed for extension - needs to be abstract, final or empty. | 15 |
|
Missing a Javadoc comment. | 15 |
| Violation | Message | Line |
|---|---|---|
|
Missing a Javadoc comment. | 3 |
|
Missing a Javadoc comment. | 5 |
| Violation | Message | Line |
|---|---|---|
|
Wrong order for 'com.atlassian.gadgets.GadgetRequestContext' import. | 4 |
|
First sentence should end with a period. | 7 |
|
First sentence should end with a period. | 12 |
|
First sentence should end with a period. | 20 |
| Violation | Message | Line |
|---|---|---|
|
First sentence should end with a period. | 5 |
| Violation | Message | Line |
|---|---|---|
|
Wrong order for 'com.atlassian.gadgets.dashboard.DashboardId' import. | 6 |
|
Wrong order for 'com.atlassian.sal.api.transaction.TransactionCallback' import. | 13 |
|
Line has trailing spaces. | 38 |
|
Method 'retrieve' is not designed for extension - needs to be abstract, final or empty. | 39 |
|
Missing a Javadoc comment. | 39 |
|
Method 'store' is not designed for extension - needs to be abstract, final or empty. | 57 |
|
Missing a Javadoc comment. | 57 |
|
Method 'remove' is not designed for extension - needs to be abstract, final or empty. | 87 |
|
Missing a Javadoc comment. | 87 |
| Violation | Message | Line |
|---|---|---|
|
Missing a Javadoc comment. | 12 |
|
Missing a Javadoc comment. | 16 |
|
Line has trailing spaces. | 20 |
|
Missing a Javadoc comment. | 21 |
|
Missing a Javadoc comment. | 26 |
|
Line has trailing spaces. | 30 |
|
Missing a Javadoc comment. | 31 |
|
Missing a Javadoc comment. | 43 |
|
';' is followed by whitespace. | 45 |
|
Missing a Javadoc comment. | 55 |
|
'gadgets' hides a field. | 57 |
|
Missing a Javadoc comment. | 65 |
| Violation | Message | Line |
|---|---|---|
|
'com.google.common.collect.Lists.newLinkedList' should be separated from previous imports. | 4 |
|
Wrong order for 'java.util.ArrayList' import. | 6 |
|
Wrong order for 'com.atlassian.gadgets.dashboard.DashboardState.ColumnIndex' import. | 22 |
|
Class Data Abstraction Coupling is 9 (max allowed is 7) classes [ArrayList, Column, GadgetImpl, GadgetLayoutException, GadgetLimitExceededException, GadgetNotFoundException, GadgetNotLoadedException, HashMap, LinkedList]. | 33 |
|
Class Fan-Out Complexity is 24 (max allowed is 10). | 33 |
|
Line has trailing spaces. | 37 |
|
Missing a Javadoc comment. | 45 |
|
Missing a Javadoc comment. | 52 |
|
Line has trailing spaces. | 56 |
|
Missing a Javadoc comment. | 57 |
|
Line is longer than 120 characters. | 62 |
|
Missing a Javadoc comment. | 62 |
|
Method 'getId' is not designed for extension - needs to be abstract, final or empty. | 71 |
|
Missing a Javadoc comment. | 71 |
|
Method 'getTitle' is not designed for extension - needs to be abstract, final or empty. | 80 |
|
Missing a Javadoc comment. | 80 |
|
Method 'getLayout' is not designed for extension - needs to be abstract, final or empty. | 89 |
|
Missing a Javadoc comment. | 89 |
|
Method 'getMaxGadgets' is not designed for extension - needs to be abstract, final or empty. | 98 |
|
Missing a Javadoc comment. | 98 |
|
Line has trailing spaces. | 106 |
|
Method 'getGadgetsInColumn' is not designed for extension - needs to be abstract, final or empty. | 107 |
|
Missing a Javadoc comment. | 107 |
|
Line has trailing spaces. | 118 |
|
Method 'appendGadget' is not designed for extension - needs to be abstract, final or empty. | 119 |
|
Missing a Javadoc comment. | 119 |
|
Method 'appendGadget' is not designed for extension - needs to be abstract, final or empty. | 124 |
|
Missing a Javadoc comment. | 124 |
|
Line is longer than 120 characters. | 129 |
|
Method 'addGadget' is not designed for extension - needs to be abstract, final or empty. | 134 |
|
Missing a Javadoc comment. | 134 |
|
Method 'addGadget' is not designed for extension - needs to be abstract, final or empty. | 139 |
|
Missing a Javadoc comment. | 139 |
|
Line is longer than 120 characters. | 144 |
|
Method 'changeLayout' is not designed for extension - needs to be abstract, final or empty. | 149 |
|
Missing a Javadoc comment. | 149 |
|
'layout' hides a field. | 149 |
|
method call child at indentation level 7 not at correct indentation, 8 | 151 |
|
method def child at indentation level 7 not at correct indentation, 8 | 151 |
|
method call child at indentation level 7 not at correct indentation, 8 | 152 |
|
method def child at indentation level 7 not at correct indentation, 8 | 152 |
|
method call child at indentation level 7 not at correct indentation, 8 | 153 |
|
method def child at indentation level 7 not at correct indentation, 8 | 153 |
|
Line has trailing spaces. | 154 |
|
method def child at indentation level 7 not at correct indentation, 8 | 155 |
|
method call child at indentation level 7 not at correct indentation, 8 | 156 |
|
method def child at indentation level 7 not at correct indentation, 8 | 156 |
|
method call child at indentation level 7 not at correct indentation, 8 | 157 |
|
method def child at indentation level 7 not at correct indentation, 8 | 157 |
|
Method 'rearrangeGadgets' is not designed for extension - needs to be abstract, final or empty. | 160 |
|
Missing a Javadoc comment. | 160 |
|
Line has trailing spaces. | 165 |
|
Line has trailing spaces. | 169 |
|
Method 'changeGadgetColor' is not designed for extension - needs to be abstract, final or empty. | 170 |
|
Missing a Javadoc comment. | 170 |
|
Method 'updateGadgetUserPrefs' is not designed for extension - needs to be abstract, final or empty. | 185 |
|
Missing a Javadoc comment. | 185 |
|
',' is not followed by whitespace. | 185 |
|
Method 'removeGadget' is not designed for extension - needs to be abstract, final or empty. | 200 |
|
Missing a Javadoc comment. | 200 |
|
Line has trailing spaces. | 209 |
|
Method 'getState' is not designed for extension - needs to be abstract, final or empty. | 210 |
|
Missing a Javadoc comment. | 210 |
|
Line has trailing spaces. | 223 |
|
'columns' hides a field. | 226 |
|
Line has trailing spaces. | 238 |
|
Line has trailing spaces. | 248 |
|
'state' hides a field. | 249 |
|
Line is longer than 120 characters. | 269 |
|
Line has trailing spaces. | 288 |
|
Line has trailing spaces. | 300 |
|
Line has trailing spaces. | 325 |
|
Line has trailing spaces. | 353 |
|
Line is longer than 120 characters. | 370 |
|
Line has trailing spaces. | 376 |
|
Line has trailing spaces. | 377 |
|
Method 'assertGadgetLayoutIsValid' is not designed for extension - needs to be abstract, final or empty. | 379 |
|
'layout' hides a field. | 379 |
|
Expected @param tag for 'layout'. | 379 |
|
Expected @param tag for 'gadgetLayout'. | 379 |
|
Line is longer than 120 characters. | 383 |
| Violation | Message | Line |
|---|---|---|
|
Missing package-info.java file. | 0 |
|
Wrong order for 'com.atlassian.gadgets.dashboard.DashboardId' import. | 5 |
|
Wrong order for 'com.atlassian.gadgets.GadgetRequestContext' import. | 13 |
|
Line has trailing spaces. | 34 |
|
Line is longer than 120 characters. | 35 |
|
Method 'get' is not designed for extension - needs to be abstract, final or empty. | 35 |
|
Missing a Javadoc comment. | 35 |
|
Method 'save' is not designed for extension - needs to be abstract, final or empty. | 40 |
|
Missing a Javadoc comment. | 40 |
|
Line is longer than 120 characters. | 45 |
| Violation | Message | Line |
|---|---|---|
|
Method 'get' is not designed for extension - needs to be abstract, final or empty. | 29 |
|
Missing a Javadoc comment. | 29 |
|
Method 'save' is not designed for extension - needs to be abstract, final or empty. | 38 |
|
Missing a Javadoc comment. | 38 |
| Violation | Message | Line |
|---|---|---|
|
Missing a Javadoc comment. | 9 |
|
Line has trailing spaces. | 12 |
|
Line has trailing spaces. | 14 |
|
Missing a Javadoc comment. | 15 |
|
Line has trailing spaces. | 19 |
|
Method 'get' is not designed for extension - needs to be abstract, final or empty. | 20 |
|
Missing a Javadoc comment. | 20 |
|
Method 'put' is not designed for extension - needs to be abstract, final or empty. | 25 |
|
Missing a Javadoc comment. | 25 |
|
Method 'remove' is not designed for extension - needs to be abstract, final or empty. | 30 |
|
Missing a Javadoc comment. | 30 |
|
Method 'removeAll' is not designed for extension - needs to be abstract, final or empty. | 35 |
|
Missing a Javadoc comment. | 35 |
| Violation | Message | Line |
|---|---|---|
|
Missing a Javadoc comment. | 10 |
|
Missing a Javadoc comment. | 12 |
|
Method 'getBaseUrl' is not designed for extension - needs to be abstract, final or empty. | 21 |
|
Method 'buildDashboardUrl' is not designed for extension - needs to be abstract, final or empty. | 27 |
|
Missing a Javadoc comment. | 27 |
|
Method 'buildDashboardLayoutUrl' is not designed for extension - needs to be abstract, final or empty. | 32 |
|
Missing a Javadoc comment. | 32 |
|
Line has trailing spaces. | 36 |
|
Method 'buildGadgetUrl' is not designed for extension - needs to be abstract, final or empty. | 37 |
|
Missing a Javadoc comment. | 37 |
|
Method 'buildGadgetColorUrl' is not designed for extension - needs to be abstract, final or empty. | 42 |
|
Missing a Javadoc comment. | 42 |
|
Method 'buildGadgetUserPrefsUrl' is not designed for extension - needs to be abstract, final or empty. | 47 |
|
Missing a Javadoc comment. | 47 |
|
Method 'buildErrorGadgetUrl' is not designed for extension - needs to be abstract, final or empty. | 52 |
|
Missing a Javadoc comment. | 52 |
|
Line is longer than 120 characters. | 54 |
|
Method 'buildDashboardResourceUrl' is not designed for extension - needs to be abstract, final or empty. | 57 |
|
Missing a Javadoc comment. | 57 |
|
Method 'buildDashboardDirectoryResourceUrl' is not designed for extension - needs to be abstract, final or empty. | 63 |
|
Missing a Javadoc comment. | 63 |
|
Method 'buildDashboardDirectoryUrl' is not designed for extension - needs to be abstract, final or empty. | 68 |
|
Missing a Javadoc comment. | 68 |
|
'{' is not preceded with whitespace. | 68 |
|
'{' should be on a new line. | 68 |
| Violation | Message | Line |
|---|---|---|
|
Wrong order for 'com.atlassian.gadgets.GadgetRequestContext' import. | 8 |
|
Line is longer than 120 characters. | 43 |
|
Line is longer than 120 characters. | 45 |
|
Method 'createGadget' is not designed for extension - needs to be abstract, final or empty. | 45 |
|
Line is longer than 120 characters. | 69 |
|
Method 'createGadget' is not designed for extension - needs to be abstract, final or empty. | 69 |
| Violation | Message | Line |
|---|---|---|
|
'com.google.common.collect.Iterables.any' should be separated from previous imports. | 4 |
|
Wrong order for 'java.util.ArrayList' import. | 7 |
|
Wrong order for 'java.util.LinkedList' import. | 11 |
|
Wrong order for 'java.net.URI' import. | 12 |
|
Wrong order for 'com.atlassian.gadgets.spec.GadgetSpec' import. | 15 |
|
Wrong order for 'com.atlassian.gadgets.GadgetId' import. | 17 |
|
Wrong order for 'com.atlassian.gadgets.spec.DataType' import. | 21 |
|
Wrong order for 'com.atlassian.gadgets.dashboard.Color' import. | 22 |
|
'com.google.common.base.Predicate' should be separated from previous imports. | 25 |
|
Wrong order for 'com.google.common.base.Function' import. | 26 |
|
Class Fan-Out Complexity is 16 (max allowed is 10). | 32 |
|
Line has trailing spaces. | 38 |
|
Line has trailing spaces. | 86 |
|
Missing a Javadoc comment. | 87 |
|
Missing a Javadoc comment. | 92 |
|
Missing a Javadoc comment. | 98 |
|
Missing a Javadoc comment. | 103 |
|
Missing a Javadoc comment. | 109 |
|
Missing a Javadoc comment. | 115 |
|
Missing a Javadoc comment. | 121 |
|
Line has trailing spaces. | 125 |
|
Missing a Javadoc comment. | 126 |
|
Missing a Javadoc comment. | 132 |
|
Missing a Javadoc comment. | 137 |
|
Static variable definition in wrong order. | 142 |
|
Name 'isNotHidden' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 142 |
|
Missing a Javadoc comment. | 150 |
|
Missing a Javadoc comment. | 155 |
|
',' is not followed by whitespace. | 155 |
|
Line has trailing spaces. | 170 |
|
Missing a Javadoc comment. | 176 |
|
'userPrefs' hides a field. | 190 |
|
Missing a Javadoc comment. | 205 |
|
Missing a Javadoc comment. | 210 |
| Violation | Message | Line |
|---|---|---|
|
Wrong order for 'java.util.List' import. | 5 |
|
Wrong order for 'com.atlassian.gadgets.GadgetId' import. | 9 |
|
Missing a Javadoc comment. | 12 |
|
Missing a Javadoc comment. | 16 |
|
Method 'getNumberOfColumns' is not designed for extension - needs to be abstract, final or empty. | 21 |
|
Missing a Javadoc comment. | 21 |
|
Line has trailing spaces. | 25 |
|
Method 'getGadgetsInColumn' is not designed for extension - needs to be abstract, final or empty. | 26 |
|
Missing a Javadoc comment. | 26 |
|
Line has trailing spaces. | 30 |
|
Method 'equals' is not designed for extension - needs to be abstract, final or empty. | 31 |
|
Line has trailing spaces. | 52 |
|
Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. | 53 |
| Violation | Message | Line |
|---|---|---|
|
Wrong order for 'com.atlassian.gadgets.GadgetRequestContext' import. | 4 |
|
Missing a Javadoc comment. | 11 |
|
Missing a Javadoc comment. | 15 |
|
Method 'convertStateToDashboard' is not designed for extension - needs to be abstract, final or empty. | 20 |
|
Missing a Javadoc comment. | 20 |
|
Method 'convertStateToGadget' is not designed for extension - needs to be abstract, final or empty. | 25 |
|
Missing a Javadoc comment. | 25 |
| Violation | Message | Line |
|---|---|---|
|
Wrong order for 'org.apache.commons.lang.builder.EqualsBuilder' import. | 4 |
|
Wrong order for 'org.apache.commons.lang.StringUtils' import. | 5 |
|
Wrong order for 'com.atlassian.gadgets.dashboard.internal.UserPref' import. | 6 |
|
Wrong order for 'com.atlassian.gadgets.spec.DataType' import. | 8 |
|
Wrong order for 'java.util.Map' import. | 10 |
|
Missing a Javadoc comment. | 12 |
|
Missing a Javadoc comment. | 17 |
|
Method 'getName' is not designed for extension - needs to be abstract, final or empty. | 23 |
|
Missing a Javadoc comment. | 23 |
|
Method 'getDisplayName' is not designed for extension - needs to be abstract, final or empty. | 28 |
|
Missing a Javadoc comment. | 28 |
|
Method 'isRequired' is not designed for extension - needs to be abstract, final or empty. | 33 |
|
Missing a Javadoc comment. | 33 |
|
Method 'getDataType' is not designed for extension - needs to be abstract, final or empty. | 38 |
|
Missing a Javadoc comment. | 38 |
|
Method 'getEnumValues' is not designed for extension - needs to be abstract, final or empty. | 43 |
|
Missing a Javadoc comment. | 43 |
|
Method 'getDefaultValue' is not designed for extension - needs to be abstract, final or empty. | 48 |
|
Missing a Javadoc comment. | 48 |
|
Method 'getValue' is not designed for extension - needs to be abstract, final or empty. | 53 |
|
Missing a Javadoc comment. | 53 |
|
Method 'setValue' is not designed for extension - needs to be abstract, final or empty. | 58 |
|
Missing a Javadoc comment. | 58 |
|
Line is longer than 120 characters. | 62 |
|
Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. | 67 |
|
'19' is a magic number. | 70 |
|
'35' is a magic number. | 70 |
|
Method 'equals' is not designed for extension - needs to be abstract, final or empty. | 79 |
|
'if' construct must use '{}'s. | 82 |
|
'if' construct must use '{}'s. | 83 |
|
'if' construct must use '{}'s. | 84 |
| Violation | Message | Line |
|---|---|---|
|
Wrong order for 'com.atlassian.gadgets.GadgetRequestContext' import. | 4 |
|
Wrong order for 'javax.ws.rs.core.Response' import. | 6 |
| Violation | Message | Line |
|---|---|---|
|
Class Fan-Out Complexity is 19 (max allowed is 10). | 30 |
|
Method 'addGadget' is not designed for extension - needs to be abstract, final or empty. | 65 |
|
Missing a Javadoc comment. | 65 |
| Violation | Message | Line |
|---|---|---|
|
Wrong order for 'com.atlassian.gadgets.GadgetId' import. | 5 |
|
Wrong order for 'javax.ws.rs.core.Response' import. | 8 |
| Violation | Message | Line |
|---|---|---|
|
Method 'setGadgetColor' is not designed for extension - needs to be abstract, final or empty. | 39 |
|
Missing a Javadoc comment. | 39 |
| Violation | Message | Line |
|---|---|---|
|
Wrong order for 'com.atlassian.gadgets.GadgetRequestContext' import. | 4 |
|
Wrong order for 'javax.ws.rs.core.Response' import. | 6 |
|
Wrong order for 'javax.ws.rs.core.MultivaluedMap' import. | 7 |
|
Line is longer than 120 characters. | 18 |
|
Expected an @return tag. | 21 |
| Violation | Message | Line |
|---|---|---|
|
Wrong order for 'com.atlassian.gadgets.dashboard.internal.DashboardRepository' import. | 6 |
|
Wrong order for 'com.atlassian.gadgets.dashboard.Layout' import. | 9 |
|
Wrong order for 'com.atlassian.gadgets.dashboard.DashboardId' import. | 10 |
|
Wrong order for 'com.atlassian.gadgets.GadgetId' import. | 11 |
|
Wrong order for 'javax.ws.rs.core.Response' import. | 15 |
|
Wrong order for 'javax.ws.rs.core.MultivaluedMap' import. | 16 |
|
Wrong order for 'javax.ws.rs.core.MediaType' import. | 17 |
|
Wrong order for 'java.io.IOException' import. | 18 |
|
Wrong order for 'java.util.ArrayList' import. | 20 |
|
Wrong order for 'org.apache.commons.logging.Log' import. | 26 |
|
Class Fan-Out Complexity is 19 (max allowed is 10). | 31 |
|
Missing a Javadoc comment. | 38 |
|
Method 'changeLayout' is not designed for extension - needs to be abstract, final or empty. | 44 |
|
Missing a Javadoc comment. | 44 |
|
Line has trailing spaces. | 88 |
|
method def throws at indentation level 12 not at correct indentation, 8 | 100 |
|
method def throws at indentation level 12 not at correct indentation, 8 | 122 |
|
Line is longer than 120 characters. | 125 |
| Violation | Message | Line |
|---|---|---|
|
Wrong order for 'com.atlassian.gadgets.dashboard.Layout' import. | 5 |
|
Wrong order for 'com.atlassian.gadgets.dashboard.DashboardState' import. | 6 |
|
Wrong order for 'com.atlassian.gadgets.GadgetRequestContext' import. | 8 |
|
Wrong order for 'javax.xml.bind.annotation.XmlRootElement' import. | 10 |
|
Wrong order for 'javax.xml.bind.annotation.XmlElement' import. | 11 |
|
Wrong order for 'javax.xml.bind.annotation.XmlAttribute' import. | 12 |
|
Unused import - javax.xml.bind.annotation.XmlAttribute. | 12 |
|
Wrong order for 'javax.xml.bind.annotation.adapters.XmlAdapter' import. | 14 |
|
Wrong order for 'java.util.ArrayList' import. | 15 |
|
Unused import - java.util.HashMap. | 17 |
|
Unused import - java.util.Map. | 19 |
|
Missing a Javadoc comment. | 22 |
|
Utility classes should not have a public or default constructor. | 36 |
|
'}' is not preceded with whitespace. | 42 |
|
'}' is not preceded with whitespace. | 60 |
|
Line is longer than 120 characters. | 77 |
|
'{' should be on a new line. | 80 |
|
Line is longer than 120 characters. | 81 |
|
Line is longer than 120 characters. | 89 |
|
'{' should be on a new line. | 89 |
|
'}' is not preceded with whitespace. | 100 |
|
Line has trailing spaces. | 109 |
|
Line is longer than 120 characters. | 110 |
|
Missing a Javadoc comment. | 110 |
|
Line is longer than 120 characters. | 124 |
|
Method 'getColumns' is not designed for extension - needs to be abstract, final or empty. | 131 |
|
Missing a Javadoc comment. | 131 |
|
Method 'getTitle' is not designed for extension - needs to be abstract, final or empty. | 136 |
|
Missing a Javadoc comment. | 136 |
|
Method 'getLayout' is not designed for extension - needs to be abstract, final or empty. | 141 |
|
Missing a Javadoc comment. | 141 |
|
Method 'getMaxGadgets' is not designed for extension - needs to be abstract, final or empty. | 146 |
|
Missing a Javadoc comment. | 146 |
|
Method 'getId' is not designed for extension - needs to be abstract, final or empty. | 151 |
|
Missing a Javadoc comment. | 151 |
| Violation | Message | Line |
|---|---|---|
|
Wrong order for 'java.net.URI' import. | 7 |
|
Unused import - java.net.URI. | 7 |
|
Unused import - java.net.URISyntaxException. | 8 |
|
Wrong order for 'com.atlassian.gadgets.dashboard.DashboardId' import. | 27 |
|
Class Fan-Out Complexity is 23 (max allowed is 10). | 44 |
|
Line has trailing spaces. | 57 |
|
More than 7 parameters. | 70 |
|
Method 'getDashboard' is not designed for extension - needs to be abstract, final or empty. | 89 |
|
Missing a Javadoc comment. | 89 |
|
Line is longer than 120 characters. | 101 |
|
Line is longer than 120 characters. | 106 |
|
Method 'addGadget' is not designed for extension - needs to be abstract, final or empty. | 119 |
|
Method 'changeLayoutViaPOST' is not designed for extension - needs to be abstract, final or empty. | 171 |
|
Method 'changeLayoutViaPUT' is not designed for extension - needs to be abstract, final or empty. | 204 |
| Violation | Message | Line |
|---|---|---|
|
Wrong order for 'com.atlassian.gadgets.GadgetId' import. | 4 |
|
Wrong order for 'javax.ws.rs.core.Response' import. | 7 |
|
Wrong order for 'java.util.Locale' import. | 8 |
|
Unused import - java.util.Locale. | 8 |
| Violation | Message | Line |
|---|---|---|
|
Method 'deleteGadget' is not designed for extension - needs to be abstract, final or empty. | 39 |
|
Missing a Javadoc comment. | 39 |
| Violation | Message | Line |
|---|---|---|
|
'org.apache.commons.lang.builder.EqualsBuilder' should be separated from previous imports. | 18 |
|
Comment matches to-do format 'TODO:'. | 23 |
|
Class Fan-Out Complexity is 11 (max allowed is 10). | 26 |
|
'}' is not preceded with whitespace. | 49 |
|
Line is longer than 120 characters. | 70 |
|
Method 'getColor' is not designed for extension - needs to be abstract, final or empty. | 109 |
|
Missing a Javadoc comment. | 109 |
|
Method 'getGadgetSpecUrl' is not designed for extension - needs to be abstract, final or empty. | 114 |
|
Missing a Javadoc comment. | 114 |
|
Method 'getHeight' is not designed for extension - needs to be abstract, final or empty. | 119 |
|
Missing a Javadoc comment. | 119 |
|
Method 'getId' is not designed for extension - needs to be abstract, final or empty. | 124 |
|
Missing a Javadoc comment. | 124 |
|
Method 'getMaximizable' is not designed for extension - needs to be abstract, final or empty. | 129 |
|
Missing a Javadoc comment. | 129 |
|
Method 'getTitle' is not designed for extension - needs to be abstract, final or empty. | 134 |
|
Missing a Javadoc comment. | 134 |
|
Method 'getUserPrefs' is not designed for extension - needs to be abstract, final or empty. | 139 |
|
Missing a Javadoc comment. | 139 |
|
Method 'getWidth' is not designed for extension - needs to be abstract, final or empty. | 144 |
|
Missing a Javadoc comment. | 144 |
|
Method 'getRenderedGadgetUrl' is not designed for extension - needs to be abstract, final or empty. | 149 |
|
Missing a Javadoc comment. | 149 |
|
Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. | 154 |
|
'17' is a magic number. | 157 |
|
'29' is a magic number. | 157 |
|
Method 'equals' is not designed for extension - needs to be abstract, final or empty. | 169 |
| Violation | Message | Line |
|---|---|---|
|
Wrong order for 'com.atlassian.sal.api.message.I18nResolver' import. | 42 |
|
Class Fan-Out Complexity is 28 (max allowed is 10). | 50 |
|
More than 7 parameters. | 79 |
|
Method 'getRenderedGadget' is not designed for extension - needs to be abstract, final or empty. | 108 |
|
Line is longer than 120 characters. | 128 |
|
Method 'deleteGadgetViaPOST' is not designed for extension - needs to be abstract, final or empty. | 169 |
|
Method 'deleteGadget' is not designed for extension - needs to be abstract, final or empty. | 196 |
|
Method 'changeGadgetColorViaPOST' is not designed for extension - needs to be abstract, final or empty. | 224 |
|
Method 'changeGadgetColor' is not designed for extension - needs to be abstract, final or empty. | 254 |
|
Method 'updateUserPrefsViaPOST' is not designed for extension - needs to be abstract, final or empty. | 300 |
|
Method 'updateUserPrefsViaPUT' is not designed for extension - needs to be abstract, final or empty. | 343 |
| Violation | Message | Line |
|---|---|---|
|
Wrong order for 'javax.ws.rs.core.MultivaluedMap' import. | 7 |
| Violation | Message | Line |
|---|---|---|
|
Class Fan-Out Complexity is 12 (max allowed is 10). | 24 |
|
Method 'updateUserPrefs' is not designed for extension - needs to be abstract, final or empty. | 43 |
|
Missing a Javadoc comment. | 43 |
| Violation | Message | Line |
|---|---|---|
|
Missing package-info.java file. | 0 |
|
Wrong order for 'com.atlassian.gadgets.GadgetRequestContext' import. | 7 |
|
Wrong order for 'java.util.Map' import. | 10 |
|
Missing a Javadoc comment. | 12 |
|
Missing a Javadoc comment. | 21 |
|
Line is longer than 120 characters. | 29 |
|
Missing a Javadoc comment. | 38 |
| Violation | Message | Line |
|---|---|---|
|
Missing a Javadoc comment. | 13 |
|
Line is longer than 120 characters. | 19 |
|
Missing a Javadoc comment. | 19 |
|
Missing a Javadoc comment. | 27 |
|
Missing a Javadoc comment. | 38 |
| Violation | Message | Line |
|---|---|---|
|
Wrong order for 'com.atlassian.gadgets.GadgetRequestContext' import. | 9 |
|
Missing a Javadoc comment. | 12 |
|
Missing a Javadoc comment. | 19 |
|
Line is longer than 120 characters. | 30 |
|
Method 'createDashboardView' is not designed for extension - needs to be abstract, final or empty. | 30 |
|
Missing a Javadoc comment. | 30 |
