FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 1.2.0

Threshold is Low

Effort is Default

Summary

Classes Bugs Errors Missing Classes
206 5 0 0

Files

Class Bugs
com.atlassian.gadgets.dashboard.internal.impl.GadgetImpl$1 1
com.atlassian.gadgets.dashboard.internal.rest.ChangeLayoutHandlerImpl$ParseGadgetLayoutException 2
com.atlassian.gadgets.dashboard.internal.rest.DashboardResource 1
com.atlassian.gadgets.dashboard.internal.rest.GadgetResource 1

com.atlassian.gadgets.dashboard.internal.impl.GadgetImpl$1

Bug Category Details Line
The class com.atlassian.gadgets.dashboard.internal.impl.GadgetImpl$1 could be refactored into a named _static_ inner class PERFORMANCE SIC_INNER_SHOULD_BE_STATIC_ANON Not available

com.atlassian.gadgets.dashboard.internal.rest.ChangeLayoutHandlerImpl$ParseGadgetLayoutException

Bug Category Details Line
com.atlassian.gadgets.dashboard.internal.rest.ChangeLayoutHandlerImpl$ParseGadgetLayoutException is serializable but also an inner class of a non-serializable class BAD_PRACTICE SE_BAD_FIELD_INNER_CLASS Not available
Should com.atlassian.gadgets.dashboard.internal.rest.ChangeLayoutHandlerImpl$ParseGadgetLayoutException be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC Not available

com.atlassian.gadgets.dashboard.internal.rest.DashboardResource

Bug Category Details Line
Method com.atlassian.gadgets.dashboard.internal.rest.DashboardResource.changeLayoutViaPOST(DashboardId, HttpServletRequest, MultivaluedMap) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 135

com.atlassian.gadgets.dashboard.internal.rest.GadgetResource

Bug Category Details Line
Method com.atlassian.gadgets.dashboard.internal.rest.GadgetResource.updateUserPrefsViaPOST(String, DashboardId, GadgetId, HttpServletRequest, MultivaluedMap) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 309