The following document contains the results of FindBugs Report
FindBugs Version is 1.2.0
Threshold is Low
Effort is Default
| Classes | Bugs | Errors | Missing Classes |
|---|---|---|---|
| 1191 | 110 | 0 | 7 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Dead store to prime in com.atlassian.theplugin.eclipse.core.bamboo.BambooServer.hashCode() | STYLE | DLS_DEAD_LOCAL_STORE | 105 |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.theplugin.eclipse.core.operation.AbstractNonLockingOperation.NON_LOCKING_RULE isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 23 |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.theplugin.eclipse.core.operation.CompositeOperation$Pair.Pair(CompositeOperation, IActionOperation, IActionOperation[]) may expose internal representation by storing an externally mutable object into CompositeOperation$Pair.dependsOnOperation | MALICIOUS_CODE | EI_EXPOSE_REP2 | 114 |
| Should com.atlassian.theplugin.eclipse.core.operation.CompositeOperation$Pair be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Method com.atlassian.theplugin.eclipse.core.operation.UILoggedOperation$1.1(String, String, IStatus, boolean) creates a thread using the default empty run method | MT_CORRECTNESS | DM_USELESS_THREAD | 59 |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.theplugin.eclipse.core.operation.bamboo.DeleteBambooServerOperation.DeleteBambooServerOperation(IBambooServer[]) may expose internal representation by storing an externally mutable object into DeleteBambooServerOperation.servers | MALICIOUS_CODE | EI_EXPOSE_REP2 | 31 |
| Bug | Category | Details | Line |
|---|---|---|---|
| The class com.atlassian.theplugin.eclipse.core.operation.bamboo.DeleteBambooServerOperation$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.theplugin.eclipse.core.operation.bamboo.RefreshBambooServersOperation.RefreshBambooServersOperation(Object[], boolean) may expose internal representation by storing an externally mutable object into RefreshBambooServersOperation.nodes | MALICIOUS_CODE | EI_EXPOSE_REP2 | 37 |
| Bug | Category | Details | Line |
|---|---|---|---|
| BuildLogEditor.text not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Write to static field com.atlassian.theplugin.eclipse.preferences.Activator.plugin from instance method com.atlassian.theplugin.eclipse.preferences.Activator.start(BundleContext) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 94 |
| Write to static field com.atlassian.theplugin.eclipse.preferences.Activator.plugin from instance method com.atlassian.theplugin.eclipse.preferences.Activator.stop(BundleContext) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 143 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Method com.atlassian.theplugin.eclipse.preferences.Activator$1.belongsTo(Object) uses the same code for two switch clauses | STYLE | DB_DUPLICATE_SWITCH_CLAUSES | 275 |
| The class com.atlassian.theplugin.eclipse.preferences.Activator$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Dead store to empty1 in com.atlassian.theplugin.eclipse.preferences.BambooPlanListFieldEditor.doFillIntoGrid(Composite, int) | STYLE | DLS_DEAD_LOCAL_STORE | 132 |
| Dead store to empty2 in com.atlassian.theplugin.eclipse.preferences.BambooPlanListFieldEditor.doFillIntoGrid(Composite, int) | STYLE | DLS_DEAD_LOCAL_STORE | 172 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Method com.atlassian.theplugin.eclipse.preferences.BambooPlanListFieldEditor$Column.getNames() uses Collection.toArray() with zero-length array argument | PERFORMANCE | ITA_INEFFICIENT_TO_ARRAY | 411 |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.theplugin.eclipse.preferences.BambooTabConfiguration.getColumnsOrder() may expose internal representation by returning BambooTabConfiguration.columnsOrder | MALICIOUS_CODE | EI_EXPOSE_REP | 28 |
| com.atlassian.theplugin.eclipse.preferences.BambooTabConfiguration.setColumnsOrder(int[]) may expose internal representation by storing an externally mutable object into BambooTabConfiguration.columnsOrder | MALICIOUS_CODE | EI_EXPOSE_REP2 | 32 |
| BambooTabConfiguration.columnsOrder not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Method com.atlassian.theplugin.eclipse.preferences.MyIntegerFieldEditor.setValidRange(int, int) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 80 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Possible null pointer dereference of MyStringFieldEditor.textField in com.atlassian.theplugin.eclipse.preferences.MyStringFieldEditor.checkState() | CORRECTNESS | NP_NULL_ON_SOME_PATH | 194 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Possible null pointer dereference of PasswordFieldEditor.textField in com.atlassian.theplugin.eclipse.preferences.PasswordFieldEditor.checkState() | CORRECTNESS | NP_NULL_ON_SOME_PATH | 194 |
| Bug | Category | Details | Line |
|---|---|---|---|
| The class com.atlassian.theplugin.eclipse.preferences.PreferencePageServers$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.theplugin.eclipse.preferences.ProjectConfigurationWrapper.getPluginConfiguration() invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 68 |
| Bug | Category | Details | Line |
|---|---|---|---|
| The class com.atlassian.theplugin.eclipse.preferences.TestConnection$TestConnectionListener$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Should com.atlassian.theplugin.eclipse.ui.RefreshPending.getChildren(Object) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 47 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Should com.atlassian.theplugin.eclipse.ui.bamboo.BambooErrorNode.getChildren(Object) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 44 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Should com.atlassian.theplugin.eclipse.ui.bamboo.BambooPlanNode.getChildren(Object) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 16 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Should com.atlassian.theplugin.eclipse.ui.bamboo.BambooPlans.wrapChildren(BambooPlan[]) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 94 |
| Redundant nullcheck of plans, which is known to be non-null in com.atlassian.theplugin.eclipse.ui.bamboo.BambooPlans.wrapChildren(BambooPlan[]) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 97 |
| Bug | Category | Details | Line |
|---|---|---|---|
| The class com.atlassian.theplugin.eclipse.ui.bamboo.BambooPlans$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.theplugin.eclipse.ui.bamboo.BambooServerNode.getChildren(Object) may expose internal representation by returning BambooServerNode.children | MALICIOUS_CODE | EI_EXPOSE_REP | 80 |
| com.atlassian.theplugin.eclipse.ui.bamboo.BambooServerNode defines equals and uses Object.hashCode() | BAD_PRACTICE | HE_EQUALS_USE_HASHCODE | 88-91 |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.theplugin.eclipse.ui.bamboo.BambooServersRoot.getChildren(Object) may expose internal representation by returning BambooServersRoot.children | MALICIOUS_CODE | EI_EXPOSE_REP | 97 |
| Bug | Category | Details | Line |
|---|---|---|---|
| The class com.atlassian.theplugin.eclipse.ui.bamboo.BambooServersRoot$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| BambooServersView.root not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| The class com.atlassian.theplugin.eclipse.ui.bamboo.BambooServersView$4 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| The class com.atlassian.theplugin.eclipse.ui.bamboo.BambooServersView$9 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.theplugin.eclipse.ui.bamboo.BambooTreeViewer.internalRefreshStruct(Widget, Object, boolean) invokes java.lang.reflect.Method.setAccessible(boolean), which should be invoked from within a doPrivileged block | BAD_PRACTICE | DP_DO_INSIDE_DO_PRIVILEGED | 201 |
| Should com.atlassian.theplugin.eclipse.ui.bamboo.BambooTreeViewer.getIdenticalNodes(Object, boolean) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 230 |
| Exception is caught when Exception is not thrown in com.atlassian.theplugin.eclipse.ui.bamboo.BambooTreeViewer.internalRefreshStruct(Widget, Object, boolean) | STYLE | REC_CATCH_EXCEPTION | 203 |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.theplugin.eclipse.ui.bamboo.IBambooResource$Info.Info(long, String, Date, boolean) may expose internal representation by storing an externally mutable object into IBambooResource$Info.lastChangedDate | MALICIOUS_CODE | EI_EXPOSE_REP2 | 35 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Dead store of null to report in com.atlassian.theplugin.eclipse.ui.composite.ReportingComposite.saveReport() | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 326 |
| Confusing to have methods com.atlassian.theplugin.eclipse.ui.composite.ReportingComposite.getUserName() and com.atlassian.theplugin.eclipse.core.bamboo.BambooServer.getUsername() | BAD_PRACTICE | NM_CONFUSING | 103 |
| Bug | Category | Details | Line |
|---|---|---|---|
| The class com.atlassian.theplugin.eclipse.ui.composite.ReportingComposite$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Method com.atlassian.theplugin.eclipse.ui.debugmail.Reporter.formReport(IMailSettingsProvider, IStatus, String, String, String, String, String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 112 |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.theplugin.eclipse.ui.dialog.AdvancedDialog.setButtonEx(Button[]) may expose internal representation by storing an externally mutable object into AdvancedDialog.buttonsEx | MALICIOUS_CODE | EI_EXPOSE_REP2 | 165 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Field DefaultDialog.message masks field in superclass org.eclipse.jface.dialogs.IconAndMessageDialog | CORRECTNESS | MF_CLASS_MASKS_FIELD | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| The class com.atlassian.theplugin.eclipse.ui.dialog.DefaultDialog$2 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.theplugin.eclipse.ui.operation.bamboo.GetBambooPlansChildrenOperation.getChildren() may expose internal representation by returning GetBambooPlansChildrenOperation.children | MALICIOUS_CODE | EI_EXPOSE_REP | 39 |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.theplugin.eclipse.ui.panel.AbstractAdvancedDialogPanel.getButtonNamesEx() may expose internal representation by returning AbstractAdvancedDialogPanel.buttonNamesEx | MALICIOUS_CODE | EI_EXPOSE_REP | 35 |
| com.atlassian.theplugin.eclipse.ui.panel.AbstractAdvancedDialogPanel.AbstractAdvancedDialogPanel(String[], String[]) may expose internal representation by storing an externally mutable object into AbstractAdvancedDialogPanel.buttonNamesEx | MALICIOUS_CODE | EI_EXPOSE_REP2 | 31 |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.theplugin.eclipse.ui.panel.AbstractDialogPanel.getButtonNames() may expose internal representation by returning AbstractDialogPanel.buttonNames | MALICIOUS_CODE | EI_EXPOSE_REP | 89 |
| com.atlassian.theplugin.eclipse.ui.panel.AbstractDialogPanel.AbstractDialogPanel(String[]) may expose internal representation by storing an externally mutable object into AbstractDialogPanel.buttonNames | MALICIOUS_CODE | EI_EXPOSE_REP2 | 47 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Ambiguous invocation of either an outer or inherited method com.atlassian.theplugin.eclipse.ui.verifier.AbstractVerificationKeyListener.isFilledRight() in com.atlassian.theplugin.eclipse.ui.panel.AbstractDialogPanel$VerificationKeyListener.handleButtons() | STYLE | IA_AMBIGUOUS_INVOCATION_OF_INHERITED_OR_OUTER_METHOD | 171 |
| Ambiguous invocation of either an outer or inherited method com.atlassian.theplugin.eclipse.ui.verifier.AbstractVerificationKeyListener.isFilledRight() in com.atlassian.theplugin.eclipse.ui.panel.AbstractDialogPanel$VerificationKeyListener.handleButtons() | STYLE | IA_AMBIGUOUS_INVOCATION_OF_INHERITED_OR_OUTER_METHOD | 173 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Dead store to styledRanges in com.atlassian.theplugin.eclipse.ui.panel.reporting.PreviewPanel.createControls(Composite) | STYLE | DLS_DEAD_LOCAL_STORE | 77 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Method com.atlassian.theplugin.eclipse.ui.verifier.AbstractFormattedVerifier.getFormattedMessage(String) invokes toString() method on a String | PERFORMANCE | DM_STRING_TOSTRING | 62 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Dead store of null to listeners in com.atlassian.theplugin.eclipse.ui.verifier.AbstractVerifier.fireError(String) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 95 |
| Dead store of null to listeners in com.atlassian.theplugin.eclipse.ui.verifier.AbstractVerifier.fireOk() | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 119 |
| Dead store of null to listeners in com.atlassian.theplugin.eclipse.ui.verifier.AbstractVerifier.fireWarning(String) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 107 |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.theplugin.eclipse.ui.verifier.NonEmptyFieldVerifier.ERROR_MESSAGE should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Not available |
| Write to static field com.atlassian.theplugin.eclipse.ui.verifier.NonEmptyFieldVerifier.ERROR_MESSAGE from instance method com.atlassian.theplugin.eclipse.ui.verifier.NonEmptyFieldVerifier.NonEmptyFieldVerifier(String) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 30 |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.theplugin.eclipse.ui.verifier.URLVerifier.ERROR_MESSAGE_FULL should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Not available |
| com.atlassian.theplugin.eclipse.ui.verifier.URLVerifier.ERROR_MESSAGE_SHORT should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Not available |
| Write to static field com.atlassian.theplugin.eclipse.ui.verifier.URLVerifier.ERROR_MESSAGE_FULL from instance method com.atlassian.theplugin.eclipse.ui.verifier.URLVerifier.URLVerifier(String) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 38 |
| Write to static field com.atlassian.theplugin.eclipse.ui.verifier.URLVerifier.ERROR_MESSAGE_SHORT from instance method com.atlassian.theplugin.eclipse.ui.verifier.URLVerifier.URLVerifier(String) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 33 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Ambiguous invocation of either an outer or inherited method com.atlassian.theplugin.eclipse.ui.verifier.AbstractVerificationKeyListener.isFilledRight() in com.atlassian.theplugin.eclipse.ui.wizard.AbstractVerifiedWizardPage$VerificationKeyListener.handleButtons() | STYLE | IA_AMBIGUOUS_INVOCATION_OF_INHERITED_OR_OUTER_METHOD | 154 |
| Bug | Category | Details | Line |
|---|---|---|---|
| The class com.atlassian.theplugin.eclipse.ui.wizard.bamboo.AddBambooServerPage$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| The class com.atlassian.theplugin.eclipse.ui.wizard.bamboo.AddBambooServerPage$3 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.theplugin.eclipse.ui.wizard.bamboo.AddBambooServerPage$ProjectListPanel.ProjectListPanel(IProject[], boolean) may expose internal representation by storing an externally mutable object into AddBambooServerPage$ProjectListPanel.resources | MALICIOUS_CODE | EI_EXPOSE_REP2 | 288 |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.theplugin.eclipse.util.FileUtil.copyFile(File, File, int, IProgressMonitor) might ignore java.lang.Exception | BAD_PRACTICE | DE_MIGHT_IGNORE | 494 |
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 134 |
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 157 |
| com.atlassian.theplugin.eclipse.util.FileUtil.getEnvironmentVariables() may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 126 |
| Exception is caught when Exception is not thrown in com.atlassian.theplugin.eclipse.util.FileUtil.getEnvironmentVariables() | STYLE | REC_CATCH_EXCEPTION | 120 |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.theplugin.eclipse.util.StringId.generateRandom(int) invokes inefficient new String() constructor | PERFORMANCE | DM_STRING_VOID_CTOR | 51 |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.theplugin.eclipse.view.bamboo.BambooConfigurationStorage.getBambooServers() may expose internal representation by returning BambooConfigurationStorage.bambooServers | MALICIOUS_CODE | EI_EXPOSE_REP | 120 |
| Bug | Category | Details | Line |
|---|---|---|---|
| The class com.atlassian.theplugin.eclipse.view.bamboo.BambooStatusBar$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| BambooToolWindow.commentBuildAction not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
| BambooToolWindow.labelBuildAction not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
| BambooToolWindow.runBuildAction not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
| BambooToolWindow.showBuilLogAction not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
| BambooToolWindow.statusLineManager not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Method com.atlassian.theplugin.eclipse.view.bamboo.BambooToolWindowContent$BambooLabelProvider.getColumnText(Object, int) uses the same code for two switch clauses | STYLE | DB_DUPLICATE_SWITCH_CLAUSES | 269 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Write to static field com.atlassian.theplugin.eclipse.view.bamboo.BambooToolWindowHtmlContent.html from instance method com.atlassian.theplugin.eclipse.view.bamboo.BambooToolWindowHtmlContent.updateBambooStatus(BuildStatus, BambooPopupInfo) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 57 |
| Write to static field com.atlassian.theplugin.eclipse.view.bamboo.BambooToolWindowHtmlContent.linkClicked from instance method com.atlassian.theplugin.eclipse.view.bamboo.BambooToolWindowHtmlContent.updateBambooStatus(BuildStatus, BambooPopupInfo) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 58 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Should com.atlassian.theplugin.eclipse.view.bamboo.BambooToolWindowHtmlContent$BrowserLocationListener be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Should com.atlassian.theplugin.eclipse.view.bamboo.BambooToolWindowHtmlContent$MouseClickListener be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| The class com.atlassian.theplugin.eclipse.view.popup.AbstractNotificationPopup$5 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.theplugin.eclipse.view.popup.AbstractTask.getCompletionDate() may expose internal representation by returning AbstractTask.completionDate | MALICIOUS_CODE | EI_EXPOSE_REP | 409 |
| com.atlassian.theplugin.eclipse.view.popup.AbstractTask.getCreationDate() may expose internal representation by returning AbstractTask.creationDate | MALICIOUS_CODE | EI_EXPOSE_REP | 432 |
| com.atlassian.theplugin.eclipse.view.popup.AbstractTask.getDueDate() may expose internal representation by returning AbstractTask.dueDate | MALICIOUS_CODE | EI_EXPOSE_REP | 490 |
| com.atlassian.theplugin.eclipse.view.popup.AbstractTask.getScheduledForDate() may expose internal representation by returning AbstractTask.scheduledForDate | MALICIOUS_CODE | EI_EXPOSE_REP | 417 |
| com.atlassian.theplugin.eclipse.view.popup.AbstractTask.setCompletionDate(Date) may expose internal representation by storing an externally mutable object into AbstractTask.completionDate | MALICIOUS_CODE | EI_EXPOSE_REP2 | 444 |
| com.atlassian.theplugin.eclipse.view.popup.AbstractTask.setCreationDate(Date) may expose internal representation by storing an externally mutable object into AbstractTask.creationDate | MALICIOUS_CODE | EI_EXPOSE_REP2 | 436 |
| com.atlassian.theplugin.eclipse.view.popup.AbstractTask.setDueDate(Date) may expose internal representation by storing an externally mutable object into AbstractTask.dueDate | MALICIOUS_CODE | EI_EXPOSE_REP2 | 494 |
| com.atlassian.theplugin.eclipse.view.popup.AbstractTask.setScheduledForDate(Date) may expose internal representation by storing an externally mutable object into AbstractTask.scheduledForDate | MALICIOUS_CODE | EI_EXPOSE_REP2 | 413 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Method com.atlassian.theplugin.eclipse.view.popup.AbstractTask$PriorityLevel.toString() uses the same code for two switch clauses | STYLE | DB_DUPLICATE_SWITCH_CLAUSES | 110 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Read of unwritten field background in com.atlassian.theplugin.eclipse.view.popup.CompositeSynchImageDescriptor.CompositeSynchImageDescriptor(ImageDescriptor, boolean) | CORRECTNESS | NP_UNWRITTEN_FIELD | 42 |
| Unused field: com.atlassian.theplugin.eclipse.view.popup.CompositeSynchImageDescriptor.WIDTH | PERFORMANCE | UUF_UNUSED_FIELD | Not available |
| Unwritten field: com.atlassian.theplugin.eclipse.view.popup.CompositeSynchImageDescriptor.background | CORRECTNESS | UWF_UNWRITTEN_FIELD | 42 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Dead store to fontColor in com.atlassian.theplugin.eclipse.view.popup.NotificationPopup.createContentArea(Composite) | STYLE | DLS_DEAD_LOCAL_STORE | 118 |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.theplugin.eclipse.view.popup.SwtUtil.fade(Shell, boolean, int, int) invokes java.lang.reflect.Method.setAccessible(boolean), which should be invoked from within a doPrivileged block | BAD_PRACTICE | DP_DO_INSIDE_DO_PRIVILEGED | 88 |
| com.atlassian.theplugin.eclipse.view.popup.SwtUtil.getAlpha(Shell) invokes java.lang.reflect.Method.setAccessible(boolean), which should be invoked from within a doPrivileged block | BAD_PRACTICE | DP_DO_INSIDE_DO_PRIVILEGED | 67 |
| com.atlassian.theplugin.eclipse.view.popup.SwtUtil.setAlpha(Shell, int) invokes java.lang.reflect.Method.setAccessible(boolean), which should be invoked from within a doPrivileged block | BAD_PRACTICE | DP_DO_INSIDE_DO_PRIVILEGED | 50 |
| Exception is caught when Exception is not thrown in com.atlassian.theplugin.eclipse.view.popup.SwtUtil.fade(Shell, boolean, int, int) | STYLE | REC_CATCH_EXCEPTION | 115 |
| Exception is caught when Exception is not thrown in com.atlassian.theplugin.eclipse.view.popup.SwtUtil.getAlpha(Shell) | STYLE | REC_CATCH_EXCEPTION | 69 |
| Exception is caught when Exception is not thrown in com.atlassian.theplugin.eclipse.view.popup.SwtUtil.setAlpha(Shell, int) | STYLE | REC_CATCH_EXCEPTION | 54 |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.theplugin.eclipse.view.popup.TaskListColorsAndFonts.STRIKETHROUGH isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 74 |
