The following document contains the results of FindBugs Report
FindBugs Version is 1.2.0
Threshold is Low
Effort is Default
| Classes | Bugs | Errors | Missing Classes |
|---|---|---|---|
| 641 | 42 | 0 | 0 |
| Bug | Category | Details | Line |
|---|---|---|---|
| The class com.atlassian.theplugin.commons.DefaultSwingUiTaskExecutor$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.theplugin.commons.bamboo.BambooBuildInfo.getBuildCompletedDate() may expose internal representation by returning BambooBuildInfo.buildCompletedDate | MALICIOUS_CODE | EI_EXPOSE_REP | 91 |
| com.atlassian.theplugin.commons.bamboo.BambooBuildInfo.getPollingTime() may expose internal representation by returning BambooBuildInfo.pollingTime | MALICIOUS_CODE | EI_EXPOSE_REP | 200 |
| com.atlassian.theplugin.commons.bamboo.BambooBuildInfo.BambooBuildInfo(String, String, BambooServerCfg, Date, String, boolean, String, BuildStatus, String, Date, String, String, int, int, Date, String, String, String, Collection) may expose internal representation by storing an externally mutable object into BambooBuildInfo.pollingTime | MALICIOUS_CODE | EI_EXPOSE_REP2 | 61 |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.theplugin.commons.bamboo.BambooBuildInfo$Builder.completionTime(Date) may expose internal representation by storing an externally mutable object into BambooBuildInfo$Builder.completionTime | MALICIOUS_CODE | EI_EXPOSE_REP2 | 270 |
| com.atlassian.theplugin.commons.bamboo.BambooBuildInfo$Builder.pollingTime(Date) may expose internal representation by storing an externally mutable object into BambooBuildInfo$Builder.pollingTime | MALICIOUS_CODE | EI_EXPOSE_REP2 | 291 |
| com.atlassian.theplugin.commons.bamboo.BambooBuildInfo$Builder.startTime(Date) may expose internal representation by storing an externally mutable object into BambooBuildInfo$Builder.startTime | MALICIOUS_CODE | EI_EXPOSE_REP2 | 265 |
| Bug | Category | Details | Line |
|---|---|---|---|
| BambooChangeSetImpl.commitDate not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Result of integer multiplication cast to long in com.atlassian.theplugin.commons.bamboo.BambooStatusChecker.getInterval() | STYLE | ICAST_INTEGER_MULTIPLY_CAST_TO_LONG | 149 |
| Bug | Category | Details | Line |
|---|---|---|---|
| The class com.atlassian.theplugin.commons.bamboo.StatusIconBambooListener$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Unchecked/unconfirmed cast from com.atlassian.theplugin.commons.cfg.PrivateServerCfgInfo to com.atlassian.theplugin.commons.cfg.PrivateBambooServerCfgInfo in com.atlassian.theplugin.commons.cfg.BambooServerCfg.mergePrivateConfiguration(PrivateServerCfgInfo) | STYLE | BC_UNCONFIRMED_CAST | 166 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Unread field: com.atlassian.theplugin.commons.cfg.CfgManagerImpl.credentialListeners | PERFORMANCE | URF_UNREAD_FIELD | 29 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Should com.atlassian.theplugin.commons.cfg.CfgManagerImpl$ConfigurationTypeChangedAction be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Should com.atlassian.theplugin.commons.cfg.CfgManagerImpl$ServerAddedAction be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Should com.atlassian.theplugin.commons.cfg.CfgManagerImpl$ServerChangedAction be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Should com.atlassian.theplugin.commons.cfg.CfgManagerImpl$ServerEnabledDisabledAction be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Should com.atlassian.theplugin.commons.cfg.CfgManagerImpl$ServerRemovedAction be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Uncallable method com.atlassian.theplugin.commons.cfg.CrucibleServerCfg$1.setPassword(String) defined in anonymous class | CORRECTNESS | UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS | 53-54 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Confusing to have methods com.atlassian.theplugin.commons.cfg.PrivateServerCfgInfo.getUsername() and com.atlassian.theplugin.commons.crucible.api.model.UserBean.getUserName() | BAD_PRACTICE | NM_CONFUSING | 37 |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.theplugin.commons.cfg.xstream.HomeDirPrivateConfigurationDao.writeXmlFile(Element, File) may fail to close stream on exception | BAD_PRACTICE | OS_OPEN_STREAM_EXCEPTION_PATH | 133 |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.theplugin.commons.crucible.CrucibleFiltersBean.getPredefinedFilters() may expose internal representation by returning CrucibleFiltersBean.predefinedFilters | MALICIOUS_CODE | EI_EXPOSE_REP | 43 |
| com.atlassian.theplugin.commons.crucible.CrucibleFiltersBean.setPredefinedFilters(Boolean[]) may expose internal representation by storing an externally mutable object into CrucibleFiltersBean.predefinedFilters | MALICIOUS_CODE | EI_EXPOSE_REP2 | 54 |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.theplugin.commons.crucible.api.model.CrucibleFileInfoImpl.getCommitDate() may expose internal representation by returning CrucibleFileInfoImpl.commitDate | MALICIOUS_CODE | EI_EXPOSE_REP | 260 |
| com.atlassian.theplugin.commons.crucible.api.model.CrucibleFileInfoImpl.setCommitDate(Date) may expose internal representation by storing an externally mutable object into CrucibleFileInfoImpl.commitDate | MALICIOUS_CODE | EI_EXPOSE_REP2 | 264 |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.theplugin.commons.crucible.api.model.CustomFilterBean.getState() may expose internal representation by returning CustomFilterBean.state | MALICIOUS_CODE | EI_EXPOSE_REP | 94 |
| com.atlassian.theplugin.commons.crucible.api.model.CustomFilterBean.setState(State[]) may expose internal representation by storing an externally mutable object into CustomFilterBean.state | MALICIOUS_CODE | EI_EXPOSE_REP2 | 98 |
| Redundant nullcheck of ?, which is known to be non-null in com.atlassian.theplugin.commons.crucible.api.model.CustomFilterBean.hashCode() | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 67 |
| Method com.atlassian.theplugin.commons.crucible.api.model.CustomFilterBean.getStates() concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 224 |
| Unread field: com.atlassian.theplugin.commons.crucible.api.model.CustomFilterBean.filterName; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 40 |
| Unread field: com.atlassian.theplugin.commons.crucible.api.model.CustomFilterBean.filterUrl; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 41 |
| Bug | Category | Details | Line |
|---|---|---|---|
| com.atlassian.theplugin.commons.crucible.api.model.ReviewBean.getCloseDate() may expose internal representation by returning ReviewBean.closeDate | MALICIOUS_CODE | EI_EXPOSE_REP | 394 |
| com.atlassian.theplugin.commons.crucible.api.model.ReviewBean.getCreateDate() may expose internal representation by returning ReviewBean.createDate | MALICIOUS_CODE | EI_EXPOSE_REP | 386 |
| com.atlassian.theplugin.commons.crucible.api.model.ReviewBean.setCloseDate(Date) may expose internal representation by storing an externally mutable object into ReviewBean.closeDate | MALICIOUS_CODE | EI_EXPOSE_REP2 | 398 |
| com.atlassian.theplugin.commons.crucible.api.model.ReviewBean.setCreateDate(Date) may expose internal representation by storing an externally mutable object into ReviewBean.createDate | MALICIOUS_CODE | EI_EXPOSE_REP2 | 390 |
| ReviewBean.generalComments not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
| ReviewBean.reviewers not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Abstract com.atlassian.theplugin.commons.crucible.api.model.User defines compareTo(User) method | BAD_PRACTICE | CO_ABSTRACT_SELF | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Confusing to have methods com.atlassian.theplugin.commons.crucible.api.model.UserBean.setUserName(String) and com.atlassian.theplugin.commons.cfg.ServerCfg.setUsername(String) | BAD_PRACTICE | NM_CONFUSING | 41-42 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Method com.atlassian.theplugin.commons.crucible.api.rest.CrucibleSessionImpl.addReviewers(PermId, Set) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 1339 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Should com.atlassian.theplugin.commons.remoteapi.rest.AbstractHttpSession$CacheRecord be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 62 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 62 |
