FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 1.2.0

Threshold is Low

Effort is Default

Summary

Classes Bugs Errors Missing Classes
265 20 0 0

Files

Class Bugs
com.atlassian.config.AbstractConfigurationPersister 2
com.atlassian.config.ApplicationConfig 2
com.atlassian.config.bootstrap.BootstrappedContextLoaderListener 1
com.atlassian.config.bootstrap.DefaultAtlassianBootstrapManager 3
com.atlassian.config.db.DatabaseDetails 2
com.atlassian.config.db.DatabaseHelper 1
com.atlassian.config.db.DatabaseLowerPropertyCheck 1
com.atlassian.config.db.HibernateConfig 1
com.atlassian.config.lifecycle.DefaultLifecycleManager 2
com.atlassian.config.lifecycle.LifecyclePluginModuleDescriptor 1
com.atlassian.config.lifecycle.events.ApplicationStartedEvent 1
com.atlassian.config.lifecycle.events.ApplicationStoppedEvent 1
com.atlassian.config.lifecycle.events.ApplicationStoppingEvent 1
com.atlassian.config.xml.Dom4jXmlMapEntryConfigElement$Entry 1

com.atlassian.config.AbstractConfigurationPersister

Bug Category Details Line
Exception is caught when Exception is not thrown in com.atlassian.config.AbstractConfigurationPersister.addConfigElement(Object, String, Object) STYLE REC_CATCH_EXCEPTION 60
Exception is caught when Exception is not thrown in com.atlassian.config.AbstractConfigurationPersister.getConfigElement(Class, String, Object) STYLE REC_CATCH_EXCEPTION 81

com.atlassian.config.ApplicationConfig

Bug Category Details Line
com.atlassian.config.ApplicationConfig.setProperty(Object, boolean) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead PERFORMANCE DM_BOOLEAN_CTOR 177
Method com.atlassian.config.ApplicationConfig.setProperty(Object, int) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 172

com.atlassian.config.bootstrap.BootstrappedContextLoaderListener

Bug Category Details Line
Class com.atlassian.config.bootstrap.BootstrappedContextLoaderListener implements same interface as superclass STYLE RI_REDUNDANT_INTERFACES Not available

com.atlassian.config.bootstrap.DefaultAtlassianBootstrapManager

Bug Category Details Line
com.atlassian.config.bootstrap.DefaultAtlassianBootstrapManager.getTestDatasourceConnection(String) may fail to close java.sql.Statement BAD_PRACTICE ODR_OPEN_DATABASE_RESOURCE 404
com.atlassian.config.bootstrap.DefaultAtlassianBootstrapManager.getTestDatasourceConnection(String) ignores return value of java.sql.Connection.createStatement() CORRECTNESS RV_RETURN_VALUE_IGNORED 404
Method com.atlassian.config.bootstrap.DefaultAtlassianBootstrapManager.tableExists(Connection, String) passes a nonconstant String to an execute method on an SQL statement BAD_PRACTICE SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE 442

com.atlassian.config.db.DatabaseDetails

Bug Category Details Line
Use of non-localized String.toUpperCase() or String.toLowerCase I18N DM_CONVERT_CASE 179
Use of non-localized String.toUpperCase() or String.toLowerCase I18N DM_CONVERT_CASE 201

com.atlassian.config.db.DatabaseHelper

Bug Category Details Line
com.atlassian.config.db.DatabaseHelper.setDatabaseLowerProperty(Properties, ApplicationConfiguration) may fail to close java.sql.Statement BAD_PRACTICE ODR_OPEN_DATABASE_RESOURCE 56

com.atlassian.config.db.DatabaseLowerPropertyCheck

Bug Category Details Line
DatabaseLowerPropertyCheck.bootstrapManager not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available

com.atlassian.config.db.HibernateConfig

Bug Category Details Line
HibernateConfig.applicationConfig not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available

com.atlassian.config.lifecycle.DefaultLifecycleManager

Bug Category Details Line
DefaultLifecycleManager.eventManager not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available
DefaultLifecycleManager.pluginManager not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available

com.atlassian.config.lifecycle.LifecyclePluginModuleDescriptor

Bug Category Details Line
com.atlassian.config.lifecycle.LifecyclePluginModuleDescriptor defines compareTo(Object) and uses Object.equals() BAD_PRACTICE EQ_COMPARETO_USE_OBJECT_EQUALS 115-117

com.atlassian.config.lifecycle.events.ApplicationStartedEvent

Bug Category Details Line
com.atlassian.config.lifecycle.events.ApplicationStartedEvent is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID Not available

com.atlassian.config.lifecycle.events.ApplicationStoppedEvent

Bug Category Details Line
com.atlassian.config.lifecycle.events.ApplicationStoppedEvent is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID Not available

com.atlassian.config.lifecycle.events.ApplicationStoppingEvent

Bug Category Details Line
com.atlassian.config.lifecycle.events.ApplicationStoppingEvent is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID Not available

com.atlassian.config.xml.Dom4jXmlMapEntryConfigElement$Entry

Bug Category Details Line
Should com.atlassian.config.xml.Dom4jXmlMapEntryConfigElement$Entry be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC Not available