Checkstyle Results

The following document contains the results of Checkstyle . rss feed

Summary

Files Infos info Warnings warning Errors error
102 0 0 3542

Rules

Rules Violations Severity
PackageHtml 13 error Error
NewlineAtEndOfFile 34 error Error
Translation 0 error Error
JavadocMethod 491 error Error
JavadocType 42 error Error
JavadocVariable 192 error Error
JavadocStyle 59 error Error
ConstantName 12 error Error
LocalFinalVariableName 0 error Error
LocalVariableName 0 error Error
MemberName 0 error Error
MethodName 0 error Error
PackageName 0 error Error
ParameterName 0 error Error
StaticVariableName 2 error Error
TypeName 0 error Error
AvoidStarImport 5 error Error
IllegalImport 0 error Error
RedundantImport 0 error Error
UnusedImports 6 error Error
FileLength 0 error Error
LineLength 722 error Error
MethodLength 1 error Error
ParameterNumber 0 error Error
EmptyForIteratorPad 0 error Error
MethodParamPad 3 error Error
NoWhitespaceAfter 4 error Error
NoWhitespaceBefore 0 error Error
OperatorWrap 11 error Error
ParenPad 1 error Error
TypecastParenPad 0 error Error
TabCharacter 128 error Error
WhitespaceAfter 13 error Error
WhitespaceAround 25 error Error
ModifierOrder 3 error Error
RedundantModifier 37 error Error
AvoidNestedBlocks 0 error Error
EmptyBlock 0 error Error
LeftCurly 762 error Error
NeedBraces 66 error Error
RightCurly 84 error Error
AvoidInlineConditionals 23 error Error
DoubleCheckedLocking 0 error Error
EmptyStatement 0 error Error
EqualsHashCode 0 error Error
HiddenField 88 error Error
IllegalInstantiation 0 error Error
InnerAssignment 2 error Error
MagicNumber 58 error Error
MissingSwitchDefault 3 error Error
RedundantThrows 4 error Error
SimplifyBooleanExpression 0 error Error
SimplifyBooleanReturn 1 error Error
DesignForExtension 146 error Error
FinalClass 2 error Error
HideUtilityClassConstructor 9 error Error
InterfaceIsType 0 error Error
VisibilityModifier 25 error Error
ArrayTypeStyle 1 error Error
FinalParameters 400 error Error
GenericIllegalRegexp
  • message : "Line has trailing spaces."
  • format : "\s+$"
59 error Error
TodoComment 1 error Error
UpperEll 0 error Error

Files

Files I info W warning E error
com/atlassian/seraph/service/PathService.java 0 0 68
com/atlassian/seraph/interceptor/LoginInterceptor.java 0 0 7
com/atlassian/security/auth/trustedapps/IPMatcher.java 0 0 7
com/atlassian/seraph/filter/package.html 0 0 1
com/atlassian/security/auth/trustedapps/BaseEncryptionProvider.java 0 0 11
com/atlassian/seraph/cookie/DefaultCookieHandler.java 0 0 46
com/atlassian/security/auth/trustedapps/TransportException.java 0 0 16
com/atlassian/security/auth/trustedapps/InvalidCertificateException.java 0 0 17
com/atlassian/seraph/SecurityService.java 0 0 7
com/atlassian/security/auth/trustedapps/InvalidIPAddressException.java 0 0 8
com/atlassian/seraph/util/XMLUtils.java 0 0 13
com/atlassian/seraph/auth/Authenticator.java 0 0 27
com/atlassian/security/auth/trustedapps/request/package.html 0 0 1
com/atlassian/security/auth/trustedapps/EncryptedCertificate.java 0 0 14
com/atlassian/security/auth/trustedapps/URLMatcher.java 0 0 5
com/atlassian/security/auth/trustedapps/UserResolver.java 0 0 14
com/atlassian/seraph/interceptor/package.html 0 0 1
com/atlassian/security/auth/trustedapps/EncryptionProvider.java 0 0 33
com/atlassian/seraph/controller/package.html 0 0 1
com/atlassian/seraph/logout/LogoutServlet.java 0 0 37
com/atlassian/security/auth/trustedapps/request/TrustedRequest.java 0 0 3
com/atlassian/seraph/util/RedirectUtils.java 0 0 99
com/atlassian/seraph/auth/AuthenticationContextImpl.java 0 0 13
com/atlassian/seraph/filter/HttpAuthFilter.java 0 0 48
com/atlassian/security/auth/trustedapps/CurrentApplication.java 0 0 22
com/atlassian/seraph/config/SecurityConfig.java 0 0 21
com/atlassian/seraph/RequestParameterConstants.java 0 0 5
com/atlassian/seraph/auth/AbstractAuthenticator.java 0 0 43
com/atlassian/security/auth/trustedapps/DefaultRequestValidator.java 0 0 36
com/atlassian/security/auth/trustedapps/StringUtil.java 0 0 140
com/atlassian/seraph/cookie/package.html 0 0 1
com/atlassian/seraph/service/WebworkService.java 0 0 91
com/atlassian/seraph/cookie/EncryptedCookieEncoder.java 0 0 47
com/atlassian/security/auth/trustedapps/DefaultCurrentApplication.java 0 0 41
com/atlassian/seraph/util/SecurityUtils.java 0 0 10
com/atlassian/seraph/util/GroupCache.java 0 0 14
com/atlassian/seraph/controller/SecurityController.java 0 0 7
com/atlassian/security/auth/trustedapps/SystemException.java 0 0 7
com/atlassian/seraph/auth/package.html 0 0 1
com/atlassian/seraph/config/package.html 0 0 1
com/atlassian/security/auth/trustedapps/CertificateTooOldException.java 0 0 8
com/atlassian/seraph/config/ConfigurationException.java 0 0 8
com/atlassian/security/auth/trustedapps/Null.java 0 0 17
com/atlassian/security/auth/trustedapps/ApplicationRetriever.java 0 0 11
com/atlassian/security/auth/trustedapps/InvalidRequestException.java 0 0 5
com/atlassian/seraph/config/DefaultLoginUrlStrategy.java 0 0 19
com/atlassian/seraph/filter/TrustedApplicationsFilter.java 0 0 261
com/atlassian/seraph/auth/GroupRoleMapper.java 0 0 25
com/atlassian/seraph/package.html 0 0 1
com/atlassian/seraph/interceptor/Interceptor.java 0 0 4
com/atlassian/seraph/config/SecurityConfigFactory.java 0 0 26
com/atlassian/seraph/config/LoginUrlStrategy.java 0 0 8
com/atlassian/security/auth/trustedapps/InvalidRemoteAddressException.java 0 0 6
com/atlassian/seraph/service/package.html 0 0 1
com/atlassian/security/auth/trustedapps/UIDGenerator.java 0 0 40
com/atlassian/seraph/filter/BaseLoginFilter.java 0 0 115
com/atlassian/security/auth/trustedapps/BouncyCastleEncryptionProvider.java 0 0 158
com/atlassian/seraph/cookie/CookieHandler.java 0 0 19
com/atlassian/security/auth/trustedapps/IPAddressFormatException.java 0 0 12
com/atlassian/security/auth/trustedapps/request/commonshttpclient/package.html 0 0 1
com/atlassian/security/auth/trustedapps/InvalidRequestUrlException.java 0 0 6
com/atlassian/security/auth/trustedapps/DefaultURLMatcher.java 0 0 17
com/atlassian/seraph/auth/AuthenticatorException.java 0 0 7
com/atlassian/seraph/auth/DefaultAuthenticator.java 0 0 239
com/atlassian/security/auth/trustedapps/RequestValidator.java 0 0 7
com/atlassian/security/auth/trustedapps/DefaultTrustedApplicationsManager.java 0 0 30
com/atlassian/seraph/util/CachedPathMapper.java 0 0 30
com/atlassian/seraph/Initable.java 0 0 4
com/atlassian/security/auth/trustedapps/TrustedApplication.java 0 0 25
com/atlassian/seraph/util/CookieUtils.java 0 0 99
com/atlassian/security/auth/trustedapps/ApplicationCertificate.java 0 0 10
com/atlassian/seraph/config/SecurityConfigImpl.java 0 0 218
com/atlassian/seraph/interceptor/LogoutInterceptor.java 0 0 3
com/atlassian/seraph/util/package.html 0 0 1
com/atlassian/security/auth/trustedapps/TransportErrorMessage.java 0 0 196
com/atlassian/security/auth/trustedapps/SimpleApplication.java 0 0 32
com/atlassian/security/auth/trustedapps/Application.java 0 0 13
com/atlassian/security/auth/trustedapps/ReaderApplicationRetriever.java 0 0 11
com/atlassian/security/auth/trustedapps/Transcoder.java 0 0 26
com/atlassian/security/auth/trustedapps/InvalidXForwardedForAddressException.java 0 0 6
com/atlassian/seraph/cookie/CookieFactory.java 0 0 19
com/atlassian/security/auth/trustedapps/request/commonshttpclient/CommonsHttpClientTrustedRequest.java 0 0 12
com/atlassian/security/auth/trustedapps/URLApplicationRetriever.java 0 0 16
com/atlassian/seraph/util/PathMapper.java 0 0 143
com/atlassian/seraph/util/EncryptionUtils.java 0 0 132
com/atlassian/security/auth/trustedapps/DefaultApplicationCertificate.java 0 0 46
com/atlassian/seraph/filter/PasswordBasedLoginFilter.java 0 0 48
com/atlassian/security/auth/trustedapps/DefaultEncryptedCertificate.java 0 0 43
com/atlassian/seraph/filter/LoginFilter.java 0 0 23
com/atlassian/security/auth/trustedapps/TrustedApplicationsManager.java 0 0 8
com/atlassian/seraph/auth/AuthenticationContext.java 0 0 9
com/atlassian/seraph/cookie/InsecureCookieEncoder.java 0 0 14
com/atlassian/seraph/filter/SecurityFilter.java 0 0 84
com/atlassian/seraph/logout/package.html 0 0 1
com/atlassian/seraph/cookie/CookieEncoder.java 0 0 11
com/atlassian/security/auth/trustedapps/DefaultTrustedApplication.java 0 0 71
com/atlassian/security/auth/trustedapps/package.html 0 0 1
com/atlassian/security/auth/trustedapps/TrustedApplicationUtils.java 0 0 57
com/atlassian/security/auth/trustedapps/ListApplicationRetriever.java 0 0 19
com/atlassian/seraph/controller/NullSecurityController.java 0 0 8
com/atlassian/security/auth/trustedapps/DefaultIPMatcher.java 0 0 61
com/atlassian/seraph/auth/RoleMapper.java 0 0 7

Details

com/atlassian/seraph/service/PathService.java

Violation Message Line
error Using the '.*' form of import should be avoided - java.util.*. 17
error Line is longer than 80 characters. 23
error Line contains a tab character. 29
error Line contains a tab character. 30
error Line contains a tab character. 31
error Line contains a tab character. 32
error Line contains a tab character. 33
error Line contains a tab character. 34
error Line contains a tab character. 35
error Line contains a tab character. 36
error '{' should be on the previous line. 42
error Missing a Javadoc comment. 43
error Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 43
error Missing a Javadoc comment. 44
error Name 'CONFIG_FILE_PARAM_KEY' must match pattern '^[a-z][a-zA-Z0-9]*$'. 44
error Variable 'CONFIG_FILE_PARAM_KEY' must be private and have accessor methods. 44
error Missing a Javadoc comment. 46
error Variable 'configFileLocation' must be private and have accessor methods. 46
error Line is longer than 80 characters. 49
error Missing a Javadoc comment. 49
error '10' is a magic number. 49
error '10' is a magic number. 49
error Missing a Javadoc comment. 52
error First sentence should end with a period. 55
error Method 'init' is not designed for extension - needs to be abstract, final or empty. 58
error Parameter params should be final. 58
error Expected @param tag for 'params'. 58
error Parameter config should be final. 58
error Expected @param tag for 'config'. 58
error '{' should be on the previous line. 59
error '{' should be on the previous line. 61
error '{' should be on the previous line. 63
error '}' should be on the same line. 68
error '{' should be on the previous line. 70
error First sentence should end with a period. 76
error '{' should be on the previous line. 80
error '{' should be on the previous line. 82
error Line is longer than 80 characters. 83
error Line is longer than 80 characters. 84
error 'if' construct must use '{}'s. 86
error Line is longer than 80 characters. 87
error 'if' construct must use '{}'s. 90
error Line is longer than 80 characters. 94
error '{' should be on the previous line. 102
error Line is longer than 80 characters. 107
error '{' should be on the previous line. 110
error '}' should be on the same line. 116
error '{' should be on the previous line. 118
error Method 'parseRoles' is not designed for extension - needs to be abstract, final or empty. 123
error Missing a Javadoc comment. 123
error Parameter roleNames should be final. 123
error Missing a Javadoc comment. 134
error '{' should be on the previous line. 135
error Method 'getRequiredRoles' is not designed for extension - needs to be abstract, final or empty. 138
error Missing a Javadoc comment. 138
error Parameter request should be final. 138
error '{' should be on the previous line. 139
error Method 'getRequiredRoles' is not designed for extension - needs to be abstract, final or empty. 144
error Missing a Javadoc comment. 144
error Parameter servletPath should be final. 144
error '{' should be on the previous line. 145
error 'if' construct must use '{}'s. 151
error Line is longer than 80 characters. 151
error '+' is not preceded with whitespace. 151
error '+' is not followed by whitespace. 151
error Line is longer than 80 characters. 152
error '{' should be on the previous line. 158
error Line is longer than 80 characters. 159

com/atlassian/seraph/interceptor/LoginInterceptor.java

Violation Message Line
error Line is longer than 80 characters. 8
error Line is longer than 80 characters. 10
error '{' should be on the previous line. 13
error Line is longer than 80 characters. 14
error Missing a Javadoc comment. 14
error Line is longer than 80 characters. 16
error Missing a Javadoc comment. 16

com/atlassian/security/auth/trustedapps/IPMatcher.java

Violation Message Line
error File does not end with a newline. 0
error Line is longer than 80 characters. 4
error '{' should be on the previous line. 8
error Line has trailing spaces. 11
error Expected an @return tag. 14
error Expected @param tag for 'ipAddress'. 14
error Redundant throws: 'IPAddressFormatException' is unchecked exception. 14

com/atlassian/seraph/filter/package.html

Violation Message Line
error Missing package documentation file. 0

com/atlassian/security/auth/trustedapps/BaseEncryptionProvider.java

Violation Message Line
error Line is longer than 80 characters. 3
error First sentence should end with a period. 5
error Line is longer than 80 characters. 6
error '{' should be on the previous line. 9
error Line is longer than 80 characters. 10
error Method 'getApplicationCertificate' is not designed for extension - needs to be abstract, final or empty. 10
error Missing a Javadoc comment. 10
error Parameter baseUrl should be final. 10
error Method 'generateUID' is not designed for extension - needs to be abstract, final or empty. 16
error Missing a Javadoc comment. 16
error '{' should be on the previous line. 17

com/atlassian/seraph/cookie/DefaultCookieHandler.java

Violation Message Line
error Missing a Javadoc comment. 10
error '{' should be on the previous line. 11
error Line is longer than 80 characters. 12
error Missing a Javadoc comment. 12
error Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 12
error Line is longer than 80 characters. 14
error Method 'invalidateCookie' is not designed for extension - needs to be abstract, final or empty. 14
error Missing a Javadoc comment. 14
error Parameter request should be final. 14
error Parameter response should be final. 14
error Parameter cookieName should be final. 14
error Parameter path should be final. 15
error '{' should be on the previous line. 16
error '{' should be on the previous line. 18
error Method 'getCookie' is not designed for extension - needs to be abstract, final or empty. 24
error Missing a Javadoc comment. 24
error Parameter request should be final. 24
error Parameter name should be final. 24
error '{' should be on the previous line. 25
error Array brackets at illegal position. 30
error '{' should be on the previous line. 32
error '{' should be on the previous line. 34
error '{' should be on the previous line. 43
error '{' should be on the previous line. 45
error '{' should be on the previous line. 50
error Line is longer than 80 characters. 56
error Method 'setCookie' is not designed for extension - needs to be abstract, final or empty. 56
error Missing a Javadoc comment. 56
error Parameter request should be final. 56
error Parameter response should be final. 56
error Parameter name should be final. 56
error Parameter value should be final. 56
error Parameter maxAge should be final. 57
error Parameter path should be final. 57
error '{' should be on the previous line. 58
error Line is longer than 80 characters. 59
error '{' should be on the previous line. 61
error Line is longer than 80 characters. 62
error Avoid inline conditionals. 62
error '{' should be on the previous line. 68
error Method 'getCookieValue' is not designed for extension - needs to be abstract, final or empty. 77
error Missing a Javadoc comment. 77
error Parameter request should be final. 77
error Parameter name should be final. 77
error '{' should be on the previous line. 78
error '{' should be on the previous line. 81

com/atlassian/security/auth/trustedapps/TransportException.java

Violation Message Line
error File does not end with a newline. 0
error Missing a Javadoc comment. 3
error '{' should be on the previous line. 4
error Missing a Javadoc comment. 5
error Line has trailing spaces. 6
error Missing a Javadoc comment. 7
error Parameter error should be final. 7
error 'error' hides a field. 7
error '{' should be on the previous line. 8
error Missing a Javadoc comment. 14
error Parameter error should be final. 14
error 'error' hides a field. 14
error Parameter exception should be final. 14
error '{' should be on the previous line. 15
error Missing a Javadoc comment. 21
error '{' should be on the previous line. 22

com/atlassian/security/auth/trustedapps/InvalidCertificateException.java

Violation Message Line
error File does not end with a newline. 0
error Missing a Javadoc comment. 3
error '{' should be on the previous line. 4
error Line is longer than 80 characters. 5
error Missing a Javadoc comment. 5
error Parameter error should be final. 5
error Parameter cause should be final. 5
error Missing a Javadoc comment. 10
error Parameter error should be final. 10
error '{' should be on the previous line. 11
error Missing a Javadoc comment. 15
error Parameter exception should be final. 15
error '{' should be on the previous line. 16
error Method 'getMessage' is not designed for extension - needs to be abstract, final or empty. 20
error Missing a Javadoc comment. 20
error '{' should be on the previous line. 21
error '{' should be on the previous line. 24

com/atlassian/seraph/SecurityService.java

Violation Message Line
error Line is longer than 80 characters. 8
error Line is longer than 80 characters. 10
error '{' should be on the previous line. 14
error Missing a Javadoc comment. 15
error Redundant 'public' modifier. 15
error Missing a Javadoc comment. 17
error Redundant 'public' modifier. 17

com/atlassian/security/auth/trustedapps/InvalidIPAddressException.java

Violation Message Line
error File does not end with a newline. 0
error First sentence should end with a period. 5
error Line is longer than 80 characters. 6
error Missing a Javadoc comment. 10
error Parameter code should be final. 10
error Parameter address should be final. 10
error '{' should be on the previous line. 11
error Line is longer than 80 characters. 12

com/atlassian/seraph/util/XMLUtils.java

Violation Message Line
error Utility classes should not have a public or default constructor. 10
error '{' should be on the previous line. 11
error Line is longer than 80 characters. 13
error Expected an @return tag. 16
error Parameter parent should be final. 16
error Expected @param tag for 'parent'. 16
error Parameter childTagName should be final. 16
error Expected @param tag for 'childTagName'. 16
error '{' should be on the previous line. 17
error '{' should be on the previous line. 19
error Line is longer than 80 characters. 20
error '}' should be on the same line. 23
error '{' should be on the previous line. 25

com/atlassian/seraph/auth/Authenticator.java

Violation Message Line
error Line is longer than 80 characters. 10
error '{' should be on the previous line. 13
error Line is longer than 80 characters. 14
error Missing a Javadoc comment. 14
error Redundant 'public' modifier. 14
error Missing a Javadoc comment. 16
error Redundant 'public' modifier. 16
error Missing a Javadoc comment. 18
error Redundant 'public' modifier. 18
error Missing a Javadoc comment. 20
error Redundant 'public' modifier. 20
error Line is longer than 80 characters. 22
error Missing a Javadoc comment. 22
error Redundant 'public' modifier. 22
error Expected an @return tag. 25
error Redundant 'public' modifier. 25
error Expected @param tag for 'request'. 25
error Expected @param tag for 'role'. 25
error Line is longer than 80 characters. 27
error Missing a Javadoc comment. 27
error Redundant 'public' modifier. 27
error Line is longer than 80 characters. 29
error Missing a Javadoc comment. 29
error Redundant 'public' modifier. 29
error Line is longer than 80 characters. 31
error Missing a Javadoc comment. 31
error Redundant 'public' modifier. 31

com/atlassian/security/auth/trustedapps/request/package.html

Violation Message Line
error Missing package documentation file. 0

com/atlassian/security/auth/trustedapps/EncryptedCertificate.java

Violation Message Line
error File does not end with a newline. 0
error Line is longer than 80 characters. 4
error Line is longer than 80 characters. 5
error Line is longer than 80 characters. 6
error '{' should be on the previous line. 10
error First sentence should end with a period. 11
error Expected an @return tag. 14
error Line is longer than 80 characters. 19
error Expected an @return tag. 21
error First sentence should end with a period. 23
error Expected an @return tag. 28
error Expected an @return tag. 35
error Line is longer than 80 characters. 40
error Expected an @return tag. 42

com/atlassian/security/auth/trustedapps/URLMatcher.java

Violation Message Line
error File does not end with a newline. 0
error '{' should be on the previous line. 7
error First sentence should end with a period. 8
error Expected an @return tag. 11
error Expected @param tag for 'urlPath'. 11

com/atlassian/security/auth/trustedapps/UserResolver.java

Violation Message Line
error First sentence should end with a period. 6
error Line is longer than 80 characters. 7
error '{' should be on the previous line. 10
error Line contains a tab character. 11
error Line is longer than 80 characters. 12
error Line contains a tab character. 12
error Line has trailing spaces. 13
error Line contains a tab character. 13
error Line has trailing spaces. 14
error Line contains a tab character. 14
error Line contains a tab character. 15
error Line contains a tab character. 16
error Line contains a tab character. 17
error Redundant 'public' modifier. 17

com/atlassian/seraph/interceptor/package.html

Violation Message Line
error Missing package documentation file. 0

com/atlassian/security/auth/trustedapps/EncryptionProvider.java

Violation Message Line
error Line is longer than 80 characters. 3
error Line is longer than 80 characters. 13
error Line is longer than 80 characters. 14
error Line is longer than 80 characters. 17
error '{' should be on the previous line. 20
error Line is longer than 80 characters. 22
error Comment matches to-do format 'TODO:'. 23
error Line is longer than 80 characters. 23
error Line has trailing spaces. 24
error Line is longer than 80 characters. 29
error Unused @throws tag for 'RuntimeException'. 31
error Line is longer than 80 characters. 32
error Line is longer than 80 characters. 34
error First sentence should end with a period. 36
error Line has trailing spaces. 38
error Line is longer than 80 characters. 45
error Line is longer than 80 characters. 48
error Line is longer than 80 characters. 49
error Line has trailing spaces. 50
error First sentence should end with a period. 55
error Line has trailing spaces. 57
error Line is longer than 80 characters. 68
error First sentence should end with a period. 70
error Line is longer than 80 characters. 71
error Line has trailing spaces. 72
error Expected an @return tag. 81
error Line is longer than 80 characters. 81
error First sentence should end with a period. 83
error Line has trailing spaces. 85
error Line is longer than 80 characters. 96
error First sentence should end with a period. 98
error Line has trailing spaces. 100
error Line is longer than 80 characters. 111

com/atlassian/seraph/controller/package.html

Violation Message Line
error Missing package documentation file. 0

com/atlassian/seraph/logout/LogoutServlet.java

Violation Message Line
error Unused import - javax.servlet.http.HttpSession. 12
error Line is longer than 80 characters. 18
error Line is longer than 80 characters. 21
error Unclosed HTML tag found: <code>, this servlet 21
error Line is longer than 80 characters. 22
error Line is longer than 80 characters. 23
error '{' should be on the previous line. 28
error Missing a Javadoc comment. 29
error Method 'init' is not designed for extension - needs to be abstract, final or empty. 31
error Missing a Javadoc comment. 31
error '{' should be on the previous line. 32
error Method 'init' is not designed for extension - needs to be abstract, final or empty. 37
error Missing a Javadoc comment. 37
error Parameter servletConfig should be final. 37
error '{' should be on the previous line. 38
error Line is longer than 80 characters. 40
error Line is longer than 80 characters. 43
error Method 'service' is not designed for extension - needs to be abstract, final or empty. 43
error Missing a Javadoc comment. 43
error Parameter request should be final. 43
error Parameter response should be final. 43
error '{' should be on the previous line. 46
error Line is longer than 80 characters. 47
error Line is longer than 80 characters. 48
error '}' should be on the same line. 49
error '{' should be on the previous line. 51
error Line is longer than 80 characters. 52
error '{' should be on the previous line. 54
error '}' should be on the same line. 57
error '{' should be on the previous line. 59
error Line is longer than 80 characters. 60
error Missing a Javadoc comment. 66
error '{' should be on the previous line. 67
error Method 'getSecurityConfig' is not designed for extension - needs to be abstract, final or empty. 71
error Missing a Javadoc comment. 71
error Method 'getAuthenticator' is not designed for extension - needs to be abstract, final or empty. 75
error Missing a Javadoc comment. 75

com/atlassian/security/auth/trustedapps/request/TrustedRequest.java

Violation Message Line
error First sentence should end with a period. 3
error '{' should be on the previous line. 7
error Missing a Javadoc comment. 8

com/atlassian/seraph/util/RedirectUtils.java

Violation Message Line
error Utility classes should not have a public or default constructor. 14
error '{' should be on the previous line. 15
error Line is longer than 80 characters. 17
error Line is longer than 80 characters. 19
error Line is longer than 80 characters. 20
error Line is longer than 80 characters. 23
error Line is longer than 80 characters. 24
error Line is longer than 80 characters. 25
error Line is longer than 80 characters. 27
error Line is longer than 80 characters. 28
error Line is longer than 80 characters. 29
error Line is longer than 80 characters. 31
error Line is longer than 80 characters. 35
error Parameter request should be final. 37
error '{' should be on the previous line. 38
error Line is longer than 80 characters. 45
error Line is longer than 80 characters. 46
error Line is longer than 80 characters. 47
error Line is longer than 80 characters. 48
error Line is longer than 80 characters. 50
error Expected an @return tag. 52
error Parameter request should be final. 52
error Expected @param tag for 'request'. 52
error '{' should be on the previous line. 53
error Line is longer than 80 characters. 60
error Missing a Javadoc comment. 60
error Parameter loginURL should be final. 60
error Parameter request should be final. 60
error '{' should be on the previous line. 65
error '}' should be on the same line. 67
error '{' should be on the previous line. 69
error Missing a Javadoc comment. 74
error Parameter loginURL should be final. 74
error '{' should be on the previous line. 75
error Expected an @return tag. 82
error Line is longer than 80 characters. 82
error Expected @param tag for 'loginURL'. 82
error Expected @param tag for 'request'. 82
error Parameter external should be final. 82
error Expected @param tag for 'external'. 82
error '{' should be on the previous line. 86
error Line is longer than 80 characters. 88
error Line is longer than 80 characters. 89
error Avoid inline conditionals. 89
error ')' is preceded with whitespace. 89
error '+' is not preceded with whitespace. 89
error '}' should be on the same line. 90
error 'else' construct must use '{}'s. 91
error Expected an @return tag. 98
error Line is longer than 80 characters. 98
error Parameter request should be final. 98
error Expected @param tag for 'request'. 98
error Parameter external should be final. 98
error Expected @param tag for 'external'. 98
error Line is longer than 80 characters. 100
error '{' should be on the previous line. 102
error 'if' construct must use '{}'s. 103
error 'else' construct must use '{}'s. 105
error 'if' construct must use '{}'s. 109
error Line is longer than 80 characters. 110
error Avoid inline conditionals. 110
error 'else' construct must use '{}'s. 111
error '+' should be on a new line. 112
error Avoid inline conditionals. 113
error '+' should be on a new line. 113
error Line is longer than 80 characters. 114
error Avoid inline conditionals. 114
error Expected an @return tag. 121
error Parameter request should be final. 121
error Expected @param tag for 'request'. 121
error '{' should be on the previous line. 122
error Line is longer than 80 characters. 127
error '!' is followed by whitespace. 127
error '80' is a magic number. 127
error '443' is a magic number. 127
error First sentence should end with a period. 135
error Line is longer than 80 characters. 136
error Expected an @return tag. 138
error Line is longer than 80 characters. 138
error Parameter request should be final. 138
error Expected @param tag for 'request'. 138
error Parameter basicAuth should be final. 138
error Expected @param tag for 'basicAuth'. 138
error 'if' construct must use '{}'s. 141
error 'if' construct must use '{}'s. 145
error Conditiona